From c1dd41020122cf2d0bf15791bf138bb55671240c Mon Sep 17 00:00:00 2001 From: Rafa de la Torre Date: Mon, 3 Oct 2016 12:21:44 +0200 Subject: [PATCH] Make RedisConnectionConfigBuilder abstract and also use custom ConfigException instead of generic one. --- .../cartodb_services/refactor/storage/redis_config.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/server/lib/python/cartodb_services/cartodb_services/refactor/storage/redis_config.py b/server/lib/python/cartodb_services/cartodb_services/refactor/storage/redis_config.py index 8c156eb..96346eb 100644 --- a/server/lib/python/cartodb_services/cartodb_services/refactor/storage/redis_config.py +++ b/server/lib/python/cartodb_services/cartodb_services/refactor/storage/redis_config.py @@ -1,3 +1,6 @@ +from cartodb_services.refactor.config.exceptions import ConfigException +from abc import ABCMeta, abstractmethod + """ How to use this (just a draft, WIP): @@ -43,12 +46,14 @@ class RedisConnectionConfig(object): return self._sentinel_id -# TODO make it abstract class RedisConnectionConfigBuilder(object): + __metaclass__ = ABCMeta + DEFAULT_USER_DB = 5 DEFAULT_TIMEOUT = 1.5 # seconds + @abstractmethod def __init__(self, server_config_storage, config_key): self._server_config_storage = server_config_storage self._config_key = config_key @@ -56,7 +61,7 @@ class RedisConnectionConfigBuilder(object): def get(self): conf = self._server_config_storage.get(self._config_key) if conf is None: - raise Exception("There is no redis configuration defined") + raise ConfigException("There is no redis configuration defined") host = conf['redis_host'] port = conf['redis_port']