cartodb4/log4js-node
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #203 from idalv/master

Browse Source 
Clusterred appender should consider the categories.
This commit is contained in:
Gareth Jones
2014-06-28 08:17:16 +10:00
parent 101739ebef f8b6cc7c39
commit 06bab894af
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/appenders/clustered.js
+4 -1
View File
@@ -71,7 +71,10 @@ function createAppender(config) {
if (config.actualAppenders) { if (config.actualAppenders) {
var size = config.actualAppenders.length; var size = config.actualAppenders.length;
for(var i = 0; i < size; i++) { for(var i = 0; i < size; i++) {
config.actualAppenders[i](loggingEvent); if (!config.appenders[i].category || config.appenders[i].category === loggingEvent.categoryName) {
// Relying on the index is not a good practice but otherwise the change would have been bigger.
config.actualAppenders[i](loggingEvent);
}
} }
} }
} }
test/clusteredAppender-test.js
+4 -1
View File
@@ -37,7 +37,8 @@ vows.describe('log4js cluster appender').addBatch({
}); });
var masterAppender = appenderModule.appender({ var masterAppender = appenderModule.appender({
actualAppenders: [ fakeActualAppender ] actualAppenders: [fakeActualAppender, fakeActualAppender, fakeActualAppender],
appenders: [{}, {category: "test"}, {category: "wovs"}]
}); });
// Actual test - log message using masterAppender // Actual test - log message using masterAppender
@@ -56,7 +57,9 @@ vows.describe('log4js cluster appender').addBatch({
}, },
"should log using actual appender": function(topic) { "should log using actual appender": function(topic) {
assert.equal(topic.loggingEvents.length, 2)
assert.equal(topic.loggingEvents[0].data[0], 'masterAppender test'); assert.equal(topic.loggingEvents[0].data[0], 'masterAppender test');
assert.equal(topic.loggingEvents[1].data[0], 'masterAppender test');
}, },
}, },