more linting

This commit is contained in:
Gareth Jones
2013-05-26 16:41:31 +10:00
parent b356dec318
commit 8b3c036245
+129 -129
View File
@@ -1,169 +1,169 @@
var vows = require('vows'), "use strict";
assert = require('assert'), var vows = require('vows')
log4js = require('../lib/log4js'), , assert = require('assert')
sandbox = require('sandboxed-module'); , log4js = require('../lib/log4js')
, sandbox = require('sandboxed-module')
;
function setupLogging(category, options) { function setupLogging(category, options) {
var msgs = []; var msgs = [];
var fakeMailer = { var fakeMailer = {
createTransport: function (name, options) { createTransport: function (name, options) {
return { return {
config: options, config: options,
sendMail: function (msg, callback) { sendMail: function (msg, callback) {
msgs.push(msg); msgs.push(msg);
callback(null, true); callback(null, true);
}, },
close: function() {} close: function() {}
}; };
} }
}; };
var smtpModule = sandbox.require('../lib/appenders/smtp', { var smtpModule = sandbox.require('../lib/appenders/smtp', {
requires: { requires: {
'nodemailer': fakeMailer 'nodemailer': fakeMailer
} }
}); });
log4js.addAppender(smtpModule.configure(options), category); log4js.addAppender(smtpModule.configure(options), category);
return { return {
logger: log4js.getLogger(category), logger: log4js.getLogger(category),
mailer: fakeMailer, mailer: fakeMailer,
results: msgs results: msgs
}; };
} }
function checkMessages (result, sender, subject) { function checkMessages (result, sender, subject) {
for (var i = 0; i < result.results.length; ++i) { for (var i = 0; i < result.results.length; ++i) {
assert.equal(result.results[i].from, sender); assert.equal(result.results[i].from, sender);
assert.equal(result.results[i].to, 'recipient@domain.com'); assert.equal(result.results[i].to, 'recipient@domain.com');
assert.equal(result.results[i].subject, subject ? subject : 'Log event #' + (i+1)); assert.equal(result.results[i].subject, subject ? subject : 'Log event #' + (i+1));
assert.ok(new RegExp('.+Log event #' + (i+1) + '\n$').test(result.results[i].text)); assert.ok(new RegExp('.+Log event #' + (i+1) + '\n$').test(result.results[i].text));
} }
} }
log4js.clearAppenders(); log4js.clearAppenders();
vows.describe('log4js smtpAppender').addBatch({ vows.describe('log4js smtpAppender').addBatch({
'minimal config': { 'minimal config': {
topic: function() { topic: function() {
var setup = setupLogging('minimal config', { var setup = setupLogging('minimal config', {
recipients: 'recipient@domain.com', recipients: 'recipient@domain.com',
transport: "SMTP", transport: "SMTP",
SMTP: { SMTP: {
port: 25, port: 25,
auth: { auth: {
user: 'user@domain.com' user: 'user@domain.com'
} }
} }
}); });
setup.logger.info('Log event #1'); setup.logger.info('Log event #1');
return setup; return setup;
}, },
'there should be one message only': function (result) { 'there should be one message only': function (result) {
assert.equal(result.results.length, 1); assert.equal(result.results.length, 1);
}, },
'message should contain proper data': function (result) { 'message should contain proper data': function (result) {
checkMessages(result); checkMessages(result);
} }
},
'fancy config': {
topic: function() {
var setup = setupLogging('fancy config', {
recipients: 'recipient@domain.com',
sender: 'sender@domain.com',
subject: 'This is subject',
transport: "SMTP",
SMTP: {
port: 25,
auth: {
user: 'user@domain.com'
}
}
});
setup.logger.info('Log event #1');
return setup;
}, },
'fancy config': { 'there should be one message only': function (result) {
topic: function() { assert.equal(result.results.length, 1);
var setup = setupLogging('fancy config', {
recipients: 'recipient@domain.com',
sender: 'sender@domain.com',
subject: 'This is subject',
transport: "SMTP",
SMTP: {
port: 25,
auth: {
user: 'user@domain.com'
}
}
});
setup.logger.info('Log event #1');
return setup;
},
'there should be one message only': function (result) {
assert.equal(result.results.length, 1);
},
'message should contain proper data': function (result) {
checkMessages(result, 'sender@domain.com', 'This is subject');
}
}, },
'separate email for each event': { 'message should contain proper data': function (result) {
topic: function() { checkMessages(result, 'sender@domain.com', 'This is subject');
var self = this;
var setup = setupLogging('separate email for each event', {
recipients: 'recipient@domain.com',
transport: "SMTP",
SMTP: {
port: 25,
auth: {
user: 'user@domain.com'
}
}
});
setTimeout(function () {
setup.logger.info('Log event #1');
}, 0);
setTimeout(function () {
setup.logger.info('Log event #2');
}, 500);
setTimeout(function () {
setup.logger.info('Log event #3');
}, 1050);
setTimeout(function () {
self.callback(null, setup);
}, 2100);
},
'there should be three messages': function (result) {
assert.equal(result.results.length, 3);
},
'messages should contain proper data': function (result) {
checkMessages(result);
}
},
'multiple events in one email': {
topic: function() {
var self = this;
var setup = setupLogging('multiple events in one email', {
recipients: 'recipient@domain.com',
sendInterval: 1,
transport: "SMTP",
SMTP: {
port: 25,
auth: {
user: 'user@domain.com'
}
}
});
setTimeout(function () {
setup.logger.info('Log event #1');
}, 0);
setTimeout(function () {
setup.logger.info('Log event #2');
}, 500);
setTimeout(function () {
setup.logger.info('Log event #3');
}, 1050);
setTimeout(function () {
self.callback(null, setup);
}, 2100);
},
'there should be two messages': function (result) {
assert.equal(result.results.length, 2);
},
'messages should contain proper data': function (result) {
assert.equal(result.results[0].to, 'recipient@domain.com');
assert.equal(result.results[0].subject, 'Log event #1');
assert.equal(result.results[0].text.match(new RegExp('.+Log event #[1-2]$', 'gm')).length, 2);
assert.equal(result.results[1].to, 'recipient@domain.com');
assert.equal(result.results[1].subject, 'Log event #3');
assert.ok(new RegExp('.+Log event #3\n$').test(result.results[1].text));
}
} }
},
'separate email for each event': {
topic: function() {
var self = this;
var setup = setupLogging('separate email for each event', {
recipients: 'recipient@domain.com',
transport: "SMTP",
SMTP: {
port: 25,
auth: {
user: 'user@domain.com'
}
}
});
setTimeout(function () {
setup.logger.info('Log event #1');
}, 0);
setTimeout(function () {
setup.logger.info('Log event #2');
}, 500);
setTimeout(function () {
setup.logger.info('Log event #3');
}, 1050);
setTimeout(function () {
self.callback(null, setup);
}, 2100);
},
'there should be three messages': function (result) {
assert.equal(result.results.length, 3);
},
'messages should contain proper data': function (result) {
checkMessages(result);
}
},
'multiple events in one email': {
topic: function() {
var self = this;
var setup = setupLogging('multiple events in one email', {
recipients: 'recipient@domain.com',
sendInterval: 1,
transport: "SMTP",
SMTP: {
port: 25,
auth: {
user: 'user@domain.com'
}
}
});
setTimeout(function () {
setup.logger.info('Log event #1');
}, 0);
setTimeout(function () {
setup.logger.info('Log event #2');
}, 500);
setTimeout(function () {
setup.logger.info('Log event #3');
}, 1050);
setTimeout(function () {
self.callback(null, setup);
}, 2100);
},
'there should be two messages': function (result) {
assert.equal(result.results.length, 2);
},
'messages should contain proper data': function (result) {
assert.equal(result.results[0].to, 'recipient@domain.com');
assert.equal(result.results[0].subject, 'Log event #1');
assert.equal(result.results[0].text.match(new RegExp('.+Log event #[1-2]$', 'gm')).length, 2);
assert.equal(result.results[1].to, 'recipient@domain.com');
assert.equal(result.results[1].subject, 'Log event #3');
assert.ok(new RegExp('.+Log event #3\n$').test(result.results[1].text));
}
}
}).export(module); }).export(module);