cartodb4/log4js-node
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

made calling logger.log safe if level is not provided as first argument (github issue #279)

Browse Source
This commit is contained in:
Gareth Jones
2015-04-17 08:31:12 +10:00
parent 1cdd37c488
commit adeb714243
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
examples/example.js
View File

@@ -35,11 +35,13 @@ logger.setLevel('ERROR');
//console logging methods have been replaced with log4js ones. //console logging methods have been replaced with log4js ones.
//so this will get coloured output on console, and appear in cheese.log //so this will get coloured output on console, and appear in cheese.log
console.error("AAArgh! Something went wrong", { some: "otherObject", useful_for: "debug purposes" }); console.error("AAArgh! Something went wrong", { some: "otherObject", useful_for: "debug purposes" });
console.log("This should appear as info output");
//these will not appear (logging level beneath error) //these will not appear (logging level beneath error)
logger.trace('Entering cheese testing'); logger.trace('Entering cheese testing');
logger.debug('Got cheese.'); logger.debug('Got cheese.');
logger.info('Cheese is Gouda.'); logger.info('Cheese is Gouda.');
logger.log('Something funny about cheese.');
logger.warn('Cheese is quite smelly.'); logger.warn('Cheese is quite smelly.');
//these end up on the console and in cheese.log //these end up on the console and in cheese.log
logger.error('Cheese %s is too ripe!', "gouda"); logger.error('Cheese %s is too ripe!', "gouda");

2
lib/logger.js
View File

@@ -51,7 +51,7 @@ Logger.prototype.removeLevel = function() {
Logger.prototype.log = function() { Logger.prototype.log = function() {
var args = Array.prototype.slice.call(arguments) var args = Array.prototype.slice.call(arguments)
, logLevel = levels.toLevel(args.shift()) , logLevel = levels.toLevel(args.shift(), levels.INFO)
, loggingEvent; , loggingEvent;
if (this.isLevelEnabled(logLevel)) { if (this.isLevelEnabled(logLevel)) {
loggingEvent = new LoggingEvent(this.category, logLevel, args, this); loggingEvent = new LoggingEvent(this.category, logLevel, args, this);