Commit Graph
172 Commits
Author SHA1 Message Date
Gareth Jones a0a5a3aa99 moved connect-logger to log4js-connect 2013-08-22 08:01:57 +10:00
Gareth Jones a0d0373480 convert level string to Level 2013-08-21 08:05:28 +10:00
Gareth Jones eb875b6d98 mocha tests for new log4js 2013-08-21 08:04:26 +10:00
Gareth Jones a8679aced1 simplified levels a bit, converted tests to mocha 2013-08-21 08:02:37 +10:00
Gareth Jones c60d629608 added mocha, simplified logger by removing levels and making immutable 2013-08-08 08:56:09 +10:00
Gareth Jones 9897dcbc93 trying out weak references, don't think they're going to help 2013-08-05 11:19:53 +10:00
Gareth Jones 5bd7ce3ab9 working, except for tests which expect log levels to persist across getLogger calls 2013-08-02 15:12:04 +10:00
Gareth Jones 3b55aefe6f changed logger to not use events. everything is broken 2013-08-02 11:36:05 +10:00
Lex dde2e69948 Getting console appender to work with node-webkit 2013-07-10 05:07:28 -07:00
Gareth Jones 351a912a86 simplified the reload config code a little, moved the tests into their own file, improved coverage 2013-07-09 09:24:11 +10:00
Gareth Jones c5fd75dac3 removed check on undefined configState.filename - should not happen, and is covered by the statSync anyway 2013-07-09 08:01:41 +10:00
Gareth Jones 4dd5989d27 Merge branch 'master' of https://github.com/nomiddlename/log4js-node
Conflicts:
	test/gelfAppender-test.js
2013-07-08 15:24:29 +10:00
Karl Lam baaebef2ed GELF appender - test case covers custom fields, remove unused
console.log
2013-07-05 15:28:10 +08:00
Karl Lam 837d007de3 GELF appender can add customFields to config for every message 2013-07-05 11:23:59 +08:00
Karl Lam be754f0c0e GELF appender can add custom fields 2013-07-05 10:54:31 +08:00
Gareth Jones 0e5da1d361 moved debug fn out to own module, added tests 2013-06-24 08:51:10 +10:00
Gareth Jones f1c0767ca3 improved coverage 2013-06-17 16:01:03 +10:00
Gareth Jones 652888944b improved coverage for date_format 2013-06-17 16:00:42 +10:00
Gareth Jones efc4e36317 improved coverage for layouts 2013-06-14 08:13:16 +10:00
Gareth Jones dd25d30228 rolled back my clever map+join, because it broke the tests 2013-06-06 07:53:22 +10:00
Gareth Jones 11fe5bde5f increased test coverage for smtp appender 2013-06-05 18:30:11 +10:00
Gareth Jones 41ddf5eea7 merged util.format branch (fixes a lint error and simplifies the code) 2013-06-05 08:52:07 +10:00
Gareth Jones 81fa9c3568 removed unnecessary argument to createNoLogCondition 2013-06-05 08:38:39 +10:00
Gareth Jones 7ca517b5ed simplified createNoLogCondition 2013-06-05 08:37:27 +10:00
Gareth Jones 6368de1094 refactored pattern layout 2013-06-05 08:02:10 +10:00
Gareth Jones 94dbd22c71 reduced complex function to smaller ones 2013-06-04 08:37:36 +10:00
Gareth Jones 5d6f00eda4 fixed all lint errors except ones which require refactoring of code 2013-06-04 08:17:36 +10:00
Gareth Jones f998d7e81a more linting 2013-05-30 08:45:15 +10:00
Gareth Jones 46ae1a586d more linting 2013-05-30 08:26:26 +10:00
Gareth Jones 516320c79a more linting 2013-05-30 08:26:03 +10:00
Gareth Jones 40ec9e98e4 more linting 2013-05-30 08:00:04 +10:00
Gareth Jones cc2e94cf11 more linting 2013-05-30 07:58:09 +10:00
Gareth Jones 2de838bc76 more linting 2013-05-30 07:56:28 +10:00
Gareth Jones b356dec318 Getting my lint on (via bob) 2013-05-25 14:00:06 +10:00
Gareth Jones 8492519e3b Fixing issue #137 2013-05-25 13:04:48 +10:00
Gareth Jones ab8c7ed89d Merge pull request #136 from issacg/dontalwaysrename-bug
Dontalwaysrename bug
2013-05-15 23:52:57 -07:00
Issac Goldstand dc632f4705 Fixes bug introduced in github issue #132 where file rolling needs to be handled differently for alwaysIncludePattern streams 2013-05-11 23:01:28 +03:00
Jure Mav ac6284add1 Added automatic level detection to connect-logger, depends on http status response.
Update of connect logger example code, compatible with express 3.x
2013-05-11 16:17:23 +02:00
Issac Goldstand 2da01cc611 Fixes bug introduced in github issue #132 where renaming a file to itself can cause an unhandled error 2013-05-09 13:09:59 +03:00
Issac Goldstand 8c12c948d9 Fixes bug in detecting empty options (see issue #132 on github) 2013-05-08 12:05:32 +03:00
Gareth Jones 936ad4da8e fixed tests broken by alwaysIncludePattern 2013-05-05 13:44:01 +10:00
Gareth Jones 097ae3d7f1 Merge branch 'alwaysIncludePattern' of https://github.com/issacg/log4js-node into isaacg-alwaysIncludePattern 2013-05-04 16:10:02 +10:00
Issac Goldstand 29b02921b6 add option alwaysIncludePattern to dateTime appender to always use the filename with the pattern included when logging 2013-05-02 14:56:33 +03:00
Gareth Jones ed7462885f backporting new streams to node 0.8 for issue #129 2013-04-11 21:45:16 +10:00
Gary Steven e58cf201ca Updated for Node 0.10.x
net.createServer no longer emits 'connect' event
2013-03-30 03:23:58 -07:00
Jim Schubert f3271a3997 Add standard debug conditional function
: master
2013-03-23 18:50:13 -07:00
Gareth Jones 65e490cbd2 Fixes for version v0.10 streams, breaks log4js for older versions of node 2013-03-20 09:14:27 +11:00
Gareth Jones f272e3fd0a Merge branch 'master' into util.format 2013-02-25 16:43:03 +11:00
Mário Freitas 8e53c6213e fix: pass options from multiprocess appender to inner appender 2013-02-21 00:06:59 +09:00
Nicolas Pelletier b75e3660f4 Speed up file logging for high rate of logging.
During an evaluation of multiple loggers, I saw a slow down when trying to
quickly log more than 100,000 messages to a file:
```javascript
    counter = 150000;
    while (counter) {
        logger.info('Message[' + counter + ']');
        counter -= 1;
    }
```

My detailed test can be found here:
 - https://gist.github.com/NicolasPelletier/4773843

The test demonstrate that writing 150,000 lines straight in a FileStream
takes about 22 seconds until the file content stabilizes. When calling
logger.debug() 150,000 times, the file stabilizes to its final content
after 229s ( almost 4 minutes ! ).

After investigation, it turns out that the problem is using an Array() to
accumulate the data. Pushing the data in the Array with Array.push() is
quick, but the code flushing the buffer uses Array.shift(), which forces
re-indexing of all 149,999 elements remaining in the Array. This is
exponentially slower as the buffer grows.

The solution is to use something else than an Array to accumulate the
messages. The fix was made using a package called Dequeue
( https://github.com/lleo/node-dequeue ). By replacing the Array with
a Dequeue object, it brought the logging of 150,000 messages back down to
31s. Seven times faster than the previous 229s.

There is a caveat that each log event is slightly longer due to the need
to create an object to put in the double-ended queue inside the Dequeue
object. According to a quick test, it takes about 4% more time per call
to logger.debug().
2013-02-13 09:35:02 -05:00