Make tests a bit more robusto

This commit is contained in:
Brian M. Carlson
2014-09-15 20:56:34 -04:00
parent 33f6ecc11b
commit d6eab36b66
3 changed files with 6 additions and 6 deletions
+4 -2
View File
@@ -20,9 +20,11 @@ var testBinaryCopy = function() {
var toClient = client() var toClient = client()
queries = [ queries = [
'CREATE TABLE data (num BIGINT, word TEXT)', 'DROP TABLE IF EXISTS data',
'CREATE TABLE IF NOT EXISTS data (num BIGINT, word TEXT)',
'INSERT INTO data (num, word) VALUES (1, \'hello\'), (2, \'other thing\'), (3, \'goodbye\')', 'INSERT INTO data (num, word) VALUES (1, \'hello\'), (2, \'other thing\'), (3, \'goodbye\')',
'CREATE TABLE data_copy (LIKE data INCLUDING ALL)' 'DROP TABLE IF EXISTS data_copy',
'CREATE TABLE IF NOT EXISTS data_copy (LIKE data INCLUDING ALL)'
] ]
async.eachSeries(queries, _.bind(fromClient.query, fromClient), function(err) { async.eachSeries(queries, _.bind(fromClient.query, fromClient), function(err) {
+1 -1
View File
@@ -43,7 +43,7 @@ var testRange = function(top) {
fromClient.query('SELECT COUNT(*) FROM numbers', function(err, res) { fromClient.query('SELECT COUNT(*) FROM numbers', function(err, res) {
assert.ifError(err) assert.ifError(err)
assert.equal(res.rows[0].count, top, 'expected ' + top + ' rows but got ' + res.rows[0].count) assert.equal(res.rows[0].count, top, 'expected ' + top + ' rows but got ' + res.rows[0].count)
console.log('found ', res.rows.length, 'rows') //console.log('found ', res.rows.length, 'rows')
countDone() countDone()
var firstRowDone = gonna('have correct result') var firstRowDone = gonna('have correct result')
assert.equal(stream.rowCount, top, 'should have rowCount ' + top + ' ') assert.equal(stream.rowCount, top, 'should have rowCount ' + top + ' ')
+1 -3
View File
@@ -70,7 +70,7 @@ testLeak(5)
var testInternalPostgresError = function() { var testInternalPostgresError = function() {
var fromClient = client() var fromClient = client()
// This attempts to make an array that's too large, and should fail. // This attempts to make an array that's too large, and should fail.
var txt = "COPY (SELECT array_agg(e) FROM (SELECT generate_series(1, 100000000) AS e) t) TO STDOUT" var txt = "COPY (SELECT asdlfsdf AS e) t) TO STDOUT"
var runStream = function(callback) { var runStream = function(callback) {
var stream = fromClient.query(copy(txt)) var stream = fromClient.query(copy(txt))
@@ -82,8 +82,6 @@ var testInternalPostgresError = function() {
runStream(function(err) { runStream(function(err) {
assert.notEqual(err, null) assert.notEqual(err, null)
expectedMessage = 'invalid memory alloc request size'
assert.notEqual(err.toString().indexOf(expectedMessage), -1, 'Error message should mention memory alloc request size.')
fromClient.end() fromClient.end()
}) })
} }