Apply fixes from StyleCI

This commit is contained in:
Nabeel Shahzad
2018-08-26 18:51:47 +00:00
committed by StyleCI Bot
parent e95b3eb366
commit 3c32f2d89d
38 changed files with 61 additions and 51 deletions

View File

@@ -70,7 +70,7 @@ class DatabaseService extends Service
// see if this table uses a UUID as the PK
// if no ID is specified
if (\in_array($table, $this->uuid_tables, true)) {
/** @noinspection NestedPositiveIfStatementsInspection */
/* @noinspection NestedPositiveIfStatementsInspection */
if (!array_key_exists('id', $row)) {
$row['id'] = Uuid::generate()->string;
}

View File

@@ -11,7 +11,6 @@ use App\Models\Pirep;
use App\Repositories\ExpenseRepository;
use App\Repositories\JournalRepository;
use App\Services\FareService;
use App\Services\PirepService;
use App\Support\Math;
use App\Support\Money;
use Log;
@@ -284,7 +283,7 @@ class PirepFinanceService extends Service
.$expense->name.'", A='.$expense->amount);
// If an airline_id is filled, then see if it matches
/** @noinspection NotOptimalIfConditionsInspection */
/* @noinspection NotOptimalIfConditionsInspection */
if (filled($expense->airline_id) && $expense->airline_id !== $pirep->airline_id) {
Log::info('Finance: Expense has an airline ID and it doesn\'t match, skipping');
continue;

View File

@@ -237,7 +237,7 @@ class FlightService extends Service
throw new BidExists('A bid already exists for this flight');
}
} else {
/** @noinspection NestedPositiveIfStatementsInspection */
/* @noinspection NestedPositiveIfStatementsInspection */
if ($flight->has_bid === true) {
Log::info('Bid exists, flight='.$flight->id.'; no entry in bids table, cleaning up');
}

View File

@@ -53,8 +53,9 @@ class AircraftImporter extends ImportExport
* @param array $row
* @param int $index
*
* @return bool
* @throws \Exception
*
* @return bool
*/
public function import(array $row, $index): bool
{

View File

@@ -19,7 +19,6 @@ use App\Models\Navdata;
use App\Models\Pirep;
use App\Models\PirepFieldValue;
use App\Models\User;
use App\Repositories\PirepRepository;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Log;
@@ -35,8 +34,8 @@ class PirepService extends Service
/**
* PirepService constructor.
*
* @param GeoService $geoSvc
* @param UserService $pilotSvc
* @param GeoService $geoSvc
* @param UserService $pilotSvc
*/
public function __construct(
GeoService $geoSvc,
@@ -196,6 +195,7 @@ class PirepService extends Service
* Submit the PIREP. Figure out its default state
*
* @param Pirep $pirep
*
* @throws \Exception
*/
public function submit(Pirep $pirep)
@@ -302,8 +302,9 @@ class PirepService extends Service
/**
* @param Pirep $pirep
*
* @return Pirep
* @throws \Exception
*
* @return Pirep
*/
public function accept(Pirep $pirep): Pirep
{