FGFS-4.1/phpvms
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check for valid reference object in recurring finance (#1056)

Browse Source
This commit is contained in:
Nabeel S
2021-03-02 16:19:54 -05:00
committed by GitHub
parent 936cd2efd3
commit 922e754c9e
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/Services/Finance/RecurringFinanceService.php
View File

@@ -66,6 +66,10 @@ class RecurringFinanceService extends Service
$obj = $expense->getReferencedObject(); $obj = $expense->getReferencedObject();
} }
if (empty($obj)) {
return [null, null];
}
if ($klass === 'Airport') { if ($klass === 'Airport') {
$memo = "Airport Expense: {$expense->name} ({$expense->ref_model_id})"; $memo = "Airport Expense: {$expense->name} ({$expense->ref_model_id})";
$transaction_group = "Airport: {$expense->ref_model_id}"; $transaction_group = "Airport: {$expense->ref_model_id}";
@@ -128,6 +132,9 @@ class RecurringFinanceService extends Service
} }
[$memo, $ta_group] = $this->getMemoAndGroup($expense); [$memo, $ta_group] = $this->getMemoAndGroup($expense);
if (empty($memo) || empty($ta_group)) {
continue;
}
$this->financeSvc->debitFromJournal( $this->financeSvc->debitFromJournal(
$journal, $journal,