Build new assets

.gitignore

@@ -30,6 +30,8 @@ env.php
 Homestead.json
 LocalValetDriver.php
 docker-compose-profiler.yml
+sync.sh
+.env.*
 
 # Rocketeer PHP task runner and deployment package. https://github.com/rocketeers/rocketeer
 .rocketeer/

.travis.yml

@@ -6,6 +6,7 @@ language: php
 php:
   - '7.4'
   - '7.3'
+  - '7.2'
 
 #env:
 #  - DB=mysql

.travis/phpunit.travis.xml

@@ -21,9 +21,9 @@
             <directory suffix=".php">./app</directory>
         </whitelist>
     </filter>
-    <!--<listeners>
+    <listeners>
         <listener class="NunoMaduro\Collision\Adapters\Phpunit\Listener"/>
-    </listeners>-->
+    </listeners>
     <php>
         <ini name="error_reporting" value="E_ALL"/>
         <ini name="display_errors" value="On"/>

Makefile

@@ -74,9 +74,9 @@ reload-db:
 tests: test
 
 .PHONY: test
-test:
-	@#php artisan database:create --reset
-	@vendor/bin/phpunit --verbose
+test: phpcs
+	#php artisan database:create --reset
+	vendor/bin/phpunit --debug --verbose
 
 .PHONY: phpcs
 phpcs:

README.md

@@ -14,7 +14,7 @@ A full distribution, with all of the composer dependencies, is available at this
 
 ## Requirements
 
-- PHP 7.3+, extensions:
+- PHP 7.1+, extensions:
   - cURL
   - JSON
   - mbstring

app/Console/Commands/CreateDatabase.php

@@ -79,13 +79,6 @@ class CreateDatabase extends Command
      */
     protected function create_sqlite($dbkey)
     {
-        $dbPath = config($dbkey.'database');
-
-        // Skip if running in memory
-        if ($dbPath === ':memory:') {
-            return;
-        }
-
         $exec = 'sqlite3';
         if ($this->os->isWindowsLike()) {
             $exec = 'sqlite3.exe';
@@ -96,11 +89,11 @@ class CreateDatabase extends Command
             $this->runCommand($cmd);
         }
 
-        if (!file_exists($dbPath)) {
+        if (!file_exists(config($dbkey.'database'))) {
             $cmd = [
                 $exec,
-                $dbPath,
-                '".exit"',
+                config($dbkey.'database'),
+                '""',
             ];
 
             $this->runCommand($cmd);

app/Contracts/Command.php

@@ -3,7 +3,6 @@
 namespace App\Contracts;
 
 use Illuminate\Support\Facades\Log;
-use function is_array;
 use Symfony\Component\Process\Process;
 
 /**
@@ -83,9 +82,9 @@ abstract class Command extends \Illuminate\Console\Command
     }
 
     /**
-     * @param array|string $cmd
-     * @param bool         $return
-     * @param mixed        $verbose
+     * @param       $cmd
+     * @param bool  $return
+     * @param mixed $verbose
      *
      * @throws \Symfony\Component\Process\Exception\RuntimeException
      * @throws \Symfony\Component\Process\Exception\LogicException
@@ -94,16 +93,16 @@ abstract class Command extends \Illuminate\Console\Command
      */
     public function runCommand($cmd, $return = false, $verbose = true): string
     {
-        if (is_array($cmd)) {
+        if (\is_array($cmd)) {
             $cmd = implode(' ', $cmd);
         }
 
         if ($verbose) {
-            $this->info('Running '.$cmd);
+            $this->info('Running "'.$cmd.'"');
         }
 
         $val = '';
-        $process = Process::fromShellCommandline($cmd);
+        $process = new Process($cmd);
         $process->run(function ($type, $buffer) use ($return, &$val) {
             if ($return) {
                 $val .= $buffer;

app/Contracts/Event.php

@@ -1,12 +0,0 @@
-<?php
-
-namespace App\Contracts;
-
-use Illuminate\Foundation\Events\Dispatchable;
-use Illuminate\Queue\SerializesModels;
-
-class Event
-{
-    use Dispatchable;
-    use SerializesModels;
-}

app/Contracts/Listener.php

@@ -16,7 +16,7 @@ abstract class Listener
     public function subscribe(Dispatcher $events): void
     {
         foreach (static::$callbacks as $klass => $cb) {
-            $events->listen($klass, static::class.'@'.$cb);
+            $events->listen($klass, get_class($this).'@'.$cb);
         }
     }
 }

app/Contracts/Repository.php

@@ -6,8 +6,7 @@ use Illuminate\Validation\Validator;
 use Prettus\Repository\Eloquent\BaseRepository;
 
 /**
- * @mixin Model
- * @mixin BaseRepository
+ * @mixin \Prettus\Repository\Eloquent\BaseRepository
  */
 abstract class Repository extends BaseRepository
 {

app/Contracts/Resource.php

@@ -2,12 +2,10 @@
 
 namespace App\Contracts;
 
-use Illuminate\Http\Resources\Json\JsonResource;
-
 /**
  * Base class for a resource/response
  */
-class Resource extends JsonResource
+class Resource extends \Illuminate\Http\Resources\Json\Resource
 {
     /**
      * Iterate through the list of $fields and check if they're a "Unit"

app/Database/factories/AircraftFactory.php

@@ -1,30 +1,24 @@
 <?php
 
-use App\Models\Airport;
-use App\Models\Enums\AircraftState;
-use App\Models\Enums\AircraftStatus;
-use App\Models\Subfleet;
-use App\Support\ICAO;
 use Faker\Generator as Faker;
 
 $factory->define(App\Models\Aircraft::class, function (Faker $faker) {
     return [
         'id'          => null,
         'subfleet_id' => function () {
-            return factory(Subfleet::class)->create()->id;
+            return factory(App\Models\Subfleet::class)->create()->id;
         },
         'airport_id' => function () {
-            return factory(Airport::class)->create()->id;
+            return factory(App\Models\Airport::class)->create()->id;
         },
         'iata'         => $faker->unique()->text(5),
         'icao'         => $faker->unique()->text(5),
         'name'         => $faker->text(50),
         'registration' => $faker->unique()->text(10),
-        'hex_code'     => ICAO::createHexCode(),
-        'mtow'         => $faker->randomFloat(2, 0, 50000),
+        'hex_code'     => \App\Support\ICAO::createHexCode(),
         'zfw'          => $faker->randomFloat(2, 0, 50000),
-        'status'       => AircraftStatus::ACTIVE,
-        'state'        => AircraftState::PARKED,
+        'status'       => \App\Models\Enums\AircraftStatus::ACTIVE,
+        'state'        => \App\Models\Enums\AircraftState::PARKED,
         'created_at'   => $faker->dateTimeBetween('-1 week', 'now'),
         'updated_at'   => function (array $pirep) {
             return $pirep['created_at'];

app/Database/factories/AirlineFactory.php

@@ -9,7 +9,7 @@ use Hashids\Hashids;
 $factory->define(App\Models\Airline::class, function (Faker $faker) {
     return [
         'id'   => null,
-        'icao' => function (array $apt) {
+        'icao' => function (array $apt) use ($faker) {
             $hashids = new Hashids(microtime(), 5);
             $mt = str_replace('.', '', microtime(true));
 

app/Database/factories/FlightFactory.php

@@ -8,19 +8,19 @@ $factory->define(App\Models\Flight::class, function (Faker $faker) {
     return [
         'id'         => $faker->unique()->numberBetween(10, 10000000),
         'airline_id' => function () {
-            return factory(\App\Models\Airline::class)->create()->id;
+            return factory(App\Models\Airline::class)->create()->id;
         },
         'flight_number'  => $faker->unique()->numberBetween(10, 1000000),
         'route_code'     => $faker->randomElement(['', $faker->text(5)]),
         'route_leg'      => $faker->randomElement(['', $faker->numberBetween(0, 1000)]),
         'dpt_airport_id' => function () {
-            return factory(\App\Models\Airport::class)->create()->id;
+            return factory(App\Models\Airport::class)->create()->id;
         },
         'arr_airport_id' => function () {
-            return factory(\App\Models\Airport::class)->create()->id;
+            return factory(App\Models\Airport::class)->create()->id;
         },
         'alt_airport_id' => function () {
-            return factory(\App\Models\Airport::class)->create()->id;
+            return factory(App\Models\Airport::class)->create()->id;
         },
         'distance'             => $faker->numberBetween(1, 1000),
         'route'                => null,

app/Database/factories/JournalTransactionsFactory.php

@@ -6,7 +6,7 @@ $factory->define(App\Models\JournalTransactions::class, function (Faker $faker)
     return [
         'transaction_group' => \Ramsey\Uuid\Uuid::uuid4()->toString(),
         'journal_id'        => function () {
-            return factory(\App\Models\Journal::class)->create()->id;
+            return factory(App\Models\Journal::class)->create()->id;
         },
         'credit'    => $faker->numberBetween(100, 10000),
         'debit'     => $faker->numberBetween(100, 10000),

app/Database/factories/NewsFactory.php

@@ -6,7 +6,7 @@ $factory->define(App\Models\News::class, function (Faker $faker) {
     return [
         'id'      => null,
         'user_id' => function () {
-            return factory(\App\Models\User::class)->create()->id;
+            return factory(App\Models\User::class)->create()->id;
         },
         'subject' => $faker->text(),
         'body'    => $faker->sentence,

app/Database/factories/PirepFactory.php

@@ -10,8 +10,8 @@ use Faker\Generator as Faker;
  * Create a new PIREP
  */
 $factory->define(App\Models\Pirep::class, function (Faker $faker) {
-    $airline = factory(\App\Models\Airline::class)->create();
-    $flight = factory(\App\Models\Flight::class)->create([
+    $airline = factory(App\Models\Airline::class)->create();
+    $flight = factory(App\Models\Flight::class)->create([
         'airline_id' => $airline->id,
     ]);
 
@@ -21,10 +21,10 @@ $factory->define(App\Models\Pirep::class, function (Faker $faker) {
             return $airline->id;
         },
         'user_id' => function () {
-            return factory(\App\Models\User::class)->create()->id;
+            return factory(App\Models\User::class)->create()->id;
         },
         'aircraft_id' => function () {
-            return factory(\App\Models\Aircraft::class)->create()->id;
+            return factory(App\Models\Aircraft::class)->create()->id;
         },
         'flight_id' => function () use ($flight) {
             return $flight->id;

app/Database/factories/SubfleetFactory.php

@@ -6,7 +6,7 @@ $factory->define(App\Models\Subfleet::class, function (Faker $faker) {
     return [
         'id'         => null,
         'airline_id' => function () {
-            return factory(\App\Models\Airline::class)->create()->id;
+            return factory(App\Models\Airline::class)->create()->id;
         },
         'name'                       => $faker->unique()->text(50),
         'type'                       => $faker->unique()->text(7),

app/Database/factories/UserFactory.php

@@ -1,9 +1,7 @@
 <?php
 
-use App\Models\Airline;
 use App\Models\Enums\UserState;
 use Faker\Generator as Faker;
-use Illuminate\Support\Facades\Hash;
 
 $factory->define(App\Models\User::class, function (Faker $faker) {
     static $password;
@@ -16,7 +14,7 @@ $factory->define(App\Models\User::class, function (Faker $faker) {
         'password'   => $password ?: $password = Hash::make('secret'),
         'api_key'    => $faker->sha1,
         'airline_id' => function () {
-            return factory(Airline::class)->create()->id;
+            return factory(App\Models\Airline::class)->create()->id;
         },
         'rank_id'        => 1,
         'flights'        => $faker->numberBetween(0, 1000),

app/Database/migrations/2020_03_27_174238_create_pages.php

@@ -1,6 +1,5 @@
 <?php
 
-use App\Models\Enums\PageType;
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
@@ -23,7 +22,7 @@ class CreatePages extends Migration
             $table->string('name');
             $table->string('slug');
             $table->string('icon');
-            $table->unsignedSmallInteger('type')->default(PageType::PAGE);
+            $table->unsignedSmallInteger('type');
             $table->boolean('public');
             $table->boolean('enabled');
             $table->mediumText('body');

app/Database/migrations/2020_06_09_141153_pages_add_link.php

@@ -1,36 +0,0 @@
-<?php
-
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-class PagesAddLink extends Migration
-{
-    /**
-     * Add a `link` column and make the body optional. Also add a "new_window" bool
-     * which determines if we open this link in a new window or not
-     */
-    public function up()
-    {
-        Schema::table('pages', function (Blueprint $table) {
-            $table->string('body')->change()->nullable();
-            $table->string('link')
-                ->default('')
-                ->nullable()
-                ->after('body');
-
-            $table->boolean('new_window')->default(false);
-        });
-    }
-
-    /**
-     * @return void
-     */
-    public function down()
-    {
-        Schema::table('fares', function (Blueprint $table) {
-            $table->dropColumn('link');
-            $table->dropColumn('new_window');
-        });
-    }
-}

app/Database/migrations/2020_07_21_141153_create_user_fields.php

@@ -1,49 +0,0 @@
-<?php
-
-use App\Contracts\Model;
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-class CreateUserFields extends Migration
-{
-    /**
-     * Add two tables for holding user fields and the values
-     */
-    public function up()
-    {
-        /*
-         * Hold a master list of fields
-         */
-        Schema::create('user_fields', function (Blueprint $table) {
-            $table->increments('id');
-            $table->string('name', 200);
-            $table->text('description')->nullable();
-            $table->boolean('show_on_registration')->default(false)->nullable();
-            $table->boolean('required')->default(false)->nullable();
-            $table->boolean('private')->default(false)->nullable();
-            $table->boolean('active')->default(true)->nullable();
-            $table->timestamps();
-        });
-
-        /*
-         * The values for the actual fields
-         */
-        Schema::create('user_field_values', function (Blueprint $table) {
-            $table->bigIncrements('id');
-            $table->unsignedBigInteger('user_field_id');
-            $table->string('user_id', Model::ID_MAX_LENGTH);
-            $table->text('value')->nullable();
-            $table->timestamps();
-
-            $table->index(['user_field_id', 'user_id']);
-        });
-    }
-
-    /**
-     * @return void
-     */
-    public function down()
-    {
-    }
-}

app/Database/migrations/2020_09_03_141152_aircraft_add_mtow.php

@@ -1,33 +0,0 @@
-<?php
-
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-/**
- * Add a `mtow` column for the max takeoff weight
- */
-class AircraftAddMtow extends Migration
-{
-    public function up()
-    {
-        Schema::table('aircraft', function (Blueprint $table) {
-            $table->unsignedDecimal('mtow')
-                ->nullable()
-                ->default(0.0)
-                ->after('hex_code');
-        });
-    }
-
-    /**
-     * Reverse the migrations.
-     *
-     * @return void
-     */
-    public function down()
-    {
-        Schema::table('aircraft', function (Blueprint $table) {
-            $table->dropColumn('mtow');
-        });
-    }
-}

app/Database/seeds/dev/base.yml

@@ -12,11 +12,3 @@ airlines:
     active: 1
     created_at: now
     updated_at: now
-  - id: 2
-    icao: XXX
-    iata: XX
-    name: inactive airline
-    country: us
-    active: 0
-    created_at: now
-    updated_at: now

app/Database/seeds/dev/users.yml

@@ -69,26 +69,3 @@ role_user:
   - user_id: 3
     role_id: 2
     user_type: App\Models\User
-
-user_fields:
-  - id: 1
-    name: 'VATSIM ID'
-    show_on_registration: true
-    required: false
-    private: false
-  - id: 2
-    name: 'Referral'
-    description: 'Who referred you'
-    show_on_registration: true
-    required: false
-    private: true
-
-user_field_values:
-  - id: 1
-    user_field_id: 1
-    user_id: 1
-    value: 'my vatsim id'
-  - id: 2
-    user_field_id: 2
-    user_id: 1
-    value: 'Nobody did'

app/Database/seeds/permissions.yml

@@ -3,9 +3,6 @@
 - name: admin-access
   display_name: Admin Panel
   description: Access the admin panel
-- name: aircraft
-  display_name: Aircraft
-  description: Create/edit aircraft
 - name: airlines
   display_name: Airlines
   description: Create/edit airlines

app/Database/seeds/settings.yml

@@ -26,13 +26,6 @@
   options:
   type: boolean
   description: If an airport isn't added, try to look it up when adding schedules
-- key: general.allow_unadded_airports
-  name: 'Allow unadded airports'
-  group: general
-  value: false
-  options:
-  type: boolean
-  description: If an un-added airport is used, it is looked up and added
 - key: general.check_prerelease_version
   name: 'Pre-release versions in version check'
   group: general

app/Events/AcarsUpdate.php

@@ -1,22 +0,0 @@
-<?php
-
-namespace App\Events;
-
-use App\Contracts\Event;
-use App\Models\Acars;
-use App\Models\Pirep;
-
-class AcarsUpdate extends Event
-{
-    /** @var Pirep */
-    public $pirep;
-
-    /** @var Acars */
-    public $acars;
-
-    public function __construct(Pirep $pirep, Acars $acars)
-    {
-        $this->pirep = $pirep;
-        $this->acars = $acars;
-    }
-}

app/Events/BaseEvent.php

@@ -2,11 +2,13 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
+use Illuminate\Broadcasting\InteractsWithSockets;
+use Illuminate\Foundation\Events\Dispatchable;
+use Illuminate\Queue\SerializesModels;
 
-/**
- * @deprecated Extend App\Contracts\Event directly
- */
-class BaseEvent extends Event
+class BaseEvent
 {
+    use Dispatchable;
+    use InteractsWithSockets;
+    use SerializesModels;
 }

app/Events/CronHourly.php

@@ -2,8 +2,6 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
-
-class CronHourly extends Event
+class CronHourly extends BaseEvent
 {
 }

app/Events/CronMonthly.php

@@ -2,12 +2,10 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
-
 /**
  * This event is dispatched when the monthly cron is run
  * It happens after all of the default nightly tasks
  */
-class CronMonthly extends Event
+class CronMonthly extends BaseEvent
 {
 }

app/Events/CronNightly.php

@@ -2,12 +2,10 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
-
 /**
  * This event is dispatched when the daily cron is run
  * It happens after all of the default nightly tasks
  */
-class CronNightly extends Event
+class CronNightly extends BaseEvent
 {
 }

app/Events/CronWeekly.php

@@ -2,13 +2,11 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
-
 /**
  * This event is dispatched when the weekly cron is run
  * It happens after all of the default nightly tasks
  */
-class CronWeekly extends Event
+class CronWeekly extends BaseEvent
 {
     public function __construct()
     {

app/Events/Expenses.php

@@ -2,7 +2,6 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\Pirep;
 
 /**
@@ -26,7 +25,7 @@ use App\Models\Pirep;
  *
  * The event will have a copy of the PIREP model, if it's applicable
  */
-class Expenses extends Event
+class Expenses extends BaseEvent
 {
     public $pirep;
 

app/Events/NewsAdded.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\News;
 
-class NewsAdded extends Event
+class NewsAdded extends BaseEvent
 {
     public $news;
 

app/Events/PirepAccepted.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\Pirep;
 
-class PirepAccepted extends Event
+class PirepAccepted extends BaseEvent
 {
     public $pirep;
 

app/Events/PirepCancelled.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\Pirep;
 
-class PirepCancelled extends Event
+class PirepCancelled extends BaseEvent
 {
     public $pirep;
 

app/Events/PirepFiled.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\Pirep;
 
-class PirepFiled extends Event
+class PirepFiled extends BaseEvent
 {
     public $pirep;
 

app/Events/PirepPrefiled.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\Pirep;
 
-class PirepPrefiled extends Event
+class PirepPrefiled extends BaseEvent
 {
     public $pirep;
 

app/Events/PirepRejected.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\Pirep;
 
-class PirepRejected extends Event
+class PirepRejected extends BaseEvent
 {
     public $pirep;
 

app/Events/PirepUpdated.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\Pirep;
 
-class PirepUpdated extends Event
+class PirepUpdated extends BaseEvent
 {
     public $pirep;
 

app/Events/TestEvent.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\User;
 
-class TestEvent extends Event
+class TestEvent extends BaseEvent
 {
     public $user;
 

app/Events/UserAccepted.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\User;
 
-class UserAccepted extends Event
+class UserAccepted extends BaseEvent
 {
     public $user;
 

app/Events/UserRegistered.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\User;
 
-class UserRegistered extends Event
+class UserRegistered extends BaseEvent
 {
     public $user;
 

app/Events/UserStateChanged.php

@@ -2,13 +2,12 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\User;
 
 /**
  * Event triggered when a user's state changes
  */
-class UserStateChanged extends Event
+class UserStateChanged extends BaseEvent
 {
     public $old_state;
     public $user;

app/Events/UserStatsChanged.php

@@ -2,10 +2,9 @@
 
 namespace App\Events;
 
-use App\Contracts\Event;
 use App\Models\User;
 
-class UserStatsChanged extends Event
+class UserStatsChanged extends BaseEvent
 {
     public $stat_name;
     public $old_value;

app/Exceptions/AircraftInvalid.php

@@ -1,47 +0,0 @@
-<?php
-
-namespace App\Exceptions;
-
-use App\Models\Aircraft;
-
-class AircraftInvalid extends AbstractHttpException
-{
-    public const MESSAGE = 'The supplied aircraft is invalid';
-
-    private $aircraft;
-
-    public function __construct(Aircraft $aircraft)
-    {
-        $this->aircraft = $aircraft;
-        parent::__construct(
-            400,
-            static::MESSAGE
-        );
-    }
-
-    /**
-     * Return the RFC 7807 error type (without the URL root)
-     */
-    public function getErrorType(): string
-    {
-        return 'aircraft-invalid';
-    }
-
-    /**
-     * Get the detailed error string
-     */
-    public function getErrorDetails(): string
-    {
-        return $this->getMessage();
-    }
-
-    /**
-     * Return an array with the error details, merged with the RFC7807 response
-     */
-    public function getErrorMetadata(): array
-    {
-        return [
-            'aircraft_id' => optional($this->aircraft)->id,
-        ];
-    }
-}

app/Exceptions/Converters/GenericExceptionAbstract.php

@@ -3,13 +3,13 @@
 namespace App\Exceptions\Converters;
 
 use App\Exceptions\AbstractHttpException;
-use Throwable;
+use Exception;
 
 class GenericExceptionAbstract extends AbstractHttpException
 {
     private $exception;
 
-    public function __construct(Throwable $exception)
+    public function __construct(Exception $exception)
     {
         $this->exception = $exception;
         parent::__construct(

app/Exceptions/Handler.php

@@ -5,7 +5,8 @@ namespace App\Exceptions;
 use App\Exceptions\Converters\GenericExceptionAbstract;
 use App\Exceptions\Converters\SymfonyException;
 use App\Exceptions\Converters\ValidationException;
-use App\Http\Middleware\SetActiveTheme;
+use Exception;
+use Illuminate\Auth\Access\AuthorizationException;
 use Illuminate\Auth\AuthenticationException;
 use Illuminate\Contracts\Container\BindingResolutionException;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
@@ -14,9 +15,10 @@ use Illuminate\Http\Request;
 use Illuminate\Session\TokenMismatchException;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Validation\ValidationException as IlluminateValidationException;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\HttpException as SymfonyHttpException;
+use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Throwable;
 use Whoops\Handler\HandlerInterface;
 
 /**
@@ -40,19 +42,19 @@ class Handler extends ExceptionHandler
     /**
      * Render an exception into an HTTP response.
      *
-     * @param Request    $request
-     * @param \Throwable $exception
+     * @param Request   $request
+     * @param Exception $exception
      *
      * @return mixed
      */
-    public function render($request, Throwable $exception)
+    public function render($request, Exception $exception)
     {
         if ($request->is('api/*')) {
             return $this->handleApiError($request, $exception);
         }
 
-        (new SetActiveTheme())->setTheme($request);
-        if ($exception instanceof AbstractHttpException && $exception->getStatusCode() === 403) {
+        if ($exception instanceof AbstractHttpException
+            && $exception->getStatusCode() === 403) {
             return redirect()->guest('login');
         }
 
@@ -63,11 +65,11 @@ class Handler extends ExceptionHandler
      * Handle errors in the API
      *
      * @param            $request
-     * @param \Throwable $exception
+     * @param \Exception $exception
      *
      * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\Response
      */
-    private function handleApiError($request, Throwable $exception)
+    private function handleApiError($request, Exception $exception)
     {
         Log::error('API Error', $exception->getTrace());
 
@@ -116,13 +118,38 @@ class Handler extends ExceptionHandler
     {
         if ($request->expectsJson() || $request->is('api/*')) {
             $error = new Unauthenticated();
-
             return $error->getResponse();
         }
 
         return redirect()->guest('login');
     }
 
+    /**
+     * Render the given HttpException.
+     *
+     * @param AbstractHttpException $e
+     *
+     * @return \Illuminate\Http\Response|Response
+     */
+    protected function renderHttpException(HttpExceptionInterface $e)
+    {
+        $status = $e->getStatusCode();
+        view()->replaceNamespace('errors', [
+            resource_path('views/layouts/'.setting('general.theme', 'default').'/errors'),
+            resource_path('views/errors'),
+            __DIR__.'/views',
+        ]);
+
+        if (view()->exists("errors::{$status}")) {
+            return response()->view("errors::{$status}", [
+                'exception' => $e,
+                'SKIN_NAME' => setting('general.theme', 'default'),
+            ], $status, $e->getHeaders());
+        }
+
+        return $this->convertExceptionToResponse($e);
+    }
+
     /**
      * Ignition error page integration
      */

app/Exceptions/PilotIdNotFound.php

@@ -1,43 +0,0 @@
-<?php
-
-namespace App\Exceptions;
-
-class PilotIdNotFound extends AbstractHttpException
-{
-    private $pilot_id;
-
-    public function __construct($pilot_id)
-    {
-        $this->pilot_id = $pilot_id;
-        parent::__construct(
-            404,
-            'Pilot '.$pilot_id.' not found'
-        );
-    }
-
-    /**
-     * Return the RFC 7807 error type (without the URL root)
-     */
-    public function getErrorType(): string
-    {
-        return 'pilot-id-not-found';
-    }
-
-    /**
-     * Get the detailed error string
-     */
-    public function getErrorDetails(): string
-    {
-        return $this->getMessage();
-    }
-
-    /**
-     * Return an array with the error details, merged with the RFC7807 response
-     */
-    public function getErrorMetadata(): array
-    {
-        return [
-            'pilot_id' => $this->pilot_id,
-        ];
-    }
-}

app/Exceptions/Unauthorized.php

@@ -1,43 +0,0 @@
-<?php
-
-namespace App\Exceptions;
-
-use Exception;
-
-class Unauthorized extends AbstractHttpException
-{
-    private $exception;
-
-    public function __construct(Exception $exception)
-    {
-        $this->exception = $exception;
-        parent::__construct(
-            403,
-            $exception->getMessage()
-        );
-    }
-
-    /**
-     * Return the RFC 7807 error type (without the URL root)
-     */
-    public function getErrorType(): string
-    {
-        return 'unauthorized';
-    }
-
-    /**
-     * Get the detailed error string
-     */
-    public function getErrorDetails(): string
-    {
-        return $this->getMessage();
-    }
-
-    /**
-     * Return an array with the error details, merged with the RFC7807 response
-     */
-    public function getErrorMetadata(): array
-    {
-        return [];
-    }
-}

app/Exceptions/UnknownPageType.php

@@ -1,46 +0,0 @@
-<?php
-
-namespace App\Exceptions;
-
-use App\Models\Page;
-
-class UnknownPageType extends AbstractHttpException
-{
-    private $page;
-
-    public function __construct(Page $page)
-    {
-        $this->page = $page;
-        parent::__construct(
-            400,
-            'Unknown page type "'.$page->type.'"'
-        );
-    }
-
-    /**
-     * Return the RFC 7807 error type (without the URL root)
-     */
-    public function getErrorType(): string
-    {
-        return 'unknown-page-type';
-    }
-
-    /**
-     * Get the detailed error string
-     */
-    public function getErrorDetails(): string
-    {
-        return $this->getMessage();
-    }
-
-    /**
-     * Return an array with the error details, merged with the RFC7807 response
-     */
-    public function getErrorMetadata(): array
-    {
-        return [
-            'id'   => $this->page->id,
-            'type' => $this->page->type,
-        ];
-    }
-}

app/Http/Composers/PageLinksComposer.php

@@ -10,10 +10,7 @@ use Illuminate\View\View;
 
 class PageLinksComposer extends Composer
 {
-    private static $fields = ['id', 'name', 'slug', 'icon', 'type', 'link', 'new_window'];
-
-    /** @var \App\Repositories\PageRepository */
-    private $pageRepo;
+    protected $pageRepo;
 
     /**
      * PageLinksComposer constructor.
@@ -31,16 +28,13 @@ class PageLinksComposer extends Composer
     public function compose(View $view)
     {
         try {
-            $w = [
-                'enabled' => true,
-            ];
-
             // If not logged in, then only get the public pages
+            $w = ['enabled' => true];
             if (!Auth::check()) {
-                $w['public'] = true;
+                $w = ['public' => true];
             }
 
-            $pages = $this->pageRepo->findWhere($w, static::$fields);
+            $pages = $this->pageRepo->findWhere($w, ['id', 'name', 'slug', 'icon']);
         } catch (Exception $e) {
             $pages = [];
         }

app/Http/Controllers/Admin/MaintenanceController.php

@@ -11,7 +11,6 @@ use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Artisan;
 use Illuminate\Support\Facades\Log;
 use Laracasts\Flash\Flash;
-use Nwidart\Modules\Facades\Module;
 
 class MaintenanceController extends Controller
 {
@@ -37,7 +36,7 @@ class MaintenanceController extends Controller
         return view('admin.maintenance.index', [
             'cron_path'           => $this->cronSvc->getCronExecString(),
             'cron_problem_exists' => $this->cronSvc->cronProblemExists(),
-            'new_version'         => $this->kvpRepo->get('new_version_available', false),
+            'new_version'         => true, //$this->kvpRepo->get('new_version_available', false),
             'new_version_tag'     => $this->kvpRepo->get('latest_version_tag'),
         ]);
     }
@@ -111,10 +110,6 @@ class MaintenanceController extends Controller
     {
         $new_version_tag = $this->kvpRepo->get('latest_version_tag');
         Log::info('Attempting to update to '.$new_version_tag);
-
-        $module = Module::find('updater');
-        $module->enable();
-
         return redirect('/update/downloader');
     }
 }

app/Http/Controllers/Admin/UserController.php

@@ -158,12 +158,11 @@ class UserController extends Controller
      */
     public function edit($id)
     {
-        $user = $this->userRepo
-            ->with(['fields', 'rank'])
-            ->findWithoutFail($id);
+        $user = $this->userRepo->findWithoutFail($id);
 
         if (empty($user)) {
             Flash::error('User not found');
+
             return redirect(route('admin.users.index'));
         }
 

app/Http/Controllers/Admin/UserFieldController.php

@@ -1,154 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin;
-
-use App\Contracts\Controller;
-use App\Repositories\UserFieldRepository;
-use Illuminate\Http\Request;
-use Laracasts\Flash\Flash;
-use Prettus\Repository\Criteria\RequestCriteria;
-
-class UserFieldController extends Controller
-{
-    /** @var \App\Repositories\UserFieldRepository */
-    private $userFieldRepo;
-
-    /**
-     * @param UserFieldRepository $userFieldRepo
-     */
-    public function __construct(UserFieldRepository $userFieldRepo)
-    {
-        $this->userFieldRepo = $userFieldRepo;
-    }
-
-    /**
-     * Display a listing of the UserField.
-     *
-     * @param Request $request
-     *
-     * @throws \Prettus\Repository\Exceptions\RepositoryException
-     *
-     * @return mixed
-     */
-    public function index(Request $request)
-    {
-        $this->userFieldRepo->pushCriteria(new RequestCriteria($request));
-        $fields = $this->userFieldRepo->all();
-
-        return view('admin.userfields.index', ['fields' => $fields]);
-    }
-
-    /**
-     * Show the form for creating a new UserField.
-     */
-    public function create()
-    {
-        return view('admin.userfields.create');
-    }
-
-    /**
-     * Store a newly created UserField in storage.
-     *
-     * @param Request $request
-     *
-     * @throws \Prettus\Validator\Exceptions\ValidatorException
-     *
-     * @return mixed
-     */
-    public function store(Request $request)
-    {
-        $this->userFieldRepo->create($request->all());
-
-        Flash::success('Field added successfully.');
-        return redirect(route('admin.userfields.index'));
-    }
-
-    /**
-     * Display the specified UserField.
-     *
-     * @param int $id
-     *
-     * @return mixed
-     */
-    public function show($id)
-    {
-        $field = $this->userFieldRepo->findWithoutFail($id);
-
-        if (empty($field)) {
-            Flash::error('Flight field not found');
-            return redirect(route('admin.userfields.index'));
-        }
-
-        return view('admin.userfields.show', ['field' => $field]);
-    }
-
-    /**
-     * Show the form for editing the specified UserField.
-     *
-     * @param int $id
-     *
-     * @return mixed
-     */
-    public function edit($id)
-    {
-        $field = $this->userFieldRepo->findWithoutFail($id);
-
-        if (empty($field)) {
-            Flash::error('Field not found');
-            return redirect(route('admin.userfields.index'));
-        }
-
-        return view('admin.userfields.edit', ['field' => $field]);
-    }
-
-    /**
-     * Update the specified UserField in storage.
-     *
-     * @param         $id
-     * @param Request $request
-     *
-     * @throws \Prettus\Validator\Exceptions\ValidatorException
-     *
-     * @return mixed
-     */
-    public function update($id, Request $request)
-    {
-        $field = $this->userFieldRepo->findWithoutFail($id);
-
-        if (empty($field)) {
-            Flash::error('UserField not found');
-            return redirect(route('admin.userfields.index'));
-        }
-
-        $this->userFieldRepo->update($request->all(), $id);
-
-        Flash::success('Field updated successfully.');
-        return redirect(route('admin.userfields.index'));
-    }
-
-    /**
-     * Remove the specified UserField from storage.
-     *
-     * @param int $id
-     *
-     * @return mixed
-     */
-    public function destroy($id)
-    {
-        $field = $this->userFieldRepo->findWithoutFail($id);
-        if (empty($field)) {
-            Flash::error('Field not found');
-            return redirect(route('admin.userfields.index'));
-        }
-
-        if ($this->userFieldRepo->isInUse($id)) {
-            Flash::error('This field cannot be deleted, it is in use. Deactivate it instead');
-            return redirect(route('admin.userfields.index'));
-        }
-
-        $this->userFieldRepo->delete($id);
-
-        Flash::success('Field deleted successfully.');
-        return redirect(route('admin.userfields.index'));
-    }
-}

app/Http/Controllers/Api/AcarsController.php

@@ -3,7 +3,6 @@
 namespace App\Http\Controllers\Api;
 
 use App\Contracts\Controller;
-use App\Events\AcarsUpdate;
 use App\Exceptions\PirepCancelled;
 use App\Http\Requests\Acars\EventRequest;
 use App\Http\Requests\Acars\LogRequest;
@@ -199,9 +198,6 @@ class AcarsController extends Controller
 
         $pirep->save();
 
-        // Post a new update for this ACARS position
-        event(new AcarsUpdate($pirep, $pirep->position));
-
         return $this->message($count.' positions added', $count);
     }
 

app/Http/Controllers/Api/FlightController.php

@@ -78,32 +78,29 @@ class FlightController extends Controller
      */
     public function search(Request $request)
     {
-        /** @var \App\Models\User $user */
         $user = Auth::user();
-
         $where = [
             'active'  => true,
             'visible' => true,
         ];
 
         // Allow the option to bypass some of these restrictions for the searches
-        if (!$request->filled('ignore_restrictions') || $request->get('ignore_restrictions') === '0') {
+        if (!$request->filled('ignore_restrictions')
+            || $request->get('ignore_restrictions') === '0'
+        ) {
             if (setting('pilots.restrict_to_company')) {
-                $where['airline_id'] = $user->airline_id;
+                $where['airline_id'] = Auth::user()->airline_id;
             }
 
             if (setting('pilots.only_flights_from_current')) {
-                $where['dpt_airport_id'] = $user->curr_airport_id;
+                $where['dpt_airport_id'] = Auth::user()->curr_airport_id;
             }
         }
 
         try {
             $this->flightRepo->resetCriteria();
             $this->flightRepo->searchCriteria($request);
-            $this->flightRepo->pushCriteria(new WhereCriteria($request, $where, [
-                'airline' => ['active' => true],
-            ]));
-
+            $this->flightRepo->pushCriteria(new WhereCriteria($request, $where));
             $this->flightRepo->pushCriteria(new RequestCriteria($request));
 
             $flights = $this->flightRepo

app/Http/Controllers/Auth/LoginController.php

@@ -3,98 +3,36 @@
 namespace App\Http\Controllers\Auth;
 
 use App\Contracts\Controller;
-use App\Exceptions\PilotIdNotFound;
 use App\Models\Enums\UserState;
-use App\Services\UserService;
 use Illuminate\Foundation\Auth\AuthenticatesUsers;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Log;
 
+/**
+ * Class LoginController
+ */
 class LoginController extends Controller
 {
     use AuthenticatesUsers;
 
     protected $redirectTo = '/dashboard';
 
-    /** @var UserService */
-    private $userSvc;
-
-    /** @var string */
-    private $loginFieldValue;
-
     /**
      * LoginController constructor.
-     *
-     * @param UserService $userSvc
      */
-    public function __construct(UserService $userSvc)
+    public function __construct()
     {
         $this->redirectTo = config('phpvms.login_redirect');
         $this->middleware('guest', ['except' => 'logout']);
-        $this->userSvc = $userSvc;
     }
 
     /**
-     * Get the needed authorization credentials from the request.
-     * Overriding the value from the trait
-     *
-     * @override
-     *
-     * @param \Illuminate\Http\Request $request
-     *
-     * @return array
+     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
      */
-    protected function credentials(Request $request)
+    public function showLoginForm()
     {
-        return [
-            'email'    => $this->loginFieldValue,
-            'password' => $request->input('password'),
-        ];
-    }
-
-    /**
-     * Validate the user login request.
-     *
-     * @override
-     *
-     * @param \Illuminate\Http\Request $request
-     *
-     * @return void
-     */
-    protected function validateLogin(Request $request)
-    {
-        $id_field = $request->input('email');
-        $validations = ['required', 'string'];
-
-        /*
-         * Trying to login by email or not?
-         *
-         * If not, run a validation rule which attempts to split the user by their VA and ID
-         * Then inject that user's email into the request
-         */
-        if (strpos($id_field, '@') !== false) {
-            $validations[] = 'email';
-            $this->loginFieldValue = $request->input('email');
-        } else {
-            $validations[] = function ($attr, $value, $fail) use ($request) {
-                try {
-                    $user = $this->userSvc->findUserByPilotId($value);
-                } catch (PilotIdNotFound $ex) {
-                    Log::warning('Error logging in, pilot_id not found, id='.$value);
-                    $fail('Pilot not found');
-                    return;
-                }
-
-                $request->email = $user->email;
-                $this->loginFieldValue = $user->email;
-            };
-        }
-
-        $request->validate([
-            'email'    => $validations,
-            'password' => 'required|string',
-        ]);
+        return view('auth/login');
     }
 
     /**
@@ -109,7 +47,8 @@ class LoginController extends Controller
         $user->last_ip = $request->ip();
         $user->save();
 
-        if ($user->state !== UserState::ACTIVE && $user->state !== UserState::ON_LEAVE) {
+        // TODO: How to handle ON_LEAVE?
+        if ($user->state !== UserState::ACTIVE) {
             Log::info('Trying to login '.$user->ident.', state '
                 .UserState::label($user->state));
 

app/Http/Controllers/Auth/RegisterController.php

@@ -3,20 +3,19 @@
 namespace App\Http\Controllers\Auth;
 
 use App\Contracts\Controller;
+use App\Http\Requests\CreateUserRequest;
 use App\Models\Enums\UserState;
 use App\Models\User;
-use App\Models\UserField;
-use App\Models\UserFieldValue;
 use App\Repositories\AirlineRepository;
 use App\Repositories\AirportRepository;
 use App\Services\UserService;
 use App\Support\Countries;
 use App\Support\Timezonelist;
+use Illuminate\Contracts\Validation\Validator;
 use Illuminate\Foundation\Auth\RegistersUsers;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Hash;
 use Illuminate\Support\Facades\Log;
-use Illuminate\Support\Facades\Validator;
 
 class RegisterController extends Controller
 {
@@ -62,14 +61,12 @@ class RegisterController extends Controller
     {
         $airports = $this->airportRepo->selectBoxList(false, setting('pilots.home_hubs_only'));
         $airlines = $this->airlineRepo->selectBoxList();
-        $userFields = UserField::where(['show_on_registration' => true])->get();
 
         return view('auth.register', [
-            'airports'   => $airports,
-            'airlines'   => $airlines,
-            'countries'  => Countries::getSelectList(),
-            'timezones'  => Timezonelist::toArray(),
-            'userFields' => $userFields,
+            'airports'  => $airports,
+            'airlines'  => $airlines,
+            'countries' => Countries::getSelectList(),
+            'timezones' => Timezonelist::toArray(),
         ]);
     }
 
@@ -84,24 +81,13 @@ class RegisterController extends Controller
     {
         $rules = [
             'name'            => 'required|max:255',
-            'email'           => 'required|email|max:255|unique:users,email',
+            'email'           => 'required|email|max:255|unique:users, email',
             'airline_id'      => 'required',
             'home_airport_id' => 'required',
             'password'        => 'required|min:5|confirmed',
             'toc_accepted'    => 'accepted',
         ];
 
-        // Dynamically add the required fields
-        $userFields = UserField::where([
-            'show_on_registration' => true,
-            'required'             => true,
-            'active'               => true,
-        ])->get();
-
-        foreach ($userFields as $field) {
-            $rules['field_'.$field->slug] = 'required';
-        }
-
         if (config('captcha.enabled')) {
             $rules['g-recaptcha-response'] = 'required|captcha';
         }
@@ -133,15 +119,6 @@ class RegisterController extends Controller
 
         Log::info('User registered: ', $user->toArray());
 
-        $userFields = UserField::all();
-        foreach ($userFields as $field) {
-            $field_name = 'field_'.$field->slug;
-            UserFieldValue::updateOrCreate([
-                'user_field_id' => $field->id,
-                'user_id'       => $user->id,
-            ], ['value' => $opts[$field_name]]);
-        }
-
         return $user;
     }
 
@@ -154,10 +131,8 @@ class RegisterController extends Controller
      *
      * @return mixed
      */
-    public function register(Request $request)
+    public function register(CreateUserRequest $request)
     {
-        $this->validator($request->all())->validate();
-
         $user = $this->create($request->all());
         if ($user->state === UserState::PENDING) {
             return view('auth.pending');

app/Http/Controllers/Frontend/FlightController.php

@@ -79,26 +79,20 @@ class FlightController extends Controller
             'visible' => true,
         ];
 
-        /** @var \App\Models\User $user */
-        $user = Auth::user();
-
         if (setting('pilots.restrict_to_company')) {
-            $where['airline_id'] = $user->airline_id;
+            $where['airline_id'] = Auth::user()->airline_id;
         }
 
         // default restrictions on the flights shown. Handle search differently
         if (setting('pilots.only_flights_from_current')) {
-            $where['dpt_airport_id'] = $user->curr_airport_id;
+            $where['dpt_airport_id'] = Auth::user()->curr_airport_id;
         }
 
         $this->flightRepo->resetCriteria();
 
         try {
             $this->flightRepo->searchCriteria($request);
-            $this->flightRepo->pushCriteria(new WhereCriteria($request, $where, [
-                'airline' => ['active' => true],
-            ]));
-
+            $this->flightRepo->pushCriteria(new WhereCriteria($request, $where));
             $this->flightRepo->pushCriteria(new RequestCriteria($request));
         } catch (RepositoryException $e) {
             Log::emergency($e);

app/Http/Controllers/Frontend/PageController.php

@@ -4,10 +4,8 @@ namespace App\Http\Controllers\Frontend;
 
 use App\Contracts\Controller;
 use App\Exceptions\PageNotFound;
-use App\Exceptions\Unauthorized;
 use App\Repositories\PageRepository;
 use Exception;
-use Illuminate\Support\Facades\Auth;
 
 class PageController extends Controller
 {
@@ -30,16 +28,11 @@ class PageController extends Controller
      */
     public function show($slug)
     {
-        /** @var \App\Models\Page $page */
         $page = $this->pageRepo->findWhere(['slug' => $slug])->first();
         if (!$page) {
             throw new PageNotFound(new Exception('Page not found'));
         }
 
-        if (!$page->public && !Auth::check()) {
-            throw new Unauthorized(new Exception('You must be logged in to view this page'));
-        }
-
         return view('pages.index', ['page' => $page]);
     }
 }

app/Http/Controllers/Frontend/PirepController.php

@@ -10,7 +10,6 @@ use App\Models\Enums\PirepState;
 use App\Models\Enums\PirepStatus;
 use App\Models\Pirep;
 use App\Models\SimBrief;
-use App\Models\User;
 use App\Repositories\AircraftRepository;
 use App\Repositories\AirlineRepository;
 use App\Repositories\AirportRepository;
@@ -281,11 +280,9 @@ class PirepController extends Controller
      */
     public function store(CreatePirepRequest $request)
     {
-        /** @var User $user */
-        $user = Auth::user();
-
+        // Create the main PIREP
         $pirep = new Pirep($request->post());
-        $pirep->user_id = $user->id;
+        $pirep->user_id = Auth::user()->id;
 
         $attrs = $request->all();
         $attrs['submit'] = strtolower($attrs['submit']);
@@ -293,13 +290,8 @@ class PirepController extends Controller
         if ($attrs['submit'] === 'submit') {
             // Are they allowed at this airport?
             if (setting('pilots.only_flights_from_current')
-                && $user->curr_airport_id !== $pirep->dpt_airport_id) {
-                Log::info(
-                    'Pilot '.$user->id
-                    .' not at departure airport (curr='.$user->curr_airport_id
-                    .', dpt='.$pirep->dpt_airport_id.')'
-                );
-
+                && Auth::user()->curr_airport_id !== $pirep->dpt_airport_id) {
+                Log::info('Pilot '.Auth::user()->id.' not at departure airport, erroring out');
                 return $this->flashError(
                     'You are currently not at the departure airport!',
                     'frontend.pireps.create'
@@ -308,8 +300,8 @@ class PirepController extends Controller
 
             // Can they fly this aircraft?
             if (setting('pireps.restrict_aircraft_to_rank', false)
-                && !$this->userSvc->aircraftAllowed($user, $pirep->aircraft_id)) {
-                Log::info('Pilot '.$user->id.' not allowed to fly aircraft');
+                && !$this->userSvc->aircraftAllowed(Auth::user(), $pirep->aircraft_id)) {
+                Log::info('Pilot '.Auth::user()->id.' not allowed to fly aircraft');
                 return $this->flashError(
                     'You are not allowed to fly this aircraft!',
                     'frontend.pireps.create'
@@ -318,20 +310,9 @@ class PirepController extends Controller
 
             // is the aircraft in the right place?
             /* @noinspection NotOptimalIfConditionsInspection */
-            // Get the aircraft
-            $aircraft = $this->aircraftRepo->findWithoutFail($pirep->aircraft_id);
-            if ($aircraft === null) {
-                Log::error('Aircraft for PIREP not found, id='.$pirep->aircraft_id);
-                return $this->flashError(
-                    'The aircraft for the PIREP hasn\'t been found',
-                    'frontend.pireps.create'
-                );
-            }
-
             if (setting('pireps.only_aircraft_at_dpt_airport')
-                && $aircraft->airport_id !== $pirep->dpt_airport_id
-            ) {
-                Log::info('Aircraft '.$pirep->aircraft_id.' not at departure airport (curr='.$pirep->aircraft->airport_id.', apt='.$pirep->dpt_airport_id.')');
+                && $pirep->aircraft_id !== $pirep->dpt_airport_id) {
+                Log::info('Aircraft '.$pirep->aircraft_id.' not at departure airport '.$pirep->dpt_airport_id.', erroring out');
                 return $this->flashError(
                     'This aircraft is not positioned at the departure airport!',
                     'frontend.pireps.create'

app/Http/Controllers/Frontend/ProfileController.php

@@ -4,8 +4,6 @@ namespace App\Http\Controllers\Frontend;
 
 use App\Contracts\Controller;
 use App\Models\User;
-use App\Models\UserField;
-use App\Models\UserFieldValue;
 use App\Repositories\AirlineRepository;
 use App\Repositories\AirportRepository;
 use App\Repositories\UserRepository;
@@ -65,22 +63,16 @@ class ProfileController extends Controller
      */
     public function index()
     {
-        /** @var User $user */
-        $user = Auth::user();
-
         if (setting('pilots.home_hubs_only')) {
             $airports = $this->airportRepo->findWhere(['hub' => true]);
         } else {
             $airports = $this->airportRepo->all();
         }
 
-        $userFields = $this->userRepo->getUserFields($user);
-
         return view('profile.index', [
-            'acars'      => $this->acarsEnabled(),
-            'user'       => $user,
-            'airports'   => $airports,
-            'userFields' => $userFields,
+            'acars'    => $this->acarsEnabled(),
+            'user'     => Auth::user(),
+            'airports' => $airports,
         ]);
     }
 
@@ -91,22 +83,18 @@ class ProfileController extends Controller
      */
     public function show($id)
     {
-        $user = User::with(['fields', 'fields.field'])
-            ->where('id', $id)
-            ->first();
-
+        $user = User::where('id', $id)->first();
         if (empty($user)) {
             Flash::error('User not found!');
+
             return redirect(route('frontend.dashboard.index'));
         }
 
         $airports = $this->airportRepo->all();
-        $userFields = $this->userRepo->getUserFields($user, true);
 
         return view('profile.index', [
-            'user'       => $user,
-            'userFields' => $userFields,
-            'airports'   => $airports,
+            'user'     => $user,
+            'airports' => $airports,
         ]);
     }
 
@@ -121,27 +109,22 @@ class ProfileController extends Controller
      */
     public function edit(Request $request)
     {
-        /** @var \App\Models\User $user */
-        $user = User::with(['fields', 'fields.field'])
-            ->where('id', Auth::user()->id)
-            ->first();
-
+        $user = User::where('id', Auth::user()->id)->first();
         if (empty($user)) {
             Flash::error('User not found!');
+
             return redirect(route('frontend.dashboard.index'));
         }
 
         $airlines = $this->airlineRepo->selectBoxList();
         $airports = $this->airportRepo->selectBoxList(false, setting('pilots.home_hubs_only'));
-        $userFields = $this->userRepo->getUserFields($user, false);
 
         return view('profile.edit', [
-            'user'       => $user,
-            'airlines'   => $airlines,
-            'airports'   => $airports,
-            'countries'  => Countries::getSelectList(),
-            'timezones'  => Timezonelist::toArray(),
-            'userFields' => $userFields,
+            'user'      => $user,
+            'airlines'  => $airlines,
+            'airports'  => $airports,
+            'countries' => Countries::getSelectList(),
+            'timezones' => Timezonelist::toArray(),
         ]);
     }
 
@@ -157,20 +140,13 @@ class ProfileController extends Controller
         $id = Auth::user()->id;
         $user = $this->userRepo->findWithoutFail($id);
 
-        $rules = [
+        $validator = Validator::make($request->toArray(), [
             'name'       => 'required',
             'email'      => 'required|unique:users,email,'.$id,
             'airline_id' => 'required',
             'password'   => 'confirmed',
             'avatar'     => 'nullable|mimes:jpeg,png,jpg',
-        ];
-
-        $userFields = UserField::where(['show_on_registration' => true, 'required' => true])->get();
-        foreach ($userFields as $field) {
-            $rules['field_'.$field->slug] = 'required';
-        }
-
-        $validator = Validator::make($request->toArray(), $rules);
+        ]);
 
         if ($validator->fails()) {
             Log::info('validator failed for user '.$user->ident);
@@ -191,7 +167,6 @@ class ProfileController extends Controller
         if (isset($req_data['avatar']) !== null) {
             Storage::delete($user->avatar);
         }
-
         if ($request->hasFile('avatar')) {
             $avatar = $request->file('avatar');
             $file_name = $user->ident.'.'.$avatar->getClientOriginalExtension();
@@ -215,16 +190,6 @@ class ProfileController extends Controller
 
         $this->userRepo->update($req_data, $id);
 
-        // Save all of the user fields
-        $userFields = UserField::all();
-        foreach ($userFields as $field) {
-            $field_name = 'field_'.$field->slug;
-            UserFieldValue::updateOrCreate([
-                'user_field_id' => $field->id,
-                'user_id'       => $id,
-            ], ['value' => $request->get($field_name)]);
-        }
-
         Flash::success('Profile updated successfully!');
 
         return redirect(route('frontend.profile.index'));

app/Http/Kernel.php

@@ -45,7 +45,6 @@ class Kernel extends HttpKernel
             ShareErrorsFromSession::class,
             // VerifyCsrfToken::class,
             SubstituteBindings::class,
-            SetActiveTheme::class,
         ],
     ];
 

app/Http/Middleware/SetActiveTheme.php

@@ -13,44 +13,8 @@ use Illuminate\Support\Facades\Log;
  */
 class SetActiveTheme implements Middleware
 {
-    private static $skip = [
-        'admin',
-        'admin/*',
-        'api',
-        'api/*',
-        'importer',
-        'importer/*',
-        'install',
-        'install/*',
-        'update',
-        'update/*',
-    ];
-
-    /**
-     * Handle the request
-     *
-     * @param \Illuminate\Http\Request $request
-     * @param \Closure                 $next
-     *
-     * @return mixed
-     */
     public function handle(Request $request, Closure $next)
     {
-        $this->setTheme($request);
-        return $next($request);
-    }
-
-    /**
-     * Set the theme for the current middleware
-     *
-     * @param \Illuminate\Http\Request $request
-     */
-    public function setTheme(Request $request)
-    {
-        if ($request->is(self::$skip)) {
-            return;
-        }
-
         try {
             $theme = setting('general.theme');
         } catch (\Exception $e) {
@@ -61,5 +25,7 @@ class SetActiveTheme implements Middleware
         if (!empty($theme)) {
             Theme::set($theme);
         }
+
+        return $next($request);
     }
 }

app/Http/Requests/UpdatePageRequest.php

@@ -19,7 +19,7 @@ class UpdatePageRequest extends FormRequest
                 'required',
                 Rule::unique('pages')->ignore($this->id, 'id'),
             ],
-            'body' => 'nullable',
+            'body' => 'required',
         ];
     }
 }

app/Http/Resources/SimBrief.php

@@ -2,7 +2,7 @@
 
 namespace App\Http\Resources;
 
-use App\Contracts\Resource;
+use Illuminate\Http\Resources\Json\Resource;
 
 /**
  * @mixin \App\Models\SimBrief

app/Models/Aircraft.php

@@ -16,8 +16,6 @@ use Carbon\Carbon;
  * @property string   icao
  * @property string   registration
  * @property int      flight_time
- * @property float    mtow
- * @property float    zfw
  * @property string   hex_code
  * @property Airport  airport
  * @property Subfleet subfleet
@@ -41,7 +39,6 @@ class Aircraft extends Model
         'registration',
         'hex_code',
         'flight_time',
-        'mtow',
         'zfw',
         'status',
         'state',
@@ -52,7 +49,6 @@ class Aircraft extends Model
      */
     protected $casts = [
         'subfleet_id' => 'integer',
-        'mtow'        => 'float',
         'zfw'         => 'float',
         'flight_time' => 'float',
         'state'       => 'integer',
@@ -66,8 +62,6 @@ class Aircraft extends Model
         'name'         => 'required',
         'status'       => 'required',
         'registration' => 'required',
-        'mtow'         => 'nullable|numeric',
-        'zfw'          => 'nullable|numeric',
     ];
 
     /**

app/Models/Enums/AnalyticsDimensions.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace App\Models\Enums;
+
+use App\Contracts\Enum;
+
+class AnalyticsDimensions extends Enum
+{
+    public const PHP_VERSION = 1;
+    public const DATABASE_VERSION = 2;
+    public const PHPVMS_VERSION = 3;
+}

app/Models/Enums/AnalyticsMetrics.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace App\Models\Enums;
+
+use App\Contracts\Enum;
+
+/**
+ * Metrics IDs used in Google Analytics
+ */
+class AnalyticsMetrics extends Enum
+{
+    // Track the lookup time for airports from vaCentral
+    public const AIRPORT_LOOKUP_TIME = 1;
+}

app/Models/Enums/PageType.php

@@ -6,11 +6,6 @@ use App\Contracts\Enum;
 
 class PageType extends Enum
 {
-    public const PAGE = 0;
-    public const LINK = 1;
-
-    public static $labels = [
-        self::PAGE => 'Page',
-        self::LINK => 'Link',
-    ];
+    public const HTML = 0;
+    public const MARKDOWN = 1;
 }

app/Models/File.php

@@ -9,14 +9,14 @@ use Illuminate\Support\Facades\Storage;
 use Illuminate\Support\Str;
 
 /**
- * @property string $name
- * @property string $description
- * @property string $disk
- * @property string $path
- * @property bool   $public
- * @property int    $download_count
- * @property string $url
- * @property string $filename
+ * @property string  $name
+ * @property string  $description
+ * @property string  $disk
+ * @property string  $path
+ * @property bool $public
+ * @property int     $download_count
+ * @property string  $url
+ * @property string  $filename
  */
 class File extends Model
 {

app/Models/Journal.php

@@ -14,11 +14,11 @@ use Carbon\Carbon;
  * Holds various journals, depending on the morphed_type and morphed_id columns
  *
  * @property mixed                         id
- * @property Money  $balance
- * @property string $currency
- * @property Carbon $updated_at
- * @property Carbon $post_date
- * @property Carbon $created_at
+ * @property Money                         $balance
+ * @property string                        $currency
+ * @property Carbon                        $updated_at
+ * @property Carbon                        $post_date
+ * @property Carbon                        $created_at
  * @property \App\Models\Enums\JournalType type
  * @property mixed                         morphed_type
  * @property mixed                         morphed_id

app/Models/Ledger.php

@@ -13,11 +13,11 @@ use Carbon\Carbon;
 /**
  * Class Ledger
  *
- * @property Money  $balance
- * @property string $currency
- * @property Carbon $updated_at
- * @property Carbon $post_date
- * @property Carbon $created_at
+ * @property    Money  $balance
+ * @property    string $currency
+ * @property    Carbon $updated_at
+ * @property    Carbon $post_date
+ * @property    Carbon $created_at
  */
 class Ledger extends Model
 {

app/Models/Page.php

@@ -3,8 +3,6 @@
 namespace App\Models;
 
 use App\Contracts\Model;
-use App\Exceptions\UnknownPageType;
-use App\Models\Enums\PageType;
 
 /**
  * @property int    id
@@ -14,9 +12,7 @@ use App\Models\Enums\PageType;
  * @property int    type
  * @property bool   public
  * @property bool   enabled
- * @property bool   new_window
  * @property string body
- * @property string link
  */
 class Page extends Model
 {
@@ -29,39 +25,17 @@ class Page extends Model
         'icon',
         'public',
         'body',
-        'link',
         'enabled',
-        'new_window',
     ];
 
     protected $casts = [
-        'type'       => 'integer',
-        'public'     => 'boolean',
-        'enabled'    => 'boolean',
-        'new_window' => 'boolean',
+        'type'    => 'integer',
+        'public'  => 'boolean',
+        'enabled' => 'boolean',
     ];
 
     public static $rules = [
         'name' => 'required|unique:pages,name',
-        'body' => 'nullable',
-        'type' => 'required',
+        'body' => 'required',
     ];
-
-    /**
-     * Return the full URL to this page; determines if it's internal or external
-     *
-     * @throws \App\Exceptions\UnknownPageType
-     */
-    public function getUrlAttribute(): string
-    {
-        if ($this->type === PageType::PAGE) {
-            return url(route('frontend.pages.show', ['slug' => $this->slug]));
-        }
-
-        if ($this->type === PageType::LINK) {
-            return $this->link;
-        }
-
-        throw new UnknownPageType($this);
-    }
 }

app/Models/Pirep.php

@@ -43,7 +43,7 @@ use Illuminate\Support\Collection;
  * @property User        user
  * @property Flight|null flight
  * @property Collection  fields
- * @property string      status
+ * @property int         status
  * @property bool        state
  * @property string      source
  * @property Carbon      submitted_at

app/Models/SimBrief.php

@@ -6,10 +6,10 @@ use App\Contracts\Model;
 use Illuminate\Support\Collection;
 
 /**
- * @property string      $id                   The Simbrief OFP ID
- * @property int         $user_id              The user that generated this
- * @property string      $flight_id            Optional, if attached to a flight, removed if attached to PIREP
- * @property string      $pirep_id             Optional, if attached to a PIREP, removed if attached to flight
+ * @property string      $id        The Simbrief OFP ID
+ * @property int         $user_id   The user that generated this
+ * @property string      $flight_id Optional, if attached to a flight, removed if attached to PIREP
+ * @property string      $pirep_id  Optional, if attached to a PIREP, removed if attached to flight
  * @property string      $acars_xml
  * @property string      $ofp_xml
  * @property string      $ofp_html

app/Models/Subfleet.php

@@ -33,8 +33,6 @@ class Subfleet extends Model
         'name',
         'turn_time',
         'fuel_type',
-        'cost_block_hour',
-        'cost_delay_minute',
         'ground_handling_multiplier',
         'cargo_capacity',
         'fuel_capacity',

app/Models/User.php

@@ -10,33 +10,32 @@ use Illuminate\Notifications\Notifiable;
 use Laratrust\Traits\LaratrustUserTrait;
 
 /**
- * @property int              id
- * @property int              pilot_id
- * @property int              airline_id
- * @property string           name
- * @property string           name_private Only first name, rest are initials
- * @property string           email
- * @property string           password
- * @property string           api_key
- * @property mixed            timezone
- * @property string           ident
- * @property string           curr_airport_id
- * @property string           home_airport_id
- * @property string           avatar
- * @property Airline          airline
- * @property Flight[]         flights
- * @property int              flight_time
- * @property int              transfer_time
- * @property string           remember_token
- * @property \Carbon\Carbon   created_at
- * @property \Carbon\Carbon   updated_at
- * @property Rank             rank
- * @property Journal          journal
- * @property int              rank_id
- * @property int              state
- * @property bool             opt_in
- * @property string           last_pirep_id
- * @property UserFieldValue[] fields
+ * @property int            id
+ * @property int            pilot_id
+ * @property int            airline_id
+ * @property string         name
+ * @property string         name_private Only first name, rest are initials
+ * @property string         email
+ * @property string         password
+ * @property string         api_key
+ * @property mixed          timezone
+ * @property string         ident
+ * @property string         curr_airport_id
+ * @property string         home_airport_id
+ * @property string         avatar
+ * @property Airline        airline
+ * @property Flight[]       flights
+ * @property int            flight_time
+ * @property int            transfer_time
+ * @property string         remember_token
+ * @property \Carbon\Carbon created_at
+ * @property \Carbon\Carbon updated_at
+ * @property Rank           rank
+ * @property Journal        journal
+ * @property int            rank_id
+ * @property int            state
+ * @property bool           opt_in
+ * @property string         last_pirep_id
  *
  * @mixin \Illuminate\Database\Eloquent\Builder
  * @mixin \Illuminate\Notifications\Notifiable
@@ -213,16 +212,6 @@ class User extends Authenticatable
         return $this->hasMany(UserAward::class, 'user_id');
     }
 
-    /**
-     * The bid rows
-     *
-     * @return \Illuminate\Database\Eloquent\Relations\HasMany
-     */
-    public function bids()
-    {
-        return $this->hasMany(Bid::class, 'user_id');
-    }
-
     public function home_airport()
     {
         return $this->belongsTo(Airport::class, 'home_airport_id');
@@ -238,9 +227,22 @@ class User extends Authenticatable
         return $this->belongsTo(Pirep::class, 'last_pirep_id');
     }
 
-    public function fields()
+    /**
+     * These are the flights they've bid on
+     */
+    // public function flights()
+    // {
+    //     return $this->belongsToMany(Flight::class, 'bids');
+    // }
+
+    /**
+     * The bid rows
+     *
+     * @return \Illuminate\Database\Eloquent\Relations\HasMany
+     */
+    public function bids()
     {
-        return $this->hasMany(UserFieldValue::class, 'user_id');
+        return $this->hasMany(Bid::class, 'user_id');
     }
 
     public function pireps()

app/Models/UserField.php

@@ -1,49 +0,0 @@
-<?php
-
-namespace App\Models;
-
-use App\Contracts\Model;
-
-/**
- * @property string name
- * @property string slug
- * @property string value  Only set if "squashed"
- * @property bool   show_on_registration
- * @property bool   required
- * @property bool   private
- */
-class UserField extends Model
-{
-    public $table = 'user_fields';
-
-    protected $fillable = [
-        'name',
-        'description',
-        'show_on_registration', // Show on the registration form?
-        'required',             // Required to be filled out in registration?
-        'private',              // Whether this is shown on the user's public profile
-        'active',
-    ];
-
-    protected $casts = [
-        'show_on_registration' => 'boolean',
-        'required'             => 'boolean',
-        'private'              => 'boolean',
-        'active'               => 'boolean',
-    ];
-
-    public static $rules = [
-        'name'        => 'required',
-        'description' => 'nullable',
-    ];
-
-    /**
-     * Get the slug so we can use it in forms
-     *
-     * @return string
-     */
-    public function getSlugAttribute(): string
-    {
-        return str_slug($this->name, '_');
-    }
-}

app/Models/UserFieldValue.php

@@ -1,37 +0,0 @@
-<?php
-
-namespace App\Models;
-
-use App\Contracts\Model;
-
-/**
- * @property string    name
- * @property string    value
- * @property UserField field
- * @property User      user
- */
-class UserFieldValue extends Model
-{
-    public $table = 'user_field_values';
-
-    protected $fillable = [
-        'user_field_id',
-        'user_id',
-        'value',
-    ];
-
-    public static $rules = [];
-
-    /**
-     * Foreign Keys
-     */
-    public function field()
-    {
-        return $this->belongsTo(UserField::class, 'user_field_id');
-    }
-
-    public function user()
-    {
-        return $this->belongsTo(User::class, 'user_id');
-    }
-}

app/Notifications/BaseNotification.php

@@ -1,23 +1,23 @@
 <?php
 
-namespace App\Contracts;
+namespace App\Notifications;
 
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Notifications\Notification;
 use Illuminate\Support\Facades\Log;
 
-class Notification extends \Illuminate\Notifications\Notification implements ShouldQueue
+class BaseNotification extends Notification implements ShouldQueue
 {
     use Queueable;
 
     public $channels = [];
-    public $requires_opt_in = false;
 
     public function __construct()
     {
         // Look in the notifications.channels config and see where this particular
         // notification can go. Map it to $channels
-        $klass = static::class;
+        $klass = get_class($this);
         $notif_config = config('notifications.channels', []);
         if (!array_key_exists($klass, $notif_config)) {
             Log::error('Notification type '.$klass.' missing from notifications config, defaulting to mail');

app/Notifications/Channels/MailChannel.php

@@ -34,7 +34,7 @@ trait MailChannel
     public function toMail($notifiable)
     {
         return (new MailMessage())
-            ->from(config('mail.from.address', 'no-reply@phpvms.net'), config('mail.from.name'))
+            ->from(config('mail.from.address', 'no-reply@phpvms.net'))
             ->subject($this->mailSubject)
             ->markdown($this->mailTemplate, $this->mailTemplateArgs);
     }

app/Notifications/EventHandler.php

@@ -16,7 +16,6 @@ use App\Notifications\Messages\UserPending;
 use App\Notifications\Messages\UserRejected;
 use App\Notifications\Notifiables\Broadcast;
 use Exception;
-use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Notification;
 
@@ -28,7 +27,6 @@ class EventHandler extends Listener
     private static $broadcastNotifyable;
 
     public static $callbacks = [
-        NewsAdded::class        => 'onNewsAdded',
         PirepAccepted::class    => 'onPirepAccepted',
         PirepFiled::class       => 'onPirepFile',
         PirepRejected::class    => 'onPirepRejected',
@@ -44,7 +42,7 @@ class EventHandler extends Listener
     /**
      * Send a notification to all of the admins
      *
-     * @param \App\Contracts\Notification $notification
+     * @param \Illuminate\Notifications\Notification $notification
      */
     protected function notifyAdmins($notification)
     {
@@ -58,8 +56,8 @@ class EventHandler extends Listener
     }
 
     /**
-     * @param User                        $user
-     * @param \App\Contracts\Notification $notification
+     * @param User                                   $user
+     * @param \Illuminate\Notifications\Notification $notification
      */
     protected function notifyUser($user, $notification)
     {
@@ -71,25 +69,13 @@ class EventHandler extends Listener
     }
 
     /**
-     * Send a notification to all users. Also can specify if a particular notification
-     * requires an opt-in
+     * Send a notification to all users
      *
-     * @param \App\Contracts\Notification $notification
+     * @param $notification
      */
-    protected function notifyAllUsers(\App\Contracts\Notification $notification)
+    protected function notifyAllUsers($notification)
     {
-        $where = [];
-        if ($notification->requires_opt_in === true) {  // If the opt-in is required
-            $where['opt_in'] = true;
-        }
-
-        /** @var Collection $users */
-        $users = User::where($where)->get();
-        if (empty($users) || $users->count() === 0) {
-            return;
-        }
-
-        Log::info('Sending notification to '.$users->count().' users');
+        $users = User::all()->get();
 
         try {
             Notification::send($users, $notification);
@@ -178,7 +164,7 @@ class EventHandler extends Listener
     }
 
     /**
-     * Notify all users of a news event, but only the users which have opted in
+     * Notify all users of a news event
      *
      * @param \App\Events\NewsAdded $event
      */

app/Notifications/Messages/AdminUserRegistered.php

@@ -2,11 +2,11 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\User;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
-class AdminUserRegistered extends Notification
+class AdminUserRegistered extends BaseNotification
 {
     use MailChannel;
 

app/Notifications/Messages/NewsAdded.php

@@ -2,16 +2,15 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\News;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
-class NewsAdded extends Notification
+class NewsAdded extends BaseNotification
 {
     use MailChannel;
 
     public $channels = ['mail'];
-    public $requires_opt_in = true;
 
     private $news;
 

app/Notifications/Messages/PirepAccepted.php

@@ -2,14 +2,14 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\Pirep;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
 /**
  * Send the PIREP accepted message to a particular user
  */
-class PirepAccepted extends Notification
+class PirepAccepted extends BaseNotification
 {
     use MailChannel;
 

app/Notifications/Messages/PirepRejected.php

@@ -2,11 +2,11 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\Pirep;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
-class PirepRejected extends Notification
+class PirepRejected extends BaseNotification
 {
     use MailChannel;
 

app/Notifications/Messages/PirepSubmitted.php

@@ -2,11 +2,11 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\Pirep;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
-class PirepSubmitted extends Notification
+class PirepSubmitted extends BaseNotification
 {
     use MailChannel;
 

app/Notifications/Messages/UserPending.php

@@ -2,11 +2,11 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\User;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
-class UserPending extends Notification
+class UserPending extends BaseNotification
 {
     use MailChannel;
 

app/Notifications/Messages/UserRegistered.php

@@ -2,11 +2,11 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\User;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
-class UserRegistered extends Notification
+class UserRegistered extends BaseNotification
 {
     use MailChannel;
 

app/Notifications/Messages/UserRejected.php

@@ -2,11 +2,11 @@
 
 namespace App\Notifications\Messages;
 
-use App\Contracts\Notification;
 use App\Models\User;
+use App\Notifications\BaseNotification;
 use App\Notifications\Channels\MailChannel;
 
-class UserRejected extends Notification
+class UserRejected extends BaseNotification
 {
     use MailChannel;
 

app/Providers/BindServiceProviders.php

@@ -32,6 +32,7 @@ class BindServiceProviders extends ServiceProvider
             IVaCentral::class,
             function ($app) {
                 $client = new VaCentral();
+                $client->setVaCentralUrl(config('vacentral.api_url'));
 
                 // Set API if exists
                 if (filled(config('vacentral.api_key'))) {

app/Providers/EventServiceProvider.php

@@ -38,6 +38,7 @@ class EventServiceProvider extends ServiceProvider
 
         UpdateAvailable::class => [],
         UpdateSucceeded::class => [],
+
     ];
 
     protected $subscribe = [

app/Providers/RouteServiceProvider.php

@@ -39,7 +39,7 @@ class RouteServiceProvider extends ServiceProvider
     private function mapWebRoutes()
     {
         Route::group([
-            'middleware' => ['web'],
+            'middleware' => ['web', 'theme'],
             'namespace'  => $this->namespace,
         ], function ($router) {
             Route::group([
@@ -60,6 +60,8 @@ class RouteServiceProvider extends ServiceProvider
                 Route::get('flights/search', 'FlightController@search')->name('flights.search');
                 Route::resource('flights', 'FlightController');
 
+                Route::get('p/{slug}', 'PageController@show')->name('pages.show');
+
                 Route::get('pireps/fares', 'PirepController@fares');
                 Route::post('pireps/{id}/submit', 'PirepController@submit')->name('pireps.submit');
 
@@ -93,18 +95,15 @@ class RouteServiceProvider extends ServiceProvider
                 Route::get('users/{id}', 'ProfileController@show')->name('users.show.public');
                 Route::get('pilots/{id}', 'ProfileController@show')->name('pilots.show.public');
 
-                Route::get('page/{slug}', 'PageController@show')->name('pages.show');
-
-                Route::get('profile/{id}', 'ProfileController@show')->name('profile.show.public');
-
+                Route::get('p/{id}', 'ProfileController@show')->name('profile.show.public');
                 Route::get('users', 'UserController@index')->name('users.index');
                 Route::get('pilots', 'UserController@index')->name('pilots.index');
 
                 Route::get('livemap', 'LiveMapController@index')->name('livemap.index');
             });
 
-            Route::get('/logout', 'Auth\LoginController@logout')->name('auth.logout');
             Auth::routes(['verify' => true]);
+            Route::get('/logout', 'Auth\LoginController@logout')->name('logout');
         });
     }
 
@@ -262,10 +261,10 @@ class RouteServiceProvider extends ServiceProvider
             Route::resource('flightfields', 'FlightFieldController')
                 ->middleware('ability:admin,flights');
 
-            Route::resource('userfields', 'UserFieldController')->middleware('ability:admin,users');
-
             // pirep related routes
-            Route::get('pireps/fares', 'PirepController@fares')->middleware('ability:admin,pireps');
+            Route::get('pireps/fares', 'PirepController@fares')
+                ->middleware('ability:admin,pireps');
+
             Route::get('pireps/pending', 'PirepController@pending')
                 ->middleware('ability:admin,pireps');
 

app/Repositories/AirlineRepository.php

@@ -27,19 +27,14 @@ class AirlineRepository extends Repository implements CacheableInterface
     /**
      * Return the list of airline formatted for a select box
      *
-     * @param bool $add_blank
-     * @param bool $only_active
+     * @param mixed $add_blank
      *
      * @return array
      */
-    public function selectBoxList($add_blank = false, $only_active = true): array
+    public function selectBoxList($add_blank = false): array
     {
         $retval = [];
-        $where = [
-            'active' => $only_active,
-        ];
-
-        $items = $this->findWhere($where);
+        $items = $this->all();
 
         if ($add_blank) {
             $retval[''] = '';

app/Repositories/ExpenseRepository.php

@@ -24,14 +24,13 @@ class ExpenseRepository extends Repository implements CacheableInterface
      * Get all of the expenses for a given type, and also
      * include expenses for a given airline ID
      *
-     * @param        $type
-     * @param int    $airline_id
-     * @param string $ref_model
-     * @param mixed  $ref_model_id
+     * @param      $type
+     * @param null $airline_id
+     * @param null $ref_model
      *
      * @return Collection
      */
-    public function getAllForType($type, $airline_id = null, $ref_model = null, $ref_model_id = null)
+    public function getAllForType($type, $airline_id = null, $ref_model = null)
     {
         $where = [
             'type' => $type,
@@ -48,10 +47,6 @@ class ExpenseRepository extends Repository implements CacheableInterface
             if ($ref_model) {
                 $where['ref_model'] = $ref_model_type;
             }
-
-            if ($ref_model_id) {
-                $where['ref_model_id'] = $ref_model_id;
-            }
         }
 
         $expenses = $this->findWhere($where);

app/Repositories/PirepRepository.php

@@ -7,6 +7,9 @@ use App\Models\Enums\PirepState;
 use App\Models\Pirep;
 use App\Models\User;
 
+/**
+ * Class PirepRepository
+ */
 class PirepRepository extends Repository
 {
     protected $fieldSearchable = [

app/Repositories/UserFieldRepository.php

@@ -1,32 +0,0 @@
-<?php
-
-namespace App\Repositories;
-
-use App\Contracts\Repository;
-use App\Models\UserField;
-use App\Models\UserFieldValue;
-
-class UserFieldRepository extends Repository
-{
-    protected $fieldSearchable = [
-        'name' => 'like',
-    ];
-
-    /**
-     * @return string
-     */
-    public function model(): string
-    {
-        return UserField::class;
-    }
-
-    /**
-     * Return whether or not this field is in use by a value
-     *
-     * @param $id
-     */
-    public function isInUse($id): bool
-    {
-        return UserFieldValue::where(['user_field_id' => $id])->exists();
-    }
-}