fix: package.json & package-lock.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-CKEDITOR4-1922733
- https://snyk.io/vuln/SNYK-JS-CKEDITOR4-1922735

.github/scripts/build.sh

@@ -23,7 +23,6 @@ declare -a remove_files=(
   .eslintrc
   .php_cs
   .php_cs.cache
-  .php-cs-fixer.php
   .phpstorm.meta.php
   .styleci.yml
   .phpunit.result.cache

.github/workflows/build.yml

@@ -2,12 +2,12 @@ name: 'Build'
 on: ['push', 'pull_request', 'workflow_dispatch', 'release']
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-18.04
     if: github.repository == 'nabeelio/phpvms'
     strategy:
       fail-fast: true
       matrix:
-        php-versions: ['7.3', '7.4', '8.0', '8.1']
+        php-versions: ['7.3', '7.4', '8.0']
     name: PHP ${{ matrix.php-versions }}
     env:
       extensions: intl, pcov, mbstring
@@ -78,8 +78,7 @@ jobs:
 
     - name: Run Tests
       run: |
-        export PHP_CS_FIXER_IGNORE_ENV=1
-        vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php -v --dry-run --diff --using-cache=no
+        vendor/bin/php-cs-fixer fix --config=.php_cs -v --dry-run --diff --using-cache=no
         vendor/bin/phpunit --debug --verbose
 
   # This runs after all of the tests, run have run. Creates a cleaned up version of the

.gitignore

@@ -76,4 +76,3 @@ error_log
 /config.php
 /config.bak.php
 /VERSION
-sync.sh

.php-cs-fixer.php

@@ -1,69 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-/*
- * This file is part of PHP CS Fixer.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- *     Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * This source file is subject to the MIT license that is bundled
- * with this source code in the file LICENSE.
- */
-
-$header = <<<'EOF'
-This file is part of PHP CS Fixer.
-(c) Fabien Potencier <fabien@symfony.com>
-    Dariusz Rumiński <dariusz.ruminski@gmail.com>
-This source file is subject to the MIT license that is bundled
-with this source code in the file LICENSE.
-EOF;
-
-$finder = PhpCsFixer\Finder::create()
-    ->ignoreVCSIgnored(true)
-    ->exclude('tests/data')
-    ->exclude('storage')
-    ->exclude('resources')
-    ->in(__DIR__)
-    ->append([
-        __DIR__.'/dev-tools/doc.php',
-        // __DIR__.'/php-cs-fixer', disabled, as we want to be able to run bootstrap file even on lower PHP version, to show nice message
-        __FILE__,
-    ])
-;
-
-$config = new PhpCsFixer\Config();
-$config
-    ->setRiskyAllowed(true)
-    ->setRules([
-        '@PSR2'                             => true,
-        'strict_param'                      => true,
-        'no_php4_constructor'               => true,
-        'no_extra_blank_lines'              => true,
-        'no_superfluous_elseif'             => true,
-        'single_line_comment_style'         => false,
-        'simple_to_complex_string_variable' => true,
-        'array_syntax'                      => [
-            'syntax' => 'short',
-        ],
-        'binary_operator_spaces' => [
-            'operators' => [
-                '=>' => 'align_single_space_minimal'
-            ]
-        ],
-        /*
-        'blank_line_before_statement'       => [
-            'statements' => [
-                'declare',
-                'for',
-                'return',
-                'throw',
-                'try',
-            ],
-        ],
-        */
-    ])
-    ->setFinder($finder);
-
-return $config;

.php_cs

@@ -0,0 +1,37 @@
+<?php
+
+$finder = PhpCsFixer\Finder::create()
+    ->in('app')
+    ->in('config');
+
+return PhpCsFixer\Config::create()
+    ->setHideProgress(true)
+    ->setUsingCache(false)
+    ->setRiskyAllowed(true)
+    ->setRules([
+        '@PSR2'                             => true,
+        'strict_param'                      => true,
+        'no_php4_constructor'               => true,
+        'no_extra_blank_lines'              => true,
+        'no_superfluous_elseif'             => true,
+        'single_line_comment_style'         => false,
+        'simple_to_complex_string_variable' => true,
+        'array_syntax'                      => [
+            'syntax' => 'short',
+        ],
+        'binary_operator_spaces'            => [
+            'align_double_arrow' => true,
+        ],
+        /*
+        'blank_line_before_statement'       => [
+            'statements' => [
+                'declare',
+                'for',
+                'return',
+                'throw',
+                'try',
+            ],
+        ],
+        */
+    ])
+    ->setFinder($finder);

.shift

@@ -1,4 +0,0 @@
-This file was added by Shift #54503 in order to open a
-Pull Request since no other commits were made.
-
-You should remove this file.

app/Contracts/ImportExport.php

@@ -166,27 +166,6 @@ class ImportExport
                 return [];
             }
 
-            if (strpos($split_values[0], '?') !== false) {
-                // This contains the query string, which turns it into a multi-level array
-                $query_str = explode('?', $split_values[0]);
-                $parent = trim($query_str[0]);
-
-                $children = [];
-                $kvp = explode('&', trim($query_str[1]));
-                foreach ($kvp as $items) {
-                    if (!$items) {
-                        continue;
-                    }
-
-                    $this->kvpToArray($items, $children);
-                }
-
-                $ret[$parent] = $children;
-
-                return $ret;
-            }
-
-            // This is not a query string, return it back untouched
             return [$split_values[0]];
         }
 

app/Database/migrations/2021_11_23_184532_add_type_rating_tables.php

@@ -1,53 +0,0 @@
-<?php
-
-use App\Contracts\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-class AddTypeRatingTables extends Migration
-{
-    public function up()
-    {
-        if (!Schema::hasTable('typeratings')) {
-            Schema::create('typeratings', function (Blueprint $table) {
-                $table->increments('id');
-                $table->string('name');
-                $table->string('type');
-                $table->string('description')->nullable();
-                $table->string('image_url')->nullable();
-                $table->boolean('active')->default(true);
-                $table->timestamps();
-
-                $table->unique('id');
-                $table->unique('name');
-            });
-        }
-
-        if (!Schema::hasTable('typerating_user')) {
-            Schema::create('typerating_user', function (Blueprint $table) {
-                $table->unsignedInteger('typerating_id');
-                $table->unsignedInteger('user_id');
-
-                $table->primary(['typerating_id', 'user_id']);
-                $table->index(['typerating_id', 'user_id']);
-            });
-        }
-
-        if (!Schema::hasTable('typerating_subfleet')) {
-            Schema::create('typerating_subfleet', function (Blueprint $table) {
-                $table->unsignedInteger('typerating_id');
-                $table->unsignedInteger('subfleet_id');
-
-                $table->primary(['typerating_id', 'subfleet_id']);
-                $table->index(['typerating_id', 'subfleet_id']);
-            });
-        }
-    }
-
-    public function down()
-    {
-        Schema::dropIfExists('typeratings');
-        Schema::dropIfExists('typerating_user');
-        Schema::dropIfExists('typerating_subfleet');
-    }
-}

app/Database/migrations/2021_11_27_132418_add_hub_to_aircraft.php

@@ -1,15 +0,0 @@
-<?php
-
-use App\Contracts\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-class AddHubToAircraft extends Migration
-{
-    public function up()
-    {
-        Schema::table('aircraft', function (Blueprint $table) {
-            $table->string('hub_id', 5)->nullable()->after('airport_id');
-        });
-    }
-}

app/Database/migrations/2022_01_10_131604_update_awards_add_active.php

@@ -1,15 +0,0 @@
-<?php
-
-use App\Contracts\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-class UpdateAwardsAddActive extends Migration
-{
-    public function up()
-    {
-        Schema::table('awards', function (Blueprint $table) {
-            $table->boolean('active')->default(true)->nullable()->after('ref_model_params');
-        });
-    }
-}

app/Database/seeds/dev/in_progress.yml

@@ -36,8 +36,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb1
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -55,8 +54,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb2
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -74,8 +72,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb3
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -93,8 +90,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb34
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -112,8 +108,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb35
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -131,8 +126,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb36
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -150,8 +144,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb37
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -169,8 +162,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb38
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -188,8 +180,7 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - id: 9aAN4mxlK9zb39
-    pirep_id: b68R5gwVzpVe
+  - pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'

app/Database/seeds/dev/sample.yml

@@ -34,17 +34,6 @@ airports:
     lon: -97.6698889
     hub: 1
     ground_handling_cost: 100
-  - id: KPHN
-    iata: HPN
-    icao: KPHN
-    name: Westchester County Airport
-    location: White Plains
-    country: United States
-    timezone: America/New_York
-    lat: 41.067
-    lon: -73.7076
-    hub: 1
-    ground_handling_cost: 100
   - id: KJFK
     iata: JFK
     icao: KJFK
@@ -459,21 +448,6 @@ flights:
   - id: flightid_1
     airline_id: 1
     flight_number: 100
-    dpt_airport_id: KHPN
-    arr_airport_id: KJFK
-    route: DCT CMK V374 DENNA V44 BELTT/N0346F140 V44 DPK DCT
-    distance: 113
-    level: 110
-    dpt_time: 6PM CST
-    arr_time: 11PM EST
-    flight_time: 240
-    flight_type: J
-    load_factor: 100
-    created_at: NOW
-    updated_at: NOW
-  - id: flightid_2
-    airline_id: 1
-    flight_number: 101
     dpt_airport_id: KAUS
     arr_airport_id: KJFK
     route: KAUS SID TNV J87 IAH J2 LCH J22 MEI J239 ATL J52 AJFEB J14 BYJAC Q60 JAXSN J14 COLIN J61 HUBBS J55 SIE STAR KJFK

app/Database/seeds/permissions.yml

@@ -42,9 +42,6 @@
 - name: ranks
   display_name: Ranks
   description: Create/edit ranks
-- name: typeratings
-  display_name: Type Ratings
-  description: Create/edit type ratings
 - name: users
   display_name: Users
   description: Create/edit users

app/Database/seeds/settings.yml

@@ -137,13 +137,6 @@
   options: ''
   type: int
   description: 'Initial zoom level on the map'
-- key: acars.update_interval
-  name: 'Refresh Interval'
-  group: acars
-  value: 60
-  options: ''
-  type: int
-  description: 'How often the live map updates its data'
 - key: airports.default_ground_handling_cost
   name: 'Default Ground Handling Cost'
   group: airports
@@ -290,14 +283,7 @@
   value: true
   options: ''
   type: boolean
-  description: 'Aircraft restricted to user''s rank'
-- key: pireps.restrict_aircraft_to_typerating
-  name: 'Restrict Aircraft by Type Ratings'
-  group: pireps
-  value: false
-  options: ''
-  type: boolean
-  description: 'Aircraft restricted to user type ratings'
+  description: 'Aircraft that can be flown are restricted to a user''s rank'
 - key: pireps.only_aircraft_at_dpt_airport
   name: 'Restrict Aircraft At Departure'
   group: pireps

app/Http/Controllers/Admin/AircraftController.php

@@ -79,7 +79,6 @@ class AircraftController extends Controller
     {
         return view('admin.aircraft.create', [
             'airports'    => $this->airportRepo->selectBoxList(),
-            'hubs'        => $this->airportRepo->selectBoxList(true, true),
             'subfleets'   => Subfleet::all()->pluck('name', 'id'),
             'statuses'    => AircraftStatus::select(false),
             'subfleet_id' => $request->query('subfleet'),
@@ -144,7 +143,6 @@ class AircraftController extends Controller
         return view('admin.aircraft.edit', [
             'aircraft'  => $aircraft,
             'airports'  => $this->airportRepo->selectBoxList(),
-            'hubs'      => $this->airportRepo->selectBoxList(true, true),
             'subfleets' => Subfleet::all()->pluck('name', 'id'),
             'statuses'  => AircraftStatus::select(false),
         ]);

app/Http/Controllers/Admin/FlightController.php

@@ -300,18 +300,14 @@ class FlightController extends Controller
     public function export(Request $request)
     {
         $exporter = app(ExportService::class);
-
-        $where = [];
-        $file_name = 'flights.csv';
-        if ($request->input('airline_id')) {
-            $airline_id = $request->input('airline_id');
-            $where['airline_id'] = $airline_id;
-            $file_name = 'flights-'.$airline_id.'.csv';
-        }
-        $flights = $this->flightRepo->where($where)->get();
+        $flights = $this->flightRepo->all();
 
         $path = $exporter->exportFlights($flights);
-        return response()->download($path, $file_name, ['content-type' => 'text/csv'])->deleteFileAfterSend(true);
+        return response()
+            ->download($path, 'flights.csv', [
+                'content-type' => 'text/csv',
+            ])
+            ->deleteFileAfterSend(true);
     }
 
     /**

app/Http/Controllers/Admin/SubfleetController.php

@@ -17,7 +17,6 @@ use App\Repositories\AircraftRepository;
 use App\Repositories\FareRepository;
 use App\Repositories\RankRepository;
 use App\Repositories\SubfleetRepository;
-use App\Repositories\TypeRatingRepository;
 use App\Services\ExportService;
 use App\Services\FareService;
 use App\Services\FleetService;
@@ -37,29 +36,26 @@ class SubfleetController extends Controller
     private $importSvc;
     private $rankRepo;
     private $subfleetRepo;
-    private $typeratingRepo;
 
     /**
      * SubfleetController constructor.
      *
-     * @param AircraftRepository   $aircraftRepo
-     * @param FareRepository       $fareRepo
-     * @param FareService          $fareSvc
-     * @param FleetService         $fleetSvc
-     * @param ImportService        $importSvc
-     * @param RankRepository       $rankRepo
-     * @param SubfleetRepository   $subfleetRepo
-     * @param TypeRatingRepository $typeratingRepo
+     * @param AircraftRepository $aircraftRepo
+     * @param FleetService       $fleetSvc
+     * @param FareRepository     $fareRepo
+     * @param FareService        $fareSvc
+     * @param ImportService      $importSvc
+     * @param RankRepository     $rankRepo
+     * @param SubfleetRepository $subfleetRepo
      */
     public function __construct(
         AircraftRepository $aircraftRepo,
+        FleetService $fleetSvc,
         FareRepository $fareRepo,
         FareService $fareSvc,
-        FleetService $fleetSvc,
         ImportService $importSvc,
         RankRepository $rankRepo,
-        SubfleetRepository $subfleetRepo,
-        TypeRatingRepository $typeratingRepo
+        SubfleetRepository $subfleetRepo
     ) {
         $this->aircraftRepo = $aircraftRepo;
         $this->fareRepo = $fareRepo;
@@ -68,7 +64,48 @@ class SubfleetController extends Controller
         $this->importSvc = $importSvc;
         $this->rankRepo = $rankRepo;
         $this->subfleetRepo = $subfleetRepo;
-        $this->typeratingRepo = $typeratingRepo;
+    }
+
+    /**
+     * Get the ranks that are available to the subfleet
+     *
+     * @param $subfleet
+     *
+     * @return array
+     */
+    protected function getAvailRanks($subfleet)
+    {
+        $retval = [];
+        $all_ranks = $this->rankRepo->all();
+        $avail_ranks = $all_ranks->except($subfleet->ranks->modelKeys());
+        foreach ($avail_ranks as $rank) {
+            $retval[$rank->id] = $rank->name;
+        }
+
+        return $retval;
+    }
+
+    /**
+     * Get all the fares that haven't been assigned to a given subfleet
+     *
+     * @param mixed $subfleet
+     *
+     * @return array
+     */
+    protected function getAvailFares($subfleet)
+    {
+        $retval = [];
+        $all_fares = $this->fareRepo->all();
+        $avail_fares = $all_fares->except($subfleet->fares->modelKeys());
+        foreach ($avail_fares as $fare) {
+            $retval[$fare->id] = $fare->name.
+                ' (price: '.$fare->price.
+                ', type: '.FareType::label($fare->type).
+                ', cost: '.$fare->cost.
+                ', capacity: '.$fare->capacity.')';
+        }
+
+        return $retval;
     }
 
     /**
@@ -115,8 +152,8 @@ class SubfleetController extends Controller
     {
         $input = $request->all();
         $subfleet = $this->subfleetRepo->create($input);
-        Flash::success('Subfleet saved successfully.');
 
+        Flash::success('Subfleet saved successfully.');
         return redirect(route('admin.subfleets.edit', [$subfleet->id]));
     }
 
@@ -135,12 +172,10 @@ class SubfleetController extends Controller
 
         if (empty($subfleet)) {
             Flash::error('Subfleet not found');
-
             return redirect(route('admin.subfleets.index'));
         }
 
         $avail_fares = $this->getAvailFares($subfleet);
-
         return view('admin.subfleets.show', [
             'subfleet'    => $subfleet,
             'avail_fares' => $avail_fares,
@@ -157,27 +192,24 @@ class SubfleetController extends Controller
     public function edit($id)
     {
         $subfleet = $this->subfleetRepo
-            ->with(['fares', 'ranks', 'typeratings'])
+            ->with(['fares', 'ranks'])
             ->findWithoutFail($id);
 
         if (empty($subfleet)) {
             Flash::error('Subfleet not found');
-
             return redirect(route('admin.subfleets.index'));
         }
 
         $avail_fares = $this->getAvailFares($subfleet);
         $avail_ranks = $this->getAvailRanks($subfleet);
-        $avail_ratings = $this->getAvailTypeRatings($subfleet);
 
         return view('admin.subfleets.edit', [
-            'airlines'      => Airline::all()->pluck('name', 'id'),
-            'hubs'          => Airport::where('hub', 1)->pluck('name', 'id'),
-            'fuel_types'    => FuelType::labels(),
-            'avail_fares'   => $avail_fares,
-            'avail_ranks'   => $avail_ranks,
-            'avail_ratings' => $avail_ratings,
-            'subfleet'      => $subfleet,
+            'airlines'    => Airline::all()->pluck('name', 'id'),
+            'hubs'        => Airport::where('hub', 1)->pluck('name', 'id'),
+            'fuel_types'  => FuelType::labels(),
+            'avail_fares' => $avail_fares,
+            'avail_ranks' => $avail_ranks,
+            'subfleet'    => $subfleet,
         ]);
     }
 
@@ -197,13 +229,12 @@ class SubfleetController extends Controller
 
         if (empty($subfleet)) {
             Flash::error('Subfleet not found');
-
             return redirect(route('admin.subfleets.index'));
         }
 
         $this->subfleetRepo->update($request->all(), $id);
-        Flash::success('Subfleet updated successfully.');
 
+        Flash::success('Subfleet updated successfully.');
         return redirect(route('admin.subfleets.index'));
     }
 
@@ -220,7 +251,6 @@ class SubfleetController extends Controller
 
         if (empty($subfleet)) {
             Flash::error('Subfleet not found');
-
             return redirect(route('admin.subfleets.index'));
         }
 
@@ -229,13 +259,12 @@ class SubfleetController extends Controller
         $aircraft = $this->aircraftRepo->findWhere(['subfleet_id' => $id], ['id']);
         if ($aircraft->count() > 0) {
             Flash::error('There are aircraft still assigned to this subfleet, you can\'t delete it!')->important();
-
             return redirect(route('admin.subfleets.index'));
         }
 
         $this->subfleetRepo->delete($id);
-        Flash::success('Subfleet deleted successfully.');
 
+        Flash::success('Subfleet deleted successfully.');
         return redirect(route('admin.subfleets.index'));
     }
 
@@ -252,8 +281,11 @@ class SubfleetController extends Controller
         $subfleets = $this->subfleetRepo->all();
 
         $path = $exporter->exportSubfleets($subfleets);
-
-        return response()->download($path, 'subfleets.csv', ['content-type' => 'text/csv'])->deleteFileAfterSend(true);
+        return response()
+            ->download($path, 'subfleets.csv', [
+                'content-type' => 'text/csv',
+            ])
+            ->deleteFileAfterSend(true);
     }
 
     /**
@@ -280,64 +312,77 @@ class SubfleetController extends Controller
     }
 
     /**
-     * Get all the fares that haven't been assigned to a given subfleet
+     * @param Subfleet $subfleet
      *
-     * @param mixed $subfleet
-     *
-     * @return array
+     * @return mixed
      */
-    protected function getAvailFares($subfleet)
+    protected function return_ranks_view(?Subfleet $subfleet)
     {
-        $retval = [];
-        $all_fares = $this->fareRepo->all();
-        $avail_fares = $all_fares->except($subfleet->fares->modelKeys());
-        foreach ($avail_fares as $fare) {
-            $retval[$fare->id] = $fare->name.
-                ' (price: '.$fare->price.
-                ', type: '.FareType::label($fare->type).
-                ', cost: '.$fare->cost.
-                ', capacity: '.$fare->capacity.')';
-        }
+        $subfleet->refresh();
 
-        return $retval;
+        $avail_ranks = $this->getAvailRanks($subfleet);
+        return view('admin.subfleets.ranks', [
+            'subfleet'    => $subfleet,
+            'avail_ranks' => $avail_ranks,
+        ]);
     }
 
     /**
-     * Get the ranks that are available to the subfleet
+     * @param Subfleet $subfleet
      *
-     * @param $subfleet
-     *
-     * @return array
+     * @return mixed
      */
-    protected function getAvailRanks($subfleet)
+    protected function return_fares_view(?Subfleet $subfleet)
     {
-        $retval = [];
-        $all_ranks = $this->rankRepo->all();
-        $avail_ranks = $all_ranks->except($subfleet->ranks->modelKeys());
-        foreach ($avail_ranks as $rank) {
-            $retval[$rank->id] = $rank->name;
-        }
+        $subfleet->refresh();
 
-        return $retval;
+        $avail_fares = $this->getAvailFares($subfleet);
+        return view('admin.subfleets.fares', [
+            'subfleet'    => $subfleet,
+            'avail_fares' => $avail_fares,
+        ]);
     }
 
     /**
-     * Get the type ratings that are available to the subfleet
+     * Operations for associating ranks to the subfleet
      *
-     * @param $subfleet
+     * @param         $id
+     * @param Request $request
      *
-     * @return array
+     * @return mixed
      */
-    protected function getAvailTypeRatings($subfleet)
+    public function ranks($id, Request $request)
     {
-        $retval = [];
-        $all_ratings = $this->typeratingRepo->all();
-        $avail_ratings = $all_ratings->except($subfleet->typeratings->modelKeys());
-        foreach ($avail_ratings as $tr) {
-            $retval[$tr->id] = $tr->name.' ('.$tr->type.')';
+        $subfleet = $this->subfleetRepo->findWithoutFail($id);
+        if (empty($subfleet)) {
+            return $this->return_ranks_view($subfleet);
         }
 
-        return $retval;
+        if ($request->isMethod('get')) {
+            return $this->return_ranks_view($subfleet);
+        }
+
+        /*
+         * update specific rank data
+         */
+        if ($request->isMethod('post')) {
+            $rank = $this->rankRepo->find($request->input('rank_id'));
+            $this->fleetSvc->addSubfleetToRank($subfleet, $rank);
+        } elseif ($request->isMethod('put')) {
+            $override = [];
+            $rank = $this->rankRepo->find($request->input('rank_id'));
+            $override[$request->name] = $request->value;
+
+            $this->fleetSvc->addSubfleetToRank($subfleet, $rank, $override);
+        } // dissassociate fare from teh aircraft
+        elseif ($request->isMethod('delete')) {
+            $rank = $this->rankRepo->find($request->input('rank_id'));
+            $this->fleetSvc->removeSubfleetFromRank($subfleet, $rank);
+        }
+
+        $subfleet->save();
+
+        return $this->return_ranks_view($subfleet);
     }
 
     /**
@@ -353,54 +398,6 @@ class SubfleetController extends Controller
         ]);
     }
 
-    /**
-     * @param Subfleet $subfleet
-     *
-     * @return mixed
-     */
-    protected function return_fares_view(?Subfleet $subfleet)
-    {
-        $subfleet->refresh();
-        $avail_fares = $this->getAvailFares($subfleet);
-
-        return view('admin.subfleets.fares', [
-            'subfleet'    => $subfleet,
-            'avail_fares' => $avail_fares,
-        ]);
-    }
-
-    /**
-     * @param Subfleet $subfleet
-     *
-     * @return mixed
-     */
-    protected function return_ranks_view(?Subfleet $subfleet)
-    {
-        $subfleet->refresh();
-        $avail_ranks = $this->getAvailRanks($subfleet);
-
-        return view('admin.subfleets.ranks', [
-            'subfleet'    => $subfleet,
-            'avail_ranks' => $avail_ranks,
-        ]);
-    }
-
-    /**
-     * @param Subfleet $subfleet
-     *
-     * @return mixed
-     */
-    protected function return_typeratings_view(?Subfleet $subfleet)
-    {
-        $subfleet->refresh();
-        $avail_ratings = $this->getAvailTypeRatings($subfleet);
-
-        return view('admin.subfleets.type_ratings', [
-            'subfleet'      => $subfleet,
-            'avail_ratings' => $avail_ratings,
-        ]);
-    }
-
     /**
      * Operations for associating ranks to the subfleet
      *
@@ -482,79 +479,4 @@ class SubfleetController extends Controller
 
         return $this->return_fares_view($subfleet);
     }
-
-    /**
-     * Operations for associating ranks to the subfleet
-     *
-     * @param         $id
-     * @param Request $request
-     *
-     * @return mixed
-     */
-    public function ranks($id, Request $request)
-    {
-        $subfleet = $this->subfleetRepo->findWithoutFail($id);
-        if (empty($subfleet)) {
-            return $this->return_ranks_view($subfleet);
-        }
-
-        if ($request->isMethod('get')) {
-            return $this->return_ranks_view($subfleet);
-        }
-
-        // associate rank with the subfleet
-        if ($request->isMethod('post')) {
-            $rank = $this->rankRepo->find($request->input('rank_id'));
-            $this->fleetSvc->addSubfleetToRank($subfleet, $rank);
-        } // override definitions
-        elseif ($request->isMethod('put')) {
-            $override = [];
-            $rank = $this->rankRepo->find($request->input('rank_id'));
-            $override[$request->name] = $request->value;
-
-            $this->fleetSvc->addSubfleetToRank($subfleet, $rank, $override);
-        } // dissassociate rank from the subfleet
-        elseif ($request->isMethod('delete')) {
-            $rank = $this->rankRepo->find($request->input('rank_id'));
-            $this->fleetSvc->removeSubfleetFromRank($subfleet, $rank);
-        }
-
-        $subfleet->save();
-
-        return $this->return_ranks_view($subfleet);
-    }
-
-    /**
-     * Operations for associating type ratings to the subfleet
-     *
-     * @param         $id
-     * @param Request $request
-     *
-     * @return mixed
-     */
-    public function typeratings($id, Request $request)
-    {
-        $subfleet = $this->subfleetRepo->findWithoutFail($id);
-        if (empty($subfleet)) {
-            return $this->return_typeratings_view($subfleet);
-        }
-
-        if ($request->isMethod('get')) {
-            return $this->return_typeratings_view($subfleet);
-        }
-
-        // associate subfleet with type rating
-        if ($request->isMethod('post')) {
-            $typerating = $this->typeratingRepo->find($request->input('typerating_id'));
-            $this->fleetSvc->addSubfleetToTypeRating($subfleet, $typerating);
-        } // dissassociate subfleet from the type rating
-        elseif ($request->isMethod('delete')) {
-            $typerating = $this->typeratingRepo->find($request->input('typerating_id'));
-            $this->fleetSvc->removeSubfleetFromTypeRating($subfleet, $typerating);
-        }
-
-        $subfleet->save();
-
-        return $this->return_typeratings_view($subfleet);
-    }
 }

app/Http/Controllers/Admin/TypeRatingController.php

@@ -1,168 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Admin;
-
-use App\Contracts\Controller;
-use App\Http\Requests\CreateTypeRatingRequest;
-use App\Http\Requests\UpdateTypeRatingRequest;
-use App\Repositories\SubfleetRepository;
-use App\Repositories\TypeRatingRepository;
-use App\Services\FleetService;
-use Cache;
-use Illuminate\Http\Request;
-use Laracasts\Flash\Flash;
-use Prettus\Repository\Criteria\RequestCriteria;
-
-class TypeRatingController extends Controller
-{
-    private $fleetSvc;
-    private $subfleetRepo;
-    private $typeratingRepo;
-
-    public function __construct(
-        FleetService $fleetSvc,
-        SubfleetRepository $subfleetRepo,
-        TypeRatingRepository $typeratingRepo
-    ) {
-        $this->fleetSvc = $fleetSvc;
-        $this->subfleetRepo = $subfleetRepo;
-        $this->typeratingRepo = $typeratingRepo;
-    }
-
-    public function index(Request $request)
-    {
-        $this->typeratingRepo->pushCriteria(new RequestCriteria($request));
-        $typeratings = $this->typeratingRepo->all();
-
-        return view('admin.typeratings.index', [
-            'typeratings' => $typeratings,
-        ]);
-    }
-
-    public function create()
-    {
-        return view('admin.typeratings.create');
-    }
-
-    public function store(CreateTypeRatingRequest $request)
-    {
-        $input = $request->all();
-
-        $model = $this->typeratingRepo->create($input);
-        Flash::success('Type Rating saved successfully.');
-        // Cache::forget(config('cache.keys.RANKS_PILOT_LIST.key'));
-
-        return redirect(route('admin.typeratings.edit', [$model->id]));
-    }
-
-    public function show($id)
-    {
-        $typerating = $this->typeratingRepo->findWithoutFail($id);
-
-        if (empty($typerating)) {
-            Flash::error('Type Rating not found');
-
-            return redirect(route('admin.typeratings.index'));
-        }
-
-        return view('admin.typeratings.show', [
-            'typerating' => $typerating,
-        ]);
-    }
-
-    public function edit($id)
-    {
-        $typerating = $this->typeratingRepo->findWithoutFail($id);
-
-        if (empty($typerating)) {
-            Flash::error('Type Rating not found');
-
-            return redirect(route('admin.typeratings.index'));
-        }
-
-        $avail_subfleets = $this->getAvailSubfleets($typerating);
-
-        return view('admin.typeratings.edit', [
-            'typerating'      => $typerating,
-            'avail_subfleets' => $avail_subfleets,
-        ]);
-    }
-
-    public function update($id, UpdateTypeRatingRequest $request)
-    {
-        $typerating = $this->typeratingRepo->findWithoutFail($id);
-
-        if (empty($typerating)) {
-            Flash::error('Type Rating not found');
-
-            return redirect(route('admin.typeratings.index'));
-        }
-
-        $typerating = $this->typeratingRepo->update($request->all(), $id);
-        // Cache::forget(config('cache.keys.RANKS_PILOT_LIST.key'));
-        Flash::success('Type Rating updated successfully.');
-
-        return redirect(route('admin.typeratings.index'));
-    }
-
-    public function destroy($id)
-    {
-        $typerating = $this->typeratingRepo->findWithoutFail($id);
-
-        if (empty($typerating)) {
-            Flash::error('Type Rating not found');
-
-            return redirect(route('admin.typeratings.index'));
-        }
-
-        $this->typeratingRepo->delete($id);
-
-        Flash::success('Type Rating deleted successfully.');
-
-        return redirect(route('admin.typeratings.index'));
-    }
-
-    protected function getAvailSubfleets($typerating)
-    {
-        $retval = [];
-        $all_subfleets = $this->subfleetRepo->all();
-        $avail_subfleets = $all_subfleets->except($typerating->subfleets->modelKeys());
-        foreach ($avail_subfleets as $subfleet) {
-            $retval[$subfleet->id] = $subfleet->name.' (Airline: '.$subfleet->airline->code.')';
-        }
-
-        return $retval;
-    }
-
-    protected function return_subfleet_view($typerating)
-    {
-        $avail_subfleets = $this->getAvailSubfleets($typerating);
-
-        return view('admin.typeratings.subfleets', [
-            'typerating'      => $typerating,
-            'avail_subfleets' => $avail_subfleets,
-        ]);
-    }
-
-    public function subfleets($id, Request $request)
-    {
-        $typerating = $this->typeratingRepo->findWithoutFail($id);
-        if (empty($typerating)) {
-            Flash::error('Type Rating not found!');
-            return redirect(route('admin.typeratings.index'));
-        }
-
-        // add subfleet to type rating
-        if ($request->isMethod('post')) {
-            $subfleet = $this->subfleetRepo->find($request->input('subfleet_id'));
-            $this->fleetSvc->addSubfleetToTypeRating($subfleet, $typerating);
-        }
-        // remove subfleet from type rating
-        elseif ($request->isMethod('delete')) {
-            $subfleet = $this->subfleetRepo->find($request->input('subfleet_id'));
-            $this->fleetSvc->removeSubfleetFromTypeRating($subfleet, $typerating);
-        }
-
-        return $this->return_subfleet_view($typerating);
-    }
-}

app/Http/Controllers/Admin/UserController.php

@@ -12,7 +12,6 @@ use App\Repositories\AirlineRepository;
 use App\Repositories\AirportRepository;
 use App\Repositories\PirepRepository;
 use App\Repositories\RoleRepository;
-use App\Repositories\TypeRatingRepository;
 use App\Repositories\UserRepository;
 use App\Services\UserService;
 use App\Support\Timezonelist;
@@ -31,27 +30,24 @@ class UserController extends Controller
     private $airportRepo;
     private $pirepRepo;
     private $roleRepo;
-    private $typeratingRepo;
     private $userRepo;
     private $userSvc;
 
     /**
      * UserController constructor.
      *
-     * @param AirlineRepository    $airlineRepo
-     * @param AirportRepository    $airportRepo
-     * @param PirepRepository      $pirepRepo
-     * @param RoleRepository       $roleRepo
-     * @param TypeRatingRepository $typeratingRepo
-     * @param UserRepository       $userRepo
-     * @param UserService          $userSvc
+     * @param AirlineRepository $airlineRepo
+     * @param AirportRepository $airportRepo
+     * @param PirepRepository   $pirepRepo
+     * @param RoleRepository    $roleRepo
+     * @param UserRepository    $userRepo
+     * @param UserService       $userSvc
      */
     public function __construct(
         AirlineRepository $airlineRepo,
         AirportRepository $airportRepo,
         PirepRepository $pirepRepo,
         RoleRepository $roleRepo,
-        TypeRatingRepository $typeratingRepo,
         UserRepository $userRepo,
         UserService $userSvc
     ) {
@@ -59,7 +55,6 @@ class UserController extends Controller
         $this->airportRepo = $airportRepo;
         $this->pirepRepo = $pirepRepo;
         $this->roleRepo = $roleRepo;
-        $this->typeratingRepo = $typeratingRepo;
         $this->userSvc = $userSvc;
         $this->userRepo = $userRepo;
     }
@@ -154,7 +149,7 @@ class UserController extends Controller
     public function edit($id)
     {
         $user = $this->userRepo
-            ->with(['awards', 'fields', 'rank', 'typeratings'])
+            ->with(['awards', 'fields', 'rank'])
             ->findWithoutFail($id);
 
         if (empty($user)) {
@@ -174,19 +169,17 @@ class UserController extends Controller
         $airlines = $this->airlineRepo->selectBoxList();
         $airports = $this->airportRepo->selectBoxList(false);
         $roles = $this->roleRepo->selectBoxList(false, true);
-        $avail_ratings = $this->getAvailTypeRatings($user);
 
         return view('admin.users.edit', [
-            'user'          => $user,
-            'pireps'        => $pireps,
-            'country'       => new ISO3166(),
-            'countries'     => $countries,
-            'timezones'     => Timezonelist::toArray(),
-            'airports'      => $airports,
-            'airlines'      => $airlines,
-            'ranks'         => Rank::all()->pluck('name', 'id'),
-            'roles'         => $roles,
-            'avail_ratings' => $avail_ratings,
+            'user'      => $user,
+            'pireps'    => $pireps,
+            'country'   => new ISO3166(),
+            'countries' => $countries,
+            'timezones' => Timezonelist::toArray(),
+            'airports'  => $airports,
+            'airlines'  => $airlines,
+            'ranks'     => Rank::all()->pluck('name', 'id'),
+            'roles'     => $roles,
         ]);
     }
 
@@ -267,7 +260,6 @@ class UserController extends Controller
         $user = $this->userRepo->findWithoutFail($id);
         if (empty($user)) {
             Flash::error('User not found');
-
             return redirect(route('admin.users.index'));
         }
 
@@ -291,7 +283,6 @@ class UserController extends Controller
         $userAward = UserAward::where(['user_id' => $id, 'award_id' => $award_id]);
         if (empty($userAward)) {
             Flash::error('The user award could not be found');
-
             return redirect()->back();
         }
 
@@ -320,73 +311,4 @@ class UserController extends Controller
 
         return redirect(route('admin.users.edit', [$id]));
     }
-
-    /**
-     * Get the type ratings that are available to the user
-     *
-     * @param $user
-     *
-     * @return array
-     */
-    protected function getAvailTypeRatings($user)
-    {
-        $retval = [];
-        $all_ratings = $this->typeratingRepo->all();
-        $avail_ratings = $all_ratings->except($user->typeratings->modelKeys());
-        foreach ($avail_ratings as $tr) {
-            $retval[$tr->id] = $tr->name.' ('.$tr->type.')';
-        }
-
-        return $retval;
-    }
-
-    /**
-     * @param User $user
-     *
-     * @return mixed
-     */
-    protected function return_typeratings_view(?User $user)
-    {
-        $user->refresh();
-
-        $avail_ratings = $this->getAvailTypeRatings($user);
-        return view('admin.users.type_ratings', [
-            'user'          => $user,
-            'avail_ratings' => $avail_ratings,
-        ]);
-    }
-
-    /**
-     * Operations for associating type ratings to the user
-     *
-     * @param         $id
-     * @param Request $request
-     *
-     * @return mixed
-     */
-    public function typeratings($id, Request $request)
-    {
-        $user = $this->userRepo->findWithoutFail($id);
-        if (empty($user)) {
-            return $this->return_typeratings_view($user);
-        }
-
-        if ($request->isMethod('get')) {
-            return $this->return_typeratings_view($user);
-        }
-
-        // associate user with type rating
-        if ($request->isMethod('post')) {
-            $typerating = $this->typeratingRepo->find($request->input('typerating_id'));
-            $this->userSvc->addUserToTypeRating($user, $typerating);
-        } // dissassociate user from the type rating
-        elseif ($request->isMethod('delete')) {
-            $typerating = $this->typeratingRepo->find($request->input('typerating_id'));
-            $this->userSvc->removeUserFromTypeRating($user, $typerating);
-        }
-
-        $user->save();
-
-        return $this->return_typeratings_view($user);
-    }
 }

app/Http/Controllers/Api/AcarsController.php

@@ -148,10 +148,10 @@ class AcarsController extends Controller
         $pirep = Pirep::find($id);
         $this->checkCancelled($pirep);
 
-        /*Log::debug(
+        Log::debug(
             'Posting ACARS update (user: '.Auth::user()->ident.', pirep id :'.$id.'): ',
             $request->post()
-        );*/
+        );
 
         $count = 0;
         $positions = $request->post('positions');
@@ -223,7 +223,7 @@ class AcarsController extends Controller
         $pirep = Pirep::find($id);
         $this->checkCancelled($pirep);
 
-        // Log::debug('Posting ACARS log, PIREP: '.$id, $request->post());
+        Log::debug('Posting ACARS log, PIREP: '.$id, $request->post());
 
         $count = 0;
         $logs = $request->post('logs');

app/Http/Controllers/Api/PirepController.php

@@ -25,7 +25,6 @@ use App\Models\Pirep;
 use App\Models\PirepComment;
 use App\Models\PirepFare;
 use App\Models\PirepFieldValue;
-use App\Models\User;
 use App\Repositories\JournalRepository;
 use App\Repositories\PirepRepository;
 use App\Services\Finance\PirepFinanceService;
@@ -236,12 +235,8 @@ class PirepController extends Controller
         Log::info('PIREP Update, user '.Auth::id());
         Log::info($request->getContent());
 
-        /** @var User $user */
         $user = Auth::user();
-
-        /** @var Pirep $pirep */
         $pirep = Pirep::find($pirep_id);
-
         $this->checkCancelled($pirep);
 
         $attrs = $this->parsePirep($request);
@@ -283,7 +278,6 @@ class PirepController extends Controller
     {
         Log::info('PIREP file, user '.Auth::id(), $request->post());
 
-        /** @var User $user */
         $user = Auth::user();
 
         // Check if the status is cancelled...
@@ -338,7 +332,7 @@ class PirepController extends Controller
      */
     public function cancel($pirep_id, Request $request)
     {
-        Log::info('PIREP '.$pirep_id.' Cancel, user '.Auth::id(), $request->post());
+        Log::info('PIREP Cancel, user '.Auth::id(), $request->post());
 
         $pirep = Pirep::find($pirep_id);
         $this->pirepSvc->cancel($pirep);

app/Http/Controllers/Auth/RegisterController.php

@@ -62,7 +62,7 @@ class RegisterController extends Controller
     {
         $airports = $this->airportRepo->selectBoxList(false, setting('pilots.home_hubs_only'));
         $airlines = $this->airlineRepo->selectBoxList();
-        $userFields = UserField::where(['show_on_registration' => true, 'active' => true])->get();
+        $userFields = UserField::where(['show_on_registration' => true])->get();
 
         return view('auth.register', [
             'airports'   => $airports,
@@ -138,7 +138,7 @@ class RegisterController extends Controller
 
         Log::info('User registered: ', $user->toArray());
 
-        $userFields = UserField::where(['show_on_registration' => true, 'active' => true])->get();
+        $userFields = UserField::all();
         foreach ($userFields as $field) {
             $field_name = 'field_'.$field->slug;
             UserFieldValue::updateOrCreate([

app/Http/Controllers/Frontend/PirepController.php

@@ -91,12 +91,8 @@ class PirepController extends Controller
      */
     public function aircraftList($add_blank = false)
     {
-        $user = Auth::user();
-        $user_loc = filled($user->curr_airport_id) ? $user->curr_airport_id : $user->home_airport_id;
-        $location_check = setting('pireps.only_aircraft_at_dpt_airport', false);
-
         $aircraft = [];
-        $subfleets = $this->userSvc->getAllowableSubfleets($user);
+        $subfleets = $this->userSvc->getAllowableSubfleets(Auth::user());
 
         if ($add_blank) {
             $aircraft[''] = '';
@@ -104,9 +100,7 @@ class PirepController extends Controller
 
         foreach ($subfleets as $subfleet) {
             $tmp = [];
-            foreach ($subfleet->aircraft->when($location_check, function ($query) use ($user_loc) {
-                return $query->where('airport_id', $user_loc);
-            }) as $ac) {
+            foreach ($subfleet->aircraft as $ac) {
                 $tmp[$ac->id] = $ac['name'].' - '.$ac['registration'];
             }
 

app/Http/Controllers/Frontend/ProfileController.php

@@ -80,7 +80,7 @@ class ProfileController extends Controller
     public function show($id)
     {
         /** @var \App\Models\User $user */
-        $with = ['airline', 'awards', 'current_airport', 'fields.field', 'home_airport', 'last_pirep', 'rank', 'typeratings'];
+        $with = ['airline', 'awards', 'current_airport', 'fields.field', 'home_airport', 'last_pirep', 'rank'];
         $user = User::with($with)->where('id', $id)->first();
 
         if (empty($user)) {

app/Http/Controllers/Frontend/SimBriefController.php

@@ -80,39 +80,46 @@ class SimBriefController
 
         // No aircraft selected, show selection form
         if (!$aircraft_id) {
-
-            // Get user's allowed subfleets and intersect it with flight subfleets
-            // so we will have a proper list which the user is allowed to fly
-            $user_subfleets = $this->userSvc->getAllowableSubfleets($user)->pluck('id')->toArray();
-            $flight_subfleets = $flight->subfleets->pluck('id')->toArray();
-
-            $subfleet_ids = filled($flight_subfleets) ? array_intersect($user_subfleets, $flight_subfleets) : $user_subfleets;
-
-            // Prepare variables for single aircraft query
-            $where = [];
-            $where['state'] = AircraftState::PARKED;
-            $where['status'] = AircraftStatus::ACTIVE;
-
-            if (setting('pireps.only_aircraft_at_dpt_airport')) {
-                $where['airport_id'] = $flight->dpt_airport_id;
+            // If no subfleets defined for flight get them from user
+            if ($flight->subfleets->count() > 0) {
+                $subfleets = $flight->subfleets;
+            } else {
+                $subfleets = $this->userSvc->getAllowableSubfleets($user);
             }
 
-            $withCount = ['simbriefs' => function ($query) {
-                $query->whereNull('pirep_id');
-            }];
+            // Build an array of subfleet id's from the subfleets collection
+            $sf_ids = $subfleets->map(function ($subfleets) {
+                return collect($subfleets->toArray())
+                  ->only(['id'])
+                  ->all();
+            });
 
-            // Build proper aircraft collection considering all possible settings
-            // Flight subfleets, user subfleet restrictions, pirep restrictions, simbrief blocking etc
-            $aircraft = Aircraft::withCount($withCount)->where($where)
-                ->when(setting('simbrief.block_aircraft'), function ($query) {
-                    return $query->having('simbriefs_count', 0);
-                })->whereIn('subfleet_id', $subfleet_ids)
-                ->orderby('icao')->orderby('registration')
-                ->get();
+            // Now we can build a proper aircrafts collection
+            // Contents will be either members of flight->subfleets
+            // or members of user's allowable subfleets
+            $aircrafts = Aircraft::whereIn('subfleet_id', $sf_ids)
+                                ->where('state', AircraftState::PARKED)
+                                ->where('status', AircraftStatus::ACTIVE)
+                                ->orderby('icao')
+                                ->orderby('registration')
+                                ->get();
+
+            if (setting('pireps.only_aircraft_at_dpt_airport')) {
+                $aircrafts = $aircrafts->where('airport_id', $flight->dpt_airport_id);
+            }
+
+            if (setting('simbrief.block_aircraft')) {
+                // Build a list of aircraft_id's being used for active sb packs
+                $sb_aircraft = SimBrief::whereNotNull('flight_id')->pluck('aircraft_id');
+
+                // Filter aircraft list to non used/blocked ones
+                $aircrafts = $aircrafts->whereNotIn('id', $sb_aircraft);
+            }
 
             return view('flights.simbrief_aircraft', [
                 'flight'    => $flight,
-                'aircrafts' => $aircraft,
+                'aircrafts' => $aircrafts,
+                'subfleets' => $subfleets,
             ]);
         }
 

app/Http/Requests/CreateTypeRatingRequest.php

@@ -1,19 +0,0 @@
-<?php
-
-namespace App\Http\Requests;
-
-use App\Contracts\FormRequest;
-use App\Models\Typerating;
-
-class CreateTypeRatingRequest extends FormRequest
-{
-    /**
-     * Get the validation rules that apply to the request.
-     *
-     * @return array
-     */
-    public function rules(): array
-    {
-        return Typerating::$rules;
-    }
-}

app/Http/Requests/UpdateTypeRatingRequest.php

@@ -1,19 +0,0 @@
-<?php
-
-namespace App\Http\Requests;
-
-use App\Contracts\FormRequest;
-use App\Models\Typerating;
-
-class UpdateTypeRatingRequest extends FormRequest
-{
-    /**
-     * Get the validation rules that apply to the request.
-     *
-     * @return array
-     */
-    public function rules(): array
-    {
-        return Typerating::$rules;
-    }
-}

app/Listeners/AwardHandler.php

@@ -60,7 +60,7 @@ class AwardHandler extends Listener
      */
     public function checkForAwards($user)
     {
-        $awards = Award::where('active', 1)->get();
+        $awards = Award::all();
         foreach ($awards as $award) {
             $klass = $award->getReference($award, $user);
             if ($klass) {

app/Models/Aircraft.php

@@ -13,7 +13,6 @@ use Znck\Eloquent\Traits\BelongsToThrough;
  * @property int      id
  * @property mixed    subfleet_id
  * @property string   airport_id   The apt where the aircraft is
- * @property string   hub_id       The apt where the aircraft is based
  * @property string   ident
  * @property string   name
  * @property string   icao
@@ -23,7 +22,6 @@ use Znck\Eloquent\Traits\BelongsToThrough;
  * @property float    zfw
  * @property string   hex_code
  * @property Airport  airport
- * @property Airport  hub
  * @property Subfleet subfleet
  * @property int      status
  * @property int      state
@@ -41,7 +39,6 @@ class Aircraft extends Model
     protected $fillable = [
         'subfleet_id',
         'airport_id',
-        'hub_id',
         'iata',
         'icao',
         'name',
@@ -130,11 +127,6 @@ class Aircraft extends Model
         return $this->belongsTo(Airport::class, 'airport_id');
     }
 
-    public function hub()
-    {
-        return $this->hasOne(Airport::class, 'id', 'hub_id');
-    }
-
     public function pireps()
     {
         return $this->hasMany(Pirep::class, 'aircraft_id');

app/Models/Award.php

@@ -21,7 +21,6 @@ class Award extends Model
         'image_url',
         'ref_model',
         'ref_model_params',
-        'active',
     ];
 
     public static $rules = [
@@ -30,7 +29,6 @@ class Award extends Model
         'image_url'        => 'nullable',
         'ref_model'        => 'required',
         'ref_model_params' => 'nullable',
-        'active'           => 'nullable',
     ];
 
     /**

app/Models/Subfleet.php

@@ -107,9 +107,4 @@ class Subfleet extends Model
         return $this->belongsToMany(Rank::class, 'subfleet_rank')
             ->withPivot('acars_pay', 'manual_pay');
     }
-
-    public function typeratings()
-    {
-        return $this->belongsToMany(Typerating::class, 'typerating_subfleet', 'subfleet_id', 'typerating_id');
-    }
 }

app/Models/Typerating.php

@@ -1,37 +0,0 @@
-<?php
-
-namespace App\Models;
-
-use App\Contracts\Model;
-
-class Typerating extends Model
-{
-    public $table = 'typeratings';
-
-    protected $fillable = [
-        'name',
-        'type',
-        'description',
-        'image_url',
-        'active',
-    ];
-
-    // Validation
-    public static $rules = [
-        'name'        => 'required',
-        'type'        => 'required',
-        'description' => 'nullable',
-        'image_url'   => 'nullable',
-    ];
-
-    // Relationships
-    public function subfleets()
-    {
-        return $this->belongsToMany(Subfleet::class, 'typerating_subfleet', 'typerating_id', 'subfleet_id');
-    }
-
-    public function users()
-    {
-        return $this->belongsToMany(User::class, 'typerating_user', 'typerating_id', 'user_id');
-    }
-}

app/Models/User.php

@@ -7,7 +7,6 @@ use App\Models\Traits\JournalTrait;
 use Illuminate\Foundation\Auth\User as Authenticatable;
 use Illuminate\Notifications\Notifiable;
 use Laratrust\Traits\LaratrustUserTrait;
-use Staudenmeir\EloquentHasManyDeep\HasRelationships;
 
 /**
  * @property int              id
@@ -43,7 +42,6 @@ use Staudenmeir\EloquentHasManyDeep\HasRelationships;
  * @property UserFieldValue[] fields
  * @property Role[]           roles
  * @property Subfleet[]       subfleets
- * @property TypeRating[]     typeratings
  *
  * @mixin \Illuminate\Database\Eloquent\Builder
  * @mixin \Illuminate\Notifications\Notifiable
@@ -54,7 +52,6 @@ class User extends Authenticatable
     use JournalTrait;
     use LaratrustUserTrait;
     use Notifiable;
-    use HasRelationships;
 
     public $table = 'users';
 
@@ -194,7 +191,8 @@ class User extends Authenticatable
     {
         $default = config('gravatar.default');
 
-        $uri = config('gravatar.url').md5(strtolower(trim($this->email))).'?d='.urlencode($default);
+        $uri = config('gravatar.url')
+            .md5(strtolower(trim($this->email))).'?d='.urlencode($default);
 
         if ($size !== null) {
             $uri .= '&s='.$size;
@@ -267,14 +265,4 @@ class User extends Authenticatable
     {
         return $this->belongsTo(Rank::class, 'rank_id');
     }
-
-    public function typeratings()
-    {
-        return $this->belongsToMany(Typerating::class, 'typerating_user', 'user_id', 'typerating_id');
-    }
-
-    public function rated_subfleets()
-    {
-        return $this->hasManyDeep(Subfleet::class, ['typerating_user', Typerating::class, 'typerating_subfleet']);
-    }
 }

app/Providers/RouteServiceProvider.php

@@ -376,21 +376,6 @@ class RouteServiceProvider extends ServiceProvider
             ], 'settings', 'SettingsController@update')
                 ->name('settings.update')->middleware('ability:admin,settings');
 
-            // Type Ratings
-            Route::resource('typeratings', 'TypeRatingController')->middleware('ability:admin,typeratings');
-            Route::match([
-                'get',
-                'post',
-                'put',
-                'delete',
-            ], 'typeratings/{id}/subfleets', 'TypeRatingController@subfleets')->middleware('ability:admin,typeratings');
-            Route::match([
-                'get',
-                'post',
-                'put',
-                'delete',
-            ], 'typeratings/{id}/users', 'TypeRatingController@users')->middleware('ability:admin,typeratings');
-
             // maintenance
             Route::match(['get'], 'maintenance', 'MaintenanceController@index')
                 ->name('maintenance.index')->middleware('ability:admin,maintenance');
@@ -441,13 +426,6 @@ class RouteServiceProvider extends ServiceProvider
                 'delete',
             ], 'subfleets/{id}/ranks', 'SubfleetController@ranks')->middleware('ability:admin,fleet');
 
-            Route::match([
-                'get',
-                'post',
-                'put',
-                'delete',
-            ], 'subfleets/{id}/typeratings', 'SubfleetController@typeratings')->middleware('ability:admin,fleet');
-
             Route::resource('subfleets', 'SubfleetController')->middleware('ability:admin,fleet');
 
             /**
@@ -461,13 +439,6 @@ class RouteServiceProvider extends ServiceProvider
 
             Route::resource('users', 'UserController')->middleware('ability:admin,users');
 
-            Route::match([
-                'get',
-                'post',
-                'put',
-                'delete',
-            ], 'users/{id}/typeratings', 'UserController@typeratings')->middleware('ability:admin,users');
-
             // defaults
             Route::get('', ['uses' => 'DashboardController@index'])
                 ->middleware('update_pending', 'ability:admin,admin-access');

app/Repositories/TypeRatingRepository.php

@@ -1,43 +0,0 @@
-<?php
-
-namespace App\Repositories;
-
-use App\Contracts\Repository;
-use App\Models\Typerating;
-use Prettus\Repository\Contracts\CacheableInterface;
-use Prettus\Repository\Traits\CacheableRepository;
-
-class TypeRatingRepository extends Repository implements CacheableInterface
-{
-    use CacheableRepository;
-
-    protected $fieldSearchable = [
-        'name' => 'like',
-        'type' => 'like',
-    ];
-
-    public function model()
-    {
-        return Typerating::class;
-    }
-
-    public function selectBoxList($add_blank = false, $only_active = true): array
-    {
-        $retval = [];
-        $where = [
-            'active' => $only_active,
-        ];
-
-        $items = $this->findWhere($where);
-
-        if ($add_blank) {
-            $retval[''] = '';
-        }
-
-        foreach ($items as $i) {
-            $retval[$i->id] = $i->name;
-        }
-
-        return $retval;
-    }
-}

app/Services/FleetService.php

@@ -6,7 +6,6 @@ use App\Contracts\Service;
 use App\Models\Flight;
 use App\Models\Rank;
 use App\Models\Subfleet;
-use App\Models\Typerating;
 
 class FleetService extends Service
 {
@@ -34,36 +33,7 @@ class FleetService extends Service
     public function removeSubfleetFromRank(Subfleet $subfleet, Rank $rank)
     {
         $subfleet->ranks()->detach($rank->id);
-        $subfleet->save();
-        $subfleet->refresh();
 
-        return $subfleet;
-    }
-
-    /**
-     * Add the subfleet to a type rating
-     *
-     * @param Subfleet   $subfleet
-     * @param Typerating $typerating
-     */
-    public function addSubfleetToTypeRating(Subfleet $subfleet, Typerating $typerating)
-    {
-        $subfleet->typeratings()->syncWithoutDetaching([$typerating->id]);
-        $subfleet->save();
-        $subfleet->refresh();
-
-        return $subfleet;
-    }
-
-    /**
-     * Remove the subfleet from a type rating
-     *
-     * @param Subfleet   $subfleet
-     * @param Typerating $typerating
-     */
-    public function removeSubfleetFromTypeRating(Subfleet $subfleet, Typerating $typerating)
-    {
-        $subfleet->typeratings()->detach($typerating->id);
         $subfleet->save();
         $subfleet->refresh();
 

app/Services/ImportExport/AircraftImporter.php

@@ -25,7 +25,6 @@ class AircraftImporter extends ImportExport
         'subfleet'     => 'required',
         'iata'         => 'nullable',
         'icao'         => 'nullable',
-        'hub_id'       => 'nullable',
         'airport_id'   => 'nullable',
         'name'         => 'required',
         'registration' => 'required',
@@ -54,7 +53,7 @@ class AircraftImporter extends ImportExport
     }
 
     /**
-     * Import an aircraft, parse out the different rows
+     * Import a flight, parse out the different rows
      *
      * @param array $row
      * @param int   $index

app/Services/ImportExport/FlightImporter.php

@@ -253,9 +253,8 @@ class FlightImporter extends ImportExport
                 $fare_attributes = [];
             }
 
-            $fare = Fare::firstOrCreate(['code' => $fare_code], ['name' => $fare_code]);
+            $fare = Fare::updateOrCreate(['code' => $fare_code], ['name' => $fare_code]);
             $this->fareSvc->setForFlight($flight, $fare, $fare_attributes);
-            $fare->save();
         }
     }
 

app/Services/ImportExport/SubfleetImporter.php

@@ -84,9 +84,8 @@ class SubfleetImporter extends ImportExport
                 $fare_attributes = [];
             }
 
-            $fare = Fare::firstOrCreate(['code' => $fare_code], ['name' => $fare_code]);
+            $fare = Fare::updateOrCreate(['code' => $fare_code], ['name' => $fare_code]);
             $this->fareSvc->setForSubfleet($subfleet, $fare, $fare_attributes);
-            $fare->save();
         }
     }
 }

app/Services/UserService.php

@@ -15,7 +15,6 @@ use App\Models\Enums\UserState;
 use App\Models\Pirep;
 use App\Models\Rank;
 use App\Models\Role;
-use App\Models\Typerating;
 use App\Models\User;
 use App\Models\UserFieldValue;
 use App\Repositories\AircraftRepository;
@@ -344,7 +343,7 @@ class UserService extends Service
 
     /**
      * Return the subfleets this user is allowed access to,
-     * based on their current Rank and/or by Type Rating
+     * based on their current rank
      *
      * @param $user
      *
@@ -352,31 +351,14 @@ class UserService extends Service
      */
     public function getAllowableSubfleets($user)
     {
-        $restrict_rank = setting('pireps.restrict_aircraft_to_rank', true);
-        $restrict_type = setting('pireps.restrict_aircraft_to_typerating', false);
-        $restricted_to = [];
-
-        if ($user) {
-            $rank_sf_array = $restrict_rank ? $user->rank->subfleets()->pluck('id')->toArray() : [];
-            $type_sf_array = $restrict_type ? $user->rated_subfleets->pluck('id')->toArray() : [];
-
-            if ($restrict_rank && !$restrict_type) {
-                $restricted_to = $rank_sf_array;
-            } elseif (!$restrict_rank && $restrict_type) {
-                $restricted_to = $type_sf_array;
-            } elseif ($restrict_rank && $restrict_type) {
-                $restricted_to = array_intersect($rank_sf_array, $type_sf_array);
-            }
+        if ($user === null || setting('pireps.restrict_aircraft_to_rank') === false) {
+            /** @var Collection $subfleets */
+            $subfleets = $this->subfleetRepo->with('aircraft')->all();
         } else {
-            $restrict_rank = false;
-            $restrict_type = false;
+            /** @var Collection $subfleets */
+            $subfleets = $user->rank->subfleets()->with('aircraft')->get();
         }
 
-        // @var Collection $subfleets
-        $subfleets = $this->subfleetRepo->when(($restrict_rank || $restrict_type), function ($query) use ($restricted_to) {
-            return $query->whereIn('id', $restricted_to);
-        })->with('aircraft')->get();
-
         // Map the subfleets with the proper fare information
         return $subfleets->transform(function ($sf, $key) {
             $sf->fares = $this->fareSvc->getForSubfleet($sf);
@@ -416,7 +398,9 @@ class UserService extends Service
             return $user;
         }
 
-        Log::info('User '.$user->ident.' state changing from '.UserState::label($old_state).' to '.UserState::label($user->state));
+        Log::info('User '.$user->ident.' state changing from '
+            .UserState::label($old_state).' to '
+            .UserState::label($user->state));
 
         event(new UserStateChanged($user, $old_state));
 
@@ -577,39 +561,11 @@ class UserService extends Service
         // Recalc the rank
         $this->calculatePilotRank($user);
 
-        Log::info('User '.$user->ident.' updated; pirep count='.$pirep_count.', rank='.$user->rank->name.', flight_time='.$user->flight_time.' minutes');
+        Log::info('User '.$user->ident.' updated; pirep count='.$pirep_count
+            .', rank='.$user->rank->name
+            .', flight_time='.$user->flight_time.' minutes');
 
         $user->save();
         return $user;
     }
-
-    /**
-     * Attach a type rating to the user
-     *
-     * @param User       $user
-     * @param Typerating $typerating
-     */
-    public function addUserToTypeRating(User $user, Typerating $typerating)
-    {
-        $user->typeratings()->syncWithoutDetaching([$typerating->id]);
-        $user->save();
-        $user->refresh();
-
-        return $user;
-    }
-
-    /**
-     * Detach a type rating from the user
-     *
-     * @param User       $user
-     * @param Typerating $typerating
-     */
-    public function removeUserFromTypeRating(User $user, Typerating $typerating)
-    {
-        $user->typeratings()->detach($typerating->id);
-        $user->save();
-        $user->refresh();
-
-        return $user;
-    }
 }

app/Support/Database.php

@@ -134,11 +134,6 @@ class Database
                     ->where($id_col, $row[$id_col])
                     ->update($row);
             } else {
-                // Remove ID column if it exists and its empty, let the DB set it
-                /*if (array_key_exists($id_col, $row) && empty($row[$id_col])) {
-                    unset($row[$id_col]);
-                }*/
-
                 DB::table($table)->insert($row);
             }
         } catch (QueryException $e) {

bootstrap/application.php

@@ -39,7 +39,7 @@ class application extends Illuminate\Foundation\Application
         $bootstrappers = array_replace(
             $bootstrappers,
             array_fill_keys(
-                array_keys($bootstrappers, $find, true),
+                array_keys($bootstrappers, $find),
                 $replace
             )
         );

composer.json

@@ -20,12 +20,7 @@
         "symfony/polyfill-mbstring": "*",
         "symfony/polyfill-php74": "*",
         "symfony/polyfill-php80": "*",
-        "symfony/polyfill-php81": "*",
-        "symfony/event-dispatcher-contracts": "^2",
-        "symfony/property-info": "^5.4",
-        "symfony/string": "^5.4",
-        "psr/container": "1.1.1",
-        "composer/composer": "~2.0",
+        "composer/composer": "~1.0",
         "composer/installers": "~1.0",
         "laravel/framework": "~8.0",
         "anhskohbo/no-captcha": "^3.0",
@@ -47,7 +42,7 @@
         "laravelcollective/html": "~6.2.0",
         "jeremykendall/php-domain-parser": "~5.7.2",
         "league/commonmark": "~1.6",
-        "league/csv": "9.7.*",
+        "league/csv": "9.2.*",
         "league/geotools": "0.8.*",
         "league/iso3166": "^3.0.0",
         "markrogoyski/math-php": "^1.10",
@@ -75,15 +70,14 @@
         "queueworker/sansdaemon": "^1.2",
         "jpkleemans/attribute-events": "^1.1",
         "akaunting/laravel-money": "^1.2",
-        "staudenmeir/belongs-to-through": "^2.5",
-        "staudenmeir/eloquent-has-many-deep": "1.14.3"
+        "staudenmeir/belongs-to-through": "^2.5"
     },
     "require-dev": {
         "barryvdh/laravel-debugbar": "^3.5",
-        "barryvdh/laravel-ide-helper": "^2.10",
+        "barryvdh/laravel-ide-helper": "^2.9",
         "bpocallaghan/generators": "~7.0",
         "filp/whoops": "~2.0",
-        "friendsofphp/php-cs-fixer": "^3.3",
+        "friendsofphp/php-cs-fixer": "^2.16",
         "mockery/mockery": "^1.4.0",
         "nunomaduro/collision": "^5.3.0",
         "phpunit/phpunit": "~9.0",
@@ -111,10 +105,7 @@
          "installer-paths": {
              "modules/{$name}/": ["type:phpvms-module"]
          },
-         "module-dir": "modules",
-         "symfony": {
-            "require": "^5.4"
-         }
+         "module-dir": "modules"
     },
     "scripts": {
         "pre-package-uninstall": [

docker-compose.yml

@@ -2,7 +2,7 @@
 version: '3'
 services:
   app:
-    image: nabeelio/phpvms
+    image: phpvms:latest
     environment:
       DB_HOST: mysql
       REDIS_HOST: redis

package-lock.json

@@ -1,5 +1,5 @@
 {
-  "name": "phpvms",
+  "name": "npm-proj-1637278668440-0.3155840252673714Cj2SAC",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
@@ -12,7 +12,7 @@
         "bootstrap": "~4.3",
         "bootstrap-sass": "^3.4.1",
         "bootstrap3": "npm:bootstrap@~3.4",
-        "ckeditor4": "4.14.0",
+        "ckeditor4": "^4.17.0",
         "cookieconsent": "^3.1.0",
         "cross-env": "^5.1.6",
         "eonasdan-bootstrap-datetimepicker": "^4.17.47",
@@ -3030,9 +3030,9 @@
       }
     },
     "node_modules/ckeditor4": {
-      "version": "4.14.0",
-      "resolved": "https://registry.npmjs.org/ckeditor4/-/ckeditor4-4.14.0.tgz",
-      "integrity": "sha512-g5p3bhbxbwB094bE7ss0rOyvG/azYdRjLTyngnPM2+fKZhnPrMVaFDx3SiiWKB+zyvndT3Deu54VTv/z2MQJCA=="
+      "version": "4.17.0",
+      "resolved": "https://registry.npmjs.org/ckeditor4/-/ckeditor4-4.17.0.tgz",
+      "integrity": "sha512-csrwImc6il06rHIxE7SqfOBZE5kWk1u/J+yMJP4HwTikaWOmqGGoYnSajhSJk0/tbDQrWGUInwV428QzKcHyww=="
     },
     "node_modules/class-utils": {
       "version": "0.3.6",
@@ -16466,9 +16466,9 @@
       }
     },
     "ckeditor4": {
-      "version": "4.14.0",
-      "resolved": "https://registry.npmjs.org/ckeditor4/-/ckeditor4-4.14.0.tgz",
-      "integrity": "sha512-g5p3bhbxbwB094bE7ss0rOyvG/azYdRjLTyngnPM2+fKZhnPrMVaFDx3SiiWKB+zyvndT3Deu54VTv/z2MQJCA=="
+      "version": "4.17.0",
+      "resolved": "https://registry.npmjs.org/ckeditor4/-/ckeditor4-4.17.0.tgz",
+      "integrity": "sha512-csrwImc6il06rHIxE7SqfOBZE5kWk1u/J+yMJP4HwTikaWOmqGGoYnSajhSJk0/tbDQrWGUInwV428QzKcHyww=="
     },
     "class-utils": {
       "version": "0.3.6",

package.json

@@ -17,7 +17,7 @@
     "bootstrap": "~4.3",
     "bootstrap-sass": "^3.4.1",
     "bootstrap3": "npm:bootstrap@~3.4",
-    "ckeditor4": "4.14.0",
+    "ckeditor4": "4.17.0",
     "cookieconsent": "^3.1.0",
     "cross-env": "^5.1.6",
     "eonasdan-bootstrap-datetimepicker": "^4.17.47",

resources/views/admin/aircraft/fields.blade.php

@@ -5,7 +5,7 @@
          Subfleet and Status
       </h6>
       <div class="form-container-body row">
-        <div class="form-group col-sm-3">
+        <div class="form-group col-sm-4">
           {{ Form::label('subfleet_id', 'Subfleet:') }}
           {{ Form::select('subfleet_id', $subfleets, $subfleet_id ?? null, [
               'class' => 'form-control select2',
@@ -15,21 +15,17 @@
           <p class="text-danger">{{ $errors->first('subfleet_id') }}</p>
         </div>
 
-        <div class="form-group col-sm-3">
+        <div class="form-group col-sm-4">
           {{ Form::label('status', 'Status:') }}
           {{ Form::select('status', $statuses, null, ['class' => 'form-control select2', 'placeholder' => 'Select Status']) }}
           <p class="text-danger">{{ $errors->first('subfleet_id') }}</p>
         </div>
 
-        <div class="form-group col-sm-3">
-          {{ Form::label('hub_id', 'Hub:') }}
-          {{ Form::select('hub_id', $hubs, null, ['class' => 'form-control select2']) }}
-          <p class="text-danger">{{ $errors->first('hub_id') }}</p>
-        </div>
-
-        <div class="form-group col-sm-3">
+        <div class="form-group col-sm-4">
           {{ Form::label('airport_id', 'Location:') }}
-          {{ Form::select('airport_id', $airports, null, ['class' => 'form-control select2']) }}
+          {{ Form::select('airport_id', $airports, null, [
+              'class' => 'form-control select2'
+              ]) }}
           <p class="text-danger">{{ $errors->first('airport_id') }}</p>
         </div>
       </div>

resources/views/admin/aircraft/table.blade.php

@@ -3,7 +3,6 @@
   <th>Name</th>
   <th style="text-align: center;">Registration</th>
   <th>Subfleet</th>
-  <th style="text-align: center;">Hub</th>
   <th style="text-align: center;">Location</th>
   <th style="text-align: center;">Hours</th>
   <th style="text-align: center;">Active</th>
@@ -23,7 +22,6 @@
           -
         @endif
       </td>
-      <td style="text-align: center;">{{ $ac->hub_id }}</td>
       <td style="text-align: center;">{{ $ac->airport_id }}</td>
       <td style="text-align: center;">
         @minutestotime($ac->flight_time)

resources/views/admin/awards/edit.blade.php

@@ -1,5 +1,5 @@
 @extends('admin.app')
-@section('title', "Edit \"$award->name\" Award")
+@section('title', "Edit \"$award->title\" Award")
 @section('content')
   <div class="card border-blue-bottom">
     <div class="content">

resources/views/admin/awards/fields.blade.php

@@ -18,13 +18,17 @@
     <p class="text-danger">{{ $errors->first('name') }}</p>
   </div>
 
+
   <div class="form-group col-sm-6">
     {!! Form::label('image', 'Image:') !!}
     <div class="callout callout-info">
       <i class="icon fa fa-info">&nbsp;&nbsp;</i>
       This is the image of the award. Be creative!
     </div>
-    {!! Form::text('image_url', null, ['class' => 'form-control', 'placeholder' => 'Enter the url of the image location']) !!}
+    {!! Form::text('image_url', null, [
+            'class' => 'form-control',
+            'placeholder' => 'Enter the url of the image location'
+        ]) !!}
     <p class="text-danger">{{ $errors->first('image_url') }}</p>
   </div>
 </div>
@@ -43,31 +47,29 @@
   <div class="form-group col-sm-6">
     <div>
       {{ Form::label('ref_model', 'Award Class:') }}
-      {{ Form::select('ref_model', $award_classes, null, ['class' => 'form-control select2', 'id' => 'award_class_select']) }}
+      {{ Form::select('ref_model', $award_classes, null , [
+          'class' => 'form-control select2',
+          'id' => 'award_class_select',
+      ]) }}
       <p class="text-danger">{{ $errors->first('ref_model') }}</p>
     </div>
+
     <div>
       {{ Form::label('ref_model_params', 'Award Class parameters') }}
       {{ Form::text('ref_model_params', null, ['class' => 'form-control']) }}
       <p class="text-danger">{{ $errors->first('ref_model_params') }}</p>
-      <p id="ref_model_param_description"></p>
+
+      <p id="ref_model_param_description">
+
+      </p>
     </div>
+
   </div>
 </div>
 
 <div class="row">
-  {{-- Active/Deactive Checkbox --}}
-  <div class="form-group col-sm-6 text-left">
-    <div class="checkbox">
-      <label class="checkbox-inline">
-        {{ Form::label('active', 'Active: ') }}
-        {{ Form::hidden('active', false) }}
-        {{ Form::checkbox('active') }}
-      </label>
-    </div>
-  </div>
-  {{-- Form Actions --}}
-  <div class="form-group col-sm-6">
+  <!-- Submit Field -->
+  <div class="form-group col-sm-12">
     <div class="pull-right">
       {!! Form::button('Save', ['type' => 'submit', 'class' => 'btn btn-success']) !!}
       <a href="{!! route('admin.awards.index') !!}" class="btn btn-warn">Cancel</a>

resources/views/admin/awards/table.blade.php

@@ -1,47 +1,40 @@
 <table class="table table-hover table-responsive" id="awards-table">
   <thead>
-    <th>Name</th>
-    <th>Description</th>
-    <th>Image</th>
-    <th class="text-center">Active</th>
-    <th class="text-right">Action</th>
+  <th>Name</th>
+  <th>Description</th>
+  <th>Image</th>
+  <th class="text-right">Action</th>
   </thead>
   <tbody>
-    @foreach($awards->sortby('name', SORT_NATURAL) as $award)
-      <tr>
-        <td>
-          <a href="{{ route('admin.awards.edit', [$award->id]) }}">{{ $award->name }}</a>
-        </td>
-        <td>
-          {{ $award->description }}
-        </td>
-        <td>
-          @if($award->image_url)
-            <img src="{{ $award->image_url }}" name="{{ $award->name }}" alt="No Image Available" style="height: 100px"/>
-          @else
-            -
-          @endif
-        </td>
-        <td class="text-center">
-          @if($award->active)
-            <i class="fas fa-check-circle fa-2x text-success"></i>
-          @else 
-            <i class="fas fa-times-circle fa-2x text-danger"></i>
-          @endif
-        </td>
-        <td class="text-right">
-          {{ Form::open(['route' => ['admin.awards.destroy', $award->id], 'method' => 'delete']) }}
-          <a href="{{ route('admin.awards.edit', [$award->id]) }}" class='btn btn-sm btn-success btn-icon'>
-            <i class="fas fa-pencil-alt"></i>
-          </a>
-          {{ Form::button('<i class="fa fa-times"></i>', [
-                  'type' => 'submit',
-                  'class' => 'btn btn-sm btn-danger btn-icon',
-                  'onclick' => "return confirm('Are you sure you want to delete this award?')"
-          ]) }}
-          {{ Form::close() }}
-        </td>
-      </tr>
-    @endforeach
+  @foreach($awards as $award)
+    <tr>
+      <td>
+        <a href="{{ route('admin.awards.edit', [$award->id]) }}">
+          {{ $award->name }}</a>
+      </td>
+      <td>{{ $award->description }}</td>
+      <td>
+
+        @if($award->image_url)
+          <img src="{{ $award->image_url }}" name="{{ $award->name }}" alt="No Image Available" style="height: 100px"/>
+        @else
+          -
+        @endif
+      </td>
+      <td class="text-right">
+        {{ Form::open(['route' => ['admin.awards.destroy', $award->id], 'method' => 'delete']) }}
+        <a href="{{ route('admin.awards.edit', [$award->id]) }}" class='btn btn-sm btn-success btn-icon'>
+          <i class="fas fa-pencil-alt"></i></a>
+
+        {{ Form::button('<i class="fa fa-times"></i>', [
+                'type' => 'submit',
+                'class' => 'btn btn-sm btn-danger btn-icon',
+                'onclick' => "return confirm('Are you sure you want to delete this award?')"
+        ]) }}
+
+        {{ Form::close() }}
+      </td>
+    </tr>
+  @endforeach
   </tbody>
-</table>
+</table>

resources/views/admin/flights/index.blade.php

@@ -2,15 +2,8 @@
 @section('title', 'Flights')
 
 @section('actions')
-  <li>
-    <a href="{{ route('admin.flights.export') }}@if(request()->get('airline_id')){{ '?airline_id='.request()->get('airline_id') }}@endif">
-      <i class="ti-plus"></i>
-      Export to CSV @if(request()->get('airline_id')) (Selected Airline) @endif
-    </a>
-  </li>
-  <li>
-    <a href="{{ route('admin.flights.import') }}"><i class="ti-plus"></i>Import from CSV</a>
-  </li>
+  <li><a href="{{ route('admin.flights.export') }}"><i class="ti-plus"></i>Export to CSV</a></li>
+  <li><a href="{{ route('admin.flights.import') }}"><i class="ti-plus"></i>Import from CSV</a></li>
   <li>
     <a href="{{ route('admin.flights.create') }}">
       <i class="ti-plus"></i>

resources/views/admin/menu.blade.php

@@ -62,10 +62,6 @@
       <li><a href="{{ url('/admin/ranks') }}"><i class="pe-7s-graph1"></i>ranks</a></li>
       @endability
 
-      @ability('admin', 'typeratings')
-      <li><a href="{{ url('/admin/typeratings') }}"><i class="pe-7s-plane"></i>type ratings</a></li>
-      @endability
-
       @ability('admin', 'awards')
       <li><a href="{!! url('/admin/awards') !!}"><i class="pe-7s-diamond"></i>awards</a></li>
       @endability

resources/views/admin/subfleets/edit.blade.php

@@ -16,12 +16,6 @@
     </div>
   </div>
 
-  <div class="card border-blue-bottom">
-    <div class="content">
-      @include('admin.subfleets.type_ratings')
-    </div>
-  </div>
-
   <div class="card border-blue-bottom">
     <div class="content">
       @include('admin.subfleets.fares')

resources/views/admin/subfleets/script.blade.php

@@ -114,12 +114,6 @@
         $.pjax.submit(event, '#subfleet_ranks_wrapper', {push: false});
       });
 
-      $(document).on('submit', 'form.modify_typerating', function (event) {
-        event.preventDefault();
-        console.log(event);
-        $.pjax.submit(event, '#subfleet_typeratings_wrapper', {push: false});
-      });
-
       $(document).on('submit', 'form.modify_expense', function (event) {
         event.preventDefault();
         console.log(event);

resources/views/admin/subfleets/table.blade.php

@@ -4,7 +4,6 @@
     <th>Name</th>
     <th>Airline</th>
     <th>Type</th>
-    <th>Hub</th>
     <th>Aircraft</th>
     <th></th>
     </thead>
@@ -18,7 +17,6 @@
         </td>
         <td>{{ optional($subfleet->airline)->name }}</td>
         <td>{{ $subfleet->type }}</td>
-        <td>{{ $subfleet->hub_id }}</td>
         <td>{{ $subfleet->aircraft->count() }}</td>
         <td class="text-right">
           {{ Form::open(['route' => ['admin.subfleets.destroy', $subfleet->id], 'method' => 'delete']) }}

resources/views/admin/subfleets/type_ratings.blade.php

@@ -1,45 +0,0 @@
-<div id="subfleet_typeratings_wrapper" class="dataTables_wrapper form-inline dt-bootstrap">
-  <div class="header">
-    <h3>type ratings</h3>
-    @component('admin.components.info')
-      These type ratings are allowed to fly aircraft in this subfleet.
-    @endcomponent
-  </div>
-  <br/>
-  <table id="subfleet_ranks" class="table table-hover">
-    @if(count($subfleet->typeratings))
-      <thead>
-        <tr>
-          <th>Type</th>
-          <th>Name</th>
-          <th></th>
-        </tr>
-      </thead>
-    @endif
-    <tbody>
-      @foreach($subfleet->typeratings as $tr)
-        <tr>
-          <td class="sorting_1">{{ $tr->type }}</td>
-          <td>{{ $tr->name }}</td>
-          <td style="text-align: right; width:3%;">
-            {{ Form::open(['url' => '/admin/subfleets/'.$subfleet->id.'/typeratings', 'method' => 'delete', 'class' => 'modify_typerating']) }}
-            {{ Form::hidden('typerating_id', $tr->id) }}
-            {{ Form::button('<i class="fa fa-times"></i>', ['type' => 'submit', 'class' => 'btn btn-sm btn-danger btn-icon']) }}
-            {{ Form::close() }}
-          </td>
-        </tr>
-      @endforeach
-    </tbody>
-  </table>
-  <hr/>
-  <div class="row">
-    <div class="col-xs-12">
-      <div class="text-right">
-        {{ Form::open(['url' => '/admin/subfleets/'.$subfleet->id.'/typeratings', 'method' => 'post', 'class' => 'modify_typerating form-inline']) }}
-        {{ Form::select('typerating_id', $avail_ratings, null, ['placeholder' => 'Select Type Rating', 'class' => 'ac-fare-dropdown form-control input-lg select2']) }}
-        {{ Form::button('<i class="glyphicon glyphicon-plus"></i> add', ['type' => 'submit', 'class' => 'btn btn-success btn-s']) }}
-        {{ Form::close() }}
-      </div>
-    </div>
-  </div>
-</div>

resources/views/admin/typeratings/create.blade.php

@@ -1,12 +0,0 @@
-@extends('admin.app')
-@section('title', 'Add Type Rating')
-@section('content')
-  <div class="card border-blue-bottom">
-    <div class="content">
-      {{ Form::open(['route' => 'admin.typeratings.store', 'class' => 'add_typerating', 'method'=>'POST', 'autocomplete' => false]) }}
-      @include('admin.typeratings.fields')
-      {{ Form::close() }}
-    </div>
-  </div>
-@endsection
-@include('admin.typeratings.scripts')

resources/views/admin/typeratings/edit.blade.php

@@ -1,26 +0,0 @@
-@extends('admin.app')
-@section('title', 'Edit '.$typerating->name)
-@section('content')
-  <div class="card border-blue-bottom">
-    <div class="content">
-      {{ Form::model($typerating, ['route' => ['admin.typeratings.update', $typerating->id], 'method' => 'patch', 'autocomplete' => false]) }}
-      @include('admin.typeratings.fields')
-      {{ Form::close() }}
-    </div>
-  </div>
-
-  <div class="card border-blue-bottom">
-    <div class="content">
-      <div class="header">
-        <h3>Subfleets</h3>
-        @component('admin.components.info')
-          These are the subfleets this type rating is allowed to use.
-        @endcomponent
-      </div>
-      <div class="row">
-        @include('admin.typeratings.subfleets')
-      </div>
-    </div>
-  </div>
-@endsection
-@include('admin.typeratings.scripts')

resources/views/admin/typeratings/fields.blade.php

@@ -1,42 +0,0 @@
-<div class="row">
-  <div class="form-group col-sm-7">
-    {{ Form::label('name', 'Name:') }}
-    {{ Form::text('name', null, ['class' => 'form-control']) }}
-    <p class="text-danger">{{ $errors->first('name') }}</p>
-  </div>
-  <div class="form-group col-sm-5">
-    {{ Form::label('type', 'Type Code:') }}
-    {{ Form::text('type', null, ['class' => 'form-control']) }}
-    <p class="text-danger">{{ $errors->first('type') }}</p>
-  </div>
-</div>
-
-<div class="row">
-  <div class="form-group col-sm-7">
-    {{ Form::label('description', 'Description:') }}
-    {{ Form::text('description', null, ['class' => 'form-control']) }}
-    <p class="text-danger">{{ $errors->first('description') }}</p>
-  </div>
-  <div class="form-group col-sm-5">
-    {{ Form::label('image_url', 'Image Link:') }}
-    {{ Form::text('image_url', null, ['class' => 'form-control']) }}
-    <p class="text-danger">{{ $errors->first('image_url') }}</p>
-  </div>
-</div>
-
-<div class="row">
-  <div class="form-group col-sm-3">
-    <div class="checkbox">
-      <label class="checkbox-inline">
-        {{ Form::label('active', 'Active:') }}
-        {{ Form::hidden('active', false) }}
-        {{ Form::checkbox('active') }}
-      </label>
-    </div>
-  </div>
-  <div class="col-sm-9">
-    <div class="text-right">
-      {{ Form::button('Save', ['type' => 'submit', 'class' => 'btn btn-success']) }}
-    </div>
-  </div>
-</div>

resources/views/admin/typeratings/index.blade.php

@@ -1,18 +0,0 @@
-@extends('admin.app')
-@section('title', 'Type Ratings')
-@section('actions')
-  <li>
-    <a href="{{ route('admin.typeratings.create') }}">
-      <i class="ti-plus"></i>
-      Add New
-    </a>
-  </li>
-@endsection
-
-@section('content')
-  <div class="card border-blue-bottom">
-    <div class="content">
-      @include('admin.typeratings.table')
-    </div>
-  </div>
-@endsection

resources/views/admin/typeratings/scripts.blade.php

@@ -1,48 +0,0 @@
-@section('scripts')
-  <script>
-    function setEditable() {
-
-      const token = $('meta[name="csrf-token"]').attr('content');
-      const api_key = $('meta[name="api-key"]').attr('content');
-
-      @if(isset($typerating))
-      $('#subfleets-table a').editable({
-        type: 'text',
-        mode: 'inline',
-        emptytext: 'inherited',
-        url: '{{ url('/admin/typerating/'.$typerating->id.'/subfleets') }}',
-        title: 'Enter override value',
-        ajaxOptions: {
-          type: 'put',
-          headers: {
-            'x-api-key': api_key,
-            'X-CSRF-TOKEN': token,
-          }
-        },
-        params: function (params) {
-          return {
-            subfleet_id: params.pk,
-            name: params.name,
-            value: params.value
-          }
-        }
-      });
-      @endif
-    }
-
-    $(document).ready(function () {
-
-      setEditable();
-
-      $(document).on('submit', 'form.pjax_form', function (event) {
-        event.preventDefault();
-        $.pjax.submit(event, '#typerating_subfleet_wrapper', {push: false});
-      });
-
-      $(document).on('pjax:complete', function () {
-        initPlugins();
-        setEditable();
-      });
-    });
-  </script>
-@endsection

resources/views/admin/typeratings/show.blade.php

@@ -1,17 +0,0 @@
-@extends('admin.app')
-
-@section('content')
-  <section class="content-header">
-    <h1>{{ $typerating->name }}</h1>
-  </section>
-  <div class="content">
-    <div class="box box-primary">
-      <div class="box-body">
-        <div class="row" style="padding-left: 20px">
-          @include('admin.typerating.show_fields')
-        </div>
-      </div>
-    </div>
-  </div>
-@endsection
-@include('admin.typerating.scripts')

resources/views/admin/typeratings/show_fields.blade.php

@@ -1,42 +0,0 @@
-<!-- Id Field -->
-<div class="form-group">
-  {{ Form::label('id', 'Id:') }}
-  <p>{{ $typerating->id }}</p>
-</div>
-
-<!-- Name Field -->
-<div class="form-group">
-  {{ Form::label('name', 'Name:') }}
-  <p>{{ $typerating->name }}</p>
-</div>
-
-<!-- Type Code Field -->
-<div class="form-group">
-  {{ Form::label('type', 'Type Code:') }}
-  <p>{{ $typerating->type }}</p>
-</div>
-
-<!-- Description Field -->
-<div class="form-group">
-  {{ Form::label('description', 'Description:') }}
-  <p>{{ $typerating->description }}</p>
-</div>
-
-<!-- Image URL Field -->
-<div class="form-group">
-  {{ Form::label('image_url', 'Image URL:') }}
-  <p>{{ $typerating->image_url }}</p>
-</div>
-
-<!-- Created At Field -->
-<div class="form-group">
-  {{ Form::label('created_at', 'Created At:') }}
-  <p>{{ show_datetime($typerating->created_at) }}</p>
-</div>
-
-<!-- Updated At Field -->
-<div class="form-group">
-  {{ Form::label('updated_at', 'Updated At:') }}
-  <p>{{ show_datetime($typerating->updated_at) }}</p>
-</div>
-

resources/views/admin/typeratings/subfleets.blade.php

@@ -1,54 +0,0 @@
-<div id="typerating_subfleet_wrapper" class="dataTables_wrapper form-inline dt-bootstrap col-lg-12">
-  @if(count($typerating->subfleets) === 0)
-    @include('admin.common.none_added', ['type' => 'subfleets'])
-  @endif
-
-  <table class="table table-responsive" id="subfleets-table">
-    @if(count($typerating->subfleets))
-      <thead>
-      <th>Airline</th>
-      <th>Name</th>
-      <th style="text-align: center;">Actions</th>
-      </thead>
-    @endif
-    <tbody>
-    @foreach($typerating->subfleets as $sf)
-      <tr>
-        <td>{{ $sf->airline->name }}</td>
-        <td>{{ $sf->name.' ('.$sf->type.')' }}</td>
-        <td style="width: 10%; text-align: center;" class="form-inline">
-          {{ Form::open(['url' => '/admin/typeratings/'.$typerating->id.'/subfleets', 'method' => 'delete', 'class' => 'pjax_form']) }}
-          {{ Form::hidden('subfleet_id', $sf->id) }}
-          <div class='btn-group'>
-            {{ Form::button('<i class="fa fa-times"></i>',
-                             ['type' => 'submit',
-                              'class' => 'btn btn-sm btn-danger btn-icon'])
-              }}
-          </div>
-          {{ Form::close() }}
-        </td>
-      </tr>
-    @endforeach
-    </tbody>
-  </table>
-  <hr/>
-  <div class="row">
-    <div class="col-lg-12">
-      <div class="input-group input-group-lg pull-right">
-        {{ Form::open(['url' => url('/admin/typeratings/'.$typerating->id.'/subfleets'),
-                        'method' => 'post',
-                        'class' => 'pjax_form form-inline'
-                        ])
-        }}
-        {{ Form::select('subfleet_id', $avail_subfleets, null, [
-                'placeholder' => 'Select Subfleet',
-                'class' => 'select2 form-control input-lg'])
-        }}
-        {{ Form::button('<i class="fa fa-plus"></i> Add',
-                         ['type' => 'submit',
-                          'class' => 'btn btn-success btn-small']) }}
-        {{ Form::close() }}
-      </div>
-    </div>
-  </div>
-</div>

resources/views/admin/typeratings/table.blade.php

@@ -1,26 +0,0 @@
-<div id="typeratings_table_wrapper">
-  <table class="table table-hover table-responsive">
-    <thead>
-      <th>Type Code</th>
-      <th>Name</th>
-      <th>Description</th>
-      <th></th>
-    </thead>
-    <tbody>
-      @foreach($typeratings as $typerating)
-        <tr>
-          <td><a href="{{ route('admin.typeratings.edit', [$typerating->id]) }}">{{ $typerating->type }}</a></td>
-          <td>{{ $typerating->name }}</td>
-          <td>{{ $typerating->description }}</td>
-          <td class="text-right">
-            {{ Form::open(['route' => ['admin.typeratings.destroy', $typerating->id], 'method' => 'delete']) }}
-            <a href="{{ route('admin.typeratings.edit', [$typerating->id]) }}" class='btn btn-sm btn-success btn-icon'>
-              <i class="fas fa-pencil-alt"></i></a>
-            {{ Form::button('<i class="fa fa-times"></i>', ['type' => 'submit', 'class' => 'btn btn-sm btn-danger btn-icon', 'onclick' => "return confirm('Are you sure?')"]) }}
-            {{ Form::close() }}
-          </td>
-        </tr>
-      @endforeach
-    </tbody>
-  </table>
-</div>

resources/views/admin/users/edit.blade.php

@@ -9,15 +9,6 @@
     </div>
   </div>
 
-  <div class="card border-blue-bottom">
-    <div class="content">
-      <div class="header">
-        <h3>Type Ratings</h3>
-      </div>
-      @include('admin.users.type_ratings')
-    </div>
-  </div>
-
   <div class="card border-blue-bottom">
     <div class="content">
       <div class="header">
@@ -43,4 +34,3 @@
     </div>
   </div>
 @endsection
-@include('admin.users.script')

resources/views/admin/users/script.blade.php

@@ -1,25 +0,0 @@
-@section('scripts')
-  <script>
-    function setEditable() {
-
-      const token = $('meta[name="csrf-token"]').attr('content');
-      const api_key = $('meta[name="api-key"]').attr('content');
-    }
-
-    $(document).ready(function () {
-
-      setEditable();
-
-      $(document).on('submit', 'form.modify_typerating', function (event) {
-        event.preventDefault();
-        console.log(event);
-        $.pjax.submit(event, '#user_typeratings_wrapper', {push: false});
-      });
-
-      $(document).on('pjax:complete', function () {
-        initPlugins();
-        setEditable();
-      });
-    });
-  </script>
-@endsection

resources/views/admin/users/type_ratings.blade.php

@@ -1,38 +0,0 @@
-<div id="user_typeratings_wrapper" class="dataTables_wrapper form-inline dt-bootstrap">
-  <table id="user_typeratings" class="table table-hover">
-    @if(count($user->typeratings))
-      <thead>
-        <tr>
-          <th>Type</th>
-          <th>Name</th>
-          <th></th>
-        </tr>
-      </thead>
-    @endif
-    <tbody>
-      @foreach($user->typeratings as $tr)
-        <tr>
-          <td class="sorting_1">{{ $tr->type }}</td>
-          <td>{{ $tr->name }}</td>
-          <td style="text-align: right; width:3%;">
-            {{ Form::open(['url' => '/admin/users/'.$user->id.'/typeratings', 'method' => 'delete', 'class' => 'modify_typerating']) }}
-            {{ Form::hidden('typerating_id', $tr->id) }}
-            {{ Form::button('<i class="fa fa-times"></i>', ['type' => 'submit', 'class' => 'btn btn-sm btn-danger btn-icon']) }}
-            {{ Form::close() }}
-          </td>
-        </tr>
-      @endforeach
-    </tbody>
-  </table>
-  <hr/>
-  <div class="row">
-    <div class="col-xs-12">
-      <div class="text-right">
-        {{ Form::open(['url' => '/admin/users/'.$user->id.'/typeratings', 'method' => 'post', 'class' => 'modify_typerating form-inline']) }}
-        {{ Form::select('typerating_id', $avail_ratings, null, ['placeholder' => 'Select Type Rating', 'class' => 'ac-fare-dropdown form-control input-lg select2']) }}
-        {{ Form::button('<i class="glyphicon glyphicon-plus"></i> add', ['type' => 'submit', 'class' => 'btn btn-success btn-s']) }}
-        {{ Form::close() }}
-      </div>
-    </div>
-  </div>
-</div>

resources/views/layouts/default/widgets/live_map.blade.php

@@ -114,7 +114,6 @@ and being mindful of the rivets bindings
       center: ['{{ $center[0] }}', '{{ $center[1] }}'],
       zoom: '{{ $zoom }}',
       aircraft_icon: '{!! public_asset('/assets/img/acars/aircraft.png') !!}',
-      refresh_interval: {{ setting('acars.update_interval', 60) }},
       units: '{{ setting('units.distance') }}',
       leafletOptions: {
         scrollWheelZoom: false,

resources/views/layouts/default/widgets/weather.blade.php

@@ -14,7 +14,7 @@ https://api.checkwx.com/#metar-decoded
       <td>@lang('widgets.weather.wind')</td>
       <td>
         @if($metar['wind_speed'] < '1') Calm @else {{ $metar['wind_speed'] }} kts @lang('common.from') {{ $metar['wind_direction_label'] }} ({{ $metar['wind_direction']}}&deg;) @endif
-        @if($metar['wind_gust_speed']) @lang('widgets.weather.guststo') {{ $metar['wind_gust_speed'] }} @endif
+				@if($metar['wind_gust_speed']) @lang('widgets.weather.guststo') {{ $metar['wind_gust_speed'] }} @endif
       </td>
     </tr>
     @if($metar['visibility'])
@@ -24,62 +24,58 @@ https://api.checkwx.com/#metar-decoded
      </tr>
     @endif
     @if($metar['runways_visual_range'])
-     <tr>
-      <td>Runway Visual Range</td>
-      <td>
-        @foreach($metar['runways_visual_range'] as $rvr)
-          <b>RWY{{ $rvr['runway'] }}</b>; {{ $rvr['report'] }}<br>
-        @endforeach
-      </td>
-     </tr>
-    @endif
-    @if($metar['present_weather_report'] && $metar['present_weather_report'] <> 'Dry')
-     <tr>
-      <td>Phenomena</td>
-      <td>{{ $metar['present_weather_report'] }}</td>
-     </tr>
-    @endif
+		 <tr>
+			<td>Runway Visual Range</td>
+			<td>
+			  @foreach($metar['runways_visual_range'] as $rvr)
+			    <b>RWY{{ $rvr['runway'] }}</b>; {{ $rvr['report'] }}<br>
+			  @endforeach
+			</td>
+		 </tr>
+		@endif
+    @if($metar['present_weather_report'] <> 'Dry')
+		 <tr>
+			<td>Phenomena</td>
+			<td>{{ $metar['present_weather_report'] }}</td>
+		 </tr>
+		@endif
     @if($metar['clouds'] || $metar['cavok'])
-     <tr>
-      <td>@lang('widgets.weather.clouds')</td>
-      <td>
-        @if($unit_alt === 'ft') {{ $metar['clouds_report_ft'] }} @else {{ $metar['clouds_report'] }} @endif 
-        @if($metar['cavok'] == 1) Ceiling and Visibility OK @endif
-      </td>
-     </tr>
-    @endif
-    @if($metar['temperature'])
-      <tr>
-        <td>@lang('widgets.weather.temp')</td>
-        <td>
-          @if($metar['temperature'][$unit_temp]) {{ $metar['temperature'][$unit_temp] }} @else 0 @endif &deg;{{strtoupper($unit_temp)}}
-          @if($metar['dew_point']), @lang('widgets.weather.dewpoint') @if($metar['dew_point'][$unit_temp]) {{ $metar['dew_point'][$unit_temp] }} @else 0 @endif &deg;{{strtoupper($unit_temp)}} @endif 
-          @if($metar['humidity']), @lang('widgets.weather.humidity') {{ $metar['humidity'] }}%  @endif
-        </td>
-      </tr>
-    @endif
-    @if($metar['barometer'])
-      <tr>
-        <td>@lang('widgets.weather.barometer')</td>
-        <td>{{ number_format($metar['barometer']['hPa']) }} hPa / {{ number_format($metar['barometer']['inHg'], 2) }} inHg</td>
-      </tr>
-    @endif
+		 <tr>
+			<td>@lang('widgets.weather.clouds')</td>
+			<td>
+				@if($unit_alt === 'ft') {{ $metar['clouds_report_ft'] }} @else {{ $metar['clouds_report'] }} @endif 
+				@if($metar['cavok'] == 1) Ceiling and Visibility OK @endif
+			</td>
+		 </tr>
+		@endif
+    <tr>
+			<td>@lang('widgets.weather.temp')</td>
+			<td>
+        @if($metar['temperature'][$unit_temp]) {{ $metar['temperature'][$unit_temp] }} @else 0 @endif &deg;{{strtoupper($unit_temp)}}
+				@if($metar['dew_point']), @lang('widgets.weather.dewpoint') @if($metar['dew_point'][$unit_temp]) {{ $metar['dew_point'][$unit_temp] }} @else 0 @endif &deg;{{strtoupper($unit_temp)}} @endif 
+				@if($metar['humidity']), @lang('widgets.weather.humidity') {{ $metar['humidity'] }}%  @endif
+			</td>
+		</tr>
+    <tr>
+      <td>@lang('widgets.weather.barometer')</td>
+      <td>{{ number_format($metar['barometer']['hPa']) }} hPa / {{ number_format($metar['barometer']['inHg'], 2) }} inHg</td>
+    </tr>
     @if($metar['recent_weather_report'])
-     <tr>
-      <td>Recent Phenomena</td>
-      <td>{{ $metar['recent_weather_report'] }}</td>
-     </tr>
-    @endif
-    @if($metar['runways_report'])
-     <tr>
-      <td>Runway Condition</td>
-      <td>
-        @foreach($metar['runways_report'] as $runway)
-          <b>RWY{{ $runway['runway'] }}</b>; {{ $runway['report'] }}<br>
-        @endforeach
-      </td>
-     </tr>	
-    @endif
+		 <tr>
+			<td>Recent Phenomena</td>
+			<td>{{ $metar['recent_weather_report'] }}</td>
+		 </tr>
+		@endif
+		@if($metar['runways_report'])
+		 <tr>
+			<td>Runway Condition</td>
+			<td>
+			  @foreach($metar['runways_report'] as $runway)
+			    <b>RWY{{ $runway['runway'] }}</b>; {{ $runway['report'] }}<br>
+			  @endforeach
+			</td>
+		 </tr>	
+		@endif
     @if($metar['remarks'])
       <tr>
         <td>@lang('widgets.weather.remarks')</td>

tests/VersionTest.php

@@ -38,7 +38,7 @@ class VersionTest extends TestCase
 
             $this->assertTrue(
                 $versionSvc->isGreaterThan($newVersion, $currentVersion),
-                "$newVersion not greater than $currentVersion"
+                "{$newVersion} not greater than ${currentVersion}"
             );
         }
     }

tests/data/aircraft-update.csv

@@ -1,3 +1,3 @@
-subfleet,iata,icao,hub_id,airport_id,name,registration,hex_code,mtow,zfw,status
-A32X,A320,320,,,A320-211,N309US,,,,S
-74X,747 400,, ,,,
+subfleet,iata, icao,airport_id, name,registration,hex_code,mtow,zfw,status
+A32X,A320,320,,A320-211,N309US,,,,S
+74X,747 400, ,,,

tests/data/aircraft.csv

@@ -1,3 +1,3 @@
-subfleet,iata,icao,hub_id,airport_id,name,registration,hex_code,mtow,zfw,status
-A32X,A320,320,,,A320-211,N309US,,,,A
-74X,747 400,,, ,,
+subfleet,iata, icao,airport_id, name,registration,hex_code,mtow,zfw,status
+A32X,A320,320,,A320-211,N309US,,,,A
+74X,747 400,, ,,

tests/data/aircraft_empty_cols.csv

@@ -1,3 +1,3 @@
-subfleet,iata,icao,hub_id,airport_id,name,registration,hex_code,mtow,zfw,status
-A32X,A320-211,,,N309US,,,
- , B744-GE,,, N304,,,
+subfleet,iata, icao,airport_id, name,registration,hex_code,mtow,zfw,status
+A32X,A320-211,,N309US,,,
+ , B744-GE,, N304,,,