Update simbrief_briefing.blade.php (#1497)

Change in blade forms to SimBrief provided direct links.

.github/scripts/build.sh

@@ -15,7 +15,10 @@ declare -a remove_files=(
   .idea
   .travis
   docker
+  node_modules
+  vendor/willdurand/geocoder/tests
   _ide_helper.php
+  .env
   .dockerignore
   .dpl
   .editorconfig
@@ -23,6 +26,7 @@ declare -a remove_files=(
   .eslintrc
   .php_cs
   .php_cs.cache
+  .php-cs-fixer.php
   .phpstorm.meta.php
   .styleci.yml
   .phpunit.result.cache
@@ -37,9 +41,8 @@ declare -a remove_files=(
   phpvms.iml
   Procfile
   phpstan.neon
-  node_modules
+  symfony.lock
   composer.phar
-  vendor/willdurand/geocoder/tests
 )
 
 for file in "${remove_files[@]}"; do
@@ -70,14 +73,22 @@ mkdir -p storage/framework/views
 
 cd /tmp
 
+echo "Current directory contents"
+ls -al $BASE_DIR
+
+echo "Parent directory contents"
 ls -al $BASE_DIR/../
 
-tar -czf $TAR_NAME -C $BASE_DIR .
+echo "Calling find"
+find $BASE_DIR/../ -type d -maxdepth 2
+
+tar -czf $TAR_NAME -C $BASE_DIR --xform 's:^\./::' . [--show-transformed-names|--show-stored-names]
 sha256sum $TAR_NAME >"$TAR_NAME.sha256"
 
 cd $BASE_DIR;
-zip -r $ZIP_NAME .* *
+zip -r $ZIP_NAME ./
 sha256sum $ZIP_NAME >"$ZIP_NAME.sha256"
+
 mv $ZIP_NAME /tmp
 mv "$ZIP_NAME.sha256" /tmp
 

.github/workflows/build.yml

@@ -2,12 +2,12 @@ name: 'Build'
 on: ['push', 'pull_request', 'workflow_dispatch', 'release']
 jobs:
   build:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: github.repository == 'nabeelio/phpvms'
     strategy:
       fail-fast: true
       matrix:
-        php-versions: ['7.3', '7.4', '8.0']
+        php-versions: ['8.0', '8.1']
     name: PHP ${{ matrix.php-versions }}
     env:
       extensions: intl, pcov, mbstring
@@ -69,6 +69,7 @@ jobs:
       run: |
         php --version
         mysql --version
+        sleep 15
         # Downgrade composer version to 1.x
         composer install --dev --no-interaction --verbose
         cp .github/scripts/env.php env.php
@@ -78,7 +79,8 @@ jobs:
 
     - name: Run Tests
       run: |
-        vendor/bin/php-cs-fixer fix --config=.php_cs -v --dry-run --diff --using-cache=no
+        export PHP_CS_FIXER_IGNORE_ENV=1
+        #vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php -v --dry-run --diff --using-cache=no
         vendor/bin/phpunit --debug --verbose
 
   # This runs after all of the tests, run have run. Creates a cleaned up version of the
@@ -86,7 +88,7 @@ jobs:
   artifacts:
     name: 'Create dev build'
     needs: build
-    runs-on: 'ubuntu-18.04'
+    runs-on: ubuntu-20.04
     if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev'
     steps:
       - name: Checkout
@@ -95,7 +97,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '7.4'
+          php-version: '8.0'
 
       - uses: olegtarasov/get-tag@v2.1
         id: tagName
@@ -116,7 +118,6 @@ jobs:
       - name: 'Install Release Dependencies'
         run: |
           rm -rf vendor
-          sudo npm i tar-to-zip -g
           composer install --no-dev --prefer-dist --no-interaction --verbose
           sudo chmod +x ./.github/scripts/*
 
@@ -149,7 +150,7 @@ jobs:
   release:
     name: 'Create Release'
     needs: build
-    runs-on: 'ubuntu-18.04'
+    runs-on: ubuntu-20.04
     if: startsWith(github.ref, 'refs/tags/')
     steps:
       - name: Checkout
@@ -158,7 +159,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '7.4'
+          php-version: 8.0
 
       - uses: olegtarasov/get-tag@v2.1
         id: tagName
@@ -179,7 +180,6 @@ jobs:
       - name: 'Install Release Dependencies'
         run: |
           rm -rf vendor
-          sudo npm i tar-to-zip -g
           composer install --no-dev --prefer-dist --no-interaction --verbose
           sudo chmod +x ./.github/scripts/*
 

.gitignore

@@ -22,6 +22,7 @@ storage/*.sqlite
 .env.*.php
 .env.php
 .env
+.env.*
 .env.bak
 env.php
 .env.generated
@@ -76,3 +77,14 @@ error_log
 /config.php
 /config.bak.php
 /VERSION
+sync.sh
+
+###> friendsofphp/php-cs-fixer ###
+/.php-cs-fixer.php
+/.php-cs-fixer.cache
+###< friendsofphp/php-cs-fixer ###
+
+###> phpunit/phpunit ###
+/phpunit.xml
+.phpunit.result.cache
+###< phpunit/phpunit ###

.php-cs-fixer.php

@@ -0,0 +1,69 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of PHP CS Fixer.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *     Dariusz Rumiński <dariusz.ruminski@gmail.com>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+$header = <<<'EOF'
+This file is part of PHP CS Fixer.
+(c) Fabien Potencier <fabien@symfony.com>
+    Dariusz Rumiński <dariusz.ruminski@gmail.com>
+This source file is subject to the MIT license that is bundled
+with this source code in the file LICENSE.
+EOF;
+
+$finder = PhpCsFixer\Finder::create()
+    ->ignoreVCSIgnored(true)
+    ->exclude('tests/data')
+    ->exclude('storage')
+    ->exclude('resources')
+    ->in(__DIR__)
+    ->append([
+        __DIR__.'/dev-tools/doc.php',
+        // __DIR__.'/php-cs-fixer', disabled, as we want to be able to run bootstrap file even on lower PHP version, to show nice message
+        __FILE__,
+    ])
+;
+
+$config = new PhpCsFixer\Config();
+$config
+    ->setRiskyAllowed(true)
+    ->setRules([
+        '@PSR2'                             => true,
+        'strict_param'                      => true,
+        'no_php4_constructor'               => true,
+        'no_extra_blank_lines'              => true,
+        'no_superfluous_elseif'             => true,
+        'single_line_comment_style'         => false,
+        'simple_to_complex_string_variable' => true,
+        'array_syntax'                      => [
+            'syntax' => 'short',
+        ],
+        'binary_operator_spaces' => [
+            'operators' => [
+                '=>' => 'align_single_space_minimal'
+            ]
+        ],
+        /*
+        'blank_line_before_statement'       => [
+            'statements' => [
+                'declare',
+                'for',
+                'return',
+                'throw',
+                'try',
+            ],
+        ],
+        */
+    ])
+    ->setFinder($finder);
+
+return $config;

.php_cs

@@ -1,37 +0,0 @@
-<?php
-
-$finder = PhpCsFixer\Finder::create()
-    ->in('app')
-    ->in('config');
-
-return PhpCsFixer\Config::create()
-    ->setHideProgress(true)
-    ->setUsingCache(false)
-    ->setRiskyAllowed(true)
-    ->setRules([
-        '@PSR2'                             => true,
-        'strict_param'                      => true,
-        'no_php4_constructor'               => true,
-        'no_extra_blank_lines'              => true,
-        'no_superfluous_elseif'             => true,
-        'single_line_comment_style'         => false,
-        'simple_to_complex_string_variable' => true,
-        'array_syntax'                      => [
-            'syntax' => 'short',
-        ],
-        'binary_operator_spaces'            => [
-            'align_double_arrow' => true,
-        ],
-        /*
-        'blank_line_before_statement'       => [
-            'statements' => [
-                'declare',
-                'for',
-                'return',
-                'throw',
-                'try',
-            ],
-        ],
-        */
-    ])
-    ->setFinder($finder);

Dockerfile

@@ -1,14 +1,15 @@
-FROM php:7.4-fpm-alpine
+FROM php:8.1-fpm-alpine3.15
 
 WORKDIR /var/www/
 
-RUN apk add gmp-dev icu-dev zlib-dev libpng-dev
-RUN curl --silent --show-error https://getcomposer.org/installer | php
+# Setup composer
+COPY --from=composer:2.2.7 /usr/bin/composer /usr/local/bin/composer
+
+RUN apk add gmp-dev icu-dev zlib-dev libpng-dev libzip-dev zip
 
 # Copy any config files in
 COPY resources/docker/php/ext-opcache.ini $PHP_INI_DIR/conf.d/
 COPY resources/docker/php/www.conf /usr/local/etc/php-fpm.d/www.conf
-RUN ln -sf /dev/stderr /var/log/fpm-error.log
 
 RUN docker-php-ext-install \
   calendar \
@@ -16,17 +17,19 @@ RUN docker-php-ext-install \
   pdo_mysql \
   gd \
   gmp \
-  opcache && \
-  docker-php-ext-enable pdo_mysql opcache
+  bcmath \
+  opcache \
+  zip && \
+  docker-php-ext-enable pdo_mysql opcache bcmath zip intl
 
 COPY . /var/www/
-RUN php composer.phar install \
+RUN composer install \
     --ignore-platform-reqs \
     --no-interaction \
     --no-plugins \
     --no-scripts \
     --prefer-dist
 
-RUN chown -R www-data:www-data /var/www
+#RUN chown -R www-data:www-data /var/www
 
 EXPOSE 9000

Makefile

@@ -80,7 +80,7 @@ test:
 
 .PHONY: phpcs
 phpcs:
-	@vendor/bin/php-cs-fixer fix --config=.php_cs -v --diff --diff-format=udiff --dry-run
+	@PHP_CS_FIXER_IGNORE_ENV=1 vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php -v --dry-run --diff --using-cache=no
 
 .PHONY: replay-acars
 replay-acars:
@@ -102,7 +102,7 @@ reset-installer:
 
 .PHONY: docker-test
 docker-test:
-	@docker-compose -f docker-compose.yml -f docker-compose.local.yml up
+	@docker compose -f docker-compose.dev.yml up
 
 .PHONY: docker-clean
 docker-clean:

README.md

@@ -11,7 +11,7 @@ A full distribution, with all of the composer dependencies, is available at this
 
 ### Requirements
 
-- PHP 7.3+, extensions:
+- PHP 8.0+, extensions:
   - cURL
   - JSON
   - mbstring
@@ -39,7 +39,7 @@ make docker-test
 
 # **OR** with docker-compose directly
 
-docker-compose -f docker-compose.yml -f docker-compose.local.yml up
+docker-compose -f docker-compose.yml -f docker-compose.dev.yml up
 ```
 
 Then go to `http://localhost`. If you're using dnsmasq, the `app` container is listening on `phpvms.test`, or you can add to your `/etc/hosts` file:

app/Console/Commands/AcarsReplay.php

@@ -17,25 +17,25 @@ class AcarsReplay extends Command
      *
      * @var string
      */
-    protected $apiKey = 'testadminapikey';
+    protected string $apiKey = 'testadminapikey';
 
     /**
      * For automatic updates, how many seconds to sleep between updates
      *
      * @var int
      */
-    protected $sleepTime = 10;
+    protected int $sleepTime = 10;
 
     /**
      * @var array key == update[callsign]
      *            value == PIREP ID
      */
-    protected $pirepList = [];
+    protected array $pirepList = [];
 
     /**
      * @var Client
      */
-    protected $httpClient;
+    protected Client $httpClient;
 
     /**
      * Return an instance of an HTTP client all ready to post

app/Console/Commands/CreateConfigs.php

@@ -2,11 +2,11 @@
 
 namespace App\Console\Commands;
 
-use App;
 use App\Contracts\Command;
 use App\Services\Installer\ConfigService;
 use App\Services\Installer\SeederService;
 use DatabaseSeeder;
+use Illuminate\Support\Facades\App;
 
 /**
  * Create the config files
@@ -16,8 +16,8 @@ class CreateConfigs extends Command
     protected $signature = 'phpvms:config {db_host} {db_name} {db_user} {db_pass}';
     protected $description = 'Create the config files';
 
-    private $databaseSeeder;
-    private $seederSvc;
+    private DatabaseSeeder $databaseSeeder;
+    private SeederService $seederSvc;
 
     public function __construct(DatabaseSeeder $databaseSeeder, SeederService $seederSvc)
     {

app/Console/Commands/CreateDatabase.php

@@ -11,7 +11,11 @@ class CreateDatabase extends Command
 {
     protected $signature = 'database:create {--reset} {--migrate} {--conn=?}';
     protected $description = 'Create a database';
-    protected $os;
+
+    /**
+     * @var Detector
+     */
+    protected Detector $os;
 
     /**
      * CreateDatabase constructor.

app/Console/Commands/DevCommands.php

@@ -24,7 +24,8 @@ class DevCommands extends Command
 {
     protected $signature = 'phpvms {cmd} {param?}';
     protected $description = 'Developer commands';
-    protected $dbSvc;
+
+    protected DatabaseService $dbSvc;
 
     /**
      * DevCommands constructor.

app/Console/Commands/DevInstall.php

@@ -13,7 +13,7 @@ class DevInstall extends Command
     protected $signature = 'phpvms:dev-install {--reset-db} {--reset-configs}';
     protected $description = 'Run a developer install and run the sample migration';
 
-    private $databaseSeeder;
+    private \DatabaseSeeder $databaseSeeder;
 
     public function __construct(\DatabaseSeeder $databaseSeeder)
     {

app/Console/Commands/ImportCsv.php

@@ -10,7 +10,7 @@ class ImportCsv extends Command
     protected $signature = 'phpvms:csv-import {type} {file}';
     protected $description = 'Import from a CSV file';
 
-    private $importer;
+    private ImportService $importer;
 
     /**
      * Import constructor.

app/Console/Commands/ProcessQueue.php

@@ -18,11 +18,15 @@ class ProcessQueue extends Command
     public function handle()
     {
         Artisan::call('queue:work', [
-            '--sansdaemon'      => null,
+            //'--sansdaemon'      => null,
             '--stop-when-empty' => null,
         ]);
 
-        Log::info(Artisan::output());
+        $jobOutput = trim(Artisan::output());
+        if (!empty($jobOutput)) {
+            Log::info($jobOutput);
+        }
+
         ///** @var App\Support\WorkCommand $queueWorker */
         //$queueWorker = new App\Support\WorkCommand(app('queue.worker'), app('cache.store'));
 

app/Console/Commands/TestApi.php

@@ -8,7 +8,11 @@ use GuzzleHttp\Client;
 class TestApi extends Command
 {
     protected $signature = 'phpvms:test-api {apikey} {url}';
-    protected $httpClient;
+
+    /**
+     * @var Client
+     */
+    protected Client $httpClient;
 
     /**
      * Run dev related commands

app/Console/Commands/Version.php

@@ -10,8 +10,14 @@ class Version extends Command
 {
     protected $signature = 'phpvms:version {--write} {--base-only} {--write-full-version} {version?}';
 
-    private $versionSvc;
+    /**
+     * @var VersionService
+     */
+    private VersionService $versionSvc;
 
+    /**
+     * @param VersionService $versionSvc
+     */
     public function __construct(VersionService $versionSvc)
     {
         parent::__construct();

app/Console/Commands/YamlImport.php

@@ -12,7 +12,11 @@ class YamlImport extends Command
 {
     protected $signature = 'phpvms:yaml-import {files*}';
     protected $description = 'Developer commands';
-    protected $dbSvc;
+
+    /**
+     * @var DatabaseService
+     */
+    protected DatabaseService $dbSvc;
 
     /**
      * YamlImport constructor.

app/Console/Cron.php

@@ -0,0 +1,90 @@
+<?php
+/**
+ * This runs any of the cron tasks that are set to run according to the Laravel schedule
+ */
+
+namespace App\Console;
+
+use App\Console\Cron\FifteenMinute;
+use App\Console\Cron\FiveMinute;
+use App\Console\Cron\Hourly;
+use App\Console\Cron\JobQueue;
+use App\Console\Cron\Monthly;
+use App\Console\Cron\Nightly;
+use App\Console\Cron\ThirtyMinute;
+use App\Console\Cron\Weekly;
+use App\Contracts\Command;
+use Illuminate\Console\Scheduling\Schedule;
+
+class Cron
+{
+    /** @var Schedule */
+    private $scheduler;
+
+    /**
+     * @var string[] The cron tasks which get called/run
+     */
+    private $cronTasks = [
+        JobQueue::class,
+        FiveMinute::class,
+        FifteenMinute::class,
+        ThirtyMinute::class,
+        Hourly::class,
+        Nightly::class,
+        Weekly::class,
+        Monthly::class,
+    ];
+
+    /**
+     * @var array Stores the instantiated cron tasks
+     */
+    private $cronRunners = [];
+
+    /**
+     * @param Schedule $scheduler
+     */
+    public function __construct(Schedule $scheduler)
+    {
+        $this->scheduler = $scheduler;
+        foreach ($this->cronTasks as $task) {
+            /** @var Command $cronTask */
+            $cronTask = app($task);
+            $signature = $cronTask->getSignature();
+
+            if (empty($signature)) {
+                continue;
+            }
+
+            $this->cronRunners[$signature] = $cronTask;
+        }
+    }
+
+    /**
+     * Try to figure out which commands are supposed to run right now
+     *
+     * @return array string of tasks that were run
+     */
+    public function run(): array
+    {
+        $events = $this->scheduler->dueEvents(app());
+        if (empty($events)) {
+            return [];
+        }
+
+        $run = [];
+
+        /** @var \Illuminate\Console\Scheduling\Event $event */
+        foreach ($events as $event) {
+            foreach ($this->cronRunners as $signature => $task) {
+                if (!str_contains($event->command, $signature)) {
+                    continue;
+                }
+
+                $task->callEvent();
+                $run[] = $signature;
+            }
+        }
+
+        return $run;
+    }
+}

app/Console/Cron/FifteenMinute.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace App\Console\Cron;
+
+use App\Contracts\CronCommand;
+use App\Events\CronFifteenMinute;
+
+/**
+ * The actual cron tasks are in app/Cron
+ */
+class FifteenMinute extends CronCommand
+{
+    protected $signature = 'cron:fifteen';
+    protected $description = 'Run the 15 minute cron tasks';
+    protected $schedule;
+
+    public function handle(): void
+    {
+        $this->callEvent();
+    }
+
+    public function callEvent()
+    {
+        event(new CronFifteenMinute());
+    }
+}

app/Console/Cron/FiveMinute.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace App\Console\Cron;
+
+use App\Contracts\CronCommand;
+use App\Events\CronFiveMinute;
+
+/**
+ * This just calls the CronNightly event, so all of the
+ * listeners, etc can just be called to run those tasks
+ *
+ * The actual cron tasks are in app/Cron
+ */
+class FiveMinute extends CronCommand
+{
+    protected $signature = 'cron:five';
+    protected $description = 'Run the 5 minute cron tasks';
+    protected $schedule;
+
+    public function handle(): void
+    {
+        $this->callEvent();
+    }
+
+    public function callEvent()
+    {
+        event(new CronFiveMinute());
+    }
+}

app/Console/Cron/Hourly.php

@@ -2,14 +2,14 @@
 
 namespace App\Console\Cron;
 
-use App\Contracts\Command;
+use App\Contracts\CronCommand;
 use App\Events\CronHourly;
 
 /**
  * This just calls the CronHourly event, so all of the
  * listeners, etc can just be called to run those tasks
  */
-class Hourly extends Command
+class Hourly extends CronCommand
 {
     protected $signature = 'cron:hourly';
     protected $description = 'Run the hourly cron tasks';
@@ -17,7 +17,11 @@ class Hourly extends Command
 
     public function handle(): void
     {
-        $this->redirectLoggingToFile('cron');
+        $this->callEvent();
+    }
+
+    public function callEvent()
+    {
         event(new CronHourly());
     }
 }

app/Console/Cron/JobQueue.php

@@ -2,14 +2,14 @@
 
 namespace App\Console\Cron;
 
-use App\Contracts\Command;
+use App\Contracts\CronCommand;
 use Illuminate\Support\Facades\Artisan;
 
 /**
  * This just calls the CronHourly event, so all of the
  * listeners, etc can just be called to run those tasks
  */
-class JobQueue extends Command
+class JobQueue extends CronCommand
 {
     protected $signature = 'cron:queue';
     protected $description = 'Run the cron queue tasks';
@@ -17,9 +17,16 @@ class JobQueue extends Command
 
     public function handle(): void
     {
-        $this->redirectLoggingToFile('cron');
-        Artisan::call('queue:cron');
+        $this->callEvent();
 
-        $this->info(Artisan::output());
+        $queueOutput = trim(Artisan::output());
+        if (!empty($queueOutput)) {
+            $this->info($queueOutput);
+        }
+    }
+
+    public function callEvent()
+    {
+        Artisan::call('queue:cron');
     }
 }

app/Console/Cron/Monthly.php

@@ -2,7 +2,7 @@
 
 namespace App\Console\Cron;
 
-use App\Contracts\Command;
+use App\Contracts\CronCommand;
 use App\Events\CronMonthly;
 
 /**
@@ -11,7 +11,7 @@ use App\Events\CronMonthly;
  *
  * The actual cron tasks are in app/Cron
  */
-class Monthly extends Command
+class Monthly extends CronCommand
 {
     protected $signature = 'cron:monthly';
     protected $description = 'Run the monthly cron tasks';
@@ -19,7 +19,11 @@ class Monthly extends Command
 
     public function handle(): void
     {
-        $this->redirectLoggingToFile('cron');
+        $this->callEvent();
+    }
+
+    public function callEvent()
+    {
         event(new CronMonthly());
     }
 }

app/Console/Cron/Nightly.php

@@ -2,7 +2,7 @@
 
 namespace App\Console\Cron;
 
-use App\Contracts\Command;
+use App\Contracts\CronCommand;
 use App\Events\CronNightly;
 
 /**
@@ -11,7 +11,7 @@ use App\Events\CronNightly;
  *
  * The actual cron tasks are in app/Cron
  */
-class Nightly extends Command
+class Nightly extends CronCommand
 {
     protected $signature = 'cron:nightly';
     protected $description = 'Run the nightly cron tasks';
@@ -19,7 +19,11 @@ class Nightly extends Command
 
     public function handle(): void
     {
-        $this->redirectLoggingToFile('cron');
+        $this->callEvent();
+    }
+
+    public function callEvent()
+    {
         event(new CronNightly());
     }
 }

app/Console/Cron/ThirtyMinute.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace App\Console\Cron;
+
+use App\Contracts\CronCommand;
+use App\Events\CronThirtyMinute;
+
+/**
+ * The actual cron tasks are in app/Cron
+ */
+class ThirtyMinute extends CronCommand
+{
+    protected $signature = 'cron:thirty';
+    protected $description = 'Run the 30 minute cron tasks';
+    protected $schedule;
+
+    public function handle(): void
+    {
+        $this->callEvent();
+    }
+
+    public function callEvent()
+    {
+        event(new CronThirtyMinute());
+    }
+}

app/Console/Cron/Weekly.php

@@ -2,7 +2,7 @@
 
 namespace App\Console\Cron;
 
-use App\Contracts\Command;
+use App\Contracts\CronCommand;
 use App\Events\CronWeekly;
 
 /**
@@ -11,7 +11,7 @@ use App\Events\CronWeekly;
  *
  * The actual cron tasks are in app/Cron
  */
-class Weekly extends Command
+class Weekly extends CronCommand
 {
     protected $signature = 'cron:weekly';
     protected $description = 'Run the weekly cron tasks';
@@ -19,7 +19,11 @@ class Weekly extends Command
 
     public function handle(): void
     {
-        $this->redirectLoggingToFile('cron');
+        $this->callEvent();
+    }
+
+    public function callEvent()
+    {
         event(new CronWeekly());
     }
 }

app/Console/Kernel.php

@@ -2,10 +2,13 @@
 
 namespace App\Console;
 
+use App\Console\Cron\FifteenMinute;
+use App\Console\Cron\FiveMinute;
 use App\Console\Cron\Hourly;
 use App\Console\Cron\JobQueue;
 use App\Console\Cron\Monthly;
 use App\Console\Cron\Nightly;
+use App\Console\Cron\ThirtyMinute;
 use App\Console\Cron\Weekly;
 use App\Services\CronService;
 use Illuminate\Console\Scheduling\Schedule;
@@ -33,10 +36,16 @@ class Kernel extends ConsoleKernel
                 ->withoutOverlapping();
         }
 
+        /*
+         * NOTE: IF MORE TASKS ARE ADDED, THEY ALSO MUST BE ADDED TO THE CRON.PHP
+         */
+        $schedule->command(FiveMinute::class)->everyFiveMinutes();
+        $schedule->command(FifteenMinute::class)->everyFifteenMinutes();
+        $schedule->command(ThirtyMinute::class)->everyThirtyMinutes();
         $schedule->command(Nightly::class)->dailyAt('01:00');
+        $schedule->command(Hourly::class)->hourly();
         $schedule->command(Weekly::class)->weeklyOn(0);
         $schedule->command(Monthly::class)->monthlyOn(1);
-        $schedule->command(Hourly::class)->hourly();
 
         // When spatie-backups runs
         /*if (config('backup.backup.enabled', false) === true) {

app/Contracts/Award.php

@@ -37,10 +37,10 @@ abstract class Award
      */
 
     /** @var \App\Models\Award|null */
-    protected $award;
+    protected ?AwardModel $award;
 
     /** @var \App\Models\User|null */
-    protected $user;
+    protected ?User $user;
 
     public function __construct(AwardModel $award = null, User $user = null)
     {
@@ -69,9 +69,9 @@ abstract class Award
     /**
      * Add the award to this user, if they don't already have it
      *
-     * @return bool|UserAward
+     * @return bool|UserAward|null
      */
-    protected function addAward()
+    protected function addAward(): bool|UserAward|null
     {
         $w = [
             'user_id'  => $this->user->id,

app/Contracts/Command.php

@@ -29,6 +29,16 @@ abstract class Command extends \Illuminate\Console\Command
         }*/
     }
 
+    /**
+     * Return the signature of the command
+     *
+     * @return string
+     */
+    public function getSignature(): string
+    {
+        return $this->signature;
+    }
+
     /**
      * Splice the logger and replace the active handlers with the handlers from the
      * a stack in config/logging.php

app/Contracts/Controller.php

@@ -84,19 +84,21 @@ abstract class Controller extends \Illuminate\Routing\Controller
      *
      * @param $message
      * @param null|mixed $count
+     * @param mixed      $attrs
      *
      * @return \Illuminate\Http\JsonResponse
      */
-    public function message($message, $count = null)
+    public function message($message, $count = null, $attrs = [])
     {
-        $attrs = [
+        $ret = [
             'message' => $message,
+            'attrs'   => $attrs,
         ];
 
         if ($count !== null) {
-            $attrs['count'] = $count;
+            $ret['count'] = $count;
         }
 
-        return response()->json($attrs);
+        return response()->json($ret);
     }
 }

app/Contracts/CronCommand.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace App\Contracts;
+
+abstract class CronCommand extends Command
+{
+    /**
+     * @return mixed
+     */
+    abstract public function callEvent();
+
+    /**
+     * Adjust the logging depending on where we're running from
+     */
+    public function __construct()
+    {
+        parent::__construct();
+        $this->redirectLoggingToFile('cron');
+    }
+}

app/Contracts/Enum.php

@@ -7,14 +7,14 @@ namespace App\Contracts;
  */
 abstract class Enum
 {
-    protected static $cache = [];
-    protected static $codes = [];
-    protected static $labels = [];
+    protected static array $cache = [];
+    protected static array $codes = [];
+    protected static array $labels = [];
 
     /**
      * @var int
      */
-    protected $value;
+    protected int $value;
 
     /**
      * Create an instance of this Enum
@@ -29,9 +29,9 @@ abstract class Enum
     /**
      * Return the value that's been set if this is an instance
      *
-     * @return mixed
+     * @return int|null
      */
-    final public function getValue()
+    final public function getValue(): ?int
     {
         return $this->value;
     }
@@ -41,9 +41,9 @@ abstract class Enum
      *
      * @param $value
      *
-     * @return mixed
+     * @return string
      */
-    final public static function label($value)
+    final public static function label($value): string
     {
         if (isset(static::$labels[$value])) {
             $val = static::$labels[$value];
@@ -53,6 +53,8 @@ abstract class Enum
 
             return $val;
         }
+
+        return $value;
     }
 
     /**
@@ -87,11 +89,11 @@ abstract class Enum
      *
      * @return false|int|string
      */
-    public static function convertToCode($value)
+    public static function convertToCode($value): bool|int|string|null
     {
         $value = (int) $value;
         if (!array_key_exists($value, static::$codes)) {
-            return;
+            return null;
         }
 
         return static::$codes[$value];

app/Contracts/Factory.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace App\Contracts;
+
+use Illuminate\Database\Eloquent\Factories\Factory as EloquentFactory;
+
+abstract class Factory extends EloquentFactory
+{
+}

app/Contracts/ImportExport.php

@@ -166,6 +166,27 @@ class ImportExport
                 return [];
             }
 
+            if (strpos($split_values[0], '?') !== false) {
+                // This contains the query string, which turns it into a multi-level array
+                $query_str = explode('?', $split_values[0]);
+                $parent = trim($query_str[0]);
+
+                $children = [];
+                $kvp = explode('&', trim($query_str[1]));
+                foreach ($kvp as $items) {
+                    if (!$items) {
+                        continue;
+                    }
+
+                    $this->kvpToArray($items, $children);
+                }
+
+                $ret[$parent] = $children;
+
+                return $ret;
+            }
+
+            // This is not a query string, return it back untouched
             return [$split_values[0]];
         }
 

app/Contracts/Notification.php

@@ -2,7 +2,6 @@
 
 namespace App\Contracts;
 
-use App\Notifications\Channels\Discord\DiscordMessage;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 
@@ -26,24 +25,4 @@ class Notification extends \Illuminate\Notifications\Notification implements Sho
 
         $this->channels = $notif_config[$klass];*/
     }
-
-    /**
-     * Get the notification's delivery channels.
-     *
-     * @param mixed $notifiable
-     *
-     * @return array
-     */
-    /*public function via($notifiable)
-    {
-        return $this->channels;
-    }*/
-
-    /**
-     * @return DiscordMessage|null
-     */
-    public function toDiscordChannel($notifiable): ?DiscordMessage
-    {
-        return null;
-    }
 }

app/Contracts/Repository.php

@@ -133,7 +133,10 @@ abstract class Repository extends BaseRepository
         $page = (int) request()->query('page', 1);
 
         $results = $this->model->{$method}($limit, $columns, 'page', $page);
-        $results->appends(app('request')->query());
+
+        $qs = request()->except(['page', 'user']);
+        $results->appends($qs);
+
         $this->resetModel();
 
         return $this->parserResult($results);

app/Contracts/Unit.php

@@ -3,7 +3,6 @@
 namespace App\Contracts;
 
 use ArrayAccess;
-use PhpUnitsOfMeasure\Exception\UnknownUnitOfMeasure;
 
 /**
  * Abstract unit wrapper
@@ -11,45 +10,89 @@ use PhpUnitsOfMeasure\Exception\UnknownUnitOfMeasure;
 class Unit implements ArrayAccess
 {
     /**
-     * The unit this is kept as
+     * The localized unit the user wants it displayed in
      */
-    public $unit;
+    public string $localUnit;
 
     /**
-     * All of the units of this class
+     * The unit that this value is stored in locally
      */
-    public $units;
+    public string $internalUnit;
+
+    /**
+     * All of the units of this class which are reported in an API response
+     */
+    public array $units;
 
     /**
      * Holds an instance of the PhpUnit type
-     *
-     * @var \PhpUnitsOfMeasure\AbstractPhysicalQuantity
      */
-    protected $instance;
+    protected mixed $instance;
 
     /**
      * Units that are included as part of the REST response
      */
-    public $responseUnits = [];
+    public array $responseUnits = [];
 
     /**
-     * @return mixed
+     * Factory method for creating a new unit type
+     *
+     * @param mixed  $value
+     * @param string $unit
+     *
+     * @throws \Exception
+     *
+     * @return Unit
      */
-    public function value()
+    public static function make(mixed $value, string $unit): self
     {
-        return $this->__toString();
+        if ($value instanceof self) {
+            return $value;
+        }
+
+        return new static($value, $unit);
+    }
+
+    /**
+     * Return the value in an internal format
+     *
+     * @param int|null $round Optional value to round to
+     *
+     * @return float|null
+     */
+    public function internal(?int $round = null): ?float
+    {
+        return $this->toUnit($this->internalUnit, $round);
+    }
+
+    /**
+     * Return the value in the localized format
+     *
+     * @param int|null $round Optional value to round to
+     *
+     * @return float|null
+     */
+    public function local(?int $round = null): ?float
+    {
+        return $this->toUnit($this->localUnit, $round);
     }
 
     /**
      * Just call toUnit() on the PhpUnitOfMeasure instance
      *
-     * @param string $unit
+     * @param string   $unit
+     * @param int|null $round Optional value to round to
      *
-     * @return mixed
+     * @return float|null
      */
-    public function toUnit($unit)
+    public function toUnit(string $unit, ?int $round = null): ?float
     {
-        return $this->instance->toUnit($unit);
+        $val = $this->instance->toUnit($unit);
+        if ($round === null) {
+            return $val;
+        }
+
+        return round($val, $round);
     }
 
     /**
@@ -59,7 +102,7 @@ class Unit implements ArrayAccess
     {
         $response = [];
         foreach ($this->responseUnits as $unit) {
-            $response[$unit] = $this[$unit] ?? 0;
+            $response[$unit] = round($this->instance->toUnit($unit), 2);
         }
 
         return $response;
@@ -72,7 +115,7 @@ class Unit implements ArrayAccess
      *
      * @return bool
      */
-    public function offsetExists($offset)
+    public function offsetExists($offset): bool
     {
         return $this->offsetGet($offset) !== null;
     }
@@ -80,19 +123,15 @@ class Unit implements ArrayAccess
     /**
      * Implements ArrayAccess
      *
-     * @param $offset
+     * @param $unit
      *
-     * @return mixed
+     * @return float|null
      */
-    public function offsetGet($offset)
+    public function offsetGet($unit): ?float
     {
-        try {
-            $value = $this->instance->toUnit($offset);
-            if (!$value) {
-                return;
-            }
-        } catch (UnknownUnitOfMeasure $e) {
-            return;
+        $value = $this->instance->toUnit($unit);
+        if (!$value) {
+            return null;
         }
 
         return round($value, 2);
@@ -124,6 +163,6 @@ class Unit implements ArrayAccess
      */
     public function __toString()
     {
-        return (string) $this->offsetGet($this->unit);
+        return (string) $this->offsetGet($this->localUnit);
     }
 }

app/Cron/Hourly/ClearExpiredSimbrief.php

@@ -12,7 +12,7 @@ use Illuminate\Support\Facades\Log;
  */
 class ClearExpiredSimbrief extends Listener
 {
-    private $simbriefSvc;
+    private SimBriefService $simbriefSvc;
 
     public function __construct(SimBriefService $simbriefSvc)
     {
@@ -20,7 +20,7 @@ class ClearExpiredSimbrief extends Listener
     }
 
     /**
-     * @param \App\Events\CronNightly $event
+     * @param CronHourly $event
      */
     public function handle(CronHourly $event): void
     {

app/Cron/Hourly/RemoveExpiredLiveFlights.php

@@ -6,6 +6,7 @@ use App\Contracts\Listener;
 use App\Events\CronHourly;
 use App\Events\PirepCancelled;
 use App\Models\Enums\PirepState;
+use App\Models\Enums\PirepStatus;
 use App\Models\Pirep;
 use Carbon\Carbon;
 use Illuminate\Support\Facades\Log;
@@ -31,6 +32,7 @@ class RemoveExpiredLiveFlights extends Listener
         $date = Carbon::now('UTC')->subHours(setting('acars.live_time'));
         $pireps = Pirep::where('updated_at', '<', $date)
             ->where('state', PirepState::IN_PROGRESS)
+            ->where('status', '<>', PirepStatus::PAUSED)
             ->get();
 
         foreach ($pireps as $pirep) {

app/Cron/Monthly/ApplyExpenses.php

@@ -13,7 +13,7 @@ use Illuminate\Support\Facades\Log;
  */
 class ApplyExpenses extends Listener
 {
-    private $financeSvc;
+    private RecurringFinanceService $financeSvc;
 
     /**
      * ApplyExpenses constructor.

app/Cron/Nightly/ApplyExpenses.php

@@ -13,7 +13,7 @@ use Illuminate\Support\Facades\Log;
  */
 class ApplyExpenses extends Listener
 {
-    private $financeSvc;
+    private RecurringFinanceService $financeSvc;
 
     /**
      * ApplyExpenses constructor.

app/Cron/Nightly/NewVersionCheck.php

@@ -9,7 +9,7 @@ use Illuminate\Support\Facades\Log;
 
 class NewVersionCheck extends Listener
 {
-    private $versionSvc;
+    private VersionService $versionSvc;
 
     /**
      * @param VersionService $versionSvc

app/Cron/Nightly/PilotLeave.php

@@ -12,7 +12,7 @@ use Illuminate\Support\Facades\Log;
  */
 class PilotLeave extends Listener
 {
-    private $userSvc;
+    private UserService $userSvc;
 
     /**
      * PilotLeave constructor.

app/Cron/Nightly/RecalculateBalances.php

@@ -6,14 +6,14 @@ use App\Contracts\Listener;
 use App\Events\CronNightly;
 use App\Models\Journal;
 use App\Repositories\JournalRepository;
-use Log;
+use Illuminate\Support\Facades\Log;
 
 /**
  * This recalculates the balances on all of the journals
  */
 class RecalculateBalances extends Listener
 {
-    private $journalRepo;
+    private JournalRepository $journalRepo;
 
     /**
      * Nightly constructor.

app/Cron/Nightly/RecalculateStats.php

@@ -13,8 +13,8 @@ use Illuminate\Support\Facades\Log;
  */
 class RecalculateStats extends Listener
 {
-    private $aircraftSvc;
-    private $userSvc;
+    private AircraftService $aircraftSvc;
+    private UserService $userSvc;
 
     public function __construct(AircraftService $aircraftSvc, UserService $userSvc)
     {

app/Database/factories/AcarsFactory.php

@@ -1,23 +1,43 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\Acars::class, function (Faker $faker) {
-    return [
-        'id'          => null,
-        'pirep_id'    => null,
-        'log'         => $faker->text(100),
-        'lat'         => $faker->latitude,
-        'lon'         => $faker->longitude,
-        'distance'    => $faker->randomFloat(2, 0, 6000),
-        'heading'     => $faker->numberBetween(0, 359),
-        'altitude'    => $faker->numberBetween(20, 400),
-        'vs'          => $faker->numberBetween(-5000, 5000),
-        'gs'          => $faker->numberBetween(300, 500),
-        'transponder' => $faker->numberBetween(200, 9999),
-        'autopilot'   => $faker->text(10),
-        'fuel'        => $faker->randomFloat(2, 100, 1000),
-        'fuel_flow'   => $faker->randomFloat(2, 100, 1000),
-        'sim_time'    => $faker->dateTime('now', 'UTC'),
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Acars;
+use DateTime;
+
+class AcarsFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Acars::class;
+
+    /**
+     * @return array <string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'          => null,
+            'pirep_id'    => null,
+            'log'         => $this->faker->text(100),
+            'lat'         => $this->faker->latitude,
+            'lon'         => $this->faker->longitude,
+            'distance'    => $this->faker->randomFloat(2, 0, 6000),
+            'heading'     => $this->faker->numberBetween(0, 359),
+            'altitude'    => $this->faker->numberBetween(20, 400),
+            'vs'          => $this->faker->numberBetween(-5000, 5000),
+            'gs'          => $this->faker->numberBetween(300, 500),
+            'transponder' => $this->faker->numberBetween(200, 9999),
+            'autopilot'   => $this->faker->text(10),
+            'fuel'        => $this->faker->randomFloat(2, 100, 1000),
+            'fuel_flow'   => $this->faker->randomFloat(2, 100, 1000),
+            'sim_time'    => $this->faker->dateTime('now', 'UTC')->format(DateTime::ATOM),
+        ];
+    }
+}

app/Database/factories/AircraftFactory.php

@@ -1,33 +1,51 @@
 <?php
 
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Aircraft;
 use App\Models\Airport;
 use App\Models\Enums\AircraftState;
 use App\Models\Enums\AircraftStatus;
 use App\Models\Subfleet;
 use App\Support\ICAO;
-use Faker\Generator as Faker;
+use DateTime;
 
-$factory->define(App\Models\Aircraft::class, function (Faker $faker) {
-    return [
-        'id'          => null,
-        'subfleet_id' => function () {
-            return factory(Subfleet::class)->create()->id;
-        },
-        'airport_id' => function () {
-            return factory(Airport::class)->create()->id;
-        },
-        'iata'         => $faker->unique()->text(5),
-        'icao'         => $faker->unique()->text(5),
-        'name'         => $faker->text(50),
-        'registration' => $faker->unique()->text(10),
-        'hex_code'     => ICAO::createHexCode(),
-        'mtow'         => $faker->randomFloat(2, 0, 50000),
-        'zfw'          => $faker->randomFloat(2, 0, 50000),
-        'status'       => AircraftStatus::ACTIVE,
-        'state'        => AircraftState::PARKED,
-        'created_at'   => $faker->dateTimeBetween('-1 week', 'now'),
-        'updated_at'   => function (array $pirep) {
-            return $pirep['created_at'];
-        },
-    ];
-});
+class AircraftFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Aircraft::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @throws \Exception
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'           => null,
+            'subfleet_id'  => fn () => Subfleet::factory()->create()->id,
+            'airport_id'   => fn () => Airport::factory()->create()->id,
+            'iata'         => $this->faker->unique()->text(5),
+            'icao'         => $this->faker->unique()->text(5),
+            'name'         => $this->faker->text(50),
+            'registration' => $this->faker->unique()->text(10),
+            'hex_code'     => ICAO::createHexCode(),
+            'mtow'         => $this->faker->randomFloat(2, 0, 50000),
+            'zfw'          => $this->faker->randomFloat(2, 0, 50000),
+            'status'       => AircraftStatus::ACTIVE,
+            'state'        => AircraftState::PARKED,
+            'created_at'   => $this->faker->dateTimeBetween('-1 week')->format(DateTime::ATOM),
+            'updated_at'   => fn (array $pirep) => $pirep['created_at'],
+        ];
+    }
+}

app/Database/factories/AirlineFactory.php

@@ -1,25 +1,41 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Airline;
 use Hashids\Hashids;
 
-/*
- * Add any number of airports. Don't really care if they're real or not
- */
-$factory->define(App\Models\Airline::class, function (Faker $faker) {
-    return [
-        'id'   => null,
-        'icao' => function (array $apt) {
-            $hashids = new Hashids(microtime(), 5);
-            $mt = str_replace('.', '', microtime(true));
+class AirlineFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Airline::class;
 
-            return $hashids->encode($mt);
-        },
-        'iata' => function (array $apt) {
-            return $apt['icao'];
-        },
-        'name'    => $faker->sentence(3),
-        'country' => $faker->country,
-        'active'  => 1,
-    ];
-});
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'   => null,
+            'icao' => function (array $apt): string {
+                $hashids = new Hashids(microtime(), 5);
+                $mt = str_replace('.', '', microtime(true));
+
+                return $hashids->encode($mt);
+            },
+            'iata'    => fn (array $apt) => $apt['icao'],
+            'name'    => $this->faker->sentence(3),
+            'country' => $this->faker->country,
+            'active'  => 1,
+        ];
+    }
+}

app/Database/factories/AirportFactory.php

@@ -1,12 +1,31 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-/*
- * Create an ICAO for use in the factory.
- */
-if (!function_exists('createFactoryICAO')) {
-    function createFactoryICAO(): string
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Airport;
+
+class AirportFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Airport::class;
+
+    protected array $usedIcaos = [];
+
+    /**
+     * Generate a fake ICAO
+     *
+     * @throws \Exception
+     *
+     * @return string
+     */
+    protected function createFactoryICAO(): string
     {
         $characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
         $max = strlen($characters) - 1;
@@ -20,37 +39,35 @@ if (!function_exists('createFactoryICAO')) {
 
         return $string;
     }
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id' => function () {
+                do {
+                    $airport = $this->createFactoryICAO();
+                } while (in_array($airport, $this->usedIcaos, true));
+
+                return $airport;
+            },
+            'icao'                 => fn (array $apt) => $apt['id'],
+            'iata'                 => fn (array $apt) => $apt['id'],
+            'name'                 => $this->faker->sentence(3),
+            'country'              => $this->faker->country,
+            'timezone'             => $this->faker->timezone,
+            'lat'                  => $this->faker->latitude,
+            'lon'                  => $this->faker->longitude,
+            'hub'                  => false,
+            'notes'                => null,
+            'ground_handling_cost' => $this->faker->randomFloat(2, 0, 500),
+            'fuel_100ll_cost'      => $this->faker->randomFloat(2, 1, 10),
+            'fuel_jeta_cost'       => $this->faker->randomFloat(2, 1, 10),
+            'fuel_mogas_cost'      => $this->faker->randomFloat(2, 1, 10),
+        ];
+    }
 }
-
-/*
- * Add any number of airports. Don't really care if they're real or not
- */
-$factory->define(App\Models\Airport::class, function (Faker $faker) {
-    $usedIcaos = [];
-
-    return [
-        'id' => function () use ($usedIcaos) {
-            do {
-                $airport = createFactoryICAO();
-            } while (in_array($airport, $usedIcaos, true));
-
-            return $airport;
-        },
-        'icao' => function (array $apt) {
-            return $apt['id'];
-        },
-        'iata' => function (array $apt) {
-            return $apt['id'];
-        },
-        'name'                 => $faker->sentence(3),
-        'country'              => $faker->country,
-        'timezone'             => $faker->timezone,
-        'lat'                  => $faker->latitude,
-        'lon'                  => $faker->longitude,
-        'hub'                  => false,
-        'ground_handling_cost' => $faker->randomFloat(2, 0, 500),
-        'fuel_100ll_cost'      => $faker->randomFloat(2, 1, 10),
-        'fuel_jeta_cost'       => $faker->randomFloat(2, 1, 10),
-        'fuel_mogas_cost'      => $faker->randomFloat(2, 1, 10),
-    ];
-});

app/Database/factories/AwardFactory.php

@@ -0,0 +1,34 @@
+<?php
+
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Award;
+
+class AwardFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Award::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'               => null,
+            'name'             => $this->faker->name,
+            'description'      => $this->faker->text(10),
+            'ref_model'        => null,
+            'ref_model_params' => null,
+        ];
+    }
+}

app/Database/factories/AwardsFactory.php

@@ -1,13 +0,0 @@
-<?php
-
-use Faker\Generator as Faker;
-
-$factory->define(App\Models\Award::class, function (Faker $faker) {
-    return [
-        'id'               => null,
-        'name'             => $faker->name,
-        'description'      => $faker->text(10),
-        'ref_model'        => null,
-        'ref_model_params' => null,
-    ];
-});

app/Database/factories/ExpenseFactory.php

@@ -1,18 +1,39 @@
 <?php
 
-use App\Models\Enums\ExpenseType;
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\Expense::class, function (Faker $faker) {
-    return [
-        'id'           => null,
-        'airline_id'   => null,
-        'name'         => $faker->text(20),
-        'amount'       => $faker->randomFloat(2, 100, 1000),
-        'type'         => ExpenseType::FLIGHT,
-        'multiplier'   => false,
-        'ref_model'    => \App\Models\Expense::class,
-        'ref_model_id' => null,
-        'active'       => true,
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Enums\ExpenseType;
+use App\Models\Expense;
+
+class ExpenseFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Expense::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'           => null,
+            'airline_id'   => null,
+            'name'         => $this->faker->text(20),
+            'amount'       => $this->faker->randomFloat(2, 100, 1000),
+            'type'         => ExpenseType::FLIGHT,
+            'multiplier'   => false,
+            'ref_model'    => \App\Models\Expense::class,
+            'ref_model_id' => null,
+            'active'       => true,
+        ];
+    }
+}

app/Database/factories/FareFactory.php

@@ -1,16 +1,35 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\Fare::class, function (Faker $faker) {
-    return [
-        'id'    => null,
-        'code'  => $faker->unique()->text(50),
-        'name'  => $faker->text(50),
-        'price' => $faker->randomFloat(2, 100, 1000),
-        'cost'  => function (array $fare) {
-            return round($fare['price'] / 2);
-        },
-        'capacity' => $faker->randomFloat(0, 20, 500),
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Fare;
+
+class FareFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Fare::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'       => null,
+            'code'     => $this->faker->unique()->text(50),
+            'name'     => $this->faker->text(50),
+            'price'    => $this->faker->randomFloat(2, 100, 1000),
+            'cost'     => fn (array $fare) => round($fare['price'] / 2),
+            'capacity' => $this->faker->randomFloat(0, 20, 500),
+        ];
+    }
+}

app/Database/factories/FlightFactory.php

@@ -1,44 +1,58 @@
 <?php
-/**
- * Create flights
- */
-use Faker\Generator as Faker;
 
-$factory->define(App\Models\Flight::class, function (Faker $faker) {
-    return [
-        'id'         => $faker->unique()->numberBetween(10, 10000000),
-        'airline_id' => function () {
-            return factory(\App\Models\Airline::class)->create()->id;
-        },
-        'flight_number'  => $faker->unique()->numberBetween(10, 1000000),
-        'route_code'     => $faker->randomElement(['', $faker->text(5)]),
-        'route_leg'      => $faker->randomElement(['', $faker->numberBetween(0, 1000)]),
-        'dpt_airport_id' => function () {
-            return factory(\App\Models\Airport::class)->create()->id;
-        },
-        'arr_airport_id' => function () {
-            return factory(\App\Models\Airport::class)->create()->id;
-        },
-        'alt_airport_id' => function () {
-            return factory(\App\Models\Airport::class)->create()->id;
-        },
-        'distance'             => $faker->numberBetween(1, 1000),
-        'route'                => null,
-        'level'                => 0,
-        'dpt_time'             => $faker->time(),
-        'arr_time'             => $faker->time(),
-        'flight_time'          => $faker->numberBetween(60, 360),
-        'load_factor'          => $faker->randomElement([15, 20, 50, 90, 100]),
-        'load_factor_variance' => $faker->randomElement([15, 20, 50, 90, 100]),
-        'has_bid'              => false,
-        'active'               => true,
-        'visible'              => true,
-        'days'                 => 0,
-        'start_date'           => null,
-        'end_date'             => null,
-        'created_at'           => $faker->dateTimeBetween('-1 week', 'now'),
-        'updated_at'           => static function (array $flight) {
-            return $flight['created_at'];
-        },
-    ];
-});
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Flight;
+use DateTime;
+
+class FlightFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Flight::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'            => $this->faker->unique()->numberBetween(10, 10000000),
+            'airline_id'    => fn () => \App\Models\Airline::factory()->create()->id,
+            'flight_number' => $this->faker->unique()->numberBetween(10, 1000000),
+            'route_code'    => $this->faker->randomElement(['', $this->faker->text(5)]),
+            'route_leg'     => $this->faker->randomElement(
+                ['', $this->faker->numberBetween(0, 1000)]
+            ),
+            'dpt_airport_id'       => static fn () => \App\Models\Airport::factory()->create()->id,
+            'arr_airport_id'       => static fn () => \App\Models\Airport::factory()->create()->id,
+            'alt_airport_id'       => static fn () => \App\Models\Airport::factory()->create()->id,
+            'distance'             => $this->faker->numberBetween(1, 1000),
+            'route'                => null,
+            'level'                => 0,
+            'dpt_time'             => $this->faker->time(),
+            'arr_time'             => $this->faker->time(),
+            'flight_time'          => $this->faker->numberBetween(60, 360),
+            'load_factor'          => $this->faker->randomElement([15, 20, 50, 90, 100]),
+            'load_factor_variance' => $this->faker->randomElement([15, 20, 50, 90, 100]),
+            'has_bid'              => false,
+            'active'               => true,
+            'visible'              => true,
+            'days'                 => 0,
+            'start_date'           => null,
+            'end_date'             => null,
+            'created_at'           => $this->faker->dateTimeBetween('-1 week')->format(
+                DateTime::ATOM
+            ),
+            'updated_at' => static fn (array $flight) => $flight['created_at'],
+        ];
+    }
+}

app/Database/factories/JournalFactory.php

@@ -1,9 +1,30 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\Journal::class, function (Faker $faker) {
-    return [
-        'currency' => 'USD',
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Journal;
+
+class JournalFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Journal::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'currency' => 'USD',
+        ];
+    }
+}

app/Database/factories/JournalTransactionsFactory.php

@@ -1,20 +1,39 @@
 <?php
 
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
 use App\Models\Journal;
+use App\Models\JournalTransaction;
 use Carbon\Carbon;
-use Faker\Generator as Faker;
 use Ramsey\Uuid\Uuid;
 
-$factory->define(App\Models\JournalTransaction::class, function (Faker $faker) {
-    return [
-        'transaction_group' => Uuid::uuid4()->toString(),
-        'journal_id'        => function () {
-            return factory(Journal::class)->create()->id;
-        },
-        'credit'    => $faker->numberBetween(100, 10000),
-        'debit'     => $faker->numberBetween(100, 10000),
-        'currency'  => 'USD',
-        'memo'      => $faker->sentence(6),
-        'post_date' => Carbon::now('UTC'),
-    ];
-});
+class JournalTransactionsFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = JournalTransaction::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'transaction_group' => Uuid::uuid4()->toString(),
+            'journal_id'        => fn () => Journal::factory()->create()->id,
+            'credit'            => $this->faker->numberBetween(100, 10000),
+            'debit'             => $this->faker->numberBetween(100, 10000),
+            'currency'          => 'USD',
+            'memo'              => $this->faker->sentence(6),
+            'post_date'         => Carbon::now('UTC')->toDateTimeString(),
+        ];
+    }
+}

app/Database/factories/NavdataFactory.php

@@ -1,15 +1,36 @@
 <?php
 
-use App\Models\Enums\NavaidType;
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\Navdata::class, function (Faker $faker) {
-    return [
-        'id'   => str_replace(' ', '', str_replace('.', '', $faker->unique()->text(5))),
-        'name' => str_replace('.', '', $faker->unique()->word),
-        'type' => $faker->randomElement([NavaidType::VOR, NavaidType::NDB]),
-        'lat'  => $faker->latitude,
-        'lon'  => $faker->longitude,
-        'freq' => $faker->randomFloat(2, 100, 1000),
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Enums\NavaidType;
+use App\Models\Navdata;
+
+class NavdataFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Navdata::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'   => str_replace(' ', '', str_replace('.', '', $this->faker->unique()->text(5))),
+            'name' => str_replace('.', '', $this->faker->unique()->word),
+            'type' => $this->faker->randomElement([NavaidType::VOR, NavaidType::NDB]),
+            'lat'  => $this->faker->latitude,
+            'lon'  => $this->faker->longitude,
+            'freq' => $this->faker->randomFloat(2, 100, 1000),
+        ];
+    }
+}

app/Database/factories/NewsFactory.php

@@ -1,14 +1,33 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\News::class, function (Faker $faker) {
-    return [
-        'id'      => null,
-        'user_id' => function () {
-            return factory(\App\Models\User::class)->create()->id;
-        },
-        'subject' => $faker->text(),
-        'body'    => $faker->sentence,
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\News;
+
+class NewsFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = News::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'      => null,
+            'user_id' => fn () => \App\Models\User::factory()->create()->id,
+            'subject' => $this->faker->text(),
+            'body'    => $this->faker->sentence,
+        ];
+    }
+}

app/Database/factories/PirepFactory.php

@@ -1,69 +1,74 @@
 <?php
 
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Airline;
 use App\Models\Enums\PirepSource;
 use App\Models\Enums\PirepState;
 use App\Models\Enums\PirepStatus;
+use App\Models\Flight;
+use App\Models\Pirep;
 use Carbon\Carbon;
-use Faker\Generator as Faker;
 
-/*
- * Create a new PIREP
- */
-$factory->define(App\Models\Pirep::class, function (Faker $faker) {
-    $airline = factory(\App\Models\Airline::class)->create();
-    $flight = factory(\App\Models\Flight::class)->create([
-        'airline_id' => $airline->id,
-    ]);
+class PirepFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Pirep::class;
 
-    return [
-        'id'         => $faker->unique()->numberBetween(10, 10000000),
-        'airline_id' => function () use ($airline) {
-            return $airline->id;
-        },
-        'user_id' => function () {
-            return factory(\App\Models\User::class)->create()->id;
-        },
-        'aircraft_id' => function () {
-            return factory(\App\Models\Aircraft::class)->create()->id;
-        },
-        'flight_id' => function () use ($flight) {
-            return $flight->id;
-        },
-        'flight_number' => function () use ($flight) {
-            return $flight->flight_number;
-        },
-        'route_code'     => null,
-        'route_leg'      => null,
-        'dpt_airport_id' => function () use ($flight) {
-            return $flight->dpt_airport_id;
-        },
-        'arr_airport_id' => function () use ($flight) {
-            return $flight->arr_airport_id;
-        },
-        'level'               => $faker->numberBetween(20, 400),
-        'distance'            => $faker->randomFloat(2, 0, 6000),
-        'planned_distance'    => $faker->randomFloat(2, 0, 6000),
-        'flight_time'         => $faker->numberBetween(60, 360),
-        'planned_flight_time' => $faker->numberBetween(60, 360),
-        'zfw'                 => $faker->randomFloat(2),
-        'block_fuel'          => $faker->randomFloat(2, 0, 1000),
-        'fuel_used'           => function (array $pirep) {
-            return round($pirep['block_fuel'] * .9, 2); // 90% of the fuel loaded was used
-        },
-        'block_on_time'  => Carbon::now('UTC'),
-        'block_off_time' => function (array $pirep) {
-            return $pirep['block_on_time']->subMinutes($pirep['flight_time']);
-        },
-        'route'        => $faker->text(200),
-        'notes'        => $faker->text(200),
-        'source'       => $faker->randomElement([PirepSource::MANUAL, PirepSource::ACARS]),
-        'source_name'  => 'TestFactory',
-        'state'        => PirepState::PENDING,
-        'status'       => PirepStatus::SCHEDULED,
-        'submitted_at' => Carbon::now('UTC')->toDateTimeString(),
-        'created_at'   => Carbon::now('UTC')->toDateTimeString(),
-        'updated_at'   => function (array $pirep) {
-            return $pirep['created_at'];
-        },
-    ];
-});
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        /** @var Airline $airline */
+        $airline = Airline::factory()->create();
+
+        /** @var Flight $flight */
+        $flight = Flight::factory()->create(['airline_id' => $airline->id]);
+
+        return [
+            'id'                  => $this->faker->unique()->numberBetween(10, 10000000),
+            'airline_id'          => fn () => $airline->id,
+            'user_id'             => fn () => \App\Models\User::factory()->create()->id,
+            'aircraft_id'         => fn () => \App\Models\Aircraft::factory()->create()->id,
+            'flight_id'           => fn () => $flight->id,
+            'flight_number'       => fn () => $flight->flight_number,
+            'route_code'          => null,
+            'route_leg'           => null,
+            'dpt_airport_id'      => fn () => $flight->dpt_airport_id,
+            'arr_airport_id'      => fn () => $flight->arr_airport_id,
+            'level'               => $this->faker->numberBetween(20, 400),
+            'distance'            => $this->faker->randomFloat(2, 0, 6000),
+            'planned_distance'    => $this->faker->randomFloat(2, 0, 6000),
+            'flight_time'         => $this->faker->numberBetween(60, 360),
+            'planned_flight_time' => $this->faker->numberBetween(60, 360),
+            'zfw'                 => $this->faker->randomFloat(2),
+            'block_fuel'          => $this->faker->randomFloat(2, 0, 1000),
+            'fuel_used'           => fn (array $pirep) => round($pirep['block_fuel'] * .9, 2),
+            'block_on_time'       => Carbon::now('UTC'),
+            'block_off_time'      => fn (array $pirep) => $pirep['block_on_time']->subMinutes(
+                $pirep['flight_time']
+            ),
+            'route'  => $this->faker->text(200),
+            'notes'  => $this->faker->text(200),
+            'source' => $this->faker->randomElement(
+                [PirepSource::MANUAL, PirepSource::ACARS]
+            ),
+            'source_name'  => 'TestFactory',
+            'state'        => PirepState::PENDING,
+            'status'       => PirepStatus::SCHEDULED,
+            'submitted_at' => Carbon::now('UTC')->toDateTimeString(),
+            'created_at'   => Carbon::now('UTC')->toDateTimeString(),
+            'updated_at'   => fn (array $pirep) => $pirep['created_at'],
+        ];
+    }
+}

app/Database/factories/RankFactory.php

@@ -1,23 +1,37 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-/*
- * id: 2
-    name: Junior First Officer
-    hours: 10
-    auto_approve_acars: 1
-    auto_approve_manual: 1
- */
-$factory->define(App\Models\Rank::class, function (Faker $faker) {
-    return [
-        'id'                   => null,
-        'name'                 => $faker->unique()->text(50),
-        'hours'                => $faker->numberBetween(10, 50),
-        'acars_base_pay_rate'  => $faker->numberBetween(10, 100),
-        'manual_base_pay_rate' => $faker->numberBetween(10, 100),
-        'auto_approve_acars'   => 0,
-        'auto_approve_manual'  => 0,
-        'auto_promote'         => 0,
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Rank;
+
+class RankFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Rank::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'                   => null,
+            'name'                 => $this->faker->unique()->text(50),
+            'hours'                => $this->faker->numberBetween(10, 50),
+            'acars_base_pay_rate'  => $this->faker->numberBetween(10, 100),
+            'manual_base_pay_rate' => $this->faker->numberBetween(10, 100),
+            'auto_approve_acars'   => 0,
+            'auto_approve_manual'  => 0,
+            'auto_promote'         => 0,
+        ];
+    }
+}

app/Database/factories/RoleFactory.php

@@ -1,13 +1,34 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\Role::class, function (Faker $faker) {
-    return [
-        'id'                      => null,
-        'name'                    => $faker->name,
-        'display_name'            => $faker->name,
-        'read_only'               => false,
-        'disable_activity_checks' => $faker->boolean(),
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Role;
+
+class RoleFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Role::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'                      => null,
+            'name'                    => $this->faker->name,
+            'display_name'            => $this->faker->name,
+            'read_only'               => false,
+            'disable_activity_checks' => $this->faker->boolean(),
+        ];
+    }
+}

app/Database/factories/SimBriefFactory.php

@@ -0,0 +1,38 @@
+<?php
+
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\SimBrief;
+use Carbon\Carbon;
+
+class SimBriefFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = SimBrief::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition()
+    {
+        return [
+            'id'         => $this->faker->unique()->numberBetween(10, 10000000),
+            'user_id'    => null,
+            'flight_id'  => null,
+            'pirep_id'   => null,
+            'acars_xml'  => '',
+            'ofp_xml'    => '',
+            'created_at' => Carbon::now('UTC')->toDateTimeString(),
+            'updated_at' => fn (array $sb) => $sb['created_at'],
+        ];
+    }
+}

app/Database/factories/SimbriefFactory.php

@@ -1,21 +0,0 @@
-<?php
-
-/** @var \Illuminate\Database\Eloquent\Factory $factory */
-
-use Carbon\Carbon;
-use Faker\Generator as Faker;
-
-$factory->define(App\Models\SimBrief::class, function (Faker $faker) {
-    return [
-        'id'         => $faker->unique()->numberBetween(10, 10000000),
-        'user_id'    => null,
-        'flight_id'  => null,
-        'pirep_id'   => null,
-        'acars_xml'  => '',
-        'ofp_xml'    => '',
-        'created_at' => Carbon::now('UTC')->toDateTimeString(),
-        'updated_at' => function (array $sb) {
-            return $sb['created_at'];
-        },
-    ];
-});

app/Database/factories/SubfleetFactory.php

@@ -1,15 +1,34 @@
 <?php
 
-use Faker\Generator as Faker;
+/** @noinspection PhpIllegalPsrClassPathInspection */
 
-$factory->define(App\Models\Subfleet::class, function (Faker $faker) {
-    return [
-        'id'         => null,
-        'airline_id' => function () {
-            return factory(\App\Models\Airline::class)->create()->id;
-        },
-        'name'                       => $faker->unique()->text(50),
-        'type'                       => $faker->unique()->text(7),
-        'ground_handling_multiplier' => $faker->numberBetween(50, 200),
-    ];
-});
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
+use App\Models\Subfleet;
+
+class SubfleetFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Subfleet::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'id'                         => null,
+            'airline_id'                 => fn () => \App\Models\Airline::factory()->create()->id,
+            'name'                       => $this->faker->unique()->text(50),
+            'type'                       => $this->faker->unique()->text(7),
+            'ground_handling_multiplier' => $this->faker->numberBetween(50, 200),
+        ];
+    }
+}

app/Database/factories/UserFactory.php

@@ -1,28 +1,54 @@
 <?php
 
+/** @noinspection PhpIllegalPsrClassPathInspection */
+
+namespace App\Database\Factories;
+
+use App\Contracts\Factory;
 use App\Models\Airline;
 use App\Models\Enums\UserState;
-use Faker\Generator as Faker;
+use App\Models\User;
 use Illuminate\Support\Facades\Hash;
 
-$factory->define(App\Models\User::class, function (Faker $faker) {
-    static $password;
+class UserFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = User::class;
 
-    return [
-        'id'         => null,
-        'pilot_id'   => null,
-        'name'       => $faker->name,
-        'email'      => $faker->safeEmail,
-        'password'   => $password ?: $password = Hash::make('secret'),
-        'api_key'    => $faker->sha1,
-        'airline_id' => function () {
-            return factory(Airline::class)->create()->id;
-        },
-        'rank_id'        => 1,
-        'flights'        => $faker->numberBetween(0, 1000),
-        'flight_time'    => $faker->numberBetween(0, 10000),
-        'transfer_time'  => $faker->numberBetween(0, 10000),
-        'state'          => UserState::ACTIVE,
-        'remember_token' => $faker->unique()->text(5),
-    ];
-});
+    /**
+     * @var string
+     */
+    private static string $password;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        if (empty(self::$password)) {
+            self::$password = Hash::make('secret');
+        }
+
+        return [
+            'id'             => null,
+            'pilot_id'       => null,
+            'name'           => $this->faker->name,
+            'email'          => $this->faker->safeEmail,
+            'password'       => self::$password,
+            'api_key'        => $this->faker->sha1,
+            'airline_id'     => fn () => Airline::factory()->create()->id,
+            'rank_id'        => 1,
+            'flights'        => $this->faker->numberBetween(0, 1000),
+            'flight_time'    => $this->faker->numberBetween(0, 10000),
+            'transfer_time'  => $this->faker->numberBetween(0, 10000),
+            'state'          => UserState::ACTIVE,
+            'remember_token' => $this->faker->unique()->text(5),
+        ];
+    }
+}

app/Database/migrations/2017_06_07_014930_create_settings_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use App\Services\Installer\SeederService;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateSettingsTable extends Migration
-{
+return new class() extends Migration {
     private $seederSvc;
 
     public function __construct()
@@ -50,4 +49,4 @@ class CreateSettingsTable extends Migration
     {
         Schema::dropIfExists('settings');
     }
-}
+};

app/Database/migrations/2017_06_08_0000_create_users_table.php

@@ -5,8 +5,7 @@ use App\Models\Pirep;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateUsersTable extends Migration
-{
+return new class() extends Migration {
     /**
      * Run the migrations.
      *
@@ -55,4 +54,4 @@ class CreateUsersTable extends Migration
     {
         Schema::dropIfExists('users');
     }
-}
+};

app/Database/migrations/2017_06_08_0001_roles_permissions_tables.php

@@ -2,9 +2,9 @@
 
 use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
 
-class RolesPermissionsTables extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         // Create table for storing roles
@@ -82,4 +82,4 @@ class RolesPermissionsTables extends Migration
         Schema::dropIfExists('role_user');
         Schema::dropIfExists('roles');
     }
-}
+};

app/Database/migrations/2017_06_08_0005_create_password_resets_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreatePasswordResetsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('password_resets', function (Blueprint $table) {
@@ -19,4 +18,4 @@ class CreatePasswordResetsTable extends Migration
     {
         Schema::dropIfExists('password_resets');
     }
-}
+};

app/Database/migrations/2017_06_08_0006_create_sessions_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateSessionsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('sessions', function (Blueprint $table) {
@@ -22,4 +21,4 @@ class CreateSessionsTable extends Migration
     {
         Schema::dropIfExists('sessions');
     }
-}
+};

app/Database/migrations/2017_06_08_191703_create_airlines_table.php

@@ -3,8 +3,7 @@
 use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateAirlinesTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('airlines', function (Blueprint $table) {
@@ -31,4 +30,4 @@ class CreateAirlinesTable extends Migration
     {
         Schema::dropIfExists('airlines');
     }
-}
+};

app/Database/migrations/2017_06_09_010621_create_aircrafts_table.php

@@ -5,8 +5,7 @@ use App\Models\Enums\AircraftState;
 use App\Models\Enums\AircraftStatus;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateAircraftsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('aircraft', function (Blueprint $table) {
@@ -34,4 +33,4 @@ class CreateAircraftsTable extends Migration
     {
         Schema::dropIfExists('aircraft');
     }
-}
+};

app/Database/migrations/2017_06_10_040335_create_fares_table.php

@@ -3,8 +3,7 @@
 use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateFaresTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('fares', function (Blueprint $table) {
@@ -24,4 +23,4 @@ class CreateFaresTable extends Migration
     {
         Schema::dropIfExists('fares');
     }
-}
+};

app/Database/migrations/2017_06_11_135707_create_airports_table.php

@@ -3,8 +3,7 @@
 use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateAirportsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('airports', function (Blueprint $table) {
@@ -33,4 +32,4 @@ class CreateAirportsTable extends Migration
     {
         Schema::dropIfExists('airports');
     }
-}
+};

app/Database/migrations/2017_06_17_214650_create_flight_tables.php

@@ -5,8 +5,7 @@ use App\Contracts\Model;
 use App\Models\Enums\FlightType;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateFlightTables extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('flights', function (Blueprint $table) {
@@ -98,4 +97,4 @@ class CreateFlightTables extends Migration
         Schema::drop('flight_subfleet');
         Schema::drop('flights');
     }
-}
+};

app/Database/migrations/2017_06_21_165410_create_ranks_table.php

@@ -3,8 +3,7 @@
 use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateRanksTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('ranks', function (Blueprint $table) {
@@ -29,4 +28,4 @@ class CreateRanksTable extends Migration
     {
         Schema::dropIfExists('ranks');
     }
-}
+};

app/Database/migrations/2017_06_23_011011_create_subfleet_tables.php

@@ -3,8 +3,7 @@
 use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreateSubfleetTables extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('subfleets', function (Blueprint $table) {
@@ -51,4 +50,4 @@ class CreateSubfleetTables extends Migration
         Schema::dropIfExists('subfleet_fare');
         Schema::dropIfExists('subfleet_rank');
     }
-}
+};

app/Database/migrations/2017_06_28_195426_create_pirep_tables.php

@@ -7,8 +7,7 @@ use App\Models\Enums\PirepState;
 use App\Models\Enums\PirepStatus;
 use Illuminate\Database\Schema\Blueprint;
 
-class CreatePirepTables extends Migration
-{
+return new class() extends Migration {
     /**
      * Run the migrations.
      *
@@ -106,4 +105,4 @@ class CreatePirepTables extends Migration
         Schema::dropIfExists('pirep_fields');
         Schema::dropIfExists('pirep_field_values');
     }
-}
+};

app/Database/migrations/2017_12_12_174519_create_bids_table.php

@@ -5,8 +5,7 @@ use App\Contracts\Model;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateBidsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('bids', function (Blueprint $table) {
@@ -24,4 +23,4 @@ class CreateBidsTable extends Migration
     {
         Schema::dropIfExists('bids');
     }
-}
+};

app/Database/migrations/2017_12_14_225241_create_jobs_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateJobsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('jobs', function (Blueprint $table) {
@@ -23,4 +22,4 @@ class CreateJobsTable extends Migration
     {
         Schema::dropIfExists('jobs');
     }
-}
+};

app/Database/migrations/2017_12_14_225337_create_failed_jobs_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateFailedJobsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('failed_jobs', function (Blueprint $table) {
@@ -22,4 +21,4 @@ class CreateFailedJobsTable extends Migration
     {
         Schema::dropIfExists('failed_jobs');
     }
-}
+};

app/Database/migrations/2017_12_20_004147_create_navdata_tables.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateNavdataTables extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         /*
@@ -30,4 +29,4 @@ class CreateNavdataTables extends Migration
     {
         Schema::dropIfExists('navdata');
     }
-}
+};

app/Database/migrations/2017_12_20_005147_create_acars_tables.php

@@ -5,8 +5,7 @@ use App\Contracts\Model;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateAcarsTables extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('acars', function (Blueprint $table) {
@@ -43,4 +42,4 @@ class CreateAcarsTables extends Migration
     {
         Schema::dropIfExists('acars');
     }
-}
+};

app/Database/migrations/2018_01_03_014930_create_stats_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateStatsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('stats', function (Blueprint $table) {
@@ -24,4 +23,4 @@ class CreateStatsTable extends Migration
     {
         Schema::dropIfExists('stats');
     }
-}
+};

app/Database/migrations/2018_01_08_142204_create_news_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateNewsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('news', function (Blueprint $table) {
@@ -21,4 +20,4 @@ class CreateNewsTable extends Migration
     {
         Schema::drop('news');
     }
-}
+};

app/Database/migrations/2018_01_28_180522_create_awards_table.php

@@ -5,8 +5,7 @@ use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 use Modules\Awards\Awards\PilotFlightAwards;
 
-class CreateAwardsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('awards', function (Blueprint $table) {
@@ -52,4 +51,4 @@ class CreateAwardsTable extends Migration
         Schema::dropIfExists('awards');
         Schema::dropIfExists('user_awards');
     }
-}
+};

app/Database/migrations/2018_02_26_185121_create_expenses_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateExpensesTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('expenses', function (Blueprint $table) {
@@ -34,4 +33,4 @@ class CreateExpensesTable extends Migration
     {
         Schema::dropIfExists('expenses');
     }
-}
+};

app/Database/migrations/2018_02_28_231807_create_journal_transactions_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateJournalTransactionsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('journal_transactions', function (Blueprint $table) {
@@ -33,4 +32,4 @@ class CreateJournalTransactionsTable extends Migration
     {
         Schema::dropIfExists('journal_transactions');
     }
-}
+};

app/Database/migrations/2018_02_28_231813_create_journals_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateJournalsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('journals', function (Blueprint $table) {
@@ -23,4 +22,4 @@ class CreateJournalsTable extends Migration
     {
         Schema::dropIfExists('journals');
     }
-}
+};

app/Database/migrations/2018_02_28_232438_create_ledgers_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateLedgersTable extends Migration
-{
+return new class() extends Migration {
     /**
      * Run the migrations.
      *
@@ -30,4 +29,4 @@ class CreateLedgersTable extends Migration
     {
         Schema::dropIfExists('ledgers');
     }
-}
+};

app/Database/migrations/2018_04_01_193443_create_files_table.php

@@ -5,8 +5,7 @@ use App\Contracts\Model;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateFilesTable extends Migration
-{
+return new class() extends Migration {
     /**
      * Create the files table. Acts as a morphable
      *
@@ -40,4 +39,4 @@ class CreateFilesTable extends Migration
     {
         Schema::dropIfExists('files');
     }
-}
+};

app/Database/migrations/2019_06_19_220910_add_readonly_to_roles.php

@@ -5,8 +5,7 @@ use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Schema;
 
-class AddReadonlyToRoles extends Migration
-{
+return new class() extends Migration {
     public function up(): void
     {
         Schema::table('roles', static function (Blueprint $table) {
@@ -25,4 +24,4 @@ class AddReadonlyToRoles extends Migration
             $table->dropColumn('read_only');
         });
     }
-}
+};

app/Database/migrations/2019_07_16_141152_users_add_pilot_id.php

@@ -12,8 +12,7 @@ use Illuminate\Support\Facades\Schema;
  * 3. Iterate through all of the users and set their `id` to the `pilot_id`
  * 4. Change the other tables column types that reference `user_id`
  */
-class UsersAddPilotId extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::table('users', static function (Blueprint $table) {
@@ -33,4 +32,4 @@ class UsersAddPilotId extends Migration
             $table->dropColumn('pilot_id');
         });
     }
-}
+};

app/Database/migrations/2019_08_30_132224_create_notifications_table.php

@@ -4,8 +4,7 @@ use App\Contracts\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-class CreateNotificationsTable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::create('notifications', function (Blueprint $table) {
@@ -22,4 +21,4 @@ class CreateNotificationsTable extends Migration
     {
         Schema::dropIfExists('notifications');
     }
-}
+};

app/Database/migrations/2019_09_16_141152_pireps_change_state_type.php

@@ -9,8 +9,7 @@ use Illuminate\Support\Facades\Schema;
 /**
  * Change the PIREP state column to be a TINYINT
  */
-class PirepsChangeStateType extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         // Migrate the old rejected state
@@ -23,4 +22,4 @@ class PirepsChangeStateType extends Migration
             $table->unsignedSmallInteger('state')->change();
         });
     }
-}
+};

app/Database/migrations/2019_10_30_141152_pireps_add_flight_id.php

@@ -8,12 +8,11 @@ use Illuminate\Support\Facades\Schema;
 /**
  * Add a `flight_id` column to the PIREPs table
  */
-class PirepsAddFlightId extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::table('pireps', function (Blueprint $table) {
             $table->string('flight_id', Model::ID_MAX_LENGTH)->nullable()->after('aircraft_id');
         });
     }
-}
+};

app/Database/migrations/2020_02_12_141152_expenses_add_flight_type.php

@@ -7,8 +7,7 @@ use Illuminate\Support\Facades\Schema;
 /**
  * Add a `flight_type` column to the expenses table
  */
-class ExpensesAddFlightType extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::table('expenses', function (Blueprint $table) {
@@ -24,4 +23,4 @@ class ExpensesAddFlightType extends Migration
             $table->dropColumn('flight_type');
         });
     }
-}
+};

app/Database/migrations/2020_02_26_044305_modify_airports_coordinates.php

@@ -6,8 +6,7 @@ use Illuminate\Support\Facades\Schema;
 /**
  * Turn the airport coordinates and other lat/lon coords into decimal type
  */
-class ModifyAirportsCoordinates extends Migration
-{
+return new class() extends Migration {
     /**
      * Run the migrations.
      *
@@ -25,4 +24,4 @@ class ModifyAirportsCoordinates extends Migration
             $table->decimal('lon', 11, 5)->change()->default(0.0)->nullable();
         });
     }
-}
+};

app/Database/migrations/2020_03_04_044305_flight_field_nullable.php

@@ -6,12 +6,11 @@ use Illuminate\Support\Facades\Schema;
 /**
  * Allow the flight field value to be nullable
  */
-class FlightFieldNullable extends Migration
-{
+return new class() extends Migration {
     public function up()
     {
         Schema::table('flight_field_values', function ($table) {
             $table->text('value')->change()->nullable();
         });
     }
-}
+};