FGFS-4.1/simgear
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

REVIEW: Memory Leaks

Browse Source
This commit is contained in:
Scott Giese
2020-09-24 22:24:12 -05:00
parent 4560095c36
commit cb4f3b1ca9
5 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
simgear/bvh/BVHStaticGeometryBuilder.hxx
View File

@@ -113,6 +113,7 @@ public:
return;
_triangleSet.insert(indexKey);
BVHStaticTriangle* staticTriangle;
// REVIEW: Memory Leak - 11,680 bytes in 365 blocks are indirectly lost
staticTriangle = new BVHStaticTriangle(_currentMaterialIndex, indices);
_leafRefList.push_back(LeafRef(staticTriangle, *_staticData));
}

1
simgear/props/props.cxx
View File

@@ -1202,6 +1202,7 @@ SGPropertyNode::getChild (const std::string& name, int index, bool create)
} else if (create) {
// REVIEW: Memory Leak - 12,862 (11,856 direct, 1,006 indirect) bytes in 78 blocks are definitely lost
SGPropertyNode* node = new SGPropertyNode(name, index, this);
// REVIEW: Memory Leak - 104,647 (8 direct, 104,639 indirect) bytes in 1 blocks are definitely lost
_children.push_back(node);
fireChildAdded(node);
return node;

4
simgear/scene/material/Effect.cxx
View File

@@ -288,6 +288,7 @@ Effect::~Effect()
void buildPass(Effect* effect, Technique* tniq, const SGPropertyNode* prop,
const SGReaderWriterOptions* options)
{
// REVIEW: Memory Leak - 35,712 bytes in 72 blocks are still reachable
Pass* pass = new Pass;
tniq->passes.push_back(pass);
for (int i = 0; i < prop->nChildren(); ++i) {
@@ -490,6 +491,8 @@ void MaterialBuilder::buildAttribute(Effect* effect, Pass* pass,
{
if (!isAttributeActive(effect, prop))
return;
// REVIEW: Memory Leak - 20,160 bytes in 72 blocks are still reachable
Material* mat = new Material;
const SGPropertyNode* color = 0;
if ((color = getEffectPropertyChild(effect, prop, "ambient")))
@@ -1330,6 +1333,7 @@ InstallAttributeBuilder<DepthBuilder> installDepth("depth");
void buildTechnique(Effect* effect, const SGPropertyNode* prop,
const SGReaderWriterOptions* options)
{
// REVIEW: Memory Leak - 13,248 bytes in 72 blocks are indirectly lost
Technique* tniq = new Technique;
effect->techniques.push_back(tniq);
tniq->setScheme(prop->getStringValue("scheme"));

1
simgear/scene/material/Technique.cxx
View File

@@ -291,6 +291,7 @@ Expression* extensionSupportedParser(const SGPropertyNode* exp,
{
if (exp->getType() == props::STRING
|| exp->getType() == props::UNSPECIFIED) {
// REVIEW: Memory Leak - 15,552 bytes in 216 blocks are indirectly lost
ExtensionSupportedExpression* esp
= new ExtensionSupportedExpression(exp->getStringValue());
int location = parser->getBindingLayout().addBinding("__contextId",

1
simgear/scene/tgdb/SGTileDetailsCallback.hxx
View File

@@ -393,6 +393,7 @@ public:
SGBuildingBin* bin = NULL;
if (building_coverage > 0) {
// REVIEW: Memory Leak - 317,405 (544 direct, 316,861 indirect) bytes in 4 blocks are definitely lost
bin = new SGBuildingBin(mat, useVBOs);
randomBuildings.push_back(bin);
}