Commit Graph
5585 Commits
Author SHA1 Message Date
James Turner c7f013e7e5 Don’t wipe startup message on pausing logging. 2020-09-07 14:42:16 +01:00
James Turner 19ace8f0f9 Silence an alert message 2020-09-06 14:48:17 +01:00
James Turner 908496d43d ASan: make copied files in log entries safe at init.
Ensure that if we copy file-names of log entries while startup
logging is active, we free them, but only once startup logging is
disabled, or on shutdown. This is needed to avoid crashes when
we use file-name copying for the Qt message handler.
2020-09-05 10:43:01 +01:00
James Turner 52c0f04e6e Bindings: don’t cache the command pointer
Caching it complicates add/remove command logic, so making a simple
fix for now, which can be back-ported to 2020.2; ideally we would
cache the pointer but have an invalidation scheme, but that’s
considerably more work and risk.

Relates to Sentry crash:
https://sentry.io/organizations/flightgear/issues/1858764364
2020-09-04 10:51:32 +01:00
James Turner f6656354b8 Refactor SGBuildingBin
Trying to trace a crash that was reported, but along the way fix a leak
of BuildingBins. Also avoid allocating some std::strings on the heap.
2020-09-03 20:35:50 +01:00
Erik Hofman 4928509646 Mipmapping requires a power-of-two destination buffer even if the source isn't. Neglecting this causes a massive bufferoverflow of the destination buffer. So for now we do not mipmap non-power-of-two textures and throw a warning. This affects at least the PC-9M and F-16, presumable many others. The effect will be a black texture when zoomed out and the proper texture when zooming in close enough. 2020-08-29 14:45:47 +02:00
Scott Giese 9ecb90edda Clean up memory leak comment 2020-08-27 23:41:19 -05:00
Scott Giese 0d5552851b Memory Leak Fixed - SGTexturedTriangleBin
Reclaimed 42,560 bytes in 280 blocks
2020-08-27 23:40:25 -05:00
James Turner 6f2b81b477 Fix for the fact we find_package(AAX) all the time.
Since we probe for AeonWave first, we set AAX_LIBRARY to NOT_FOUND,
which then upsets CMake if we try to use it. So add some temporary
ugly logic, until I have time to define a proper ALIAS target for the
audio backend.
2020-08-24 11:14:16 +01:00
Erik Hofman af1b170059 Use consistent naming 2020-08-24 10:58:55 +02:00
Erik Hofman f235a81519 Temporary fix for AeonWave support 2020-08-24 10:58:22 +02:00
Scott Giese 5b0f44f0db Memory Leak Fix - matlib
Reclaimed 61,560 bytes in 405 blocks
2020-08-24 00:20:59 -05:00
Scott Giese f14bcfb3c5 Memory Leak Fix - SGMaterial
Reclaimed 61,560 bytes in 405 blocks
2020-08-24 00:20:26 -05:00
Scott Giese e1e70e8d33 Memory Leak Fix - BVHStaticGeometryBuilder
Was resolved at some point over the last two weeks.
Reclaimed 4,518,880 bytes in 141,215 blocks
2020-08-23 22:38:06 -05:00
Scott Giese bd01e741ac Memory Leak Fix - sg_path
Resolved via HTTPRespository fix
Reclaimed 272,181 bytes in 2,833 blocks
2020-08-23 22:22:18 -05:00
Scott Giese 423a0f65b0 Memory Leak Fix - HTTPRepository
Reclaimed 1,797,012 bytes in 7599 blocks
2020-08-23 22:15:28 -05:00
Scott Giese b8e06453ea Temporary fix: SimGear OpenAL dependency
FG configuration fails due to SG find_dependency(OpenAL) issue.
Skipping this dependency since FG itself will find_package(OpenAL).
2020-08-23 20:15:18 -05:00
James Turner bab083d072 For static builds, ensure we find the sound library
Should fix Erik’s issue with AeonWave.
2020-08-23 18:10:49 +01:00
James Turner 2c4120974c Follow rule of three for HTTPRepo:ChildInfo 2020-08-23 18:10:17 +01:00
James Turner 8b14e56f88 HTTPRepo: Fix ownership of HTTPDirectory 2020-08-23 18:08:49 +01:00
James Turner 3298260f11 GDAL is a public dependency :( 2020-08-23 11:27:09 +01:00
James Turner 2ed15eebfd CMake fixes for Linux 2020-08-23 11:27:09 +01:00
Scott Giese 720a1fe7d2 REVIEW: Memory Leak - naTempSave()
1,024 bytes in 1 blocks are still reachable
2020-08-23 01:02:27 -05:00
Scott Giese fc1178fb39 REVIEW: Memory Leak - ODGauge
1,176 bytes in 3 blocks are indirectly lost
2020-08-23 00:57:39 -05:00
Scott Giese 7ac400a162 REVIEW: Memory Leak - vgCreateContextSH()
1,624 bytes in 1 blocks are still reachable
2020-08-23 00:27:31 -05:00
Scott Giese 3550047bc8 REVIEW: Memory Leak - condition.cxx
2,880 bytes in 40 blocks are indirectly lost
632 bytes in 79 blocks are indirectly lost
2020-08-23 00:07:19 -05:00
Scott Giese b7d2eea4b2 REVIEW: Memory Leak - props.cxx
2,028 (1,976 direct, 52 indirect) bytes in 13 blocks are definitely lost
1,963 bytes in 47 blocks are indirectly lost
1,544 bytes in 193 blocks are indirectly lost
662 bytes in 32 blocks are indirectly lost
152 bytes in 1 blocks are definitely lost
32 bytes in 1 blocks are indirectly lost
8 bytes in 1 blocks are indirectly lost
2020-08-22 23:52:36 -05:00
Scott Giese 69ad4a39e3 REVIEW: Memory Leak - nasal newBlock()
168 bytes in 7 blocks are still reachable
2020-08-22 22:42:09 -05:00
Scott Giese 4ccaa68c6a REVIEW: Memory Leak - ODGauge
3,572 (136 direct, 3,436 indirect) bytes in 1 blocks are definitely lost
3,572 (8 direct, 3,564 indirect) bytes in 1 blocks are definitely lost
2,712 bytes in 3 blocks are indirectly lost
384 bytes in 3 blocks are indirectly lost
168 bytes in 3 blocks are indirectly lost
2020-08-22 22:38:33 -05:00
Scott Giese fd6e4e7298 REVIEW: Memory Leak - nasal string.c; setlen()
3,953 bytes in 184 blocks are still reachable
2020-08-22 21:53:47 -05:00
Scott Giese 896f3b6928 REVIEW: Memory Leak - soundmgr_openal.cxx
4,136 bytes in 1 blocks are still reachable
2020-08-22 21:39:47 -05:00
Scott Giese 6f6c3a0e05 REVIEW: Memory Leak - SGReaderWriterXML sgLoad3DModel_internal()
4,352 bytes in 272 blocks are definitely lost
2020-08-22 21:30:41 -05:00
Scott Giese 6160fce2ae REVIEW: Memory Leak - SGComparisonCondition::setRightValue()
7,144 bytes in 47 blocks are indirectly lost
2020-08-22 18:23:19 -05:00
Scott Giese e1a6602a59 REVIEW: Memory Leak - naNewContext()
8,184 bytes in 1 blocks are still reachable
2020-08-22 18:07:11 -05:00
Scott Giese d18c9910e8 REVIEW: Memory Leak - SGMaterialLib::load()
8,800 bytes in 57 blocks are indirectly lost
2020-08-22 18:04:56 -05:00
Scott Giese b4ba7db5c0 REVIEW: Memory Leak - SGMaterialLib::load()
10,240 (1,440 direct, 8,800 indirect) bytes in 60 blocks are definitely lost
2020-08-22 17:57:54 -05:00
Scott Giese bdd7878d19 REVIEW: Memory Leak - condition::readAndConditions()
11,502 (1,560 direct, 9,942 indirect) bytes in 39 blocks are definitely lost
2020-08-22 17:42:58 -05:00
Scott Giese f210d6ba94 REVIEW: Memory Leak - SGPropertyNode::getChild()
12,862 (11,856 direct, 1,006 indirect) bytes in 78 blocks are definitely lost
2020-08-22 17:39:58 -05:00
Scott Giese 0807a6ddf7 REVIEW: Memory Leak - SGPropertyNode::addChangeListener
24,928 bytes in 164 blocks are indirectly lost
2020-08-22 17:37:39 -05:00
Scott Giese ea53e9af0c REVIEW: Memory Leak - UniformFactoryImpl::getUniform()
13,800 bytes in 69 blocks are indirectly lost
2020-08-22 17:36:43 -05:00
Scott Giese bcb22691fc REVIEW: Memory Leak - SGTexturedTriangleBin::buildGeometry()
42,560 bytes in 280 blocks are definitely lost
2020-08-22 17:10:43 -05:00
Scott Giese 34ca004e95 REVIEW: Memory Leak - SGMaterial::read_properties()
61,560 bytes in 405 blocks are definitely lost
2020-08-22 16:57:21 -05:00
Scott Giese 53487ae732 // REVIEW: Memory Leak - HTTPRepository copy-ctor
93,275 bytes in 2,275 blocks are indirectly lost
2020-08-22 16:16:38 -05:00
Scott Giese 685866ffa7 // REVIEW: Memory Leak - nasal newBlock()
113,376 bytes in 1 blocks are still reachable
2020-08-22 16:11:52 -05:00
Scott Giese e3ce59ee80 REVIEW: Memory Leak - Effect::buildAttribute()
144,400 bytes in 38 blocks are indirectly lost
2020-08-22 16:08:58 -05:00
Scott Giese ce019a169b REVIEW: Memory Leak - EffectBuilder::InitFromParameters()
156,910 (2,320 direct, 154,590 indirect) bytes in 29 blocks are definitely lost
2020-08-22 15:53:25 -05:00
Scott Giese 03a76a1805 REVIEW: Memory Leak - hash::resize()
196,628 bytes in 1 blocks are still reachable
2020-08-22 15:40:07 -05:00
Scott Giese 8f76c2b401 REVIEW: Memory Leak - SGPath::append()
212,955 bytes in 2,277 blocks are indirectly lost
2020-08-22 15:28:37 -05:00
Scott Giese 39b83cdb51 REVIEW: Memory Leak - ModelRegistry
262,144 bytes in 1 blocks are indirectly lost
2020-08-22 15:09:46 -05:00
Scott Giese 10ffa82ea6 REVIEW: Memory Leak - ChildInfo copy-ctor
447,264 bytes in 39 blocks are indirectly lost
2020-08-22 14:59:27 -05:00