mirror of
https://github.com/vector-im/element-call.git
synced 2026-02-20 04:57:03 +00:00
Don't trigger keyboard shortcuts if modifiers are held
None of these keyboard shortcuts expect modifier keys, so they should in fact expect the absence of modifiers.
This commit is contained in:
@@ -93,6 +93,16 @@ test("reactions can be sent via keyboard presses", async () => {
|
||||
}
|
||||
});
|
||||
|
||||
test("reaction is not sent when modifier key is held", async () => {
|
||||
const user = userEvent.setup();
|
||||
|
||||
const sendReaction = vi.fn();
|
||||
render(<TestComponent sendReaction={sendReaction} />);
|
||||
|
||||
await user.keyboard("{Meta>}1{/Meta}");
|
||||
expect(sendReaction).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
test("raised hand can be sent via keyboard presses", async () => {
|
||||
const user = userEvent.setup();
|
||||
|
||||
|
||||
@@ -43,6 +43,8 @@ export function useCallViewKeyboardShortcuts(
|
||||
(event: KeyboardEvent) => {
|
||||
if (focusElement.current === null) return;
|
||||
if (!mayReceiveKeyEvents(focusElement.current)) return;
|
||||
if (event.altKey || event.ctrlKey || event.metaKey || event.shiftKey)
|
||||
return;
|
||||
|
||||
if (event.key === "m") {
|
||||
event.preventDefault();
|
||||
|
||||
Reference in New Issue
Block a user