Review

https://github.com/element-hq/element-call/pull/2475#pullrequestreview-2175298702

src/analytics/PosthogSpanProcessor.ts

@@ -161,8 +161,7 @@ export class PosthogSpanProcessor implements SpanProcessor {
   /**
    * Shutdown the processor.
    */
-  // eslint-disable-next-line @typescript-eslint/require-await
   public async shutdown(): Promise<void> {
-    return;
+    return Promise.resolve();
   }
 }

src/config/Config.ts

@@ -35,14 +35,10 @@ export class Config {
       return Config.internalInstance.initPromise;
     }
     Config.internalInstance = new Config();
-    Config.internalInstance.initPromise = new Promise<void>(
-      (resolve, reject) => {
-        downloadConfig("../config.json")
-          .then((config) => {
-            Config.internalInstance.config = { ...DEFAULT_CONFIG, ...config };
-            resolve();
-          })
-          .catch(reject);
+
+    Config.internalInstance.initPromise = downloadConfig("../config.json").then(
+      (config) => {
+        Config.internalInstance.config = { ...DEFAULT_CONFIG, ...config };
       },
     );
     return Config.internalInstance.initPromise;

src/rtcSessionHelpers.ts

@@ -36,7 +36,6 @@ export function makeActiveFocus(): LivekitFocusActive {
   };
 }
 
-// eslint-disable-next-line @typescript-eslint/require-await
 async function makePreferredLivekitFoci(
   rtcSession: MatrixRTCSession,
   livekitAlias: string,
@@ -84,8 +83,7 @@ async function makePreferredLivekitFoci(
       `No livekit_service_url is configured so we could not create a focus.
     Currently we skip computing a focus based on other users in the room.`,
     );
-
-  return preferredFoci;
+  return Promise.resolve(preferredFoci);
 
   // TODO: we want to do something like this:
   //