mirror of
https://github.com/vector-im/element-call.git
synced 2026-11-07 00:52:28 +00:00
Name the upstream cause behind the transformer's update override
@livekit/track-processors skips a frame on `isDisabled ?? backgroundDisabled`, and `isDisabled` is never undefined, so a disabled effect that keeps its blur radius is still segmented and drawn on every frame. Still the case in 0.8.2. The override stays until that is fixed upstream. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
b04237fada
commit
5fa2c2bec7
@@ -53,9 +53,12 @@ const wasmFileset: WasmFileset = {
|
||||
*/
|
||||
export class BackgroundEffectTransformer extends BackgroundTransformer {
|
||||
/**
|
||||
* As the library's, except that disabling also drops the blur radius: kept,
|
||||
* it has every frame segmented and the result thrown away, where with
|
||||
* neither a radius nor a picture frames are passed on untouched.
|
||||
* As the library's, except that disabling also drops the blur radius. The
|
||||
* library skips a frame on `isDisabled ?? backgroundDisabled`, and
|
||||
* `isDisabled` is never undefined, so a disabled effect that keeps its
|
||||
* radius has every frame segmented and drawn for nothing. With neither a
|
||||
* radius nor a picture, frames are passed on untouched.
|
||||
* TODO: drop once fixed upstream in livekit/track-processors-js (still in 0.8.2).
|
||||
*/
|
||||
public override async update(opts: BackgroundOptions): Promise<void> {
|
||||
await super.update(
|
||||
|
||||
Reference in New Issue
Block a user