Address review feedback

This commit is contained in:
Robin
2025-06-18 15:42:56 -04:00
parent 032e1e438c
commit bb414d975e

View File

@@ -71,11 +71,6 @@ export function useAudioContext<S extends string>(
props: Props<S>,
): UseAudioContext<S> | null {
const [soundEffectVolume] = useSetting(soundEffectVolumeSetting);
const devices = useMediaDevices();
const audioOutputId = useObservableEagerState(
devices.audioOutput.selected$,
)?.id;
const { controlledAudioDevices } = useUrlParams();
const [audioContext, setAudioContext] = useState<AudioContext>();
const [audioBuffers, setAudioBuffers] = useState<Record<S, AudioBuffer>>();
@@ -112,6 +107,11 @@ export function useAudioContext<S extends string>(
};
}, [props.sounds, props.latencyHint]);
const audioOutputId = useObservableEagerState(
useMediaDevices().audioOutput.selected$,
)?.id;
const { controlledAudioDevices } = useUrlParams();
// Update the sink ID whenever we change devices.
useEffect(() => {
if (