Compare commits

..
4 Commits
Author SHA1 Message Date
Timo ed62dc8cde Merge pull request #4487 from element-hq/toger5/backport-4403-publish-late-device
[backport] publish late device
2026-11-20 18:21:14 +01:00
Timo c7f62e692e Merge pull request #4488 from element-hq/toger5/backport-4479-exact-device-constraint
[backport] exact device constraint (fix chrome device switching)
2026-11-20 18:12:05 +01:00
TimoandClaude Fable 5.2 f0675f26ab Publish late device (#4485)
* Publish a camera or microphone listed after the call view opened

Without a lobby the call decides what to publish once, as its view
mounts. A device the browser listed a moment later switched to its
default "on" without the mute handler being asked, so the button showed
on and nothing was published: the other side kept waiting for media.

The default is now asked of the handler like any other request where one
is set, so the call publishes the device. A device that comes back while
a handler is set stays off, since the user may have turned it off; the
button used to show it as on there too. Without a handler, as in the
lobby, the default is assumed at once as before.

Follows the patch tiran133 posted on the issue. A stop-gap until one
reconciler owns the local media.

Fixes https://github.com/element-hq/element-call/issues/4403

---------

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-20 18:11:08 +01:00
Timo 5d6490cbea Merge pull request #4486 from element-hq/toger5/4479-exact-device-constraint
Exact device constraint (fixes chrome device switches)
2026-11-20 18:03:19 +01:00
7 changed files with 8 additions and 57 deletions
+2 -2
View File
@@ -19,10 +19,10 @@ services:
- ./backend/playwright_homeserver-othersite.yaml:/data/cfg/homeserver.yaml:Z
element-web:
# Pin to a SHA so that upstream cannot break our tests. Renovate handles regular updates.
image: ghcr.io/element-hq/element-web:develop@sha256:2f9e5d993e20adbd062453fd1c437821d554bac1f22ed3177290b7911f667848
image: ghcr.io/element-hq/element-web:develop@sha256:f85350f2b31a7521a800d9050e9f5c0676d04cfb60675242ccc0c6e25cad7d04
element-web-1:
# Pin to a SHA so that upstream cannot break our tests. Renovate handles regular updates.
image: ghcr.io/element-hq/element-web:develop@sha256:2f9e5d993e20adbd062453fd1c437821d554bac1f22ed3177290b7911f667848
image: ghcr.io/element-hq/element-web:develop@sha256:f85350f2b31a7521a800d9050e9f5c0676d04cfb60675242ccc0c6e25cad7d04
volumes:
# The other site opens the embedded package under test in place of the
# copy its image bundles (the first site opens the dev server's app.
-36
View File
@@ -1,36 +0,0 @@
/*
Copyright 2026 Element Creations Ltd.
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
Please see LICENSE in the repository root for full details.
*/
import { expect, test } from "@playwright/test";
import { SpaHelpers } from "./spa-helpers.ts";
test("The full screen button can be clicked while the footer overlays the video", async ({
page,
}) => {
await page.goto("/");
await SpaHelpers.createCall(page, "John Doe", "ShortWindow", true);
await SpaHelpers.expectVideoTilesCount(page, 1);
const fullScreenButton = page.getByRole("button", { name: "maximise" });
const footer = page.getByTestId("footer-container");
// Short enough for the footer to be drawn over the video
await page.setViewportSize({ width: 1000, height: 500 });
await expect(fullScreenButton).toBeVisible();
await page.getByTestId("videoTile").first().hover();
await expect(footer).toHaveCSS("opacity", "1");
const buttonBox = (await fullScreenButton.boundingBox())!;
const footerBox = (await footer.boundingBox())!;
expect(buttonBox.y + buttonBox.height).toBeLessThanOrEqual(footerBox.y);
await fullScreenButton.click();
await expect
.poll(async () => page.evaluate(() => document.fullscreenElement !== null))
.toBe(true);
});
+3 -5
View File
@@ -5,7 +5,7 @@
"schedule:monthly",
":enableVulnerabilityAlertsWithLabel(security)"
],
"labels": ["dependencies"],
"addLabels": ["dependencies"],
"minimumReleaseAge": "5 days",
"packageRules": [
{
@@ -16,8 +16,7 @@
{
"groupName": "GitHub Actions",
"matchDepTypes": ["action"],
"pinDigests": true,
"labels": ["PR-Task"]
"pinDigests": true
},
{
"description": "Disable Renovate for packages we want to monitor ourselves",
@@ -70,8 +69,7 @@
"matchUpdateTypes": ["digest"],
"schedule": ["* 0-3 * * *"],
"minimumReleaseAge": null,
"automerge": true,
"labels": ["PR-Task"]
"automerge": true
}
],
"semanticCommits": "disabled",
+2 -6
View File
@@ -16,16 +16,12 @@ The following sound effects have been licensed from Pixabay, under https://pixab
The following sound effects have been originally created by Element.
- `blocked`
- `end_talk`
- `start_talk_local`
- `start_talk_remote`
- `join_call`
- `left_call`
- `screen_share_started`
- `ringtone`
- `call_declined`
- `call_timeout`
- `end_call`
- `reactions/rock`
- `reactions/wave`
- `reactions/baduntss`
- `reactions/deer`
+1 -4
View File
@@ -111,10 +111,7 @@ Please see LICENSE in the repository root for full details.
display: flex;
gap: var(--cpd-space-2x);
position: absolute;
/* Ensure that the buttons lie within the safe area */
inset-block-end: calc(
var(--call-view-safe-area-inset-bottom, 0px) + var(--cpd-space-1x)
);
inset-block-end: var(--cpd-space-1x);
inset-inline-end: var(--cpd-space-1x);
z-index: 1;
}
-2
View File
@@ -67,7 +67,6 @@ describe("widget", () => {
ElementCallReactionEventType,
EventType.RTCDecline,
EventType.RTCMembership,
"m.rtc.member",
];
const sendState = [
@@ -101,7 +100,6 @@ describe("widget", () => {
EventType.CallSDPStreamMetadataChangedPrefix,
EventType.CallReplaces,
EventType.CallEncryptionKeysPrefix,
"m.rtc.encryption_key",
];
expect(createRoomWidgetClientSpy.mock.calls[0][1]).toStrictEqual({
-2
View File
@@ -132,7 +132,6 @@ export const initializeWidget = (
ElementCallReactionEventType,
EventType.RTCDecline,
EventType.RTCMembership,
"m.rtc.member",
];
const sendState = [
@@ -163,7 +162,6 @@ export const initializeWidget = (
EventType.CallSDPStreamMetadataChangedPrefix,
EventType.CallReplaces,
EventType.CallEncryptionKeysPrefix,
"m.rtc.encryption_key",
];
const client = createRoomWidgetClient(