Simplify condition and remove unused method

2017-09-11 19:31:38 +02:00
parent 9aa5a9e850
commit 03babcb43b
1 changed files with 1 additions and 5 deletions
@@ -186,7 +186,7 @@ module.exports = class NumericHistogram extends BaseHistogram {
        return `
            WITH
            ${filteredQueryTpl(ctx)},
-            ${this._shouldOverride(ctx._override) ? overrideBasicsQueryTpl(ctx) : basicsQueryTpl(ctx)},
+            ${this._shouldOverrideRange(ctx._override) ? overrideBasicsQueryTpl(ctx) : basicsQueryTpl(ctx)},
            ${this._shouldOverrideBins(ctx._override) ?
                overrideBinsQueryTpl(ctx) :
                `${iqrQueryTpl(ctx)}, ${binsQueryTpl(ctx)}`
@@ -197,10 +197,6 @@ module.exports = class NumericHistogram extends BaseHistogram {
        `;
    }

-    _shouldOverride (override) {
-        return this._shouldOverrideRange(override) && this._shouldOverrideBins(override);
-    }
-
    _shouldOverrideRange (override) {
        return override && override.hasOwnProperty('start') && override.hasOwnProperty('end');
    }