cartodb4/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Early return is the way to go. Avoid checking conditions later

Browse Source
This commit is contained in:
Daniel García Aubert
2018-08-01 17:39:08 +02:00
parent 78f4cf3155
commit 732a2d7742
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/cartodb/models/mapconfig/adapter/mapconfig-overviews-adapter.js
+8 -8
View File
@@ -66,15 +66,17 @@ function augmentLayer(overviewsMetadataBackend, filterStatsBackend, user, layer,
return callback(err, layer);
}
if (_.isEmpty(metadata)) {
return callback(null, layer);
}
queryRewriteData.overviews = metadata;
var filters = queryRewriteData.filters;
if (!filters) {
if (!_.isEmpty(metadata)) {
layer = Object.assign({}, layer);
layer.options = Object.assign({}, layer.options, { query_rewrite_data: queryRewriteData });
}
layer = Object.assign({}, layer);
layer.options = Object.assign({}, layer.options, { query_rewrite_data: queryRewriteData });
return callback(null, layer);
}
@@ -88,10 +90,8 @@ function augmentLayer(overviewsMetadataBackend, filterStatsBackend, user, layer,
queryRewriteData.filter_stats = stats;
if (!_.isEmpty(metadata)) {
layer = Object.assign({}, layer);
layer.options = Object.assign({}, layer.options, { query_rewrite_data: queryRewriteData });
}
layer = Object.assign({}, layer);
layer.options = Object.assign({}, layer.options, { query_rewrite_data: queryRewriteData });
return callback(null, layer);
});