add dataview type to overviews logs

This commit is contained in:
Eneko Lakasta
2018-08-30 14:30:03 +02:00
parent c9d50c412d
commit 7c52f504e5
2 changed files with 18 additions and 2 deletions
+3
View File
@@ -39,6 +39,9 @@ module.exports = class BaseDataview {
if (flags && flags.usesOverviews) {
stats.usesOverviews = true;
if (this.getType) {
stats.dataviewType = this.getType();
}
}
return callback(null, result, stats);
+15 -2
View File
@@ -271,6 +271,7 @@ describe('dataviews using tables with overviews', function() {
"type":"formula"
});
assert.ok(getUsesOverviewsFromHeaders(headers)); //Overviews logging
assert(getDataviewTypeFromHeaders(headers) === 'formula'); //Overviews logging
testClient.drain(done);
});
@@ -291,6 +292,7 @@ describe('dataviews using tables with overviews', function() {
"nans": 0
});
assert.ok(getUsesOverviewsFromHeaders(headers)); //Overviews logging
assert(getDataviewTypeFromHeaders(headers) === 'formula'); //Overviews logging
testClient.drain(done);
});
@@ -311,6 +313,7 @@ describe('dataviews using tables with overviews', function() {
"nans": 0
});
assert.ok(getUsesOverviewsFromHeaders(headers)); //Overviews logging
assert(getDataviewTypeFromHeaders(headers) === 'formula'); //Overviews logging
testClient.drain(done);
});
@@ -386,6 +389,8 @@ describe('dataviews using tables with overviews', function() {
assert.equal(histogram.type, 'histogram');
assert.ok(Array.isArray(histogram.bins));
assert.ok(getUsesOverviewsFromHeaders(headers)); //Overviews logging
assert(getDataviewTypeFromHeaders(headers) === 'histogram'); //Overviews logging
testClient.drain(done);
});
});
@@ -594,10 +599,11 @@ describe('dataviews using tables with overviews', function() {
it("should expose an aggregation dataview filtering special float values out", function (done) {
var testClient = new TestClient(overviewsMapConfig);
testClient.getDataview('test_categories_special_values', params, function (err, dataview) {
testClient.getDataview('test_categories_special_values', params, function (err, dataview, headers) {
if (err) {
return done(err);
}
assert.deepEqual(dataview, {
aggregation: 'sum',
count: 5,
@@ -610,6 +616,10 @@ describe('dataviews using tables with overviews', function() {
categories: [ { category: 'Hawai', value: 6, agg: false } ],
type: 'aggregation'
});
assert.ok(getUsesOverviewsFromHeaders(headers)); //Overviews logging
assert(getDataviewTypeFromHeaders(headers) === 'aggregation'); //Overviews logging
testClient.drain(done);
});
});
@@ -656,7 +666,10 @@ describe('dataviews using tables with overviews', function() {
});
});
function getUsesOverviewsFromHeaders(headers) {
return headers && headers['x-tiler-profiler'] && JSON.parse(headers['x-tiler-profiler']).usesOverviews;
}
function getDataviewTypeFromHeaders(headers) {
return headers && headers['x-tiler-profiler'] && JSON.parse(headers['x-tiler-profiler']).dataviewType;
}