Use express router to group controllers' enpoints and reuse common middleware for analysis controller

lib/cartodb/controllers/analyses.js

@@ -20,11 +20,14 @@ util.inherits(AnalysesController, BaseController);
 
 module.exports = AnalysesController;
 
-AnalysesController.prototype.register = function(app) {
-    app.get(
-        app.base_url_mapconfig + '/analyses/catalog',
+AnalysesController.prototype.register = function(router) {
+    router.use(
         cors(),
-        userMiddleware,
+        userMiddleware
+    );
+
+    router.get(
+        '/analyses/catalog',
         this.req2paramsMiddleware,
         this.catalog.bind(this)
     );

lib/cartodb/server.js

@@ -255,7 +255,11 @@ module.exports = function(serverOptions) {
 
     new controller.NamedMapsAdmin(authApi, pgConnection, templateMaps).register(app);
 
-    new controller.Analyses(authApi, pgConnection).register(app);
+    const analysisRouter = express.Router();
+
+    new controller.Analyses(authApi, pgConnection).register(analysisRouter);
+
+    app.use(app.base_url_mapconfig, analysisRouter);
 
     new controller.ServerInfo(versions).register(app);