Release 1.8.5

.gitignore

@@ -5,5 +5,3 @@ config/environments/*.js
 tools/munin/windshaft.conf
 logs/
 pids/
-redis.pid
-test.log

.travis.yml

@@ -1,13 +1,15 @@
-addons:
-  postgresql: "9.3"
-
 before_install:
-  - sudo apt-get install -y pkg-config libcairo2-dev libjpeg8-dev libgif-dev
+  - sudo apt-add-repository --yes ppa:mapnik/v2.1.0
+  - sudo apt-get update -q
+  - sudo apt-get install -q libmapnik-dev
   - createdb template_postgis
   - psql -c "CREATE EXTENSION postgis" template_postgis
+  # Tell npm to use known registrars:
+  # see http://blog.npmjs.org/post/78085451721/npms-self-signed-certificate-is-no-more
+  - npm config set ca ""
 
 env:
-  - NPROCS=1 JOBS=1 PGUSER=postgres
+  - NPROCS=1 JOBS=1
 
 language: node_js
 node_js:

HOWTO_RELEASE

@@ -1,20 +1,13 @@
-1. Test (make clean all check), fix if broken before proceeding
-2. Ensure proper version in package.json 
-3. Ensure NEWS section exists for the new version, review it, add release date
-4. Drop npm-shrinkwrap.json
-5. Run npm shrinkwrap to recreate npm-shrinkwrap.json
-6. Commit package.json, npm-shrinwrap.json, NEWS
-7. git tag -a Major.Minor.Patch # use NEWS section as content
-8. Announce on cartodb@googlegroups.com
-9. Stub NEWS/package for next version
+1. Ensure proper version in package.json 
+2. Ensure NEWS section exists for the new version, review it, add release date
+3. Drop npm-shrinkwrap.json
+4. Run npm install
+5. Test (make check or npm test), fix if broken before proceeding
+6. Run npm shrinkwrap
+7. Set "from" in npm-shrinkwrap.json for known packages
+   (windshaft, node-varnish, grainstore...)
+8. Commit package.json, npm-shrinwrap.json, NEWS
+9. git tag -a Major.Minor.Patch # use NEWS section as content
+10. Announce
+11. Stub NEWS/package for next version
 
-Versions:
-
-Bugfix releases increment Patch component of version.
-Feature releases increment Minor and set Patch to zero.
-If backward compatibility is broken, increment Major and
-set to zero Minor and Patch.
-
-Branches named 'b<Major>.<Minor>' are kept for any critical
-fix that might need to be shipped before next feature release
-is ready.

LICENCE

@@ -0,0 +1,27 @@
+Copyright (c) 2011, Vizzuality 
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+1. Redistributions of source code must retain the above copyright
+   notice, this list of conditions and the following disclaimer.
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+3. All advertising materials mentioning features or use of this software
+   must display the following acknowledgement:
+   This product includes software developed by Vizzuality.
+4. Neither the name of Vizzuality nor the
+   names of its contributors may be used to endorse or promote products
+   derived from this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS "AS IS" AND ANY
+EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY
+DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

LICENSE

@@ -1,27 +0,0 @@
-Copyright (c) 2014, Vizzuality
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without 
-modification, are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice, this 
-list of conditions and the following disclaimer.
-
-2. Redistributions in binary form must reproduce the above copyright notice, 
-this list of conditions and the following disclaimer in the documentation 
-and/or other materials provided with the distribution.
-
-3. Neither the name of the copyright holder nor the names of its contributors 
-may be used to endorse or promote products derived from this software without 
-specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE 
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
-SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 
-CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, 
-OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

NEWS.md

@@ -1,344 +1,3 @@
-1.26.2 -- 2015-01-28
---------------------
-
-Bugfixes:
- - Accept 'open' string in templates' `auth` as authorized.
-
-
-1.26.1 -- 2015-01-28
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.35.1, see https://github.com/CartoDB/Windshaft/pull/254
-
-
-1.26.0 -- 2015-01-27
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.35.0, supports mapconfig version `1.3.0`
-
-
-1.25.0 -- 2015-01-26
---------------------
-
-Announcements:
- - No more signed maps (#227 and #238)
-    - Splits template maps endpoint into its own controller
-    - Removes TemplateMaps dependency on SignedMaps
-     - Token validation is done against the template
-     - Template is always extended with default values for auth and placeholders
-     - MapConfig is extended, in order to validate auth_tokens, with template info:
-        - template name
-        - template auth
-     - No more locks to create, update or delete templates
-        - Trusting in redis' hash semantics
-        - Some tradeoffs:
-            * A client having more templates than allowed by a race condition between limit (HLEN) check and creation (HSET)
-            * Updating a template could happen while deleting it, resulting in a new template
-            * Templates already instantiated will be accessible through their layergroup so it is possible to continue requesting tiles/grids/etc.
-     - Authorisation is now handled by template maps
-    - Template instantiation returns new instances with default values if they are missing
-
-
-New features:
- - Basic layergroup validation on named map creation/update (#196)
- - Add named maps surrogate keys and call invalidation on template modification/deletion (#247)
-    - Extends TemplateMaps backend with EventEmitter
-        - Emits for create, update and delete templates
-    - VarnishHttpCacheBackend will invalidate a varnish instance via HTTP PURGE method
-        - In the future there could be more backends, for instance to invalidate a CDN.
-    - NamedMapsEntry has the responsibility to generate a cache key for a named map
-        - It probably should receive a template/named map instead of owner and template name
-    - SurrogateKeysCache is responsible to tag responses with a header
-        - It also is responsible for invalidations given an Invalidation Backend
-        - In the future it could have several backends so it can invalidates different caches
-    - SurrogateKeysCache is subscribed to TemplateMaps events to do the invalidations
-
-
-1.24.0 -- 2015-01-15
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.34.0 for retina support
-
-
-1.23.1 -- 2015-01-14
---------------------
-
-Announcements:
- - Regenerate npm-shrinkwrap.json
-
-
-1.23.0 -- 2015-01-14
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.33.0
-
-New features:
- - Sets HTTP renderer configuration in server_options
-
-
-1.22.0 -- 2015-01-13
---------------------
-
-New features:
- - Health check endpoint
-
-
-1.21.2 -- 2014-12-15
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.32.4
-
-
-1.21.1 -- 2014-12-11
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.32.2
-
-Bugfixes:
- - Closes fd for log files on `kill -HUP` (#230)
-
-
-
-1.21.0 -- 2014-10-24
---------------------
-
-New features:
- - Allow a different cache-control max-age for layergroup responses
-
-
-1.20.2 -- 2014-10-20
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.31.0
-
-
-1.20.1 -- 2014-10-17
---------------------
-
-Announcements:
- - Upgrades redis-mpool to 0.3.0
-
-
-1.20.0 -- 2014-10-15
---------------------
-
-New features:
- - Report to statsd the status of redis pools
- - Upgrades Windshaft to start reporting redis/renderers/mapnik pool metrics
-
-Enhancements:
- - Share one redis-mpool across the application
-
-
-1.19.0 -- 2014-10-14
---------------------
-
-Announcements:
- - Dropping support for npm <1.2.1
-   npm-shrinkwrap.json is incompatible when generated with npm >=1.2.1 and consumed by npm <1.2.1
- - Upgrades windshaft to 0.28.2
- - Generates npm-shrinkwrap.json with npm >1.2.0
-
-
-1.18.2 -- 2014-10-13
---------------------
-
-Bug fixes:
- - Defaults resultSet to object if undefined in QueryTablesApi
-
-Announcements:
- - Upgrades windshaft to 0.28.1
-
-
-1.18.1 -- 2014-10-13
---------------------
-
-New features:
- - Allow to add more node.js' threadpool workers via process.env.UV_THREADPOOL_SIZE
-
-
-1.18.0 -- 2014-10-03
---------------------
-
-Announcements:
- - Comes back to use mapnik 2.3.x based on cartodb/node-mapnik@1.4.15-cdb from windshaft@0.28.0
-
-
-1.17.2 -- 2014-10-01
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.27.2 which downgrades node-mapnik to 0.7.26-cdb1
-
-
-1.17.1 -- 2014-09-30
---------------------
-
-Announcements:
- - Upgrades windshaft to 0.27.1 which downgrades node-mapnik to 1.4.10
-
-Enhancements:
- - TTL for template locks so they are not kept forever
- - Upgrades mocha
-
-
-1.17.0 -- 2014-09-25
---------------------
-
-New features:
- - Starts using mapnik 2.3.x
-
-Enhancements:
- - Upgrades windshaft and cartodb-redis
- - Supports `!scale_denominator!` dynamic param in SQL queries
- - Metrics revamp: removes and adds some metrics
- - Adds poolSize configuration for mapnik
-
-1.16.1 -- 2014-08-19
---------------------
-
-Enhancements:
- - Upgrades cartodb-redis
-
-1.16.0 -- 2014-08-18
---------------------
-
-New features:
- - Configurable QueryTablesAPI to call directly postgresql using cartodb-psql
-   or to keep using a request to the SQL API
-
-Enhancements:
- - Removes mapnik dependency as it now relies on Windshaft to check mapnik version
- - Upgrades dependencies:
-    - underscore
-    - lzma
-    - log4js
-    - rollbar
-    - windshaft
-    - request
-
-1.15.0 -- 2014-08-13
---------------------
-Enhancements:
- - Upgrades dependencies:
-    - redis-mpool
-    - cartodb-redis
-    - windshaft
- - Specifies name in the redis pool
- - Slow pool configuration in example configurations
-
-
-1.14.0 -- 2014-08-07
---------------------
-
-Enhancements:
- - SQL API requests moved to its own entity
-
-New features:
- - Affected tables and last updated time for a query are performed in a single
-   request to the SQL API
- - Allow specifying the tile format, upgrades windshaft and grainstore
-   dependencies for this matter
-
-
-1.13.1 -- 2014-08-04
---------------------
-
-Enhancements:
- - Profiler header sent as JSON string
-
-
-1.13.0 -- 2014-07-30
---------------------
-
-New features:
- - Support for postgresql schemas
- - Use public user from redis
- - Support for several auth tokens
-
-1.12.1 -- 2014-06-24
---------------------
-
-Enhancements:
- - Caches layergroup and sets X-Cache-Channel in GET requests also in named maps
-
-1.12.0 -- 2014-06-24
---------------------
-
-New features:
- - Caches layergroup and sets X-Cache-Channel in GET requests
-
-1.11.1 -- 2014-05-07
---------------------
-
-Enhancements:
-
- - Upgrade Windshaft to 0.21.0, see
- http://github.com/CartoDB/Windshaft/blob/0.21.0/NEWS
-
-1.11.0 -- 2014-04-28
---------------------
-
-New features:
-
- - Add support for log_filename directive
- - Reopen log file on SIGHUP, for better logrotate integration
-
-Enhancements:
-
- - Set default PostgreSQL application name to "cartodb_tiler"
-
-1.10.2 -- 2014-04-08
---------------------
-
-Bug fixes:
-
- - Fix show_style tool broken since 1.8.1
- - Fix X-Cache-Channel of tiles accessed via signed token (#188)
-
-1.10.1 -- 2014-03-21
---------------------
-
-Bug fixes:
-
- - Do not cache non-success jsonp responses (#186)
-
-1.10.0 -- 2014-03-20
---------------------
-
-New features:
-
- - Add optional support for rollbar (#150)
-
-Enhancements:
-
- - Do not send connection details to client (#183)
- - Upgrade node-varnish to 0.3.0
- - Upgrade Windshaft to 0.20.0, see
-   http://github.com/CartoDB/Windshaft/blob/0.20.0/NEWS
- - Include tiler version in startup log
- - Install an uncaught exception handler
- - Require own fork of node-mapnik, with temptative fix
-   for libxml usage (glibc detected corruptions)
-
-Other changes:
-
- - Switch to 3-clause BSD license (#184)
-
-1.9.0 -- 2014-03-10
--------------------
-
-New features:
-
- - Allow to set server related configuration in serverMetadata (#182)
-
 1.8.5 -- 2014-03-10
 -------------------
 

app.js

@@ -7,11 +7,6 @@
  * environments: [development, production]
  */
 
-var path = require('path'),
-    fs = require('fs'),
-    RedisPool = require('redis-mpool')
-;
-
 
 if ( process.argv[2] ) ENV = process.argv[2];
 else if ( process.env['NODE_ENV'] ) ENV = process.env['NODE_ENV'];
@@ -26,69 +21,30 @@ if (ENV != 'development' && ENV != 'production' && ENV != 'staging' ){
     process.exit(1);
 }
 
-var _ = require('underscore');
-
+var _ = require('underscore')
+    , Step       = require('step')
+    ;
 // set environment specific variables
+global.settings     = require(__dirname + '/config/settings');
 global.environment  = require(__dirname + '/config/environments/' + ENV);
-global.environment.api_hostname = require('os').hostname().split('.')[0];
+_.extend(global.settings, global.environment);
 
-global.log4js = require('log4js');
-log4js_config = {
-  appenders: [],
-  replaceConsole:true
-};
-
-if (global.environment.uv_threadpool_size) {
-    process.env.UV_THREADPOOL_SIZE = global.environment.uv_threadpool_size;
-}
-
-if ( global.environment.log_filename ) {
-  var logdir = path.dirname(global.environment.log_filename);
-  // See cwd inlog4js.configure call below
-  logdir = path.resolve(__dirname, logdir);
-  if ( ! fs.existsSync(logdir) ) {
-    console.error("Log filename directory does not exist: " + logdir);
-    process.exit(1);
-  }
-  console.log("Logs will be written to " + global.environment.log_filename);
-  log4js_config.appenders.push(
-    { type: "file", filename: global.environment.log_filename }
-  );
-} else {
-  log4js_config.appenders.push(
+global.log4js = require('log4js')
+log4js.configure({
+  appenders: [
     { type: "console", layout: { type:'basic' } }
-  );
-}
+  ],
+  replaceConsole:true
+});
 
-if ( global.environment.rollbar ) {
-  log4js_config.appenders.push({
-    type: __dirname + "/lib/cartodb/log4js_rollbar.js",
-    options: global.environment.rollbar
-  });
-}
-
-log4js.configure(log4js_config, { cwd: __dirname });
-global.logger = log4js.getLogger();
-
-var redisOpts = _.extend(global.environment.redis, { name: 'windshaft' }),
-    redisPool = new RedisPool(redisOpts);
 
 // Include cartodb_windshaft only _after_ the "global" variable is set
 // See https://github.com/Vizzuality/Windshaft-cartodb/issues/28
-var CartodbWindshaft = require('./lib/cartodb/cartodb_windshaft'),
-    serverOptions = require('./lib/cartodb/server_options')(redisPool);
+var CartodbWindshaft = require('./lib/cartodb/cartodb_windshaft');
+var serverOptions = require('./lib/cartodb/server_options')();
 
 ws = CartodbWindshaft(serverOptions);
 
-if (global.statsClient) {
-    redisPool.on('status', function(status) {
-        var keyPrefix = 'windshaft.redis-pool.' + status.name + '.db' + status.db + '.';
-        global.statsClient.gauge(keyPrefix + 'count', status.count);
-        global.statsClient.gauge(keyPrefix + 'unused', status.unused);
-        global.statsClient.gauge(keyPrefix + 'waiting', status.waiting);
-    });
-}
-
 // Maximum number of connections for one process
 // 128 is a good number if you have up to 1024 filedescriptors
 // 4 is good if you have max 32 filedescriptors
@@ -97,10 +53,8 @@ ws.maxConnections = global.environment.maxConnections || 128;
 
 ws.listen(global.environment.port, global.environment.host);
 
-var version = require("./package").version;
-
 ws.on('listening', function() {
-  console.log("Windshaft tileserver " + version + " started on "
+  console.log("Windshaft tileserver started on "
               + global.environment.host + ':' + global.environment.port
               + " (" + ENV + ")");
 });
@@ -115,14 +69,3 @@ process.on('SIGUSR2', function() {
   ws.dumpCacheStats();
 });
 
-process.on('SIGHUP', function() {
-    global.log4js.clearAndShutdownAppenders(function() {
-        global.log4js.configure(log4js_config);
-        global.logger = log4js.getLogger();
-        console.log('Log files reloaded');
-    });
-});
-
-process.on('uncaughtException', function(err) {
-  logger.error('Uncaught exception: ' + err.stack); 
-});

config/environments/development.js.example

@@ -2,7 +2,6 @@ var config = {
      environment: 'development'
     ,port: 8181
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
     // Regular expression pattern to extract username
     // from hostname. Must have a single grabbing block.
     ,user_from_host: '^(.*)\\.localhost'
@@ -32,15 +31,11 @@ var config = {
     // to be able to navigate the map without a reload ?
     // Defaults to 7200 (2 hours)
     ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds 
+    // idle socket timeout, in miliseconds 
     ,socket_timeout: 600000
     ,enable_cors: true
     ,cache_enabled: false
     ,log_format: ':req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    ,log_filename: undefined
     // Templated database username for authorized user
     // Supported labels: 'user_id' (read from redis)
     ,postgres_auth_user: 'development_cartodb_user_<%= user_id %>'
@@ -63,19 +58,9 @@ var config = {
         */
         row_limit: 65535,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         max_size: 500
     }
     ,mapnik_version: undefined
-    ,mapnik_tile_format: 'png8:m=h'
     ,statsd: {
         host: 'localhost',
         port: 8125,
@@ -87,15 +72,7 @@ var config = {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
       metatile: 4,
-      bufferSize: 64,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              'http://{s}.example.com/{z}/{x}/{y}.png'
-          ]
-      }
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -107,25 +84,13 @@ var config = {
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 1, // idle time before dropping connection
-        reapIntervalMillis: 1, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1 // time between cleanups
     }
     ,sqlapi: {
         protocol: 'http',
@@ -149,25 +114,14 @@ var config = {
     }
     ,varnish: {
         host: 'localhost',
-        port: 6082, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
+        port: 6082,
         secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
     ,useProfiler:true
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: false,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
 };
 
 module.exports = config;

config/environments/production.js.example

@@ -2,7 +2,6 @@ var config = {
     environment: 'production'
     ,port: 8181
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
     // Regular expression pattern to extract username
     // from hostname. Must have a single grabbing block.
     ,user_from_host: '^(.*)\\.cartodb\\.com$'
@@ -32,15 +31,11 @@ var config = {
     // to be able to navigate the map without a reload ?
     // Defaults to 7200 (2 hours)
     ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds
+    // idle socket timeout, in miliseconds
     ,socket_timeout: 600000 
     ,enable_cors: true
     ,cache_enabled: true
     ,log_format: ':req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    ,log_filename: 'logs/node-windshaft.log'
     // Templated database username for authorized user
     // Supported labels: 'user_id' (read from redis)
     ,postgres_auth_user: 'cartodb_user_<%= user_id %>'
@@ -56,20 +51,10 @@ var config = {
         port: 6432,
         extent: "-20037508.3,-20037508.3,20037508.3,20037508.3",
         row_limit: 65535,
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
         max_size: 500
     }
     ,mapnik_version: undefined
-    ,mapnik_tile_format: 'png8:m=h'
     ,statsd: {
         host: 'localhost',
         port: 8125,
@@ -81,15 +66,7 @@ var config = {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
       metatile: 4,
-      bufferSize: 64,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              'http://{s}.example.com/{z}/{x}/{y}.png'
-          ]
-      }
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -101,25 +78,13 @@ var config = {
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 30000, // idle time before dropping connection
-        reapIntervalMillis: 1000, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1000 // time between cleanups
     }
     ,sqlapi: {
         protocol: 'https',
@@ -143,40 +108,14 @@ var config = {
     }
     ,varnish: {
         host: 'localhost',
-        port: 6082, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
+        port: 6082,
         secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
     ,useProfiler:false
-    ,serverMetadata: {
-      cdn_url: {
-        http: 'api.cartocdn.com',
-        https: 'cartocdn.global.ssl.fastly.net'
-      }
-    }
-    // Optional rollbar support
-    ,rollbar: {
-      token: 'secret',
-      // See http://github.com/rollbar/node_rollbar#configuration-reference
-      options: {
-        endpoint: 'https://api.rollbar.com/api/1/',
-        handler: 'inline'
-      }
-    }
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: true,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
 };
 
 module.exports = config;

config/environments/staging.js.example

@@ -2,7 +2,6 @@ var config = {
     environment: 'production'
     ,port: 8181
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
     // Regular expression pattern to extract username
     // from hostname. Must have a single grabbing block.
     ,user_from_host: '^(.*)\\.cartodb\\.com$'
@@ -32,15 +31,11 @@ var config = {
     // to be able to navigate the map without a reload ?
     // Defaults to 7200 (2 hours)
     ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds
+    // idle socket timeout, in miliseconds
     ,socket_timeout: 600000 
     ,enable_cors: true
     ,cache_enabled: true
     ,log_format: ':req[X-Real-IP] :method :req[Host]:url :status :response-time ms (:res[X-Tiler-Profiler]) -> :res[Content-Type]'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    ,log_filename: 'logs/node-windshaft.log'
     // Templated database username for authorized user
     // Supported labels: 'user_id' (read from redis)
     ,postgres_auth_user: 'cartodb_staging_user_<%= user_id %>'
@@ -57,19 +52,9 @@ var config = {
         extent: "-20037508.3,-20037508.3,20037508.3,20037508.3",
         row_limit: 65535,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         max_size: 500
     }
     ,mapnik_version: undefined
-    ,mapnik_tile_format: 'png8:m=h'
     ,statsd: {
         host: 'localhost',
         port: 8125,
@@ -81,15 +66,7 @@ var config = {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
       metatile: 4,
-      bufferSize: 64,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              'http://{s}.example.com/{z}/{x}/{y}.png'
-          ]
-      }
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -101,25 +78,13 @@ var config = {
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 30000, // idle time before dropping connection
-        reapIntervalMillis: 1000, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1000 // time between cleanups
     }
     ,sqlapi: {
         protocol: 'https',
@@ -143,40 +108,14 @@ var config = {
     }
     ,varnish: {
         host: 'localhost',
-        port: 6082, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
+        port: 6082,
         secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
     ,useProfiler:true
-    ,serverMetadata: {
-      cdn_url: {
-        http: 'api.cartocdn.com',
-        https: 'cartocdn.global.ssl.fastly.net'
-      }
-    }
-    // Optional rollbar support
-    ,rollbar: {
-      token: 'secret',
-      // See http://github.com/rollbar/node_rollbar#configuration-reference
-      options: {
-        endpoint: 'https://api.rollbar.com/api/1/',
-        handler: 'inline'
-      }
-    }
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: false,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
 };
 
 module.exports = config;

config/environments/test.js.example

@@ -2,7 +2,6 @@ var config = {
      environment: 'test'
     ,port: 8888
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
     // Regular expression pattern to extract username
     // from hostname. Must have a single grabbing block.
     ,user_from_host: '(.*)'
@@ -32,15 +31,11 @@ var config = {
     // to be able to navigate the map without a reload ?
     // Defaults to 7200 (2 hours)
     ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds
+    // idle socket timeout, in miliseconds
     ,socket_timeout: 600000 
     ,enable_cors: true
     ,cache_enabled: false
     ,log_format: '[:date] :req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    //,log_filename: 'logs/node-windshaft.log'
     // Templated database username for authorized user
     // Supported labels: 'user_id' (read from redis)
     ,postgres_auth_user: 'test_windshaft_cartodb_user_<%= user_id %>'
@@ -57,19 +52,9 @@ var config = {
         extent: "-20037508.3,-20037508.3,20037508.3,20037508.3",
         row_limit: 65535,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         max_size: 500
     }
     ,mapnik_version: ''
-    ,mapnik_tile_format: 'png8:m=h'
     ,statsd: {
         host: 'localhost',
         port: 8125,
@@ -81,15 +66,7 @@ var config = {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
       metatile: 4,
-      bufferSize: 64,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              'http://{s}.example.com/{z}/{x}/{y}.png'
-          ]
-      }
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -101,25 +78,13 @@ var config = {
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 1, // idle time before dropping connection
-        reapIntervalMillis: 1, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1 // time between cleanups
     }
     ,sqlapi: {
         protocol: 'http',
@@ -145,25 +110,14 @@ var config = {
     }
     ,varnish: {
         host: '',
-        port: null, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
+        port: null,
         secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
     ,useProfiler:true
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: false,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
 };
 
 module.exports = config;

config/settings.js

@@ -0,0 +1 @@
+module.exports.oneDay   = 86400000;

docs/Map-API-internal.md

@@ -1,111 +0,0 @@
-# Kind of maps
-
-Windshaft-CartoDB supports the following types of maps:
-
- - [Temporary maps](#temporary-maps) (created by anyone)
-   - [Detached maps](#detached-maps)
-   - [Inline maps](#inline-maps) (legacy)
- - [Persistent maps](#peristent-maps) (created by CartDB user)
-   - [Template maps](#template-maps)
-   - [Table maps](#table-maps) (legacy, deprecated) 
-
-## Temporary maps
-
-Temporary maps have no owners and are anonymous in nature.
-There are two kinds of temporary maps:
-
- - Detached maps (aka MultiLayer-API)
- - Inline maps 
-
-### Detached maps
-
-Detached maps are maps that are configured with a request
-obtaining a temporary token and then used by referencing
-the obtained token. The token expires automatically when unused.
-
-Anyone can create detached maps, but users will need read access
-to the data source of the map layers.
-
-The configuration format is a [MapConfig]
-(http://github.com/CartoDB/Windshaft/wiki/MapConfig-specification) document.
-
-The HTTP endpoints for creating the map and using it are described [here]
-(http://github.com/CartoDB/Windshaft-cartodb/wiki/MultiLayer-API)
-
-*TODO* cleanup the referenced document
-
-### Inline maps
-
-Inline maps are maps that only exist for a single request,
-being the request for a specific map resource (tile).
-
-Inline maps are always bound to a table, and can only be
-obtained by those having read access to the that table.
-Additionally, users need to have access to any datasource
-specified as part of the configuration.
-
-Inline maps only support PNG and UTF8GRID tiles.
-
-The configuration consist in a set of parameters, to be
-specified in the query string of the tile request:
-
- * sql - the query to run as datasource, can be an array
- * style - the CartoCSS style for the datasource, can be an array
- * style_version - version of the CartoCSS style, can be an array
- * interactivity - only for fetching UTF8GRID, 
-
-If the style is not provided, style of the associated table is
-used; if the sql is not provided, all records of the associated
-table are used as the datasource; the two possibilities result
-in a mix between _inline_ maps and [Table maps][].
-
-*TODO* specify (or link) api endpoints
-
-## Persistent maps
-
-Persistent maps can only be created by a CartoDB user who has full
-responsibility over editing and deleting them. There are two
-kind of persistent maps:
-
- - Template maps 
- - Table maps (legacy, deprecated) 
-
-### Templated maps
-
-Templated maps are templated [MapConfig]
-(http://github.com/CartoDB/Windshaft/wiki/MapConfig-specification) documents
-associated with an authorization certificate.
-
-The authorization certificate determines who can instanciate the
-template and use the resulting map. Authorized users of the instanciated
-maps will have the same database access privilege of the template owner.
-
-The HTTP endpoints for creating and using templated maps are described [here]
-(http://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps).
-
-*TODO* cleanup the referenced document
-
-### Table maps
-
-Table maps are maps associated with a table.
-Configuration of such maps is limited to the CartoCSS style.
-
- * style - the CartoCSS style for the datasource, can be an array
- * style_version - version of the CartoCSS style, can be an array
-
-You can only fetch PNG or UTF8GRID tiles from these maps.
-
-Access method is the same as the one for [Inline maps](#inline-maps)
-
-# Endpoints description 
-
-- **/api/maps/** (same interface than https://github.com/CartoDB/Windshaft/wiki/Multilayer-API)
-- **/api/maps/named** (same interface than https://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps)
-
-
-NOTE: in case Multilayer-API does not contain this info yet, the
-      endpoint for fetching attributes is this:
-
-- **/api/maps/:map_id/:layer_index/attributes/:feature_id** 
-   - would return { c: 1, d: 2 }
-

docs/Map-API.md

@@ -1,674 +1,111 @@
-## Maps API
-
-The CartoDB Maps API allows you to generate maps based on data hosted in your CartoDB account, and you can apply custom SQL and CartoCSS to the data. The API generates a XYZ-based URL to fetch Web Mercator projected tiles using web clients such as [Leaflet](http://leafletjs.com), [Google Maps](https://developers.google.com/maps/), or [OpenLayers](http://openlayers.org/).
-
-You can create two types of maps with the Maps API:
-
-- **Anonymous maps**  
-  Maps that can be created using your CartoDB public data. Any client can change the read-only SQL and CartoCSS parameters that generate the map tiles. These maps can be created from a JavaScript application alone and no authenticated calls are needed. See [this CartoDB.js example]({{ '/cartodb-platform/cartodb-js.html' | prepend: site.baseurl }}).
-
-- **Named maps**  
-  Maps that have access to your private data. These maps require an owner to setup and modify any SQL and CartoCSS parameters and are not modifiable without new setup calls. 
-
-## Quickstart
-
-### Anonymous maps
-
-Here is an example of how to create an anonymous map with JavaScript:
-
-```javascript
-var mapconfig = {
-  "version": "1.0.1",
-  "layers": [{
-    "type": "cartodb",
-    "options": {
-      "cartocss_version": "2.1.1",
-      "cartocss": "#layer { polygon-fill: #FFF; }",
-      "sql": "select * from european_countries_e"
-    }
-  }]
-}
+# Kind of maps
 
-$.ajax({
-  crossOrigin: true,
-  type: 'POST',
-  dataType: 'json',
-  contentType: 'application/json',
-  url: 'http://documentation.cartodb.com/api/v1/map',
-  data: JSON.stringify(mapconfig),
-  success: function(data) {
-    var templateUrl = 'http://documentation.cartodb.com/api/v1/map/' + data.layergroupid + '/{z}/{x}/{y}.png'
-    console.log(templateUrl);
-  }
-})
-```
+Windshaft-CartoDB supports these kind of maps:
 
-### Named maps
+ - [Temporary maps](#temporary-maps) (created by anyone)
+   - [Detached maps](#detached-maps)
+   - [Inline maps](#inline-maps) (legacy)
+ - [Persistent maps](#peristent-maps) (created by CartDB user)
+   - [Template maps](#template-maps)
+   - [Table maps](#table-maps) (legacy, deprecated) 
 
-Let's create a named map using some private tables in a CartoDB account.
-The following map config sets up a map of European countries that have a white fill color:
+## Temporary maps
 
-```javascript
-{
-  "version": "0.0.1",
-  "name": "test",
-  "auth": {
-    "method": "open"
-  },
-  "layergroup": {
-    "layers": [{
-      "type": "cartodb",
-      "options": {
-        "cartocss_version": "2.1.1",
-        "cartocss": "#layer { polygon-fill: #FFF; }",
-        "sql": "select * from european_countries_e"
-      }
-    }]
-  }
-}
-```
+Temporary maps have no owners and are anonymous in nature.
+There are two kind of temporary maps:
 
-The map config needs to be sent to CartoDB's Map API using an authenticated call. Here we will use a command line tool called `curl`. For more info about this tool, see [this blog post](http://quickleft.com/blog/command-line-tutorials-curl), or type ``man curl`` in bash. Using `curl`, and storing the config from above in a file `mapconfig.json`, the call would look like:
+ - Detached maps (aka MultiLayer-API)
+ - Inline maps 
 
-<div class="code-title notitle code-request"></div>
-```bash
-curl 'https://{account}.cartodb.com/api/v1/map/named?api_key=APIKEY' -H 'Content-Type: application/json' -d @mapconfig.json
-```
+### Detached maps
 
-To get the `URL` to fetch the tiles you need to instantiate the map, where `template_id` is the template name from the previous response.
+Detached maps are maps which are configured with a request
+obtaining a temporary token and then used by referencing
+the obtained token. The token expires automatically when unused.
 
-<div class="code-title notitle code-request"></div>
-```bash
-curl -X POST 'http://{account}.cartodb.com/api/v1/map/named/:template_id' -H 'Content-Type: application/json'
-```
+Anyone can create detached maps, but users will need read access
+to the data source of the map layers.
 
-The response will return JSON with properties for the `layergroupid`, `cdn_url`, and the timestamp (`last_updated`) of the last data modification. 
+The configuration format is a [MapConfig]
+(http://github.com/CartoDB/Windshaft/wiki/MapConfig-specification) document.
 
-Here is an example response:
+The HTTP endpoints for creating the map and using it are described [here]
+(http://github.com/CartoDB/Windshaft-cartodb/wiki/MultiLayer-API)
 
-```javascript
-{
-  "cdn_url": {
-    "http": "ashbu.cartocdn.com",
-    "https": "cartocdn-ashbu.global.ssl.fastly.net"
-  },
-  "layergroupid": "c01a54877c62831bb51720263f91fb33:0",
-  "last_updated": "1970-01-01T00:00:00.000Z"
-}
-```
+*TODO* cleanup the referenced document
 
-You can use the `layergroupid` to instantiate a URL template for accessing tiles on the client. Here we use the `layergroupid` from the example response above in this URL template:
+### Inline maps
 
-```bash
-http://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/{z}/{x}/{y}.png
-```
-
-## General Concepts
-
-The following concepts are the same for every endpoint in the API except when it's noted explicitly.
-
-### Auth
-
-By default, users do not have access to private tables in CartoDB. In order to instantiate a map from private table data, an API Key is required. Additionally, to include some endpoints, an API Key must be included (e.g. creating a named map).
-
-To execute an authorized request, api_key=YOURAPIKEY should be added to the request URL. The param can be also passed as POST param. We **strongly advise** using HTTPS when you are performing requests that include your `api_key`.
-
-### Errors
-
-Errors are reported using standard HTTP codes and extended information encoded in JSON with this format:
-
-```javascript
-{
-  "errors": [
-    "access forbidden to table TABLE"
-  ]
-}
-```
+Inline maps are maps that only exist for a single request,
+being the request for a specific map resource (tile).
 
-If you use JSONP, the 200 HTTP code is always returned so the JavaScript client can receive errors from the JSON object.
+Inline maps are always bound to a table, and can only be
+obtained by those having read access to the that table.
+Additionally, users need to have access to any datasource
+specified as part of the configuration.
 
-### CORS support
+Inline maps only support PNG and UTF8GRID tiles.
 
-All the endpoints which might be accessed using a web browser add CORS headers and allow OPTIONS method.
+The configuration consist in a set of parameters, to be
+specified in the query string of the tile request:
 
-## Anonymous Maps
+ * sql - the query to run as datasource, can be an array
+ * style - the CartoCSS style for the datasource, can be an array
+ * style_version - version of the CartoCSS style, can be an array
+ * interactivity - only for fetching UTF8GRID, 
 
-Anonymous maps allows you to instantiate a map given SQL and CartoCSS. It also allows you to add interaction capabilities using [UTF Grid.](https://github.com/mapbox/utfgrid-spec)
+If the style is not provided, style of the associated table is
+used; if the sql is not provided, all records of the associated
+table are used as the datasource; the two possibilities result
+in a mix between _inline_ maps and [Table maps][].
 
-### Instantiate
+*TODO* specify (or link) api endpoints
 
-#### Definition
+## Persistent maps
 
-<div class="code-title notitle code-request"></div>
-```html
-POST /api/v1/map
-```
+Persistent maps can only be created by a CartoDB user who has full
+responsibility over editing and deleting them. There are two
+kind of persistent maps:
 
-#### Params
+ - Template maps 
+ - Table maps (legacy, deprecated) 
 
-```javascript
-{
-  "version": "1.0.1",
-  "layers": [{
-    "type": "cartodb",
-    "options": {
-      "cartocss_version": "2.1.1", 
-      "cartocss": "#layer { polygon-fill: #FFF; }",
-      "sql": "select * from european_countries_e",
-      "interactivity": ["cartodb_id", "iso3"]
-    }
-  }]
-}
-```
+### Templated maps
 
-Should be a [Mapconfig](https://github.com/CartoDB/Windshaft/blob/0.19.1/doc/MapConfig-1.1.0.md).
+Templated maps are templated [MapConfig]
+(http://github.com/CartoDB/Windshaft/wiki/MapConfig-specification) documents
+associated with an authorization certificate.
 
-#### Response
+The authorization certificate determines who can instanciate the
+template and use the resulting map. Authorized users of the instanciated
+maps will have the same database access privilege of the template owner.
 
-The response includes:
+The HTTP endpoints for creating and using templated maps are described [here]
+(http://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps).
 
-- **layergroupid**  
-  The ID for that map, used to compose the URL for the tiles. The final URL is:
+*TODO* cleanup the referenced document
 
-  ```html
-  http://{account}.cartodb.com/api/v1/map/:layergroupid/{z}/{x}/{y}.png
-  ```
+### Table maps
 
-- **updated_at**  
-  The ISO date of the last time the data involved in the query was updated.
+Table maps are maps associated with a table.
+Configuration of such maps is limited to the CartoCSS style.
 
-- **metadata** *(optional)*  
-  Includes information about the layers. Some layers may not have metadata.
+ * style - the CartoCSS style for the datasource, can be an array
+ * style_version - version of the CartoCSS style, can be an array
 
-- **cdn_url**  
-  URLs to fetch the data using the best CDN for your zone.
+You can only fetch PNG or UTF8GRID tiles from these maps.
 
-#### Example
+Access method is the same as the one for [Inline maps](#inline-maps)
 
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl 'http://documentation.cartodb.com/api/v1/map' -H 'Content-Type: application/json' -d @mapconfig.json
-```
+# Endpoints description 
 
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "layergroupid":"c01a54877c62831bb51720263f91fb33:0",
-  "last_updated":"1970-01-01T00:00:00.000Z"
-  "cdn_url": {
-    "http": "http://cdb.com",
-    "https": "https://cdb.com"
-  }
-}
-```
+- **/api/maps/** (same interface than https://github.com/CartoDB/Windshaft/wiki/Multilayer-API)
+- **/api/maps/named** (same interface than https://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps)
 
-The tiles can be accessed using:
 
-```bash
-http://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/{z}/{x}/{y}.png
-```
+NOTE: in case Multilayer-API does not contain this info yet, the
+      endpoint for fetching attributes is this:
 
-For UTF grid tiles:
+- **/api/maps/:map_id/:layer_index/attributes/:feature_id** 
+   - would return { c: 1, d: 2 }
 
-```bash
-http://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/:layer/{z}/{x}/{y}.grid.json
-```
-
-For attributes defined in `attributes` section:
-
-```bash
-http://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/:layer/attributes/:feature_id
-```
-
-Which returns JSON with the attributes defined, like:
-
-```javascript
-{ c: 1, d: 2 }
-```
-
-Notice UTF Grid and attributes endpoints need an integer parameter, ``layer``. That number is the 0-based index of the layer inside the mapconfig. So in this case 0 returns the UTF grid tiles/attributes for layer 0, the only layer in the example mapconfig. If a second layer was available it could be returned with 1, a third layer with 2, etc.
-
-### Create JSONP
-
-The JSONP endpoint is provided in order to allow web browsers access which don't support CORS.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map?callback=method
-```
-
-#### Params
-
-- **config**
-  Encoded JSON with the params for creating named maps (the variables defined in the template).
-
-- **lmza**  
-  This attribute contains the same as config but LZMA compressed. It cannot be used at the same time as `config`.
-
-- **callback**  
-  JSON callback name.
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl "https://documentation.cartodb.com/api/v1/map?callback=callback&config=%7B%22version%22%3A%221.0.1%22%2C%22layers%22%3A%5B%7B%22type%22%3A%22cartodb%22%2C%22options%22%3A%7B%22sql%22%3A%22select+%2A+from+european_countries_e%22%2C%22cartocss%22%3A%22%23european_countries_e%7B+polygon-fill%3A+%23FF6600%3B+%7D%22%2C%22cartocss_version%22%3A%222.3.0%22%2C%22interactivity%22%3A%5B%22cartodb_id%22%5D%7D%7D%5D%7D"
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-callback({
-    layergroupid: "d9034c133262dfb90285cea26c5c7ad7:0",
-    cdn_url: {
-        "http": "http://cdb.com",
-        "https": "https://cdb.com"
-    },
-    last_updated: "1970-01-01T00:00:00.000Z"
-})
-```
-
-### Remove
-
-Anonymous maps cannot be removed by an API call. They will expire after about five minutes but sometimes longer. If an anonymous map expires and tiles are requested from it, an error will be raised. This could happen if a user leaves a map open and after time returns to the map an attempts to interact with it in a way that requires new tiles (e.g. zoom). The client will need to go through the steps of creating the map again to fix the problem.
-
-
-## Named Maps
-
-Named maps are essentially the same as anonymous maps except the mapconfig is stored on the server and the map is given a unique name. Two other big differences are that you can create named maps from private data, and that users without an API Key can see them even though they are from that private data.
-
-The main two differences compared to anonymous maps are:
-
-- **auth layer**  
-  This allows you to control who is able to see the map based on a token auth
-
-- **templates**  
-  Since the mapconfig is static it can contain some variables so the client can modify the map's appearance using those variables
-
-Template maps are persistent with no preset expiration. They can only be created or deleted by a CartoDB user with a valid API_KEY (see [auth section](http://docs.cartodb.com/cartodb-platform/maps-api.html#auth)).
-
-### Create
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```html
-POST /api/v1/map/named
-```
-
-#### Params
-
-- **api_key** is required
-
-<div class="code-title">template.json</div>
-```javascript
-{
-  "version": "0.0.1",
-  "name": "template_name",
-  "auth": {
-    "method": "token",
-    "valid_tokens": [
-      "auth_token1",
-      "auth_token2"
-    ]
-  },
-  "placeholders": {
-    "color": {
-      "type": "css_color",
-      "default": "red"
-    },
-    "cartodb_id": {
-      "type": "number",
-      "default": 1
-    }
-  },
-  "layergroup": {
-    "version": "1.0.1",
-    "layers": [
-      {
-        "type": "cartodb",
-        "options": {
-          "cartocss_version": "2.1.1",
-          "cartocss": "#layer { polygon-fill: <%= color %>; }",
-          "sql": "select * from european_countries_e WHERE cartodb_id = <%= cartodb_id %>"
-        }
-      }
-    ]
-  }
-}
-```
-
-##### Arguments
-
-- **name**: There can be at most _one_ template with the same name for any user. Valid names start with a letter, and only contain letters, numbers, or underscores (_).
-- **auth**:
-  - **method** `"token"` or `"open"` (the default if no `"method"` is given).
-  - **valid_tokens** when `"method"` is set to `"token"`, the values listed here allow you to instantiate the named map.
-- **placeholders**: Variables not listed here are not substituted. Variable not provided at instantiation time trigger an error. A default is required for optional variables. Type specification is used for quoting, to avoid injections see template format section below.
-- **layergroup**: the layer list definition. This is the MapConfig explained in anonymous maps. See [MapConfig documentation](https://github.com/CartoDB/Windshaft/blob/master/doc/MapConfig-1.1.0.md) for more info.
-
-#### Template Format
-
-A templated `layergroup` allows the use of placeholders in the "cartocss" and "sql" elements of the "option" object in any "layer" of a `layergroup` configuration
-
-Valid placeholder names start with a letter and can only contain letters, numbers, or underscores. They have to be written between the `<%=` and `%>` strings in order to be replaced.
-
-##### Example
-
-```javascript
-<%= my_color %>
-```
-
-The set of supported placeholders for a template will need to be explicitly defined with a specific type and default value for each.
-
-#### Placeholder Types
-
-The placeholder type will determine the kind of escaping for the associated value. Supported types are:
-
-- **sql_literal** internal single-quotes will be sql-escaped
-- **sql_ident** internal double-quotes will be sql-escaped
-- **number** can only contain numerical representation
-- **css_color** can only contain color names or hex-values
-
-Placeholder default values will be used whenever new values are not provided as options at the time of creation on the client. They can also be used to test the template by creating a default version with now options provided.
-
-When using templates, be very careful about your selections as they can give broad access to your data if they are defined losely.
-
-<div class="code-title code-request with-result">REQUEST</div>
-```html
-curl -X POST \
-   -H 'Content-Type: application/json' \
-   -d @template.json \
-   'https://documentation.cartodb.com/api/v1/map/named?api_key=APIKEY'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "template_id":"name",
-}
-```
-
-### Instantiate
-
-Instantiating a map allows you to get the information needed to fetch tiles. That temporal map is an anonymous map.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```html
-POST /api/v1/map/named/:template_name
-```
-
-#### Param
-
-- **auth_token** optional, but required when `"method"` is set to `"token"`
-
-```javascript
-// params.json
-{
- "color": "#ff0000",
- "cartodb_id": 3
-}
-```
-
-The fields you pass as `params.json` depend on the variables allowed by the named map. If there are variables missing it will raise an error (HTTP 400).
-
-- **auth_token** *optional* if the named map needs auth
-
-#### Example
-
-You can initialize a template map by passing all of the required parameters in a POST to `/api/v1/map/named/:template_name`.
-
-Valid credentials will be needed if required by the template.
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X POST \
-  -H 'Content-Type: application/json' \
-  -d @params.json \
-  'https://documentation.cartodb.com/api/v1/map/named/@template_name?auth_token=AUTH_TOKEN'
-```
-
-<div class="code-title">Response</div>
-```javascript
-{
-  "layergroupid": "docs@fd2861af@c01a54877c62831bb51720263f91fb33:123456788",
-  "last_updated": "2013-11-14T11:20:15.000Z"
-}
-```
-
-<div class="code-title">Error</div>
-```javascript
-{
-  "error": "Some error string here"
-}
-```
-
-You can then use the `layergroupid` for fetching tiles and grids as you would normally (see anonymous map section).  However, you'll need to show the `auth_token`, if required by the template.
-
-### Using JSONP
-
-There is also a special endpoint to be able to initialize a map using JSONP (for old browsers).
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/named/:template_name/jsonp
-```
-
-#### Params
-
-- **auth_token** optional, but required when `"method"` is set to `"token"`
-- **config** Encoded JSON with the params for creating named maps (the variables defined in the template)
-- **lmza** This attribute contains the same as config but LZMA compressed. It cannot be used at the same time than `config`.
-- **callback:** JSON callback name
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl 'https://documentation.cartodb.com/api/v1/map/named/:template_name/jsonp?auth_token=AUTH_TOKEN&callback=callback&config=template_params_json'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-callback({
-  "layergroupid":"c01a54877c62831bb51720263f91fb33:0",
-  "last_updated":"1970-01-01T00:00:00.000Z"
-  "cdn_url": {
-    "http": "http://cdb.com",
-    "https": "https://cdb.com"
-  }
-})
-```
-
-This takes the `callback` function (required), `auth_token` if the template needs auth, and `config` which is the variable for the template (in cases where it has variables). 
-
-```javascript
-url += "config=" + encodeURIComponent(
-JSON.stringify({ color: 'red' });
-```
-
-The response is in this format:
-
-```javascript
-callback({
-  layergroupid: "dev@744bd0ed9b047f953fae673d56a47b4d:1390844463021.1401",
-  last_updated: "2014-01-27T17:41:03.021Z"
-})
-```
-
-### Update
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-PUT /api/v1/map/named/:template_name
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Response
-
-Same as updating a map.
-
-#### Other Info
-
-Updating a named map removes all the named map instances so they need to be initialized again.
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X PUT \
-  -H 'Content-Type: application/json' \
-  -d @template.json \
-  'https://documentation.cartodb.com/api/v1/map/named/:template_name?api_key=APIKEY'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "template_id": "@template_name"
-}
-```
-
-If any template has the same name, it will be updated.
-
-If a template with the same name does NOT exist, a 400 HTTP response is generated with an error in this format:
-
-```javascript
-{
-  "error": "error string here"
-}
-```
-
-### Delete 
-
-Delete the specified template map from the server and disables any previously initialized versions of the map.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-DELETE /api/v1/map/named/:template_name
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Example
-
-<div class="code-title code-request">REQUEST</div>
-```bash
-curl -X DELETE 'https://documentation.cartodb.com/api/v1/map/named/:template_name?api_key=APIKEY'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "error": "Some error string here"
-}
-```
-
-On success, a 204 (No Content) response would be issued. Otherwise a 4xx response with with an error will be returned.
-
-### Listing Available Templates
-
-This allows you to get a list of all available templates. 
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/named/
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X GET 'https://documentation.cartodb.com/api/v1/map/named?api_key=APIKEY'
-```
-
-<div class="code-title with-result">RESPONSE</div>
-```javascript
-{
-   "template_ids": ["@template_name1","@template_name2"]
-}
-```
-
-<div class="code-title">ERROR</div>
-```javascript
-{
-   "error": "Some error string here"
-}
-```
-
-### Getting a Specific Template
-
-This gets the definition of a template.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/named/:template_name
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X GET 'https://documentation.cartodb.com/api/v1/map/named/:template_name?api_key=APIKEY'
-```
-
-<div class="code-title with-result">RESPONSE</div>
-```javascript
-{
-  "template": {...} // see template.json above
-}
-```
-
-<div class="code-title">ERROR</div>
-```javascript
-{
-  "error": "Some error string here"
-}
-```
-
-### Use with CartoDB.js
-Named maps can be used with CartoDB.js by specifying a named map in a layer source as follows. Named maps are treated almost the same as other layer source types in most other ways.
-
-```js
-var layerSource = {
-  user_name: '{your_user_name}', 
-  type: 'namedmap', 
-  named_map: { 
-    name: '{template_name}', 
-	layers: [{ 
-	  layer_name: "layer1", 
-      interactivity: "column1, column2, ..." 
-	}] 
-  } 
-}
-
-cartodb.createLayer('map_dom_id',layerSource)
-  .addTo(map_object);
-
-```
-
-See [CartoDB.js](http://docs.cartodb.com/cartodb-platform/cartodb-js.html) methods [layer.setParams()](http://docs.cartodb.com/cartodb-platform/cartodb-js.html#layersetparamskey-value) and [layer.setAuthToken()](http://docs.cartodb.com/cartodb-platform/cartodb-js.html#layersetauthtokenauthtoken).

docs/MultiLayer-API.md

@@ -1,6 +1,6 @@
 The Windshaft-CartoDB MultiLayer API extends the [Windshaft MultiLayer API](https://github.com/Vizzuality/Windshaft/wiki/Multilayer-API) in a few ways.
 
-## Last modification timestamp embedded in the token
+## Last modification timestamps
 
 It encodes a timestamp of 'last modification time' into the map token (token:EPOCH) returned to the client.
 It accepts tokens with encoded timestamp from the client considering the token suffix as a cache_buster value.
@@ -8,21 +8,8 @@ It accepts tokens with encoded timestamp from the client considering the token s
 Clients don't need to be aware of the extension but rather use the API as they would use the base one.
 The only difference will be that the _same_ layergroup configuration may result in different tokens if source data was modified between the mapview requests. 
 
-## Additional attributes in the response object
-
-Windshaft-CartoDB adds the following attributes in the response object
-
-- ``last_update`` field with ISO format (2013-11-30T12:23:10).
-- ``cdn_url`` object containing CDN url client should use (not mandatory) to access the tiles. It's in the form:
-
-   ```json
-   {
-     http: 'http://cdn_url.com/'
-     https: 'https://secure.cdn_url.com/'
-   }
-   ```
-
+Also Windshaft-CartoDB adds a ``last_update`` field with ISO format (2013-11-30T12:23:10).
 
 ## Stats tag
 
-Windshaft-CartoDB adds support for a ``stat_tag`` element in the multilayer configuration to help [stats](https://github.com/CartoDB/Windshaft-cartodb/wiki/Redis-stats-format) gathering.
+Windshaft-CartoDB adds support for a ``stat_tag`` element in the multilayer configuration to help [stats](Redis-stats-format) gathering.

docs/Template-maps.md

@@ -5,6 +5,13 @@ layergroup configurations (instantiation).
 Template maps are persistent, can only be created and deleted by the
 CartoDB user showing a valid API_KEY.
 
+Instantiating a signed template map would result in a [signed
+map](https://github.com/CartoDB/Windshaft-cartodb/wiki/Signed-maps)
+instance that would be signed with the same signature as the template.
+
+Deleting a signed template results in deletion of all signatures created
+as a result of instantiation.
+
 
 # Template format
 
@@ -36,19 +43,22 @@ Placeholder default value will be used when not provided at
 instantiation time and could be used to test validity of the
 template by creating a default instance.
 
+Additionally you'll be able to embed an authorization
+certificate that would be used to sign any instance of the template.
+
 ```js
 // template.json 
 {
-  version: "0.0.1",
+  version: '0.0.1',
   // there can be at most 1 template with the same name for any user 
   // valid names start with a letter and only contains letter, numbers
   // or underscores
-  name: "template_name", 
+  name: 'template_name', 
   // embedded authorization certificate
   auth: {
-   method: "token", // or "open" (the default if no "method" is given)
-   // only (required and non empty) for "token" method
-   valid_tokens: ["auth_token1","auth_token2"]
+   // See https://github.com/CartoDB/Windshaft-cartodb/wiki/Signed-maps
+   method: 'token', // or "open" (the default if no "method" is given)
+   valid_tokens: ['auth_token1','auth_token2'] // only (required and non empty) for 'token' method
   },
   // Variables not listed here are not substituted
   // Variable not provided at instantiation time trigger an error
@@ -56,11 +66,11 @@ template by creating a default instance.
   // Type specification is used for quoting, to avoid injections
   placeholders: {
       color: {
-        type:"css_color",
-        default:"red"
+        type:'css_color',
+        default:'red'
       },
       cartodb_id: {
-        type:"number",
+        type:'number',
         default: 1
       }
   },
@@ -81,8 +91,7 @@ template by creating a default instance.
 
 # Creating a templated map
 
-You can create a template map with a single call (for simplicity).
-
+You can create a signed template map with a single call (for simplicity).
 You'd use a POST sending JSON data:
 
 ```sh
@@ -111,7 +120,10 @@ Errors are in this form:
 
 # Updating an existing template
 
-You can update a template map with a PUT:
+Update of a template map implies removal all signatures from previous
+map instances.
+
+You can update a signed template map with a PUT:
 
 ```sh
 curl -X PUT \
@@ -230,7 +242,13 @@ or, on error:
 
 You can then use the ``layergroupid`` for fetching tiles and grids as you do
 normally ( see https://github.com/CartoDB/Windshaft/wiki/Multilayer-API).
-But you'll still have to show the ``auth_token``, if required by the template.
+But you'll still have to show the ``auth_token``, if required by the template
+(see https://github.com/CartoDB/Windshaft-cartodb/wiki/Signed-maps)
+
+Instances of a signed template map will be signed with the same signature
+certificate associated with the template. Such certificate would contain
+a reference to the template identifier, so that it can be revoked every
+time the template is updated or deleted. 
 
 ### using JSONP
 There is also a special endpoint to be able to instanciate using JSONP (for old browsers)
@@ -256,6 +274,8 @@ last_updated: "2014-01-27T17:41:03.021Z"
 ```
 # Deleting a template map
 
+Deletion of a template map will imply removal all instance signatures
+
 You can delete a templated map with a DELETE to ``/template/:template_name``:
 
 ```sh

docs/metrics.md

@@ -1,44 +0,0 @@
-Windshaft-cartodb metrics
-=========================
-See [Windshaft metrics documentation](https://github.com/CartoDB/Windshaft/blob/master/doc/metrics.md) to understand the full picture.
-
-The next list includes the API endpoints, each endpoint may have several inner timers, some of them are displayed within this list as subitems. Find the description for them in the Inner timers section.
-## Timers
-- **windshaft-cartodb.flush_cache**: time to flush the tile and sql cache
-- **windshaft-cartodb.get_template**: time to retrieve an specific template
-- **windshaft-cartodb.delete_template**: time to delete an specific template
-- **windshaft-cartodb.get_template_list**: time to retrieve the list of owned templates
-- **windshaft-cartodb.instance_template_post**: time to create a template via HTTP POST
-- **windshaft-cartodb.instance_template_get**: time to create a template via HTTP GET
-    + TemplateMaps_instance
-    + createLayergroup
-
-There are some endpoints that are not being tracked:
-- Adding a template
-- Updating a template
-
-### Inner timers
-Again, each inner timer may have several inner timers.
-
-- **addCacheChannel**: time to add X-Cache-Channel header based on table last modifications
-- **LZMA decompress**: time to decompress request params with LZMA
-- **TemplateMaps_instance**: time to retrieve a map template instance, see *getTemplate* and *authorizedByCert*
-- **affectedTables**: time to check what are the affected tables for adding the cache channel, see *addCacheChannel*
-- **authorize**: time to authorize a request, see *authorizedByAPIKey*, *authorizedByCert*, *authorizedBySigner*
-- **authorizedByAPIKey**: time to authorize using an API KEY
-- **authorizedByCert**: time to authorize a template instantiation
-- **authorizedBySigner**: time to authorize a request with auth_token
-- **findLastUpdated**: time to retrieve the last update time for a list of tables, see *affectedTables*
-- **generateCacheChannel**: time to generate the headers for the cache channel based on the request, see *addCacheChannel*
-- **getSignerMapKey**: time to retrieve from redis the authorized user for a template map
-- **getTablePrivacy**: time to retrieve from redis the privacy of a table
-- **getTemplate**: time to retrieve from redis the template for a map
-- **getUserMapKey**: time to retrieve from redis the user key for a map
-- **incMapviewCount**: time to incremenent in redis the map views
-- **mapStore_load**: time to retrieve from redis a map configuration
-- **req2params.setup**: time to prepare the params from a request, see *req2params* in Windshaft documentation
-- **setDBAuth**: time to retrieve from redis and set db user and db password from a user
-- **setDBConn**: time to retrieve from redis and set db host and db name from a user
-- **setDBParams**: time to prepare all db params to be able to connect/query a database, see *setDBAuth* and *setDBConn*
-- **tablePrivacy_getUserDBName**: time to retrieve from redis the database for a user
-

lib/cartodb/api/query_tables_api.js

@@ -1,122 +0,0 @@
-var sqlApi = require('../sql/sql_api'),
-    PSQL   = require('cartodb-psql');
-
-function QueryTablesApi() {
-}
-
-var affectedTableRegexCache = {
-    bbox: /!bbox!/g,
-    scale_denominator: /!scale_denominator!/g,
-    pixel_width: /!pixel_width!/g,
-    pixel_height: /!pixel_height!/g
-};
-
-module.exports = QueryTablesApi;
-
-QueryTablesApi.prototype.getLastUpdatedTime = function (username, api_key, tableNames, callback) {
-    var sql = 'SELECT EXTRACT(EPOCH FROM max(updated_at)) as max FROM CDB_TableMetadata m WHERE m.tabname = any (ARRAY['+
-        tableNames.map(function(t) { return "'" + t + "'::regclass"; }).join(',') +
-        '])';
-
-    // call sql api
-    sqlApi.query(username, api_key, sql, function(err, rows){
-        if (err){
-            var msg = err.message ? err.message : err;
-            callback(new Error('could not find last updated timestamp: ' + msg));
-            return;
-        }
-        // when the table has not updated_at means it hasn't been changed so a default last_updated is set
-        var last_updated = 0;
-        if(rows.length !== 0) {
-            last_updated = rows[0].max || 0;
-        }
-
-        callback(null, last_updated*1000);
-    });
-};
-
-QueryTablesApi.prototype.getAffectedTablesInQuery = function (username, options, sql, callback) {
-
-    var query = 'SELECT CDB_QueryTables($windshaft$' + prepareSql(sql) + '$windshaft$)';
-
-    runQuery(username, options, query, handleAffectedTablesInQueryRows, callback);
-};
-
-function handleAffectedTablesInQueryRows(err, rows, callback) {
-    if (err){
-        var msg = err.message ? err.message : err;
-        callback(new Error('could not fetch source tables: ' + msg));
-        return;
-    }
-    var qtables = rows[0].cdb_querytables;
-    var tableNames = qtables.split(/^\{(.*)\}$/)[1];
-    tableNames = tableNames ? tableNames.split(',') : [];
-    callback(null, tableNames);
-}
-
-QueryTablesApi.prototype.getAffectedTablesAndLastUpdatedTime = function (username, options, sql, callback) {
-
-    var query = [
-        'WITH querytables AS (',
-            'SELECT * FROM CDB_QueryTables($windshaft$' + prepareSql(sql) + '$windshaft$) as tablenames',
-        ')',
-        'SELECT (SELECT tablenames FROM querytables), EXTRACT(EPOCH FROM max(updated_at)) as max',
-        'FROM CDB_TableMetadata m',
-        'WHERE m.tabname = any ((SELECT tablenames from querytables)::regclass[])'
-    ].join(' ');
-
-    runQuery(username, options, query, handleAffectedTablesAndLastUpdatedTimeRows, callback);
-};
-
-function handleAffectedTablesAndLastUpdatedTimeRows(err, rows, callback) {
-    if (err || rows.length === 0) {
-        var msg = err.message ? err.message : err;
-        callback(new Error('could not fetch affected tables and last updated time: ' + msg));
-        return;
-    }
-
-    var result = rows[0];
-
-    var tableNames = result.tablenames.split(/^\{(.*)\}$/)[1];
-    tableNames = tableNames ? tableNames.split(',') : [];
-
-    var lastUpdatedTime = result.max || 0;
-
-    callback(null, {
-        affectedTables: tableNames,
-        lastUpdatedTime: lastUpdatedTime * 1000
-    });
-}
-
-
-function runQuery(username, options, query, queryHandler, callback) {
-    if (shouldQueryPostgresDirectly()) {
-        var psql = new PSQL(options);
-        psql.query(query, function(err, resultSet) {
-            resultSet = resultSet || {};
-            var rows = resultSet.rows || [];
-            queryHandler(err, rows, callback);
-        });
-    } else {
-        sqlApi.query(username, options.api_key, query, function(err, rows) {
-            queryHandler(err, rows, callback);
-        });
-    }
-}
-
-
-function prepareSql(sql) {
-    return sql
-        .replace(affectedTableRegexCache.bbox, 'ST_MakeEnvelope(0,0,0,0)')
-        .replace(affectedTableRegexCache.scale_denominator, '0')
-        .replace(affectedTableRegexCache.pixel_width, '1')
-        .replace(affectedTableRegexCache.pixel_height, '1')
-    ;
-}
-
-
-function shouldQueryPostgresDirectly() {
-    return global.environment
-        && global.environment.enabledFeatures
-        && global.environment.enabledFeatures.cdbQueryTablesFromPostgres;
-}

lib/cartodb/cache/backend/varnish_http.js

@@ -1,32 +0,0 @@
-var request = require('request');
-
-function VarnishHttpCacheBackend(host, port) {
-    this.host = host;
-    this.port = port;
-}
-
-module.exports = VarnishHttpCacheBackend;
-
-/**
- * @param cacheObject should respond to `key() -> String` method
- * @param {Function} callback
- */
-VarnishHttpCacheBackend.prototype.invalidate = function(cacheObject, callback) {
-    request(
-        {
-            method: 'PURGE',
-            url: 'http://' + this.host + ':' + this.port + '/key',
-            headers: {
-                'Invalidation-Match': '\\b' + cacheObject.key() + '\\b'
-            }
-        },
-        function(err, response) {
-            if (err || response.statusCode !== 204) {
-                return callback(new Error('Unable to invalidate Varnish object'));
-            }
-            return callback(null);
-        }
-    );
-};
-
-module.exports = VarnishHttpCacheBackend;

lib/cartodb/cache/model/named_maps_entry.js

@@ -1,18 +0,0 @@
-var crypto = require('crypto');
-
-function NamedMaps(owner, name) {
-    this.namespace = 'n';
-    this.owner = owner;
-    this.name = name;
-}
-
-module.exports = NamedMaps;
-
-
-NamedMaps.prototype.key = function() {
-    return this.namespace + ':' + shortHashKey(this.owner + ':' + this.name);
-};
-
-function shortHashKey(target) {
-    return crypto.createHash('sha256').update(target).digest('base64').substring(0,6);
-}

lib/cartodb/cache/surrogate_keys_cache.js

@@ -1,26 +0,0 @@
-/**
- * @param cacheBackend should respond to `invalidate(cacheObject, callback)` method
- * @constructor
- */
-function SurrogateKeysCache(cacheBackend) {
-    this.cacheBackend = cacheBackend;
-}
-
-module.exports = SurrogateKeysCache;
-
-
-/**
- * @param response should respond to `header(key, value)` method
- * @param cacheObject should respond to `key() -> String` method
- */
-SurrogateKeysCache.prototype.tag = function(response, cacheObject) {
-    response.header('Surrogate-Key', cacheObject.key());
-};
-
-/**
- * @param cacheObject should respond to `key() -> String` method
- * @param {Function} callback
- */
-SurrogateKeysCache.prototype.invalidate = function(cacheObject, callback) {
-    this.cacheBackend.invalidate(cacheObject, callback);
-};

lib/cartodb/cartodb_windshaft.js

@@ -1,16 +1,19 @@
+
 var _ = require('underscore')
     , Step       = require('step')
     , Windshaft = require('windshaft')
+    , redisPool = new require('redis-mpool')(global.environment.redis)
+    // TODO: instanciate cartoData with redisPool
+    , cartoData  = require('cartodb-redis')(global.environment.redis)
+    , SignedMaps = require('./signed_maps.js')
     , TemplateMaps = require('./template_maps.js')
     , Cache = require('./cache_validator')
     , os = require('os')
-    , HealthCheck = require('./monitoring/health_check')
 ;
 
-if ( ! process.env['PGAPPNAME'] )
-  process.env['PGAPPNAME']='cartodb_tiler';
-
 var CartodbWindshaft = function(serverOptions) {
+   var debug = global.environment.debug;
+
     // Perform keyword substitution in statsd
     // See https://github.com/CartoDB/Windshaft-cartodb/issues/153
     if ( global.environment.statsd ) {
@@ -20,11 +23,6 @@ var CartodbWindshaft = function(serverOptions) {
       }
     }
 
-    var redisPool = serverOptions.redis.pool
-        || require('redis-mpool')(_.extend(global.environment.redis, {name: 'windshaft:cartodb'}));
-
-    var cartoData = require('cartodb-redis')({pool: redisPool});
-
     if(serverOptions.cache_enabled) {
         console.log("cache invalidation enabled, varnish on ", serverOptions.varnish_host, ' ', serverOptions.varnish_port);
         Cache.init(serverOptions.varnish_host, serverOptions.varnish_port, serverOptions.varnish_secret);
@@ -40,7 +38,7 @@ var CartodbWindshaft = function(serverOptions) {
           err = new Error("map state cannot be changed by unauthenticated request!");
         }
         callback(err, req);
-    };
+    }
 
     // This is for Templated maps
     //
@@ -48,31 +46,11 @@ var CartodbWindshaft = function(serverOptions) {
     //
     var template_baseurl = global.environment.base_url_templated || '(?:/maps/named|/tiles/template)';
 
+    serverOptions.signedMaps = new SignedMaps(redisPool);
     var templateMapsOpts = {
       max_user_templates: global.environment.maxUserTemplates
-    };
-    var templateMaps = new TemplateMaps(redisPool, templateMapsOpts);
-    serverOptions.templateMaps = templateMaps;
-
-    var SurrogateKeysCache = require('./cache/surrogate_keys_cache'),
-        NamedMapsCacheEntry = require('./cache/model/named_maps_entry'),
-        VarnishHttpCacheBackend = require('./cache/backend/varnish_http'),
-        varnishHttpCacheBackend = new VarnishHttpCacheBackend(serverOptions.varnish_host, serverOptions.varnish_http_port),
-        surrogateKeysCache = new SurrogateKeysCache(varnishHttpCacheBackend);
-
-    if (serverOptions.varnish_purge_enabled) {
-        function invalidateNamedMap(owner, templateName) {
-            surrogateKeysCache.invalidate(new NamedMapsCacheEntry(owner, templateName), function(err) {
-                if (err) {
-                    console.warn('Cache: surrogate key invalidation failed');
-                }
-            });
-        }
-
-        ['update', 'delete'].forEach(function(eventType) {
-            templateMaps.on(eventType, invalidateNamedMap);
-        });
     }
+    var templateMaps = new TemplateMaps(redisPool, serverOptions.signedMaps, templateMapsOpts);
 
     // boot
     var ws = new Windshaft.Server(serverOptions);
@@ -83,7 +61,7 @@ var CartodbWindshaft = function(serverOptions) {
       var version = wsversion();
       version.windshaft_cartodb = require('../../package.json').version;
       return version;
-    };
+    }
 
     var ws_sendResponse = ws.sendResponse;
     // GET routes for which we don't want to request any caching.
@@ -98,14 +76,9 @@ var CartodbWindshaft = function(serverOptions) {
       var that = this;
       var thatArgs = arguments;
       var statusCode;
-      if ( res._windshaftStatusCode ) {
-        // Added by our override of sendError
-        statusCode = res._windshaftStatusCode;
-      } else {
-        if ( args.length > 2 ) statusCode = args[2];
-        else {
-          statusCode = args[1] || 200;
-        }
+      if ( args.length > 2 ) statusCode = args[2];
+      else {
+        statusCode = args[1] || 200;
       }
       var req = res.req;
       Step (
@@ -144,32 +117,13 @@ var CartodbWindshaft = function(serverOptions) {
       );
     };
 
-    var ws_sendError = ws.sendError;
-    ws.sendError = function() {
-      var res = arguments[0];
-      var statusCode = arguments[2];
-      res._windshaftStatusCode = statusCode;
-      ws_sendError.apply(this, arguments);
-    };
-
-    /*******************************************************************************************************************
-     * Routing
-     ******************************************************************************************************************/
-
-    var TemplateMapsController = require('./controllers/template_maps'),
-        templateMapsController = new TemplateMapsController(
-            ws, serverOptions, templateMaps, cartoData, template_baseurl, surrogateKeysCache, NamedMapsCacheEntry
-        );
-    templateMapsController.register(ws);
-
-    /*******************************************************************************************************************
-     * END Routing
-     ******************************************************************************************************************/
-
     /**
      * Helper to allow access to the layer to be used in the maps infowindow popup.
      */
     ws.get(serverOptions.base_url + '/infowindow', function(req, res){
+        if ( req.profiler && req.profiler.statsd_client ) {
+          req.profiler.start('windshaft-cartodb.get_infowindow');
+        }
         ws.doCORS(res);
         Step(
             function(){
@@ -191,6 +145,9 @@ var CartodbWindshaft = function(serverOptions) {
      * Helper to allow access to metadata to be used in embedded maps.
      */
     ws.get(serverOptions.base_url + '/map_metadata', function(req, res){
+        if ( req.profiler && req.profiler.statsd_client ) {
+          req.profiler.start('windshaft-cartodb.get_map_metadata');
+        }
         ws.doCORS(res);
         Step(
             function(){
@@ -231,32 +188,475 @@ var CartodbWindshaft = function(serverOptions) {
         );
     });
 
-    var healthCheck = new HealthCheck(cartoData, Windshaft.tilelive);
-    ws.get('/health', function(req, res) {
-        var healthConfig = global.environment.health || {};
+    // ---- Template maps interface starts @{
 
-        if (!!healthConfig.enabled) {
-            var startTime = Date.now();
-            healthCheck.check(healthConfig, function(err, result) {
-                var ok = !err;
-                var response = {
-                    enabled: true,
-                    ok: ok,
-                    elapsed: Date.now() - startTime,
-                    result: result
-                };
-                if (err) {
-                    response.err = err.message;
+    ws.userByReq = function(req) {
+        return serverOptions.userByReq(req);
+    }
+
+    // Add a template
+    ws.post(template_baseurl, function(req, res) {
+      ws.doCORS(res);
+      var that = this;
+      var response = {};
+      var cdbuser = ws.userByReq(req);
+      Step(
+        function checkPerms(){
+            serverOptions.authorizedByAPIKey(req, this);
+        },
+        function addTemplate(err, authenticated) {
+          if ( err ) throw err;
+          if (authenticated !== 1) {
+            err = new Error("Only authenticated user can create templated maps");
+            err.http_status = 403;
+            throw err;
+          }
+          var next = this;
+          if ( ! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json' )
+            throw new Error('template POST data must be of type application/json');
+          var cfg = req.body;
+          templateMaps.addTemplate(cdbuser, cfg, this);
+        },
+        function prepareResponse(err, tpl_id){
+          if ( err ) throw err;
+          // NOTE: might omit "cdbuser" if == dbowner ...
+          return { template_id: cdbuser + '@' + tpl_id };
+        },
+        function finish(err, response){
+            if ( req.profiler ) {
+              var report = req.profiler.toString();
+              res.header('X-Tiler-Profiler', report);
+            }
+            if (err){
+                response = { error: ''+err };
+                var statusCode = 400;
+                if ( ! _.isUndefined(err.http_status) ) {
+                  statusCode = err.http_status;
                 }
-                res.send(response, ok ? 200 : 503);
-
-            });
-        } else {
-            res.send({enabled: false, ok: true}, 200);
+                ws.sendError(res, response, statusCode, 'POST TEMPLATE', err);
+            } else {
+              ws.sendResponse(res, [response, 200]);
+            }
         }
+      );
     });
 
+    // Update a template
+    ws.put(template_baseurl + '/:template_id', function(req, res) {
+      ws.doCORS(res);
+      var that = this;
+      var response = {};
+      var cdbuser = ws.userByReq(req);
+      var template;
+      var tpl_id;
+      Step(
+        function checkPerms(){
+            serverOptions.authorizedByAPIKey(req, this);
+        },
+        function updateTemplate(err, authenticated) {
+          if ( err ) throw err;
+          if (authenticated !== 1) {
+            err = new Error("Only authenticated user can list templated maps");
+            err.http_status = 403;
+            throw err;
+          }
+          if ( ! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json' )
+            throw new Error('template PUT data must be of type application/json');
+          template = req.body;
+          tpl_id = req.params.template_id.split('@');
+          if ( tpl_id.length > 1 ) {
+            if ( tpl_id[0] != cdbuser ) {
+              err = new Error("Invalid template id '"
+                + req.params.template_id + "' for user '" + cdbuser + "'");
+              err.http_status = 404;
+              throw err;
+            }
+            tpl_id = tpl_id[1];
+          }
+          templateMaps.updTemplate(cdbuser, tpl_id, template, this);
+        },
+        function prepareResponse(err){
+          if ( err ) throw err;
+          return { template_id: cdbuser + '@' + tpl_id };
+        },
+        function finish(err, response){
+            if ( req.profiler ) {
+              var report = req.profiler.toString();
+              res.header('X-Tiler-Profiler', report);
+            }
+            if (err){
+                var statusCode = 400;
+                response = { error: ''+err };
+                if ( ! _.isUndefined(err.http_status) ) {
+                  statusCode = err.http_status;
+                }
+                ws.sendError(res, response, statusCode, 'PUT TEMPLATE', err);
+            } else {
+              ws.sendResponse(res, [response, 200]);
+            }
+        }
+      );
+    });
+
+    // Get a specific template
+    ws.get(template_baseurl + '/:template_id', function(req, res) {
+      if ( req.profiler && req.profiler.statsd_client ) {
+        req.profiler.start('windshaft-cartodb.get_template');
+      }
+      ws.doCORS(res);
+      var that = this;
+      var response = {};
+      var cdbuser = ws.userByReq(req);
+      var template;
+      var tpl_id;
+      Step(
+        function checkPerms(){
+            serverOptions.authorizedByAPIKey(req, this);
+        },
+        function updateTemplate(err, authenticated) {
+          if ( err ) throw err;
+          if (authenticated !== 1) {
+            err = new Error("Only authenticated users can get template maps");
+            err.http_status = 403;
+            throw err;
+          }
+          tpl_id = req.params.template_id.split('@');
+          if ( tpl_id.length > 1 ) {
+            if ( tpl_id[0] != cdbuser ) {
+              var err = new Error("Cannot get template id '"
+                + req.params.template_id + "' for user '" + cdbuser + "'");
+              err.http_status = 404;
+              throw err;
+            }
+            tpl_id = tpl_id[1];
+          }
+          templateMaps.getTemplate(cdbuser, tpl_id, this);
+        },
+        function prepareResponse(err, tpl_val){
+          if ( err ) throw err;
+          if ( ! tpl_val ) {
+            err = new Error("Cannot find template '" + tpl_id + "' of user '" + cdbuser + "'");
+            err.http_status = 404;
+            throw err;
+          }
+          // auth_id was added by ourselves,
+          // so we remove it before returning to the user
+          delete tpl_val.auth_id;
+          return { template: tpl_val };
+        },
+        function finish(err, response){
+            if (err){
+                var statusCode = 400;
+                response = { error: ''+err };
+                if ( ! _.isUndefined(err.http_status) ) {
+                  statusCode = err.http_status;
+                }
+                ws.sendError(res, response, statusCode, 'GET TEMPLATE', err);
+            } else {
+              ws.sendResponse(res, [response, 200]);
+            }
+        }
+      );
+    });
+
+    // Delete a specific template
+    ws.del(template_baseurl + '/:template_id', function(req, res) {
+      if ( req.profiler && req.profiler.statsd_client ) {
+        req.profiler.start('windshaft-cartodb.delete_template');
+      }
+      ws.doCORS(res);
+      var that = this;
+      var response = {};
+      var cdbuser = ws.userByReq(req);
+      var template;
+      var tpl_id;
+      Step(
+        function checkPerms(){
+            serverOptions.authorizedByAPIKey(req, this);
+        },
+        function updateTemplate(err, authenticated) {
+          if ( err ) throw err;
+          if (authenticated !== 1) {
+            err = new Error("Only authenticated users can delete template maps");
+            err.http_status = 403;
+            throw err;
+          }
+          tpl_id = req.params.template_id.split('@');
+          if ( tpl_id.length > 1 ) {
+            if ( tpl_id[0] != cdbuser ) {
+              var err = new Error("Cannot find template id '"
+                + req.params.template_id + "' for user '" + cdbuser + "'");
+              err.http_status = 404;
+              throw err;
+            }
+            tpl_id = tpl_id[1];
+          }
+          templateMaps.delTemplate(cdbuser, tpl_id, this);
+        },
+        function prepareResponse(err, tpl_val){
+          if ( err ) throw err;
+          return { status: 'ok' };
+        },
+        function finish(err, response){
+            if (err){
+                var statusCode = 400;
+                response = { error: ''+err };
+                if ( ! _.isUndefined(err.http_status) ) {
+                  statusCode = err.http_status;
+                }
+                ws.sendError(res, response, statusCode, 'DELETE TEMPLATE', err);
+            } else {
+              ws.sendResponse(res, ['', 204]);
+            }
+        }
+      );
+    });
+
+    // Get a list of owned templates 
+    ws.get(template_baseurl, function(req, res) {
+      if ( req.profiler && req.profiler.statsd_client ) {
+        req.profiler.start('windshaft-cartodb.get_template_list');
+      }
+      ws.doCORS(res);
+      var that = this;
+      var response = {};
+      var cdbuser = ws.userByReq(req);
+      Step(
+        function checkPerms(){
+            serverOptions.authorizedByAPIKey(req, this);
+        },
+        function listTemplates(err, authenticated) {
+          if ( err ) throw err;
+          if (authenticated !== 1) {
+            err = new Error("Only authenticated user can list templated maps");
+            err.http_status = 403;
+            throw err;
+          }
+          templateMaps.listTemplates(cdbuser, this);
+        },
+        function prepareResponse(err, tpl_ids){
+          if ( err ) throw err;
+          // NOTE: might omit "cbduser" if == dbowner ...
+          var ids = _.map(tpl_ids, function(id) { return cdbuser + '@' + id; })
+          return { template_ids: ids };
+        },
+        function finish(err, response){
+            var statusCode = 200;
+            if (err){
+                response = { error: ''+err };
+                if ( ! _.isUndefined(err.http_status) ) {
+                  statusCode = err.http_status;
+                }
+                ws.sendError(res, response, statusCode, 'GET TEMPLATE LIST', err);
+            } else {
+              ws.sendResponse(res, [response, statusCode]);
+            }
+        }
+      );
+    });
+
+    ws.setDBParams = function(cdbuser, params, callback) {
+      Step(
+        function setAuth() {
+          serverOptions.setDBAuth(cdbuser, params, this);
+        },
+        function setConn(err) {
+          if ( err ) throw err;
+          serverOptions.setDBConn(cdbuser, params, this);
+        },
+        function finish(err) {
+          callback(err);
+        }
+      );
+    };
+
+    ws.options(template_baseurl + '/:template_id', function(req, res) {
+      ws.doCORS(res, "Content-Type");
+      return next();
+    });
+
+    // Instantiate a template
+    function instanciateTemplate(req, res, template_params, callback) {
+      ws.doCORS(res);
+      if ( req.profiler ) req.profiler.done('cors');
+      var that = this;
+      var response = {};
+      var template;
+      var signedMaps = serverOptions.signedMaps;
+      var layergroup;
+      var layergroupid;
+      var fakereq; // used for call to createLayergroup
+      var cdbuser = ws.userByReq(req);
+      // Format of template_id: [<template_owner>]@<template_id>
+      var tpl_id = req.params.template_id.split('@');
+      if ( tpl_id.length > 1 ) {
+        if ( tpl_id[0] && tpl_id[0] != cdbuser ) {
+          var err = new Error('Cannot instanciate map of user "'
+                              + tpl_id[0] + '" on database of user "'
+                              + cdbuser + '"')
+          err.http_status = 403;
+          callback(err);
+          return;
+        }
+        tpl_id = tpl_id[1];
+      }
+      var auth_token = req.query.auth_token;
+      Step(
+        function getTemplate(){
+          templateMaps.getTemplate(cdbuser, tpl_id, this);
+        },
+        function checkAuthorized(err, data) {
+          if ( req.profiler ) req.profiler.done('getTemplate');
+          if ( err ) throw err;
+          if ( ! data ) {
+            err = new Error("Template '" + tpl_id + "' of user '" + cdbuser + "' not found");
+            err.http_status = 404;
+            throw err;
+          }
+          template = data;
+          var cert = templateMaps.getTemplateCertificate(template);
+          var authorized = false;
+          try {
+            // authorizedByCert will throw if unauthorized
+            authorized = signedMaps.authorizedByCert(cert, auth_token);
+          } catch (err) {
+            // we catch to add http_status
+            err.http_status = 403;
+            throw err;
+          }
+          if ( ! authorized ) {
+            err = new Error('Unauthorized template instanciation');
+            err.http_status = 403;
+            throw err;
+          }
+          /*if ( (! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json') && req.query.callback === undefined) {
+            throw new Error('template POST data must be of type application/json, it is instead ');
+          }*/
+          //var template_params = req.body;
+          if ( req.profiler ) req.profiler.done('authorizedByCert');
+          return templateMaps.instance(template, template_params);
+        },
+        function prepareParams(err, instance){
+          if ( req.profiler ) req.profiler.done('TemplateMaps_instance');
+          if ( err ) throw err;
+          layergroup = instance;
+          fakereq = { query: {}, params: {}, headers: _.clone(req.headers),
+            profiler: req.profiler
+          };
+          ws.setDBParams(cdbuser, fakereq.params, this);
+        },
+        function setApiKey(err){
+          if ( req.profiler ) req.profiler.done('setDBParams');
+          if ( err ) throw err;
+          cartoData.getUserMapKey(cdbuser, this);
+        },
+        function createLayergroup(err, val) {
+          if ( req.profiler ) req.profiler.done('getUserMapKey');
+          if ( err ) throw err;
+          fakereq.params.api_key = val;
+          ws.createLayergroup(layergroup, fakereq, this);
+        },
+        function signLayergroup(err, resp) {
+          // NOTE: createLayergroup uses profiler.start()/end() internally
+          //if ( req.profiler ) req.profiler.done('createLayergroup');
+          if ( err ) throw err;
+          response = resp;
+          var signer = cdbuser;
+          var map_id = response.layergroupid.split(':')[0]; // dropping last_updated 
+          var crt_id = template.auth_id; // check ?
+          if ( ! crt_id ) {
+            var errmsg = "Template '" + tpl_id + "' of user '" + cdbuser + "' has no signature";
+            // Is this really illegal ?
+            // Maybe we could just return an unsigned layergroupid
+            // in this case...
+            err = new Error(errmsg);
+            err.http_status = 403; // Forbidden, we refuse to respond to this
+            throw err;
+          }
+          signedMaps.signMap(signer, map_id, crt_id, this);
+        },
+        function prepareResponse(err) {
+          if ( req.profiler ) req.profiler.done('signMap');
+          if ( err ) throw err;
+          //console.log("Response from createLayergroup: "); console.dir(response);
+          // Add the signature part to the token!
+          var tplhash = templateMaps.fingerPrint(template).substring(0,8);
+          if ( req.profiler ) req.profiler.done('fingerPrint');
+          response.layergroupid = cdbuser + '@' + tplhash + '@' + response.layergroupid;
+          return response;
+        },
+        callback
+      );
+    }
+
+    function finish_instanciation(err, response, res, req) {
+        if ( req.profiler ) {
+          var report = req.profiler.toString();
+          res.header('X-Tiler-Profiler', report);
+        }
+        if (err) {
+            var statusCode = 400;
+            response = { error: ''+err };
+            if ( ! _.isUndefined(err.http_status) ) {
+              statusCode = err.http_status;
+            }
+            if(debug) {
+              response.stack = err.stack;
+            }
+            ws.sendError(res, response, statusCode, 'POST INSTANCE TEMPLATE', err);
+        } else {
+          ws.sendResponse(res, [response, 200]);
+        }
+    }
+
+    ws.post(template_baseurl + '/:template_id', function(req, res) {
+      if ( req.profiler && req.profiler.statsd_client) {
+        req.profiler.start('windshaft-cartodb.instance_template_post');
+      }
+      Step(
+        function() {
+          if ( ! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json') {
+            throw new Error('template POST data must be of type application/json, it is instead ');
+          }
+          instanciateTemplate(req, res, req.body, this);
+        }, function(err, response) {
+          finish_instanciation(err, response, res, req);
+        }
+      );
+    });
+
+    /**
+     * jsonp endpoint, allows to instanciate a template with a json call.
+     * callback query argument is mandartoy
+     */
+    ws.get(template_baseurl + '/:template_id/jsonp', function(req, res) {
+      if ( req.profiler && req.profiler.statsd_client) {
+        req.profiler.start('windshaft-cartodb.instance_template_get');
+      }
+      Step(
+        function() {
+          if ( req.query.callback === undefined || req.query.callback.length === 0) {
+            throw new Error('callback parameter should be present and be a function name');
+          }
+          var config = {};
+          if(req.query.config) {
+            try {
+              config = JSON.parse(req.query.config);
+            } catch(e) {
+              throw new Error('badformed config parameter, should be a valid JSON');
+            }
+          }
+          instanciateTemplate(req, res, config, this);
+        }, function(err, response) {
+          finish_instanciation(err, response, res, req);
+        }
+      );
+    });
+
+
+    // ---- Template maps interface ends @}
+
     return ws;
-};
+}
 
 module.exports = CartodbWindshaft;

lib/cartodb/controllers/template_maps.js

@@ -1,478 +0,0 @@
-var Step = require('step');
-var _ = require('underscore');
-
-function TemplateMapsController(app, serverOptions, templateMaps, metadataBackend, templateBaseUrl, surrogateKeysCache,
-                                NamedMapsCacheEntry) {
-    this.app = app;
-    this.serverOptions = serverOptions;
-    this.templateMaps = templateMaps;
-    this.metadataBackend = metadataBackend;
-    this.templateBaseUrl = templateBaseUrl;
-    this.surrogateKeysCache = surrogateKeysCache;
-    this.NamedMapsCacheEntry = NamedMapsCacheEntry;
-}
-
-module.exports = TemplateMapsController;
-
-
-TemplateMapsController.prototype.register = function(app) {
-    app.get(this.templateBaseUrl + '/:template_id/jsonp', this.jsonp.bind(this));
-    app.post(this.templateBaseUrl, this.create.bind(this));
-    app.put(this.templateBaseUrl + '/:template_id', this.update.bind(this));
-    app.get(this.templateBaseUrl + '/:template_id', this.retrieve.bind(this));
-    app.del(this.templateBaseUrl + '/:template_id', this.destroy.bind(this));
-    app.get(this.templateBaseUrl, this.list.bind(this));
-    app.options(this.templateBaseUrl + '/:template_id', this.options.bind(this));
-    app.post(this.templateBaseUrl + '/:template_id', this.instantiate.bind(this));
-};
-
-// Add a template
-TemplateMapsController.prototype.create = function(req, res) {
-    var self = this;
-
-    this.app.doCORS(res);
-
-    var cdbuser = self.serverOptions.userByReq(req);
-
-    Step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function addTemplate(err, authenticated) {
-            if ( err ) throw err;
-            if (authenticated !== 1) {
-                err = new Error("Only authenticated user can create templated maps");
-                err.http_status = 403;
-                throw err;
-            }
-            if ( ! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json' )
-                throw new Error('template POST data must be of type application/json');
-            var cfg = req.body;
-            self.templateMaps.addTemplate(cdbuser, cfg, this);
-        },
-        function prepareResponse(err, tpl_id){
-            if ( err ) throw err;
-            // NOTE: might omit "cdbuser" if == dbowner ...
-            return { template_id: cdbuser + '@' + tpl_id };
-        },
-        function finish(err, response){
-            if ( req.profiler ) {
-                res.header('X-Tiler-Profiler', req.profiler.toJSONString());
-            }
-            if (err){
-                response = { error: ''+err };
-                var statusCode = 400;
-                if ( ! _.isUndefined(err.http_status) ) {
-                    statusCode = err.http_status;
-                }
-                self.app.sendError(res, response, statusCode, 'POST TEMPLATE', err);
-            } else {
-                self.app.sendResponse(res, [response, 200]);
-            }
-        }
-    );
-};
-
-// Update a template
-TemplateMapsController.prototype.update = function(req, res) {
-    var self = this;
-
-    this.app.doCORS(res);
-
-    var cdbuser = this.serverOptions.userByReq(req);
-    var template;
-    var tpl_id;
-    Step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function updateTemplate(err, authenticated) {
-            if ( err ) throw err;
-            if (authenticated !== 1) {
-                err = new Error("Only authenticated user can list templated maps");
-                err.http_status = 403;
-                throw err;
-            }
-            if ( ! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json' )
-                throw new Error('template PUT data must be of type application/json');
-            template = req.body;
-            tpl_id = req.params.template_id.split('@');
-            if ( tpl_id.length > 1 ) {
-                if ( tpl_id[0] != cdbuser ) {
-                    err = new Error("Invalid template id '"
-                        + req.params.template_id + "' for user '" + cdbuser + "'");
-                    err.http_status = 404;
-                    throw err;
-                }
-                tpl_id = tpl_id[1];
-            }
-            self.templateMaps.updTemplate(cdbuser, tpl_id, template, this);
-        },
-        function prepareResponse(err){
-            if ( err ) throw err;
-            return { template_id: cdbuser + '@' + tpl_id };
-        },
-        function finish(err, response){
-            if ( req.profiler ) {
-                res.header('X-Tiler-Profiler', req.profiler.toJSONString());
-            }
-            if (err){
-                var statusCode = 400;
-                response = { error: ''+err };
-                if ( ! _.isUndefined(err.http_status) ) {
-                    statusCode = err.http_status;
-                }
-                self.app.sendError(res, response, statusCode, 'PUT TEMPLATE', err);
-            } else {
-                self.app.sendResponse(res, [response, 200]);
-            }
-        }
-    );
-};
-
-// Get a specific template
-TemplateMapsController.prototype.retrieve = function(req, res) {
-    var self = this;
-
-    if ( req.profiler && req.profiler.statsd_client ) {
-        req.profiler.start('windshaft-cartodb.get_template');
-    }
-
-    this.app.doCORS(res);
-
-    var cdbuser = this.serverOptions.userByReq(req);
-    var template;
-    var tpl_id;
-    Step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function updateTemplate(err, authenticated) {
-            if ( err ) throw err;
-            if (authenticated !== 1) {
-                err = new Error("Only authenticated users can get template maps");
-                err.http_status = 403;
-                throw err;
-            }
-            tpl_id = req.params.template_id.split('@');
-            if ( tpl_id.length > 1 ) {
-                if ( tpl_id[0] != cdbuser ) {
-                    var err = new Error("Cannot get template id '"
-                        + req.params.template_id + "' for user '" + cdbuser + "'");
-                    err.http_status = 404;
-                    throw err;
-                }
-                tpl_id = tpl_id[1];
-            }
-            self.templateMaps.getTemplate(cdbuser, tpl_id, this);
-        },
-        function prepareResponse(err, tpl_val){
-            if ( err ) throw err;
-            if ( ! tpl_val ) {
-                err = new Error("Cannot find template '" + tpl_id + "' of user '" + cdbuser + "'");
-                err.http_status = 404;
-                throw err;
-            }
-            // auth_id was added by ourselves,
-            // so we remove it before returning to the user
-            delete tpl_val.auth_id;
-            return { template: tpl_val };
-        },
-        function finish(err, response){
-            if (err){
-                var statusCode = 400;
-                response = { error: ''+err };
-                if ( ! _.isUndefined(err.http_status) ) {
-                    statusCode = err.http_status;
-                }
-                self.app.sendError(res, response, statusCode, 'GET TEMPLATE', err);
-            } else {
-                self.app.sendResponse(res, [response, 200]);
-            }
-        }
-    );
-};
-
-// Delete a specific template
-TemplateMapsController.prototype.destroy = function(req, res) {
-    var self = this;
-
-    if ( req.profiler && req.profiler.statsd_client ) {
-        req.profiler.start('windshaft-cartodb.delete_template');
-    }
-    this.app.doCORS(res);
-
-    var cdbuser = this.serverOptions.userByReq(req);
-    var template;
-    var tpl_id;
-    Step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function updateTemplate(err, authenticated) {
-            if ( err ) throw err;
-            if (authenticated !== 1) {
-                err = new Error("Only authenticated users can delete template maps");
-                err.http_status = 403;
-                throw err;
-            }
-            tpl_id = req.params.template_id.split('@');
-            if ( tpl_id.length > 1 ) {
-                if ( tpl_id[0] != cdbuser ) {
-                    var err = new Error("Cannot find template id '"
-                        + req.params.template_id + "' for user '" + cdbuser + "'");
-                    err.http_status = 404;
-                    throw err;
-                }
-                tpl_id = tpl_id[1];
-            }
-            self.templateMaps.delTemplate(cdbuser, tpl_id, this);
-        },
-        function prepareResponse(err, tpl_val){
-            if ( err ) throw err;
-            return { status: 'ok' };
-        },
-        function finish(err, response){
-            if (err){
-                var statusCode = 400;
-                response = { error: ''+err };
-                if ( ! _.isUndefined(err.http_status) ) {
-                    statusCode = err.http_status;
-                }
-                self.app.sendError(res, response, statusCode, 'DELETE TEMPLATE', err);
-            } else {
-                self.app.sendResponse(res, ['', 204]);
-            }
-        }
-    );
-};
-
-// Get a list of owned templates
-TemplateMapsController.prototype.list = function(req, res) {
-    var self = this;
-
-    if ( req.profiler && req.profiler.statsd_client ) {
-        req.profiler.start('windshaft-cartodb.get_template_list');
-    }
-    this.app.doCORS(res);
-
-    var cdbuser = this.serverOptions.userByReq(req);
-
-    Step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function listTemplates(err, authenticated) {
-            if ( err ) throw err;
-            if (authenticated !== 1) {
-                err = new Error("Only authenticated user can list templated maps");
-                err.http_status = 403;
-                throw err;
-            }
-            self.templateMaps.listTemplates(cdbuser, this);
-        },
-        function prepareResponse(err, tpl_ids){
-            if ( err ) throw err;
-            // NOTE: might omit "cbduser" if == dbowner ...
-            var ids = _.map(tpl_ids, function(id) { return cdbuser + '@' + id; });
-            return { template_ids: ids };
-        },
-        function finish(err, response){
-            var statusCode = 200;
-            if (err){
-                response = { error: ''+err };
-                if ( ! _.isUndefined(err.http_status) ) {
-                    statusCode = err.http_status;
-                }
-                self.app.sendError(res, response, statusCode, 'GET TEMPLATE LIST', err);
-            } else {
-                self.app.sendResponse(res, [response, statusCode]);
-            }
-        }
-    );
-};
-
-TemplateMapsController.prototype.instantiate = function(req, res) {
-    var self = this;
-
-    if ( req.profiler && req.profiler.statsd_client) {
-        req.profiler.start('windshaft-cartodb.instance_template_post');
-    }
-    Step(
-        function() {
-            if ( ! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json') {
-                throw new Error('template POST data must be of type application/json, it is instead ');
-            }
-            self.instantiateTemplate(req, res, req.body, this);
-        }, function(err, response) {
-            self.finish_instantiation(err, response, res, req);
-        }
-    );
-};
-
-TemplateMapsController.prototype.options = function(req, res) {
-    this.app.doCORS(res, "Content-Type");
-    return next();
-};
-
-/**
- * jsonp endpoint, allows to instantiate a template with a json call.
- * callback query argument is mandatory
- */
-TemplateMapsController.prototype.jsonp = function(req, res) {
-    var self = this;
-
-    if ( req.profiler && req.profiler.statsd_client) {
-        req.profiler.start('windshaft-cartodb.instance_template_get');
-    }
-    Step(
-        function() {
-            if ( req.query.callback === undefined || req.query.callback.length === 0) {
-                throw new Error('callback parameter should be present and be a function name');
-            }
-            var config = {};
-            if(req.query.config) {
-                try {
-                    config = JSON.parse(req.query.config);
-                } catch(e) {
-                    throw new Error('badformed config parameter, should be a valid JSON');
-                }
-            }
-            self.instantiateTemplate(req, res, config, this);
-        }, function(err, response) {
-            self.finish_instantiation(err, response, res, req);
-        }
-    );
-};
-
-
-// Instantiate a template
-TemplateMapsController.prototype.instantiateTemplate = function(req, res, template_params, callback) {
-    var self = this;
-
-    this.app.doCORS(res);
-
-    var template;
-    var layergroup;
-    var fakereq; // used for call to createLayergroup
-    var cdbuser = self.serverOptions.userByReq(req);
-    // Format of template_id: [<template_owner>]@<template_id>
-    var tpl_id = req.params.template_id.split('@');
-    if ( tpl_id.length > 1 ) {
-        if ( tpl_id[0] && tpl_id[0] != cdbuser ) {
-            var err = new Error('Cannot instanciate map of user "'
-                + tpl_id[0] + '" on database of user "'
-                + cdbuser + '"');
-            err.http_status = 403;
-            callback(err);
-            return;
-        }
-        tpl_id = tpl_id[1];
-    }
-    var auth_token = req.query.auth_token;
-    Step(
-        function getTemplate(){
-            self.templateMaps.getTemplate(cdbuser, tpl_id, this);
-        },
-        function checkAuthorized(err, templateValue) {
-            if ( req.profiler ) req.profiler.done('getTemplate');
-            if ( err ) throw err;
-            if ( ! templateValue ) {
-                err = new Error("Template '" + tpl_id + "' of user '" + cdbuser + "' not found");
-                err.http_status = 404;
-                throw err;
-            }
-
-            template = templateValue;
-
-            var authorized = false;
-            try {
-                authorized = self.templateMaps.isAuthorized(template, auth_token);
-            } catch (err) {
-                // we catch to add http_status
-                err.http_status = 403;
-                throw err;
-            }
-            if ( ! authorized ) {
-                err = new Error('Unauthorized template instanciation');
-                err.http_status = 403;
-                throw err;
-            }
-
-            if (req.profiler) {
-                req.profiler.done('authorizedByCert');
-            }
-
-            return self.templateMaps.instance(template, template_params);
-        },
-        function prepareParams(err, instance){
-            if ( req.profiler ) req.profiler.done('TemplateMaps_instance');
-            if ( err ) throw err;
-            layergroup = instance;
-            fakereq = { query: {}, params: {}, headers: _.clone(req.headers),
-                method: req.method,
-                res: res,
-                profiler: req.profiler
-            };
-            self.setDBParams(cdbuser, fakereq.params, this);
-        },
-        function setApiKey(err){
-            if ( req.profiler ) req.profiler.done('setDBParams');
-            if ( err ) throw err;
-            self.metadataBackend.getUserMapKey(cdbuser, this);
-        },
-        function createLayergroup(err, val) {
-            if ( req.profiler ) req.profiler.done('getUserMapKey');
-            if ( err ) throw err;
-            fakereq.params.api_key = val;
-            self.app.createLayergroup(layergroup, fakereq, this);
-        },
-        function prepareResponse(err, layergroup) {
-            if ( err ) {
-                throw err;
-            }
-            var tplhash = self.templateMaps.fingerPrint(template).substring(0,8);
-            layergroup.layergroupid = cdbuser + '@' + tplhash + '@' + layergroup.layergroupid;
-
-            self.surrogateKeysCache.tag(res, new self.NamedMapsCacheEntry(cdbuser, template.name));
-
-            return layergroup;
-        },
-        callback
-    );
-};
-
-TemplateMapsController.prototype.finish_instantiation = function(err, response, res, req) {
-    if ( req.profiler ) {
-        res.header('X-Tiler-Profiler', req.profiler.toJSONString());
-    }
-    if (err) {
-        var statusCode = 400;
-        response = { error: ''+err };
-        if ( ! _.isUndefined(err.http_status) ) {
-            statusCode = err.http_status;
-        }
-        if(global.environment.debug) {
-            response.stack = err.stack;
-        }
-        this.app.sendError(res, response, statusCode, 'POST INSTANCE TEMPLATE', err);
-    } else {
-        this.app.sendResponse(res, [response, 200]);
-    }
-};
-
-TemplateMapsController.prototype.setDBParams = function(cdbuser, params, callback) {
-    var self = this;
-    Step(
-        function setAuth() {
-            self.serverOptions.setDBAuth(cdbuser, params, this);
-        },
-        function setConn(err) {
-            if ( err ) throw err;
-            self.serverOptions.setDBConn(cdbuser, params, this);
-        },
-        function finish(err) {
-            callback(err);
-        }
-    );
-};

lib/cartodb/log4js_rollbar.js

@@ -1,49 +0,0 @@
-var rollbar = require("rollbar");
-
-/**
- * Rollbar Appender. Sends logging events to Rollbar using node-rollbar 
- *
- * @param config object with rollbar configuration data
- * {
- *   token: 'your-secret-token',
- *   options: node-rollbar options
- * }
- */
-function rollbarAppender(config) {
-
-  var opt = config.options;
-	rollbar.init(opt.token, opt.options);
-	
-	return function(loggingEvent) {
-/*
-For logger.trace('one','two','three'):
-{ startTime: Wed Mar 12 2014 16:27:40 GMT+0100 (CET),
-  categoryName: '[default]',
-  data: [ 'one', 'two', 'three' ],
-  level: { level: 5000, levelStr: 'TRACE' },
-  logger: { category: '[default]', _events: { log: [Object] } } }
-*/
-
-    // Levels:
-    // TRACE  5000
-    // DEBUG 10000
-    // INFO  20000
-    // WARN  30000
-    // ERROR 40000
-    // FATAL 50000
-    //
-    // We only log error and higher errors
-    //
-    if ( loggingEvent.level.level < 40000 ) return;
-
-    rollbar.reportMessage(loggingEvent.data);
-	};
-}
-
-function configure(config) {
-	return rollbarAppender(config);
-}
-
-exports.name      = "rollbar";
-exports.appender  = rollbarAppender;
-exports.configure = configure;

lib/cartodb/monitoring/health_check.js

@@ -1,90 +0,0 @@
-var _    = require('underscore'),
-    dot  = require('dot'),
-    fs   = require('fs'),
-    path = require('path'),
-    Step = require('step');
-
-function HealthCheck(metadataBackend, tilelive) {
-    this.metadataBackend = metadataBackend;
-    this.tilelive = tilelive;
-}
-
-module.exports = HealthCheck;
-
-
-var mapnikOptions = {
-    query: {
-        metatile: 1,
-        poolSize: 4,
-        bufferSize: 64
-    },
-    protocol: 'mapnik:',
-    slashes: true,
-    xml: null
-};
-
-var xmlTemplate = dot.template(fs.readFileSync(path.resolve(__dirname, 'map-config.xml'), 'utf-8'));
-
-HealthCheck.prototype.check = function(config, callback) {
-
-    var self = this,
-        startTime,
-        result = {
-            redis: {
-                ok: false
-            },
-            mapnik: {
-                ok: false
-            },
-            tile: {
-                ok: false
-            }
-        };
-    mapnikXmlParams = config;
-
-    Step(
-        function getDBParams() {
-            startTime = Date.now();
-            self.metadataBackend.getAllUserDBParams(config.username, this);
-        },
-        function loadMapnik(err, dbParams) {
-            if (err) {
-                throw err;
-            }
-            result.redis = {
-                ok: !err,
-                elapsed: Date.now() - startTime,
-                size: Object.keys(dbParams).length
-            };
-            mapnikOptions.xml = xmlTemplate(mapnikXmlParams);
-
-            startTime = Date.now();
-            self.tilelive.load(mapnikOptions, this);
-        },
-        function getTile(err, source) {
-            if (err) {
-                throw err;
-            }
-
-            result.mapnik = {
-                ok: !err,
-                elapsed: Date.now() - startTime
-            };
-
-            startTime = Date.now();
-            source.getTile(config.z, config.x, config.y, this);
-        },
-        function handleTile(err, tile) {
-            result.tile = {
-                ok: !err
-            };
-
-            if (tile) {
-                result.tile.elapsed = Date.now() - startTime;
-                result.tile.size = tile.length;
-            }
-
-            callback(err, result);
-        }
-    );
-};

lib/cartodb/monitoring/map-config.xml

@@ -1,4 +0,0 @@
-<Map
-    background-color="#c33"
-    srs="+proj=longlat +ellps=WGS84 +datum=WGS84 +no_defs">
-</Map>

lib/cartodb/server_options.js

@@ -1,9 +1,11 @@
 var   _          = require('underscore')
     , Step       = require('step')
-    , Cache      = require('./cache_validator')
-    , QueryTablesApi   = require('./api/query_tables_api')
+    , cartoData  = require('cartodb-redis')(global.environment.redis)
+    , Cache = require('./cache_validator')
+    , mapnik     = require('mapnik')
     , crypto     = require('crypto')
-    , LZMA       = require('lzma').LZMA
+    , request    = require('request')
+    , LZMA       = require('lzma/lzma_worker.js').LZMA
   ;
 
 // This is for backward compatibility with 1.3.3
@@ -15,35 +17,12 @@ if ( _.isUndefined(global.environment.sqlapi.domain) ) {
   }
 }
 
-// Whitelist query parameters and attach format
-var REQUEST_QUERY_PARAMS_WHITELIST = [
-    'sql',
-    'geom_type',
-    'cache_buster',
-    'cache_policy',
-    'callback',
-    'interactivity',
-    'map_key',
-    'api_key',
-    'auth_token',
-    'style',
-    'style_version',
-    'style_convert',
-    'config',
-    'scale_factor'
-];
-
-module.exports = function(redisPool) {
-    var redisOpts = redisPool ? {pool: redisPool} : global.environment.redis;
-    var cartoData = require('cartodb-redis')(redisOpts),
-        lzmaWorker = new LZMA(),
-        queryTablesApi = new QueryTablesApi();
+module.exports = function(){
 
     var rendererConfig = _.defaults(global.environment.renderer || {}, {
-        cache_ttl: 60000, // milliseconds
-        metatile: 4,
-        bufferSize: 64,
-        statsInterval: 60000
+      cache_ttl: 60000, // milliseconds
+      metatile: 4,
+      bufferSize: 64
     });
 
     var me = {
@@ -67,31 +46,23 @@ module.exports = function(redisPool) {
           },
           datasource: global.environment.postgres,
           cachedir: global.environment.millstone.cache_basedir,
-          mapnik_version: global.environment.mapnik_version,
-          mapnik_tile_format: global.environment.mapnik_tile_format || 'png',
+          mapnik_version: global.environment.mapnik_version || mapnik.versions.mapnik,
           default_layergroup_ttl: global.environment.mapConfigTTL || 7200, 
           gc_prob: 0.01 // @deprecated since Windshaft-1.8.0
         },
         mapnik: {
-          poolSize: rendererConfig.poolSize,
           metatile: rendererConfig.metatile,
           bufferSize: rendererConfig.bufferSize
         },
         statsd: global.environment.statsd,
         renderCache: {
-            ttl: rendererConfig.cache_ttl,
-            statsInterval: rendererConfig.statsInterval
-        },
-        renderer: {
-            http: rendererConfig.http
+          ttl: rendererConfig.cache_ttl
         },
         redis: global.environment.redis,
         enable_cors: global.environment.enable_cors,
         varnish_host: global.environment.varnish.host,
         varnish_port: global.environment.varnish.port,
-        varnish_http_port: global.environment.varnish.http_port,
         varnish_secret: global.environment.varnish.secret,
-        varnish_purge_enabled: global.environment.varnish.purge_enabled,
         cache_enabled: global.environment.cache_enabled,
         log_format: global.environment.log_format,
         useProfiler: global.environment.useProfiler
@@ -101,8 +72,13 @@ module.exports = function(redisPool) {
     // See http://github.com/CartoDB/Windshaft-cartodb/issues/161
     me.redis.unwatchOnRelease = false;
 
-    // Re-use redisPool
-    me.redis.pool = redisPool;
+    // Be nice and warn if configured mapnik version
+    // is != instaled mapnik version
+    if ( mapnik.versions.mapnik != me.grainstore.mapnik_version ) {
+      console.warn("WARNING: detected mapnik version ("
+        + mapnik.versions.mapnik + ") != configured mapnik version ("
+        + me.grainstore.mapnik_version + ")");
+    }
 
 /* This whole block is about generating X-Cache-Channel { */
 
@@ -112,6 +88,120 @@ module.exports = function(redisPool) {
     //       we have no SQL after layer creation.
     me.channelCache = {};
 
+    // Run a query through the SQL api
+    me.sqlQuery = function (username, api_key, sql, callback) {
+      var api = global.environment.sqlapi;
+
+      // build up api string
+      var sqlapihostname = username;
+      if ( api.domain ) sqlapihostname += '.' + api.domain;
+
+      var sqlapi = api.protocol + '://';
+      if ( api.host && api.host != api.domain ) sqlapi += api.host;
+      else sqlapi += sqlapihostname;
+      sqlapi += ':' + api.port + '/api/' + api.version + '/sql';
+
+      var qs  = { q: sql }
+
+      // add api_key if given
+      if (_.isString(api_key) && api_key != '') { qs.api_key = api_key; }
+
+      // call sql api
+      //
+      // NOTE: using POST to avoid size limits:
+      // See http://github.com/CartoDB/Windshaft-cartodb/issues/111
+      //
+      // NOTE: uses "host" header to allow IP based specification
+      //       of sqlapi address (and avoid a DNS lookup)
+      //
+      // NOTE: allows for keeping up to "maxConnections" concurrent
+      //       sockets opened per SQL-API host.
+      // See http://nodejs.org/api/http.html#http_agent_maxsockets
+      //
+      var maxSockets = global.environment.maxConnections || 128;
+      var maxGetLen = api.max_get_sql_length || 2048;
+      var maxSQLTime = api.timeout || 100; // 1/10 of a second by default
+      var reqSpec = {
+            url:sqlapi,
+            json:true,
+            headers:{host: sqlapihostname}
+            // http://nodejs.org/api/http.html#http_agent_maxsockets
+            ,pool:{maxSockets:maxSockets}
+            // timeout in milliseconds
+            ,timeout:maxSQLTime
+      }
+      if ( sql.length > maxGetLen ) {
+        reqSpec.method = 'POST';
+        reqSpec.body = qs;
+      } else {
+        reqSpec.method = 'GET';
+        reqSpec.qs = qs;
+      }
+      request(reqSpec, function(err, res, body) {
+          if (err){
+            console.log('ERROR connecting to SQL API on ' + sqlapi + ': ' + err);
+            callback(err);
+            return;
+          }
+          if (res.statusCode != 200) {
+              var msg = res.body.error ? res.body.error : res.body;
+              callback(new Error(msg));
+              console.log('unexpected response status (' + res.statusCode + ') for sql query: ' + sql + ': ' + msg);
+              return;
+          }
+          callback(null, body.rows);
+      });
+    };
+
+    //
+    // Invoke callback with number of milliseconds since
+    // last update in any of the given tables
+    //
+    me.findLastUpdated = function (username, api_key, tableNames, callback) {
+      var sql = 'SELECT EXTRACT(EPOCH FROM max(updated_at)) as max FROM CDB_TableMetadata m WHERE m.tabname::name = any (\'{'
+        + tableNames.join(',') + '}\')';
+
+      // call sql api
+      me.sqlQuery(username, api_key, sql, function(err, rows){
+          if (err){
+            var msg = err.message ? err.message : err;
+            callback(new Error('could not find last updated timestamp: ' + msg));
+            return;
+          }
+          // when the table has not updated_at means it hasn't been changed so a default last_updated is set
+          var last_updated = 0;
+          if(rows.length !== 0) {
+            last_updated = rows[0].max || 0;
+          }
+          callback(null, last_updated*1000);
+      });
+    };
+
+    me.affectedTables = function (username, api_key, sql, callback) {
+
+      // Replace mapnik tokens
+      sql = sql.replace(RegExp('!bbox!', 'g'), 'ST_MakeEnvelope(0,0,0,0)')
+               .replace(RegExp('!pixel_width!', 'g'), '1')
+               .replace(RegExp('!pixel_height!', 'g'), '1')
+            ;
+
+      // Pass to CDB_QueryTables
+      sql = 'SELECT CDB_QueryTables($windshaft$' + sql + '$windshaft$)';
+
+      // call sql api
+      me.sqlQuery(username, api_key, sql, function(err, rows){
+          if (err){
+            var msg = err.message ? err.message : err;
+            callback(new Error('could not fetch source tables: ' + msg));
+            return;
+          }
+          var qtables = rows[0].cdb_querytables;
+          var tableNames = qtables.split(/^\{(.*)\}$/)[1];
+          tableNames = tableNames ? tableNames.split(',') : [];
+          callback(null, tableNames);
+      });
+    };
+
     me.buildCacheChannel = function (dbName, tableNames){
       return dbName + ':' + tableNames.join(',');
     };
@@ -120,7 +210,7 @@ module.exports = function(redisPool) {
         var hash = crypto.createHash('md5');
         hash.update(data);
         return hash.digest('hex');
-    };
+    }
 
     me.generateCacheChannel = function(app, req, callback){
 
@@ -150,6 +240,7 @@ module.exports = function(redisPool) {
             // See http://github.com/CartoDB/Windshaft-cartodb/issues/152
             if ( ! app.mapStore ) {
               throw new Error('missing channel cache for token ' + req.params.token);
+              return;
             }
             var next = this;
             var mapStore = app.mapStore;
@@ -194,38 +285,8 @@ module.exports = function(redisPool) {
             }
             return [req.params.table];
           }
-          var user, key;
-          var next = this;
-          Step (
-            function findUserKey() {
-              if ( req.params.hasOwnProperty('_authorizedBySigner') ) {
-                user = req.params._authorizedBySigner;
-                cartoData.getUserMapKey(user, this);
-              } else {
-                user = that.userByReq(req);
-                key = req.params.map_key || req.params.api_key;
-                return null;
-              }
-            },
-            function getAffected(err, data) {
-              if ( err ) throw err;
-              if ( data ) {
-                if ( req.profiler ) req.profiler.done('getSignerMapKey');
-                key = data;
-              }
-              queryTablesApi.getAffectedTablesInQuery(user, {
-                  user: req.params.dbuser,
-                  pass: req.params.dbpass,
-                  host: req.params.dbhost,
-                  port: req.params.dbport,
-                  dbname: req.params.dbname,
-                  api_key: key
-              }, sql, this); // in addCacheChannel
-            },
-            function finish(err, data) {
-              next(err,data);
-            }
-          );
+          var username   = that.userByReq(req);
+          me.affectedTables(username, req.params.map_key, sql, this);
         },
         function buildCacheChannel(err, tableNames) {
           if ( err ) throw err;
@@ -312,14 +373,6 @@ module.exports = function(redisPool) {
             err = errors.length ? new Error(errors.join('\n')) : null;
             callback(err);
           }
-        };
-
-        // include in layergroup response the variables in serverMedata
-        // those variables are useful to send to the client information
-        // about how to reach this server or information about it
-        var serverMetadata = global.environment.serverMetadata;
-        if (serverMetadata) {
-          _.extend(response, serverMetadata);
         }
 
         // Don't wait for the mapview count increment to
@@ -342,44 +395,33 @@ module.exports = function(redisPool) {
         var key    = req.params.map_key || req.params.api_key;
 
         var cacheKey = dbName + ':' + token;
+        var tabNames;
 
         Step(
-            function getAffectedTablesAndLastUpdatedTime() {
-                queryTablesApi.getAffectedTablesAndLastUpdatedTime(usr, {
-                    user: req.params.dbuser,
-                    pass: req.params.dbpass,
-                    host: req.params.dbhost,
-                    port: req.params.dbport,
-                    dbname: req.params.dbname,
-                    api_key: key
-                }, sql, this);
-            },
-            function handleAffectedTablesAndLastUpdatedTime(err, result) {
-                if (req.profiler) req.profiler.done('queryTablesAndLastUpdated');
-                if ( err ) throw err;
-                var cacheChannel = me.buildCacheChannel(dbName, result.affectedTables);
-                me.channelCache[cacheKey] = cacheChannel;
-
-                if (req.res && req.method == 'GET') {
-                    var res = req.res;
-                    if ( req.query && req.query.cache_policy == 'persist' ) {
-                        res.header('Cache-Control', 'public,max-age=31536000'); // 1 year
-                    } else {
-                        var ttl = global.environment.varnish.layergroupTtl || 86400;
-                        res.header('Cache-Control', 'public,max-age='+ttl+',must-revalidate');
-                    }
-                    res.header('Last-Modified', (new Date()).toUTCString());
-                    res.header('X-Cache-Channel', cacheChannel);
-                }
-
-                // last update for layergroup cache buster
-                response.layergroupid = response.layergroupid + ':' + result.lastUpdatedTime;
-                response.last_updated = new Date(result.lastUpdatedTime).toISOString();
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
+          function getTables() {
+            me.affectedTables(usr, key, sql, this);
+          },
+          function getLastupdated(err, tableNames) {
+            if (req.profiler) req.profiler.done('affectedTables');
+            if ( err ) throw err;
+            var cacheChannel = me.buildCacheChannel(dbName,tableNames);
+            // store for caching from me.afterLayergroupCreate
+            me.channelCache[cacheKey] = cacheChannel;
+            // find last updated
+            if ( ! tableNames.length ) return 0; // skip for no affected tables
+            tabNames = tableNames;
+            me.findLastUpdated(usr, key, tableNames, this);
+          },
+          function(err, lastUpdated) {
+            if ( err ) throw err;
+            if (req.profiler && tabNames) req.profiler.done('findLastUpdated');
+            response.layergroupid = response.layergroupid + ':' + lastUpdated; // use epoch
+            response.last_updated = new Date(lastUpdated).toISOString(); 
+            return null;
+          },
+          function finish(err) {
+            done(err);
+          }
         );
     };
 
@@ -405,7 +447,7 @@ module.exports = function(redisPool) {
         return;
       }
       return mat[1];
-    };
+    }
 
     // Set db authentication parameters to those of the given username
     //
@@ -474,20 +516,21 @@ module.exports = function(redisPool) {
         dbport: global.environment.postgres.port
       });
       Step(
-        function getConnectionParams() {
-            cartoData.getUserDBConnectionParams(dbowner, this);
+        function getDatabaseHost(){
+            cartoData.getUserDBHost(dbowner, this);
         },
-        function extendParams(err, dbParams){
+        function getDatabase(err, data){
+            if(err) throw err;
+            if ( data ) _.extend(params, {dbhost:data});
+            cartoData.getUserDBName(dbowner, this);
+        },
+        function extendParams(err, data){
             if (err) throw err;
-            // we don't want null values or overwrite a non public user
-            if (params.dbuser != 'publicuser' || !dbParams.dbuser) {
-                delete dbParams.dbuser;
-            }
-            if ( dbParams ) _.extend(params, dbParams);
+            if ( data ) _.extend(params, {dbname:data});
             return null;
         },
         function finish(err) {
-          callback(err);
+          callback(err); 
         }
       );
     };
@@ -495,6 +538,10 @@ module.exports = function(redisPool) {
 
     // Check if a request is authorized by a signer
     //
+    // Any existing signature for the given request will verified
+    // for authorization to this specific request (may require auth_token)
+    // See https://github.com/CartoDB/Windshaft-cartodb/wiki/Signed-maps
+    //
     // @param req express request object
     // @param callback function(err, signed_by) signed_by will be
     //                 null if the request is not signed by anyone
@@ -513,20 +560,11 @@ module.exports = function(redisPool) {
       var auth_token = req.params.auth_token;
 
       //console.log("Checking authorization from signer " + signer + " for resource " + layergroup_id + " with auth_token " + auth_token);
-      var mapStore = req.app.mapStore;
-      if (!mapStore) {
-          throw new Error('Unable to retrieve map configuration token');
-      }
-
-      mapStore.load(layergroup_id, function(err, mapConfig) {
-        if (err) {
-          throw err;
-        }
-
-        var authorized = me.templateMaps.isAuthorized(mapConfig.obj().template, auth_token);
-        callback(null, authorized ? signer : null);
-      });
 
+      me.signedMaps.isAuthorized(signer, layergroup_id, auth_token,
+        function(err, authorized) {
+          callback(err, authorized ? signer : null);
+        });
     };
 
     // Check if a request is authorized by api_key
@@ -625,7 +663,6 @@ module.exports = function(redisPool) {
                 }
 
                 // Authorized by "signed_by" !
-                _.extend(req.params, { _authorizedBySigner: signed_by });
                 that.setDBAuth(signed_by, req.params, function(err) {
                   if (req.profiler) req.profiler.done('setDBAuth');
                   callback(err, true); // authorized (or error)
@@ -662,16 +699,16 @@ module.exports = function(redisPool) {
           //console.log("type of req.query.lzma is " + typeof(req.query.lzma));
 
           // Decode (from base64)
-          var lzma = (new Buffer(req.query.lzma, 'base64').toString('binary')).split('').map(function(c) { return c.charCodeAt(0) - 128 });
+          var lzma = (new Buffer(req.query.lzma, 'base64').toString('binary')).split('').map(function(c) { return c.charCodeAt(0) - 128 })
 
           // Decompress
-          lzmaWorker.decompress(
+          LZMA.decompress(
             lzma,
             function(result) {
               if (req.profiler) req.profiler.done('LZMA decompress');
               try {
-                delete req.query.lzma;
-                _.extend(req.query, JSON.parse(result));
+                delete req.query.lzma
+                _.extend(req.query, JSON.parse(result))
                 me.req2params(req, callback);
               } catch (err) {
                 callback(new Error('Error parsing lzma as JSON: ' + err));
@@ -684,7 +721,9 @@ module.exports = function(redisPool) {
           return;
         }
 
-        var bad_query  = _.difference(_.keys(req.query), REQUEST_QUERY_PARAMS_WHITELIST);
+        // Whitelist query parameters and attach format
+        var good_query = ['sql', 'geom_type', 'cache_buster', 'cache_policy', 'callback', 'interactivity', 'map_key', 'api_key', 'auth_token', 'style', 'style_version', 'style_convert', 'config' ];
+        var bad_query  = _.difference(_.keys(req.query), good_query);
 
         _.each(bad_query, function(key){ delete req.query[key]; });
         req.params =  _.extend({}, req.params); // shuffle things as request is a strange array/object
@@ -701,7 +740,7 @@ module.exports = function(redisPool) {
             req.params.signer = tksplit.shift();
             if ( ! req.params.signer ) req.params.signer = user;
             else if ( req.params.signer != user ) {
-              var err = new Error('Cannot use map signature of user "' + req.params.signer + '" on database of user "' + user + '"');
+              var err = new Error('Cannot use map signature of user "' + req.params.signer + '" on database of user "' + user + '"')
               err.http_status = 403;
               callback(err);
               return;
@@ -749,6 +788,7 @@ module.exports = function(redisPool) {
                 cartoData.getTableGeometryType(req.params.dbname, req.params.table, this);
             },
             function finishSetup(err, data){
+                if (req.profiler) req.profiler.done('cartoData.getTableGeometryType');
                 if ( err ) { callback(err, req); return; }
 
                 if (!_.isNull(data))

lib/cartodb/signed_maps.js

@@ -0,0 +1,401 @@
+var crypto    = require('crypto');
+var Step      = require('step');
+var _         = require('underscore');
+
+var debug = global.environment ? global.environment.debug : undefined;
+
+// Class handling map signatures and user certificates
+//
+// See https://github.com/CartoDB/Windshaft-cartodb/wiki/Signed-maps
+//
+// @param redis_pool an instance of a "redis-mpool"
+//        See https://github.com/CartoDB/node-redis-mpool
+//        Needs version 0.x.x of the API.
+//
+function SignedMaps(redis_pool) {
+  this.redis_pool = redis_pool;
+
+  // Database containing signatures
+  // TODO: allow configuring ?
+  // NOTE: currently it is the same as
+  //       the one containing layergroups
+  this.db_signatures = 0;
+
+  //
+  // Map signatures in redis are reference to signature certificates
+  // We have the following datastores:
+  //
+  //  1. User certificates: set of per-user authorization certificates
+  //  2. Map signatures: set of per-map certificate references 
+  //  3. Certificate applications: set of per-certificate signed maps
+
+  // User certificates (HASH:crt_id->crt_val)
+  this.key_map_crt = "map_crt|<%= signer %>";
+
+  // Map signatures (SET:crt_id)
+  this.key_map_sig = "map_sig|<%= signer %>|<%= map_id %>";
+  
+  // Certificates applications (SET:map_id)
+  //
+  // Everytime a map is signed, the map identifier (layergroup_id)
+  // is added to this set. The purpose of this set is to drop
+  // all map signatures when a certificate is removed
+  //
+  this.key_crt_sig = "crt_sig|<%= signer %>|<%= crt_id %>";
+
+};
+
+var o = SignedMaps.prototype;
+
+//--------------- PRIVATE METHODS --------------------------------
+
+o._acquireRedis = function(callback) {
+  this.redis_pool.acquire(this.db_signatures, callback);
+};
+
+o._releaseRedis = function(client) {
+  this.redis_pool.release(this.db_signatures, client);
+};
+
+/**
+ * Internal function to communicate with redis
+ *
+ * @param redisFunc - the redis function to execute
+ * @param redisArgs - the arguments for the redis function in an array
+ * @param callback - function to pass results too.
+ */
+o._redisCmd = function(redisFunc, redisArgs, callback) {
+  var redisClient;
+  var that = this;
+  var db = that.db_signatures;
+
+  Step(
+    function getRedisClient() {
+      that.redis_pool.acquire(db, this);
+    },
+    function executeQuery(err, data) {
+      if ( err ) throw err;
+      redisClient = data;
+      redisArgs.push(this);
+      redisClient[redisFunc.toUpperCase()].apply(redisClient, redisArgs);
+    },
+    function releaseRedisClient(err, data) {
+      if ( ! _.isUndefined(redisClient) ) that.redis_pool.release(db, redisClient);
+      callback(err, data);
+    }
+  );
+};
+
+o._getAuthMethod = function(auth) {
+  return auth.method || 'open';
+};
+
+//--------------- PUBLIC API -------------------------------------
+
+/// Check formal validity of a certificate
+//
+/// Return an Error instance if invalid, null otherwise
+///
+o.checkInvalidCertificate = function(cert) {
+  //console.log("Checking cert: "); console.dir(cert);
+  if ( cert.version !== "0.0.1" ) {
+    return new Error("Unsupported certificate version " + cert.version);
+  }
+
+  if ( ! cert.auth ) {
+console.log("Cert is : "); console.dir(cert);
+    return new Error("No certificate authorization");
+  }
+
+  var method = this._getAuthMethod(cert.auth);
+
+  switch ( method ) {
+    case 'open':
+      break;
+    case 'token':
+      if ( ! _.isArray(cert.auth.valid_tokens) )
+        return new Error("Invalid 'token' authentication: missing valid_tokens");
+      if ( ! cert.auth.valid_tokens.length )
+        return new Error("Invalid 'token' authentication: no valid_tokens");
+      break;
+    default:
+      return new Error("Unsupported authentication method: " + cert.auth.method);
+      break;
+  }
+
+  return null; // all valid
+}
+
+// Check if the given certificate authorizes waiver of "auth"
+o.authorizedByCert = function(cert, auth) {
+
+  var err = this.checkInvalidCertificate(cert);
+  if ( err ) throw err;
+
+  var method = this._getAuthMethod(cert.auth);
+
+  // Open authentication certificates are always authorized
+  if ( method === 'open' ) return true;
+
+  // Token based authentication requires valid token
+  if ( method === 'token' ) {
+    var found = cert.auth.valid_tokens.indexOf(auth);
+    //if ( found !== -1 ) {
+      //console.log("Token " + auth + " is found at position " + found + " in valid tokens " + cert.auth.valid_tokens);
+    //  return true;
+    //} else return false;
+    return cert.auth.valid_tokens.indexOf(auth) !== -1;
+  }
+
+  throw new Error("Unsupported authentication method: " + cert.auth.method);
+};
+
+// Check if shown credential are authorized to access a map
+// by the given signer.
+//
+// @param signer a signer name (cartodb username)
+// @param map_id a layergroup_id
+// @param auth an authentication token, or undefined if none
+//                    (can still be authorized by signature)
+//
+// @param callback function(Error, Boolean)
+//
+o.isAuthorized = function(signer, map_id, auth, callback) {
+  var that = this;
+  var redisClient;
+  var db = that.db_signatures;
+  var authorized = false;
+  var certificate_id_list;
+  var missing_certificates = [];
+  if ( debug ) {
+    console.log("Check auth from signer '" + signer + "' on map '" + map_id + "' with auth '" + auth + "'");
+  }
+  Step(
+    function getRedisClient() {
+      that.redis_pool.acquire(db, this);
+    },
+    function getMapSignatures(err, client) {
+      if ( err ) throw err;
+      redisClient = client;
+      var map_sig_key = _.template(that.key_map_sig, {signer:signer, map_id:map_id});
+      redisClient.SMEMBERS(map_sig_key, this);
+      //that._redisCmd('SMEMBERS', [ map_sig_key ], this);
+    },
+    function getCertificates(err, crt_lst) {
+      if ( err ) throw err;
+      if ( debug ) {
+        console.log("Map '" + map_id + "' is signed by " + crt_lst.length + " certificates of user '" + signer);
+      }
+      certificate_id_list = crt_lst;
+      if ( ! crt_lst.length ) {
+        // No certs, avoid calling redis with short args list.
+        // Next step expects a list of certificate values so
+        // we directly send the empty list.
+        return crt_lst;
+      }
+      var map_crt_key = _.template(that.key_map_crt, {signer:signer});
+      //that._redisCmd('HMGET', [ map_crt_key ].concat(crt_lst), this);
+      redisClient.HMGET(map_crt_key, crt_lst, this);
+    },
+    function checkCertificates(err, certs) {
+      if ( err ) throw err;
+      for (var i=0; i<certs.length; ++i) {
+        var crt_id = certificate_id_list[i];
+        if ( _.isNull(certs[i]) ) {
+          missing_certificates.push(crt_id);
+          continue;
+        }
+        var cert;
+        try {
+          //console.log("cert " + crt_id + ": " + certs[i]);
+          cert = JSON.parse(certs[i]);
+          authorized = that.authorizedByCert(cert, auth);
+        } catch (err) {
+          console.log("Certificate " + certificate_id_list[i] + " by user '" + signer + "' is malformed: " + err);
+          continue;
+        }
+        if ( authorized ) {
+          if ( debug ) {
+            console.log("Access to map '" + map_id + "' authorized by cert '"
+                        + certificate_id_list[i] + "' of user '" + signer + "'");
+          }
+          //console.dir(cert);
+          break; // no need to further check certs
+        }
+      }
+      return null;
+    },
+    function finish(err) {
+      if ( missing_certificates.length ) {
+        console.log("WARNING: map '" + map_id + "' is signed by '" + signer
+          + "' with " + missing_certificates.length
+          + " missing certificates: "
+          + missing_certificates + " (TODO: give cleanup instructions)");
+      }
+      if ( redisClient ) that.redis_pool.release(db, redisClient);
+      callback(err, authorized);
+    }
+  );
+};
+
+// Add an authorization certificate from a user.
+//
+// @param signer a signer name (cartodb username)
+// @param cert certificate object, see
+//             http://github.com/CartoDB/Windshaft-cartodb/wiki/Signed-maps
+//
+// @param callback function(err, crt_id) return certificate id
+//
+// TODO: allow for requesting error when certificate already exists ?
+//
+o.addCertificate = function(signer, cert, callback) {
+  var crt_val = JSON.stringify(cert);
+  var crt_id = crypto.createHash('md5').update(crt_val).digest('hex');
+
+  var usr_crt_key = _.template(this.key_map_crt, {signer:signer});
+  this._redisCmd('HSET', [ usr_crt_key, crt_id, crt_val ], function(err, created) {
+    // NOTE: created would be 0 if the field already existed, 1 otherwise
+    callback(err, crt_id);
+  });
+};
+
+// Remove an authorization certificate of a user, also removing
+// any signature made with the certificate.
+//
+// @param signer a signer name (cartodb username)
+// @param crt_id certificate identifier, as returned by addCertificate
+// @param callback function(err)
+//
+o.delCertificate = function(signer, crt_id, callback) {
+  var db = this.db_signatures;
+  var crt_sig_key = _.template(this.key_crt_sig, {signer:signer, crt_id:crt_id});
+  var signed_map_list;
+  var redis_client;
+  var that = this;
+  Step (
+    function getRedisClient() {
+      that._acquireRedis(this);
+    },
+    function removeCertificate(err, data) {
+      if ( err ) throw err;
+      redis_client = data;
+      // Remove the certificate (would be enough to stop authorizing uses)
+      var usr_crt_key = _.template(that.key_map_crt, {signer:signer});
+      redis_client.HDEL(usr_crt_key, crt_id, this);
+    },
+    function getMapSignatures(err, deleted) {
+      if ( err ) throw err;
+      if ( ! deleted ) {
+        // debugging (how can this be possible?)
+        console.log("WARNING: authorization certificate '" + crt_id
+          + "' by user '" + signer + "' did not exist on delete request");
+      }
+      // Get all signatures by this certificate
+      redis_client.SMEMBERS(crt_sig_key, this);
+    },
+    function delMapSignaturesReference(err, map_id_list) {
+      if ( err ) throw err;
+      signed_map_list = map_id_list;
+      if ( debug ) {
+        console.log("Certificate '" + crt_id + "' from user '" + signer
+          + "' was used to sign " + signed_map_list.length + " maps");
+      }
+      redis_client.DEL(crt_sig_key, this);
+    },
+    function delMapSignatures(err) {
+      if ( err ) throw err;
+      var crt_sig_key = _.template(that.key_crt_sig, {signer:signer, crt_id:crt_id});
+      var tx = redis_client.MULTI();
+      for (var i=0; i<signed_map_list.length; ++i) {
+        var map_id = signed_map_list[i];
+        var map_sig_key = _.template(that.key_map_sig, {signer:signer, map_id:map_id});
+        //console.log("Queuing removal of '" + crt_id + "' from '" + map_sig_key + "'");
+        tx.SREM( map_sig_key, crt_id )
+      }
+      tx.EXEC(this);
+    },
+    function reportTransaction(err, rets) {
+      if ( err ) throw err;
+      if ( debug ) {
+        for (var i=0; i<signed_map_list.length; ++i) {
+          var ret = rets[i];
+          if ( ! ret ) {
+            console.log("No signature with certificate '" + crt_id
+              + "' of user '" + signer + "' found in map '"
+              + signed_map_list[i] + "'");
+          } else {
+            console.log("Signature with certificate '" + crt_id
+              + "' of user '" + signer + "' removed from map '"
+              + signed_map_list[i] + "'");
+          }
+        }
+      }
+      return null;
+    },
+    function finish(err) {
+      if ( ! _.isUndefined(redis_client) ) {
+        that._releaseRedis(redis_client);
+      }
+      callback(err);
+    }
+  );
+};
+
+// Sign a map with a certificate reference
+//
+// @param signer a signer name (cartodb username)
+// @param map_id a layergroup_id
+// @param crt_id signature certificate identifier
+//
+// @param callback function(Error) 
+//
+o.signMap = function(signer, map_id, crt_id, callback) {
+  var that = this;
+  Step(
+    function addMapSignature() {
+      var map_sig_key = _.template(that.key_map_sig, {signer:signer, map_id:map_id});
+      if ( debug ) {
+        console.log("Adding " + crt_id + " to " + map_sig_key);
+      }
+      that._redisCmd('SADD', [ map_sig_key, crt_id ], this);
+    },
+    function addCertificateUsage(err) {
+      // Add the map to the set of maps signed by the given cert
+      if ( err ) throw err;
+      var crt_sig_key = _.template(that.key_crt_sig, {signer:signer, crt_id:crt_id});
+      that._redisCmd('SADD', [ crt_sig_key, map_id ], this);
+    },
+    function finish(err) {
+      callback(err);
+    }
+  );
+};
+
+// Sign a map with a full certificate
+//
+// @param signer a signer name (cartodb username)
+// @param map_id a layergroup_id
+// @param cert_id signature certificate identifier
+//
+// @param callback function(Error, String) return certificate id
+//
+o.addSignature = function(signer, map_id, cert, callback) {
+  var that = this;
+  var certificate_id;
+  Step(
+    function addCertificate() {
+      that.addCertificate(signer, cert, this);
+    },
+    function signMap(err, cert_id) {
+      if ( err ) throw err;
+      if ( ! cert_id ) throw new Error("addCertificate returned no certificate id");
+      certificate_id = cert_id;
+      that.signMap(signer, map_id, cert_id, this);
+    },
+    function finish(err) {
+      callback(err, certificate_id);
+    }
+  );
+};
+
+module.exports = SignedMaps;

lib/cartodb/sql/sql_api.js

@@ -1,66 +0,0 @@
-var _       = require('underscore'),
-    request = require('request');
-
-module.exports.query = function (username, api_key, sql, callback) {
-    var api = global.environment.sqlapi;
-
-    // build up api string
-    var sqlapihostname = username;
-    if ( api.domain ) sqlapihostname += '.' + api.domain;
-
-    var sqlapi = api.protocol + '://';
-    if ( api.host && api.host != api.domain ) sqlapi += api.host;
-    else sqlapi += sqlapihostname;
-    sqlapi += ':' + api.port + '/api/' + api.version + '/sql';
-
-    var qs  = { q: sql };
-
-    // add api_key if given
-    if (_.isString(api_key) && api_key != '') { qs.api_key = api_key; }
-
-    // call sql api
-    //
-    // NOTE: using POST to avoid size limits:
-    // See http://github.com/CartoDB/Windshaft-cartodb/issues/111
-    //
-    // NOTE: uses "host" header to allow IP based specification
-    //       of sqlapi address (and avoid a DNS lookup)
-    //
-    // NOTE: allows for keeping up to "maxConnections" concurrent
-    //       sockets opened per SQL-API host.
-    // See http://nodejs.org/api/http.html#http_agent_maxsockets
-    //
-    var maxSockets = global.environment.maxConnections || 128;
-    var maxGetLen = api.max_get_sql_length || 2048;
-    var maxSQLTime = api.timeout || 100; // 1/10 of a second by default
-    var reqSpec = {
-        url:sqlapi,
-        json:true,
-        headers:{host: sqlapihostname}
-        // http://nodejs.org/api/http.html#http_agent_maxsockets
-        ,pool:{maxSockets:maxSockets}
-        // timeout in milliseconds
-        ,timeout:maxSQLTime
-    };
-    if ( sql.length > maxGetLen ) {
-        reqSpec.method = 'POST';
-        reqSpec.body = qs;
-    } else {
-        reqSpec.method = 'GET';
-        reqSpec.qs = qs;
-    }
-    request(reqSpec, function(err, res, body) {
-        if (err){
-            console.log('ERROR connecting to SQL API on ' + sqlapi + ': ' + err);
-            callback(err);
-            return;
-        }
-        if (res.statusCode != 200) {
-            var msg = res.body.error ? res.body.error : res.body;
-            callback(new Error(msg));
-            console.log('unexpected response status (' + res.statusCode + ') for sql query: ' + sql + ': ' + msg);
-            return;
-        }
-        callback(null, body.rows);
-    });
-};

lib/cartodb/template_maps.js

@@ -1,12 +1,10 @@
-var crypto  = require('crypto'),
-    Step    = require('step'),
-    _       = require('underscore'),
-    dot     = require('dot');
-
-
-var EventEmitter = require('events').EventEmitter;
-var util = require('util');
+var crypto    = require('crypto');
+var Step      = require('step');
+var _         = require('underscore');
 
+// Templates in this hash (keyed as <username>@<template_name>)
+// are being worked on.
+var user_template_locks = {};
 
 // Class handling map templates
 //
@@ -16,16 +14,16 @@ var util = require('util');
 //        See https://github.com/CartoDB/node-redis-mpool
 //        Needs version 0.x.x of the API.
 //
+// @param signed_maps an instance of a "signed_maps" class,
+//        See signed_maps.js
+//
 // @param opts TemplateMap options. Supported elements:
 //    'max_user_templates' limit on the number of per-user
 //
 // 
-function TemplateMaps(redis_pool, opts) {
-  if (!(this instanceof TemplateMaps)) return new TemplateMaps();
-
-  EventEmitter.call(this);
-
+function TemplateMaps(redis_pool, signed_maps, opts) {
   this.redis_pool = redis_pool;
+  this.signed_maps = signed_maps;
   this.opts = opts || {};
 
   // Database containing templates
@@ -40,21 +38,17 @@ function TemplateMaps(redis_pool, opts) {
   // 
   // We have the following datastores:
   //
-  //  1. User templates: set of per-user map templates
+  //  1. User teplates: set of per-user map templates
+  //     NOTE: each template would have an associated auth
+  //           reference, see signed_maps.js
 
   // User templates (HASH:tpl_id->tpl_val)
-  this.key_usr_tpl = dot.template("map_tpl|{{=it.owner}}");
+  this.key_usr_tpl = "map_tpl|<%= owner %>";
 
   // User template locks (HASH:tpl_id->ctime)
-  this.key_usr_tpl_lck = dot.template("map_tpl|{{=it.owner}}|locks");
-
-  this.lock_ttl = this.opts['lock_ttl'] || 5000;
-}
-
-util.inherits(TemplateMaps, EventEmitter);
-
-module.exports = TemplateMaps;
+  this.key_usr_tpl_lck = "map_tpl|<%= owner %>|locks";
 
+};
 
 var o = TemplateMaps.prototype;
 
@@ -64,6 +58,14 @@ o._userTemplateLimit = function() {
   return this.opts['max_user_templates'] || 0;
 };
 
+o._acquireRedis = function(callback) {
+  this.redis_pool.acquire(this.db_signatures, callback);
+};
+
+o._releaseRedis = function(client) {
+  this.redis_pool.release(this.db_signatures, client);
+};
+
 /**
  * Internal function to communicate with redis
  *
@@ -93,7 +95,38 @@ o._redisCmd = function(redisFunc, redisArgs, callback) {
   );
 };
 
-var _reValidIdentifier = /^[a-zA-Z][0-9a-zA-Z_]*$/;
+// @param callback function(err, obtained)
+o._obtainTemplateLock = function(owner, tpl_id, callback) {
+  var usr_tpl_lck_key = _.template(this.key_usr_tpl_lck, {owner:owner});
+  var that = this;
+  var gotLock = false;
+  Step (
+    function obtainLock() {
+      var ctime = Date.now();
+      that._redisCmd('HSETNX', [usr_tpl_lck_key, tpl_id, ctime], this);
+    },
+    function checkLock(err, locked) {
+      if ( err ) throw err;
+      if ( ! locked ) {
+        // Already locked
+        // TODO: unlock if expired ?
+        throw new Error("Template '" + tpl_id + "' of user '" + owner + "' is locked");
+      }
+      return gotLock = true;
+    },
+    function finish(err) {
+      callback(err, gotLock);
+    }
+  );
+};
+
+// @param callback function(err, deleted)
+o._releaseTemplateLock = function(owner, tpl_id, callback) {
+  var usr_tpl_lck_key = _.template(this.key_usr_tpl_lck, {owner:owner});
+  this._redisCmd('HDEL', [usr_tpl_lck_key, tpl_id], callback);
+};
+
+o._reValidIdentifier = /^[a-zA-Z][0-9a-zA-Z_]*$/;
 o._checkInvalidTemplate = function(template) {
   if ( template.version != '0.0.1' ) {
     return new Error("Unsupported template version " + template.version);
@@ -102,88 +135,47 @@ o._checkInvalidTemplate = function(template) {
   if ( ! tplname ) {
     return new Error("Missing template name");
   }
-  if ( ! tplname.match(_reValidIdentifier) ) {
+  if ( ! tplname.match(this._reValidIdentifier) ) {
     return new Error("Invalid characters in template name '" + tplname + "'");
   }
 
-  var invalidError = isInvalidLayergroup(template.layergroup);
-  if (invalidError) {
-    return invalidError;
-  }
-
-  var placeholders = template.placeholders || {};
-
-  var placeholderKeys = Object.keys(placeholders);
-  for (var i = 0, len = placeholderKeys.length; i < len; i++) {
-      var placeholderKey = placeholderKeys[i];
-
-      if (!placeholderKey.match(_reValidIdentifier)) {
-          return new Error("Invalid characters in placeholder name '" + placeholderKey + "'");
-      }
-      if ( ! placeholders[placeholderKey].hasOwnProperty('default') ) {
-          return new Error("Missing default for placeholder '" + placeholderKey + "'");
-      }
-      if ( ! placeholders[placeholderKey].hasOwnProperty('type') ) {
-          return new Error("Missing type for placeholder '" + placeholderKey + "'");
-      }
-  }
-
-    var auth = template.auth || {};
-
-    switch ( auth.method ) {
-        case 'open':
-            break;
-        case 'token':
-            if ( ! _.isArray(auth.valid_tokens) )
-                return new Error("Invalid 'token' authentication: missing valid_tokens");
-            if ( ! auth.valid_tokens.length )
-                return new Error("Invalid 'token' authentication: no valid_tokens");
-            break;
-        default:
-            return new Error("Unsupported authentication method: " + auth.method);
-            break;
+  var phold = template.placeholders;
+  for (var k in phold) {
+    if ( ! k.match(this._reValidIdentifier) ) {
+      return new Error("Invalid characters in placeholder name '" + k + "'");
     }
+    if ( ! phold[k].hasOwnProperty('default') ) {
+      return new Error("Missing default for placeholder '" + k + "'");
+    }
+    if ( ! phold[k].hasOwnProperty('type') ) {
+      return new Error("Missing type for placeholder '" + k + "'");
+    }
+  };
 
-    return false;
+  // Check certificate validity
+  var cert = this.getTemplateCertificate(template);
+  var err = this.signed_maps.checkInvalidCertificate(cert);
+  if ( err ) return err;
+
+  // TODO: run more checks over template format ?
 };
 
-function isInvalidLayergroup(layergroup) {
-    if (!layergroup) {
-        return new Error('Missing layergroup');
-    }
-
-    var layers = layergroup.layers;
-
-    if (!_.isArray(layers) || layers.length === 0) {
-        return new Error('Missing or empty layers array from layergroup config');
-    }
-
-    var invalidLayers = layers
-        .map(function(layer, layerIndex) {
-            return layer.options ? null : layerIndex;
-        })
-        .filter(function(layerIndex) {
-            return layerIndex !== null;
-        });
-
-    if (invalidLayers.length) {
-        return new Error('Missing `options` in layergroup config for layers: ' + invalidLayers.join(', '));
-    }
-
-    return false;
-}
-
-function templateDefaults(template) {
-    var templateAuth = _.defaults({}, template.auth || {}, {
-        method: 'open'
-    });
-    return _.defaults({ auth: templateAuth }, template, {
-        placeholders: {}
-    });
-}
-
 //--------------- PUBLIC API -------------------------------------
 
+// Extract a signature certificate from a template
+//
+// The certificate will be ready to be passed to
+// SignedMaps.addCertificate or SignedMaps.authorizedByCert
+//
+o.getTemplateCertificate = function(template) {
+  var cert = {
+    version: '0.0.1',
+    template_id: template.name,
+    auth: template.auth
+  };
+  return cert;
+};
+
 // Add a template
 //
 // NOTE: locks user+template_name or fails
@@ -197,58 +189,102 @@ function templateDefaults(template) {
 //        Return template identifier (only valid for given user)
 //
 o.addTemplate = function(owner, template, callback) {
-    var self = this;
+  var invalidError = this._checkInvalidTemplate(template);
+  if ( invalidError ) {
+    callback(invalidError);
+    return;
+  }
+  var tplname = template.name;
 
-    template = templateDefaults(template);
+  // Procedure:
+  //
+  // - Check against limit
+  // 0. Obtain a lock for user+template_name, fail if impossible
+  // 1. Check no other template exists with the same name
+  // 2. Install certificate extracted from template, extending
+  //    it to contain a name to properly salt things out.
+  // 3. Modify the template object to reference certificate by id
+  // 4. Install template
+  // 5. Release lock
+  //
+  //
 
-    var invalidError = this._checkInvalidTemplate(template);
-    if ( invalidError ) {
-        return callback(invalidError);
-    }
+  var usr_tpl_key = _.template(this.key_usr_tpl, {owner:owner});
+  var gotLock = false;
+  var that = this;
+  var limit = that._userTemplateLimit();
+  Step(
+    function checkLimit() {
+      if ( ! limit ) return 0;
+      that._redisCmd('HLEN', [ usr_tpl_key ], this);
+    },
+    // try to obtain a lock
+    function obtainLock(err, len) {
+      if ( err ) throw err;
+      if ( limit && len >= limit ) {
+        throw new Error("User '" + owner + "' reached limit on number of templates (" + len + "/" + limit + ")");
+      }
+      that._obtainTemplateLock(owner, tplname, this);
+    },
+    function getExistingTemplate(err, locked) {
+      if ( err ) throw err;
+      if ( ! locked ) {
+        // Already locked
+        throw new Error("Template '" + tplname + "' of user '" + owner + "' is locked");
+      }
+      gotLock = true;
+      that._redisCmd('HEXISTS', [ usr_tpl_key, tplname ], this);
+    },
+    function installCertificate(err, exists) {
+      if ( err ) throw err;
+      if ( exists ) {
+        throw new Error("Template '" + tplname + "' of user '" + owner + "' already exists"); 
+      }
+      var cert = that.getTemplateCertificate(template);
+      that.signed_maps.addCertificate(owner, cert, this);
+    },
+    function installTemplate(err, crt_id) {
+      if ( err ) throw err;
+      template.auth_id = crt_id;
+      var tpl_val = JSON.stringify(template);
+      that._redisCmd('HSET', [ usr_tpl_key, tplname, tpl_val ], this);
+    },
+    function releaseLock(err, newfield) {
+      if ( ! err && ! newfield ) {
+        console.log("ERROR: addTemplate overridden existing template '"
+          + tplname + "' of '" + owner
+          + "' -- HSET returned " + overridden + ": someone added it without locking ?");
+        // TODO: how to recover this ?!
+      }
 
-    var templateName = template.name;
-    var userTemplatesKey = this.key_usr_tpl({ owner:owner });
-    var limit = this._userTemplateLimit();
+      if ( err && ! gotLock ) throw err;
 
-    Step(
-        function checkLimit() {
-            if ( ! limit ) {
-                return 0;
-            }
-            self._redisCmd('HLEN', [ userTemplatesKey ], this);
-        },
-        function installTemplateIfDoesNotExist(err, numberOfTemplates) {
-            if ( err ) {
-                throw err;
-            }
-            if ( limit && numberOfTemplates >= limit ) {
-                throw new Error("User '" + owner + "' reached limit on number of templates " +
-                    "("+ numberOfTemplates + "/" + limit + ")");
-            }
-            self._redisCmd('HSETNX', [ userTemplatesKey, templateName, JSON.stringify(template) ], this);
-        },
-        function validateInstallation(err, wasSet) {
-            if ( err ) {
-                throw err;
-            }
-            if ( ! wasSet ) {
-                throw new Error("Template '" + templateName + "' of user '" + owner + "' already exists");
-            }
-
-            return true;
-        },
-        function finish(err) {
-            if (!err) {
-                self.emit('add', owner, templateName, template);
-            }
-
-            callback(err, templateName, template);
+      // release the lock
+      var next = this;
+      that._releaseTemplateLock(owner, tplname, function(e, d) {
+        if ( e ) {
+          console.log("Error removing lock on template '" + tplname
+            + "' of user '" + owner + "': " + e);
+        } else if ( ! d ) {
+          console.log("ERROR: lock on template '" + tplname
+            + "' of user '" + owner + "' externally removed during insert!");
         }
+        next(err);
+      });
+    },
+    function finish(err) {
+      callback(err, tplname);
+    }
   );
 };
 
 // Delete a template
 //
+// NOTE: locks user+template_name or fails
+//
+// Also deletes associated authentication certificate, which
+// in turn deletes all instance signatures
+//
 // @param owner cartodb username of the template owner
 //
 // @param tpl_id template identifier as returned
@@ -257,28 +293,82 @@ o.addTemplate = function(owner, template, callback) {
 // @param callback function(err)
 //
 o.delTemplate = function(owner, tpl_id, callback) {
-    var self = this;
-    Step(
-        function deleteTemplate() {
-            self._redisCmd('HDEL', [ self.key_usr_tpl({ owner:owner }), tpl_id ], this);
-        },
-        function handleDeletion(err, deleted) {
-            if (err) {
-                throw err;
-            }
-            if (!deleted) {
-                throw new Error("Template '" + tpl_id + "' of user '" + owner + "' does not exist");
-            }
-            return true;
-        },
-        function finish(err) {
-            if (!err) {
-                self.emit('delete', owner, tpl_id);
-            }
-
-            callback(err);
+  var usr_tpl_key = _.template(this.key_usr_tpl, {owner:owner});
+  var gotLock = false;
+  var that = this;
+  Step(
+    // try to obtain a lock
+    function obtainLock() {
+      that._obtainTemplateLock(owner, tpl_id, this);
+    },
+    function getExistingTemplate(err, locked) {
+      if ( err ) throw err;
+      if ( ! locked ) {
+        // Already locked
+        throw new Error("Template '" + tpl_id + "' of user '" + owner + "' is locked");
+      }
+      gotLock = true;
+      that._redisCmd('HGET', [ usr_tpl_key, tpl_id ], this);
+    },
+    function delCertificate(err, tplval) {
+      if ( err ) throw err;
+      if ( ! tplval ) {
+        throw new Error("Template '" + tpl_id + "' of user '" + owner + "' does not exist"); 
+      }
+      var tpl = JSON.parse(tplval);
+      if ( ! tpl.auth_id ) {
+        // not sure this is an error, in case we'll ever
+        // allow unsigned templates...
+        console.log("ERROR: installed template '" + tpl_id
+            + "' of user '" + owner + "' has no auth_id reference: "); console.dir(tpl);
+        return null;
+      }
+      var next = this;
+      that.signed_maps.delCertificate(owner, tpl.auth_id, function(err) {
+        if ( err ) {
+          var msg = "ERROR: could not delete certificate '"
+                  + tpl.auth_id + "' associated with template '"
+                  + tpl_id + "' of user '" + owner + "': " + err;
+          // I'm actually not sure we want this event to be fatal
+          // (avoiding a deletion of the template itself) 
+          next(new Error(msg));
+        } else {
+          next();
         }
-    );
+      });
+    },
+    function delTemplate(err) {
+      if ( err ) throw err;
+      that._redisCmd('HDEL', [ usr_tpl_key, tpl_id ], this);
+    },
+    function releaseLock(err, deleted) {
+      if ( ! err && ! deleted ) {
+          console.log("ERROR: template '" + tpl_id
+            + "' of user '" + owner + "' externally removed during delete!");
+      }
+
+      if ( ! gotLock ) {
+        if ( err ) throw err;
+        return null;
+      }
+
+      // release the lock
+      var next = this;
+      that._releaseTemplateLock(owner, tpl_id, function(e, d) {
+        if ( e ) {
+          console.log("Error removing lock on template '" + tpl_id
+            + "' of user '" + owner + "': " + e);
+        } else if ( ! d ) {
+          console.log("ERROR: lock on template '" + tpl_id
+            + "' of user '" + owner + "' externally removed during delete!");
+        }
+        next(err);
+      });
+    },
+    function finish(err) {
+      callback(err);
+    }
+  );
 };
 
 // Update a template
@@ -298,54 +388,104 @@ o.delTemplate = function(owner, tpl_id, callback) {
 // @param callback function(err)
 //        
 o.updTemplate = function(owner, tpl_id, template, callback) {
-    var self = this;
 
-    template = templateDefaults(template);
+  var invalidError = this._checkInvalidTemplate(template);
+  if ( invalidError ) {
+    callback(invalidError);
+    return;
+  }
 
-    var invalidError = this._checkInvalidTemplate(template);
+  var tplname = template.name;
 
-    if ( invalidError ) {
-        return callback(invalidError);
-    }
+  if ( tpl_id != tplname ) {
+    callback(new Error("Cannot update name of a map template ('" + tpl_id + "' != '" + tplname + "')"));
+    return;
+  }
 
-    var templateName = template.name;
-
-    if ( tpl_id != templateName ) {
-        return callback(new Error("Cannot update name of a map template ('" + tpl_id + "' != '" + templateName + "')"));
-    }
-
-    var userTemplatesKey = this.key_usr_tpl({ owner:owner });
-
-    Step(
-        function getExistingTemplate() {
-            self._redisCmd('HGET', [ userTemplatesKey, tpl_id ], this);
-        },
-        function updateTemplate(err, currentTemplate) {
-            if (err) {
-                throw err;
-            }
-            if (!currentTemplate) {
-                throw new Error("Template '" + tpl_id + "' of user '" + owner + "' does not exist");
-            }
-            self._redisCmd('HSET', [ userTemplatesKey, templateName, JSON.stringify(template) ], this);
-        },
-        function handleTemplateUpdate(err, didSetNewField) {
-            if (err) {
-                throw err;
-            }
-            if (didSetNewField) {
-                console.warn('New template created on update operation');
-            }
-            return true;
-        },
-        function finish(err) {
-            if (!err) {
-                self.emit('update', owner, templateName, template);
-            }
-
-            callback(err, template);
+  var usr_tpl_key = _.template(this.key_usr_tpl, {owner:owner});
+  var gotLock = false;
+  var that = this;
+  Step(
+    // try to obtain a lock
+    function obtainLock() {
+      that._obtainTemplateLock(owner, tpl_id, this);
+    },
+    function getExistingTemplate(err, locked) {
+      if ( err ) throw err;
+      if ( ! locked ) {
+        // Already locked
+        throw new Error("Template '" + tpl_id + "' of user '" + owner + "' is locked");
+      }
+      gotLock = true;
+      that._redisCmd('HGET', [ usr_tpl_key, tpl_id ], this);
+    },
+    function delOldCertificate(err, tplval) {
+      if ( err ) throw err;
+      if ( ! tplval ) {
+        throw new Error("Template '" + tpl_id + "' of user '"
+                         + owner +"' does not exist");
+      }
+      var tpl = JSON.parse(tplval);
+      if ( ! tpl.auth_id ) {
+        // not sure this is an error, in case we'll ever
+        // allow unsigned templates...
+        console.log("ERROR: installed template '" + tpl_id
+            + "' of user '" + owner + "' has no auth_id reference: "); console.dir(tpl);
+        return null;
+      }
+      var next = this;
+      that.signed_maps.delCertificate(owner, tpl.auth_id, function(err) {
+        if ( err ) {
+          var msg = "ERROR: could not delete certificate '"
+                  + tpl.auth_id + "' associated with template '"
+                  + tpl_id + "' of user '" + owner + "': " + err;
+          // I'm actually not sure we want this event to be fatal
+          // (avoiding a deletion of the template itself) 
+          next(new Error(msg));
+        } else {
+          next();
         }
-    );
+      });
+    },
+    function installNewCertificate(err) {
+      if ( err ) throw err;
+      var cert = that.getTemplateCertificate(template);
+      that.signed_maps.addCertificate(owner, cert, this);
+    },
+    function updTemplate(err, crt_id) {
+      if ( err ) throw err;
+      template.auth_id = crt_id;
+      var tpl_val = JSON.stringify(template);
+      that._redisCmd('HSET', [ usr_tpl_key, tplname, tpl_val ], this);
+    },
+    function releaseLock(err, newfield) {
+      if ( ! err && newfield ) {
+          console.log("ERROR: template '" + tpl_id
+            + "' of user '" + owner + "' externally removed during update!");
+      }
+
+      if ( ! gotLock ) {
+        if ( err ) throw err;
+        return null;
+      }
+
+      // release the lock
+      var next = this;
+      that._releaseTemplateLock(owner, tpl_id, function(e, d) {
+        if ( e ) {
+          console.log("Error removing lock on template '" + tpl_id
+            + "' of user '" + owner + "': " + e);
+        } else if ( ! d ) {
+          console.log("ERROR: lock on template '" + tpl_id
+            + "' of user '" + owner + "' externally removed during update!");
+        }
+        next(err);
+      });
+    },
+    function finish(err) {
+      callback(err);
+    }
+  );
 };
 
 // List user templates
@@ -356,7 +496,8 @@ o.updTemplate = function(owner, tpl_id, template, callback) {
 //        Returns a list of template identifiers
 // 
 o.listTemplates = function(owner, callback) {
-    this._redisCmd('HKEYS', [ this.key_usr_tpl({owner:owner}) ], callback);
+  var usr_tpl_key = _.template(this.key_usr_tpl, {owner:owner});
+  this._redisCmd('HKEYS', [ usr_tpl_key ], callback);
 };
 
 // Get a templates
@@ -370,47 +511,22 @@ o.listTemplates = function(owner, callback) {
 //        Return full template definition
 //
 o.getTemplate = function(owner, tpl_id, callback) {
-    var self = this;
-    Step(
-        function getTemplate() {
-            self._redisCmd('HGET', [ self.key_usr_tpl({owner:owner}), tpl_id ], this);
-        },
-        function parseTemplate(err, tpl_val) {
-            if ( err ) throw err;
-            return JSON.parse(tpl_val);
-        },
-        function finish(err, tpl) {
-            callback(err, tpl);
-        }
-    );
-};
-
-o.isAuthorized = function(template, authTokens) {
-    if (!template) {
-        return false;
+  var usr_tpl_key = _.template(this.key_usr_tpl, {owner:owner});
+  var that = this;
+  Step(
+    function getTemplate() {
+      that._redisCmd('HGET', [ usr_tpl_key, tpl_id ], this);
+    },
+    function parseTemplate(err, tpl_val) {
+      if ( err ) throw err;
+      var tpl = JSON.parse(tpl_val);
+      // Should we strip auth_id ?
+      return tpl;
+    },
+    function finish(err, tpl) {
+      callback(err, tpl);
     }
-
-    authTokens = _.isArray(authTokens) ? authTokens : [authTokens];
-
-    var templateAuth = template.auth;
-
-    if (!templateAuth) {
-        return false;
-    }
-
-    if (_.isString(templateAuth) && templateAuth === 'open') {
-        return true;
-    }
-
-    if (templateAuth.method === 'open') {
-        return true;
-    }
-
-    if (templateAuth.method === 'token') {
-        return _.intersection(templateAuth.valid_tokens, authTokens).length > 0;
-    }
-
-    return false;
+  );
 };
 
 // Perform placeholder substitutions on a template
@@ -425,22 +541,25 @@ o.isAuthorized = function(template, authTokens) {
 //
 // @throws Error on malformed template or parameter
 //
-var _reNumber = /^([-+]?[\d\.]?\d+([eE][+-]?\d+)?)$/,
-    _reCSSColorName = /^[a-zA-Z]+$/,
-    _reCSSColorVal = /^#[0-9a-fA-F]{3,6}$/;
-
-_replaceVars = function(str, params) {
+o._reNumber = /^([-+]?[\d\.]?\d+([eE][+-]?\d+)?)$/;
+o._reCSSColorName = /^[a-zA-Z]+$/;
+o._reCSSColorVal = /^#[0-9a-fA-F]{3,6}$/;
+o._replaceVars = function(str, params) {
   //return _.template(str, params); // lazy way, possibly dangerous 
   // Construct regular expressions for each param
-    Object.keys(params).forEach(function(k) {
-        str = str.replace(new RegExp("<%=\\s*" + k + "\\s*%>", "g"), params[k]);
-    });
-    return str;
+  if ( ! params._re ) {
+    params._re = {};
+    for (var k in params) {
+      params._re[k] = RegExp("<%=\\s*" + k + "\\s*%>", "g");
+    }
+  }
+  for (var k in params) str = str.replace(params._re[k], params[k]);
+  return str;
 };
 o.instance = function(template, params) {
   var all_params = {};
-  var phold = template.placeholders || {};
-  Object.keys(phold).forEach(function(k) {
+  var phold = template.placeholders;
+  for (var k in phold) {
     var val = params.hasOwnProperty(k) ? params[k] : phold[k].default;
     var type = phold[k].type;
     // properly escape
@@ -454,7 +573,7 @@ o.instance = function(template, params) {
     }
     else if ( type === 'number' ) {
       // check it's a number
-      if ( typeof(val) !== 'number' && ! val.match(_reNumber) ) {
+      if ( typeof(val) !== 'number' && ! val.match(this._reNumber) ) {
         throw new Error("Invalid number value for template parameter '"
           + k + "': " + val);
       }
@@ -462,7 +581,7 @@ o.instance = function(template, params) {
     else if ( type === 'css_color' ) {
       // check it only contains letters or
       // starts with # and only contains hexdigits
-      if ( ! val.match(_reCSSColorName) && ! val.match(_reCSSColorVal) ) {
+      if ( ! val.match(this._reCSSColorName) && ! val.match(this._reCSSColorVal) ) {
         throw new Error("Invalid css_color value for template parameter '"
           + k + "': " + val);
       }
@@ -472,23 +591,16 @@ o.instance = function(template, params) {
       throw new Error("Invalid placeholder type '" + type + "'");
     }
     all_params[k] = val;
-  });
+  }
 
   // NOTE: we're deep-cloning the layergroup here
   var layergroup = JSON.parse(JSON.stringify(template.layergroup));
   for (var i=0; i<layergroup.layers.length; ++i) {
     var lyropt = layergroup.layers[i].options;
-    if ( lyropt.cartocss ) lyropt.cartocss = _replaceVars(lyropt.cartocss, all_params);
-    if ( lyropt.sql) lyropt.sql = _replaceVars(lyropt.sql, all_params);
+    if ( lyropt.cartocss ) lyropt.cartocss = this._replaceVars(lyropt.cartocss, all_params);
+    if ( lyropt.sql) lyropt.sql = this._replaceVars(lyropt.sql, all_params);
     // Anything else ?
   }
-
-  // extra information about the template
-  layergroup.template = {
-    name: template.name,
-    auth: template.auth
-  };
-
   return layergroup;
 };
 
@@ -499,3 +611,5 @@ o.fingerPrint = function(template) {
     .digest('hex')
   ;
 };
+
+module.exports = TemplateMaps;

package.json

@@ -1,7 +1,7 @@
 {
     "private": true,
     "name": "windshaft-cartodb",
-    "version": "1.26.2",
+    "version": "1.8.5",
     "description": "A map tile server for CartoDB",
     "keywords": [
       "cartodb"
@@ -22,30 +22,24 @@
       "Sandro Santilli <strk@vizzuality.com>"
     ],
     "dependencies": {
-        "node-varnish": "https://github.com/Vizzuality/node-varnish/tarball/0.3.0",
-        "underscore"  : "~1.6.0",
-        "dot": "~1.0.2",
-        "windshaft": "https://github.com/CartoDB/Windshaft/tarball/0.35.1",
-        "step": "~0.0.5",
-        "request": "~2.9.203",
-        "cartodb-redis": "https://github.com/CartoDB/node-cartodb-redis/tarball/0.11.0",
-        "cartodb-psql": "https://github.com/CartoDB/node-cartodb-psql/tarball/0.4.0",
-        "redis-mpool": "https://github.com/CartoDB/node-redis-mpool/tarball/0.3.0",
-        "lzma": "~1.3.7",
-        "log4js": "https://github.com/CartoDB/log4js-node/tarball/cdb",
-        "rollbar": "~0.3.13"
+        "node-varnish": "http://github.com/Vizzuality/node-varnish/tarball/v0.2.0",
+        "underscore"  : "~1.3.3",
+        "windshaft"  : "http://github.com/CartoDB/Windshaft/tarball/0.19.4",
+        "step": "0.0.x",
+        "request": "2.9.202",
+        "cartodb-redis": "~0.3.0",
+        "redis-mpool": "http://github.com/CartoDB/node-redis-mpool/tarball/0.0.4",
+        "mapnik": "~0.7.22",
+        "lzma": "~1.2.3",
+        "log4js": "~0.6.10"
     },
     "devDependencies": {
-        "mocha": "~1.21.4",
-        "redis": "~0.8.6",
-        "strftime": "~0.8.2",
-        "semver": "~1.1.4"
+        "mocha": "1.14.0",
+        "redis": "~0.8.3",
+        "strftime": "~0.6.0",
+        "semver": "~1.1.0"
     },
     "scripts": {
         "test": "make check"
-    },
-    "engines": {
-        "node": ">=0.8 <0.11",
-        "npm": ">=1.2.1"
     }
 }

run_tests.sh

@@ -5,8 +5,6 @@ OPT_CREATE_PGSQL=yes # create the PostgreSQL test environment
 OPT_DROP_REDIS=yes   # drop the redis test environment
 OPT_DROP_PGSQL=yes   # drop the PostgreSQL test environment
 
-export PGAPPNAME=cartodb_tiler_tester
-
 cd $(dirname $0)
 BASEDIR=$(pwd)
 cd -

test/acceptance/cache/surrogate_keys_invalidation.js

@@ -1,211 +0,0 @@
-var assert      = require('../../support/assert');
-var redis       = require('redis');
-var Step        = require('step');
-
-var helper = require(__dirname + '/../../support/test_helper');
-
-var SqlApiEmulator = require(__dirname + '/../../support/SQLAPIEmu.js');
-
-var NamedMapsCacheEntry = require(__dirname + '/../../../lib/cartodb/cache/model/named_maps_entry');
-var SurrogateKeysCache = require(__dirname + '/../../../lib/cartodb/cache/surrogate_keys_cache');
-
-var CartodbWindshaft = require(__dirname + '/../../../lib/cartodb/cartodb_windshaft');
-var ServerOptions = require(__dirname + '/../../../lib/cartodb/server_options');
-var serverOptions = ServerOptions();
-
-
-suite('templates surrogate keys', function() {
-
-    var redisClient,
-        sqlApiServer,
-        server;
-
-    var templateOwner = 'localhost',
-        templateName = 'acceptance',
-        expectedTemplateId = templateOwner + '@' + templateName,
-        template = {
-            version: '0.0.1',
-            name: templateName,
-            auth: {
-                method: 'open'
-            },
-            layergroup:  {
-                version: '1.2.0',
-                layers: [
-                    {
-                        options: {
-                            sql: 'select 1 cartodb_id, null::geometry as the_geom_webmercator',
-                            cartocss: '#layer { marker-fill:blue; }',
-                            cartocss_version: '2.3.0'
-                        }
-                    }
-                ]
-            }
-        },
-        expectedBody = { template_id: expectedTemplateId };
-
-    suiteSetup(function(done) {
-        // Enable Varnish purge for tests
-        serverOptions.varnish_purge_enabled = true;
-
-        server = new CartodbWindshaft(serverOptions);
-
-        sqlApiServer = new SqlApiEmulator(global.environment.sqlapi.port, done);
-
-        redisClient = redis.createClient(global.environment.redis.port);
-    });
-
-    var surrogateKeysCacheInvalidateFn = SurrogateKeysCache.prototype.invalidate;
-
-    beforeEach(function(done) {
-        var postTemplateRequest = {
-            url: '/tiles/template?api_key=1234',
-            method: 'POST',
-            headers: {
-                host: templateOwner,
-                'Content-Type': 'application/json'
-            },
-            data: JSON.stringify(template)
-        };
-
-        Step(
-            function postTemplate() {
-                var next = this;
-                assert.response(server,
-                    postTemplateRequest,
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        next(null, res);
-                    }
-                );
-            },
-            function rePostTemplate(err, res) {
-                if (err) {
-                    throw err;
-                }
-                var parsedBody = JSON.parse(res.body);
-                assert.deepEqual(parsedBody, expectedBody);
-                return true;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-    });
-
-    test("update template calls surrogate keys invalidation", function(done) {
-        var cacheEntryKey;
-        var surrogateKeysCacheInvalidateMethodInvoked = false;
-        SurrogateKeysCache.prototype.invalidate = function(cacheEntry) {
-            cacheEntryKey = cacheEntry.key();
-            surrogateKeysCacheInvalidateMethodInvoked = true;
-        };
-
-        Step(
-            function putValidTemplate() {
-                var updateTemplateRequest = {
-                    url: '/tiles/template/' + expectedTemplateId + '/?api_key=1234',
-                    method: 'PUT',
-                    headers: {
-                        host: templateOwner,
-                        'Content-Type': 'application/json'
-                    },
-                    data: JSON.stringify(template)
-                };
-                var next = this;
-                assert.response(server,
-                    updateTemplateRequest,
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        next(null, res);
-                    }
-                );
-            },
-            function checkValidUpdate(err, res) {
-                if (err) {
-                    throw err;
-                }
-                var parsedBody = JSON.parse(res.body);
-                assert.deepEqual(parsedBody, expectedBody);
-
-                assert.ok(surrogateKeysCacheInvalidateMethodInvoked);
-                assert.equal(cacheEntryKey, new NamedMapsCacheEntry(templateOwner, templateName).key());
-
-                return null;
-            },
-            function finish(err) {
-                if ( err ) {
-                    return done(err);
-                }
-                redisClient.keys("map_*|localhost", function(err, keys) {
-                    if ( err ) {
-                        return done(err);
-                    }
-                    redisClient.del(keys, function(err) {
-                        return done(err);
-                    });
-                });
-            }
-        );
-    });
-
-    test("delete template calls surrogate keys invalidation", function(done) {
-
-        var cacheEntryKey;
-        var surrogateKeysCacheInvalidateMethodInvoked = false;
-        SurrogateKeysCache.prototype.invalidate = function(cacheEntry) {
-            cacheEntryKey = cacheEntry.key();
-            surrogateKeysCacheInvalidateMethodInvoked = true;
-        };
-
-        Step(
-            function putValidTemplate() {
-                var deleteTemplateRequest = {
-                    url: '/tiles/template/' + expectedTemplateId + '/?api_key=1234',
-                    method: 'DELETE',
-                    headers: {
-                        host: templateOwner,
-                        'Content-Type': 'application/json'
-                    }
-                };
-                var next = this;
-                assert.response(server,
-                    deleteTemplateRequest,
-                    {
-                        status: 204
-                    },
-                    function(res) {
-                        next(null, res);
-                    }
-                );
-            },
-            function checkValidUpdate(err) {
-                if (err) {
-                    throw err;
-                }
-
-                assert.ok(surrogateKeysCacheInvalidateMethodInvoked);
-                assert.equal(cacheEntryKey, new NamedMapsCacheEntry(templateOwner, templateName).key());
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-    });
-
-    afterEach(function(done) {
-        SurrogateKeysCache.prototype.invalidate = surrogateKeysCacheInvalidateFn;
-        done();
-    });
-
-    suiteTeardown(function(done) {
-        sqlApiServer.close(done);
-    });
-
-});

test/acceptance/health_check.js

@@ -1,72 +0,0 @@
-var helper = require(__dirname + '/../support/test_helper');
-
-var assert      = require('../support/assert');
-var CartodbWindshaft = require(__dirname + '/../../lib/cartodb/cartodb_windshaft');
-var serverOptions = require(__dirname + '/../../lib/cartodb/server_options')();
-var server = new CartodbWindshaft(serverOptions);
-
-suite('health checks', function () {
-
-    beforeEach(function (done) {
-        global.environment.health = {
-            enabled: true,
-            username: 'localhost',
-            z: 0,
-            x: 0,
-            y: 0
-        };
-        done();
-    });
-
-    var healthCheckRequest = {
-        url: '/health',
-        method: 'GET',
-        headers: {
-            host: 'localhost'
-        }
-    };
-
-    test('returns 200 and ok=true with enabled configuration', function (done) {
-        assert.response(server,
-            healthCheckRequest,
-            {
-                status: 200
-            },
-            function (res, err) {
-              console.log(res.body);
-                assert.ok(!err);
-
-                var parsed = JSON.parse(res.body);
-
-                assert.ok(parsed.enabled);
-                assert.ok(parsed.ok);
-
-                done();
-            }
-        );
-    });
-
-    test('fails for invalid user because it is not in redis', function (done) {
-        global.environment.health.username = 'invalid';
-
-        assert.response(server,
-            healthCheckRequest,
-            {
-                status: 503
-            },
-            function (res, err) {
-                assert.ok(!err);
-
-                var parsed = JSON.parse(res.body);
-
-                assert.equal(parsed.enabled, true);
-                assert.equal(parsed.ok, false);
-
-                assert.equal(parsed.result.redis.ok, false);
-
-                done();
-            }
-        );
-    });
-
-});

test/acceptance/multilayer.js

@@ -4,6 +4,7 @@ var _           = require('underscore');
 var redis       = require('redis');
 var querystring = require('querystring');
 var semver      = require('semver');
+var mapnik      = require('mapnik');
 var Step        = require('step');
 var strftime    = require('strftime');
 var SQLAPIEmu   = require(__dirname + '/../support/SQLAPIEmu.js');
@@ -13,20 +14,13 @@ var helper = require(__dirname + '/../support/test_helper');
 
 var windshaft_fixtures = __dirname + '/../../node_modules/windshaft/test/fixtures';
 
-var IMAGE_EQUALS_TOLERANCE_PER_MIL = 20;
-var IMAGE_EQUALS_HIGHER_TOLERANCE_PER_MIL = 25;
-
 var CartodbWindshaft = require(__dirname + '/../../lib/cartodb/cartodb_windshaft');
 var ServerOptions = require(__dirname + '/../../lib/cartodb/server_options');
 serverOptions = ServerOptions();
 var server = new CartodbWindshaft(serverOptions);
 server.setMaxListeners(0);
 
-[true, false].forEach(function(cdbQueryTablesFromPostgresEnabledValue) {
-
-global.environment.enabledFeatures = {cdbQueryTablesFromPostgres: cdbQueryTablesFromPostgresEnabledValue};
-
-suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function() {
+suite('multilayer', function() {
 
     var redis_client = redis.createClient(global.environment.redis.port);
     var sqlapi_server;
@@ -114,15 +108,12 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               assert.equal(cc.substring(0, dbname.length), dbname);
               var jsonquery = cc.substring(dbname.length+1);
               var sentquery = JSON.parse(jsonquery);
-              var expectedQuery = [layergroup.layers[0].options.sql, ';', layergroup.layers[1].options.sql].join('');
-              assert.equal(sentquery.q, 'WITH querytables AS ( SELECT * FROM CDB_QueryTables($windshaft$'
-                + expectedQuery
-                + '$windshaft$) as tablenames )'
-                + ' SELECT (SELECT tablenames FROM querytables), EXTRACT(EPOCH FROM max(updated_at)) as max'
-                + ' FROM CDB_TableMetadata m'
-                + ' WHERE m.tabname = any ((SELECT tablenames from querytables)::regclass[])');
+              assert.equal(sentquery.q, 'SELECT CDB_QueryTables($windshaft$'
+                + layergroup.layers[0].options.sql + ';'
+                + layergroup.layers[1].options.sql 
+                + '$windshaft$)');
 
-              assert.imageEqualsFile(res.body, 'test/fixtures/test_table_0_0_0_multilayer1.png', IMAGE_EQUALS_HIGHER_TOLERANCE_PER_MIL,
+              assert.imageEqualsFile(res.body, 'test/fixtures/test_table_0_0_0_multilayer1.png', 2,
                 function(err, similarity) {
                   next(err);
               });
@@ -157,7 +148,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               method: 'GET'
           }, {}, function(res) {
               assert.equal(res.statusCode, 200, res.body);
-              assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
+              assert.equal(res.headers['content-type'], "text/javascript; charset=utf-8; charset=utf-8");
               assert.utfgridEqualsFile(res.body, 'test/fixtures/test_table_0_0_0_multilayer1.layer0.grid.json', 2,
                 function(err, similarity) {
                   next(err);
@@ -175,7 +166,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               method: 'GET'
           }, {}, function(res) {
               assert.equal(res.statusCode, 200, res.body);
-              assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
+              assert.equal(res.headers['content-type'], "text/javascript; charset=utf-8; charset=utf-8");
               assert.utfgridEqualsFile(res.body, 'test/fixtures/test_table_0_0_0_multilayer1.layer1.grid.json', 2,
                 function(err, similarity) {
                   next(err);
@@ -201,41 +192,9 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
       );
     });
 
-
-    test("should include serverMedata in the response", function(done) {
-      global.environment.serverMetadata = { cdn_url : { http:'test', https: 'tests' } }
-      var layergroup =  {
-        version: '1.0.0',
-        layers: [
-           { options: {
-               sql: 'select cartodb_id, ST_Translate(the_geom_webmercator, 5e6, 0) as the_geom_webmercator from test_table limit 2',
-               cartocss: '#layer { marker-fill:red; marker-width:32; marker-allow-overlap:true; }', 
-               cartocss_version: '2.0.1'
-             } }
-        ]
-      };
-
-      var expected_token; 
-      Step(
-        function do_create_get()
-        {
-          var next = this;
-          assert.response(server, {
-              url: '/tiles/layergroup?config=' + encodeURIComponent(JSON.stringify(layergroup)),
-              method: 'GET',
-              headers: {host: 'localhost'} 
-          }, {}, function(res, err) { next(err, res); });
-        },
-        function do_check_create(err, res) {
-          var parsed = JSON.parse(res.body);
-          assert.ok(_.isEqual(parsed.cdn_url, global.environment.serverMetadata.cdn_url));
-          done();
-        }
-      )
-    });
-
-
-    test("get creation requests has cache", function(done) {
+    // See https://github.com/CartoDB/Windshaft-cartodb/issues/176
+    // NOTE: another test like this is in templates.js
+    test("get creation requests no cache", function(done) {
 
       var layergroup =  {
         version: '1.0.0',
@@ -264,7 +223,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
           assert.equal(res.statusCode, 200, res.body);
           var parsedBody = JSON.parse(res.body);
           expected_token = parsedBody.layergroupid.split(':')[0];
-          helper.checkCache(res);
+          helper.checkNoCache(res);
           return null;
         },
         function finish(err) {
@@ -286,49 +245,6 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
       );
     });
 
-    test("get creation has no cache if sql is bogus", function(done) {
-        var layergroup =  {
-            version: '1.0.0',
-            layers: [
-                { options: {
-                    sql: 'select bogus(0,0) as the_geom_webmercator',
-                    cartocss: '#layer { polygon-fill: red; }',
-                    cartocss_version: '2.0.1'
-                } }
-            ]
-        };
-        assert.response(server, {
-            url: '/tiles/layergroup?config=' + encodeURIComponent(JSON.stringify(layergroup)),
-            method: 'GET',
-            headers: {host: 'localhost'}
-        }, {}, function(res) {
-            assert.notEqual(res.statusCode, 200);
-            helper.checkNoCache(res);
-            done();
-        });
-    });
-
-    test("get creation has no cache if cartocss is not valid", function(done) {
-        var layergroup =  {
-            version: '1.0.0',
-            layers: [
-                { options: {
-                    sql: 'select cartodb_id, ST_Translate(the_geom_webmercator, 5e6, 0) as the_geom_webmercator from test_table limit 2',
-                    cartocss: '#layer { invalid-rule:red; }',
-                    cartocss_version: '2.0.1'
-                } }
-            ]
-        };
-        assert.response(server, {
-            url: '/tiles/layergroup?config=' + encodeURIComponent(JSON.stringify(layergroup)),
-            method: 'GET',
-            headers: {host: 'localhost'}
-        }, {}, function(res) {
-            assert.notEqual(res.statusCode, 200);
-            helper.checkNoCache(res);
-            done();
-        });
-    });
 
     test("layergroup can hold substitution tokens", function(done) {
 
@@ -393,18 +309,14 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               assert.equal(cc.substring(0, dbname.length), dbname);
               var jsonquery = cc.substring(dbname.length+1);
               var sentquery = JSON.parse(jsonquery);
-              var expectedQuery = layergroup.layers[0].options.sql
-                  .replace(/!bbox!/g, 'ST_MakeEnvelope(0,0,0,0)')
-                  .replace(/!pixel_width!/g, '1')
-                  .replace(/!pixel_height!/g, '1');
-              assert.equal(sentquery.q, 'WITH querytables AS ( SELECT * FROM CDB_QueryTables($windshaft$'
-                  + expectedQuery
-                  + '$windshaft$) as tablenames )'
-                  + ' SELECT (SELECT tablenames FROM querytables), EXTRACT(EPOCH FROM max(updated_at)) as max'
-                  + ' FROM CDB_TableMetadata m'
-                  + ' WHERE m.tabname = any ((SELECT tablenames from querytables)::regclass[])');
+              assert.equal(sentquery.q, 'SELECT CDB_QueryTables($windshaft$'
+                + layergroup.layers[0].options.sql
+                    .replace(RegExp('!bbox!', 'g'), 'ST_MakeEnvelope(0,0,0,0)')
+                    .replace(RegExp('!pixel_width!', 'g'), '1')
+                    .replace(RegExp('!pixel_height!', 'g'), '1')
+                + '$windshaft$)');
 
-              assert.imageEqualsFile(res.body, 'test/fixtures/test_multilayer_bbox.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+              assert.imageEqualsFile(res.body, 'test/fixtures/test_multilayer_bbox.png', 2,
                 function(err, similarity) {
                   next(err);
               });
@@ -430,18 +342,14 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               assert.equal(cc.substring(0, dbname.length), dbname);
               var jsonquery = cc.substring(dbname.length+1);
               var sentquery = JSON.parse(jsonquery);
-              var expectedQuery = layergroup.layers[0].options.sql
-                  .replace('!bbox!', 'ST_MakeEnvelope(0,0,0,0)')
-                  .replace('!pixel_width!', '1')
-                  .replace('!pixel_height!', '1');
-              assert.equal(sentquery.q, 'WITH querytables AS ( SELECT * FROM CDB_QueryTables($windshaft$'
-                  + expectedQuery
-                  + '$windshaft$) as tablenames )'
-                  + ' SELECT (SELECT tablenames FROM querytables), EXTRACT(EPOCH FROM max(updated_at)) as max'
-                  + ' FROM CDB_TableMetadata m'
-                  + ' WHERE m.tabname = any ((SELECT tablenames from querytables)::regclass[])');
+              assert.equal(sentquery.q, 'SELECT CDB_QueryTables($windshaft$'
+                + layergroup.layers[0].options.sql
+                    .replace('!bbox!', 'ST_MakeEnvelope(0,0,0,0)')
+                    .replace('!pixel_width!', '1')
+                    .replace('!pixel_height!', '1')
+                + '$windshaft$)');
 
-              assert.imageEqualsFile(res.body, 'test/fixtures/test_multilayer_bbox.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+              assert.imageEqualsFile(res.body, 'test/fixtures/test_multilayer_bbox.png', 2,
                 function(err, similarity) {
                   next(err);
               });
@@ -458,7 +366,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               method: 'GET'
           }, {}, function(res) {
               assert.equal(res.statusCode, 200, res.body);
-              assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
+              assert.equal(res.headers['content-type'], "text/javascript; charset=utf-8; charset=utf-8");
               assert.utfgridEqualsFile(res.body, 'test/fixtures/test_multilayer_bbox.grid.json', 2,
                 function(err, similarity) {
                   next(err);
@@ -476,7 +384,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               method: 'GET'
           }, {}, function(res) {
               assert.equal(res.statusCode, 200, res.body);
-              assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
+              assert.equal(res.headers['content-type'], "text/javascript; charset=utf-8; charset=utf-8");
               assert.utfgridEqualsFile(res.body, 'test/fixtures/test_multilayer_bbox.grid.json', 2,
                 function(err, similarity) {
                   next(err);
@@ -752,7 +660,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
               method: 'GET'
           }, {}, function(res) {
               assert.equal(res.statusCode, 200, res.body);
-              assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
+              assert.equal(res.headers['content-type'], "text/javascript; charset=utf-8; charset=utf-8");
               next(err);
           });
         },
@@ -1070,7 +978,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
           }, {}, function(res) {
               assert.equal(res.statusCode, 200, res.body);
               assert.equal(res.headers['content-type'], "image/png");
-              assert.imageEqualsFile(res.body, windshaft_fixtures + '/test_default_mapnik_point.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+              assert.imageEqualsFile(res.body, windshaft_fixtures + '/test_default_mapnik_point.png', 2,
                 function(err, similarity) {
                   next(err);
               });
@@ -1324,49 +1232,6 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
       );
     });
 
-    var layergroupTtlRequest = {
-        url: '/tiles/layergroup?config=' + encodeURIComponent(JSON.stringify({
-            version: '1.0.0',
-            layers: [
-                { options: {
-                    sql: 'select * from test_table limit 2',
-                    cartocss: '#layer { marker-fill:red; marker-width:32; marker-allow-overlap:true; }',
-                    cartocss_version: '2.0.1'
-                } }
-            ]
-        })),
-        method: 'GET',
-        headers: {host: 'localhost'}
-    };
-    var layergroupTtlResponseExpectation = {
-        status: 200
-    };
-
-    test("cache control for layergroup default value", function(done) {
-        global.environment.varnish.layergroupTtl = null;
-
-        assert.response(server, layergroupTtlRequest, layergroupTtlResponseExpectation,
-            function(res) {
-                assert.equal(res.headers['cache-control'], 'public,max-age=86400,must-revalidate');
-
-                done();
-            }
-        );
-    });
-
-    test("cache control for layergroup uses configuration for max-age", function(done) {
-        var layergroupTtl = 300;
-        global.environment.varnish.layergroupTtl = layergroupTtl;
-
-        assert.response(server, layergroupTtlRequest, layergroupTtlResponseExpectation,
-            function(res) {
-                assert.equal(res.headers['cache-control'], 'public,max-age=' + layergroupTtl + ',must-revalidate');
-
-                done();
-            }
-        );
-    });
-
 
     suiteTeardown(function(done) {
 
@@ -1388,4 +1253,3 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
     
 });
 
-});

test/acceptance/server.js

@@ -4,31 +4,24 @@ var _           = require('underscore');
 var redis       = require('redis');
 var querystring = require('querystring');
 var semver      = require('semver');
+var mapnik      = require('mapnik');
 var Step        = require('step');
 var http        = require('http');
 var SQLAPIEmu   = require(__dirname + '/../support/SQLAPIEmu.js');
 
 var helper = require(__dirname + '/../support/test_helper');
 
-var IMAGE_EQUALS_TOLERANCE_PER_MIL = 20,
-    IMAGE_EQUALS_ZERO_TOLERANCE_PER_MIL = 0;
-
 var CartodbWindshaft = require(__dirname + '/../../lib/cartodb/cartodb_windshaft');
 var serverOptions = require(__dirname + '/../../lib/cartodb/server_options')();
 var server = new CartodbWindshaft(serverOptions);
 server.setMaxListeners(0);
 
-[true, false].forEach(function(cdbQueryTablesFromPostgresEnabledValue) {
-
-global.environment.enabledFeatures = {cdbQueryTablesFromPostgres: cdbQueryTablesFromPostgresEnabledValue};
-
-suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function() {
-
+suite('server', function() {
 
     var redis_client = redis.createClient(global.environment.redis.port);
     var sqlapi_server;
 
-    var mapnik_version = global.environment.mapnik_version || server.getVersion().mapnik;
+    var mapnik_version = global.environment.mapnik_version || mapnik.versions.mapnik;
     var test_database = _.template(global.environment.postgres_auth_user, {user_id:1}) + '_db';
     var default_style;
     if ( semver.satisfies(mapnik_version, '<2.1.0') ) {
@@ -586,7 +579,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             method: 'GET'
         },{
             status: 200,
-            headers: { 'Content-Type': 'application/json; charset=utf-8',
+            headers: { 'Content-Type': 'text/javascript; charset=utf-8; charset=utf-8',
                        'X-Cache-Channel': test_database+':gadm4' }
         }, function() { done(); });
     });
@@ -598,7 +591,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             method: 'GET'
         },{
             status: 200,
-            headers: { 'Content-Type': 'application/json; charset=utf-8' }
+            headers: { 'Content-Type': 'text/javascript; charset=utf-8; charset=utf-8' }
         }, function() { done(); });
     });
     
@@ -610,7 +603,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             method: 'GET'
         },{
             status: 200,
-            headers: { 'Content-Type': 'application/json; charset=utf-8' }
+            headers: { 'Content-Type': 'text/javascript; charset=utf-8; charset=utf-8' }
         }, function() { done(); });
     });
 
@@ -627,24 +620,6 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
         });
     });
 
-    // See http://github.com/CartoDB/Windshaft-cartodb/issues/186
-    test("get'ing the grid of a private table should fail when unauthenticated (jsonp)",
-    function(done) {
-        assert.response(server, {
-            headers: {host: 'localhost'},
-            url: '/tiles/test_table_private_1/6/31/24.grid.json?callback=x',
-            method: 'GET'
-        },{}, function(res) {
-          // It's forbidden, but jsonp calls for status = 200
-          assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
-          // Still, we do NOT want to add caching headers here
-          // See https://github.com/CartoDB/Windshaft-cartodb/issues/186
-          assert.ok(!res.headers.hasOwnProperty('cache-control'),
-            "Unexpected Cache-Control: " + res.headers['cache-control']);
-          done();
-        });
-    });
-
     // See http://github.com/Vizzuality/Windshaft-cartodb/issues/55
     test("get'ing grid of private table should fail on unknown username",
     function(done) {
@@ -849,7 +824,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
           assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
           var ct = res.headers['content-type'];
           assert.equal(ct, 'image/png');
-          assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+          assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png',  2,
             function(err, similarity) {
               if (err) throw err;
               done();
@@ -880,7 +855,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             assert.equal(ct, 'image/png');
             assert.imageEqualsFile(res.body,
               './test/fixtures/test_table_15_16046_12354_styled_black.png',
-              IMAGE_EQUALS_TOLERANCE_PER_MIL, this);
+              2, this);
           },
           function checkImage(err, similarity) {
               if (err) throw err;
@@ -896,8 +871,8 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
     // See https://github.com/CartoDB/Windshaft-cartodb/issues/89
     test("get'ing a tile with a user-specific database password",  function(done){
         var style = querystring.stringify({style: test_style_black_200, style_version: '2.0.0'});
-        var backupDBPass = global.environment.postgres_auth_pass;
-        global.environment.postgres_auth_pass = '<%= user_password %>';
+        var backupDBPass = global.settings.postgres_auth_pass;
+        global.settings.postgres_auth_pass = '<%= user_password %>';
         Step (
           function() {
             var next = this;
@@ -917,14 +892,14 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             assert.equal(ct, 'image/png');
             assert.imageEqualsFile(res.body,
               './test/fixtures/test_table_15_16046_12354_styled_black.png',
-              IMAGE_EQUALS_TOLERANCE_PER_MIL, this);
+              2, this);
           },
           function checkImage(err, similarity) {
               if (err) throw err;
               return null
           },
           function finish(err) {
-            global.environment.postgres_auth_pass = backupDBPass;
+            global.settings.postgres_auth_pass = backupDBPass;
             done(err);
           }
         );
@@ -941,7 +916,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
           assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
           var ct = res.headers['content-type'];
           assert.equal(ct, 'image/png');
-          assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+          assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png',  2,
             function(err, similarity) {
               if (err) throw err;
               done();
@@ -978,7 +953,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
             var ct = res.headers['content-type'];
             assert.equal(ct, 'image/png');
-            assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+            assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png',  2,
               function(err, similarity) {
                 next(err);
             });
@@ -1018,7 +993,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
             var ct = res.headers['content-type'];
             assert.equal(ct, 'image/png');
-            assert.imageEqualsFile(res.body, './test/fixtures/blank.png', IMAGE_EQUALS_ZERO_TOLERANCE_PER_MIL,
+            assert.imageEqualsFile(res.body, './test/fixtures/blank.png',  0,
               function(err, similarity) {
                 if (err) next(err); 
                 else next();
@@ -1038,7 +1013,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
             var ct = res.headers['content-type'];
             assert.equal(ct, 'image/png');
-            assert.imageEqualsFile(res.body, './test/fixtures/blank.png', IMAGE_EQUALS_ZERO_TOLERANCE_PER_MIL,
+            assert.imageEqualsFile(res.body, './test/fixtures/blank.png',  0,
               function(err, similarity) {
                 if (err) next(err); 
                 else next();
@@ -1075,7 +1050,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
             var ct = res.headers['content-type'];
             assert.equal(ct, 'image/png');
-            assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+            assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png',  2,
               function(err, similarity) {
                 // NOTE: we expect them to be EQUAL here
                 if (err) { next(err); return; }
@@ -1112,7 +1087,7 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
             assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
             var ct = res.headers['content-type'];
             assert.equal(ct, 'image/png');
-            assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png', IMAGE_EQUALS_TOLERANCE_PER_MIL,
+            assert.imageEqualsFile(res.body, './test/fixtures/test_table_15_16046_12354_styled_black.png',  2,
               function(err, similarity) {
                 // NOTE: we expect them to be different here
                 if (err) next(); 
@@ -1393,4 +1368,3 @@ suite('multilayer:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function(
     
 });
 
-});

test/acceptance/templates.js

@@ -3,9 +3,9 @@ var _           = require('underscore');
 var redis       = require('redis');
 var querystring = require('querystring');
 var semver      = require('semver');
+var mapnik      = require('mapnik');
 var Step        = require('step');
 var strftime    = require('strftime');
-var NamedMapsCacheEntry = require(__dirname + '/../../lib/cartodb/cache/model/named_maps_entry');
 var SQLAPIEmu   = require(__dirname + '/../support/SQLAPIEmu.js');
 var redis_stats_db = 5;
 
@@ -20,16 +20,11 @@ var helper = require(__dirname + '/../support/test_helper');
 var windshaft_fixtures = __dirname + '/../../node_modules/windshaft/test/fixtures';
 
 var CartodbWindshaft = require(__dirname + '/../../lib/cartodb/cartodb_windshaft');
-var ServerOptions = require(__dirname + '/../../lib/cartodb/server_options');
-var serverOptions = ServerOptions();
+var serverOptions = require(__dirname + '/../../lib/cartodb/server_options')();
 var server = new CartodbWindshaft(serverOptions);
 server.setMaxListeners(0);
 
-[true, false].forEach(function(cdbQueryTablesFromPostgresEnabledValue) {
-
-global.environment.enabledFeatures = {cdbQueryTablesFromPostgres: cdbQueryTablesFromPostgresEnabledValue};
-
-suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, function() {
+suite('template_api', function() {
 
     var redis_client = redis.createClient(global.environment.redis.port);
     var sqlapi_server;
@@ -58,29 +53,6 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
         }
     };
 
-    function makeTemplate(templateName) {
-        return {
-            version: '0.0.1',
-            name: templateName || 'acceptance1',
-            auth: { method: 'open' },
-            layergroup:  {
-                version: '1.0.0',
-                    layers: [
-                    { options: {
-                        sql: 'select cartodb_id, ST_Translate(the_geom_webmercator, -5e6, 0) as the_geom_webmercator from test_table limit 2 offset 2',
-                        cartocss: '#layer { marker-fill:blue; marker-allow-overlap:true; }',
-                        cartocss_version: '2.0.2',
-                        interactivity: 'cartodb_id'
-                    } }
-                ]
-            }
-        };
-    }
-
-    function extendDefaultsTemplate(template) {
-        return _.extend({}, template, {auth: {method: 'open'}, placeholders: {}});
-    }
-
     test("can add template, returning id", function(done) {
 
       var errors = [];
@@ -142,12 +114,15 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
                 if ( m.match(/^map_(tpl|crt)|/) )
                   return m;
               });
-              if ( todrop.length !== 1 ) {
+              if ( todrop.length != 2 ) {
                 errors.push(new Error("Unexpected keys in redis: " + todrop));
               } else {
                 if ( todrop.indexOf('map_tpl|localhost') == -1 ) {
                   errors.push(new Error("Missing 'map_tpl|localhost' key in redis"));
                 }
+                if ( todrop.indexOf('map_crt|localhost') == -1 ) {
+                  errors.push(new Error("Missing 'map_crt|localhost' key in redis"));
+                }
               }
               redis_client.del(todrop, function(err) {
                 if ( err ) errors.push(err.message);
@@ -333,52 +308,6 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
       });
     });
 
-    test("instance endpoint should return server metadata", function(done){
-      global.environment.serverMetadata = { cdn_url : { http:'test', https: 'tests' } }
-      var tmpl = _.clone(template_acceptance1)
-      tmpl.name = "rambotemplate2"
-
-      Step(function postTemplate1(err, res) {
-          var next = this;
-          var post_request = {
-              url: '/tiles/template?api_key=1234',
-              method: 'POST',
-              headers: {host: 'localhost', 'Content-Type': 'application/json' },
-              data: JSON.stringify(tmpl)
-          };
-          assert.response(server, post_request, {}, function(res) { 
-            next(null, res); 
-          });
-        },
-        function testCORS() {
-          var next = this;
-          assert.response(server, {
-              url: '/tiles/template/' + tmpl.name,
-              method: 'POST',
-              headers: {host: 'localhost', 'Content-Type': 'application/json' },
-          },{
-              status: 200
-          }, function(res) { 
-            var parsed = JSON.parse(res.body);
-            assert.ok(_.isEqual(parsed.cdn_url, global.environment.serverMetadata.cdn_url));
-            next(null); 
-          });
-        },
-        function deleteTemplate(err) {
-          if ( err ) throw err;
-          var del_request = {
-              url: '/tiles/template/' + tmpl.name + '?api_key=1234', 
-              method: 'DELETE',
-              headers: {host: 'localhost', 'Content-Type': 'application/json' }
-          }
-          var next = this;
-          assert.response(server, del_request, {},
-            function(res) { done(); });
-        }
-      );
-    });
-
-
 
     test("can list templates", function(done) {
 
@@ -478,12 +407,15 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
                 if ( m.match(/^map_(tpl|crt)|/) )
                   return m;
               });
-              if ( todrop.length !== 1 ) {
+              if ( todrop.length != 2 ) {
                 errors.push(new Error("Unexpected keys in redis: " + todrop));
               } else {
                 if ( todrop.indexOf('map_tpl|localhost') == -1 ) {
                   errors.push(new Error("Missing 'map_tpl|localhost' key in redis"));
                 }
+                if ( todrop.indexOf('map_crt|localhost') == -1 ) {
+                  errors.push(new Error("Missing 'map_crt|localhost' key in redis"));
+                }
               }
               redis_client.del(todrop, function(err) {
                 if ( err ) errors.push(err.message);
@@ -510,7 +442,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
               url: '/tiles/template?api_key=1234',
               method: 'POST',
               headers: {host: 'localhost', 'Content-Type': 'application/json' },
-              data: JSON.stringify(makeTemplate())
+              data: JSON.stringify(template_acceptance1)
           }
           assert.response(server, post_request, {},
             function(res) { next(null, res); });
@@ -548,7 +480,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
               url: '/tiles/template/unexistent/?api_key=1234',
               method: 'PUT',
               headers: {host: 'localhost', 'Content-Type': 'application/json' },
-              data: JSON.stringify(makeTemplate())
+              data: JSON.stringify(template_acceptance1)
           }
           var next = this;
           assert.response(server, put_request, {},
@@ -566,7 +498,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
               url: '/tiles/template/' + tpl_id + '/?api_key=1234',
               method: 'PUT',
               headers: {host: 'localhost', 'Content-Type': 'application/json' },
-              data: JSON.stringify(makeTemplate())
+              data: JSON.stringify(template_acceptance1)
           }
           var next = this;
           assert.response(server, put_request, {},
@@ -590,12 +522,15 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
                 if ( m.match(/^map_(tpl|crt)|/) )
                   return m;
               });
-              if ( todrop.length !== 1 ) {
+              if ( todrop.length != 2 ) {
                 errors.push(new Error("Unexpected keys in redis: " + todrop));
               } else {
                 if ( todrop.indexOf('map_tpl|localhost') == -1 ) {
                   errors.push(new Error("Missing 'map_tpl|localhost' key in redis"));
                 }
+                if ( todrop.indexOf('map_crt|localhost') == -1 ) {
+                  errors.push(new Error("Missing 'map_crt|localhost' key in redis"));
+                }
               }
               redis_client.del(todrop, function(err) {
                 if ( err ) errors.push(err.message);
@@ -622,7 +557,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
               url: '/tiles/template?api_key=1234',
               method: 'POST',
               headers: {host: 'localhost', 'Content-Type': 'application/json' },
-              data: JSON.stringify(makeTemplate())
+              data: JSON.stringify(template_acceptance1)
           }
           assert.response(server, post_request, {},
             function(res) { next(null, res); });
@@ -668,7 +603,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           var parsed = JSON.parse(res.body);
           assert.ok(parsed.hasOwnProperty('template'),
             "Missing 'template' from response body: " + res.body);
-          assert.deepEqual(extendDefaultsTemplate(makeTemplate()), parsed.template);
+          assert.deepEqual(template_acceptance1, parsed.template);
           return null;
         },
         function finish(err) {
@@ -679,12 +614,15 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
                 if ( m.match(/^map_(tpl|crt)|/) )
                   return m;
               });
-              if ( todrop.length !== 1 ) {
+              if ( todrop.length != 2 ) {
                 errors.push(new Error("Unexpected keys in redis: " + todrop));
               } else {
                 if ( todrop.indexOf('map_tpl|localhost') == -1 ) {
                   errors.push(new Error("Missing 'map_tpl|localhost' key in redis"));
                 }
+                if ( todrop.indexOf('map_crt|localhost') == -1 ) {
+                  errors.push(new Error("Missing 'map_crt|localhost' key in redis"));
+                }
               }
               redis_client.del(todrop, function(err) {
                 if ( err ) errors.push(err.message);
@@ -711,7 +649,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
               url: '/tiles/template?api_key=1234',
               method: 'POST',
               headers: {host: 'localhost', 'Content-Type': 'application/json' },
-              data: JSON.stringify(makeTemplate())
+              data: JSON.stringify(template_acceptance1)
           }
           assert.response(server, post_request, {},
             function(res) { next(null, res); });
@@ -740,7 +678,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           var parsed = JSON.parse(res.body);
           assert.ok(parsed.hasOwnProperty('template'),
             "Missing 'template' from response body: " + res.body);
-          assert.deepEqual(extendDefaultsTemplate(makeTemplate()), parsed.template);
+          assert.deepEqual(template_acceptance1, parsed.template);
           var del_request = {
               url: '/tiles/template/' + tpl_id,
               method: 'DELETE',
@@ -1023,10 +961,16 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           assert.response(server, get_request, {},
             function(res) { next(null, res); });
         },
-        function checkTileAvailable(err, res) {
+        function checkTileDeleted(err, res) {
           if ( err ) throw err;
-          assert.equal(res.statusCode, 200, 'Tile should be accessible');
-          assert.equal(res.headers['content-type'], "image/png");
+          assert.equal(res.statusCode, 403,
+            'Unexpected statusCode fetch tile after signature revokal: '
+            + res.statusCode + ':' + res.body); 
+          var parsed = JSON.parse(res.body);
+          assert.ok(parsed.hasOwnProperty('error'),
+            "Missing 'error' from response body: " + res.body);
+          assert.ok(parsed.error.match(/permission denied/i),
+            'Unexpected error for unauthorized access : ' + parsed.error);
           return null;
         },
         function finish(err) {
@@ -1177,37 +1121,12 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           assert.response(server, get_request, {},
             function(res) { next(null, res); });
         },
-        function checkTile_fetchOnRestart(err, res) {
+        function checkTile(err, res) {
           if ( err ) throw err;
           assert.equal(res.statusCode, 200, 
             'Unexpected error for authorized instance: '
             + res.statusCode + ' -- ' + res.body);
           assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
-          var cc = res.headers['x-cache-channel'];
-          assert.ok(cc);
-          assert.ok(cc.match, /ciao/, cc);
-          // hack simulating restart...
-          serverOptions = ServerOptions(); // need to clean channel cache
-          server = new CartodbWindshaft(serverOptions);
-          var get_request = {
-              url: '/tiles/layergroup/' + layergroupid + ':cb1/0/0/0/1.json.torque?auth_token=valid1',
-              method: 'GET',
-              headers: {host: 'localhost' },
-              encoding: 'binary'
-          }
-          var next = this;
-          assert.response(server, get_request, {},
-            function(res) { next(null, res); });
-        },
-        function checkCacheChannel(err, res) {
-          if ( err ) throw err;
-          assert.equal(res.statusCode, 200, 
-            'Unexpected error for authorized instance: '
-            + res.statusCode + ' -- ' + res.body);
-          assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
-          var cc = res.headers['x-cache-channel'];
-          assert.ok(cc, "Missing X-Cache-Channel on fetch-after-restart");
-          assert.ok(cc.match, /ciao/, cc);
           return null;
         },
         function deleteTemplate(err)
@@ -1236,10 +1155,16 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           assert.response(server, get_request, {},
             function(res) { next(null, res); });
         },
-        function checkTorqueTileAvailable(err, res) {
+        function checkTileDeleted(err, res) {
           if ( err ) throw err;
-          assert.equal(res.statusCode, 200, 'Torque tile should be accessible');
-          assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
+          assert.equal(res.statusCode, 403,
+            'Unexpected statusCode fetch tile after signature revokal: '
+            + res.statusCode + ':' + res.body); 
+          var parsed = JSON.parse(res.body);
+          assert.ok(parsed.hasOwnProperty('error'),
+            "Missing 'error' from response body: " + res.body);
+          assert.ok(parsed.error.match(/permission denied/i),
+            'Unexpected error for unauthorized access : ' + parsed.error);
           return null;
         },
         function finish(err) {
@@ -1426,10 +1351,16 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           assert.response(server, get_request, {},
             function(res) { next(null, res); });
         },
-        function checkLayerAttributesAvailable(err, res) {
+        function checkTileDeleted(err, res) {
           if ( err ) throw err;
-          assert.equal(res.statusCode, 200, 'Layer attributes should be accessible');
-          assert.equal(res.headers['content-type'], "application/json; charset=utf-8");
+          assert.equal(res.statusCode, 403, 
+            'Unexpected statusCode fetch tile after signature revokal: '
+            + res.statusCode + ':' + res.body); 
+          var parsed = JSON.parse(res.body);
+          assert.ok(parsed.hasOwnProperty('error'),
+            "Missing 'error' from response body: " + res.body);
+          assert.ok(parsed.error.match(/permission denied/i),
+            'Unexpected error for unauthorized access : ' + parsed.error);
           return null;
         },
         function finish(err) {
@@ -1590,8 +1521,7 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           if ( err ) throw err;
           assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
           // See https://github.com/CartoDB/Windshaft-cartodb/issues/176
-          helper.checkCache(res);
-          helper.checkSurrogateKey(res, new NamedMapsCacheEntry('localhost', template_acceptance_open.name).key());
+          helper.checkNoCache(res);
           return null;
         },
         function finish(err) {
@@ -1607,9 +1537,10 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           version: '0.0.1',
           name: 'acceptance_open_jsonp_params',
           auth: { method: 'open' },
+          /*
           placeholders: {
             color: { type: "css_color", default: "red" }
-          },
+          },*/
           layergroup:  {
             version: '1.0.0',
             layers: [
@@ -1662,11 +1593,9 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
         function checkInstanciation(err, res)
         {
           if ( err ) throw err;
-            console.log(err, res.body, res.headers);
           assert.equal(res.statusCode, 200, res.statusCode + ': ' + res.body);
           // See https://github.com/CartoDB/Windshaft-cartodb/issues/176
-          helper.checkCache(res);
-          helper.checkSurrogateKey(res, new NamedMapsCacheEntry('localhost', template_acceptance_open.name).key());
+          helper.checkNoCache(res);
           return null;
         },
         function finish(err) {
@@ -1848,7 +1777,6 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           assert.ok(parsed.hasOwnProperty('layergroupid'),
             "Missing 'layergroupid' from response body: " + res.body);
           layergroupid = parsed.layergroupid;
-          helper.checkSurrogateKey(res, new NamedMapsCacheEntry('localhost', template_acceptance2.name).key());
           return null;
         },
         function updateTemplate(err, res)
@@ -1893,7 +1821,6 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
           assert.ok(parsed.hasOwnProperty('layergroupid'),
             "Missing 'layergroupid' from response body: " + res.body);
           assert.ok(layergroupid != parsed.layergroupid);
-          helper.checkSurrogateKey(res, new NamedMapsCacheEntry('localhost', template_acceptance2.name).key());
           return null;
         },
         function finish(err) {
@@ -1904,12 +1831,15 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
                 if ( m.match(/^map_(tpl|crt)|/) )
                   return m;
               });
-              if ( todrop.length !== 1 ) {
+              if ( todrop.length != 2 ) {
                 errors.push(new Error("Unexpected keys in redis: " + todrop));
               } else {
                 if ( todrop.indexOf('map_tpl|localhost') == -1 ) {
                   errors.push(new Error("Missing 'map_tpl|localhost' key in redis"));
                 }
+                if ( todrop.indexOf('map_crt|localhost') == -1 ) {
+                  errors.push(new Error("Missing 'map_crt|localhost' key in redis"));
+                }
               }
               redis_client.del(todrop, function(err) {
                 if ( err ) errors.push(err.message);
@@ -1946,4 +1876,3 @@ suite('template_api:postgres=' + cdbQueryTablesFromPostgresEnabledValue, functio
     
 });
 
-});

test/support/SQLAPIEmu.js

@@ -2,7 +2,7 @@ var http        = require('http');
 var url         = require('url');
 var _ = require('underscore');
 
-var SQLAPIEmulator = function(port, cb) {
+var o = function(port, cb) {
 
   this.queries = [];
   var that = this;
@@ -37,45 +37,47 @@ var SQLAPIEmulator = function(port, cb) {
    }).listen(port, cb);
 };
 
-SQLAPIEmulator.prototype.handleQuery = function(query, res) {
+o.prototype.handleQuery = function(query, res) {
     this.queries.push(query);
     if ( query.q.match('SQLAPIERROR') ) {
       res.statusCode = 400;
       res.write(JSON.stringify({'error':'Some error occurred'}));
     } else if ( query.q.match('SQLAPINOANSWER') ) {
-        console.log("SQLAPIEmulator will never respond, on request");
-        return;
-    } else if (query.q.match('tablenames')) {
-        var tableNames = JSON.stringify(query);
-        res.write(queryResult({tablenames: '{' + tableNames + '}', max: 1234567890.123}));
+      console.log("SQLAPIEmulator will never respond, on request");
+      return;
     } else if ( query.q.match('EPOCH.* as max') ) {
       // This is the structure of the known query sent by tiler
-        res.write(queryResult({max: 1234567890.123}));
+      var row = {
+        'max': 1234567890.123
+      };
+      res.write(JSON.stringify({rows: [ row ]}));
     } else {
       if ( query.q.match('_private_') && query.api_key === undefined) {
         res.statusCode = 403;
         res.write(JSON.stringify({'error':'forbidden: ' + JSON.stringify(query)}));
       } else {
         var qs = JSON.stringify(query);
-        res.write(queryResult({cdb_querytables: '{' + qs + '}', max: 1234567890.123}));
+        var row = {
+          // This is the structure of the known query sent by tiler
+          'cdb_querytables': '{' + qs + '}',
+          'max': qs
+        };
+        var out_obj = {rows: [ row ]};
+        var out = JSON.stringify(out_obj);
+        res.write(out);
       }
     }
     res.end();
   };
 
-SQLAPIEmulator.prototype.close = function(cb) {
+
+o.prototype.close = function(cb) {
   this.sqlapi_server.close(cb);
 };
 
-SQLAPIEmulator.prototype.getLastRequest = function() {
+o.prototype.getLastRequest = function() {
   return this.requests.pop();
 };
 
-function queryResult(row) {
-    return JSON.stringify({
-        rows: [row]
-    });
-}
-
-module.exports = SQLAPIEmulator;
+module.exports = o;
 

test/support/assert.js

@@ -1,11 +1,10 @@
 // Cribbed from the ever prolific Konstantin Kaefer
 // https://github.com/mapbox/tilelive-mapnik/blob/master/test/support/assert.js
 
-var exec = require('child_process').exec,
-    fs = require('fs'),
-    http = require('http'),
-    path = require('path'),
-    util = require('util');
+var fs = require('fs');
+var http = require('http');
+var path = require('path');
+var exec = require('child_process').exec;
 
 var assert = module.exports = exports = require('assert');
 
@@ -67,51 +66,35 @@ assert.utfgridEqualsFile = function(buffer, file_b, tolerance, callback) {
     callback(err);
 };
 
-/**
- * Takes an image data as an input and an image path and compare them using ImageMagick fuzz algorithm, if case the
- * similarity is not within the tolerance limit it will callback with an error.
- *
- * @param buffer The image data to compare from
- * @param {string} referenceImageRelativeFilePath The relative file to compare against
- * @param {number} tolerance tolerated mean color distance, as a per mil (‰)
- * @param {function} callback Will call to home with null in case there is no error, otherwise with the error itself
- * @see FUZZY in http://www.imagemagick.org/script/command-line-options.php#metric
- */
-assert.imageEqualsFile = function(buffer, referenceImageRelativeFilePath, tolerance, callback) {
+//
+// @param tol tolerated color distance as a percent over max channel value
+//            by default this is zero. For meaningful values, see
+//            http://www.imagemagick.org/script/command-line-options.php#metric
+//
+assert.imageEqualsFile = function(buffer, file_b, tol, callback) {
     if (!callback) callback = function(err) { if (err) throw err; };
-    var referenceImageFilePath = path.resolve(referenceImageRelativeFilePath),
-        testImageFilePath = '/tmp/windshaft-test-image-' + (Math.random() * 1e16); // TODO: make predictable
-    var err = fs.writeFileSync(testImageFilePath, buffer, 'binary');
+    file_b = path.resolve(file_b);
+    var file_a = '/tmp/windshaft-test-image-test.png'; // + (Math.random() * 1e16); // TODO: make predictable 
+    var err = fs.writeFileSync(file_a, buffer, 'binary');
     if (err) throw err;
 
-    var imageMagickCmd = util.format(
-        'compare -metric fuzz "%s" "%s" /dev/null',
-        testImageFilePath, referenceImageFilePath
-    );
-
-    exec(imageMagickCmd, function(err, stdout, stderr) {
+    var fuzz = tol + '%';
+    exec('compare -fuzz ' + fuzz + ' -metric AE "' + file_a + '" "' +
+            file_b + '" /dev/null', function(err, stdout, stderr) {
         if (err) {
-            fs.unlinkSync(testImageFilePath);
+            fs.unlinkSync(file_a);
             callback(err);
         } else {
             stderr = stderr.trim();
-            var metrics = stderr.match(/([0-9]*) \((.*)\)/);
-            if ( ! metrics ) {
-                callback(new Error("No match for " + stderr));
-                return;
-            }
-            var similarity = parseFloat(metrics[2]),
-                tolerancePerMil = (tolerance / 1000);
-            if (similarity > tolerancePerMil) {
-                err = new Error(util.format(
-                        'Images %s and %s are not equal (got %d similarity, expected %d)',
-                        testImageFilePath, referenceImageFilePath, similarity, tolerancePerMil)
-                );
-                err.similarity = similarity;
-                callback(err);
+            var similarity = parseFloat(stderr);
+            if ( similarity > 0 ) {
+              var err = new Error('Images not equal(' + similarity + '): ' +
+                      file_a  + '    ' + file_b);
+              err.similarity = similarity;
+              callback(err);
             } else {
-                fs.unlinkSync(testImageFilePath);
-                callback(null);
+              fs.unlinkSync(file_a);
+              callback(null);
             }
         }
     });
@@ -226,8 +209,6 @@ assert.response = function(server, req, res, msg){
             response.on('end', function(){
                 if (timer) clearTimeout(timer);
 
-                check();
-
                 // Assert response body
                 if (res.body !== undefined) {
                     var eql = res.body instanceof RegExp
@@ -273,6 +254,7 @@ assert.response = function(server, req, res, msg){
 
                 // Callback
                 callback(response);
+                check();
             });
         });
 

test/support/prepare_db.sh

@@ -76,7 +76,7 @@ if test x"$PREPARE_PGSQL" = xyes; then
     sed "s/:PUBLICPASS/${PUBLICPASS}/" | 
     sed "s/:TESTUSER/${TESTUSER}/" | 
     sed "s/:TESTPASS/${TESTPASS}/" | 
-    psql -v ON_ERROR_STOP=1 ${TEST_DB} || exit 1
+    psql ${TEST_DB}
 
 fi
 
@@ -86,8 +86,7 @@ if test x"$PREPARE_REDIS" = xyes; then
 
   cat <<EOF | redis-cli -p ${REDIS_PORT} -n 5
 HMSET rails:users:localhost id ${TESTUSERID} \
-                            database_name "${TEST_DB}" \
-                            database_host localhost \
+                            database_name '${TEST_DB}' \
                             map_key 1234
 SADD rails:users:localhost:map_key 1235
 EOF

test/support/test_helper.js

@@ -7,18 +7,18 @@
 
 var _ = require('underscore');
 var assert = require('assert');
-var LZMA  = require('lzma').LZMA;
-
-var lzmaWorker = new LZMA();
+var LZMA  = require('lzma/lzma_worker.js').LZMA;
 
 // set environment specific variables
+global.settings     = require(__dirname + '/../../config/settings');
 global.environment  = require(__dirname + '/../../config/environments/test');
+_.extend(global.settings, global.environment);
 process.env.NODE_ENV = 'test';
 
 
 // Utility function to compress & encode LZMA
 function lzma_compress_to_base64(payload, mode, callback) {
-  lzmaWorker.compress(payload, mode,
+  LZMA.compress(payload, mode, 
     function(ints) {
       ints = ints.map(function(c) { return String.fromCharCode(c + 128) }).join('')
       var base64 = new Buffer(ints, 'binary').toString('base64');
@@ -39,27 +39,8 @@ function checkNoCache(res) {
 }
 
 
-/**
- * Check that the response headers do not request caching
- * @see checkNoCache
- * @param res
- */
-function checkCache(res) {
-    assert.ok(res.headers.hasOwnProperty('x-cache-channel'));
-    assert.ok(res.headers.hasOwnProperty('cache-control'));
-    assert.ok(res.headers.hasOwnProperty('last-modified'));
-}
-
-function checkSurrogateKey(res, expectedKey) {
-    assert.ok(res.headers.hasOwnProperty('surrogate-key'));
-    assert.equal(res.headers['surrogate-key'], expectedKey);
-}
-
-
 module.exports = {
   lzma_compress_to_base64: lzma_compress_to_base64,
-  checkNoCache: checkNoCache,
-  checkSurrogateKey: checkSurrogateKey,
-  checkCache: checkCache
-};
+  checkNoCache: checkNoCache
+}
 

test/unit/cartodb/cache/model/named_maps_entry.test.js

@@ -1,29 +0,0 @@
-var assert = require('assert');
-var _ = require('underscore');
-var NamedMapsCacheEntry = require('../../../../../lib/cartodb/cache/model/named_maps_entry');
-
-suite('cache named_maps_entry', function() {
-
-    var namedMapOwner = 'foo',
-        namedMapName = 'wadus_name',
-        namedMapsCacheEntry = new NamedMapsCacheEntry(namedMapOwner, namedMapName),
-        entryKey = namedMapsCacheEntry.key();
-
-    test('key is a string', function() {
-        assert.ok(_.isString(entryKey));
-    });
-
-    test('key is 8 chars length', function() {
-        assert.equal(entryKey.length, 8);
-        var entryKeyParts = entryKey.split(':');
-        assert.equal(entryKeyParts.length, 2);
-        assert.equal(entryKeyParts[0], 'n');
-    });
-
-    test('key is name spaced for named maps', function() {
-        var entryKeyParts = entryKey.split(':');
-        assert.equal(entryKeyParts.length, 2);
-        assert.equal(entryKeyParts[0], 'n');
-    });
-
-});

test/unit/cartodb/signed_maps.test.js

@@ -0,0 +1,109 @@
+var assert = require('assert')
+  //, _ = require('underscore')
+  , RedisPool = require('redis-mpool')
+  , SignedMaps = require('../../../lib/cartodb/signed_maps.js')
+  , test_helper = require('../../support/test_helper')
+  , Step = require('step')
+  , tests = module.exports = {};
+
+suite('signed_maps', function() {
+
+    // configure redis pool instance to use in tests
+    var redis_pool = RedisPool(global.environment.redis);
+    
+    test('can sign map with open and token-based auth', function(done) {
+      var smap = new SignedMaps(redis_pool);
+      assert.ok(smap);
+      var sig = 'sig1';
+      var map = 'map1';
+      var tok = 'tok1';
+      var crt = {
+        version:'0.0.1',
+        layergroup_id:map,
+        auth: {}
+      };
+      var crt1_id; // by token
+      var crt2_id; // open
+      Step(
+        function() {
+          smap.isAuthorized(sig,map,tok,this);
+        },
+        function checkAuthFailure1(err, authorized) {
+          if ( err ) throw err;
+          assert.ok(!authorized, "unexpectedly authorized");
+          crt.auth.method = 'token';
+          crt.auth.valid_tokens = [tok];
+          smap.addSignature(sig, map, crt, this)
+        },
+        function getCert1(err, id) {
+          if ( err ) throw err;
+          assert.ok(id, "undefined signature id");
+          crt1_id = id; // keep note of it
+//console.log("Certificate 1 is " + crt1_id);
+          smap.isAuthorized(sig,map,'',this);
+        },
+        function checkAuthFailure2(err, authorized) {
+          if ( err ) throw err;
+          assert.ok(!authorized, "unexpectedly authorized");
+          smap.isAuthorized(sig,map,tok,this);
+        },
+        function checkAuthSuccess1(err, authorized) {
+          if ( err ) throw err;
+          assert.ok(authorized, "unauthorized :(");
+          crt.auth.method = 'open';
+          delete crt.auth.valid_tokens;
+          smap.addSignature(sig, map, crt, this)
+        },
+        function getCert2(err, id) {
+          if ( err ) throw err;
+          assert.ok(id, "undefined signature id");
+          crt2_id = id; // keep note of it
+//console.log("Certificate 2 is " + crt2_id);
+          smap.isAuthorized(sig,map,'arbitrary',this);
+        },
+        function checkAuthSuccess2_delCert2(err, authorized) {
+          if ( err ) throw err;
+          assert.ok(authorized, "unauthorized :(");
+          var next = this;
+          smap.delCertificate(sig, crt2_id, function(e) {
+            if (e) next(e);
+            else smap.isAuthorized(sig,map,'arbitrary',next);
+          });
+        },
+        function checkAuthFailure3_delCert2(err, authorized) {
+          if ( err ) throw err;
+          assert.ok(!authorized, "unexpectedly authorized");
+          smap.delCertificate(sig, crt1_id, this);
+        },
+        function finish(err) {
+          done(err);
+        }
+      );
+    });
+
+    test('can validate certificates', function(done) {
+      var smap = new SignedMaps(redis_pool);
+      assert.ok(smap);
+      Step(
+        function invalidVersion() {
+          var cert = { version: '-1' };
+          var err = smap.checkInvalidCertificate(cert);
+          assert.ok(err);
+          assert.equal(err.message, "Unsupported certificate version -1");
+          return null;
+        },
+        function invalidTokenAuth() {
+          var cert = { version: '0.0.1', auth: { method:'token', valid_token:[] } };
+          var err = smap.checkInvalidCertificate(cert);
+          assert.ok(err);
+          assert.equal(err.message, "Invalid 'token' authentication: missing valid_tokens");
+          return null;
+        },
+        function finish(err) {
+          done(err);
+        }
+      );
+    });
+
+    
+});

test/unit/cartodb/template_maps.test.js

@@ -1,42 +1,23 @@
 var assert = require('assert')
   //, _ = require('underscore')
   , RedisPool = require('redis-mpool')
+  , SignedMaps = require('../../../lib/cartodb/signed_maps.js')
   , TemplateMaps = require('../../../lib/cartodb/template_maps.js')
   , test_helper = require('../../support/test_helper')
   , Step = require('step')
-  , _ = require('underscore')
   , tests = module.exports = {};
 
 suite('template_maps', function() {
 
   // configure redis pool instance to use in tests
   var redis_pool = RedisPool(global.environment.redis);
-
-    var wadusLayer = {
-        options: {
-            sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-            cartocss: '#layer { marker-fill:blue; }',
-            cartocss_version: '2.3.0'
-        }
-    };
-
-    var validTemplate = {
-        version:'0.0.1',
-        name: 'first',
-        auth: {},
-        layergroup: {
-            layers: [
-                wadusLayer
-            ]
-        }
-    };
-    var owner = 'me';
+  var signed_maps = new SignedMaps(redis_pool);
     
   test('does not accept template with unsupported version', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var tpl = { version:'6.6.6',
-      name:'k', auth: {}, layergroup: {layers:[wadusLayer]} };
+      name:'k', auth: {}, layergroup: {} };
     Step(
       function() {
         tmap.addTemplate('me', tpl, this);
@@ -53,10 +34,10 @@ suite('template_maps', function() {
   });
 
   test('does not accept template with missing name', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var tpl = { version:'0.0.1',
-      auth: {}, layergroup: {layers:[wadusLayer]} };
+      auth: {}, layergroup: {} };
     Step(
       function() {
         tmap.addTemplate('me', tpl, this);
@@ -73,10 +54,10 @@ suite('template_maps', function() {
   });
 
   test('does not accept template with invalid name', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var tpl = { version:'0.0.1',
-      auth: {}, layergroup: {layers:[wadusLayer]} };
+      auth: {}, layergroup: {} };
     var invalidnames = [ "ab|", "a b", "a@b", "1ab", "_x", "", " x", "x " ];
     var testNext = function() {
       if ( ! invalidnames.length ) { done(); return; }
@@ -99,11 +80,11 @@ suite('template_maps', function() {
   });
 
   test('does not accept template with invalid placeholder name', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var tpl = { version:'0.0.1',
       name: "valid", placeholders: {},
-      auth: {}, layergroup: {layers:[wadusLayer]} };
+      auth: {}, layergroup: {} };
     var invalidnames = [ "ab|", "a b", "a@b", "1ab", "_x", "", " x", "x " ];
     var testNext = function() {
       if ( ! invalidnames.length ) { done(); return; }
@@ -127,11 +108,11 @@ suite('template_maps', function() {
   });
 
   test('does not accept template with missing placeholder default', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var tpl = { version:'0.0.1',
       name: "valid", placeholders: { v: {} },
-      auth: {}, layergroup: {layers:[wadusLayer]} };
+      auth: {}, layergroup: {} };
     tmap.addTemplate('me', tpl, function(err) {
         if ( ! err ) {
           done(new Error("Unexpected success with missing placeholder default"));
@@ -147,11 +128,11 @@ suite('template_maps', function() {
   });
 
   test('does not accept template with missing placeholder type', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var tpl = { version:'0.0.1',
       name: "valid", placeholders: { v: { default:1 } },
-      auth: {}, layergroup: {layers:[wadusLayer]} };
+      auth: {}, layergroup: {} };
     tmap.addTemplate('me', tpl, function(err) {
         if ( ! err ) {
           done(new Error("Unexpected success with missing placeholder type"));
@@ -169,11 +150,11 @@ suite('template_maps', function() {
   // See http://github.com/CartoDB/Windshaft-cartodb/issues/128
   test('does not accept template with invalid token auth (undefined tokens)',
   function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var tpl = { version:'0.0.1',
       name: "invalid_auth1", placeholders: { },
-      auth: { method: 'token' }, layergroup: {layers:[wadusLayer]} };
+      auth: { method: 'token' }, layergroup: {} };
     tmap.addTemplate('me', tpl, function(err) {
         if ( ! err ) {
           done(new Error("Unexpected success with invalid token auth (undefined tokens)"));
@@ -189,12 +170,12 @@ suite('template_maps', function() {
   });
 
   test('add, get and delete a valid template', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var expected_failure = false;
     var tpl_id;
     var tpl = { version:'0.0.1',
-      name: 'first', auth: {}, layergroup: {layers:[wadusLayer]} };
+      name: 'first', auth: {}, layergroup: {} };
     Step(
       function() {
         tmap.addTemplate('me', tpl, this);
@@ -215,7 +196,7 @@ suite('template_maps', function() {
       },
       function delTemplate(err, got_tpl) {
         if ( err ) throw err;
-        assert.deepEqual(got_tpl, _.extend({}, tpl, {auth: {method: 'open'}, placeholders: {}}));
+        assert.deepEqual(got_tpl, tpl);
         tmap.delTemplate('me', tpl_id, this);
       },
       function finish(err) {
@@ -225,12 +206,12 @@ suite('template_maps', function() {
   });
 
   test('add multiple templates, list them', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var expected_failure = false;
-    var tpl1 = { version:'0.0.1', name: 'first', auth: {}, layergroup: {layers:[wadusLayer]} };
+    var tpl1 = { version:'0.0.1', name: 'first', auth: {}, layergroup: {} };
     var tpl1_id;
-    var tpl2 = { version:'0.0.1', name: 'second', auth: {}, layergroup: {layers:[wadusLayer]} };
+    var tpl2 = { version:'0.0.1', name: 'second', auth: {}, layergroup: {} };
     var tpl2_id;
     Step(
       function addTemplate1() {
@@ -284,14 +265,14 @@ suite('template_maps', function() {
   });
 
   test('update templates', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
     var expected_failure = false;
     var owner = 'me';
     var tpl = { version:'0.0.1',
       name: 'first',
       auth: { method: 'open' },
-      layergroup: {layers:[wadusLayer]}
+      layergroup: {}
     };
     var tpl_id;
     Step(
@@ -344,7 +325,7 @@ suite('template_maps', function() {
   });
 
   test('instanciate templates', function() {
-    var tmap = new TemplateMaps(redis_pool);
+    var tmap = new TemplateMaps(redis_pool, signed_maps);
     assert.ok(tmap);
 
     var tpl1 =  {
@@ -442,11 +423,11 @@ suite('template_maps', function() {
 
   // Can set a limit on the number of user templates
   test('can limit number of user templates', function(done) {
-    var tmap = new TemplateMaps(redis_pool, {
+    var tmap = new TemplateMaps(redis_pool, signed_maps, {
       max_user_templates: 2
     });
     assert.ok(tmap);
-    var tpl = { version:'0.0.1', auth: {}, layergroup: {layers:[wadusLayer]} };
+    var tpl = { version:'0.0.1', auth: {}, layergroup: {} };
     var expectErr = false;
     var idMe = [];
     var idYou = [];
@@ -521,5 +502,5 @@ suite('template_maps', function() {
       }
     );
   });
-
+    
 });

test/unit/cartodb/template_maps_auth.test.js

@@ -1,105 +0,0 @@
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../../lib/cartodb/template_maps');
-var test_helper = require('../../support/test_helper');
-var Step = require('step');
-var tests = module.exports = {};
-
-suite('template_maps_auth', function() {
-
-    // configure redis pool instance to use in tests
-    var redisPool = new RedisPool(global.environment.redis),
-        templateMaps = new TemplateMaps(redisPool, {max_user_templates: 1000});
-
-    function makeTemplate(method, validTokens) {
-        var template = {
-            name: 'wadus_template',
-            auth: {
-                method: method
-            }
-        };
-
-        if (method === 'token') {
-            template.auth.valid_tokens = validTokens || [];
-        }
-
-        return template;
-    }
-
-    var methodToken = 'token',
-        methodOpen = 'open';
-
-    var tokenFoo = 'foo',
-        tokenBar = 'bar';
-
-    var authorizationTestScenarios = [
-        {
-            desc: 'open method is always authorized',
-            template: makeTemplate(methodOpen),
-            token: undefined,
-            expected: true
-        },
-        {
-            desc: 'token method is authorized for valid token',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: tokenFoo,
-            expected: true
-        },
-        {
-            desc: 'token method not authorized for invalid token',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: tokenBar,
-            expected: false
-        },
-        {
-            desc: 'token method is authorized for valid token array',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: [tokenFoo],
-            expected: true
-        },
-        {
-            desc: 'token method not authorized for invalid token array',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: [tokenBar],
-            expected: false
-        },
-        {
-            desc: 'wadus method not authorized',
-            template: makeTemplate('wadus', [tokenFoo]),
-            token: tokenFoo,
-            expected: false
-        },
-        {
-            desc: 'undefined template result in not authorized',
-            template: undefined,
-            token: tokenFoo,
-            expected: false
-        },
-        {
-            desc: 'undefined template auth result in not authorized',
-            template: {},
-            token: tokenFoo,
-            expected: false
-        }
-    ];
-
-    authorizationTestScenarios.forEach(function(testScenario) {
-        test(testScenario.desc, function(done) {
-            var debugMessage = testScenario.expected ? 'should be authorized' : 'unexpectedly authorized';
-            var result = templateMaps.isAuthorized(testScenario.template, testScenario.token);
-            assert.equal(result, testScenario.expected, debugMessage);
-            done();
-        })
-    });
-
-    test("auth as 'open' string is authorized", function(done) {
-        var template = {
-            name: 'wadus_template',
-            auth: 'open'
-        };
-
-        assert.ok(templateMaps.isAuthorized(template));
-        done();
-    });
-
-});

test/unit/cartodb/template_maps_defaults.test.js

@@ -1,106 +0,0 @@
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../../lib/cartodb/template_maps.js');
-var test_helper = require('../../support/test_helper');
-var _ = require('underscore');
-
-suite('template_maps', function() {
-
-    var redisPool = new RedisPool(global.environment.redis),
-        templateMaps = new TemplateMaps(redisPool);
-
-    var owner = 'me';
-    var templateName = 'wadus';
-
-
-    var defaultTemplate = {
-        version:'0.0.1',
-        name: templateName,
-        layergroup: {
-            layers: [
-                {
-                    options: {
-                        sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-                        cartocss: '#layer { marker-fill:blue; }',
-                        cartocss_version: '2.3.0'
-                    }
-                }
-            ]
-        }
-    };
-
-    function makeTemplate(auth, placeholders) {
-        return _.extend({}, defaultTemplate, {
-            auth: auth,
-            placeholders: placeholders
-        });
-    }
-
-    var defaultAuth = {
-        method: 'open'
-    };
-
-    var authTokenSample = {
-        method: 'token',
-        valid_tokens: ['wadus_token']
-    };
-
-    var placeholdersSample = {
-        wadus: {
-            type: 'number',
-            default: 1
-        }
-    };
-
-    var testScenarios = [
-        {
-            desc: 'default auth and placeholders values',
-            template: defaultTemplate,
-            expected: {
-                auth: defaultAuth,
-                placeholders: {}
-            }
-        },
-        {
-            desc: 'default placeholders but specified auth',
-            template: makeTemplate(authTokenSample),
-            expected: {
-                auth: authTokenSample,
-                placeholders: {}
-            }
-        },
-        {
-            desc: 'default auth but specified placeholders',
-            template: makeTemplate(undefined, placeholdersSample),
-            expected: {
-                auth: defaultAuth,
-                placeholders: placeholdersSample
-            }
-        },
-        {
-            desc: 'specified auth and placeholders',
-            template: makeTemplate(authTokenSample, placeholdersSample),
-            expected: {
-                auth: authTokenSample,
-                placeholders: placeholdersSample
-            }
-        }
-    ];
-
-    testScenarios.forEach(function(testScenario) {
-        test('adding template returns a new instance with ' + testScenario.desc, function(done) {
-
-            templateMaps.addTemplate(owner, testScenario.template, function(err, templateId, template) {
-                assert.ok(!err, 'Unexpected error adding template: ' + (err && err.message));
-                assert.ok(testScenario.template !== template, 'template instances should be different');
-                assert.equal(template.name, templateName);
-                assert.deepEqual(template.auth, testScenario.expected.auth);
-                assert.deepEqual(template.placeholders, testScenario.expected.placeholders);
-
-                templateMaps.delTemplate(owner, templateName, done);
-            });
-
-        });
-    });
-
-});

test/unit/cartodb/valid_template_maps.test.js

@@ -1,112 +0,0 @@
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../../lib/cartodb/template_maps.js');
-var test_helper = require('../../support/test_helper');
-var _ = require('underscore');
-
-suite('template_maps', function() {
-
-    var redisPool = new RedisPool(global.environment.redis),
-        templateMaps = new TemplateMaps(redisPool);
-
-    var owner = 'me';
-    var templateName = 'wadus';
-
-
-    var defaultTemplate = {
-        version:'0.0.1',
-        name: templateName
-    };
-
-    function makeTemplate(layers) {
-        var layergroup = {
-            layers: layers
-        };
-        return _.extend({}, defaultTemplate, {
-            layergroup: layergroup
-        });
-    }
-
-    var layerWithMissingOptions = {},
-        minimumValidLayer = {
-            options: {
-                sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-                cartocss: '#layer { marker-fill:blue; }',
-                cartocss_version: '2.3.0'
-            }
-        };
-
-    var testScenarios = [
-        {
-            desc: 'Missing layers array does not validate',
-            template: makeTemplate(),
-            expected: {
-                isValid: false,
-                message: 'Missing or empty layers array from layergroup config'
-            }
-        },
-        {
-            desc: 'Empty layers array does not validate',
-            template: makeTemplate([]),
-            expected: {
-                isValid: false,
-                message: 'Missing or empty layers array from layergroup config'
-            }
-        },
-        {
-            desc: 'Layer with missing options does not validate',
-            template: makeTemplate([
-                layerWithMissingOptions
-            ]),
-            expected: {
-                isValid: false,
-                message: 'Missing `options` in layergroup config for layers: 0'
-            }
-        },
-        {
-            desc: 'Multiple layers report invalid layer',
-            template: makeTemplate([
-                minimumValidLayer,
-                layerWithMissingOptions
-            ]),
-            expected: {
-                isValid: false,
-                message: 'Missing `options` in layergroup config for layers: 1'
-            }
-        },
-        {
-            desc: 'default auth but specified placeholders',
-            template: makeTemplate([
-                minimumValidLayer
-            ]),
-            expected: {
-                isValid: true,
-                message: ''
-            }
-        }
-    ];
-
-    testScenarios.forEach(function(testScenario) {
-        test(testScenario.desc, function(done) {
-
-            templateMaps.addTemplate(owner, testScenario.template, function(err) {
-
-                if (testScenario.expected.isValid) {
-
-                    assert.ok(!err);
-                    templateMaps.delTemplate(owner, templateName, done);
-
-                } else {
-
-                    assert.ok(err);
-                    assert.equal(err.message, testScenario.expected.message);
-                    done();
-
-                }
-
-            });
-
-        });
-    });
-
-});

tools/examples/mapconfig_slow.js

@@ -1,11 +0,0 @@
-{"version":"1.0.1",
-	"layers":[{
-    "type":"cartodb",
-	  "options":{
-      "sql":"select 1 as id, ST_Transform(ST_SetSRID(ST_MakePoint(x/1000,x/2000),4326),3857) as the_geom_webmercator FROM generate_series(-170000,170000) x",
-	    "cartocss":"#style{ marker-width: 12;}",
-	    "cartocss_version":"2.1.1",
-      "Interactivity":"id"
-    }
-  }]
-}

tools/show_style

@@ -38,8 +38,7 @@ if ( ! username ) usage(me, 1);
 console.log("Using environment " + ENV);
 
 global.environment = require('../config/environments/' + ENV);
-// _after_ setting global.environment
-var serverOptions = require('../lib/cartodb/server_options')();
+var serverOptions = require('../lib/cartodb/server_options'); // _after_ setting global.environment
 
 var client;
 var dbname;