Release 1.3.6, fixing support for node-0.8.9

Requires windshaft 0.13.7
Jira ref CDB-414

.gitignore

@@ -1,11 +1,6 @@
 node_modules*
-config.status*
 config/environments/*.js
 .idea
 tools/munin/windshaft.conf
 logs/
 pids/
-redis.pid
-test.log
-npm-debug.log
-coverage/

.jshintignore

@@ -1,4 +0,0 @@
-test/results/
-test/monkey/
-test/benchmark.js
-test/support/

.jshintrc

@@ -1,98 +0,0 @@
-{
-//    // JSHint Default Configuration File (as on JSHint website)
-//    // See http://jshint.com/docs/ for more details
-//
-//    "maxerr"        : 50,       // {int} Maximum error before stopping
-//
-//    // Enforcing
-//    "bitwise"       : true,     // true: Prohibit bitwise operators (&, |, ^, etc.)
-//    "camelcase"     : false,    // true: Identifiers must be in camelCase
-//    "curly"         : true,     // true: Require {} for every new block or scope
-//    "eqeqeq"        : true,     // true: Require triple equals (===) for comparison
-    "forin"         : true,     // true: Require filtering for..in loops with obj.hasOwnProperty()
-    "freeze"        : true,     // true: prohibits overwriting prototypes of native objects such as Array, Date etc.
-    "immed"         : true,    // true: Require immediate invocations to be wrapped in parens e.g. `(function () { } ());`
-//    "indent"        : 4,        // {int} Number of spaces to use for indentation
-//    "latedef"       : false,    // true: Require variables/functions to be defined before being used
-    "newcap"        : true,    // true: Require capitalization of all constructor functions e.g. `new F()`
-    "noarg"         : true,     // true: Prohibit use of `arguments.caller` and `arguments.callee`
-//    "noempty"       : true,     // true: Prohibit use of empty blocks
-    "nonbsp"        : true,     // true: Prohibit "non-breaking whitespace" characters.
-    "nonew"         : true,    // true: Prohibit use of constructors for side-effects (without assignment)
-//    "plusplus"      : false,    // true: Prohibit use of `++` & `--`
-//    "quotmark"      : false,    // Quotation mark consistency:
-//    //   false    : do nothing (default)
-//    //   true     : ensure whatever is used is consistent
-//    //   "single" : require single quotes
-//    //   "double" : require double quotes
-    "undef"         : true,     // true: Require all non-global variables to be declared (prevents global leaks)
-    "unused"        : true,     // true: Require all defined variables be used
-//    "strict"        : true,     // true: Requires all functions run in ES5 Strict Mode
-//    "maxparams"     : false,    // {int} Max number of formal params allowed per function
-//    "maxdepth"      : false,    // {int} Max depth of nested blocks (within functions)
-//    "maxstatements" : false,    // {int} Max number statements per function
-    "maxcomplexity" : 8,    // {int} Max cyclomatic complexity per function
-    "maxlen"        : 120,    // {int} Max number of characters per line
-//
-//    // Relaxing
-//    "asi"           : false,     // true: Tolerate Automatic Semicolon Insertion (no semicolons)
-//    "boss"          : false,     // true: Tolerate assignments where comparisons would be expected
-    "debug"         : false,     // true: Allow debugger statements e.g. browser breakpoints.
-//    "eqnull"        : false,     // true: Tolerate use of `== null`
-//    "es5"           : false,     // true: Allow ES5 syntax (ex: getters and setters)
-//    "esnext"        : false,     // true: Allow ES.next (ES6) syntax (ex: `const`)
-//    "moz"           : false,     // true: Allow Mozilla specific syntax (extends and overrides esnext features)
-//    // (ex: `for each`, multiple try/catch, function expression…)
-//    "evil"          : false,     // true: Tolerate use of `eval` and `new Function()`
-//    "expr"          : false,     // true: Tolerate `ExpressionStatement` as Programs
-//    "funcscope"     : false,     // true: Tolerate defining variables inside control statements
-//    "globalstrict"  : false,     // true: Allow global "use strict" (also enables 'strict')
-//    "iterator"      : false,     // true: Tolerate using the `__iterator__` property
-//    "lastsemic"     : false,     // true: Tolerate omitting a semicolon for the last statement of a 1-line block
-//    "laxbreak"      : false,     // true: Tolerate possibly unsafe line breakings
-//    "laxcomma"      : false,     // true: Tolerate comma-first style coding
-//    "loopfunc"      : false,     // true: Tolerate functions being defined in loops
-//    "multistr"      : false,     // true: Tolerate multi-line strings
-//    "noyield"       : false,     // true: Tolerate generator functions with no yield statement in them.
-//    "notypeof"      : false,     // true: Tolerate invalid typeof operator values
-//    "proto"         : false,     // true: Tolerate using the `__proto__` property
-//    "scripturl"     : false,     // true: Tolerate script-targeted URLs
-//    "shadow"        : false,     // true: Allows re-define variables later in code e.g. `var x=1; x=2;`
-//    "sub"           : false,     // true: Tolerate using `[]` notation when it can still be expressed in dot notation
-//    "supernew"      : false,     // true: Tolerate `new function () { ... };` and `new Object;`
-//    "validthis"     : false,     // true: Tolerate using this in a non-constructor function
-//
-//    // Environments
-//    "browser"       : true,     // Web Browser (window, document, etc)
-//    "browserify"    : false,    // Browserify (node.js code in the browser)
-//    "couch"         : false,    // CouchDB
-//    "devel"         : true,     // Development/debugging (alert, confirm, etc)
-//    "dojo"          : false,    // Dojo Toolkit
-//    "jasmine"       : false,    // Jasmine
-//    "jquery"        : false,    // jQuery
-//    "mocha"         : true,     // Mocha
-//    "mootools"      : false,    // MooTools
-    "node"          : true,    // Node.js
-//    "nonstandard"   : false,    // Widely adopted globals (escape, unescape, etc)
-//    "prototypejs"   : false,    // Prototype and Scriptaculous
-//    "qunit"         : false,    // QUnit
-//    "rhino"         : false,    // Rhino
-//    "shelljs"       : false,    // ShellJS
-//    "worker"        : false,    // Web Workers
-//    "wsh"           : false,    // Windows Scripting Host
-//    "yui"           : false,    // Yahoo User Interface
-
-    // Custom Globals
-    "globals"       : { // additional predefined global variables
-        "describe": true,
-        "before": true,
-        "after": true,
-        "beforeEach": true,
-        "afterEach": true,
-        "it": true,
-        "suite": true,
-        "suiteSetup": true,
-        "test": true,
-        "suiteTeardown": true
-    }
-}

.travis.yml

@@ -1,22 +1,14 @@
-addons:
-  postgresql: "9.3"
-
 before_install:
-  - sudo apt-get update
-  - sudo apt-get install -y pkg-config libcairo2-dev libjpeg8-dev libgif-dev
-  - sudo apt-get install postgresql-plpython-9.3
+  - sudo apt-add-repository --yes ppa:mapnik/v2.1.0
+  - sudo apt-add-repository --yes ppa:ubuntugis/ppa
+  - sudo apt-get update -q
+  - sudo apt-get install -q libmapnik libmapnik-dev postgresql-9.1-postgis libsigc++-dev
   - createdb template_postgis
   - psql -c "CREATE EXTENSION postgis" template_postgis
 
 env:
-  - NPROCS=1 JOBS=1 PGUSER=postgres
+  - NPROCS=1 JOBS=1
 
 language: node_js
 node_js:
-  - "0.10"
-
-notifications:
-  irc:
-    channels:
-      - "irc.freenode.org#cartodb"
-    use_notice: true
+  - "0.8"

HOWTO_RELEASE

@@ -1,20 +1,11 @@
-1. Test (make clean all check), fix if broken before proceeding
-2. Ensure proper version in package.json 
-3. Ensure NEWS section exists for the new version, review it, add release date
-4. Drop npm-shrinkwrap.json
-5. Run npm shrinkwrap to recreate npm-shrinkwrap.json
-6. Commit package.json, npm-shrinwrap.json, NEWS
-7. git tag -a Major.Minor.Patch # use NEWS section as content
-8. Announce on cartodb@googlegroups.com
-9. Stub NEWS/package for next version
+1. Ensure proper version in package.json 
+2. Ensure NEWS section exists for the new version, review it, add release date
+3. Drop npm-shrinkwrap.json
+4. Run npm install
+5. Test (make check or npm test), fix if broken before proceeding
+6. Run npm shrinkwrap
+7. Commit package.json, npm-shrinwrap.json, NEWS
+8. Tag Major.Minor.Patch
+9. Announce
+10. Stub NEWS/package for next version
 
-Versions:
-
-Bugfix releases increment Patch component of version.
-Feature releases increment Minor and set Patch to zero.
-If backward compatibility is broken, increment Major and
-set to zero Minor and Patch.
-
-Branches named 'b<Major>.<Minor>' are kept for any critical
-fix that might need to be shipped before next feature release
-is ready.

LICENCE

@@ -0,0 +1,27 @@
+Copyright (c) 2011, Vizzuality 
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+1. Redistributions of source code must retain the above copyright
+   notice, this list of conditions and the following disclaimer.
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+3. All advertising materials mentioning features or use of this software
+   must display the following acknowledgement:
+   This product includes software developed by Vizzuality.
+4. Neither the name of Vizzuality nor the
+   names of its contributors may be used to endorse or promote products
+   derived from this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS "AS IS" AND ANY
+EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY
+DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

LICENSE

@@ -1,27 +0,0 @@
-Copyright (c) 2014, Vizzuality
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without 
-modification, are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice, this 
-list of conditions and the following disclaimer.
-
-2. Redistributions in binary form must reproduce the above copyright notice, 
-this list of conditions and the following disclaimer in the documentation 
-and/or other materials provided with the distribution.
-
-3. Neither the name of the copyright holder nor the names of its contributors 
-may be used to endorse or promote products derived from this software without 
-specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE 
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
-SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 
-CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, 
-OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Makefile

@@ -1,41 +1,32 @@
-SHELL=/bin/bash
-
-pre-install:
-	@$(SHELL) ./scripts/check-node-canvas.sh
+srcdir=$(shell pwd)
 
 all:
-	@$(SHELL) ./scripts/install.sh
+	npm install
 
 clean:
 	rm -rf node_modules/*
 
-distclean: clean
-	rm config.status*
-
-config.status--test:
+config/environments/test.js: config/environments/test.js.example Makefile
 	./configure --environment=test
 
-config/environments/test.js: config.status--test
-	./config.status--test 
+check-local: config/environments/test.js
+	./run_tests.sh ${RUNTESTFLAGS} \
+    test/unit/cartodb/redis_pool.test.js \
+    test/unit/cartodb/req2params.test.js \
+    test/acceptance/cache_validator.js \
+    test/acceptance/server.js \
+    test/acceptance/multilayer.js
 
-test: config/environments/test.js
-	@echo "***tests***"
-	@$(SHELL) ./run_tests.sh ${RUNTESTFLAGS} \
-		test/unit/cartodb/*.js \
-		test/unit/cartodb/cache/model/*.js \
-		test/integration/*.js \
-		test/acceptance/*.js \
-		test/acceptance/cache/*.js
+check-submodules:
+	PATH="$$PATH:$(srcdir)/node_modules/.bin/"; \
+	for sub in windshaft grainstore node-varnish mapnik; do \
+	  if test -e node_modules/$${sub}; then \
+	      echo "Testing submodule $${sub}"; \
+	      make -C node_modules/$${sub} check || exit 1; \
+	  fi; \
+	done
 
-jshint:
-	@echo "***jshint***"
-	@./node_modules/.bin/jshint lib/ test/ app.js
+check-full: check-local check-submodules
 
-test-all: jshint test
+check: check-local
 
-coverage:
-	@RUNTESTFLAGS=--with-coverage make test
-
-check: test
-
-.PHONY: pre-install test jshint coverage

README.md

@@ -1,38 +1,33 @@
 Windshaft-CartoDB
 ==================
 
-[![Build Status](https://travis-ci.org/CartoDB/Windshaft-cartodb.svg?branch=master)](https://travis-ci.org/CartoDB/Windshaft-cartodb)
+[![Build Status](https://travis-ci.org/CartoDB/Windshaft-cartodb.png)](http://travis-ci.org/CartoDB/Windshaft-cartodb)
 
-This is the [CartoDB Maps API](http://docs.cartodb.com/cartodb-platform/maps-api.html) tiler. It extends
-[Windshaft](https://github.com/CartoDB/Windshaft) with some extra functionality and custom filters for authentication.
+This is the CartoDB map tiler. It extends Windshaft with some extra
+functionality and custom filters for authentication
 
 * reads dbname from subdomain and cartodb redis for pretty tile urls
-* configures windshaft to publish `cartodb_id` as the interactivity layer
+* configures windshaft to publish ``cartodb_id`` as the interactivity layer
 * gets the default geometry type from the cartodb redis store
 * allows tiles to be styled individually
 * provides a link to varnish high speed cache
-* provides a ``infowindow`` endpoint for windshaft (DEPRECATED)
-* provides a ``map_metadata`` endpoint for windshaft (DEPRECATED)
-* provides a [template maps API](https://github.com/CartoDB/Windshaft-cartodb/blob/master/docs/Template-maps.md)
+* provides a infowindow endpoint for windshaft
+* provides a ``map_metadata`` endpoint for windshaft
 
 Requirements
 ------------
- - Core
-   - Node.js >=0.8
-   - npm >=1.2.1
-   - PostgreSQL >8.3.x, PostGIS >1.5.x
-   - Redis >2.4.0 (http://www.redis.io)
-   - Mapnik 2.0.1, 2.0.2, 2.1.0, 2.2.0, 2.3.0. See Installing Mapnik.
-   - Windshaft: check [Windshaft dependencies and installation notes](https://github.com/CartoDB/Windshaft#dependencies)
-   - libcairo2-dev, libpango1.0-dev, libjpeg8-dev and libgif-dev for server side canvas support
 
-- For cache control (optional)
-   - CartoDB-SQL-API 1.0.0+
-   - CartoDB 0.9.5+ (for `CDB_QueryTables`)
-   - Varnish (http://www.varnish-cache.org)
+ [core]
+ - node-0.8.x+
+ - PostgreSQL-8.3+
+ - PostGIS-1.5.0+
+ - Redis 2.2.0+ (http://www.redis.io)
+ - Mapnik 2.0 or 2.1 
 
-- For running the testsuite
-   - ImageMagick (http://www.imagemagick.org)
+ [for cache control]
+ - CartoDB-SQL-API 1.0.0+
+ - CartoDB 0.9.5+ (for ``CDB_QueryTables``)
+ - Varnish (https://www.varnish-cache.org)
 
 Configure
 ---------
@@ -74,16 +69,59 @@ there may be out-of-sync records in there.
 Take a look: http://redis.io/commands
 
 
-Documentation
--------------
+URLs
+----
 
-The [docs directory](https://github.com/CartoDB/Windshaft-cartodb/tree/master/docs) contains different documentation
-resources, from higher level to more detailed ones:
-The [Maps API](https://github.com/CartoDB/Windshaft-cartodb/blob/master/docs/Map-API.md) defined the endpoints and their
-expected parameters and outputs.
+**TILES**
+
+[GET] subdomain.cartodb.com/tiles/:table_name/:z/:x/:y.[png|png8|grid.json]
+
+Args:
+
+* sql - plain SQL arguments
+* interactivity - specify the column to use in UTFGrid
+* cache_buster - Specify an identifier for the internal tile cache.
+                 Requesting tiles with the same cache_buster value may
+                 result in being served a cached version of the tile
+                 (even when requesting a tile for the first time, as tiles
+                 can be prepared in advance)
+* cache_policy - Set to "persist" to have the server send an Cache-Control
+                 header requesting caching devices to keep the response
+                 cached as much as possible. This is best used with a
+                 timestamp value in cache_buster for manual control of
+                 updates.
+* geom_type - override the cartodb default
+* style - override the default map style with Carto
 
 
-Examples
---------
+**STYLE**
 
-[CartoDB's Map Gallery](http://cartodb.com/gallery/) showcases several examples of visualisations built on top of this.
+[GET/POST] subdomain.cartodb.com/tiles/:table_name/style
+
+Args:
+
+* style - the style in CartoCSS you want to set
+* style_version - the version of the style for POST
+* style_convert - request conversion to target version (both POST and GET)
+
+
+**INFOWINDOW**
+
+[GET] subdomain.cartodb.com/tiles/:table_name/infowindow
+
+Args:
+
+* infowindow - returns contents of infowindow from CartoDB.
+
+
+**MAP METADATA**
+
+[GET] subdomain.cartodb.com/tiles/:table_name/map_metadata
+
+Args:
+
+* infowindow - returns contents of infowindow from CartoDB.
+
+
+All GET requests are wrappable with JSONP using callback argument,
+including the UTFGrid map tile call.

app.js

@@ -7,82 +7,32 @@
  * environments: [development, production]
  */
 
-var path = require('path');
-var fs = require('fs');
-var RedisPool = require('redis-mpool');
-var _ = require('underscore');
-
-var ENV;
-if ( process.argv[2] ) {
-    ENV = process.argv[2];
-} else if ( process.env.NODE_ENV ) {
-    ENV = process.env.NODE_ENV;
-} else {
-    ENV = 'development';
-}
-
-process.env.NODE_ENV = ENV;
 
 // sanity check
+var ENV = process.argv[2]
 if (ENV != 'development' && ENV != 'production' && ENV != 'staging' ){
     console.error("\nnode app.js [environment]");
-    console.error("environments: development, production, staging\n");
+    console.error("environments: [development, production, staging]\n");
     process.exit(1);
 }
 
+var _ = require('underscore')
+    , Step       = require('step')
+	, CartodbWindshaft = require('./lib/cartodb/cartodb_windshaft');
+
 // set environment specific variables
+global.settings     = require(__dirname + '/config/settings');
 global.environment  = require(__dirname + '/config/environments/' + ENV);
-global.environment.api_hostname = require('os').hostname().split('.')[0];
+_.extend(global.settings, global.environment);
 
-global.log4js = require('log4js');
-var log4js_config = {
-  appenders: [],
-  replaceConsole:true
-};
-
-if (global.environment.uv_threadpool_size) {
-    process.env.UV_THREADPOOL_SIZE = global.environment.uv_threadpool_size;
-}
-
-if ( global.environment.log_filename ) {
-  var logdir = path.dirname(global.environment.log_filename);
-  // See cwd inlog4js.configure call below
-  logdir = path.resolve(__dirname, logdir);
-  if ( ! fs.existsSync(logdir) ) {
-    console.error("Log filename directory does not exist: " + logdir);
-    process.exit(1);
-  }
-  console.log("Logs will be written to " + global.environment.log_filename);
-  log4js_config.appenders.push(
-    { type: "file", filename: global.environment.log_filename }
-  );
-} else {
-  log4js_config.appenders.push(
-    { type: "console", layout: { type:'basic' } }
-  );
-}
-
-global.log4js.configure(log4js_config, { cwd: __dirname });
-global.logger = global.log4js.getLogger();
-
-var redisOpts = _.extend(global.environment.redis, { name: 'windshaft' }),
-    redisPool = new RedisPool(redisOpts);
-
-// Include cartodb_windshaft only _after_ the "global" variable is set
+// Include cart_data.js only _after_ the "global" variable is set
 // See https://github.com/Vizzuality/Windshaft-cartodb/issues/28
-var cartodbWindshaft = require('./lib/cartodb/cartodb_windshaft'),
-    serverOptions = require('./lib/cartodb/server_options')(redisPool);
+var cartoData = require('./lib/cartodb/carto_data');
 
-var ws = cartodbWindshaft(serverOptions);
+var Windshaft = require('windshaft');
+var serverOptions = require('./lib/cartodb/server_options');
 
-if (global.statsClient) {
-    redisPool.on('status', function(status) {
-        var keyPrefix = 'windshaft.redis-pool.' + status.name + '.db' + status.db + '.';
-        global.statsClient.gauge(keyPrefix + 'count', status.count);
-        global.statsClient.gauge(keyPrefix + 'unused', status.unused);
-        global.statsClient.gauge(keyPrefix + 'waiting', status.waiting);
-    });
-}
+ws = CartodbWindshaft(serverOptions);
 
 // Maximum number of connections for one process
 // 128 is a good number if you have up to 1024 filedescriptors
@@ -92,23 +42,16 @@ ws.maxConnections = global.environment.maxConnections || 128;
 
 ws.listen(global.environment.port, global.environment.host);
 
-var version = require("./package").version;
-
 ws.on('listening', function() {
-  console.log(
-      "Windshaft tileserver %s started on %s:%s (%s)",
-      version, global.environment.host, global.environment.port, ENV
-  );
+  console.log("Windshaft tileserver started on " + global.environment.host + ':' + global.environment.port);
 });
 
-process.on('SIGHUP', function() {
-    global.log4js.clearAndShutdownAppenders(function() {
-        global.log4js.configure(log4js_config);
-        global.logger = global.log4js.getLogger();
-        console.log('Log files reloaded');
-    });
+// DEPRECATED, use SIGUSR2
+process.on('SIGUSR1', function() {
+  console.log('WARNING: handling of SIGUSR1 by Windshaft-CartoDB is deprecated, please send SIGUSR2 instead');
+  ws.dumpCacheStats();
 });
 
-process.on('uncaughtException', function(err) {
-    global.logger.error('Uncaught exception: ' + err.stack);
+process.on('SIGUSR2', function() {
+  ws.dumpCacheStats();
 });

config/environments/development.js.example

@@ -2,55 +2,20 @@ var config = {
      environment: 'development'
     ,port: 8181
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
-    // Regular expression pattern to extract username
-    // from hostname. Must have a single grabbing block.
-    ,user_from_host: '^(.*)\\.localhost'
-
-    // Base URLs for the APIs
-    //
-    // See http://github.com/CartoDB/Windshaft-cartodb/wiki/Unified-Map-API
-    // 
-    // Base url for the Templated Maps API
-    // "/api/v1/map/named" is the new API,
-    // "/tiles/template" is for compatibility with versions up to 1.6.x
-    ,base_url_templated: '(?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)'
-    // Base url for the Detached Maps API
-    // "maps" is the the new API,
-    // "tiles/layergroup" is for compatibility with versions up to 1.6.x
-    ,base_url_detached: '(?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)'
-
     // Maximum number of connections for one process
     // 128 is a good value with a limit of 1024 open file descriptors
     ,maxConnections:128
-    // Maximum number of templates per user. Unlimited by default.
-    ,maxUserTemplates:1024
-    // Seconds since "last creation" before a detached
-    // or template instance map expires. Or: how long do you want
-    // to be able to navigate the map without a reload ?
-    // Defaults to 7200 (2 hours)
-    ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds 
+    // idle socket timeout, in miliseconds 
     ,socket_timeout: 600000
     ,enable_cors: true
     ,cache_enabled: false
-    ,log_format: ':req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    ,log_filename: undefined
-    // Templated database username for authorized user
-    // Supported labels: 'user_id' (read from redis)
+    ,log_format: '[:date] :req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
     ,postgres_auth_user: 'development_cartodb_user_<%= user_id %>'
-    // Templated database password for authorized user
-    // Supported labels: 'user_id', 'user_password' (both read from redis)
-    ,postgres_auth_pass: '<%= user_password %>'
     ,postgres: {
         // Parameters to pass to datasource plugin of mapnik
         // See http://github.com/mapnik/mapnik/wiki/PostGIS
         type: "postgis",
         user: "publicuser",
-        password: "public",
         host: '127.0.0.1',
         port: 5432,
         extent: "-20037508.3,-20037508.3,20037508.3,20037508.3",
@@ -61,86 +26,14 @@ var config = {
         */
         row_limit: 65535,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         max_size: 500
     }
     ,mapnik_version: undefined
-    ,mapnik_tile_format: 'png8:m=h'
-    ,statsd: {
-        host: 'localhost',
-        port: 8125,
-        prefix: 'dev.',
-        cacheDns: true
-        // support all allowed node-statsd options
-    }
     ,renderer: {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      mapnik: {
-          // The size of the pool of internal mapnik renderers
-          // Check the configuration of uv_threadpool_size to use suitable value
-          poolSize: 8,
-
-          // Metatile is the number of tiles-per-side that are going
-          // to be rendered at once. If all of them will be requested
-          // we'd have saved time. If only one will be used, we'd have
-          // wasted time.
-          metatile: 2,
-
-          // Buffer size is the tickness in pixel of a buffer
-          // around the rendered (meta?)tile.
-          //
-          // This is important for labels and other marker that overlap tile boundaries.
-          // Setting to 128 ensures no render artifacts.
-          // 64 may have artifacts but is faster.
-          // Less important if we can turn metatiling on.
-          bufferSize: 64,
-
-          // SQL queries will be wrapped with ST_SnapToGrid
-          // Snapping all points of the  geometry to a regular grid
-          snapToGrid: false,
-
-          // SQL queries will be wrapped with ST_ClipByBox2D
-          // Returning the portion of a geometry falling within a rectangle
-          // It will only work if snapToGrid is enabled
-          clipByBox2d: false, // this requires postgis >=2.2 and geos >=3.5
-
-          limits: {
-              // Time in milliseconds a render request can take before it fails, some notes:
-              //  - 0 means no render limit
-              //  - it considers metatiling, naive implementation: (render timeout) * (number of tiles in metatile)
-              render: 0,
-              // As the render request will finish even if timed out, whether it should be placed in the internal
-              // cache or it should be fully discarded. When placed in the internal cache another attempt to retrieve
-              // the same tile will result in an immediate response, however that will use a lot of more application
-              // memory. If we want to enforce this behaviour we have to implement a cache eviction policy for the
-              // internal cache.
-              cacheOnTimeout: true
-          }
-      },
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              '.*', // will enable any URL
-              'http://{s}.example.com/{z}/{x}/{y}.png'
-          ],
-          // image to use as placeholder when urlTemplate is not in the whitelist
-          // if provided the http renderer will use it instead of throw an error
-          fallbackImage: {
-              type: 'fs', // 'fs' and 'url' supported
-              src: __dirname + '/../../assets/default-placeholder.png'
-          }
-      }
+      metatile: 4,
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -152,65 +45,29 @@ var config = {
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 1, // idle time before dropping connection
-        reapIntervalMillis: 1, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1 // time between cleanups
+    }
+    ,sqlapi: {
+        protocol: 'http',
+        domain: 'localhost.lan',
+        port: 8080,
+        version: 'v1'
     }
     ,varnish: {
         host: 'localhost',
-        port: 6082, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
-        secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
-    }
-    // this [OPTIONAL] configuration enables invalidating by surrogate key in fastly
-    ,fastly: {
-        // whether the invalidation is enabled or not
-        enabled: false,
-        // the fastly api key
-        apiKey: 'wadus_api_key',
-        // the service that will get surrogate key invalidation
-        serviceId: 'wadus_service_id'
+        port: 6082,
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
     ,useProfiler:true
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: false,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
-    ,disabled_file: 'pids/disabled'
-
-    // Use this as a feature flags enabling/disabling mechanism
-    ,enabledFeatures: {
-        // whether it should intercept tile render errors an act based on them, enabled by default.
-        onTileErrorStrategy: true,
-        // whether the affected tables for a given SQL must query directly postgresql or use the SQL API
-        cdbQueryTablesFromPostgres: true
-    }
 };
 
 module.exports = config;

config/environments/production.js.example

@@ -2,139 +2,32 @@ var config = {
     environment: 'production'
     ,port: 8181
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
-    // Regular expression pattern to extract username
-    // from hostname. Must have a single grabbing block.
-    ,user_from_host: '^(.*)\\.cartodb\\.com$'
-
-    // Base URLs for the APIs
-    //
-    // See http://github.com/CartoDB/Windshaft-cartodb/wiki/Unified-Map-API
-    // 
-    // Base url for the Templated Maps API
-    // "/api/v1/map/named" is the new API,
-    // "/tiles/template" is for compatibility with versions up to 1.6.x
-    ,base_url_templated: '(?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)'
-    // Base url for the Detached Maps API
-    // "maps" is the the new API,
-    // "tiles/layergroup" is for compatibility with versions up to 1.6.x
-    ,base_url_detached: '(?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)'
-
     // Maximum number of connections for one process
     // 128 is a good value with a limit of 1024 open file descriptors
     ,maxConnections:128
-    // Maximum number of templates per user. Unlimited by default.
-    ,maxUserTemplates:1024
-    // Seconds since "last creation" before a detached
-    // or template instance map expires. Or: how long do you want
-    // to be able to navigate the map without a reload ?
-    // Defaults to 7200 (2 hours)
-    ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds
+    // idle socket timeout, in miliseconds
     ,socket_timeout: 600000 
     ,enable_cors: true
     ,cache_enabled: true
-    ,log_format: ':req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    ,log_filename: 'logs/node-windshaft.log'
-    // Templated database username for authorized user
-    // Supported labels: 'user_id' (read from redis)
+    ,log_format: '[:date] :req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
     ,postgres_auth_user: 'cartodb_user_<%= user_id %>'
-    // Templated database password for authorized user
-    // Supported labels: 'user_id', 'user_password' (both read from redis)
-    ,postgres_auth_pass: '<%= user_password %>'
     ,postgres: {
         // Parameters to pass to datasource plugin of mapnik
         // See http://github.com/mapnik/mapnik/wiki/PostGIS
         user: "publicuser",
-        password: "public",
         host: '127.0.0.1',
         port: 6432,
         extent: "-20037508.3,-20037508.3,20037508.3,20037508.3",
         row_limit: 65535,
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
         max_size: 500
     }
     ,mapnik_version: undefined
-    ,mapnik_tile_format: 'png8:m=h'
-    ,statsd: {
-        host: 'localhost',
-        port: 8125,
-        prefix: ':host.', // could be hostname, better not containing dots
-        cacheDns: true
-        // support all allowed node-statsd options
-    }
     ,renderer: {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      mapnik: {
-          // The size of the pool of internal mapnik renderers
-          // Check the configuration of uv_threadpool_size to use suitable value
-          poolSize: 8,
-
-          // Metatile is the number of tiles-per-side that are going
-          // to be rendered at once. If all of them will be requested
-          // we'd have saved time. If only one will be used, we'd have
-          // wasted time.
-          metatile: 2,
-
-          // Buffer size is the tickness in pixel of a buffer
-          // around the rendered (meta?)tile.
-          //
-          // This is important for labels and other marker that overlap tile boundaries.
-          // Setting to 128 ensures no render artifacts.
-          // 64 may have artifacts but is faster.
-          // Less important if we can turn metatiling on.
-          bufferSize: 64,
-
-          // SQL queries will be wrapped with ST_SnapToGrid
-          // Snapping all points of the  geometry to a regular grid
-          snapToGrid: false,
-
-          // SQL queries will be wrapped with ST_ClipByBox2D
-          // Returning the portion of a geometry falling within a rectangle
-          // It will only work if snapToGrid is enabled
-          clipByBox2d: false, // this requires postgis >=2.2 and geos >=3.5
-
-          limits: {
-              // Time in milliseconds a render request can take before it fails, some notes:
-              //  - 0 means no render limit
-              //  - it considers metatiling, naive implementation: (render timeout) * (number of tiles in metatile)
-              render: 0,
-              // As the render request will finish even if timed out, whether it should be placed in the internal
-              // cache or it should be fully discarded. When placed in the internal cache another attempt to retrieve
-              // the same tile will result in an immediate response, however that will use a lot of more application
-              // memory. If we want to enforce this behaviour we have to implement a cache eviction policy for the
-              // internal cache.
-              cacheOnTimeout: true
-          }
-      },
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              '.*', // will enable any URL
-              'http://{s}.example.com/{z}/{x}/{y}.png'
-          ],
-          // image to use as placeholder when urlTemplate is not in the whitelist
-          // if provided the http renderer will use it instead of throw an error
-          fallbackImage: {
-              type: 'fs', // 'fs' and 'url' supported
-              src: __dirname + '/../../assets/default-placeholder.png'
-          }
-      }
+      metatile: 4,
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -146,71 +39,29 @@ var config = {
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 30000, // idle time before dropping connection
-        reapIntervalMillis: 1000, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1000 // time between cleanups
+    }
+    ,sqlapi: {
+        protocol: 'https',
+        domain: 'cartodb.com',
+        port: 8080,
+        version: 'v2'
     }
     ,varnish: {
         host: 'localhost',
-        port: 6082, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
-        secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
-    }
-    // this [OPTIONAL] configuration enables invalidating by surrogate key in fastly
-    ,fastly: {
-        // whether the invalidation is enabled or not
-        enabled: false,
-        // the fastly api key
-        apiKey: 'wadus_api_key',
-        // the service that will get surrogate key invalidation
-        serviceId: 'wadus_service_id'
+        port: 6082,
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
     ,useProfiler:false
-    ,serverMetadata: {
-      cdn_url: {
-        http: 'api.cartocdn.com',
-        https: 'cartocdn.global.ssl.fastly.net'
-      }
-    }
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: true,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
-    ,disabled_file: 'pids/disabled'
-
-    // Use this as a feature flags enabling/disabling mechanism
-    ,enabledFeatures: {
-        // whether it should intercept tile render errors an act based on them, enabled by default.
-        onTileErrorStrategy: true,
-        // whether the affected tables for a given SQL must query directly postgresql or use the SQL API
-        cdbQueryTablesFromPostgres: true
-    }
 };
 
 module.exports = config;

config/environments/staging.js.example

@@ -2,139 +2,32 @@ var config = {
     environment: 'production'
     ,port: 8181
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
-    // Regular expression pattern to extract username
-    // from hostname. Must have a single grabbing block.
-    ,user_from_host: '^(.*)\\.cartodb\\.com$'
-
-    // Base URLs for the APIs
-    //
-    // See http://github.com/CartoDB/Windshaft-cartodb/wiki/Unified-Map-API
-    // 
-    // Base url for the Templated Maps API
-    // "/api/v1/maps/named" is the new API,
-    // "/tiles/template" is for compatibility with versions up to 1.6.x
-    ,base_url_templated: '(?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)'
-    // Base url for the Detached Maps API
-    // "/api/v1/maps" is the the new API,
-    // "/tiles/layergroup" is for compatibility with versions up to 1.6.x
-    ,base_url_detached: '(?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)'
-
     // Maximum number of connections for one process
     // 128 is a good value with a limit of 1024 open file descriptors
     ,maxConnections:128
-    // Maximum number of templates per user. Unlimited by default.
-    ,maxUserTemplates:1024
-    // Seconds since "last creation" before a detached
-    // or template instance map expires. Or: how long do you want
-    // to be able to navigate the map without a reload ?
-    // Defaults to 7200 (2 hours)
-    ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds
+    // idle socket timeout, in miliseconds
     ,socket_timeout: 600000 
     ,enable_cors: true
     ,cache_enabled: true
-    ,log_format: ':req[X-Real-IP] :method :req[Host]:url :status :response-time ms (:res[X-Tiler-Profiler]) -> :res[Content-Type]'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    ,log_filename: 'logs/node-windshaft.log'
-    // Templated database username for authorized user
-    // Supported labels: 'user_id' (read from redis)
+    ,log_format: '[:date] :req[X-Real-IP] :method :req[Host]:url :status :response-time ms (:res[X-Tiler-Profiler]) -> :res[Content-Type]'
     ,postgres_auth_user: 'cartodb_staging_user_<%= user_id %>'
-    // Templated database password for authorized user
-    // Supported labels: 'user_id', 'user_password' (both read from redis)
-    ,postgres_auth_pass: '<%= user_password %>'
     ,postgres: {
         // Parameters to pass to datasource plugin of mapnik
         // See http://github.com/mapnik/mapnik/wiki/PostGIS
         user: "publicuser",
-        password: "public",
         host: '127.0.0.1',
         port: 6432,
         extent: "-20037508.3,-20037508.3,20037508.3,20037508.3",
         row_limit: 65535,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         max_size: 500
     }
     ,mapnik_version: undefined
-    ,mapnik_tile_format: 'png8:m=h'
-    ,statsd: {
-        host: 'localhost',
-        port: 8125,
-        prefix: 'stage.:host.',
-        cacheDns: true
-        // support all allowed node-statsd options
-    }
     ,renderer: {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      mapnik: {
-          // The size of the pool of internal mapnik renderers
-          // Check the configuration of uv_threadpool_size to use suitable value
-          poolSize: 8,
-
-          // Metatile is the number of tiles-per-side that are going
-          // to be rendered at once. If all of them will be requested
-          // we'd have saved time. If only one will be used, we'd have
-          // wasted time.
-          metatile: 2,
-
-          // Buffer size is the tickness in pixel of a buffer
-          // around the rendered (meta?)tile.
-          //
-          // This is important for labels and other marker that overlap tile boundaries.
-          // Setting to 128 ensures no render artifacts.
-          // 64 may have artifacts but is faster.
-          // Less important if we can turn metatiling on.
-          bufferSize: 64,
-
-          // SQL queries will be wrapped with ST_SnapToGrid
-          // Snapping all points of the  geometry to a regular grid
-          snapToGrid: false,
-
-          // SQL queries will be wrapped with ST_ClipByBox2D
-          // Returning the portion of a geometry falling within a rectangle
-          // It will only work if snapToGrid is enabled
-          clipByBox2d: false, // this requires postgis >=2.2 and geos >=3.5
-
-          limits: {
-              // Time in milliseconds a render request can take before it fails, some notes:
-              //  - 0 means no render limit
-              //  - it considers metatiling, naive implementation: (render timeout) * (number of tiles in metatile)
-              render: 0,
-              // As the render request will finish even if timed out, whether it should be placed in the internal
-              // cache or it should be fully discarded. When placed in the internal cache another attempt to retrieve
-              // the same tile will result in an immediate response, however that will use a lot of more application
-              // memory. If we want to enforce this behaviour we have to implement a cache eviction policy for the
-              // internal cache.
-              cacheOnTimeout: true
-          }
-      },
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              '.*', // will enable any URL
-              'http://{s}.example.com/{z}/{x}/{y}.png'
-          ],
-          // image to use as placeholder when urlTemplate is not in the whitelist
-          // if provided the http renderer will use it instead of throw an error
-          fallbackImage: {
-              type: 'fs', // 'fs' and 'url' supported
-              src: __dirname + '/../../assets/default-placeholder.png'
-          }
-      }
+      metatile: 4,
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -146,71 +39,29 @@ var config = {
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 30000, // idle time before dropping connection
-        reapIntervalMillis: 1000, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1000 // time between cleanups
+    }
+    ,sqlapi: {
+        protocol: 'https',
+        domain: 'cartodb.com',
+        port: 8080,
+        version: 'v2'
     }
     ,varnish: {
         host: 'localhost',
-        port: 6082, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
-        secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
-    }
-    // this [OPTIONAL] configuration enables invalidating by surrogate key in fastly
-    ,fastly: {
-        // whether the invalidation is enabled or not
-        enabled: false,
-        // the fastly api key
-        apiKey: 'wadus_api_key',
-        // the service that will get surrogate key invalidation
-        serviceId: 'wadus_service_id'
+        port: 6082,
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
     ,useProfiler:true
-    ,serverMetadata: {
-      cdn_url: {
-        http: 'api.cartocdn.com',
-        https: 'cartocdn.global.ssl.fastly.net'
-      }
-    }
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: false,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
-    ,disabled_file: 'pids/disabled'
-
-    // Use this as a feature flags enabling/disabling mechanism
-    ,enabledFeatures: {
-        // whether it should intercept tile render errors an act based on them, enabled by default.
-        onTileErrorStrategy: true,
-        // whether the affected tables for a given SQL must query directly postgresql or use the SQL API
-        cdbQueryTablesFromPostgres: true
-    }
 };
 
 module.exports = config;

config/environments/test.js.example

@@ -2,141 +2,32 @@ var config = {
      environment: 'test'
     ,port: 8888
     ,host: '127.0.0.1'
-    ,uv_threadpool_size: undefined
-    // Regular expression pattern to extract username
-    // from hostname. Must have a single grabbing block.
-    ,user_from_host: '(.*)'
-
-    // Base URLs for the APIs
-    //
-    // See https://github.com/CartoDB/Windshaft-cartodb/wiki/Unified-Map-API
-    // 
-    // Base url for the Templated Maps API
-    // "/api/v1/map/named" is the new API,
-    // "/tiles/template" is for compatibility with versions up to 1.6.x
-    ,base_url_templated: '(?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)'
-    // Base url for the Detached Maps API
-    // "maps" is the the new API,
-    // "tiles/layergroup" is for compatibility with versions up to 1.6.x
-    ,base_url_detached: '(?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)'
-
     // Maximum number of connections for one process
     // 128 is a good value with a limit of 1024 open file descriptors
     ,maxConnections:128
-    // Maximum number of templates per user. Unlimited by default.
-    ,maxUserTemplates:1024
-    // Seconds since "last creation" before a detached
-    // or template instance map expires. Or: how long do you want
-    // to be able to navigate the map without a reload ?
-    // Defaults to 7200 (2 hours)
-    ,mapConfigTTL: 7200
-    // idle socket timeout, in milliseconds
+    // idle socket timeout, in miliseconds
     ,socket_timeout: 600000 
     ,enable_cors: true
     ,cache_enabled: false
     ,log_format: '[:date] :req[X-Real-IP] :method :req[Host]:url :status :response-time ms -> :res[Content-Type] (:res[X-Tiler-Profiler])'
-    // If log_filename is given logs will be written
-    // there, in append mode. Otherwise stdout is used (default).
-    // Log file will be re-opened on receiving the HUP signal
-    //,log_filename: 'logs/node-windshaft.log'
-    // Templated database username for authorized user
-    // Supported labels: 'user_id' (read from redis)
-    ,postgres_auth_user: 'test_windshaft_cartodb_user_<%= user_id %>'
-    // Templated database password for authorized user
-    // Supported labels: 'user_id', 'user_password' (both read from redis)
-    ,postgres_auth_pass: 'test_windshaft_cartodb_user_<%= user_id %>_pass'
+    ,postgres_auth_user: 'test_cartodb_user_<%= user_id %>'
     ,postgres: {
         // Parameters to pass to datasource plugin of mapnik
         // See http://github.com/mapnik/mapnik/wiki/PostGIS
-        user: "test_windshaft_publicuser",
-        password: "public",
+        user: "publicuser",
         host: '127.0.0.1',
         port: 5432,
         extent: "-20037508.3,-20037508.3,20037508.3,20037508.3",
         row_limit: 65535,
         simplify_geometries: true,
-        use_overviews: true, // use overviews to retrieve raster
-        /*
-         * Set persist_connection to false if you want
-         * database connections to be closed on renderer
-         * expiration (1 minute after last use).
-         * Setting to true (the default) would never
-         * close any connection for the server's lifetime
-         */
-        persist_connection: false,
         max_size: 500
     }
-    ,mapnik_version: ''
-    ,mapnik_tile_format: 'png8:m=h'
-    ,statsd: {
-        host: 'localhost',
-        port: 8125,
-        prefix: 'test.:host.',
-        cacheDns: true
-        // support all allowed node-statsd options
-    }
+    ,mapnik_version: '2.0.2'
     ,renderer: {
       // Milliseconds since last access before renderer cache item expires
       cache_ttl: 60000,
-      statsInterval: 5000, // milliseconds between each report to statsd about number of renderers and mapnik pool status
-      mapnik: {
-          // The size of the pool of internal mapnik renderers
-          // Check the configuration of uv_threadpool_size to use suitable value
-          poolSize: 8,
-
-          // Metatile is the number of tiles-per-side that are going
-          // to be rendered at once. If all of them will be requested
-          // we'd have saved time. If only one will be used, we'd have
-          // wasted time.
-          metatile: 2,
-
-          // Buffer size is the tickness in pixel of a buffer
-          // around the rendered (meta?)tile.
-          //
-          // This is important for labels and other marker that overlap tile boundaries.
-          // Setting to 128 ensures no render artifacts.
-          // 64 may have artifacts but is faster.
-          // Less important if we can turn metatiling on.
-          bufferSize: 64,
-
-          // SQL queries will be wrapped with ST_SnapToGrid
-          // Snapping all points of the  geometry to a regular grid
-          snapToGrid: false,
-
-          // SQL queries will be wrapped with ST_ClipByBox2D
-          // Returning the portion of a geometry falling within a rectangle
-          // It will only work if snapToGrid is enabled
-          clipByBox2d: false, // this requires postgis >=2.2 and geos >=3.5
-
-          limits: {
-              // Time in milliseconds a render request can take before it fails, some notes:
-              //  - 0 means no render limit
-              //  - it considers metatiling, naive implementation: (render timeout) * (number of tiles in metatile)
-              render: 0,
-              // As the render request will finish even if timed out, whether it should be placed in the internal
-              // cache or it should be fully discarded. When placed in the internal cache another attempt to retrieve
-              // the same tile will result in an immediate response, however that will use a lot of more application
-              // memory. If we want to enforce this behaviour we have to implement a cache eviction policy for the
-              // internal cache.
-              cacheOnTimeout: true
-          }
-      },
-      http: {
-          timeout: 2000, // the timeout in ms for a http tile request
-          proxy: undefined, // the url for a proxy server
-          whitelist: [ // the whitelist of urlTemplates that can be used
-              '.*', // will enable any URL
-              'http://{s}.example.com/{z}/{x}/{y}.png',
-              // for testing purposes
-              'http://{s}.basemaps.cartocdn.com/dark_nolabels/{z}/{x}/{y}.png'
-          ],
-          // image to use as placeholder when urlTemplate is not in the whitelist
-          // if provided the http renderer will use it instead of throw an error
-          fallbackImage: {
-              type: 'fs', // 'fs' and 'url' supported
-              src: __dirname + '/../../assets/default-placeholder.png'
-          }
-      }
+      metatile: 4,
+      bufferSize: 64
     }
     ,millstone: {
         // Needs to be writable by server user
@@ -144,69 +35,35 @@ var config = {
     }
     ,redis: {
         host: '127.0.0.1',
-        port: 6335,
+        port: 6333,
         // Max number of connections in each pool.
         // Users will be put on a queue when the limit is hit.
         // Set to maxConnection to have no possible queues.
-        // There are currently 2 pools involved in serving
+        // There are currently 3 pools involved in serving
         // windshaft-cartodb requests so multiply this number
-        // by 2 to know how many possible connections will be
+        // by 3 to know how many possible connections will be
         // kept open by the server. The default is 50.
         max: 50,
-        returnToHead: true, // defines the behaviour of the pool: false => queue, true => stack
         idleTimeoutMillis: 1, // idle time before dropping connection
-        reapIntervalMillis: 1, // time between cleanups
-        slowQueries: {
-            log: true,
-            elapsedThreshold: 200
-        },
-        slowPool: {
-            log: true, // whether a slow acquire must be logged or not
-            elapsedThreshold: 25 // the threshold to determine an slow acquire must be reported or not
-        },
-        emitter: {
-            statusInterval: 5000 // time, in ms, between each status report is emitted from the pool, status is sent to statsd
-        }
+        reapIntervalMillis: 1 // time between cleanups
+    }
+    ,sqlapi: {
+        protocol: 'http',
+        domain: '',
+        // This port will be used by "make check" for testing purposes
+        // It must be available
+        port: 1080,
+        version: 'v1'
     }
     ,varnish: {
         host: '',
-        port: null, // the por for the telnet interface where varnish is listening to
-        http_port: 6081, // the port for the HTTP interface where varnish is listening to
-        purge_enabled: false, // whether the purge/invalidation mechanism is enabled in varnish or not
-        secret: 'xxx',
-        ttl: 86400,
-        layergroupTtl: 86400 // the max-age for cache-control header in layergroup responses
-    }
-    // this [OPTIONAL] configuration enables invalidating by surrogate key in fastly
-    ,fastly: {
-        // whether the invalidation is enabled or not
-        enabled: false,
-        // the fastly api key
-        apiKey: 'wadus_api_key',
-        // the service that will get surrogate key invalidation
-        serviceId: 'wadus_service_id'
+        port: null,
+        ttl: 86400
     }
     // If useProfiler is true every response will be served with an
     // X-Tiler-Profile header containing elapsed timing for various 
     // steps taken for producing the response.
-    ,useProfiler:true
-    // Settings for the health check available at /health
-    ,health: {
-      enabled: false,
-      username: 'localhost',
-      z: 0,
-      x: 0,
-      y: 0
-    }
-    ,disabled_file: 'pids/disabled'
-
-    // Use this as a feature flags enabling/disabling mechanism
-    ,enabledFeatures: {
-        // whether it should intercept tile render errors an act based on them, enabled by default.
-        onTileErrorStrategy: true,
-        // whether the affected tables for a given SQL must query directly postgresql or use the SQL API
-        cdbQueryTablesFromPostgres: true
-    }
+    ,useProfiler:false
 };
 
 module.exports = config;

config/settings.js

@@ -0,0 +1 @@
+module.exports.oneDay   = 86400000;

configure

@@ -17,15 +17,11 @@
 # --strk(2012-07-23)
 #
 
-ENVDIR=config/environments
-
-PGPORT=
-SQLAPI_PORT=
+PGPORT=5432
+SQLAPI_PORT=8080
 MAPNIK_VERSION=
 ENVIRONMENT=development
 
-STATUS="$0 $*"
-
 usage() {
   echo "Usage: $0 [OPTION]"
   echo 
@@ -56,36 +52,27 @@ while test -n "$1"; do
       ENVIRONMENT=`echo "$1" | cut -d= -f2`
       ;;
     *)
-      echo "Unused option '$1'" >&2
-      ;;
+      echo "Unknown option '$1'" >&2
+      usage >&2
+      exit 1
   esac
   shift
 done
 
-ENVEX=./${ENVDIR}/${ENVIRONMENT}.js.example
-
-if [ -z "$PGPORT" ]; then
-  PGPORT=`node -e "console.log(require('${ENVEX}').postgres.port)"`
-fi
-if [ -z "$SQLAPI_PORT" ]; then
-  SQLAPI_PORT=`node -e "console.log(require('${ENVEX}').sqlapi.port)"`
-fi
-
 echo "PGPORT: $PGPORT"
 echo "SQLAPI_PORT: $SQLAPI_PORT"
 echo "MAPNIK_VERSION: $MAPNIK_VERSION"
 echo "ENVIRONMENT: $ENVIRONMENT"
 
-o=`dirname "${ENVEX}"`/`basename "${ENVEX}" .example`
-echo "Writing $o"
+# TODO: allow specifying configuration settings !
+for f in config/environments/${ENVIRONMENT}.js.example; do
+  o=`dirname "$f"`/`basename "$f" .example`
+  echo "Writing $o"
 
-# See http://austinmatzko.com/2008/04/26/sed-multi-line-search-and-replace/
-sed -n "1h;1!H;\${;g;s/\(,postgres: {[^}]*port: *'\?\)[^',]*\('\?,\)/\1$PGPORT\2/;p;}" < "${ENVEX}" \
+  # See http://austinmatzko.com/2008/04/26/sed-multi-line-search-and-replace/
+  sed -n "1h;1!H;\${;g;s/\(,postgres: {[^}]*port: *'\?\)[^',]*\('\?,\)/\1$PGPORT\2/;p;}" < "$f" \
   | sed "s/mapnik_version:.*/mapnik_version: '$MAPNIK_VERSION'/" \
   | sed -n "1h;1!H;\${;g;s/\(,sqlapi: {[^}]*port: *'\?\)[^',]*\('\?,\)/\1$SQLAPI_PORT\2/;p;}" \
   > "$o"
 
-STATUSFILE=config.status--${ENVIRONMENT}
-echo "Writing ${STATUSFILE}"
-echo ${STATUS} > ${STATUSFILE} && chmod +x ${STATUSFILE}
-
+done

docs/Map-API-internal.md

@@ -1,111 +0,0 @@
-# Kind of maps
-
-Windshaft-CartoDB supports the following types of maps:
-
- - [Temporary maps](#temporary-maps) (created by anyone)
-   - [Detached maps](#detached-maps)
-   - [Inline maps](#inline-maps) (legacy)
- - [Persistent maps](#peristent-maps) (created by CartDB user)
-   - [Template maps](#template-maps)
-   - [Table maps](#table-maps) (legacy, deprecated) 
-
-## Temporary maps
-
-Temporary maps have no owners and are anonymous in nature.
-There are two kinds of temporary maps:
-
- - Detached maps (aka MultiLayer-API)
- - Inline maps 
-
-### Detached maps
-
-Detached maps are maps that are configured with a request
-obtaining a temporary token and then used by referencing
-the obtained token. The token expires automatically when unused.
-
-Anyone can create detached maps, but users will need read access
-to the data source of the map layers.
-
-The configuration format is a [MapConfig]
-(http://github.com/CartoDB/Windshaft/wiki/MapConfig-specification) document.
-
-The HTTP endpoints for creating the map and using it are described [here]
-(http://github.com/CartoDB/Windshaft-cartodb/wiki/MultiLayer-API)
-
-*TODO* cleanup the referenced document
-
-### Inline maps
-
-Inline maps are maps that only exist for a single request,
-being the request for a specific map resource (tile).
-
-Inline maps are always bound to a table, and can only be
-obtained by those having read access to the that table.
-Additionally, users need to have access to any datasource
-specified as part of the configuration.
-
-Inline maps only support PNG and UTF8GRID tiles.
-
-The configuration consist in a set of parameters, to be
-specified in the query string of the tile request:
-
- * sql - the query to run as datasource, can be an array
- * style - the CartoCSS style for the datasource, can be an array
- * style_version - version of the CartoCSS style, can be an array
- * interactivity - only for fetching UTF8GRID, 
-
-If the style is not provided, style of the associated table is
-used; if the sql is not provided, all records of the associated
-table are used as the datasource; the two possibilities result
-in a mix between _inline_ maps and [Table maps][].
-
-*TODO* specify (or link) api endpoints
-
-## Persistent maps
-
-Persistent maps can only be created by a CartoDB user who has full
-responsibility over editing and deleting them. There are two
-kind of persistent maps:
-
- - Template maps 
- - Table maps (legacy, deprecated) 
-
-### Templated maps
-
-Templated maps are templated [MapConfig]
-(http://github.com/CartoDB/Windshaft/wiki/MapConfig-specification) documents
-associated with an authorization certificate.
-
-The authorization certificate determines who can instanciate the
-template and use the resulting map. Authorized users of the instanciated
-maps will have the same database access privilege of the template owner.
-
-The HTTP endpoints for creating and using templated maps are described [here]
-(http://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps).
-
-*TODO* cleanup the referenced document
-
-### Table maps
-
-Table maps are maps associated with a table.
-Configuration of such maps is limited to the CartoCSS style.
-
- * style - the CartoCSS style for the datasource, can be an array
- * style_version - version of the CartoCSS style, can be an array
-
-You can only fetch PNG or UTF8GRID tiles from these maps.
-
-Access method is the same as the one for [Inline maps](#inline-maps)
-
-# Endpoints description 
-
-- **/api/maps/** (same interface than https://github.com/CartoDB/Windshaft/wiki/Multilayer-API)
-- **/api/maps/named** (same interface than https://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps)
-
-
-NOTE: in case Multilayer-API does not contain this info yet, the
-      endpoint for fetching attributes is this:
-
-- **/api/maps/:map_id/:layer_index/attributes/:feature_id** 
-   - would return { c: 1, d: 2 }
-

docs/Map-API.md

@@ -1,975 +0,0 @@
-## Maps API
-
-The CartoDB Maps API allows you to generate maps based on data hosted in your CartoDB account and you can apply custom SQL and CartoCSS to the data. The API generates a XYZ-based URL to fetch Web Mercator projected tiles using web clients such as [Leaflet](http://leafletjs.com), [Google Maps](https://developers.google.com/maps/), or [OpenLayers](http://openlayers.org/).
-
-You can create two types of maps with the Maps API:
-
-- **Anonymous maps**  
-  You can create maps using your CartoDB public data. Any client can change the read-only SQL and CartoCSS parameters that generate the map tiles. These maps can be created from a JavaScript application alone and no authenticated calls are needed. See [this CartoDB.js example]({{ '/cartodb-platform/cartodb-js.html' | prepend: site.baseurl }}).
-
-- **Named maps**  
-  There are also maps that have access to your private data. These maps require an owner to setup and modify any SQL and CartoCSS parameters and are not modifiable without new setup calls. 
-
-## Quickstart
-
-### Anonymous maps
-
-Here is an example of how to create an anonymous map with JavaScript:
-
-```javascript
-var mapconfig = {
-  "version": "1.3.1",
-  "layers": [{
-    "type": "cartodb",
-    "options": {
-      "cartocss_version": "2.1.1",
-      "cartocss": "#layer { polygon-fill: #FFF; }",
-      "sql": "select * from european_countries_e"
-    }
-  }]
-}
-
-$.ajax({
-  crossOrigin: true,
-  type: 'POST',
-  dataType: 'json',
-  contentType: 'application/json',
-  url: 'https://documentation.cartodb.com/api/v1/map',
-  data: JSON.stringify(mapconfig),
-  success: function(data) {
-    var templateUrl = 'https://documentation.cartodb.com/api/v1/map/' + data.layergroupid + '/{z}/{x}/{y}.png'
-    console.log(templateUrl);
-  }
-})
-```
-
-### Named maps
-
-Let's create a named map using some private tables in a CartoDB account.
-The following map config sets up a map of European countries that have a white fill color:
-
-```javascript
-{
-  "version": "0.0.1",
-  "name": "test",
-  "auth": {
-    "method": "open"
-  },
-  "layergroup": {
-    "layers": [{
-      "type": "mapnik",
-      "options": {
-        "cartocss_version": "2.1.1",
-        "cartocss": "#layer { polygon-fill: #FFF; }",
-        "sql": "select * from european_countries_e"
-      }
-    }]
-  }
-}
-```
-
-The map config needs to be sent to CartoDB's Map API using an authenticated call. Here we will use a command line tool called `curl`. For more info about this tool, see [this blog post](http://quickleft.com/blog/command-line-tutorials-curl), or type ``man curl`` in bash. Using `curl`, and storing the config from above in a file `mapconfig.json`, the call would look like:
-
-<div class="code-title notitle code-request"></div>
-```bash
-curl 'https://{account}.cartodb.com/api/v1/map/named?api_key=APIKEY' -H 'Content-Type: application/json' -d @mapconfig.json
-```
-
-To get the `URL` to fetch the tiles you need to instantiate the map, where `template_id` is the template name from the previous response.
-
-<div class="code-title notitle code-request"></div>
-```bash
-curl -X POST 'https://{account}.cartodb.com/api/v1/map/named/:template_id' -H 'Content-Type: application/json'
-```
-
-The response will return JSON with properties for the `layergroupid`, the timestamp (`last_updated`) of the last data modification and some key/value pairs with `metadata` for the `layers`.
-Note: all `layers` in `metadata` will always have a `type` string and a `meta` dictionary with the key/value pairs.
-
-Here is an example response:
-
-```javascript
-{
-  "layergroupid": "c01a54877c62831bb51720263f91fb33:0",
-  "last_updated": "1970-01-01T00:00:00.000Z",
-  "metadata": {
-    "layers": [
-      {
-        "type": "mapnik",
-        "meta": {}
-      }
-    ]
-  }
-}
-```
-
-You can use the `layergroupid` to instantiate a URL template for accessing tiles on the client. Here we use the `layergroupid` from the example response above in this URL template:
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/{z}/{x}/{y}.png
-```
-
-## General Concepts
-
-The following concepts are the same for every endpoint in the API except when it's noted explicitly.
-
-### Auth
-
-By default, users do not have access to private tables in CartoDB. In order to instantiate a map from private table data an API Key is required. Additionally, to include some endpoints, an API Key must be included (e.g. creating a named map).
-
-To execute an authorized request, `api_key=YOURAPIKEY` should be added to the request URL. The param can be also passed as POST param. Using HTTPS is mandatory when you are performing requests that include your `api_key`.
-
-### Errors
-
-Errors are reported using standard HTTP codes and extended information encoded in JSON with this format:
-
-```javascript
-{
-  "errors": [
-    "access forbidden to table TABLE"
-  ]
-}
-```
-
-If you use JSONP, the 200 HTTP code is always returned so the JavaScript client can receive errors from the JSON object.
-
-### CORS support
-
-All the endpoints, which might be accessed using a web browser, add CORS headers and allow OPTIONS method.
-
-## Anonymous Maps
-
-Anonymous maps allows you to instantiate a map given SQL and CartoCSS. It also allows you to add interaction capabilities using [UTF Grid.](https://github.com/mapbox/utfgrid-spec)
-
-### Instantiate
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```html
-POST /api/v1/map
-```
-
-#### Params
-
-```javascript
-{
-  "version": "1.3.0",
-  "layers": [{
-    "type": "mapnik",
-    "options": {
-      "cartocss_version": "2.1.1", 
-      "cartocss": "#layer { polygon-fill: #FFF; }",
-      "sql": "select * from european_countries_e",
-      "interactivity": ["cartodb_id", "iso3"]
-    }
-  }]
-}
-```
-
-Should be a [Mapconfig](https://github.com/CartoDB/Windshaft/blob/0.44.1/doc/MapConfig-1.3.0.md).
-
-#### Response
-
-The response includes:
-
-- **layergroupid**  
-  The ID for that map, used to compose the URL for the tiles. The final URL is:
-
-  ```html
-  https://{account}.cartodb.com/api/v1/map/:layergroupid/{z}/{x}/{y}.png
-  ```
-
-- **updated_at**  
-  The ISO date of the last time the data involved in the query was updated.
-
-- **metadata**
-  Includes information about the layers.
-  -
-
-- **cdn_url**  
-  URLs to fetch the data using the best CDN for your zone.
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl 'https://documentation.cartodb.com/api/v1/map' -H 'Content-Type: application/json' -d @mapconfig.json
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "layergroupid": "c01a54877c62831bb51720263f91fb33:0",
-  "last_updated": "1970-01-01T00:00:00.000Z",
-  "metadata": {
-    "layers": [
-      {
-        "type": "mapnik",
-        "meta": {}
-      }
-    ]
-  },
-  "cdn_url": {
-    "http": "http://cdb.com",
-    "https": "https://cdb.com"
-  }
-}
-```
-
-##### Retrieve resources from the layergroup
-
-###### Mapnik tiles can be accessed using:
-
-These tiles will get just the mapnik layers. To get individual layers see next section.
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/{z}/{x}/{y}.png
-```
-
-###### Individual layers
-
-The MapConfig specification holds the layers definition in a 0-based index. Layers can be requested individually in different formats depending on the layer type.
-
-Individual layers can be accessed using that 0-based index. For UTF grid tiles:
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/:layer/{z}/{x}/{y}.grid.json
-```
-
-In this case, `:layer` as 0 returns the UTF grid tiles/attributes for layer 0, the only layer in the example MapConfig.
-
-If the MapConfig had a Torque layer at index 1 it could be possible to request it with:
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/1/{z}/{x}/{y}.torque.json
-```
-
-###### Attributes defined in `attributes` section:
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/:layer/attributes/:feature_id
-```
-
-Which returns JSON with the attributes defined, like:
-
-```javascript
-{ "c": 1, "d": 2 }
-```
-
-###### Blending and layer selection
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/:layer_filter/{z}/{x}/{y}.png
-```
-
-Note: currently format is limited to `png`.
-
-`:layer_filter` can be used to select some layers to be rendered together. `:layer_filter` supports two formats:
-
-- `all` alias
-
-Using `all` as `:layer_filter` will blend all layers in the layergroup
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/all/{z}/{x}/{y}.png
-```
-
-- Filter by layer index
-
-A list of comma separated layer indexes can be used to just render a subset of layers. For example `0,3,4` will filter and blend layers with indexes 0, 3, and 4.
-
-```bash
-https://documentation.cartodb.com/api/v1/map/c01a54877c62831bb51720263f91fb33:0/0,3,4/{z}/{x}/{y}.png
-```
-
-Some notes about filtering:
-
-  - Invalid index values or out of bounds indexes will end in `Invalid layer filtering` errors.
-  - Once a mapnik layer is selected, all mapnik layers will get blended. As this may change in the future **it is
-  recommended** to always select all mapnik layers if you want to select at least one so you will get a consistent
-  behavior in the future.
-  - Ordering is not considered. So right now filtering layers 0,3,4 is the very same thing as filtering 3,4,0. As this
-  may change in the future **it is recommended** to always select the layers in ascending order so you will get a
-  consistent behavior in the future.
-
-### Create JSONP
-
-The JSONP endpoint is provided in order to allow web browsers access which don't support CORS.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map?callback=method
-```
-
-#### Params
-
-- **config**
-  Encoded JSON with the params for creating named maps (the variables defined in the template).
-
-- **lmza**  
-  This attribute contains the same as config but LZMA compressed. It cannot be used at the same time as `config`.
-
-- **callback**  
-  JSON callback name.
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl "https://documentation.cartodb.com/api/v1/map?callback=callback&config=%7B%22version%22%3A%221.0.1%22%2C%22layers%22%3A%5B%7B%22type%22%3A%22cartodb%22%2C%22options%22%3A%7B%22sql%22%3A%22select+%2A+from+european_countries_e%22%2C%22cartocss%22%3A%22%23european_countries_e%7B+polygon-fill%3A+%23FF6600%3B+%7D%22%2C%22cartocss_version%22%3A%222.3.0%22%2C%22interactivity%22%3A%5B%22cartodb_id%22%5D%7D%7D%5D%7D"
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-callback({
-    layergroupid: "d9034c133262dfb90285cea26c5c7ad7:0",
-    cdn_url: {
-        "http": "http://cdb.com",
-        "https": "https://cdb.com"
-    },
-    last_updated: "1970-01-01T00:00:00.000Z"
-})
-```
-
-### Remove
-
-Anonymous maps cannot be removed by an API call. They will expire after about five minutes but sometimes longer. If an anonymous map expires and tiles are requested from it, an error will be raised. This could happen if a user leaves a map open and after time, returns to the map and attempts to interact with it in a way that requires new tiles (e.g. zoom). The client will need to go through the steps of creating the map again to fix the problem.
-
-
-## Named Maps
-
-Named maps are essentially the same as anonymous maps except the MapConfig is stored on the server and the map is given a unique name. Two other big differences are: you can create named maps from private data and that users without an API Key can see them even though they are from that private data.
-
-The main two differences compared to anonymous maps are:
-
-- **auth layer**  
-  This allows you to control who is able to see the map based on a token auth
-
-- **templates**  
-  Since the MapConfig is static it can contain some variables so the client can modify the map's appearance using those variables.
-
-Template maps are persistent with no preset expiration. They can only be created or deleted by a CartoDB user with a valid API_KEY (see auth section).
-
-### Create
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```html
-POST /api/v1/map/named
-```
-
-#### Params
-
-- **api_key** is required
-
-<div class="code-title">template.json</div>
-```javascript
-{
-  "version": "0.0.1",
-  "name": "template_name",
-  "auth": {
-    "method": "token",
-    "valid_tokens": [
-      "auth_token1",
-      "auth_token2"
-    ]
-  },
-  "placeholders": {
-    "color": {
-      "type": "css_color",
-      "default": "red"
-    },
-    "cartodb_id": {
-      "type": "number",
-      "default": 1
-    }
-  },
-  "layergroup": {
-    "version": "1.0.1",
-    "layers": [
-      {
-        "type": "cartodb",
-        "options": {
-          "cartocss_version": "2.1.1",
-          "cartocss": "#layer { polygon-fill: <%= color %>; }",
-          "sql": "select * from european_countries_e WHERE cartodb_id = <%= cartodb_id %>"
-        }
-      }
-    ]
-  },
-  "view": {
-    "zoom": 4,
-    "center": {
-      "lng": 0,
-      "lat": 0
-    },
-    "bounds": {
-      "west": -45,
-      "south": -45,
-      "east": 45,
-      "north": 45
-    }
-  }
-}
-```
-
-##### Arguments
-
-- **name**: There can be at most _one_ template with the same name for any user. Valid names start with a letter or a number, and only contain letters, numbers, dashes (-) or underscores (_).
-- **auth**:
-  - **method** `"token"` or `"open"` (the default if no `"method"` is given).
-  - **valid_tokens** when `"method"` is set to `"token"`, the values listed here allow you to instantiate the named map.
-- **placeholders**: Variables not listed here are not substituted. Variables not provided at instantiation time trigger an error. A default is required for optional variables. Type specification is used for quoting, to avoid injections see template format section below.
-- **layergroup**: the layer list definition. This is the MapConfig explained in anonymous maps. See [MapConfig documentation](https://github.com/CartoDB/Windshaft/blob/0.44.1/doc/MapConfig-1.3.0.md) for more info.
-- **view** (optional): extra keys to specify the compelling area for the map. It can be used to have a static preview of a named map without having to instantiate it. It is possible to specify it with `center` + `zoom` or with a bounding box `bbox`. Center+zoom takes precedence over bounding box.
-  - **zoom** The zoom level to use
-  - **center**
-    - **lng** The longitude to use for the center
-    - **lat** The latitude to use for the center
-  - **bounds**
-    - **west**: LowerCorner longitude for the bounding box, in decimal degrees (aka most western)
-    - **south**: LowerCorner latitude for the bounding box, in decimal degrees (aka most southern)
-    - **east**: UpperCorner longitude for the bounding box, in decimal degrees (aka most eastern)
-    - **north**: UpperCorner latitude for the bounding box, in decimal degrees (aka most northern)
-
-#### Template Format
-
-A templated `layergroup` allows the use of placeholders in the "cartocss" and "sql" elements of the "option" object in any "layer" of a `layergroup` configuration
-
-Valid placeholder names start with a letter and can only contain letters, numbers, or underscores. They have to be written between the `<%=` and `%>` strings in order to be replaced.
-
-##### Example
-
-```javascript
-<%= my_color %>
-```
-
-The set of supported placeholders for a template will need to be explicitly defined with a specific type and default value for each.
-
-#### Placeholder Types
-
-The placeholder type will determine the kind of escaping for the associated value. Supported types are:
-
-- **sql_literal** internal single-quotes will be sql-escaped
-- **sql_ident** internal double-quotes will be sql-escaped
-- **number** can only contain numerical representation
-- **css_color** can only contain color names or hex-values
-
-Placeholder default values will be used whenever new values are not provided as options at the time of creation on the client. They can also be used to test the template by creating a default version with new options provided.
-
-When using templates, be very careful about your selections as they can give broad access to your data if they are defined losely.
-
-<div class="code-title code-request with-result">REQUEST</div>
-```html
-curl -X POST \
-   -H 'Content-Type: application/json' \
-   -d @template.json \
-   'https://documentation.cartodb.com/api/v1/map/named?api_key=APIKEY'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "template_id":"name",
-}
-```
-
-### Instantiate
-
-Instantiating a map allows you to get the information needed to fetch tiles. That temporal map is an anonymous map.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```html
-POST /api/v1/map/named/:template_name
-```
-
-#### Param
-
-- **auth_token** optional, but required when `"method"` is set to `"token"`
-
-```javascript
-// params.json
-{
- "color": "#ff0000",
- "cartodb_id": 3
-}
-```
-
-The fields you pass as `params.json` depend on the variables allowed by the named map. If there are variables missing it will raise an error (HTTP 400)
-
-- **auth_token** *optional* if the named map needs auth
-
-#### Example
-
-You can initialize a template map by passing all of the required parameters in a POST to `/api/v1/map/named/:template_name`.
-
-Valid credentials will be needed if required by the template.
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X POST \
-  -H 'Content-Type: application/json' \
-  -d @params.json \
-  'https://documentation.cartodb.com/api/v1/map/named/@template_name?auth_token=AUTH_TOKEN'
-```
-
-<div class="code-title">Response</div>
-```javascript
-{
-  "layergroupid": "docs@fd2861af@c01a54877c62831bb51720263f91fb33:123456788",
-  "last_updated": "2013-11-14T11:20:15.000Z"
-}
-```
-
-<div class="code-title">Error</div>
-```javascript
-{
-  "errors" : ["Some error string here"]
-}
-```
-
-You can then use the `layergroupid` for fetching tiles and grids as you would normally (see anonymous map section).  However you'll need to show the `auth_token`, if required by the template.
-
-### Using JSONP
-
-There is also a special endpoint to be able to initialize a map using JSONP (for old browsers).
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/named/:template_name/jsonp
-```
-
-#### Params
-
-- **auth_token** optional, but required when `"method"` is set to `"token"`
-- **config** Encoded JSON with the params for creating named maps (the variables defined in the template)
-- **lmza** This attribute contains the same as config but LZMA compressed. It cannot be used at the same time than `config`.
-- **callback:** JSON callback name
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl 'https://documentation.cartodb.com/api/v1/map/named/:template_name/jsonp?auth_token=AUTH_TOKEN&callback=callback&config=template_params_json'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-callback({
-  "layergroupid":"c01a54877c62831bb51720263f91fb33:0",
-  "last_updated":"1970-01-01T00:00:00.000Z"
-  "cdn_url": {
-    "http": "http://cdb.com",
-    "https": "https://cdb.com"
-  }
-})
-```
-
-This takes the `callback` function (required), `auth_token` if the template needs auth, and `config` which is the variable for the template (in cases where it has variables). 
-
-```javascript
-url += "config=" + encodeURIComponent(
-JSON.stringify({ color: 'red' });
-```
-
-The response is in this format:
-
-```javascript
-callback({
-  layergroupid: "dev@744bd0ed9b047f953fae673d56a47b4d:1390844463021.1401",
-  last_updated: "2014-01-27T17:41:03.021Z"
-})
-```
-
-### Update
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-PUT /api/v1/map/named/:template_name
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Response
-
-Same as updating a map.
-
-#### Other Info
-
-Updating a named map removes all the named map instances so they need to be initialized again.
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X PUT \
-  -H 'Content-Type: application/json' \
-  -d @template.json \
-  'https://documentation.cartodb.com/api/v1/map/named/:template_name?api_key=APIKEY'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "template_id": "@template_name"
-}
-```
-
-If any template has the same name, it will be updated.
-
-If a template with the same name does NOT exist, a 400 HTTP response is generated with an error in this format:
-
-```javascript
-{
-  "errors" : ["error string here"]
-}
-```
-
-### Delete 
-
-Delete the specified template map from the server and it disables any previously initialized versions of the map.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-DELETE /api/v1/map/named/:template_name
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Example
-
-<div class="code-title code-request">REQUEST</div>
-```bash
-curl -X DELETE 'https://documentation.cartodb.com/api/v1/map/named/:template_name?api_key=APIKEY'
-```
-
-<div class="code-title">RESPONSE</div>
-```javascript
-{
-  "errors" : ["Some error string here"]
-}
-```
-
-On success, a 204 (No Content) response will be issued. Otherwise a 4xx response with an error will be returned.
-
-### Listing Available Templates
-
-This allows you to get a list of all available templates. 
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/named/
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X GET 'https://documentation.cartodb.com/api/v1/map/named?api_key=APIKEY'
-```
-
-<div class="code-title with-result">RESPONSE</div>
-```javascript
-{
-   "template_ids": ["@template_name1","@template_name2"]
-}
-```
-
-<div class="code-title">ERROR</div>
-```javascript
-{
-   "errors" : ["Some error string here"]
-}
-```
-
-### Getting a Specific Template
-
-This gets the definition of a template.
-
-#### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/named/:template_name
-```
-
-#### Params
-
-- **api_key** is required
-
-#### Example
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
-curl -X GET 'https://documentation.cartodb.com/api/v1/map/named/:template_name?api_key=APIKEY'
-```
-
-<div class="code-title with-result">RESPONSE</div>
-```javascript
-{
-  "template": {...} // see template.json above
-}
-```
-
-<div class="code-title">ERROR</div>
-```javascript
-{
-  "errors" : ["Some error string here"]
-}
-```
-
-### Use with CartoDB.js
-Named maps can be used with CartoDB.js by specifying a named map in a layer source as follows. Named maps are treated almost the same as other layer source types in most other ways.
-
-```js
-var layerSource = {
-  user_name: '{your_user_name}', 
-  type: 'namedmap', 
-  named_map: { 
-    name: '{template_name}', 
-	layers: [{ 
-	  layer_name: "layer1", 
-      interactivity: "column1, column2, ..." 
-	}] 
-  } 
-}
-
-cartodb.createLayer('map_dom_id',layerSource)
-  .addTo(map_object);
-
-```
-
-[CartoDB.js](http://docs.cartodb.com/cartodb-platform/cartodb-js.html) has methods for accessing your named maps.
-
-1. [layer.setParams()](http://docs.cartodb.com/cartodb-platform/cartodb-js.html#layersetparamskey-value) allows you to change the template variables (in the placeholders object) via JavaScript 
-2. [layer.setAuthToken()](http://docs.cartodb.com/cartodb-platform/cartodb-js.html#layersetauthtokenauthtoken) allows you to set the auth tokens to create the layer
-
-## Static Maps API
-
-The Static Maps API can be initiated using both named and anonymous maps using the 'layergroupid' token. The API can be used to create static images of parts of maps and thumbnails for use in web design, graphic design, print, field work, and many other applications that require standard image formats.
-
-### Maps API endpoints
-
-Begin by instantiating either a named or anonymous map using the `layergroupid token` as demonstrated in the Maps API documentation above. The `layergroupid` token calls to the map and allows for parameters in the definition to generate static images.
-
-#### Zoom + center
-
-##### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/static/center/:token/:z/:lat/:lng/:width/:height.:format
-```
-
-##### Params
-
-* **:token**: the layergroupid token from the map instantiation
-* **:z**: the zoom level of the map
-* **:lat**: the latitude for the center of the map
-* **:lng**: the longitude for the center of the map
-* **:width**: the width in pixels for the output image
-* **:height**: the height in pixels for the output image
-* **:format**: the format for the image, supported types: `png`, `jpg`
-  * **jpg** will have a default quality of 85.
-
-#### Bounding Box
-
-##### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/static/bbox/:token/:bbox/:width/:height.:format`
-```
-
-##### Params
-
-* **:token**: the layergroupid token from the map instantiation
-* **:bbox**: the bounding box in WGS 84 (EPSG:4326), comma separated values for:
-    - LowerCorner longitude, in decimal degrees (aka most western)
-    - LowerCorner latitude, in decimal degrees (aka most southern)
-    - UpperCorner longitude, in decimal degrees (aka most eastern)
-    - UpperCorner latitude, in decimal degrees (aka most northern)
-* **:width**: the width in pixels for the output image
-* **:height**: the height in pixels for the output image
-* **:format**: the format for the image, supported types: `png`, `jpg`
-  * **jpg** will have a default quality of 85.
-
-Note: you can see this endpoint as:
-
-```bash
-GET /api/v1/map/static/bbox/:token/:west,:south,:east,:north/:width/:height.:format`
-```
-
-#### Named map
-
-##### Definition
-
-<div class="code-title notitle code-request"></div>
-```bash
-GET /api/v1/map/static/named/:name/:width/:height.:format
-```
-
-##### Params
-
-* **:name**: the name of the named map
-* **:width**: the width in pixels for the output image
-* **:height**: the height in pixels for the output image
-* **:format**: the format for the image, supported types: `png`, `jpg`
-  * **jpg** will have a default quality of 85.
-
-A named maps static image will get its constraints from the [view in the template](#Arguments), if `view` is not present it will estimate the extent based on the involved tables otherwise it fallback to `"zoom": 1`, `"lng": 0` and `"lat": 0`.
-
-####Layers
-
-The Static Maps API allows for multiple layers of incorporation into the `MapConfig` to allow for maximum versatility in creating a static map. The examples below were used to generate the static image example in the next section, and appear in the specific order designated.
-
-**Basemaps**
-
-```javascript
-    {
-      "type": "http",
-      "options": {
-        "urlTemplate": "http://{s}.basemaps.cartocdn.com/dark_nolabels/{z}/{x}/{y}.png",
-        "subdomains": [
-          "a",
-          "b",
-          "c"
-        ]
-      }
-    },
-```
-
-By manipulating the `"urlTemplate"` custom basemaps can be used in generating static images. Supported map types for the Static Maps API are:
-
-          'http://{s}.basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png',
-          'http://{s}.basemaps.cartocdn.com/dark_nolabels/{z}/{x}/{y}.png',
-          'http://{s}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}.png',
-          'http://{s}.basemaps.cartocdn.com/light_nolabels/{z}/{x}/{y}.png',
-
-**Mapnik**
-
-```javascript
-    {
-      "type": "mapnik",
-      "options": {
-        "sql": "select null::geometry the_geom_webmercator",
-        "cartocss": "#layer {\n\tpolygon-fill: #FF3300;\n\tpolygon-opacity: 0;\n\tline-color: #333;\n\tline-width: 0;\n\tline-opacity: 0;\n}",
-        "cartocss_version": "2.2.0"
-      }
-    },
-```
-
-**CartoDB**
-
-```javascript
-    {
-      "type": "cartodb",
-      "options": {
-        "sql": "select * from park",
-        "cartocss": "/** simple visualization */\n\n#park{\n  polygon-fill: #229A00;\n  polygon-opacity: 0.7;\n  line-color: #FFF;\n  line-width: 0;\n  line-opacity: 1;\n}",
-        "cartocss_version": "2.1.1"
-      }
-    },
-```
-
-Additionally, static images from Torque maps and other map layers can be used together to generate highly customizable and versatile static maps.
-
-
-#### Caching
-
-It is important to note that generated images are cached from the live data referenced with the `layergroupid token` on the specified CartoDB account. This means that if the data changes, the cached image will also change. When linking dynamically, it is important to take into consideration the state of the data and longevity of the static image to avoid broken images or changes in how the image is displayed. To obtain a static snapshot of the map as it is today and preserve the image long-term regardless of changes in data, the image must be saved and stored locally.
-
-#### Limits
-
-* While images can encompass an entirety of a map, the default limit for pixel range is 8192 x 8192.
-* Image resolution by default is set to 72 DPI
-* JPEG quality by default is 85% 
-* Timeout limits for generating static maps are the same across the CartoDB Editor and Platform. It is important to ensure timely processing of queries.
-
-
-### Examples
-
-After instantiating a map from a CartoDB account:
-
-<div class="code-title code-request with-result">REQUEST</div>
-```bash
- GET /api/v1/map/static/center/4b615ff367e498e770e7d05e99181873:1420231989550.8699/14/40.71502926732618/-73.96039009094238/600/400.png
-```
-
-#### Response
-
-<p class="wrap-border"><img src="https://raw.githubusercontent.com/namessanti/Pictures/master/static_api.png" alt="static-api"/></p>
-
-#### MapConfig
-
-For this map, the multiple layers, order, and stylings are defined by the MapConfig.
-
-```javascript
-{
-  "version": "1.3.0",
-  "layers": [
-    {
-      "type": "http",
-      "options": {
-        "urlTemplate": "http://{s}.basemaps.cartocdn.com/dark_nolabels/{z}/{x}/{y}.png",
-        "subdomains": [
-          "a",
-          "b",
-          "c"
-        ]
-      }
-    },
-    {
-      "type": "mapnik",
-      "options": {
-        "sql": "select null::geometry the_geom_webmercator",
-        "cartocss": "#layer {\n\tpolygon-fill: #FF3300;\n\tpolygon-opacity: 0;\n\tline-color: #333;\n\tline-width: 0;\n\tline-opacity: 0;\n}",
-        "cartocss_version": "2.2.0"
-      }
-    },
-    {
-      "type": "cartodb",
-      "options": {
-        "sql": "select * from park",
-        "cartocss": "/** simple visualization */\n\n#park{\n  polygon-fill: #229A00;\n  polygon-opacity: 0.7;\n  line-color: #FFF;\n  line-width: 0;\n  line-opacity: 1;\n}",
-        "cartocss_version": "2.1.1"
-      }
-    },
-    {
-      "type": "cartodb",
-      "options": {
-        "sql": "select * from residential_zoning_2009",
-        "cartocss": "/** simple visualization */\n\n#residential_zoning_2009{\n  polygon-fill: #c7eae5;\n  polygon-opacity: 1;\n  line-color: #FFF;\n  line-width: 0.2;\n  line-opacity: 0.5;\n}",
-        "cartocss_version": "2.1.1"
-      }
-    },
-    {
-      "type": "cartodb",
-      "options": {
-        "sql": "select * from nycha_developments_july2011",
-        "cartocss": "/** simple visualization */\n\n#nycha_developments_july2011{\n  polygon-fill: #ef3b2c;\n  polygon-opacity: 0.7;\n  line-color: #FFF;\n  line-width: 0;\n  line-opacity: 1;\n}",
-        "cartocss_version": "2.1.1"
-      }
-    }
-  ]
-}
-```

docs/MapConfig-NamedMaps-extension.md

@@ -1,56 +0,0 @@
-# 1. Purpose
-
-This specification describes an extension for
-[MapConfig 1.3.0](https://github.com/CartoDB/Windshaft/blob/master/doc/MapConfig-1.3.0.md) version.
-
-
-# 2. Changes over specification
-
-This extension introduces a new layer type so it's possible to use a named map by its name as a layer.
-
-## 2.1 Named layers definition
-
-```javascript
-{
-    // REQUIRED
-    // string, `named` is the only supported value
-    type: "named",
-
-    // REQUIRED
-    // object, set `named` map layers configuration
-    options: {
-
-        // REQUIRED
-        // string, the name for the named map to use
-        name: "world_borders",
-
-        // OPTIONAL
-        // object, the replacement values for the named map's template placeholders
-        // See https://github.com/CartoDB/Windshaft-cartodb/blob/master/docs/Map-API.md#instantiate-1 for more details
-        config: {
-            "color": "#000"
-        },
-
-        // OPTIONAL
-        // string array, the authorized tokens in case the named map has auth method set to `token`
-        // See https://github.com/CartoDB/Windshaft-cartodb/blob/master/docs/Map-API.md#named-maps-1 for more details
-        auth_tokens: [
-            "token1",
-            "token2"
-        ]
-    }
-}
-```
-
-## 2.2 Limitations
-
-1. A Named Map will not allow to have `named` type layers inside their templates layergroup's layers definition.
-2. A `named` layer does not allow Named Maps form other accounts, it's only possible to use Named Maps from the very
-same user account.
-
-
-# History
-
-## 1.0.0
-
- - Initial version

docs/MultiLayer-API.md

@@ -1,28 +0,0 @@
-The Windshaft-CartoDB MultiLayer API extends the [Windshaft MultiLayer API](https://github.com/CartoDB/Windshaft/blob/master/doc/Multilayer-API.md) in a few ways.
-
-## Last modification timestamp embedded in the token
-
-It encodes a timestamp of 'last modification time' into the map token (token:EPOCH) returned to the client.
-It accepts tokens with encoded timestamp from the client considering the token suffix as a cache_buster value.
-
-Clients don't need to be aware of the extension but rather use the API as they would use the base one.
-The only difference will be that the _same_ layergroup configuration may result in different tokens if source data was modified between the mapview requests. 
-
-## Additional attributes in the response object
-
-Windshaft-CartoDB adds the following attributes in the response object
-
-- ``last_update`` field with ISO format (2013-11-30T12:23:10).
-- ``cdn_url`` object containing CDN url client should use (not mandatory) to access the tiles. It's in the form:
-
-   ```json
-   {
-     http: 'http://cdn_url.com/'
-     https: 'https://secure.cdn_url.com/'
-   }
-   ```
-
-
-## Stats tag
-
-Windshaft-CartoDB adds support for a ``stat_tag`` element in the multilayer configuration to help [stats](https://github.com/CartoDB/Windshaft-cartodb/wiki/Redis-stats-format) gathering.

docs/Routes.md

@@ -1,104 +0,0 @@
-This document list all routes available in Windshaft-cartodb Maps API server.
-
-## Routes list
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)/:token/:z/:x/:y@:scale_factor?x.:format {:user(f),:token(f),:z(f),:x(f),:y(f),:scale_factor(t),:format(f)} (1)`
-<br/>Notes: Mapnik retina tiles [0]
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)/:token/:z/:x/:y.:format {:user(f),:token(f),:z(f),:x(f),:y(f),:format(f)} (1)`
-<br/>Notes: Mapnik tiles [0]
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)/:token/:layer/:z/:x/:y.(:format) {:user(f),:token(f),:layer(f),:z(f),:x(f),:y(f),:format(f)} (1)`
-<br/>Notes: Per :layer rendering based on :format [0]
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup) {:user(f)} (1)`
-<br/>Notes: Map instantiation [0]
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)/:token/:layer/attributes/:fid {:user(f),:token(f),:layer(f),:fid(f)} (1)`
-<br/>Notes: Endpoint for info windows data, alternative for sql api when tables are private [0]
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)/static/center/:token/:z/:lat/:lng/:width/:height.:format {:user(f),:token(f),:z(f),:lat(f),:lng(f),:width(f),:height(f),:format(f)} (1)`
-<br/>Notes: Static Maps API [0]
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)/static/bbox/:token/:west,:south,:east,:north/:width/:height.:format {:user(f),:token(f),:west(f),:south(f),:east(f),:north(f),:width(f),:height(f),:format(f)} (1)`
-<br/>Notes: Static Maps API [0]
-
-1. `GET / {} (1)`
-<br/>Notes: Welcome message
-
-1. `GET /version {} (1)`
-<br/>Notes: Return relevant module versions: mapnik, grainstore, etc
-
-1. `GET (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)/:template_id/jsonp {:user(f),:template_id(f)} (1)`
-<br/>Notes: Named maps JSONP instantiation [1]
-
-1. `GET (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)/:template_id {:user(f),:template_id(f)} (1)`
-<br/>Notes: Named map retrieval (w/ API KEY) [1]
-
-1. `GET (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template) {:user(f)} (1)`
-<br/>Notes: List named maps (w/ API KEY) [1]
-
-1. `GET (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup)/static/named/:template_id/:width/:height.:format {:user(f),:template_id(f),:width(f),:height(f),:format(f)} (1)`
-<br/>Notes: Static map for named maps
-
-1. `GET /health {} (1)`
-<br/>Notes: Healt check
-
-1. `OPTIONS (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup) {:user(f)} (1)`
-<br/>Notes: CORS [0]
-
-1. `OPTIONS (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)/:template_id {:user(f),:template_id(f)} (1)`
-<br/>Notes: CORS [1]
-
-1. `POST (?:/api/v1/map|/user/:user/api/v1/map|/tiles/layergroup) {:user(f)} (1)`
-<br/>Notes: Map instantiation [0]
-
-1. `POST (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template) {:user(f)} (1)`
-<br/>Notes: Create named map (w/ API KEY) [1]
-
-1. `POST (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)/:template_id {:user(f),:template_id(f)} (1)`
-<br/>Notes: Instantiate named map [1]
-
-1. `PUT (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)/:template_id {:user(f),:template_id(f)} (1)`
-<br/>Notes: Update a named map (w/ API KEY) [1]
-
-1. `DELETE (?:/api/v1/map/named|/user/:user/api/v1/map/named|/tiles/template)/:template_id {:user(f),:template_id(f)} (1)`
-<br/>Notes: Delete named map (w/ API KEY) [1]
-
-## Optional deprecated routes
-
-- [0] `/tiles/layergroup` is deprecated and `/api/v1/map` should be used but we keep it for now.
-- [1] `/tiles/template` is deprecated and `/api/v1/map/named` should be used but we keep it for now.
-
-## How to generate the list of routes
-
-Something like the following patch should do the trick
-
-```javascript
-diff --git a/lib/cartodb/cartodb_windshaft.js b/lib/cartodb/cartodb_windshaft.js
-index b9429a2..e6cc5f9 100644
---- a/lib/cartodb/cartodb_windshaft.js
-+++ b/lib/cartodb/cartodb_windshaft.js
-@@ -212,6 +212,20 @@ var CartodbWindshaft = function(serverOptions) {
-         }
-     });
-
-+    var format = require('util').format;
-+    var routesNotes = Object.keys(ws.routes.routes)
-+        .map(function(method) { return ws.routes.routes[method]; })
-+        .reduce(function(previous, current) { current.map(function(r) { previous.push(r) }); return previous;}, [])
-+        .map(function(route) {
-+            return format("\n1. `%s %s {%s} (%d)`\n<br/>Notes: [DEPRECATED]? ",
-+                route.method.toUpperCase(),
-+                route.path,
-+                route.keys.map(function(k) { return format(':%s(%s)', k.name, k.optional ? 't' : 'f'); } ).join(','),
-+                route.callbacks.length
-+            );
-+        });
-+    console.log(routesNotes.join('\n'));
-+
-     return ws;
- };
-
-
-```

docs/Template-maps.md

@@ -1,272 +0,0 @@
-Template maps are layergroup configurations that rather than being
-fully defined contain variables that can be set to produce a different
-layergroup configurations (instantiation).
-
-Template maps are persistent, can only be created and deleted by the
-CartoDB user showing a valid API_KEY.
-
-
-# Template format
-
-A templated layergroup would allow using placeholders
-in the "cartocss" and "sql" elements in the "option"
-field of any "layer" of a layergroup configuration
-(see https://github.com/CartoDB/Windshaft/wiki/MapConfig-specification).
-
-Valid placeholder names start with a letter and can only
-contain letters, numbers or underscores. They have to be
-written between ``<%= `` and `` %>`` strings in order to be 
-replaced. Example: ``<%= my_color %>``.
-
-The set of supported placeholders for a template will need to be
-explicitly defined specifying type and default value for each.
-
-**placeholder types**
-
-Placeholder type will determine the kind of escaping for the
-associated value. Supported types are:
-
- * sql_literal (internal single-quotes will be sql-escaped)
- * sql_ident (internal double-quotes will be sql-escaped)
- * number (can only contain numerical representation)
- * css_color (can only contain color names or hex-values)
- * ... (add more as need arises)
-
-Placeholder default value will be used when not provided at
-instantiation time and could be used to test validity of the
-template by creating a default instance.
-
-```js
-// template.json 
-{
-  version: "0.0.1",
-  // there can be at most 1 template with the same name for any user 
-  // valid names start with a letter and only contains letter, numbers
-  // or underscores
-  name: "template_name", 
-  // embedded authorization certificate
-  auth: {
-   method: "token", // or "open" (the default if no "method" is given)
-   // only (required and non empty) for "token" method
-   valid_tokens: ["auth_token1","auth_token2"]
-  },
-  // Variables not listed here are not substituted
-  // Variable not provided at instantiation time trigger an error
-  // A default is required for optional variables
-  // Type specification is used for quoting, to avoid injections
-  placeholders: {
-      color: {
-        type:"css_color",
-        default:"red"
-      },
-      cartodb_id: {
-        type:"number",
-        default: 1
-      }
-  },
-  layergroup: {
-   // see https://github.com/CartoDB/Windshaft/wiki/MapConfig-specification
-   "version": "1.0.1",
-   "layers": [{
-    "type": "cartodb",
-    "options": {
-      "cartocss_version": "2.1.1", 
-      "cartocss": "#layer { polygon-fill: <%= color %>; }",
-      "sql": "select * from european_countries_e WHERE cartodb_id = <%= cartodb_id %>"
-    }
-   }]
-  } 
-}
-```
-
-# Creating a templated map
-
-You can create a template map with a single call (for simplicity).
-
-You'd use a POST sending JSON data:
-
-```sh
-curl -X POST \
-   -H 'Content-Type: application/json' \
-   -d @template.json \
-   'https://docs.cartodb.com/tiles/template?api_key=APIKEY'
-```
-
-The response would be like this:
-```js
-{
-   "template_id":"@template_name"
-}
-```
-
-If a template with the same name exists in the user storage,
-a 400 response is generated.
-
-Errors are in this form:
-```js
-{
-   "error":"Some error string here"
-}
-```
-
-# Updating an existing template
-
-You can update a template map with a PUT:
-
-```sh
-curl -X PUT \
-   -H 'Content-Type: application/json' \
-   -d @template.json \
-   'https://docs.cartodb.com/tiles/template/:template_name?api_key=APIKEY'
-```
-A template with the same name will be updated, if any.
-
-The response would be like this:
-```js
-{
-   "template_id":"@template_name"
-}
-```
-
-If a template with the same name does NOT exist,
-a 400 HTTP response is generated with an error in this format:
-
-```js
-{
-   "error":"Some error string here"
-}
-```
-
-
-# Listing available templates
-
-You can get a list of available templates with a GET to ``/template``.
-A valid api_key is required.
-
-```sh
-curl -X GET 'https://docs.cartodb.com/tiles/template?api_key=APIKEY'
-```
-
-The response would be like this:
-```js
-{
-   "template_ids": ["@template_name1","@template_name2"]
-}
-```
-
-Or, on error:
-
-```js
-{
-   "error":"Some error string here"
-}
-```
-
-# Getting a specific template
-
-You can get the definition of a template with a
-GET to ``/template/:template_name``.
-A valid api_key is required.
-
-Example:
-
-```sh
-curl -X GET 'https://docs.cartodb.com/tiles/template/@template_name?auth_token=AUTH_TOKEN'
-```
-
-The response would be like this:
-```js
-{
-   "template": {...}  // see template.json above
-}
-```
-
-Or, on error:
-
-```js
-{
-   "error":"Some error string here"
-}
-```
-
-# Instantiating a template map
-
-You can instantiate a template map passing all required parameters with
-a POST to ``/template/:template_name``.
-
-Valid credentials will be needed, if required by the template.
-
-```js
-// params.js
-{
- color: '#ff0000',
- cartodb_id: 3
-}
-```
-
-```sh
-curl -X POST \
-  -H 'Content-Type: application/json' \
-  -d @params.js \
-  'https://docs.cartodb.com/tiles/template/@template_name?auth_token=AUTH_TOKEN'
-
-```
-
-The response would be like this:
-```js
-{
-   "layergroupid":"docs@fd2861af@c01a54877c62831bb51720263f91fb33:123456788",
-   "last_updated":"2013-11-14T11:20:15.000Z"
-}
-```
-
-or, on error:
-
-```js
-{
-   "error":"Some error string here"
-}
-```
-
-You can then use the ``layergroupid`` for fetching tiles and grids as you do
-normally ( see https://github.com/CartoDB/Windshaft/wiki/Multilayer-API).
-But you'll still have to show the ``auth_token``, if required by the template.
-
-### using JSONP
-There is also a special endpoint to be able to instanciate using JSONP (for old browsers)
-
-```
-curl 'https://docs.cartodb.com/tiles/template/@template_name/jsonp?auth_token=AUTH_TOKEN&callback=function_name&config=template_params_json'
-```
-
-it takes the ``callback`` function (required), ``auth_token`` in case the template needs auth and ``config`` which is the variabñes for the template (in case it has variables). For example config may be created (using javascript)
-```
-url += "config=" + encodeURIComponent(
-JSON.stringify({ color: 'red' });
-```
-
-the response it's in this format:
-```
-jQuery17205720721024554223_1390996319118(
-{
-layergroupid: "dev@744bd0ed9b047f953fae673d56a47b4d:1390844463021.1401",
-last_updated: "2014-01-27T17:41:03.021Z"
-}
-)
-```
-# Deleting a template map
-
-You can delete a templated map with a DELETE to ``/template/:template_name``:
-
-```sh
-curl -X DELETE 'https://docs.cartodb.com/tiles/template/@template_name?auth_token=AUTH_TOKEN'
-```
-
-On success, a 204 (No Content) response would be issued.
-Otherwise a 4xx response with this format:
-
-```js
-{
-   "error":"Some error string here"
-}
-```

docs/metrics.md

@@ -1,42 +0,0 @@
-Windshaft-cartodb metrics
-=========================
-See [Windshaft metrics documentation](https://github.com/CartoDB/Windshaft/blob/master/doc/metrics.md) to understand the full picture.
-
-The next list includes the API endpoints, each endpoint may have several inner timers, some of them are displayed within this list as subitems. Find the description for them in the Inner timers section.
-## Timers
-- **windshaft-cartodb.flush_cache**: time to flush the tile and sql cache
-- **windshaft-cartodb.get_template**: time to retrieve an specific template
-- **windshaft-cartodb.delete_template**: time to delete an specific template
-- **windshaft-cartodb.get_template_list**: time to retrieve the list of owned templates
-- **windshaft-cartodb.instance_template_post**: time to create a template via HTTP POST
-- **windshaft-cartodb.instance_template_get**: time to create a template via HTTP GET
-    + TemplateMaps_instance
-    + createLayergroup
-
-There are some endpoints that are not being tracked:
-- Adding a template
-- Updating a template
-
-### Inner timers
-Again, each inner timer may have several inner timers.
-
-- **addCacheChannel**: time to add X-Cache-Channel header based on table last modifications
-- **LZMA decompress**: time to decompress request params with LZMA
-- **TemplateMaps_instance**: time to retrieve a map template instance, see *getTemplate* and *authorizedByCert*
-- **affectedTables**: time to check what are the affected tables for adding the cache channel, see *addCacheChannel*
-- **authorize**: time to authorize a request, see *authorizedByAPIKey*, *authorizedByCert*, *authorizedBySigner*
-- **authorizedByCert**: time to authorize a template instantiation
-- **findLastUpdated**: time to retrieve the last update time for a list of tables, see *affectedTables*
-- **generateCacheChannel**: time to generate the headers for the cache channel based on the request, see *addCacheChannel*
-- **getSignerMapKey**: time to retrieve from redis the authorized user for a template map
-- **getTablePrivacy**: time to retrieve from redis the privacy of a table
-- **getTemplate**: time to retrieve from redis the template for a map
-- **getUserMapKey**: time to retrieve from redis the user key for a map
-- **incMapviewCount**: time to incremenent in redis the map views
-- **mapStore_load**: time to retrieve from redis a map configuration
-- **req2params.setup**: time to prepare the params from a request, see *req2params* in Windshaft documentation
-- **setDBAuth**: time to retrieve from redis and set db user and db password from a user
-- **setDBConn**: time to retrieve from redis and set db host and db name from a user
-- **setDBParams**: time to prepare all db params to be able to connect/query a database, see *setDBAuth* and *setDBConn*
-- **tablePrivacy_getUserDBName**: time to retrieve from redis the database for a user
-

lib/cartodb/api/query_tables_api.js

@@ -1,75 +0,0 @@
-function QueryTablesApi(pgQueryRunner) {
-    this.pgQueryRunner = pgQueryRunner;
-}
-
-var affectedTableRegexCache = {
-    bbox: /!bbox!/g,
-    scale_denominator: /!scale_denominator!/g,
-    pixel_width: /!pixel_width!/g,
-    pixel_height: /!pixel_height!/g
-};
-
-module.exports = QueryTablesApi;
-
-
-QueryTablesApi.prototype.getAffectedTablesInQuery = function (username, sql, callback) {
-
-    var query = 'SELECT CDB_QueryTables($windshaft$' + prepareSql(sql) + '$windshaft$)';
-
-    this.pgQueryRunner.run(username, query, handleAffectedTablesInQueryRows, callback);
-};
-
-function handleAffectedTablesInQueryRows(err, rows, callback) {
-    if (err){
-        var msg = err.message ? err.message : err;
-        callback(new Error('could not fetch source tables: ' + msg));
-        return;
-    }
-    var qtables = rows[0].cdb_querytables;
-    var tableNames = qtables.split(/^\{(.*)\}$/)[1];
-    tableNames = tableNames ? tableNames.split(',') : [];
-    callback(null, tableNames);
-}
-
-QueryTablesApi.prototype.getAffectedTablesAndLastUpdatedTime = function (username, sql, callback) {
-
-    var query = [
-        'WITH querytables AS (',
-            'SELECT * FROM CDB_QueryTables($windshaft$' + prepareSql(sql) + '$windshaft$) as tablenames',
-        ')',
-        'SELECT (SELECT tablenames FROM querytables), EXTRACT(EPOCH FROM max(updated_at)) as max',
-        'FROM CDB_TableMetadata m',
-        'WHERE m.tabname = any ((SELECT tablenames from querytables)::regclass[])'
-    ].join(' ');
-
-    this.pgQueryRunner.run(username, query, handleAffectedTablesAndLastUpdatedTimeRows, callback);
-};
-
-function handleAffectedTablesAndLastUpdatedTimeRows(err, rows, callback) {
-    if (err || rows.length === 0) {
-        var msg = err.message ? err.message : err;
-        callback(new Error('could not fetch affected tables and last updated time: ' + msg));
-        return;
-    }
-
-    var result = rows[0];
-
-    var tableNames = result.tablenames.split(/^\{(.*)\}$/)[1];
-    tableNames = tableNames ? tableNames.split(',') : [];
-
-    var lastUpdatedTime = result.max || 0;
-
-    callback(null, {
-        affectedTables: tableNames,
-        lastUpdatedTime: lastUpdatedTime * 1000
-    });
-}
-
-function prepareSql(sql) {
-    return sql
-        .replace(affectedTableRegexCache.bbox, 'ST_MakeEnvelope(0,0,0,0)')
-        .replace(affectedTableRegexCache.scale_denominator, '0')
-        .replace(affectedTableRegexCache.pixel_width, '1')
-        .replace(affectedTableRegexCache.pixel_height, '1')
-    ;
-}

lib/cartodb/api/tables_extent_api.js

@@ -1,54 +0,0 @@
-function TablesExtentApi(pgQueryRunner) {
-    this.pgQueryRunner = pgQueryRunner;
-}
-
-module.exports = TablesExtentApi;
-
-/**
- * Given a username and a list of tables it will return the estimated extent in SRID 4326 for all the tables based on
- * the_geom_webmercator (SRID 3857) column.
- *
- * @param {String} username
- * @param {Array} tableNames The named can be schema qualified, so this accepts both `schema_name.table_name` and
- *  `table_name` format as valid input
- * @param {Function} callback function(err, result) {Object} result with `west`, `south`, `east`, `north`
- */
-TablesExtentApi.prototype.getBounds = function (username, tableNames, callback) {
-    var estimatedExtentSQLs = tableNames.map(function(tableName) {
-        var schemaTable = tableName.split('.');
-        if (schemaTable.length > 1) {
-            return "ST_EstimatedExtent('" + schemaTable[0] + "', '" + schemaTable[1] + "', 'the_geom_webmercator')";
-        }
-        return "ST_EstimatedExtent('" + schemaTable[0] + "', 'the_geom_webmercator')";
-    });
-
-    var query = [
-        "WITH ext as (" +
-            "SELECT ST_Transform(ST_SetSRID(ST_Extent(ST_Union(ARRAY[",
-                estimatedExtentSQLs.join(','),
-            "])), 3857), 4326) geom)",
-        "SELECT",
-            "ST_XMin(geom) west,",
-            "ST_YMin(geom) south,",
-            "ST_XMax(geom) east,",
-            "ST_YMax(geom) north",
-        "FROM ext"
-    ].join(' ');
-
-    this.pgQueryRunner.run(username, query, handleBoundsResult, callback);
-};
-
-function handleBoundsResult(err, rows, callback) {
-    if (err){
-        var msg = err.message ? err.message : err;
-        callback(new Error('could not fetch source tables: ' + msg));
-        return;
-    }
-    var result = null;
-    if (rows.length > 0) {
-        result = {
-            bounds: rows[0]
-        };
-    }
-    callback(null, result);
-}

lib/cartodb/backends/pg_connection.js

@@ -1,96 +0,0 @@
-var step = require('step');
-var _ = require('underscore');
-
-function PgConnection(metadataBackend) {
-    this.metadataBackend = metadataBackend;
-}
-
-module.exports = PgConnection;
-
-
-// Set db authentication parameters to those of the given username
-//
-// @param username the cartodb username, mapped to a database username
-//                 via CartodbRedis metadata records
-//
-// @param params the parameters to set auth options into
-//               added params are: "dbuser" and "dbpassword"
-//
-// @param callback function(err)
-//
-PgConnection.prototype.setDBAuth = function(username, params, callback) {
-    var self = this;
-
-    var user_params = {};
-    var auth_user = global.environment.postgres_auth_user;
-    var auth_pass = global.environment.postgres_auth_pass;
-    step(
-        function getId() {
-            self.metadataBackend.getUserId(username, this);
-        },
-        function(err, user_id) {
-            if (err) throw err;
-            user_params.user_id = user_id;
-            var dbuser = _.template(auth_user, user_params);
-            _.extend(params, {dbuser:dbuser});
-
-            // skip looking up user_password if postgres_auth_pass
-            // doesn't contain the "user_password" label
-            if (!auth_pass || ! auth_pass.match(/\buser_password\b/) ) return null;
-
-            self.metadataBackend.getUserDBPass(username, this);
-        },
-        function(err, user_password) {
-            if (err) throw err;
-            user_params.user_password = user_password;
-            if ( auth_pass ) {
-                var dbpass = _.template(auth_pass, user_params);
-                _.extend(params, {dbpassword:dbpass});
-            }
-            return true;
-        },
-        function finish(err) {
-            callback(err);
-        }
-    );
-};
-
-// Set db connection parameters to those for the given username
-//
-// @param dbowner cartodb username of database owner,
-//                mapped to a database username
-//                via CartodbRedis metadata records
-//
-// @param params the parameters to set connection options into
-//               added params are: "dbname", "dbhost"
-//
-// @param callback function(err)
-//
-PgConnection.prototype.setDBConn = function(dbowner, params, callback) {
-    var self = this;
-    // Add default database connection parameters
-    // if none given
-    _.defaults(params, {
-        dbuser: global.environment.postgres.user,
-        dbpassword: global.environment.postgres.password,
-        dbhost: global.environment.postgres.host,
-        dbport: global.environment.postgres.port
-    });
-    step(
-        function getConnectionParams() {
-            self.metadataBackend.getUserDBConnectionParams(dbowner, this);
-        },
-        function extendParams(err, dbParams){
-            if (err) throw err;
-            // we don't want null values or overwrite a non public user
-            if (params.dbuser != 'publicuser' || !dbParams.dbuser) {
-                delete dbParams.dbuser;
-            }
-            if ( dbParams ) _.extend(params, dbParams);
-            return null;
-        },
-        function finish(err) {
-            callback(err);
-        }
-    );
-};

lib/cartodb/backends/pg_query_runner.js

@@ -1,44 +0,0 @@
-var PSQL = require('cartodb-psql');
-var step = require('step');
-
-function PgQueryRunner(pgConnection) {
-    this.pgConnection = pgConnection;
-}
-
-module.exports = PgQueryRunner;
-
-
-PgQueryRunner.prototype.run = function(username, query, queryHandler, callback) {
-    var self = this;
-
-    var params = {};
-
-    step(
-        function setAuth() {
-            self.pgConnection.setDBAuth(username, params, this);
-        },
-        function setConn(err) {
-            if (err) {
-                throw err;
-            }
-            self.pgConnection.setDBConn(username, params, this);
-        },
-        function executeQuery(err) {
-            if (err) {
-                throw err;
-            }
-            var psql = new PSQL({
-                user: params.dbuser,
-                pass: params.dbpass,
-                host: params.dbhost,
-                port: params.dbport,
-                dbname: params.dbname
-            });
-            psql.query(query, function(err, resultSet) {
-                resultSet = resultSet || {};
-                var rows = resultSet.rows || [];
-                queryHandler(err, rows, callback);
-            });
-        }
-    );
-};

lib/cartodb/cache/backend/fastly.js

@@ -1,16 +0,0 @@
-var FastlyPurge = require('fastly-purge');
-
-function FastlyCacheBackend(apiKey, serviceId, softPurge) {
-    this.serviceId = serviceId;
-    this.fastlyPurge = new FastlyPurge(apiKey, { softPurge: softPurge || true });
-}
-
-module.exports = FastlyCacheBackend;
-
-/**
- * @param cacheObject should respond to `key() -> String` method
- * @param {Function} callback
- */
-FastlyCacheBackend.prototype.invalidate = function(cacheObject, callback) {
-    this.fastlyPurge.key(this.serviceId, cacheObject.key(), callback);
-};

lib/cartodb/cache/backend/varnish_http.js

@@ -1,30 +0,0 @@
-var request = require('request');
-
-function VarnishHttpCacheBackend(host, port) {
-    this.host = host;
-    this.port = port;
-}
-
-module.exports = VarnishHttpCacheBackend;
-
-/**
- * @param cacheObject should respond to `key() -> String` method
- * @param {Function} callback
- */
-VarnishHttpCacheBackend.prototype.invalidate = function(cacheObject, callback) {
-    request(
-        {
-            method: 'PURGE',
-            url: 'http://' + this.host + ':' + this.port + '/key',
-            headers: {
-                'Invalidation-Match': '\\b' + cacheObject.key() + '\\b'
-            }
-        },
-        function(err, response) {
-            if (err || response.statusCode !== 204) {
-                return callback(new Error('Unable to invalidate Varnish object'));
-            }
-            return callback(null);
-        }
-    );
-};

lib/cartodb/cache/model/named_maps_entry.js

@@ -1,18 +0,0 @@
-var crypto = require('crypto');
-
-function NamedMaps(owner, name) {
-    this.namespace = 'n';
-    this.owner = owner;
-    this.name = name;
-}
-
-module.exports = NamedMaps;
-
-
-NamedMaps.prototype.key = function() {
-    return this.namespace + ':' + shortHashKey(this.owner + ':' + this.name);
-};
-
-function shortHashKey(target) {
-    return crypto.createHash('sha256').update(target).digest('base64').substring(0,6);
-}

lib/cartodb/cache/surrogate_keys_cache.js

@@ -1,41 +0,0 @@
-var queue = require('queue-async');
-
-/**
- * @param {Array|Object} cacheBackends each backend backend should respond to `invalidate(cacheObject, callback)` method
- * @constructor
- */
-function SurrogateKeysCache(cacheBackends) {
-    this.cacheBackends = Array.isArray(cacheBackends) ? cacheBackends : [cacheBackends];
-}
-
-module.exports = SurrogateKeysCache;
-
-
-/**
- * @param response should respond to `header(key, value)` method
- * @param cacheObject should respond to `key() -> String` method
- */
-SurrogateKeysCache.prototype.tag = function(response, cacheObject) {
-    response.header('Surrogate-Key', cacheObject.key());
-};
-
-/**
- * @param cacheObject should respond to `key() -> String` method
- * @param {Function} callback
- */
-SurrogateKeysCache.prototype.invalidate = function(cacheObject, callback) {
-    var invalidationQueue = queue(this.cacheBackends.length);
-
-    this.cacheBackends.forEach(function(cacheBackend) {
-        invalidationQueue.defer(function(cacheBackend, done) {
-            cacheBackend.invalidate(cacheObject, done);
-        }, cacheBackend);
-    });
-
-    invalidationQueue.awaitAll(function(err, result) {
-        if (err) {
-            return callback(err);
-        }
-        callback(null, result);
-    });
-};

lib/cartodb/cache_validator.js

@@ -0,0 +1,21 @@
+var _             = require('underscore'),
+    Varnish       = require('node-varnish'),
+    varnish_queue = null;
+
+function init(host, port) {
+    varnish_queue = new Varnish.VarnishQueue(host, port);
+}
+
+function invalidate_db(dbname, table) {
+    try{
+        varnish_queue.run_cmd('purge obj.http.X-Cache-Channel ~ "^' + dbname + ':(.*'+ table +'.*)|(table)$"');
+        console.log('[SUCCESS FLUSHING CACHE]');
+    } catch (e) {
+        console.log("[ERROR FLUSHING CACHE] Is enable_cache set to true? Failed for: " + 'purge obj.http.X-Cache-Channel ~ "^' + dbname + ':(.*'+ table +'.*)|(table)$"');
+    }
+}
+
+module.exports = {
+    init: init,
+    invalidate_db: invalidate_db
+}

lib/cartodb/carto_data.js

@@ -0,0 +1,279 @@
+/**
+ * User: simon
+ * Date: 30/08/2011
+ * Time: 21:10
+ * Desc: CartoDB helper.
+ *       Retrieves dbname (based on subdomain/username)
+ *       and geometry type from the redis stores of cartodb
+ */
+
+var strftime    = require('strftime');
+
+var   RedisPool = require("./redis_pool")
+    , _ = require('underscore')
+    , Step = require('step');
+
+module.exports = function() {
+    var redis_pool = new RedisPool(global.environment.redis);
+
+
+    var me = {
+        user_metadata_db: 5,
+        table_metadata_db: 0,
+        user_key:  "rails:users:<%= username %>",
+        table_key: "rails:<%= database_name %>:<%= table_name %>",
+        global_mapview_key: "user:<%= username %>:mapviews:global",
+        tagged_mapview_key: "user:<%= username %>:mapviews:stat_tag:<%= stat_tag %>"
+    };
+
+
+    /**
+     * Get the database name for this particular subdomain/username
+     *
+     * @param req - standard express req object. importantly contains host information
+     * @param callback - gets called with args(err, dbname) 
+     */
+    me.getDatabase = function(req, callback) {
+        // strip subdomain from header host
+        var username = req.headers.host.split('.')[0]
+        var redisKey = _.template(this.user_key, {username: username});
+
+        this.retrieve(this.user_metadata_db, redisKey, 'database_name', function(err, dbname) {
+          if ( err ) callback(err, null);
+          else if ( dbname === null ) {
+            callback(new Error("missing " + username + "'s dbname in redis (try CARTODB/script/restore_redis)"), null);
+          }
+          else callback(err, dbname);
+        });
+    };
+
+    me.userFromHostname = function(hostname) {
+        return hostname.split('.')[0];
+    }
+
+    /**
+     * Increment mapview count for a user
+     *
+     * @param username 
+     * @param stat_tag
+     * @param callback will be called with the new value
+     */
+    me.incMapviewCount = function(username, stat_tag, callback) {
+        var that = this;
+        var now = strftime("%Y%m%d", new Date());
+        var redisKey;
+        Step (
+          function incrementGlobal() {
+            redisKey = _.template(that.global_mapview_key, {username: username});
+            that.redisCmd(me.user_metadata_db, 'ZINCRBY', [redisKey, 1, now], this);
+          },
+          function incrementTag(err, val) {
+            if ( err ) throw err;
+            if ( _.isUndefined(stat_tag) ) return 1;
+            redisKey = _.template(that.tagged_mapview_key, {username: username, stat_tag: stat_tag});
+            that.redisCmd(me.user_metadata_db, 'ZINCRBY', [redisKey, 1, now], this);
+          },
+          function finish(err, val) {
+            if ( callback ) callback(err);
+          }
+        );
+    };
+
+
+    /**
+     * Get the user id for this particular subdomain/username
+     *
+     * @param req - standard express req object. importantly contains host information
+     * @param callback
+     */
+    me.getId= function(req, callback) {
+        // strip subdomain from header host
+        var username = req.headers.host.split('.')[0];
+        var redisKey = _.template(this.user_key, {username: username});
+
+        this.retrieve(this.user_metadata_db, redisKey, 'id', function(err, dbname) {
+          if ( err ) callback(err, null);
+          else if ( dbname === null ) {
+            callback(new Error("missing " + username + "'s dbuser in redis (try CARTODB/script/restore_redis)"), null);
+          }
+          else callback(err, dbname);
+        });
+    };
+
+    /**
+     * Check the user map key for this particular subdomain/username
+     *
+     * @param req - standard express req object. importantly contains host information
+     * @param callback
+     */
+    me.checkMapKey = function(req, callback) {
+        // strip subdomain from header host
+        var username = req.headers.host.split('.')[0];
+        var redisKey = "rails:users:" + username; 
+        this.retrieve(this.user_metadata_db, redisKey, "map_key", function(err, val) {
+            var valid = 0;
+            if ( val ) {
+              if ( val == req.query.map_key ) valid = 1;
+              else if ( val == req.query.api_key ) valid = 1;
+              // check also in request body 
+              else if ( req.body && req.body.map_key && val == req.body.map_key ) valid = 1;
+              else if ( req.body && req.body.api_key && val == req.body.api_key ) valid = 1;
+            }
+            callback(err, valid);
+        });
+    };
+
+    /**
+     * Get privacy for cartodb table
+     *
+     * @param req - standard req object. Importantly contains table and host information
+     * @param callback - is the table private or not?
+     */
+    me.authorize= function(req, callback) {
+        var that = this;
+
+        Step(
+            function(){
+                that.checkMapKey(req, this);
+            },
+            function checkIfInternal(err, check_result){
+                if (err) throw err;
+                if (check_result === 1) {
+                    // authorized by key, login as db owner 
+                    that.getId(req, function(err, user_id) {
+                        if (err) throw err;
+                        var dbuser = _.template(global.settings.postgres_auth_user, {user_id: user_id});
+                        _.extend(req.params, {dbuser:dbuser});
+                        callback(err, true); 
+                    });
+                } else {
+                    return true; // continue to check if the table is public/private
+                }
+            }
+            ,function (err, data){
+                if (err) throw err;
+                that.getDatabase(req, this);
+            },
+            function(err, data){
+                if (err) throw err;
+                var redisKey = _.template(that.table_key, {database_name: data, table_name: req.params.table});
+
+                that.retrieve(that.table_metadata_db, redisKey, 'privacy', this);
+            },
+            function(err, data){
+                callback(err, data);
+             }
+        );
+    };
+
+
+    /**
+     * Get the geometry type for this particular table;
+     * @param req - standard req object. Importantly contains table and host information
+     * @param callback
+     */
+    me.getGeometryType = function(req, callback){
+        var that = this;
+
+        Step(
+            function(){
+                that.getDatabase(req, this)
+            },
+            function(err, data){
+                if (err) throw err;
+                var redisKey = _.template(that.table_key, {database_name: data, table_name: req.params.table});
+
+                that.retrieve(that.table_metadata_db, redisKey, 'the_geom_type', this);
+            },
+            function(err, data){
+                callback(err, data);
+            }
+        );
+    };
+
+
+    me.getInfowindow = function(req, callback){
+        var that = this;
+
+        Step(
+            function(){
+                that.getDatabase(req, this);
+            },
+            function(err, data) {
+                if (err) throw err;
+                var redisKey = _.template(that.table_key, {database_name: data, table_name: req.params.table});
+                that.retrieve(that.table_metadata_db, redisKey, 'infowindow', this);
+            },
+            function(err, data){
+                callback(err, data);
+            }
+        );
+    };
+
+
+    me.getMapMetadata = function(req, callback){
+        var that = this;
+
+        Step(
+            function(){
+                that.getDatabase(req, this);
+            },
+            function(err, data) {
+                if (err) throw err;
+                var redisKey = _.template(that.table_key, {database_name: data, table_name: req.params.table});
+
+                that.retrieve(that.table_metadata_db, redisKey, 'map_metadata', this);
+            },
+            function(err, data){
+                callback(err, data);
+            }
+        );
+    };
+
+    // Redis Hash lookup
+    // @param callback will be invoked with args (err, reply)
+    //                 note that reply is null when the key is missing
+    me.retrieve = function(db, redisKey, hashKey, callback) {
+        this.redisCmd(db,'HGET',[redisKey, hashKey], callback);
+    };
+
+    // Redis Set member check
+    me.inSet = function(db, setKey, member, callback) {
+        this.redisCmd(db,'SISMEMBER',[setKey, member], callback);
+    };
+
+    // Redis INCREMENT 
+    me.increment = function(db, key, callback) {
+        this.redisCmd(db,'INCR', key, callback);
+    };
+
+    /**
+     * Use Redis
+     *
+     * @param db - redis database number
+     * @param redisFunc - the redis function to execute
+     * @param redisArgs - the arguments for the redis function in an array
+     * @param callback - function to pass results too.
+     */
+    me.redisCmd = function(db, redisFunc, redisArgs, callback) {
+        var redisClient;
+
+        Step(
+            function getRedisClient() {
+                redis_pool.acquire(db, this);
+            },
+            function executeQuery(err, data) {
+                if ( err ) throw err;
+                redisClient = data;
+                redisArgs.push(this);
+                redisClient[redisFunc.toUpperCase()].apply(redisClient, redisArgs);
+            },
+            function releaseRedisClient(err, data) {
+                if ( ! _.isUndefined(redisClient) ) redis_pool.release(db, redisClient);
+                callback(err, data);
+            }
+        );
+    };
+
+    return me;
+}();

lib/cartodb/cartodb_windshaft.js

@@ -1,76 +1,28 @@
-var _ = require('underscore');
-var step = require('step');
-var Windshaft = require('windshaft');
-var os = require('os');
-var HealthCheck = require('./monitoring/health_check');
 
-var SurrogateKeysCache = require('./cache/surrogate_keys_cache');
-var NamedMapsCacheEntry = require('./cache/model/named_maps_entry');
-var VarnishHttpCacheBackend = require('./cache/backend/varnish_http');
-var FastlyCacheBackend = require('./cache/backend/fastly');
-
-if ( ! process.env.PGAPPNAME )
-  process.env.PGAPPNAME='cartodb_tiler';
+var _ = require('underscore')
+    , Step       = require('step')
+    , Windshaft = require('windshaft')
+    , Cache = require('./cache_validator');
 
 var CartodbWindshaft = function(serverOptions) {
-    // Perform keyword substitution in statsd
-    // See https://github.com/CartoDB/Windshaft-cartodb/issues/153
-    if ( global.environment.statsd ) {
-      if ( global.environment.statsd.prefix ) {
-        var host_token = os.hostname().split('.').reverse().join('.');
-        global.environment.statsd.prefix = global.environment.statsd.prefix.replace(/:host/, host_token);
-      }
+
+    if(serverOptions.cache_enabled) {
+        console.log("cache invalidation enabled, varnish on ", serverOptions.varnish_host, ' ', serverOptions.varnish_port);
+        Cache.init(serverOptions.varnish_host, serverOptions.varnish_port);
+        serverOptions.afterStateChange = function(req, data, callback) {
+            Cache.invalidate_db(req.params.dbname, req.params.table);
+            callback(null, data);
+        }
     }
 
-    var redisPool = serverOptions.redis.pool ||
-        require('redis-mpool')(_.extend(global.environment.redis, {name: 'windshaft:cartodb'}));
-
-    var cartoData = require('cartodb-redis')({pool: redisPool});
-
-    var templateMaps = serverOptions.templateMaps;
-
-    // This is for Templated maps
-    //
-    // "named" is the official, "template" is for backward compatibility up to 1.6.x
-    //
-    var template_baseurl = global.environment.base_url_templated || '(?:/maps/named|/tiles/template)';
-
-    var surrogateKeysCacheBackends = [];
-
-    if (serverOptions.varnish_purge_enabled) {
-        surrogateKeysCacheBackends.push(
-            new VarnishHttpCacheBackend(serverOptions.varnish_host, serverOptions.varnish_http_port)
-        );
+    serverOptions.beforeStateChange = function(req, callback) {
+        var err = null;
+        if ( ! req.params.hasOwnProperty('dbuser') ) {
+          err = new Error("map state cannot be changed by unauthenticated request!");
+        }
+        callback(err, req);
     }
 
-    if (!!serverOptions.fastly.enabled && !!serverOptions.fastly.apiKey && !!serverOptions.fastly.serviceId) {
-        surrogateKeysCacheBackends.push(
-            new FastlyCacheBackend(serverOptions.fastly.apiKey, serverOptions.fastly.serviceId)
-        );
-    }
-
-    var surrogateKeysCache = new SurrogateKeysCache(surrogateKeysCacheBackends);
-
-    function invalidateNamedMap (owner, templateName) {
-        var startTime = Date.now();
-        surrogateKeysCache.invalidate(new NamedMapsCacheEntry(owner, templateName), function(err) {
-            var logMessage = JSON.stringify({
-                username: owner,
-                type: 'named_map_invalidation',
-                elapsed: Date.now() - startTime,
-                error: !!err ? JSON.stringify(err.message) : undefined
-            });
-            if (err) {
-                console.warn(logMessage);
-            } else {
-                console.info(logMessage);
-            }
-        });
-    }
-    ['update', 'delete'].forEach(function(eventType) {
-        templateMaps.on(eventType, invalidateNamedMap);
-    });
-
     // boot
     var ws = new Windshaft.Server(serverOptions);
 
@@ -80,139 +32,70 @@ var CartodbWindshaft = function(serverOptions) {
       var version = wsversion();
       version.windshaft_cartodb = require('../../package.json').version;
       return version;
-    };
+    }
 
-    var ws_sendResponse = ws.sendResponse;
-    // GET routes for which we don't want to request any caching.
-    // POST/PUT/DELETE requests are never cached anyway.
-    var noCacheGETRoutes = [
-      '/',
-      '/version',
-      // See https://github.com/CartoDB/Windshaft-cartodb/issues/176
-      serverOptions.base_url_mapconfig,
-      serverOptions.base_url_mapconfig + '/static/named/:template_id/:width/:height.:format',
-      template_baseurl,
-      template_baseurl + '/:template_id',
-      template_baseurl + '/:template_id/jsonp'
-    ];
-    ws.sendResponse = function(res, args) {
-      var that = this;
-      var thatArgs = arguments;
-      var statusCode;
-      if ( res._windshaftStatusCode ) {
-        // Added by our override of sendError
-        statusCode = res._windshaftStatusCode;
-      } else {
-        if ( args.length > 2 ) statusCode = args[2];
-        else {
-          statusCode = args[1] || 200;
-        }
-      }
-      var req = res.req;
-      step (
-        function addCacheChannel() {
-          if ( ! req ) {
-            // having no associated request can happen when
-            // using fake response objects for testing layergroup
-            // creation
-            return false;
-          }
-          if ( ! req.params ) {
-            // service requests (/version, /) 
-            // have no need for an X-Cache-Channel
-            return false;
-          }
-          if ( statusCode != 200 ) {
-            // We do not want to cache
-            // unsuccessful responses
-            return false;
-          }
-          if ( _.contains(noCacheGETRoutes, req.route.path) ) {
-//console.log("Skipping cache channel in route:\n" + req.route.path);
-            return false;
-          }
-//console.log("Adding cache channel to route\n" + req.route.path + " not matching any in:\n" +
-// mapCreateRoutes.join("\n"));
-          serverOptions.addCacheChannel(that, req, this);
-        },
-        function sendResponse(err/*, added*/) {
-          if ( err ) console.log(err + err.stack);
-          ws_sendResponse.apply(that, thatArgs);
-          return null;
-        },
-        function finish(err) {
-          if ( err ) console.log(err + err.stack);
-        }
-      );
-    };
-
-    var ws_sendError = ws.sendError;
-    ws.sendError = function() {
-      var res = arguments[0];
-      var statusCode = arguments[2];
-      res._windshaftStatusCode = statusCode;
-      ws_sendError.apply(this, arguments);
-    };
-
-    /*******************************************************************************************************************
-     * Routing
-     ******************************************************************************************************************/
-
-    var NamedMapsController = require('./controllers/named_maps'),
-        namedMapsController = new NamedMapsController(
-            ws,
-            serverOptions,
-            templateMaps,
-            cartoData,
-            template_baseurl,
-            surrogateKeysCache
-        );
-    namedMapsController.register(ws);
-
-    var TablesExtentApi = require('./api/tables_extent_api');
-    var tablesExtentApi = new TablesExtentApi(serverOptions.pgQueryRunner);
-
-    var NamedStaticMapsController = require('./controllers/named_static_maps');
-    var namedStaticMapsController = new NamedStaticMapsController(
-        ws,
-        serverOptions,
-        templateMaps,
-        ws.staticMapBackend,
-        surrogateKeysCache,
-        tablesExtentApi
-    );
-    namedStaticMapsController.register(ws);
-
-    /*******************************************************************************************************************
-     * END Routing
-     ******************************************************************************************************************/
-
-    var healthCheck = new HealthCheck(cartoData, Windshaft.tilelive);
-    ws.get('/health', function(req, res) {
-        var healthConfig = global.environment.health || {};
-
-        if (!!healthConfig.enabled) {
-            var startTime = Date.now();
-            healthCheck.check(healthConfig, function(err, result) {
-                var ok = !err;
-                var response = {
-                    enabled: true,
-                    ok: ok,
-                    elapsed: Date.now() - startTime,
-                    result: result
-                };
-                if (err) {
-                    response.err = err.message;
+    /**
+     * Helper to allow access to the layer to be used in the maps infowindow popup.
+     */
+    ws.get(serverOptions.base_url + '/infowindow', function(req, res){
+        ws.doCORS(res);
+        Step(
+            function(){
+                serverOptions.getInfowindow(req, this);
+            },
+            function(err, data){
+                if (err){
+                    ws.sendError(res, {error: err.message}, 500, 'GET INFOWINDOW');
+                    //res.send({error: err.message}, 500);
+                } else {
+                    res.send({infowindow: data}, 200);
                 }
-                res.send(response, ok ? 200 : 503);
-
-            });
-        } else {
-            res.send({enabled: false, ok: true}, 200);
-        }
+            }
+        );
     });
 
+
+    /**
+     * Helper to allow access to metadata to be used in embedded maps.
+     */
+    ws.get(serverOptions.base_url + '/map_metadata', function(req, res){
+        ws.doCORS(res);
+        Step(
+            function(){
+                serverOptions.getMapMetadata(req, this);
+            },
+            function(err, data){
+                if (err){
+                    ws.sendError(res, {error: err.message}, 500, 'GET MAP_METADATA');
+                    //res.send(err.message, 500);
+                } else {
+                    res.send({map_metadata: data}, 200);
+                }
+            }
+        );
+    });
+
+    /**
+     * Helper API to allow per table tile cache (and sql cache) to be invalidated remotely.
+     * TODO: Move?
+     */
+    ws.del(serverOptions.base_url + '/flush_cache', function(req, res){
+        ws.doCORS(res);
+        Step(
+            function flushCache(){
+                serverOptions.flushCache(req, serverOptions.cache_enabled ? Cache : null, this);
+            },
+            function sendResponse(err, data){
+                if (err){
+                    ws.sendError(res, {error: err.message}, 500, 'DELETE CACHE');
+                    //res.send(500);
+                } else {
+                    res.send({status: 'ok'}, 200);
+                }
+            }
+        );
+    });
     return ws;
-};
+}
 
 module.exports = CartodbWindshaft;

lib/cartodb/controllers/named_maps.js

@@ -1,372 +0,0 @@
-var step = require('step');
-var assert = require('assert');
-var _ = require('underscore');
-var templateName = require('../template_maps').templateName;
-var CdbRequest = require('../models/cdb_request');
-var NamedMapsCacheEntry = require('../cache/model/named_maps_entry');
-
-function NamedMapsController(app, serverOptions, templateMaps, metadataBackend, templateBaseUrl, surrogateKeysCache) {
-    this.app = app;
-    this.serverOptions = serverOptions;
-    this.templateMaps = templateMaps;
-    this.metadataBackend = metadataBackend;
-    this.templateBaseUrl = templateBaseUrl;
-    this.surrogateKeysCache = surrogateKeysCache;
-}
-
-module.exports = NamedMapsController;
-
-var cdbRequest = new CdbRequest();
-
-NamedMapsController.prototype.register = function(app) {
-    app.get(this.templateBaseUrl + '/:template_id/jsonp', this.jsonp.bind(this));
-    app.post(this.templateBaseUrl, this.create.bind(this));
-    app.put(this.templateBaseUrl + '/:template_id', this.update.bind(this));
-    app.get(this.templateBaseUrl + '/:template_id', this.retrieve.bind(this));
-    app.del(this.templateBaseUrl + '/:template_id', this.destroy.bind(this));
-    app.get(this.templateBaseUrl, this.list.bind(this));
-    app.options(this.templateBaseUrl + '/:template_id', this.options.bind(this));
-    app.post(this.templateBaseUrl + '/:template_id', this.instantiate.bind(this));
-};
-
-// Add a template
-NamedMapsController.prototype.create = function(req, res) {
-    var self = this;
-
-    this.app.doCORS(res);
-
-    var cdbuser = cdbRequest.userByReq(req);
-
-    step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function addTemplate(err, authenticated) {
-            assert.ifError(err);
-            ifUnauthenticated(authenticated, 'Only authenticated users can get template maps');
-            ifInvalidContentType(req, 'template POST data must be of type application/json');
-            var cfg = req.body;
-            self.templateMaps.addTemplate(cdbuser, cfg, this);
-        },
-        function prepareResponse(err, tpl_id){
-            assert.ifError(err);
-            return { template_id: tpl_id };
-        },
-        finishFn(self.app, res, 'POST TEMPLATE')
-    );
-};
-
-// Update a template
-NamedMapsController.prototype.update = function(req, res) {
-    var self = this;
-
-    this.app.doCORS(res);
-
-    var cdbuser = cdbRequest.userByReq(req);
-    var template;
-    var tpl_id;
-    step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function updateTemplate(err, authenticated) {
-            assert.ifError(err);
-            ifUnauthenticated(authenticated, 'Only authenticated user can update templated maps');
-            ifInvalidContentType(req, 'template PUT data must be of type application/json');
-
-            template = req.body;
-            tpl_id = templateName(req.params.template_id);
-            self.templateMaps.updTemplate(cdbuser, tpl_id, template, this);
-        },
-        function prepareResponse(err){
-            assert.ifError(err);
-
-            return { template_id: tpl_id };
-        },
-        finishFn(self.app, res, 'PUT TEMPLATE')
-    );
-};
-
-// Get a specific template
-NamedMapsController.prototype.retrieve = function(req, res) {
-    var self = this;
-
-    if (req.profiler) {
-        req.profiler.start('windshaft-cartodb.get_template');
-    }
-
-    this.app.doCORS(res);
-
-    var cdbuser = cdbRequest.userByReq(req);
-    var tpl_id;
-    step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function updateTemplate(err, authenticated) {
-            assert.ifError(err);
-            ifUnauthenticated(authenticated, 'Only authenticated users can get template maps');
-
-            tpl_id = templateName(req.params.template_id);
-            self.templateMaps.getTemplate(cdbuser, tpl_id, this);
-        },
-        function prepareResponse(err, tpl_val) {
-            if ( err ) throw err;
-            if ( ! tpl_val ) {
-                err = new Error("Cannot find template '" + tpl_id + "' of user '" + cdbuser + "'");
-                err.http_status = 404;
-                throw err;
-            }
-            // auth_id was added by ourselves,
-            // so we remove it before returning to the user
-            delete tpl_val.auth_id;
-            return { template: tpl_val };
-        },
-        finishFn(self.app, res, 'GET TEMPLATE')
-    );
-};
-
-// Delete a specific template
-NamedMapsController.prototype.destroy = function(req, res) {
-    var self = this;
-
-    if (req.profiler) {
-        req.profiler.start('windshaft-cartodb.delete_template');
-    }
-    this.app.doCORS(res);
-
-    var cdbuser = cdbRequest.userByReq(req);
-    var tpl_id;
-    step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function updateTemplate(err, authenticated) {
-            assert.ifError(err);
-            ifUnauthenticated(authenticated, 'Only authenticated users can delete template maps');
-
-            tpl_id = templateName(req.params.template_id);
-            self.templateMaps.delTemplate(cdbuser, tpl_id, this);
-        },
-        function prepareResponse(err/*, tpl_val*/){
-            if ( err ) throw err;
-            return { status: 'ok' };
-        },
-        finishFn(self.app, res, 'DELETE TEMPLATE', ['', 204])
-    );
-};
-
-// Get a list of owned templates
-NamedMapsController.prototype.list = function(req, res) {
-    var self = this;
-    if ( req.profiler ) {
-        req.profiler.start('windshaft-cartodb.get_template_list');
-    }
-    this.app.doCORS(res);
-
-    var cdbuser = cdbRequest.userByReq(req);
-
-    step(
-        function checkPerms(){
-            self.serverOptions.authorizedByAPIKey(req, this);
-        },
-        function listTemplates(err, authenticated) {
-            assert.ifError(err);
-            ifUnauthenticated(authenticated, 'Only authenticated user can list templated maps');
-
-            self.templateMaps.listTemplates(cdbuser, this);
-        },
-        function prepareResponse(err, tpl_ids){
-            assert.ifError(err);
-            return { template_ids: tpl_ids };
-        },
-        finishFn(self.app, res, 'GET TEMPLATE LIST')
-    );
-};
-
-NamedMapsController.prototype.instantiate = function(req, res) {
-    var self = this;
-
-    if (req.profiler) {
-        req.profiler.start('windshaft-cartodb.instance_template_post');
-    }
-    step(
-        function() {
-            ifInvalidContentType(req, 'template POST data must be of type application/json');
-
-            self.instantiateTemplate(req, res, req.body, this);
-        }, function(err, response) {
-            self.finish_instantiation(err, response, res);
-        }
-    );
-};
-
-NamedMapsController.prototype.options = function(req, res, next) {
-    this.app.doCORS(res, "Content-Type");
-    return next();
-};
-
-/**
- * jsonp endpoint, allows to instantiate a template with a json call.
- * callback query argument is mandatory
- */
-NamedMapsController.prototype.jsonp = function(req, res) {
-    var self = this;
-
-    if (req.profiler) {
-        req.profiler.start('windshaft-cartodb.instance_template_get');
-    }
-    step(
-        function() {
-            if ( req.query.callback === undefined || req.query.callback.length === 0) {
-                throw new Error('callback parameter should be present and be a function name');
-            }
-            var config = {};
-            if(req.query.config) {
-                try {
-                    config = JSON.parse(req.query.config);
-                } catch(e) {
-                    throw new Error('badformed config parameter, should be a valid JSON');
-                }
-            }
-            self.instantiateTemplate(req, res, config, this);
-        }, function(err, response) {
-            self.finish_instantiation(err, response, res);
-        }
-    );
-};
-
-
-// Instantiate a template
-NamedMapsController.prototype.instantiateTemplate = function(req, res, template_params, callback) {
-    var self = this;
-
-    this.app.doCORS(res);
-
-    var template;
-    var layergroup;
-    var fakereq; // used for call to createLayergroup
-    var cdbuser = cdbRequest.userByReq(req);
-    // Format of template_id: [<template_owner>]@<template_id>
-    var tpl_id = templateName(req.params.template_id);
-    var auth_token = req.query.auth_token;
-    step(
-        function getTemplate(){
-            self.templateMaps.getTemplate(cdbuser, tpl_id, this);
-        },
-        function checkAuthorized(err, templateValue) {
-            if ( req.profiler ) req.profiler.done('getTemplate');
-            if ( err ) throw err;
-            if ( ! templateValue ) {
-                err = new Error("Template '" + tpl_id + "' of user '" + cdbuser + "' not found");
-                err.http_status = 404;
-                throw err;
-            }
-
-            template = templateValue;
-
-            var authorized = false;
-            try {
-                authorized = self.templateMaps.isAuthorized(template, auth_token);
-            } catch (err) {
-                // we catch to add http_status
-                err.http_status = 403;
-                throw err;
-            }
-            if ( ! authorized ) {
-                err = new Error('Unauthorized template instanciation');
-                err.http_status = 403;
-                throw err;
-            }
-
-            if (req.profiler) {
-                req.profiler.done('authorizedByCert');
-            }
-
-            return self.templateMaps.instance(template, template_params);
-        },
-        function prepareParams(err, instance){
-            if ( req.profiler ) req.profiler.done('TemplateMaps_instance');
-            if ( err ) throw err;
-            layergroup = instance;
-            fakereq = {
-                query: {},
-                params: {
-                    user: req.params.user
-                },
-                headers: _.clone(req.headers),
-                context: _.clone(req.context),
-                method: req.method,
-                res: res,
-                profiler: req.profiler
-            };
-            self.serverOptions.setDBParams(cdbuser, fakereq.params, this);
-        },
-        function setApiKey(err){
-            if ( req.profiler ) req.profiler.done('setDBParams');
-            if ( err ) throw err;
-            self.metadataBackend.getUserMapKey(cdbuser, this);
-        },
-        function createLayergroup(err, val) {
-            if ( req.profiler ) req.profiler.done('getUserMapKey');
-            if ( err ) throw err;
-            fakereq.params.api_key = val;
-            self.app.createLayergroup(layergroup, fakereq, this);
-        },
-        function prepareResponse(err, layergroup) {
-            if ( err ) {
-                return callback(err, { errors: [''+err] });
-            }
-            var tplhash = self.templateMaps.fingerPrint(template).substring(0,8);
-            layergroup.layergroupid = cdbuser + '@' + tplhash + '@' + layergroup.layergroupid;
-            res.header('X-Layergroup-Id', layergroup.layergroupid);
-
-            self.surrogateKeysCache.tag(res, new NamedMapsCacheEntry(cdbuser, template.name));
-
-            callback(null, layergroup);
-        }
-    );
-};
-
-NamedMapsController.prototype.finish_instantiation = function(err, response, res) {
-    if (err) {
-        var statusCode = 400;
-        response = { errors: [''+err] };
-        if ( ! _.isUndefined(err.http_status) ) {
-            statusCode = err.http_status;
-        }
-        this.app.sendError(res, response, statusCode, 'POST INSTANCE TEMPLATE', err);
-    } else {
-        this.app.sendResponse(res, [response, 200]);
-    }
-};
-
-function finishFn(app, res, description, okResponse) {
-    return function finish(err, response){
-        var statusCode = 200;
-        if (err) {
-            statusCode = 400;
-            response = { errors: ['' + err] };
-            if ( ! _.isUndefined(err.http_status) ) {
-                statusCode = err.http_status;
-            }
-            app.sendError(res, response, statusCode, description, err);
-        } else {
-            app.sendResponse(res, okResponse || [response, statusCode]);
-        }
-    };
-}
-
-function ifUnauthenticated(authenticated, description) {
-    if (authenticated !== 1) {
-        var err = new Error(description);
-        err.http_status = 403;
-        throw err;
-    }
-}
-
-function ifInvalidContentType(req, description) {
-    if ( ! req.headers['content-type'] || req.headers['content-type'].split(';')[0] != 'application/json' ) {
-        throw new Error(description);
-    }
-}

lib/cartodb/controllers/named_static_maps.js

@@ -1,248 +0,0 @@
-var step = require('step');
-var assert = require('assert');
-var templateName = require('../template_maps').templateName;
-var CdbRequest = require('../models/cdb_request');
-var NamedMapsCacheEntry = require('../cache/model/named_maps_entry');
-var _ = require('underscore');
-
-function NamedStaticMapsController(app, serverOptions, templateMaps, staticMapBackend, surrogateKeysCache,
-                                   tablesExtentApi) {
-    this.app = app;
-    this.serverOptions = serverOptions;
-    this.templateMaps = templateMaps;
-    this.staticMapBackend = staticMapBackend;
-    this.surrogateKeysCache = surrogateKeysCache;
-    this.tablesExtentApi = tablesExtentApi;
-}
-
-module.exports = NamedStaticMapsController;
-
-var cdbRequest = new CdbRequest();
-
-NamedStaticMapsController.prototype.register = function(app) {
-    app.get(app.base_url_mapconfig + '/static/named/:template_id/:width/:height.:format', this.named.bind(this));
-};
-
-NamedStaticMapsController.prototype.named = function(req, res) {
-    var self = this;
-
-    this.app.doCORS(res);
-    var cdbUser = cdbRequest.userByReq(req);
-
-    var format = req.params.format === 'jpg' ? 'jpeg' : 'png';
-
-    var template;
-    var layergroupConfig;
-    var layergroupId;
-    var fakeReq;
-    var cacheChannel;
-
-    step(
-        function reqParams() {
-            self.app.req2params(req, this);
-        },
-        function getTemplate(err) {
-            assert.ifError(err);
-            self.templateMaps.getTemplate(cdbUser, templateName(req.params.template_id), this);
-        },
-        function checkExists(err, tpl) {
-            assert.ifError(err);
-            if (!tpl) {
-                var notFoundErr = new Error(
-                        "Template '" + templateName(req.params.template_id) + "' of user '" + cdbUser + "' not found"
-                );
-                notFoundErr.http_status = 404;
-                throw notFoundErr;
-            }
-            return tpl;
-        },
-        function checkAuthorized(err, tpl) {
-            assert.ifError(err);
-
-            var authorized = false;
-            try {
-                authorized = self.templateMaps.isAuthorized(tpl, req.query.auth_token);
-            } catch (err) {
-                // we catch to add http_status
-                var authorizationFailedErr = new Error('Failed to authorize template');
-                authorizationFailedErr.http_status = 403;
-                throw authorizationFailedErr;
-            }
-            if ( ! authorized ) {
-                var unauthorizedErr = new Error('Unauthorized template instantiation');
-                unauthorizedErr.http_status = 403;
-                throw unauthorizedErr;
-            }
-
-            return tpl;
-        },
-        function prepareParams(err, tpl) {
-            assert.ifError(err);
-
-            template = tpl;
-
-            var templateParams = {};
-            if (req.query.config) {
-                try {
-                    templateParams = JSON.parse(req.query.config);
-                } catch (e) {
-                    throw new Error('malformed config parameter, should be a valid JSON');
-                }
-            }
-
-            return templateParams;
-        },
-        function instantiateTemplate(err, templateParams) {
-            assert.ifError(err);
-            return self.templateMaps.instance(template, templateParams);
-        },
-        function prepareLayergroup(err, layergroup) {
-            assert.ifError(err);
-            layergroupConfig = layergroup;
-            fakeReq = {
-                query: {},
-                params: {
-                    user: req.params.user
-                },
-                headers: _.clone(req.headers),
-                context: _.clone(req.context),
-                method: req.method,
-                res: res,
-                profiler: req.profiler
-            };
-            self.serverOptions.setDBParams(cdbUser, fakeReq.params, this);
-        },
-        function setApiKey(err){
-            assert.ifError(err);
-            self.app.createLayergroup(layergroupConfig, fakeReq, this);
-        },
-        function prepareResponse(err, layergroup) {
-            assert.ifError(err);
-
-            // added by createLayergroup
-            cacheChannel = res.header('X-Cache-Channel');
-            res.removeHeader('X-Cache-Channel');
-            self.surrogateKeysCache.tag(res, new NamedMapsCacheEntry(cdbUser, template.name));
-
-            layergroupId = layergroup.layergroupid.split(":")[0];
-
-            return null;
-        },
-        function staticImageOptions(err) {
-            assert.ifError(err);
-            getStaticImageOptions(template, this);
-        },
-        function estimateBounds(err, imageOpts) {
-            assert.ifError(err);
-            if (imageOpts) {
-                return imageOpts;
-            }
-
-            var defaultZoomCenter = {
-                zoom: 1,
-                center: {
-                    lng: 0,
-                    lat: 0
-                }
-            };
-
-            var dbTables = cacheChannel.split(':');
-            if (dbTables.length <= 1 || dbTables[1].length === 0) {
-                return defaultZoomCenter;
-            }
-
-            var tableNames = dbTables[1].split(',');
-            if (tableNames.length === 0) {
-                return defaultZoomCenter;
-            }
-
-            var next = this;
-            self.tablesExtentApi.getBounds(cdbUser, tableNames, function(err, result) {
-                next(null, result || defaultZoomCenter);
-            });
-        },
-        function getImage(err, imageOpts) {
-            assert.ifError(err);
-
-            var staticImageReq = {
-                headers: _.clone(fakeReq.headers),
-                params: _.extend(_.clone(fakeReq.params), {
-                    token: layergroupId,
-                    format: req.params.format
-                })
-            };
-
-            var width = +req.params.width;
-            var height = +req.params.height;
-
-            if (!_.isUndefined(imageOpts.zoom) && imageOpts.center) {
-                self.staticMapBackend.getImage(staticImageReq, width, height, imageOpts.zoom, imageOpts.center, this);
-            } else {
-                self.staticMapBackend.getImage(staticImageReq, width, height, imageOpts.bounds, this);
-            }
-        },
-        function handleImage(err, image, headers, stats) {
-            if (req.profiler) {
-                req.profiler.done('render-' + format);
-                req.profiler.add(stats || {});
-            }
-
-            if (err) {
-                if (!err.error) {
-                    err.error = err.message;
-                }
-                self.app.sendError(res, err, self.app.findStatusCode(err), 'STATIC_VIZ_MAP', err);
-            } else {
-                res.setHeader('Content-Type', headers['Content-Type'] || 'image/' + format);
-                res.setHeader('Cache-Control', 'public,max-age=7200,must-revalidate');
-                self.app.sendResponse(res, [image, 200]);
-            }
-        }
-    );
-};
-
-function getStaticImageOptions(template, callback) {
-    if (template.view) {
-        var zoomCenter = templateZoomCenter(template.view);
-        if (zoomCenter) {
-            return callback(null, zoomCenter);
-        }
-
-        var bounds = templateBounds(template.view);
-        if (bounds) {
-            return callback(null, bounds);
-        }
-    }
-    return callback(null, null);
-}
-
-function templateZoomCenter(view) {
-    if (!_.isUndefined(view.zoom) && view.center) {
-        return {
-            zoom: view.zoom,
-            center: view.center
-        };
-    }
-    return false;
-}
-
-function templateBounds(view) {
-    if (view.bounds) {
-        var hasAllBounds = _.every(['west', 'south', 'east', 'north'], function(prop) {
-            return !!view.bounds[prop];
-        });
-        if (hasAllBounds) {
-            return {
-                bounds: {
-                    west: view.bounds.west,
-                    south: view.bounds.south,
-                    east: view.bounds.east,
-                    north: view.bounds.north
-                }
-            };
-        } else {
-            return false;
-        }
-    }
-    return false;
-}

lib/cartodb/models/cdb_request.js

@@ -1,26 +0,0 @@
-function CdbRequest() {
-    this.RE_USER_FROM_HOST = new RegExp(global.environment.user_from_host ||
-            '^([^\\.]+)\\.' // would extract "strk" from "strk.cartodb.com"
-    );
-}
-
-module.exports = CdbRequest;
-
-
-CdbRequest.prototype.userByReq = function(req) {
-    var host = req.headers.host;
-    if (req.params.user) {
-        return req.params.user;
-    }
-    var mat = host.match(this.RE_USER_FROM_HOST);
-    if ( ! mat ) {
-        console.error("Pattern '" + this.RE_USER_FROM_HOST + "' does not match hostname '" + host + "'");
-        return;
-    }
-    // console.log("Matches: "); console.dir(mat);
-    if ( mat.length !== 2 ) {
-        console.error("Pattern '" + this.RE_USER_FROM_HOST + "' gave unexpected matches against '" + host + "': ", mat);
-        return;
-    }
-    return mat[1];
-};

lib/cartodb/models/mapconfig_named_layers_adapter.js

@@ -1,120 +0,0 @@
-var queue = require('queue-async');
-var _ = require('underscore');
-var Datasource = require('windshaft').Datasource;
-
-function MapConfigNamedLayersAdapter(templateMaps) {
-    this.templateMaps = templateMaps;
-}
-
-module.exports = MapConfigNamedLayersAdapter;
-
-MapConfigNamedLayersAdapter.prototype.getLayers = function(username, layers, dbMetadata, callback) {
-    var self = this;
-
-    var adaptLayersQueue = queue(layers.length);
-
-    function adaptLayer(layer, done) {
-        if (isNamedTypeLayer(layer)) {
-
-            if (!layer.options.name) {
-                return done(new Error('Missing Named Map `name` in layer options'));
-            }
-
-            var templateName = layer.options.name;
-            var templateConfigParams = layer.options.config || {};
-            var templateAuthTokens = layer.options.auth_tokens;
-
-            self.templateMaps.getTemplate(username, templateName, function(err,  template) {
-                if (err || !template) {
-                    return done(new Error("Template '" + templateName + "' of user '" + username + "' not found"));
-                }
-
-                if (self.templateMaps.isAuthorized(template, templateAuthTokens)) {
-                    var nestedNamedLayers = template.layergroup.layers.filter(function(layer) {
-                        return layer.type === 'named';
-                    });
-
-                    if (nestedNamedLayers.length > 0) {
-                        var nestedNamedMapsError = new Error('Nested named layers are not allowed');
-                        // nestedNamedMapsError.http_status = 400;
-                        return done(nestedNamedMapsError);
-                    }
-
-                    try {
-                        var templateLayergroupConfig = self.templateMaps.instance(template, templateConfigParams);
-                        return done(null, {
-                            datasource: true,
-                            layers: templateLayergroupConfig.layers
-                        });
-                    } catch (err) {
-                        return done(err);
-                    }
-                } else {
-                    var unauthorizedError = new Error("Unauthorized '" + templateName + "' template instantiation");
-                    unauthorizedError.http_status = 403;
-                    return done(unauthorizedError);
-                }
-            });
-
-        } else {
-            return done(null, {
-                datasource: false,
-                layers: [layer]
-            });
-        }
-    }
-
-    var datasourceBuilder = new Datasource.Builder();
-
-    function layersAdaptQueueFinish(err, layersResults) {
-        if (err) {
-            return callback(err);
-        }
-
-        if (!layersResults || layersResults.length === 0) {
-            return callback(new Error('Missing layers array from layergroup config'));
-        }
-
-        var layers = [],
-            currentLayerIndex = 0;
-
-        layersResults.forEach(function(layersResult) {
-
-            layersResult.layers.forEach(function(layer) {
-                layers.push(layer);
-                if (layersResult.datasource) {
-                    datasourceBuilder.withLayerDatasource(currentLayerIndex, {
-                        user: dbAuth.dbuser
-                    });
-                }
-                currentLayerIndex++;
-            });
-
-        });
-
-        return callback(null, layers, datasourceBuilder.build());
-    }
-
-
-    var dbAuth = {};
-
-    if (_.some(layers, isNamedTypeLayer)) {
-        // Lazy load dbAuth
-        dbMetadata.setDBAuth(username, dbAuth, function(err) {
-            if (err) {
-                return callback(err);
-            }
-            layers.forEach(function(layer) {
-                adaptLayersQueue.defer(adaptLayer, layer);
-            });
-            adaptLayersQueue.awaitAll(layersAdaptQueueFinish);
-        });
-    } else {
-        return callback(null, layers, datasourceBuilder.build());
-    }
-
-};
-
-function isNamedTypeLayer(layer) {
-    return layer.type === 'named';
-}

lib/cartodb/monitoring/health_check.js

@@ -1,45 +0,0 @@
-var fs = require('fs');
-var step = require('step');
-
-function HealthCheck(metadataBackend, tilelive) {
-    this.metadataBackend = metadataBackend;
-    this.tilelive = tilelive;
-}
-
-module.exports = HealthCheck;
-
-
-HealthCheck.prototype.check = function(config, callback) {
-
-    var result = {
-            redis: {
-                ok: false
-            },
-            mapnik: {
-                ok: false
-            },
-            tile: {
-                ok: false
-            }
-        };
-
-    step(
-        function getManualDisable() {
-          fs.readFile(global.environment.disabled_file, this);
-        },
-        function handleDisabledFile(err, data) {
-          var next = this;
-          if (err) {
-            return next();
-          }
-          if (!!data) {
-            err = new Error(data);
-            err.http_status = 503;
-            throw err;
-          }
-        },
-        function handleResult(err) {
-            callback(err, result);
-        }
-    );
-};

lib/cartodb/monitoring/map-config.xml

@@ -1,4 +0,0 @@
-<Map
-    background-color="#c33"
-    srs="+proj=longlat +ellps=WGS84 +datum=WGS84 +no_defs">
-</Map>

lib/cartodb/redis_pool.js

@@ -0,0 +1,80 @@
+/**
+ * RedisPool. A database specific redis pooling lib
+ *
+ */
+
+var redis  = require('redis')
+  , _      = require('underscore')
+  , Pool   = require('generic-pool').Pool;
+
+// constructor.
+// 
+// - `opts` {Object} optional config for redis and pooling
+var RedisPool = function(opts){
+  var opts = opts || {};
+  var defaults = {
+    host: '127.0.0.1', 
+    port: '6379', 
+    max: 50, 
+    idleTimeoutMillis: 10000, 
+    reapIntervalMillis: 1000, 
+    log: false
+  };    
+  var options = _.defaults(opts, defaults)
+
+  var me = {
+    pools: {} // cached pools by DB name
+  };
+  
+  // Acquire resource.
+  //
+  // - `database` {String} redis database name
+  // - `callback` {Function} callback to call once acquired. Takes the form
+  //   `callback(err, resource)`  
+  me.acquire = function(database, callback) {
+      if (!this.pools[database]) {
+        this.pools[database] = this.makePool(database);            
+      }
+      this.pools[database].acquire(function(err,resource) {
+        callback(err, resource);
+      });
+  };
+  
+  // Release resource.
+  //
+  // - `database` {String} redis database name
+  // - `resource` {Object} resource object to release
+  me.release = function(database, resource) {
+      this.pools[database] && this.pools[database].release(resource);
+  };
+    
+  // Factory for pool objects.
+  me.makePool = function(database) {
+    return Pool({
+      name: database,
+      create: function(callback){
+        var client = redis.createClient(options.port, options.host);          
+        client.on('connect', function () {
+          client.send_anyway = true;
+          client.select(database);  
+          client.send_anyway = false;
+          callback(null, client);
+        });    
+        client.on('error', function (err) {
+          callback(err, null);
+        });
+      },
+      destroy: function(client) { 
+        return client.quit(); 
+      },
+      max: options.max, 
+      idleTimeoutMillis: options.idleTimeoutMillis, 
+      reapIntervalMillis: options.reapIntervalMillis, 
+      log: options.log 
+    });
+  };
+      
+  return me;
+};
+
+module.exports = RedisPool;

lib/cartodb/server_options.js

@@ -1,117 +1,58 @@
-var _ = require('underscore');
-var step = require('step');
-var LZMA = require('lzma').LZMA;
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
+var   _          = require('underscore')
+    , Step       = require('step')
+    , cartoData  = require('./carto_data')
+    , Cache = require('./cache_validator')
+    , mapnik     = require('mapnik')
+    , crypto     = require('crypto')
+    , request    = require('request')
+    , LZMA       = require('lzma/lzma_worker.js').LZMA
+  ;
 
-var QueryTablesApi = require('./api/query_tables_api');
-var PgQueryRunner = require('./backends/pg_query_runner');
-var PgConnection = require('./backends/pg_connection');
-var TemplateMaps = require('./template_maps.js');
-var MapConfigNamedLayersAdapter = require('./models/mapconfig_named_layers_adapter');
-var CdbRequest = require('./models/cdb_request');
+// This is for backward compatibility with 1.3.3
+if ( _.isUndefined(global.environment.sqlapi.domain) ) {
+  global.environment.sqlapi.domain = global.environment.sqlapi.host;
+}
 
-var timeoutErrorTilePath = __dirname + '/../../assets/render-timeout-fallback.png';
-var timeoutErrorTile = require('fs').readFileSync(timeoutErrorTilePath, {encoding: null});
-
-// Whitelist query parameters and attach format
-var REQUEST_QUERY_PARAMS_WHITELIST = [
-    'config',
-    'map_key',
-    'api_key',
-    'auth_token',
-    'callback'
-];
-
-module.exports = function(redisPool) {
-    redisPool = redisPool || new RedisPool(_.extend(global.environment.redis, {name: 'windshaft:server_options'}));
-
-    var cartoData = require('cartodb-redis')({ pool: redisPool });
-    var lzmaWorker = new LZMA();
-    var pgConnection = new PgConnection(cartoData);
-    var pgQueryRunner = new PgQueryRunner(pgConnection);
-    var queryTablesApi = new QueryTablesApi(pgQueryRunner);
-    var cdbRequest = new CdbRequest();
+module.exports = function(){
 
     var rendererConfig = _.defaults(global.environment.renderer || {}, {
-        cache_ttl: 60000, // milliseconds
-        statsInterval: 60000,
-        mapnik: {
-            poolSize: 8,
-            metatile: 2,
-            bufferSize: 64,
-            snapToGrid: false,
-            clipByBox2d: false,
-            limits: {}
-        },
-        http: {}
+      cache_ttl: 60000, // milliseconds
+      metatile: 4,
+      bufferSize: 64
     });
 
     var me = {
-        // This is for inline maps and table maps
-        base_url: global.environment.base_url_legacy || '/tiles/:table',
-
-        /// @deprecated with Windshaft-0.17.0
-        ///base_url_notable: '/tiles',
-
-        // This is for Detached maps
-        //
-        // "maps" is the official, while
-        // "tiles/layergroup" is for backward compatibility up to 1.6.x
-        //
-        base_url_mapconfig: global.environment.base_url_detached || '(?:/maps|/tiles/layergroup)',
-
+        base_url: '/tiles/:table',
+        base_url_notable: '/tiles',
         grainstore: {
-          map: {
-            // TODO: allow to specify in configuration
-            srid: 3857
-          },
           datasource: global.environment.postgres,
           cachedir: global.environment.millstone.cache_basedir,
-          mapnik_version: global.environment.mapnik_version,
-          mapnik_tile_format: global.environment.mapnik_tile_format || 'png',
-          default_layergroup_ttl: global.environment.mapConfigTTL || 7200
+          mapnik_version: global.environment.mapnik_version || mapnik.versions.mapnik,
+          default_layergroup_ttl: 7200 // seconds (defaultis 300)
+        },
+        mapnik: {
+          metatile: rendererConfig.metatile,
+          bufferSize: rendererConfig.bufferSize
         },
-        statsd: global.environment.statsd,
         renderCache: {
-            ttl: rendererConfig.cache_ttl,
-            statsInterval: rendererConfig.statsInterval
-        },
-        renderer: {
-            mapnik: rendererConfig.mapnik,
-            http: rendererConfig.http
+          ttl: rendererConfig.cache_ttl
         },
         redis: global.environment.redis,
         enable_cors: global.environment.enable_cors,
         varnish_host: global.environment.varnish.host,
         varnish_port: global.environment.varnish.port,
-        varnish_http_port: global.environment.varnish.http_port,
-        varnish_secret: global.environment.varnish.secret,
-        varnish_purge_enabled: global.environment.varnish.purge_enabled,
-        fastly: global.environment.fastly || {},
         cache_enabled: global.environment.cache_enabled,
         log_format: global.environment.log_format,
         useProfiler: global.environment.useProfiler
     };
-    
-    // Do not send unwatch on release
-    // See http://github.com/CartoDB/Windshaft-cartodb/issues/161
-    me.redis.unwatchOnRelease = false;
 
-    // Re-use redisPool
-    me.redis.pool = redisPool;
-
-    // Re-use pgConnection
-    me.pgConnection = pgConnection;
-    // Re-use pgQueryRunner
-    me.pgQueryRunner = pgQueryRunner;
-
-    var templateMaps = new TemplateMaps(redisPool, {
-        max_user_templates: global.environment.maxUserTemplates
-    });
-    me.templateMaps = templateMaps;
-
-    var mapConfigNamedLayersAdapter = new MapConfigNamedLayersAdapter(templateMaps);
+    // Be nice and warn if configured mapnik version
+    // is != instaled mapnik version
+    if ( mapnik.versions.mapnik != me.grainstore.mapnik_version ) {
+      console.warn("WARNING: detected mapnik version ("
+        + mapnik.versions.mapnik + ") != configured mapnik version ("
+        + me.grainstore.mapnik_version + ")");
+    }
 
 /* This whole block is about generating X-Cache-Channel { */
 
@@ -121,85 +62,141 @@ module.exports = function(redisPool) {
     //       we have no SQL after layer creation.
     me.channelCache = {};
 
+    // Run a query through the SQL api
+    me.sqlQuery = function (username, api_key, sql, callback) {
+      var api = global.environment.sqlapi;
+
+      // build up api string
+      var sqlapi = api.protocol + '://' + username + '.' + api.domain + ':' + api.port + '/api/' + api.version + '/sql'
+
+      var qs  = { q: sql }
+
+      // add api_key if given
+      if (_.isString(api_key) && api_key != '') { qs.api_key = api_key; }
+
+      // call sql api
+      request.get({url:sqlapi, qs:qs, json:true}, function(err, res, body){
+          if (err){
+            console.log('ERROR running connecting to SQL API on ' + sqlapi + ': ' + err);
+            callback(err);
+            return;
+          }
+          if (res.statusCode != 200) {
+              var msg = res.body.error ? res.body.error : res.body;
+              callback(new Error(msg));
+              console.log('unexpected response status (' + res.statusCode + ') for sql query: ' + sql + ': ' + msg);
+              return;
+          }
+          callback(null, body.rows);
+      });
+    };
+
+    //
+    // Invoke callback with number of milliseconds since
+    // last update in any of the given tables
+    //
+    me.findLastUpdated = function (username, api_key, tableNames, callback) {
+      var sql = 'SELECT EXTRACT(EPOCH FROM max(updated_at)) as max FROM CDB_TableMetadata m WHERE m.tabname::name = any (\'{'
+        + tableNames.join(',') + '}\')';
+
+      // call sql api
+      me.sqlQuery(username, api_key, sql, function(err, rows){
+          if (err){
+            var msg = err.message ? err.message : err;
+            callback(new Error('could not find last updated timestamp: ' + msg));
+            return;
+          }
+          // when the table has not updated_at means it hasn't been changed so a default last_updated is set
+          var last_updated = 0;
+          if(rows.length !== 0) {
+            last_updated = rows[0].max || 0;
+          }
+          callback(null, last_updated*1000);
+      });
+    };
+
+    me.affectedTables = function (username, api_key, sql, callback) {
+
+      // Replace mapnik tokens
+      sql = sql.replace(RegExp('!bbox!', 'g'), 'ST_MakeEnvelope(0,0,0,0)')
+               .replace(RegExp('!pixel_width!', 'g'), '1')
+               .replace(RegExp('!pixel_height!', 'g'), '1')
+            ;
+
+      // Pass to CDB_QueryTables
+      sql = 'SELECT CDB_QueryTables($windshaft$' + sql + '$windshaft$)';
+
+      // call sql api
+      me.sqlQuery(username, api_key, sql, function(err, rows){
+          if (err){
+            var msg = err.message ? err.message : err;
+            callback(new Error('could not fetch source tables: ' + msg));
+            return;
+          }
+          var qtables = rows[0].cdb_querytables;
+          var tableNames = qtables.split(/^\{(.*)\}$/)[1];
+          tableNames = tableNames.split(',');
+          callback(null, tableNames);
+      });
+    };
+
     me.buildCacheChannel = function (dbName, tableNames){
       return dbName + ':' + tableNames.join(',');
     };
 
-    me.generateCacheChannel = function(app, req, callback){
-        // Build channelCache key
-        var dbName = req.params.dbname;
-        var cacheKey = [ dbName, req.params.token ].join(':');
+    me.generateMD5 = function(data){
+        var hash = crypto.createHash('md5');
+        hash.update(data);
+        return hash.digest('hex');
+    }
 
-        // no token means no tables associated
-        if (!req.params.token) {
-            return callback(null, this.buildCacheChannel(dbName, []));
-        }
+    me.generateCacheChannel = function(req, callback){
 
-        step(
-            function checkCached() {
-                if ( me.channelCache.hasOwnProperty(cacheKey) ) {
-                    return callback(null, me.channelCache[cacheKey]);
-                }
-                return null;
-            },
-            function extractSQL(err) {
-                assert.ifError(err);
+      // use key to call sql api with sql request if present, else
+      // just return dbname and table name base key
+      var dbName     = req.params.dbname;
 
-                // TODO: cached cache channel for token-based access should
-                //       be constructed at renderer cache creation time
-                // See http://github.com/CartoDB/Windshaft-cartodb/issues/152
-                if ( ! app.mapStore ) {
-                    throw new Error('missing channel cache for token ' + req.params.token);
-                }
-                var mapStore = app.mapStore;
-                step(
-                    function loadFromStore() {
-                        mapStore.load(req.params.token, this);
-                    },
-                    function getSQL(err, mapConfig) {
-                        if (req.profiler) {
-                            req.profiler.done('mapStore_load');
-                        }
-                        assert.ifError(err);
+      var cacheKey = [ dbName ];
+      if ( req.params.token ) cacheKey.push(req.params.token);
+      else if ( req.params.sql ) cacheKey.push( me.generateMD5(req.params.sql) );
+      cacheKey = cacheKey.join(':');
 
-                        var queries = mapConfig.getLayers()
-                            .map(function(lyr) {
-                                return lyr.options.sql;
-                            })
-                            .filter(function(sql) {
-                                return !!sql;
-                            });
+      if ( me.channelCache.hasOwnProperty(cacheKey) ) {
+        callback(null, me.channelCache[cacheKey]);
+        return;
+      }
+      else if ( req.params.token ) {
+        // cached cache channel for token-based access should be constructed
+        // at cache creation time
+        callback(new Error('missing channel cache for token ' + req.params.token));
+        return;
+      }
 
-                        return queries.length ? queries.join(';') : null;
-                    },
-                    this
-                );
-            },
-            function findAffectedTables(err, sql) {
-                assert.ifError(err);
+      if ( ! req.params.sql && ! req.params.token ) {
+        var cacheChannel = me.buildCacheChannel(dbName, [req.params.table]);
+        // not worth caching this
+        callback(null, cacheChannel);
+        return;
+      }
 
-                if ( ! sql ) {
-                    throw new Error("this request doesn't need an X-Cache-Channel generated");
-                }
+      if ( ! req.params.sql ) {
+        callback(new Error("this request doesn't need an X-Cache-Channel generated"));
+        return;
+      }
 
-                queryTablesApi.getAffectedTablesInQuery(cdbRequest.userByReq(req), sql, this); // in addCacheChannel
-            },
-            function buildCacheChannel(err, tableNames) {
-                assert.ifError(err);
+      var dbName     = req.params.dbname;
+      var username   = req.headers.host.split('.')[0];
 
-                if (req.profiler) {
-                    req.profiler.done('affectedTables');
-                }
+      // strip out windshaft/mapnik inserted sql if present
+      var sql = req.params.sql.match(/^\((.*)\)\sas\scdbq$/);
+      sql = (sql != null) ? sql[1] : req.params.sql;
 
-                var cacheChannel = me.buildCacheChannel(dbName,tableNames);
-                me.channelCache[cacheKey] = cacheChannel;
-
-                return cacheChannel;
-            },
-            function finish(err, cacheChannel) {
-                callback(err, cacheChannel);
-            }
-        );
+      me.affectedTables(username, req.params.map_key, sql, function(err, tableNames) {
+          if ( err ) { callback(err); return; }
+          var cacheChannel = me.buildCacheChannel(dbName,tableNames);
+          me.channelCache[cacheKey] = cacheChannel; // store for caching
+          callback(null, cacheChannel);
+      });
     };
 
     // Set the cache chanel info to invalidate the cache on the frontend server
@@ -211,14 +208,13 @@ module.exports = function(redisPool) {
     // @param cb function(err, channel) will be called when ready.
     //           the channel parameter will be null if nothing was added
     //
-    me.addCacheChannel = function(app, req, cb) {
+    me.addCacheChannel = function(req, cb) {
         // skip non-GET requests, or requests for which there's no response
         if ( req.method != 'GET' || ! req.res ) { cb(null, null); return; }
-        if (req.profiler) {
-            req.profiler.start('addCacheChannel');
-        }
         var res = req.res;
-        if ( req.params.token ) {
+        var cache_policy = req.query.cache_policy;
+        if ( req.params.token ) cache_policy = 'persist';
+        if ( cache_policy == 'persist' ) {
           res.header('Cache-Control', 'public,max-age=31536000'); // 1 year
         } else {
           var ttl = global.environment.varnish.ttl || 86400;
@@ -236,11 +232,7 @@ module.exports = function(redisPool) {
         }
         res.header('Last-Modified', lastUpdated.toUTCString());
 
-        me.generateCacheChannel(app, req, function(err, channel){
-            if (req.profiler) {
-                req.profiler.done('generateCacheChannel');
-                req.profiler.end();
-            }
+        me.generateCacheChannel(req, function(err, channel){
             if ( ! err ) {
               res.header('X-Cache-Channel', channel);
               cb(null, channel);
@@ -252,62 +244,10 @@ module.exports = function(redisPool) {
         });
     };
 
-
-    if (global.environment.enabledFeatures.onTileErrorStrategy !== false) {
-        me.renderer.onTileErrorStrategy = function(err, tile, headers, stats, format, callback) {
-            if (err && err.message === 'Render timed out' && format === 'png') {
-                return callback(null, timeoutErrorTile, { 'Content-Type': 'image/png' }, {});
-            } else {
-                return callback(err, tile, headers, stats);
-            }
-        };
-    }
-
-    me.renderCache.beforeRendererCreate = function(req, callback) {
-        var user = cdbRequest.userByReq(req);
-
-        var rendererOptions = {};
-
-        step(
-            function getLimits(err) {
-                assert.ifError(err);
-                cartoData.getTilerRenderLimit(user, this);
-            },
-            function handleTilerLimits(err, renderLimit) {
-                assert.ifError(err);
-                rendererOptions.limits = {
-                    cacheOnTimeout: rendererConfig.mapnik.limits.cacheOnTimeout || false,
-                    render: renderLimit || rendererConfig.mapnik.limits.render || 0
-                };
-                return null;
-            },
-            function finish(err) {
-                if (err) {
-                    return callback(err);
-                }
-
-                return callback(null, rendererOptions);
-            }
-        );
-    };
-
-    me.beforeLayergroupCreate = function(req, requestMapConfig, callback) {
-        mapConfigNamedLayersAdapter.getLayers(cdbRequest.userByReq(req), requestMapConfig.layers, pgConnection,
-            function(err, layers, datasource) {
-                if (err) {
-                    return callback(err);
-                }
-
-                requestMapConfig.layers = layers;
-                return callback(null, requestMapConfig, datasource);
-            }
-        );
-    };
-
     me.afterLayergroupCreate = function(req, mapconfig, response, callback) {
         var token = response.layergroupid;
 
-        var username = cdbRequest.userByReq(req);
+        var username = cartoData.userFromHostname(req.headers.host);
 
         var tasksleft = 2; // redis key and affectedTables
         var errors = [];
@@ -320,219 +260,48 @@ module.exports = function(redisPool) {
             err = errors.length ? new Error(errors.join('\n')) : null;
             callback(err);
           }
-        };
-
-        // include in layergroup response the variables in serverMedata
-        // those variables are useful to send to the client information
-        // about how to reach this server or information about it
-        var serverMetadata = global.environment.serverMetadata;
-        if (serverMetadata) {
-          _.extend(response, serverMetadata);
         }
 
         // Don't wait for the mapview count increment to
         // take place before proceeding. Error will be logged
         // asyncronously
         cartoData.incMapviewCount(username, mapconfig.stat_tag, function(err) {
-          if (req.profiler) {
-              req.profiler.done('incMapviewCount');
-          }
-          if ( err ) {
-              console.log("ERROR: failed to increment mapview count for user '" + username + "': " + err);
-          }
+          if (req.profiler) req.profiler.done('incMapviewCount');
+          if ( err ) console.log("ERROR: failed to increment mapview count for user '" + username + "': " + err);
           done();
         });
 
-        var sql = mapconfig.layers.map(function(layer) {
-            return layer.options.sql;
-        }).join(';');
+        var sql = [];
+        _.each(mapconfig.layers, function(lyr) {
+          sql.push(lyr.options.sql);
+        });
+        sql = sql.join(';');
 
         var dbName = req.params.dbname;
+        var usr    = req.headers.host.split('.')[0];
+        var key    = req.params.map_key;
+
         var cacheKey = dbName + ':' + token;
 
-        step(
-            function getAffectedTablesAndLastUpdatedTime() {
-                queryTablesApi.getAffectedTablesAndLastUpdatedTime(username, sql, this);
-            },
-            function handleAffectedTablesAndLastUpdatedTime(err, result) {
-                if (req.profiler) {
-                    req.profiler.done('queryTablesAndLastUpdated');
-                }
-                assert.ifError(err);
-                var cacheChannel = me.buildCacheChannel(dbName, result.affectedTables);
-                me.channelCache[cacheKey] = cacheChannel;
+        me.affectedTables(usr, key, sql, function(err, tableNames) {
+            if (req.profiler) req.profiler.done('affectedTables');
 
-                // last update for layergroup cache buster
-                response.layergroupid = response.layergroupid + ':' + result.lastUpdatedTime;
-                response.last_updated = new Date(result.lastUpdatedTime).toISOString();
-
-                var res = req.res;
-                if (res) {
-                    if (req.method === 'GET') {
-                        var ttl = global.environment.varnish.layergroupTtl || 86400;
-                        res.header('Cache-Control', 'public,max-age='+ttl+',must-revalidate');
-                        res.header('Last-Modified', (new Date()).toUTCString());
-                        res.header('X-Cache-Channel', cacheChannel);
-                    }
-
-                    res.header('X-Layergroup-Id', response.layergroupid);
-                }
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
+            if ( err ) { done(err); return; }
+            var cacheChannel = me.buildCacheChannel(dbName,tableNames);
+            me.channelCache[cacheKey] = cacheChannel; // store for caching
+            // find last updated
+            me.findLastUpdated(usr, key, tableNames, function(err, lastUpdated) {
+              if (req.profiler) req.profiler.done('findLastUpdated');
+              if ( err ) { done(err); return; }
+              response.layergroupid = response.layergroupid + ':' + lastUpdated; // use epoch
+              response.last_updated = new Date(lastUpdated).toISOString(); // TODO: use ISO format
+              done(null);
+            });
+        });
     };
 
 /* X-Cache-Channel generation } */
 
-    // Check if a request is authorized by a signer
-    //
-    // @param req express request object
-    // @param callback function(err, signed_by) signed_by will be
-    //                 null if the request is not signed by anyone
-    //                 or will be a string cartodb username otherwise.
-    //                 
-    me.authorizedBySigner = function(req, callback) {
-        if ( ! req.params.token || ! req.params.signer ) {
-            return callback(null, null); // no signer requested
-        }
-
-        var signer = req.params.signer;
-        var layergroup_id = req.params.token;
-        var auth_token = req.params.auth_token;
-
-        var mapStore = req.app.mapStore;
-        if (!mapStore) {
-            throw new Error('Unable to retrieve map configuration token');
-        }
-
-        mapStore.load(layergroup_id, function(err, mapConfig) {
-            if (err) {
-                return callback(err);
-            }
-
-            var authorized = me.templateMaps.isAuthorized(mapConfig.obj().template, auth_token);
-
-            return callback(null, authorized ? signer : null);
-        });
-    };
-
-    // Check if a request is authorized by api_key
-    //
-    // @param req express request object
-    // @param callback function(err, authorized) 
-    //        NOTE: authorized is expected to be 0 or 1 (integer)
-    //                 
-    me.authorizedByAPIKey = function(req, callback)
-    {
-        var givenKey = req.query.api_key || req.query.map_key;
-        if ( ! givenKey && req.body ) {
-          // check also in request body
-          givenKey = req.body.api_key || req.body.map_key;
-        }
-        if ( ! givenKey ) {
-          callback(null, 0); // no api key, no authorization...
-          return;
-        }
-        //console.log("given ApiKey: " + givenKey);
-        var user = cdbRequest.userByReq(req);
-        step(
-          function (){
-              cartoData.getUserMapKey(user, this);
-          },
-          function checkApiKey(err, val){
-              assert.ifError(err);
-              return ( val && givenKey == val ) ? 1 : 0;
-          },
-          function finish(err, authorized) {
-              callback(err, authorized);
-          }
-        );
-    };
-
-    /**
-     * Check access authorization
-     *
-     * @param req - standard req object. Importantly contains table and host information
-     * @param callback function(err, allowed) is access allowed not?
-     */
-    me.authorize = function(req, callback) {
-        var that = this;
-        var user = cdbRequest.userByReq(req);
-
-        step(
-            function (){
-                that.authorizedByAPIKey(req, this);
-            },
-            function checkApiKey(err, authorized){
-                if (req.profiler) {
-                    req.profiler.done('authorizedByAPIKey');
-                }
-                assert.ifError(err);
-
-                // if not authorized by api_key, continue 
-                if (authorized !== 1)  {
-                  // not authorized by api_key, 
-                  // check if authorized by signer
-                  that.authorizedBySigner(req, this);
-                  return;
-                }
-
-                // authorized by api key, login as the given username and stop
-                pgConnection.setDBAuth(user, req.params, function(err) {
-                  callback(err, true); // authorized (or error)
-                });
-            },
-            function checkSignAuthorized(err, signed_by){
-                if (err) {
-                    return callback(err);
-                }
-
-                if ( ! signed_by ) {
-                  // request not authorized by signer.
-
-                  // if no signer name was given, let dbparams and
-                  // PostgreSQL do the rest.
-                  // 
-                  if ( ! req.params.signer ) {
-                    callback(null, true); // authorized so far
-                    return;
-                  }
-
-                  // if signer name was given, return no authorization
-                  callback(null, false); 
-                  return;
-                }
-
-                pgConnection.setDBAuth(signed_by, req.params, function(err) {
-                  if (req.profiler) {
-                      req.profiler.done('setDBAuth');
-                  }
-                  callback(err, true); // authorized (or error)
-                });
-            }
-        );
-    };
-
-    me.setDBParams = function(cdbuser, params, callback) {
-        step(
-            function setAuth() {
-                pgConnection.setDBAuth(cdbuser, params, this);
-            },
-            function setConn(err) {
-                if ( err ) throw err;
-                pgConnection.setDBConn(cdbuser, params, this);
-            },
-            function finish(err) {
-                callback(err);
-            }
-        );
-    };
-
-    // jshint maxcomplexity:10
     /**
      * Whitelist input and get database name & default geometry type from
      * subdomain/user metadata held in CartoDB Redis
@@ -543,109 +312,165 @@ module.exports = function(redisPool) {
 
         if ( req.query.lzma ) {
 
+          // TODO: check ?
+          //console.log("type of req.query.lzma is " + typeof(req.query.lzma));
+
           // Decode (from base64)
-          var lzma = new Buffer(req.query.lzma, 'base64')
-              .toString('binary')
-              .split('')
-              .map(function(c) {
-                  return c.charCodeAt(0) - 128;
-              });
+          var lzma = (new Buffer(req.query.lzma, 'base64').toString('binary')).split('').map(function(c) { return c.charCodeAt(0) - 128 })
 
           // Decompress
-          lzmaWorker.decompress(
+          LZMA.decompress(
             lzma,
             function(result) {
-              if (req.profiler) {
-                  req.profiler.done('lzma');
-              }
+              if (req.profiler) req.profiler.done('LZMA decompress');
               try {
-                delete req.query.lzma;
-                _.extend(req.query, JSON.parse(result));
+                delete req.query.lzma
+                _.extend(req.query, JSON.parse(result))
                 me.req2params(req, callback);
               } catch (err) {
                 callback(new Error('Error parsing lzma as JSON: ' + err));
               }
+            },
+            function(percent) { // progress
+              //console.log("LZMA decompression " + percent + "%");
             }
           );
           return;
         }
 
-        req.query = _.pick(req.query, REQUEST_QUERY_PARAMS_WHITELIST);
-        req.params = _.extend({}, req.params); // shuffle things as request is a strange array/object
+        // Whitelist query parameters and attach format
+        var good_query = ['sql', 'geom_type', 'cache_buster', 'cache_policy', 'callback', 'interactivity', 'map_key', 'api_key', 'style', 'style_version', 'style_convert', 'config' ];
+        var bad_query  = _.difference(_.keys(req.query), good_query);
 
-        var user = cdbRequest.userByReq(req);
+        _.each(bad_query, function(key){ delete req.query[key]; });
+        req.params =  _.extend({}, req.params); // shuffle things as request is a strange array/object
 
         if ( req.params.token ) {
           //console.log("Request parameters include token " + req.params.token);
           var tksplit = req.params.token.split(':');
           req.params.token = tksplit[0];
-          if ( tksplit.length > 1 ) {
-              req.params.cache_buster= tksplit[1];
-          }
-          tksplit = req.params.token.split('@');
-          if ( tksplit.length > 1 ) {
-            req.params.signer = tksplit.shift();
-            if ( ! req.params.signer ) {
-                req.params.signer = user;
-            }
-            else if ( req.params.signer !== user ) {
-              var err = new Error('Cannot use map signature of user "' + req.params.signer + '" on database of user "' +
-                  user + '"');
-              err.http_status = 403;
-              callback(err);
-              return;
-            }
-            if ( tksplit.length > 1 ) {
-              /*var template_hash = */tksplit.shift(); // unused
-            }
-            req.params.token = tksplit.shift(); 
-            //console.log("Request for token " + req.params.token + " with signature from " + req.params.signer);
-          }
+          if ( tksplit.length > 1 ) req.params.cache_buster= tksplit[1];
         }
 
         // bring all query values onto req.params object
         _.extend(req.params, req.query);
 
-        if (req.profiler) {
-            req.profiler.done('req2params.setup');
+        // for cartodb, ensure interactivity is cartodb_id or user specified
+        req.params.interactivity = req.params.interactivity || 'cartodb_id';
+
+        req.params.processXML = function(req, xml, callback) {
+          var dbuser = req.params.dbuser || global.settings.postgres.user;
+          if ( ! me.rx_dbuser ) me.rx_dbuser = /(<Parameter name="user"><!\[CDATA\[)[^\]]*(]]><\/Parameter>)/g;
+          xml = xml.replace(me.rx_dbuser, "$1" + dbuser + "$2");
+          callback(null, xml);
         }
 
-        step(
+        var that = this;
+
+        if (req.profiler) req.profiler.done('req2params.setup');
+
+        Step(
             function getPrivacy(){
-                me.authorize(req, this);
+                cartoData.authorize(req, this);
             },
-            function gatekeep(err, authorized){
-                if (req.profiler) {
-                    req.profiler.done('authorize');
-                }
-                assert.ifError(err);
-                if(!authorized) {
-                  err = new Error("Sorry, you are unauthorized (permission denied)");
-                  err.http_status = 403;
-                  throw err;
-                }
-                return null;
+            function gatekeep(err, data){
+        if (req.profiler) req.profiler.done('cartoData.authorize');
+                if(err) throw err;
+                if(data === "0") throw new Error("Sorry, you are unauthorized (permission denied)");
+                return data;
             },
-            function getDatabase(err){
-                assert.ifError(err);
-                pgConnection.setDBConn(user, req.params, this);
+            function getDatabase(err, data){
+                if(err) throw err;
+
+                cartoData.getDatabase(req, this);
             },
-            function finishSetup(err) {
+            function getGeometryType(err, data){
+        if (req.profiler) req.profiler.done('cartoData.getDatabase');
+                if (err) throw err;
+                _.extend(req.params, {dbname:data});
+
+                cartoData.getGeometryType(req, this);
+            },
+            function finishSetup(err, data){
+        if (req.profiler) req.profiler.done('cartoData.getGeometryType');
                 if ( err ) { callback(err, req); return; }
 
-                // Add default database connection parameters
-                // if none given
-                _.defaults(req.params, {
-                  dbuser: global.environment.postgres.user,
-                  dbpassword: global.environment.postgres.password,
-                  dbhost: global.environment.postgres.host,
-                  dbport: global.environment.postgres.port
-                });
+                if (!_.isNull(data))
+                    _.extend(req.params, {geom_type: data});
 
-                callback(null, req);
+                that.addCacheChannel(req, function(err) {
+        if (req.profiler) req.profiler.done('addCacheChannel');
+                  callback(err, req);
+                });
+            }
+        );
+    };
+
+    /**
+     * Little helper method to get the current list of infowindow variables and return to client
+     * @param req
+     * @param callback
+     */
+    me.getInfowindow = function(req, callback){
+        var that = this;
+
+        Step(
+            function(){
+                that.req2params(req, this);
+            },
+            function(err, data){
+                if (err) callback(err, null);
+                else cartoData.getInfowindow(data, callback);
+            }
+        );
+    };
+
+    /**
+     * Little helper method to get map metadata and return to client
+     * @param req
+     * @param callback
+     */
+    me.getMapMetadata = function(req, callback){
+        var that = this;
+
+        Step(
+            function(){
+                that.req2params(req, this);
+            },
+            function(err, data){
+                if (err) callback(err, null);
+                else cartoData.getMapMetadata(data, callback);
+            }
+        );
+    };
+
+    /**
+     * Helper to clear out tile cache on request
+     * @param req
+     * @param callback
+     */
+    me.flushCache = function(req, Cache, callback){
+        var that = this;
+
+        Step(
+            function getParams(){
+                // this is mostly to compute req.params.dbname
+                that.req2params(req, this);
+            },
+            function flushInternalCache(err){
+                // TODO: implement this, see
+                // http://github.com/Vizzuality/Windshaft-cartodb/issues/73
+                return true;
+            },
+            function flushVarnishCache(err){
+                if (err) { callback(err); return; }
+                if(Cache) {
+                  Cache.invalidate_db(req.params.dbname, req.params.table);
+                }
+                callback(null, true);
             }
         );
     };
 
     return me;
-};
+}();

lib/cartodb/template_maps.js

@@ -1,506 +0,0 @@
-var crypto = require('crypto');
-var step = require('step');
-var _ = require('underscore');
-var dot = require('dot');
-
-
-var EventEmitter = require('events').EventEmitter;
-var util = require('util');
-
-
-// Class handling map templates
-//
-// See http://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps
-//
-// @param redis_pool an instance of a "redis-mpool"
-//        See https://github.com/CartoDB/node-redis-mpool
-//        Needs version 0.x.x of the API.
-//
-// @param opts TemplateMap options. Supported elements:
-//    'max_user_templates' limit on the number of per-user
-//
-// 
-function TemplateMaps(redis_pool, opts) {
-  if (!(this instanceof TemplateMaps)) return new TemplateMaps();
-
-  EventEmitter.call(this);
-
-  this.redis_pool = redis_pool;
-  this.opts = opts || {};
-
-  // Database containing templates
-  // TODO: allow configuring ?
-  // NOTE: currently it is the same as
-  //       the one containing layergroups
-  this.db_signatures = 0;
-
-  //
-  // Map templates are owned by a user that specifies access permissions
-  // for their instances.
-  // 
-  // We have the following datastores:
-  //
-  //  1. User templates: set of per-user map templates
-
-  // User templates (HASH:tpl_id->tpl_val)
-  this.key_usr_tpl = dot.template("map_tpl|{{=it.owner}}");
-}
-
-util.inherits(TemplateMaps, EventEmitter);
-
-module.exports = TemplateMaps;
-
-
-var o = TemplateMaps.prototype;
-
-//--------------- PRIVATE METHODS --------------------------------
-
-o._userTemplateLimit = function() {
-  return this.opts.max_user_templates || 0;
-};
-
-/**
- * Internal function to communicate with redis
- *
- * @param redisFunc - the redis function to execute
- * @param redisArgs - the arguments for the redis function in an array
- * @param callback - function to pass results too.
- */
-o._redisCmd = function(redisFunc, redisArgs, callback) {
-  var redisClient;
-  var that = this;
-  var db = that.db_signatures;
-
-  step(
-    function getRedisClient() {
-      that.redis_pool.acquire(db, this);
-    },
-    function executeQuery(err, data) {
-      if ( err ) throw err;
-      redisClient = data;
-      redisArgs.push(this);
-      redisClient[redisFunc.toUpperCase()].apply(redisClient, redisArgs);
-    },
-    function releaseRedisClient(err, data) {
-      if ( ! _.isUndefined(redisClient) ) that.redis_pool.release(db, redisClient);
-      callback(err, data);
-    }
-  );
-};
-
-var _reValidNameIdentifier = /^[a-z0-9][0-9a-z_\-]*$/i;
-var _reValidPlaceholderIdentifier = /^[a-z][0-9a-z_]*$/i;
-// jshint maxcomplexity:15
-o._checkInvalidTemplate = function(template) {
-  if ( template.version != '0.0.1' ) {
-    return new Error("Unsupported template version " + template.version);
-  }
-  var tplname = template.name;
-  if ( ! tplname ) {
-    return new Error("Missing template name");
-  }
-  if ( ! tplname.match(_reValidNameIdentifier) ) {
-    return new Error("Invalid characters in template name '" + tplname + "'");
-  }
-
-  var invalidError = isInvalidLayergroup(template.layergroup);
-  if (invalidError) {
-    return invalidError;
-  }
-
-  var placeholders = template.placeholders || {};
-
-  var placeholderKeys = Object.keys(placeholders);
-  for (var i = 0, len = placeholderKeys.length; i < len; i++) {
-      var placeholderKey = placeholderKeys[i];
-
-      if (!placeholderKey.match(_reValidPlaceholderIdentifier)) {
-          return new Error("Invalid characters in placeholder name '" + placeholderKey + "'");
-      }
-      if ( ! placeholders[placeholderKey].hasOwnProperty('default') ) {
-          return new Error("Missing default for placeholder '" + placeholderKey + "'");
-      }
-      if ( ! placeholders[placeholderKey].hasOwnProperty('type') ) {
-          return new Error("Missing type for placeholder '" + placeholderKey + "'");
-      }
-  }
-
-    var auth = template.auth || {};
-
-    switch ( auth.method ) {
-        case 'open':
-            break;
-        case 'token':
-            if ( ! _.isArray(auth.valid_tokens) )
-                return new Error("Invalid 'token' authentication: missing valid_tokens");
-            if ( ! auth.valid_tokens.length )
-                return new Error("Invalid 'token' authentication: no valid_tokens");
-            break;
-        default:
-            return new Error("Unsupported authentication method: " + auth.method);
-    }
-
-    return false;
-};
-
-function isInvalidLayergroup(layergroup) {
-    if (!layergroup) {
-        return new Error('Missing layergroup');
-    }
-
-    var layers = layergroup.layers;
-
-    if (!_.isArray(layers) || layers.length === 0) {
-        return new Error('Missing or empty layers array from layergroup config');
-    }
-
-    var invalidLayers = layers
-        .map(function(layer, layerIndex) {
-            return layer.options ? null : layerIndex;
-        })
-        .filter(function(layerIndex) {
-            return layerIndex !== null;
-        });
-
-    if (invalidLayers.length) {
-        return new Error('Missing `options` in layergroup config for layers: ' + invalidLayers.join(', '));
-    }
-
-    return false;
-}
-
-function templateDefaults(template) {
-    var templateAuth = _.defaults({}, template.auth || {}, {
-        method: 'open'
-    });
-    return _.defaults({ auth: templateAuth }, template, {
-        placeholders: {}
-    });
-}
-
-//--------------- PUBLIC API -------------------------------------
-
-// Add a template
-//
-// NOTE: locks user+template_name or fails
-//
-// @param owner cartodb username of the template owner
-//
-// @param template layergroup template, see
-//        http://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps#template-format
-//
-// @param callback function(err, tpl_id) 
-//        Return template identifier (only valid for given user)
-//
-o.addTemplate = function(owner, template, callback) {
-    var self = this;
-
-    template = templateDefaults(template);
-
-    var invalidError = this._checkInvalidTemplate(template);
-    if ( invalidError ) {
-        return callback(invalidError);
-    }
-
-    var templateName = template.name;
-    var userTemplatesKey = this.key_usr_tpl({ owner:owner });
-    var limit = this._userTemplateLimit();
-
-    step(
-        function checkLimit() {
-            if ( ! limit ) {
-                return 0;
-            }
-            self._redisCmd('HLEN', [ userTemplatesKey ], this);
-        },
-        function installTemplateIfDoesNotExist(err, numberOfTemplates) {
-            if ( err ) {
-                throw err;
-            }
-            if ( limit && numberOfTemplates >= limit ) {
-                throw new Error("User '" + owner + "' reached limit on number of templates " +
-                    "("+ numberOfTemplates + "/" + limit + ")");
-            }
-            self._redisCmd('HSETNX', [ userTemplatesKey, templateName, JSON.stringify(template) ], this);
-        },
-        function validateInstallation(err, wasSet) {
-            if ( err ) {
-                throw err;
-            }
-            if ( ! wasSet ) {
-                throw new Error("Template '" + templateName + "' of user '" + owner + "' already exists");
-            }
-
-            return true;
-        },
-        function finish(err) {
-            if (!err) {
-                self.emit('add', owner, templateName, template);
-            }
-
-            callback(err, templateName, template);
-        }
-  );
-};
-
-// Delete a template
-//
-// @param owner cartodb username of the template owner
-//
-// @param tpl_id template identifier as returned
-//        by addTemplate or listTemplates
-//
-// @param callback function(err)
-//
-o.delTemplate = function(owner, tpl_id, callback) {
-    var self = this;
-    step(
-        function deleteTemplate() {
-            self._redisCmd('HDEL', [ self.key_usr_tpl({ owner:owner }), tpl_id ], this);
-        },
-        function handleDeletion(err, deleted) {
-            if (err) {
-                throw err;
-            }
-            if (!deleted) {
-                throw new Error("Template '" + tpl_id + "' of user '" + owner + "' does not exist");
-            }
-            return true;
-        },
-        function finish(err) {
-            if (!err) {
-                self.emit('delete', owner, tpl_id);
-            }
-
-            callback(err);
-        }
-    );
-};
-
-// Update a template
-//
-// NOTE: locks user+template_name or fails
-//
-// Also deletes and re-creates associated authentication certificate,
-// which in turn deletes all instance signatures
-//
-// @param owner cartodb username of the template owner
-//
-// @param tpl_id template identifier as returned by addTemplate
-//
-// @param template layergroup template, see
-//        http://github.com/CartoDB/Windshaft-cartodb/wiki/Template-maps#template-format
-//
-// @param callback function(err)
-//        
-o.updTemplate = function(owner, tpl_id, template, callback) {
-    var self = this;
-
-    template = templateDefaults(template);
-
-    var invalidError = this._checkInvalidTemplate(template);
-
-    if ( invalidError ) {
-        return callback(invalidError);
-    }
-
-    var templateName = template.name;
-
-    if ( tpl_id != templateName ) {
-        return callback(new Error("Cannot update name of a map template ('" + tpl_id + "' != '" + templateName + "')"));
-    }
-
-    var userTemplatesKey = this.key_usr_tpl({ owner:owner });
-
-    step(
-        function getExistingTemplate() {
-            self._redisCmd('HGET', [ userTemplatesKey, tpl_id ], this);
-        },
-        function updateTemplate(err, currentTemplate) {
-            if (err) {
-                throw err;
-            }
-            if (!currentTemplate) {
-                throw new Error("Template '" + tpl_id + "' of user '" + owner + "' does not exist");
-            }
-            self._redisCmd('HSET', [ userTemplatesKey, templateName, JSON.stringify(template) ], this);
-        },
-        function handleTemplateUpdate(err, didSetNewField) {
-            if (err) {
-                throw err;
-            }
-            if (didSetNewField) {
-                console.warn('New template created on update operation');
-            }
-            return true;
-        },
-        function finish(err) {
-            if (!err) {
-                self.emit('update', owner, templateName, template);
-            }
-
-            callback(err, template);
-        }
-    );
-};
-
-// List user templates
-//
-// @param owner cartodb username of the templates owner
-//
-// @param callback function(err, tpl_id_list)
-//        Returns a list of template identifiers
-// 
-o.listTemplates = function(owner, callback) {
-    this._redisCmd('HKEYS', [ this.key_usr_tpl({owner:owner}) ], callback);
-};
-
-// Get a templates
-//
-// @param owner cartodb username of the template owner
-//
-// @param tpl_id template identifier as returned
-//        by addTemplate or listTemplates
-//
-// @param callback function(err, template)
-//        Return full template definition
-//
-o.getTemplate = function(owner, tpl_id, callback) {
-    var self = this;
-    step(
-        function getTemplate() {
-            self._redisCmd('HGET', [ self.key_usr_tpl({owner:owner}), tpl_id ], this);
-        },
-        function parseTemplate(err, tpl_val) {
-            if ( err ) throw err;
-            return JSON.parse(tpl_val);
-        },
-        function finish(err, tpl) {
-            callback(err, tpl);
-        }
-    );
-};
-
-o.isAuthorized = function(template, authTokens) {
-    if (!template) {
-        return false;
-    }
-
-    authTokens = _.isArray(authTokens) ? authTokens : [authTokens];
-
-    var templateAuth = template.auth;
-
-    if (!templateAuth) {
-        return false;
-    }
-
-    if (_.isString(templateAuth) && templateAuth === 'open') {
-        return true;
-    }
-
-    if (templateAuth.method === 'open') {
-        return true;
-    }
-
-    if (templateAuth.method === 'token') {
-        return _.intersection(templateAuth.valid_tokens, authTokens).length > 0;
-    }
-
-    return false;
-};
-
-// Perform placeholder substitutions on a template
-//
-// @param template a template object (will not be modified)
-//
-// @param params an object containing named subsitution parameters
-//        Only the ones found in the template's placeholders object
-//        will be used, with missing ones taking default values.
-//
-// @returns a layergroup configuration 
-//
-// @throws Error on malformed template or parameter
-//
-var _reNumber = /^([-+]?[\d\.]?\d+([eE][+-]?\d+)?)$/,
-    _reCSSColorName = /^[a-zA-Z]+$/,
-    _reCSSColorVal = /^#[0-9a-fA-F]{3,6}$/;
-
-function _replaceVars (str, params) {
-  //return _.template(str, params); // lazy way, possibly dangerous 
-  // Construct regular expressions for each param
-    Object.keys(params).forEach(function(k) {
-        str = str.replace(new RegExp("<%=\\s*" + k + "\\s*%>", "g"), params[k]);
-    });
-    return str;
-}
-o.instance = function(template, params) {
-  var all_params = {};
-  var phold = template.placeholders || {};
-  Object.keys(phold).forEach(function(k) {
-    var val = params.hasOwnProperty(k) ? params[k] : phold[k].default;
-    var type = phold[k].type;
-    // properly escape
-    if ( type === 'sql_literal' ) {
-      // duplicate any single-quote
-      val = val.replace(/'/g, "''");
-    }
-    else if ( type === 'sql_ident' ) {
-      // duplicate any double-quote
-      val = val.replace(/"/g, '""');
-    }
-    else if ( type === 'number' ) {
-      // check it's a number
-      if ( typeof(val) !== 'number' && ! val.match(_reNumber) ) {
-        throw new Error("Invalid number value for template parameter '" + k + "': " + val);
-      }
-    }
-    else if ( type === 'css_color' ) {
-      // check it only contains letters or
-      // starts with # and only contains hexdigits
-      if ( ! val.match(_reCSSColorName) && ! val.match(_reCSSColorVal) ) {
-        throw new Error("Invalid css_color value for template parameter '" + k + "': " + val);
-      }
-    }
-    else {
-      // NOTE: should be checked at template create/update time
-      throw new Error("Invalid placeholder type '" + type + "'");
-    }
-    all_params[k] = val;
-  });
-
-  // NOTE: we're deep-cloning the layergroup here
-  var layergroup = JSON.parse(JSON.stringify(template.layergroup));
-  for (var i=0; i<layergroup.layers.length; ++i) {
-    var lyropt = layergroup.layers[i].options;
-    if ( lyropt.cartocss ) lyropt.cartocss = _replaceVars(lyropt.cartocss, all_params);
-    if ( lyropt.sql) lyropt.sql = _replaceVars(lyropt.sql, all_params);
-    // Anything else ?
-  }
-
-  // extra information about the template
-  layergroup.template = {
-    name: template.name,
-    auth: template.auth
-  };
-
-  return layergroup;
-};
-
-// Return a fingerPrint of the object
-o.fingerPrint = function(template) {
-  return crypto.createHash('md5')
-    .update(JSON.stringify(template))
-    .digest('hex')
-  ;
-};
-
-module.exports.templateName = function templateName(templateId) {
-    var templateIdTokens = templateId.split('@');
-    var name = templateIdTokens[0];
-
-    if (templateIdTokens.length > 1) {
-        name = templateIdTokens[1];
-    }
-
-    return name;
-};

package.json

@@ -1,11 +1,8 @@
 {
     "private": true,
     "name": "windshaft-cartodb",
-    "version": "2.5.0",
+    "version": "1.3.6",
     "description": "A map tile server for CartoDB",
-    "keywords": [
-      "cartodb"
-    ],
     "url": "https://github.com/CartoDB/Windshaft-cartodb",
     "licenses": [{
         "type": "BSD",
@@ -22,34 +19,23 @@
       "Sandro Santilli <strk@vizzuality.com>"
     ],
     "dependencies": {
-        "underscore"  : "~1.6.0",
-        "dot": "~1.0.2",
-        "windshaft": "0.45.0",
-        "step": "~0.0.5",
-        "queue-async": "~1.0.7",
-        "request": "~2.9.203",
-        "cartodb-redis": "~0.13.0",
-        "cartodb-psql": "~0.4.0",
-        "fastly-purge": "~1.0.0",
-        "redis-mpool": "~0.3.0",
-        "lzma": "~1.3.7",
-        "log4js": "https://github.com/CartoDB/log4js-node/tarball/cdb"
+        "node-varnish": "0.1.1",
+        "underscore"  : "~1.3.3",
+        "windshaft"  : "~0.13.7",
+        "step": "0.0.x",
+        "generic-pool": "~2.0.3",
+        "redis": "~0.8.3",
+        "hiredis": "~0.1.14",
+        "request": "2.9.202",
+        "mapnik": "~0.7.14",
+        "strftime": "~0.6.0",
+        "lzma": "~1.2.3"
     },
     "devDependencies": {
-        "istanbul": "~0.3.6",
-        "mocha": "~1.21.4",
-        "nock": "~1.3.0",
-        "jshint": "~2.6.0",
-        "redis": "~0.8.6",
-        "strftime": "~0.8.2",
-        "semver": "~1.1.4"
+        "mocha": "1.2.1",
+        "semver": "~1.1.0"
     },
     "scripts": {
-        "preinstall": "make pre-install",
-        "test": "make test-all"
-    },
-    "engines": {
-        "node": ">=0.8 <0.11",
-        "npm": ">=1.2.1"
+        "test": "make check"
     }
 }

run_tests.sh

@@ -1,12 +1,7 @@
 #!/bin/sh
 
-OPT_CREATE_REDIS=yes # create the redis test environment
-OPT_CREATE_PGSQL=yes # create the PostgreSQL test environment
-OPT_DROP_REDIS=yes   # drop the redis test environment
-OPT_DROP_PGSQL=yes   # drop the PostgreSQL test environment
-OPT_COVERAGE=no      # run tests with coverage
-
-export PGAPPNAME=cartodb_tiler_tester
+OPT_CREATE=yes # create the test environment
+OPT_DROP=yes   # drop the test environment
 
 cd $(dirname $0)
 BASEDIR=$(pwd)
@@ -16,7 +11,7 @@ REDIS_PORT=`node -e "console.log(require('${BASEDIR}/config/environments/test.js
 export REDIS_PORT
 
 cleanup() {
-  if test x"$OPT_DROP_REDIS" = xyes; then
+  if test x"$OPT_DROP" = xyes; then
     if test x"$PID_REDIS" = x; then
       PID_REDIS=$(cat ${BASEDIR}/redis.pid)
       if test x"$PID_REDIS" = x; then
@@ -24,13 +19,9 @@ cleanup() {
         return;
       fi
     fi
-    echo "Killing test redis pid ${PID_REDIS}"
+    echo "Cleaning up"
     kill ${PID_REDIS}
   fi
-  if test x"$OPT_DROP_PGSQL" = xyes; then
-    # TODO: drop postgresql ?
-    echo "Dropping PostgreSQL test database isn't implemented yet"
-  fi
 }
 
 cleanup_and_exit() {
@@ -48,36 +39,12 @@ die() {
 trap 'cleanup_and_exit' 1 2 3 5 9 13
 
 while [ -n "$1" ]; do
-        # This is kept for backward compatibility
         if test "$1" = "--nodrop"; then
-                OPT_DROP_REDIS=no
-                OPT_DROP_PGSQL=no
+                OPT_DROP=no
                 shift
                 continue
-        elif test "$1" = "--nodrop-pg"; then
-                OPT_DROP_PGSQL=no
-                shift
-                continue
-        elif test "$1" = "--nodrop-redis"; then
-                OPT_DROP_REDIS=no
-                shift
-                continue
-        elif test "$1" = "--nocreate-pg"; then
-                OPT_CREATE_PGSQL=no
-                shift
-                continue
-        elif test "$1" = "--nocreate-redis"; then
-                OPT_CREATE_REDIS=no
-                shift
-                continue
-        elif test "$1" = "--with-coverage"; then
-                OPT_COVERAGE=yes
-                shift
-                continue
-        # This is kept for backward compatibility
         elif test "$1" = "--nocreate"; then
-                OPT_CREATE_REDIS=no
-                OPT_CREATE_PGSQL=no
+                OPT_CREATE=no
                 shift
                 continue
         else
@@ -90,41 +57,25 @@ if [ -z "$1" ]; then
         echo "Options:" >&2
         echo " --nocreate   do not create the test environment on start" >&2
         echo " --nodrop     do not drop the test environment on exit" >&2
-        echo " --with-coverage   use istanbul to determine code coverage" >&2
         exit 1
 fi
 
 TESTS=$@
 
-if test x"$OPT_CREATE_REDIS" = xyes; then
+if test x"$OPT_CREATE" = xyes; then
   echo "Starting redis on port ${REDIS_PORT}"
   echo "port ${REDIS_PORT}" | redis-server - > ${BASEDIR}/test.log &
   PID_REDIS=$!
   echo ${PID_REDIS} > ${BASEDIR}/redis.pid
-fi
 
-PREPARE_DB_OPTS=
-if test x"$OPT_CREATE_PGSQL" != xyes; then
-  PREPARE_DB_OPTS="$PREPARE_DB_OPTS --skip-pg"
+  echo "Preparing the environment"
+  cd ${BASEDIR}/test/support; sh prepare_db.sh || die "database preparation failure"; cd -
 fi
-if test x"$OPT_CREATE_REDIS" != xyes; then
-  PREPARE_DB_OPTS="$PREPARE_DB_OPTS --skip-redis"
-fi
-
-echo "Preparing the environment"
-cd ${BASEDIR}/test/support
-sh prepare_db.sh ${PREPARE_DB_OPTS} || die "database preparation failure"
-cd -
 
 PATH=node_modules/.bin/:$PATH
 
-if test x"$OPT_COVERAGE" = xyes; then
-  echo "Running tests with coverage"
-  ./node_modules/.bin/istanbul cover node_modules/.bin/_mocha -- -u tdd -t 5000 ${TESTS}
-else
-  echo "Running tests"
-  mocha -u tdd -t 5000 ${TESTS}
-fi
+echo "Running tests"
+mocha -t 10000 -u tdd ${MOCHA_OPTS} ${TESTS}
 ret=$?
 
 cleanup

scripts/check-node-canvas.sh

@@ -1,24 +0,0 @@
-#!/bin/bash
-
-if [[ "$OSTYPE" == "darwin"* ]]; then
-    CAIRO_PKG_CONFIG=`pkg-config cairo --cflags-only-I 2> /dev/null`
-    RESULT=$?
-
-    if [[ ${RESULT} -ne 0 ]]; then
-        echo "###################################################################################"
-        echo "#                            PREINSTALL HOOK ERROR                                #"
-        echo "#---------------------------------------------------------------------------------#"
-        echo "#                                                                                 #"
-        echo "# node-canvas install error: some packages required by 'cairo' are not found      #"
-        echo "#                                                                                 #"
-        echo -e "# Use '\033[1mmake all\033[0m', it will take care of common/known issues                        #"
-        echo "#                                                                                 #"
-        echo "# As an alternative try:                                                          #"
-        echo "# Try to 'export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/opt/X11/lib/pkgconfig' #"
-        echo "#                                                                                 #"
-        echo "# If problems persist visit: https://github.com/Automattic/node-canvas/wiki       #"
-        echo "#                                                                                 #"
-        echo "###################################################################################"
-        exit 1
-    fi
-fi

scripts/install.sh

@@ -1,7 +0,0 @@
-#!/bin/bash
-
-if [[ "$OSTYPE" == "darwin"* ]]; then
-    export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/opt/X11/lib/pkgconfig
-fi
-
-npm install

scripts/lzma2config.js

@@ -1,18 +0,0 @@
-if (process.argv.length !== 3) {
-    console.error('Usage: node %s lzma_string', __filename);
-    process.exit(1);
-}
-
-var LZMA = require('lzma').LZMA;
-var lzmaWorker = new LZMA();
-var lzmaInput = decodeURIComponent(process.argv[2]);
-var lzmaBuffer = new Buffer(lzmaInput, 'base64')
-    .toString('binary')
-    .split('')
-    .map(function(c) {
-        return c.charCodeAt(0) - 128
-    });
-
-lzmaWorker.decompress(lzmaBuffer, function(result) {
-    console.log(JSON.stringify(JSON.parse(JSON.parse(result).config), null, 4));
-});

test/acceptance/cache/surrogate_keys_invalidation.js

@@ -1,313 +0,0 @@
-require(__dirname + '/../../support/test_helper');
-
-var assert      = require('../../support/assert');
-var redis       = require('redis');
-var step        = require('step');
-var FastlyPurge = require('fastly-purge');
-
-var NamedMapsCacheEntry = require(__dirname + '/../../../lib/cartodb/cache/model/named_maps_entry');
-var CartodbWindshaft = require(__dirname + '/../../../lib/cartodb/cartodb_windshaft');
-
-
-describe('templates surrogate keys', function() {
-
-    var redisClient = redis.createClient(global.environment.redis.port);
-
-    // Enable Varnish purge for tests
-    var varnishHost = global.environment.varnish.host;
-    global.environment.varnish.host = '127.0.0.1';
-    var varnishPurgeEnabled = global.environment.varnish.purge_enabled;
-    global.environment.varnish.purge_enabled = true;
-
-    var fastlyConfig = global.environment.fastly;
-    var FAKE_FASTLY_API_KEY = 'fastly-api-key';
-    var FAKE_FASTLY_SERVICE_ID = 'fake-service-id';
-    global.environment.fastly = {
-        enabled: true,
-        // the fastly api key
-        apiKey: FAKE_FASTLY_API_KEY,
-        // the service that will get surrogate key invalidation
-        serviceId: FAKE_FASTLY_SERVICE_ID
-    };
-
-    var serverOptions = require('../../../lib/cartodb/server_options')();
-    var server = new CartodbWindshaft(serverOptions);
-
-    var templateOwner = 'localhost',
-        templateName = 'acceptance',
-        expectedTemplateId = templateName,
-        template = {
-            version: '0.0.1',
-            name: templateName,
-            auth: {
-                method: 'open'
-            },
-            layergroup:  {
-                version: '1.2.0',
-                layers: [
-                    {
-                        options: {
-                            sql: 'select 1 cartodb_id, null::geometry as the_geom_webmercator',
-                            cartocss: '#layer { marker-fill:blue; }',
-                            cartocss_version: '2.3.0'
-                        }
-                    }
-                ]
-            }
-        },
-        expectedBody = { template_id: expectedTemplateId };
-
-    var varnishHttpUrl = [
-        'http://', global.environment.varnish.host, ':', global.environment.varnish.http_port
-    ].join('');
-
-    var cacheEntryKey = new NamedMapsCacheEntry(templateOwner, templateName).key();
-    var invalidationMatchHeader = '\\b' + cacheEntryKey + '\\b';
-    var fastlyPurgePath = '/service/' + FAKE_FASTLY_SERVICE_ID + '/purge/' + encodeURIComponent(cacheEntryKey);
-
-    var nock = require('nock');
-    nock.enableNetConnect(/(127.0.0.1:5555|cartocdn.com)/);
-
-    after(function(done) {
-        serverOptions.varnish_purge_enabled = false;
-        global.environment.varnish.host = varnishHost;
-        global.environment.varnish.purge_enabled = varnishPurgeEnabled;
-
-        global.environment.fastly = fastlyConfig;
-
-        nock.restore();
-        done();
-    });
-
-    function createTemplate(callback) {
-        var postTemplateRequest = {
-            url: '/api/v1/map/named?api_key=1234',
-            method: 'POST',
-            headers: {
-                host: templateOwner,
-                'Content-Type': 'application/json'
-            },
-            data: JSON.stringify(template)
-        };
-
-        step(
-            function postTemplate() {
-                var next = this;
-                assert.response(server,
-                    postTemplateRequest,
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        next(null, res);
-                    }
-                );
-            },
-            function rePostTemplate(err, res) {
-                if (err) {
-                    throw err;
-                }
-                var parsedBody = JSON.parse(res.body);
-                assert.deepEqual(parsedBody, expectedBody);
-                return true;
-            },
-            function finish(err) {
-                callback(err);
-            }
-        );
-    }
-
-    it("invalidates surrogate keys on template update", function(done) {
-
-        var scope = nock(varnishHttpUrl)
-            .intercept('/key', 'PURGE')
-            .matchHeader('Invalidation-Match', invalidationMatchHeader)
-            .reply(204, '');
-
-        var fastlyScope = nock(FastlyPurge.FASTLY_API_ENDPOINT)
-            .post(fastlyPurgePath)
-            .matchHeader('Fastly-Key', FAKE_FASTLY_API_KEY)
-            .matchHeader('Fastly-Soft-Purge', 1)
-            .matchHeader('Accept', 'application/json')
-            .reply(200, {
-                status:'ok'
-            });
-
-        step(
-            function createTemplateToUpdate() {
-                createTemplate(this);
-            },
-            function putValidTemplate(err) {
-                if (err) {
-                    throw err;
-                }
-                var updateTemplateRequest = {
-                    url: '/api/v1/map/named/' + expectedTemplateId + '/?api_key=1234',
-                    method: 'PUT',
-                    headers: {
-                        host: templateOwner,
-                        'Content-Type': 'application/json'
-                    },
-                    data: JSON.stringify(template)
-                };
-                var next = this;
-                assert.response(server,
-                    updateTemplateRequest,
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        next(null, res);
-                    }
-                );
-            },
-            function checkValidUpdate(err, res) {
-                if (err) {
-                    throw err;
-                }
-                var parsedBody = JSON.parse(res.body);
-                assert.deepEqual(parsedBody, expectedBody);
-
-                assert.equal(scope.pendingMocks().length, 0);
-                assert.equal(fastlyScope.pendingMocks().length, 0);
-
-                return null;
-            },
-            function finish(err) {
-                if ( err ) {
-                    return done(err);
-                }
-                redisClient.keys("map_*|localhost", function(err, keys) {
-                    if ( err ) {
-                        return done(err);
-                    }
-                    redisClient.del(keys, function(err) {
-                        return done(err);
-                    });
-                });
-            }
-        );
-    });
-
-    it("invalidates surrogate on template deletion", function(done) {
-
-        var scope = nock(varnishHttpUrl)
-            .intercept('/key', 'PURGE')
-            .matchHeader('Invalidation-Match', invalidationMatchHeader)
-            .reply(204, '');
-
-        var fastlyScope = nock(FastlyPurge.FASTLY_API_ENDPOINT)
-            .post(fastlyPurgePath)
-            .matchHeader('Fastly-Key', FAKE_FASTLY_API_KEY)
-            .matchHeader('Fastly-Soft-Purge', 1)
-            .matchHeader('Accept', 'application/json')
-            .reply(200, {
-                status:'ok'
-            });
-
-        step(
-            function createTemplateToDelete() {
-                createTemplate(this);
-            },
-            function deleteValidTemplate(err) {
-                if (err) {
-                    throw err;
-                }
-                var deleteTemplateRequest = {
-                    url: '/api/v1/map/named/' + expectedTemplateId + '/?api_key=1234',
-                    method: 'DELETE',
-                    headers: {
-                        host: templateOwner,
-                        'Content-Type': 'application/json'
-                    }
-                };
-                var next = this;
-                assert.response(server,
-                    deleteTemplateRequest,
-                    {
-                        status: 204
-                    },
-                    function(res) {
-                        next(null, res);
-                    }
-                );
-            },
-            function checkValidUpdate(err) {
-                if (err) {
-                    throw err;
-                }
-
-                assert.equal(scope.pendingMocks().length, 0);
-                assert.equal(fastlyScope.pendingMocks().length, 0);
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-    });
-
-    it("should update template even if surrogate key invalidation fails", function(done) {
-
-        var scope = nock(varnishHttpUrl)
-            .intercept('/key', 'PURGE')
-            .matchHeader('Invalidation-Match', invalidationMatchHeader)
-            .reply(503, '');
-
-        step(
-            function createTemplateToUpdate() {
-                createTemplate(this);
-            },
-            function putValidTemplate(err) {
-                if (err) {
-                    throw err;
-                }
-                var updateTemplateRequest = {
-                    url: '/api/v1/map/named/' + expectedTemplateId + '/?api_key=1234',
-                    method: 'PUT',
-                    headers: {
-                        host: templateOwner,
-                        'Content-Type': 'application/json'
-                    },
-                    data: JSON.stringify(template)
-                };
-                var next = this;
-                assert.response(server,
-                    updateTemplateRequest,
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        next(null, res);
-                    }
-                );
-            },
-            function checkValidUpdate(err, res) {
-                if (err) {
-                    throw err;
-                }
-                var parsedBody = JSON.parse(res.body);
-                assert.deepEqual(parsedBody, expectedBody);
-
-                assert.equal(scope.pendingMocks().length, 0);
-
-                return null;
-            },
-            function finish(err) {
-                if ( err ) {
-                    return done(err);
-                }
-                redisClient.keys("map_*|localhost", function(err, keys) {
-                    if ( err ) {
-                        return done(err);
-                    }
-                    redisClient.del(keys, function(err) {
-                        return done(err);
-                    });
-                });
-            }
-        );
-    });
-
-});

test/acceptance/cache_validator.js

@@ -0,0 +1,21 @@
+var assert      = require('../support/assert');
+require(__dirname + '/../support/test_helper');
+var CacheValidator = require(__dirname + '/../../lib/cartodb/cache_validator');
+
+var VarnishEmu = require('../support/VarnishEmu');
+
+suite('cache_validator', function() {
+
+    test('should call purge on varnish when invalidate database', function(done) {
+        var varnish = new VarnishEmu(function(cmds) {
+            assert.ok(cmds.length == 1);        
+            assert.equal('purge obj.http.X-Cache-Channel ~ \"^test_db:(.*test_cache.*)|(table)$\"\n', cmds[0].toString('utf8'));
+            done();
+        },
+        function() {
+            CacheValidator.init('localhost', 1337);
+            CacheValidator.invalidate_db('test_db', 'test_cache');
+        });
+    });
+
+});

test/acceptance/health_check.js

@@ -1,94 +0,0 @@
-require(__dirname + '/../support/test_helper');
-
-var assert      = require('../support/assert');
-var CartodbWindshaft = require(__dirname + '/../../lib/cartodb/cartodb_windshaft');
-var serverOptions = require(__dirname + '/../../lib/cartodb/server_options')();
-var server = new CartodbWindshaft(serverOptions);
-
-var metadataBackend = {};
-var tilelive = {};
-var HealthCheck = require('../../lib/cartodb/monitoring/health_check');
-var healthCheck = new HealthCheck(metadataBackend, tilelive);
-
-describe('health checks', function () {
-
-    function resetHealthConfig() {
-        global.environment.health = {
-            enabled: true,
-            username: 'localhost',
-            z: 0,
-            x: 0,
-            y: 0
-        };
-    }
-
-    var healthCheckRequest = {
-        url: '/health',
-        method: 'GET',
-        headers: {
-            host: 'localhost'
-        }
-    };
-
-    it('returns 200 and ok=true with enabled configuration', function (done) {
-        resetHealthConfig();
-
-        assert.response(server,
-            healthCheckRequest,
-            {
-                status: 200
-            },
-            function (res, err) {
-                assert.ok(!err);
-
-                var parsed = JSON.parse(res.body);
-
-                assert.ok(parsed.enabled);
-                assert.ok(parsed.ok);
-
-                done();
-            }
-        );
-    });
-
-    it('error if disabled file exists', function(done) {
-      var fs = require('fs');
-
-      var readFileFn = fs.readFile;
-      fs.readFile = function(filename, callback) {
-        callback(null, "Maintenance");
-      };
-      
-      healthCheck.check(null, function(err/*, result*/) {
-        assert.equal(err.message, "Maintenance");
-        assert.equal(err.http_status, 503);
-        done();
-        fs.readFile = readFileFn;
-      }); 
-      
-    }); 
-
-    it('not err if disabled file does not exists', function(done) {
-      resetHealthConfig();
-
-      global.environment.disabled_file = '/tmp/ftreftrgtrccre';
-
-      assert.response(server,
-        healthCheckRequest,
-        {
-          status: 200
-        },
-        function (res, err) {
-          assert.ok(!err);
-
-          var parsed = JSON.parse(res.body);
-
-          assert.equal(parsed.enabled, true);
-          assert.equal(parsed.ok, true);
-
-          done();
-        }
-      );
-    }); 
-
-});

test/acceptance/limits.js

@@ -1,307 +0,0 @@
-require('../support/test_helper');
-
-var assert = require('../support/assert');
-var _ = require('underscore');
-var redis = require('redis');
-
-var CartodbWindshaft = require('../../lib/cartodb/cartodb_windshaft');
-var serverOptions = require('../../lib/cartodb/server_options');
-
-describe('render limits', function() {
-
-    var layergroupUrl = '/api/v1/map';
-
-    var redisClient = redis.createClient(global.environment.redis.port);
-    after(function(done) {
-        redisClient.keys("map_style|*", function(err, matches) {
-            redisClient.del(matches, function() {
-                done();
-            });
-        });
-    });
-
-    var server;
-    beforeEach(function() {
-        server = new CartodbWindshaft(serverOptions());
-        server.setMaxListeners(0);
-    });
-
-    var keysToDelete = [];
-    afterEach(function(done) {
-        redisClient.DEL(keysToDelete, function() {
-            keysToDelete = [];
-            done();
-        });
-    });
-
-    var user = 'localhost';
-
-    var pointSleepSql = "SELECT pg_sleep(0.5)," +
-        " 'SRID=3857;POINT(0 0)'::geometry the_geom_webmercator, 1 cartodb_id";
-    var pointCartoCss = '#layer { marker-fill:red; }';
-    var polygonSleepSql = "SELECT pg_sleep(0.5)," +
-        " ST_Buffer('SRID=3857;POINT(0 0)'::geometry, 100000000) the_geom_webmercator, 1 cartodb_id";
-    var polygonCartoCss = '#layer { polygon-fill:red; }';
-
-    function singleLayergroupConfig(sql, cartocss) {
-        return {
-            version: '1.0.0',
-            layers: [
-                {
-                    type: 'mapnik',
-                    options: {
-                        sql: sql,
-                        cartocss: cartocss,
-                        cartocss_version: '2.0.1'
-                    }
-                }
-            ]
-        };
-    }
-
-    function createRequest(layergroup, userHost) {
-        return {
-            url: layergroupUrl,
-            method: 'POST',
-            headers: {
-                host: userHost,
-                'Content-Type': 'application/json'
-            },
-            data: JSON.stringify(layergroup)
-        };
-    }
-
-    function withRenderLimit(user, renderLimit, callback) {
-        redisClient.SELECT(5, function(err) {
-            if (err) {
-                return callback(err);
-            }
-            var userLimitsKey = 'limits:tiler:' + user;
-            redisClient.HSET(userLimitsKey, 'render', renderLimit, function(err) {
-                if (err) {
-                    return callback(err);
-                }
-                keysToDelete.push(userLimitsKey);
-                return callback();
-            });
-        });
-
-    }
-
-    describe('with onTileErrorStrategy DISABLED', function() {
-        var onTileErrorStrategyEnabled;
-        before(function() {
-            onTileErrorStrategyEnabled = global.environment.enabledFeatures.onTileErrorStrategy;
-            global.environment.enabledFeatures.onTileErrorStrategy = false;
-        });
-
-        after(function() {
-            global.environment.enabledFeatures.onTileErrorStrategy = onTileErrorStrategyEnabled;
-        });
-
-        it("layergroup creation fails if test tile is slow", function(done) {
-            withRenderLimit(user, 50, function(err) {
-                if (err) {
-                    return done(err);
-                }
-
-                var layergroup = singleLayergroupConfig(polygonSleepSql, polygonCartoCss);
-                assert.response(server,
-                    createRequest(layergroup, user),
-                    {
-                        status: 400
-                    },
-                    function(res) {
-                        var parsed = JSON.parse(res.body);
-                        assert.deepEqual(parsed, { errors: [ 'Render timed out' ] });
-                        done();
-                    }
-                );
-            });
-        });
-
-        it("layergroup creation does not fail if user limit is high enough even if test tile is slow", function(done) {
-            withRenderLimit(user, 5000, function(err) {
-                if (err) {
-                    return done(err);
-                }
-
-                var layergroup = singleLayergroupConfig(polygonSleepSql, polygonCartoCss);
-                assert.response(server,
-                    createRequest(layergroup, user),
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        var parsed = JSON.parse(res.body);
-                        assert.ok(parsed.layergroupid);
-                        done();
-                    }
-                );
-            });
-        });
-
-
-        it("layergroup creation works if test tile is fast but tile request fails if they are slow",  function(done) {
-            withRenderLimit(user, 50, function(err) {
-                if (err) {
-                    return done(err);
-                }
-
-                var layergroup = singleLayergroupConfig(pointSleepSql, pointCartoCss);
-                assert.response(server,
-                    createRequest(layergroup, user),
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        assert.response(server,
-                            {
-                                url: layergroupUrl + _.template('/<%= layergroupId %>/<%= z %>/<%= x %>/<%= y %>.png', {
-                                    layergroupId: JSON.parse(res.body).layergroupid,
-                                    z: 0,
-                                    x: 0,
-                                    y: 0
-                                }),
-                                method: 'GET',
-                                headers: {
-                                    host: 'localhost'
-                                },
-                                encoding: 'binary'
-                            },
-                            {
-                                status: 400
-                            },
-                            function(res) {
-                                var parsed = JSON.parse(res.body);
-                                assert.deepEqual(parsed, { errors: ['Render timed out'] });
-                                done();
-                            }
-                        );
-
-                    }
-                );
-            });
-        });
-
-        it("tile request does not fail if user limit is high enough",  function(done) {
-            withRenderLimit(user, 5000, function(err) {
-                if (err) {
-                    return done(err);
-                }
-
-                var layergroup = singleLayergroupConfig(pointSleepSql, pointCartoCss);
-                assert.response(server,
-                    createRequest(layergroup, user),
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        assert.response(server,
-                            {
-                                url: layergroupUrl + _.template('/<%= layergroupId %>/<%= z %>/<%= x %>/<%= y %>.png', {
-                                    layergroupId: JSON.parse(res.body).layergroupid,
-                                    z: 0,
-                                    x: 0,
-                                    y: 0
-                                }),
-                                method: 'GET',
-                                headers: {
-                                    host: 'localhost'
-                                },
-                                encoding: 'binary'
-                            },
-                            {
-                                status: 200,
-                                headers: {
-                                    'Content-Type': 'image/png'
-                                }
-                            },
-                            function(res, err) {
-                                done(err);
-                            }
-                        );
-
-                    }
-                );
-            });
-        });
-
-    });
-
-    describe('with onTileErrorStrategy', function() {
-
-        it("layergroup creation works even if test tile is slow", function(done) {
-            withRenderLimit(user, 50, function(err) {
-                if (err) {
-                    return done(err);
-                }
-
-                var layergroup = singleLayergroupConfig(polygonSleepSql, polygonCartoCss);
-                assert.response(server,
-                    createRequest(layergroup, user),
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        var parsed = JSON.parse(res.body);
-                        assert.ok(parsed.layergroupid);
-                        done();
-                    }
-                );
-            });
-        });
-
-        it("layergroup creation and tile requests works even if they are slow but returns fallback",  function(done) {
-            withRenderLimit(user, 50, function(err) {
-                if (err) {
-                    return done(err);
-                }
-
-                var layergroup = singleLayergroupConfig(pointSleepSql, pointCartoCss);
-                assert.response(server,
-                    createRequest(layergroup, user),
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        assert.response(server,
-                            {
-                                url: layergroupUrl + _.template('/<%= layergroupId %>/<%= z %>/<%= x %>/<%= y %>.png', {
-                                    layergroupId: JSON.parse(res.body).layergroupid,
-                                    z: 0,
-                                    x: 0,
-                                    y: 0
-                                }),
-                                method: 'GET',
-                                headers: {
-                                    host: 'localhost'
-                                },
-                                encoding: 'binary'
-                            },
-                            {
-                                status: 200,
-                                headers: {
-                                    'Content-Type': 'image/png'
-                                }
-                            },
-                            function(res, err) {
-                                if (err) {
-                                    done(err);
-                                }
-                                assert.imageEqualsFile(res.body, './test/fixtures/render-timeout-fallback.png', 25,
-                                    function(imgErr/*, similarity*/) {
-                                        done(imgErr);
-                                    }
-                                );
-                            }
-                        );
-
-                    }
-                );
-            });
-        });
-
-    });
-
-});

test/acceptance/multilayer_server.js

@@ -1,343 +0,0 @@
-var testHelper = require('../support/test_helper');
-
-var assert = require('../support/assert');
-
-var redis = require('redis');
-var _ = require('underscore');
-
-
-var PgQueryRunner = require('../../lib/cartodb/backends/pg_query_runner');
-var CartodbWindshaft = require('../../lib/cartodb/cartodb_windshaft');
-var serverOptions = require('../../lib/cartodb/server_options')();
-var server = new CartodbWindshaft(serverOptions);
-server.setMaxListeners(0);
-
-describe('tests from old api translated to multilayer', function() {
-
-    var layergroupUrl = '/api/v1/map';
-
-    var redisClient = redis.createClient(global.environment.redis.port);
-    after(function(done) {
-        // This test will add map_style records, like
-        // 'map_style|null|publicuser|my_table',
-        redisClient.keys("map_style|*", function(err, matches) {
-            redisClient.del(matches, function() {
-                done();
-            });
-        });
-    });
-
-    var wadusSql = 'select 1 as cartodb_id, null::geometry as the_geom_webmercator';
-    var pointSql = "SELECT 'SRID=3857;POINT(0 0)'::geometry as the_geom_webmercator, 1::int as cartodb_id";
-
-    function singleLayergroupConfig(sql, cartocss) {
-        return {
-            version: '1.0.0',
-            layers: [
-                {
-                    type: 'mapnik',
-                    options: {
-                        sql: sql,
-                        cartocss: cartocss,
-                        cartocss_version: '2.0.1'
-                    }
-                }
-            ]
-        };
-    }
-
-    function createRequest(layergroup, userHost, apiKey) {
-        var url = layergroupUrl;
-        if (apiKey) {
-            url += '?api_key=' + apiKey;
-        }
-        return {
-            url: url,
-            method: 'POST',
-            headers: {
-                host: userHost || 'localhost',
-                'Content-Type': 'application/json'
-            },
-            data: JSON.stringify(layergroup)
-        };
-    }
-
-    it("layergroup creation fails if CartoCSS is bogus", function(done) {
-        var layergroup = singleLayergroupConfig(wadusSql, '#my_table3{');
-        assert.response(server,
-            createRequest(layergroup),
-            {
-                status: 400
-            },
-            function(res) {
-                var parsed = JSON.parse(res.body);
-                assert.ok(parsed.errors[0].match(/^style0/));
-                assert.ok(parsed.errors[0].match(/missing closing/));
-                done();
-            }
-        );
-    });
-
-    it("multiple bad styles returns 400 with all errors", function(done) {
-        var layergroup = singleLayergroupConfig(wadusSql, '#my_table4{backgxxxxxround-color:#fff;foo:bar}');
-        assert.response(server,
-            createRequest(layergroup),
-            {
-                status: 400
-            },
-            function(res) {
-                var parsed = JSON.parse(res.body);
-                assert.equal(parsed.errors.length, 1);
-                assert.ok(parsed.errors[0].match(/^style0/));
-                assert.ok(parsed.errors[0].match(/Unrecognized rule: backgxxxxxround-color/));
-                assert.ok(parsed.errors[0].match(/Unrecognized rule: foo/));
-                done();
-            }
-        );
-    });
-
-    // Zoom is a special variable
-    it("Specifying zoom level in CartoCSS does not need a 'zoom' variable in SQL output", function(done) {
-        var layergroup = singleLayergroupConfig(pointSql, '#gadm4 [ zoom>=3] { marker-fill:red; }');
-
-        assert.response(server,
-            createRequest(layergroup),
-            {
-                status: 200
-            },
-            function(res) {
-                var parsed = JSON.parse(res.body);
-                assert.ok(parsed.layergroupid);
-                assert.equal(res.headers['x-layergroup-id'], parsed.layergroupid);
-                done();
-            }
-        );
-    });
-
-    // See https://github.com/CartoDB/Windshaft-cartodb/issues/88
-    it("getting a tile from a user-specific database should return an expected tile", function(done) {
-        var layergroup = singleLayergroupConfig(pointSql, '#layer { marker-fill:red; }');
-
-        var backupDBHost = global.environment.postgres.host;
-        global.environment.postgres.host = '6.6.6.6';
-
-        assert.response(server,
-            createRequest(layergroup, 'cartodb250user'),
-            {
-                status: 200
-            },
-            function(res) {
-                var parsed = JSON.parse(res.body);
-                assert.ok(parsed.layergroupid);
-                assert.equal(res.headers['x-layergroup-id'], parsed.layergroupid);
-
-                global.environment.postgres.host = backupDBHost;
-                done();
-            }
-        );
-    });
-
-    // See https://github.com/CartoDB/Windshaft-cartodb/issues/89
-    it("getting a tile with a user-specific database password", function(done) {
-        var layergroup = singleLayergroupConfig(pointSql, '#layer { marker-fill:red; }');
-
-        var backupDBPass = global.environment.postgres_auth_pass;
-        global.environment.postgres_auth_pass = '<%= user_password %>';
-
-        assert.response(server,
-            createRequest(layergroup, 'cartodb250user', '4321'),
-            {
-                status: 200
-            },
-            function(res) {
-                var parsed = JSON.parse(res.body);
-                assert.ok(parsed.layergroupid);
-                assert.equal(res.headers['x-layergroup-id'], parsed.layergroupid);
-
-                global.environment.postgres_auth_pass = backupDBPass;
-                done();
-            }
-        );
-    });
-
-    it("creating a layergroup from lzma param",  function(done){
-        var params = {
-            config: JSON.stringify(singleLayergroupConfig(pointSql, '#layer { marker-fill:red; }'))
-        };
-
-        testHelper.lzma_compress_to_base64(JSON.stringify(params), 1, function(err, lzma) {
-            if (err) {
-                return done(err);
-            }
-            assert.response(server,
-                {
-                    url: layergroupUrl + '?lzma=' + encodeURIComponent(lzma),
-                    method: 'GET',
-                    headers: {
-                        host: 'localhost'
-                    },
-                    encoding: 'binary'
-                },
-                {
-                    status: 200
-                },
-                function(res) {
-                    var parsed = JSON.parse(res.body);
-                    assert.ok(parsed.layergroupid);
-
-                    done();
-                }
-            );
-        });
-    });
-
-    it("creating a layergroup from lzma param, invalid json input",  function(done) {
-        var params = {
-            config: 'WADUS'
-        };
-
-        testHelper.lzma_compress_to_base64(JSON.stringify(params), 1, function(err, lzma) {
-            if (err) {
-                return done(err);
-            }
-            assert.response(server,
-                {
-                    url: layergroupUrl + '?lzma=' + encodeURIComponent(lzma),
-                    method: 'GET',
-                    headers: {
-                        host: 'localhost'
-                    },
-                    encoding: 'binary'
-                },
-                {
-                    status: 400
-                },
-                function(res) {
-                    var parsed = JSON.parse(res.body);
-                    assert.deepEqual(parsed, { errors: [ 'Unexpected token W' ] });
-
-                    done();
-                }
-            );
-        });
-    });
-
-    it("uses queries postgresql to figure affected tables in query",  function(done) {
-        var tableName = 'gadm4';
-        var expectedCacheChannel = _.template('<%= databaseName %>:public.<%= tableName %>', {
-            databaseName: _.template(global.environment.postgres_auth_user, {user_id:1}) + '_db',
-            tableName: tableName
-        });
-
-        var layergroup =  singleLayergroupConfig('select * from ' + tableName, '#gadm4 { marker-fill: red; }');
-
-        assert.response(server,
-            {
-                url: layergroupUrl + '?config=' + encodeURIComponent(JSON.stringify(layergroup)),
-                method: 'GET',
-                headers: {
-                    host: 'localhost'
-                }
-            },
-            {
-                status: 200
-            },
-            function(res) {
-                var parsed = JSON.parse(res.body);
-                assert.ok(parsed.layergroupid);
-
-                assert.ok(res.headers.hasOwnProperty('x-cache-channel'));
-                assert.equal(res.headers['x-cache-channel'], expectedCacheChannel);
-
-                assert.equal(res.headers['x-layergroup-id'], parsed.layergroupid);
-
-                done();
-            }
-        );
-    });
-
-    it("creates layergroup fails when postgresql queries fail to figure affected tables in query",  function(done) {
-
-        var runQueryFn = PgQueryRunner.prototype.run;
-        PgQueryRunner.prototype.run = function(username, query, queryHandler, callback) {
-            return queryHandler(new Error('fake error message'), [], callback);
-        };
-
-        var layergroup =  singleLayergroupConfig('select * from gadm4', '#gadm4 { marker-fill: red; }');
-
-        assert.response(server,
-            {
-                url: layergroupUrl + '?config=' + encodeURIComponent(JSON.stringify(layergroup)),
-                method: 'GET',
-                headers: {
-                    host: 'localhost'
-                }
-            },
-            {
-                status: 400
-            },
-            function(res) {
-                PgQueryRunner.prototype.run = runQueryFn;
-
-                assert.ok(!res.headers.hasOwnProperty('x-cache-channel'));
-
-                var parsed = JSON.parse(res.body);
-                assert.deepEqual(parsed, {
-                    errors: ["Error: could not fetch affected tables and last updated time: fake error message"]
-                });
-
-                done();
-            }
-        );
-    });
-
-    it("tile requests works when postgresql queries fail to figure affected tables in query",  function(done) {
-        var layergroup =  singleLayergroupConfig('select * from gadm4', '#gadm4 { marker-fill: red; }');
-        assert.response(server,
-            {
-                url: layergroupUrl + '?config=' + encodeURIComponent(JSON.stringify(layergroup)),
-                method: 'GET',
-                headers: {
-                    host: 'localhost'
-                }
-            },
-            {
-                status: 200
-            },
-            function(res) {
-                var runQueryFn = PgQueryRunner.prototype.run;
-                PgQueryRunner.prototype.run = function(username, query, queryHandler, callback) {
-                    return queryHandler(new Error('failed to query database for affected tables'), [], callback);
-                };
-
-                // reset internal cacheChannel cache
-                serverOptions.channelCache = {};
-
-                assert.response(server,
-                    {
-                        url: layergroupUrl + _.template('/<%= layergroupId %>/<%= z %>/<%= x %>/<%= y %>.png', {
-                            layergroupId: JSON.parse(res.body).layergroupid,
-                            z: 0,
-                            x: 0,
-                            y: 0
-                        }),
-                        method: 'GET',
-                        headers: {
-                            host: 'localhost'
-                        },
-                        encoding: 'binary'
-                    },
-                    {
-                        status: 200
-                    },
-                    function(res) {
-                        assert.ok(!res.headers.hasOwnProperty('x-cache-channel'));
-                        PgQueryRunner.prototype.run = runQueryFn;
-                        done();
-                    }
-                );
-            }
-        );
-    });
-
-});

test/acceptance/named_layers.js

@@ -1,737 +0,0 @@
-var test_helper = require('../support/test_helper');
-
-var assert = require('../support/assert');
-var CartodbWindshaft = require(__dirname + '/../../lib/cartodb/cartodb_windshaft');
-var serverOptions = require(__dirname + '/../../lib/cartodb/server_options')();
-var server = new CartodbWindshaft(serverOptions);
-
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../lib/cartodb/template_maps.js');
-
-var step = require('step');
-
-describe('named_layers', function() {
-    // configure redis pool instance to use in tests
-    var redisPool = new RedisPool(global.environment.redis);
-
-    var templateMaps = new TemplateMaps(redisPool, {
-        max_user_templates: global.environment.maxUserTemplates
-    });
-
-    var wadusLayer = {
-        type: 'cartodb',
-        options: {
-            sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-            cartocss: '#layer { marker-fill: <%= color %>; }',
-            cartocss_version: '2.3.0'
-        }
-    };
-
-    var username = 'localhost';
-
-    var templateName = 'valid_template';
-    var template = {
-        version: '0.0.1',
-        name: templateName,
-        auth: {
-            method: 'open'
-        },
-        "placeholders": {
-            "color": {
-                "type": "css_color",
-                "default": "#cc3300"
-            }
-        },
-        layergroup: {
-            layers: [
-                wadusLayer,
-                wadusLayer
-            ]
-        }
-    };
-
-    var tokenAuthTemplateName = 'auth_valid_template';
-    var tokenAuthTemplate = {
-        version: '0.0.1',
-        name: tokenAuthTemplateName,
-        auth: {
-            method: 'token',
-            valid_tokens: ['valid1', 'valid2']
-        },
-        placeholders: {
-            color: {
-                "type": "css_color",
-                "default": "#cc3300"
-            }
-        },
-        layergroup: {
-            layers: [
-                wadusLayer
-            ]
-        }
-    };
-
-
-    var namedMapLayer = {
-        type: 'named',
-        options: {
-            name: templateName,
-            config: {},
-            auth_tokens: []
-        }
-    };
-
-    var nestedNamedMapTemplateName = 'nested_template';
-    var nestedNamedMapTemplate = {
-        version: '0.0.1',
-        name: nestedNamedMapTemplateName,
-        auth: {
-            method: 'open'
-        },
-        layergroup: {
-            layers: [
-                namedMapLayer
-            ]
-        }
-    };
-
-    before(function(done) {
-        global.environment.enabledFeatures = {cdbQueryTablesFromPostgres: true};
-        templateMaps.addTemplate(username, nestedNamedMapTemplate, function(err) {
-            if (err) {
-                return done(err);
-            }
-            templateMaps.addTemplate(username, tokenAuthTemplate, function(err) {
-                if (err) {
-                    return done(err);
-                }
-                templateMaps.addTemplate(username, template, function(err) {
-                    return done(err);
-                });
-            });
-        });
-    });
-
-    it('should fail for non-existing template name', function(done) {
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'named',
-                    options: {
-                        name: 'nonexistent'
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createLayergroup() {
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 400
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.deepEqual(parsedBody, { errors: ["Template 'nonexistent' of user 'localhost' not found"] });
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-    });
-
-    it('should return 403 if not properly authorized', function(done) {
-
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'named',
-                    options: {
-                        name: tokenAuthTemplateName,
-                        config: {},
-                        auth_tokens: ['token1']
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createLayergroup() {
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 403
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.deepEqual(
-                    parsedBody,
-                    { errors: [ "Unauthorized 'auth_valid_template' template instantiation" ] }
-                );
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-
-    });
-
-    it('should return 200 and layergroup if properly authorized', function(done) {
-
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'named',
-                    options: {
-                        name: tokenAuthTemplateName,
-                        config: {},
-                        auth_tokens: ['valid1']
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createLayergroup() {
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 200
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.ok(parsedBody.layergroupid);
-                assert.ok(parsedBody.last_updated);
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-
-    });
-
-    it('should return 400 for nested named map layers', function(done) {
-
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'named',
-                    options: {
-                        name: nestedNamedMapTemplateName
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createLayergroup() {
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 400
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.deepEqual(parsedBody, { errors: [ 'Nested named layers are not allowed' ] });
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-
-    });
-
-    it('should return 200 and layergroup with private tables', function(done) {
-
-        var privateTableTemplateName = 'private_table_template';
-        var privateTableTemplate = {
-            version: '0.0.1',
-            name: privateTableTemplateName,
-            auth: {
-                method: 'open'
-            },
-            layergroup: {
-                layers: [
-                    {
-                        type: 'cartodb',
-                        options: {
-                            sql: 'select * from test_table_private_1',
-                            cartocss: '#layer { marker-fill: #cc3300; }',
-                            cartocss_version: '2.3.0'
-                        }
-                    }
-                ]
-            }
-        };
-
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'named',
-                    options: {
-                        name: privateTableTemplateName
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createTemplate() {
-                templateMaps.addTemplate(username, privateTableTemplate, this);
-            },
-            function createLayergroup(err) {
-                if (err) {
-                    throw err;
-                }
-
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 200
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.ok(parsedBody.layergroupid);
-                assert.ok(parsedBody.last_updated);
-
-                return parsedBody.layergroupid;
-            },
-            function requestTile(err, layergroupId) {
-                if (err) {
-                    throw err;
-                }
-
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map/' + layergroupId + '/0/0/0.png',
-                        method: 'GET',
-                        headers: {
-                            host: 'localhost'
-                        },
-                        encoding: 'binary'
-                    },
-                    {
-                        status: 200,
-                        headers: {
-                            'content-type': 'image/png'
-                        }
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function handleTileResponse(err, res) {
-                if (err) {
-                    throw err;
-                }
-                test_helper.checkCache(res);
-                return true;
-            },
-            function deleteTemplate(err) {
-                var next = this;
-                templateMaps.delTemplate(username, privateTableTemplate, function(/*delErr*/) {
-                    // ignore deletion error
-                    next(err);
-                });
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-
-    });
-
-    it('should return 200 and layergroup with private tables and interactivity', function(done) {
-
-        var privateTableTemplateNameInteractivity = 'private_table_template_interactivity';
-        var privateTableTemplate = {
-            "version": "0.0.1",
-            "auth": {
-                "method": "open"
-            },
-            "name": privateTableTemplateNameInteractivity,
-            "layergroup": {
-                "layers": [
-                    {
-                        "type": "cartodb",
-                        "options": {
-                            "attributes": {
-                                "columns": [
-                                    "name"
-                                ],
-                                "id": "cartodb_id"
-                            },
-                            "cartocss": "#layer { marker-fill: #cc3300; }",
-                            "cartocss_version": "2.3.0",
-                            "interactivity": "cartodb_id",
-                            "sql": "select * from test_table_private_1"
-                        }
-                    }
-                ]
-            }
-        };
-
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'named',
-                    options: {
-                        name: privateTableTemplateNameInteractivity
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createTemplate() {
-                templateMaps.addTemplate(username, privateTableTemplate, this);
-            },
-            function createLayergroup(err) {
-                if (err) {
-                    throw err;
-                }
-
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 200
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.ok(parsedBody.layergroupid);
-                assert.ok(parsedBody.last_updated);
-
-                return parsedBody.layergroupid;
-            },
-            function requestTile(err, layergroupId) {
-                if (err) {
-                    throw err;
-                }
-
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map/' + layergroupId + '/0/0/0.png',
-                        method: 'GET',
-                        headers: {
-                            host: 'localhost'
-                        },
-                        encoding: 'binary'
-                    },
-                    {
-                        status: 200,
-                        headers: {
-                            'content-type': 'image/png'
-                        }
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function handleTileResponse(err, res) {
-                if (err) {
-                    throw err;
-                }
-                test_helper.checkCache(res);
-                return true;
-            },
-            function deleteTemplate(err) {
-                var next = this;
-                templateMaps.delTemplate(username, privateTableTemplate, function(/*delErr*/) {
-                    // ignore deletion error
-                    next(err);
-                });
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-
-    });
-
-    it('should return 403 when private table is accessed from non named layer', function(done) {
-
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'cartodb',
-                    options: {
-                        sql: 'select * from test_table_private_1',
-                        cartocss: '#layer { marker-fill: #cc3300; }',
-                        cartocss_version: '2.3.0'
-                    }
-                },
-                {
-                    type: 'named',
-                    options: {
-                        name: templateName
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createLayergroup() {
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 403
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.ok(parsedBody.errors[0].match(/permission denied for relation test_table_private_1/));
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-
-    });
-
-    it('should return metadata for named layers', function(done) {
-
-        var layergroup =  {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'plain',
-                    options: {
-                        color: '#fabada'
-                    }
-                },
-                {
-                    type: 'cartodb',
-                    options: {
-                        sql: 'select * from test_table',
-                        cartocss: '#layer { marker-fill: #cc3300; }',
-                        cartocss_version: '2.3.0'
-                    }
-                },
-                {
-                    type: 'named',
-                    options: {
-                        name: templateName
-                    }
-                },
-                {
-                    type: 'torque',
-                    options: {
-                        sql: "select * from test_table LIMIT 0",
-                        cartocss: "Map { -torque-frame-count:1; -torque-resolution:1; " +
-                        "-torque-aggregation-function:'count(*)'; -torque-time-attribute:'updated_at'; }"
-                    }
-                }
-            ]
-        };
-
-        step(
-            function createLayergroup() {
-                var next = this;
-                assert.response(server,
-                    {
-                        url: '/api/v1/map',
-                        method: 'POST',
-                        headers: {
-                            host: 'localhost',
-                            'Content-Type': 'application/json'
-                        },
-                        data: JSON.stringify(layergroup)
-                    },
-                    {
-                        status: 200
-                    },
-                    function(res, err) {
-                        next(err, res);
-                    }
-                );
-            },
-            function checkLayergroup(err, response) {
-                if (err) {
-                    throw err;
-                }
-
-                var parsedBody = JSON.parse(response.body);
-                assert.ok(parsedBody.metadata);
-                assert.ok(parsedBody.metadata.layers);
-                assert.equal(parsedBody.metadata.layers.length, 5);
-                assert.equal(parsedBody.metadata.layers[0].type, 'plain');
-                assert.equal(parsedBody.metadata.layers[1].type, 'mapnik');
-                assert.equal(parsedBody.metadata.layers[2].type, 'mapnik');
-                assert.equal(parsedBody.metadata.layers[3].type, 'mapnik');
-                assert.equal(parsedBody.metadata.layers[4].type, 'torque');
-
-                return null;
-            },
-            function finish(err) {
-                done(err);
-            }
-        );
-
-    });
-
-
-
-    after(function(done) {
-        global.environment.enabledFeatures = {cdbQueryTablesFromPostgres: false};
-        templateMaps.delTemplate(username, nestedNamedMapTemplateName, function(err) {
-            if (err) {
-                return done(err);
-            }
-            templateMaps.delTemplate(username, tokenAuthTemplateName, function(err) {
-                if (err) {
-                    return done(err);
-                }
-                templateMaps.delTemplate(username, templateName, function(err) {
-                    return done(err);
-                });
-            });
-        });
-    });
-});

test/acceptance/named_static_maps.js

@@ -1,189 +0,0 @@
-var test_helper = require('../support/test_helper');
-var RedisPool = require('redis-mpool');
-var querystring = require('querystring');
-
-var assert = require('../support/assert');
-var CartodbWindshaft = require(__dirname + '/../../lib/cartodb/cartodb_windshaft');
-var serverOptions = require(__dirname + '/../../lib/cartodb/server_options')();
-var server = new CartodbWindshaft(serverOptions);
-var TemplateMaps = require('../../lib/cartodb/template_maps.js');
-var NamedMapsCacheEntry = require('../../lib/cartodb/cache/model/named_maps_entry');
-
-describe('named static maps', function() {
-    // configure redis pool instance to use in tests
-    var redisPool = new RedisPool(global.environment.redis);
-
-    var templateMaps = new TemplateMaps(redisPool, {
-        max_user_templates: global.environment.maxUserTemplates
-    });
-
-    var wadusLayer = {
-        type: 'cartodb',
-        options: {
-            sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-            cartocss: '#layer { marker-fill: <%= color %>; }',
-            cartocss_version: '2.3.0'
-        }
-    };
-
-    var username = 'localhost';
-
-    var templateName = 'valid_template';
-    var template = {
-        version: '0.0.1',
-        name: templateName,
-        auth: {
-            method: 'open'
-        },
-        "placeholders": {
-            "color": {
-                "type": "css_color",
-                "default": "#cc3300"
-            }
-        },
-        layergroup: {
-            layers: [
-                wadusLayer
-            ]
-        }
-    };
-
-    var tokenAuthTemplateName = 'auth_valid_template';
-    var tokenAuthTemplate = {
-        version: '0.0.1',
-        name: tokenAuthTemplateName,
-        auth: {
-            method: 'token',
-            valid_tokens: ['valid1', 'valid2']
-        },
-        placeholders: {
-            color: {
-                "type": "css_color",
-                "default": "#cc3300"
-            }
-        },
-        layergroup: {
-            layers: [
-                wadusLayer
-            ]
-        }
-    };
-
-
-    var namedMapLayer = {
-        type: 'named',
-        options: {
-            name: templateName,
-            config: {},
-            auth_tokens: []
-        }
-    };
-
-    var nestedNamedMapTemplateName = 'nested_template';
-    var nestedNamedMapTemplate = {
-        version: '0.0.1',
-        name: nestedNamedMapTemplateName,
-        auth: {
-            method: 'open'
-        },
-        layergroup: {
-            layers: [
-                namedMapLayer
-            ]
-        }
-    };
-
-    before(function (done) {
-        templateMaps.addTemplate(username, nestedNamedMapTemplate, function (err) {
-            if (err) {
-                return done(err);
-            }
-            templateMaps.addTemplate(username, tokenAuthTemplate, function (err) {
-                if (err) {
-                    return done(err);
-                }
-                templateMaps.addTemplate(username, template, function (err) {
-                    return done(err);
-                });
-            });
-        });
-    });
-
-    after(function (done) {
-        templateMaps.delTemplate(username, nestedNamedMapTemplateName, function (err) {
-            if (err) {
-                return done(err);
-            }
-            templateMaps.delTemplate(username, tokenAuthTemplateName, function (err) {
-                if (err) {
-                    return done(err);
-                }
-                templateMaps.delTemplate(username, templateName, function (err) {
-                    return done(err);
-                });
-            });
-        });
-    });
-
-    function getStaticMap(name, options, callback) {
-
-        var url = '/api/v1/map/static/named/' + name + '/640/480.png';
-        if (options.params) {
-            url = url + '?' + querystring.stringify(options.params);
-        }
-        var requestOptions = {
-            url: url,
-            method: 'GET',
-            headers: {
-                host: username
-            }
-        };
-
-        console.log(url);
-
-        var statusCode = options.status || 200;
-
-        var expectedResponse = {
-            status: statusCode,
-            headers: {
-                'Content-Type': statusCode === 200 ? 'image/png' : 'application/json; charset=utf-8'
-            }
-        };
-
-        assert.response(server,
-            requestOptions,
-            expectedResponse,
-            function (res, err) {
-                return callback(err, res);
-            }
-        );
-    }
-
-    it('should return a 404 error for nonexistent template name', function (done) {
-        var nonexistentName = 'nonexistent';
-        getStaticMap(nonexistentName, { status: 404 }, function(err, res) {
-            assert.ok(!err);
-            var parsed = JSON.parse(res.body);
-            assert.equal(parsed.error, "Template '" + nonexistentName + "' of user '" + username + "' not found");
-            done();
-        });
-    });
-
-    it('should return 403 if not properly authorized', function(done) {
-        getStaticMap(tokenAuthTemplateName, { status: 403 }, function(err, res) {
-            assert.ok(!err);
-            var parsed = JSON.parse(res.body);
-            assert.equal(parsed.error, 'Unauthorized template instantiation');
-            done();
-        });
-    });
-
-    it('should return 200 if properly authorized', function(done) {
-        getStaticMap(tokenAuthTemplateName, { params: { auth_token: 'valid1' } }, function(err, res) {
-            assert.ok(!err);
-            test_helper.checkSurrogateKey(res, new NamedMapsCacheEntry(username, tokenAuthTemplateName).key());
-            done();
-        });
-    });
-
-});

test/acceptance/x_cache_channel.js

@@ -1,295 +0,0 @@
-require('../support/test_helper');
-
-var assert = require('../support/assert');
-var qs = require('querystring');
-
-var CartodbWindshaft = require('../../lib/cartodb/cartodb_windshaft');
-var serverOptions = require('../../lib/cartodb/server_options')();
-var server = new CartodbWindshaft(serverOptions);
-server.setMaxListeners(0);
-
-describe('get requests x-cache-channel', function() {
-
-    var statusOkResponse = {
-        status: 200
-    };
-
-    var mapConfig = {
-        version: '1.3.0',
-        layers: [
-            {
-                options: {
-                    sql: 'select * from test_table limit 2',
-                    cartocss: '#layer { marker-fill:red; }',
-                    cartocss_version: '2.3.0',
-                    attributes: {
-                        id:'cartodb_id',
-                        columns: [
-                            'name',
-                            'address'
-                        ]
-                    }
-                }
-            }
-        ]
-    };
-
-    var layergroupRequest = {
-        url: '/api/v1/map?config=' + encodeURIComponent(JSON.stringify(mapConfig)),
-        method: 'GET',
-        headers: {
-            host: 'localhost'
-        }
-    };
-
-    function getRequest(url, addApiKey, callbackName) {
-        var params = {};
-        if (!!addApiKey) {
-            params.api_key = '1234';
-        }
-        if (!!callbackName) {
-            params.callback = callbackName;
-        }
-
-        return {
-            url: url + '?' + qs.stringify(params),
-            method: 'GET',
-            headers: {
-                host: 'localhost',
-                'Content-Type': 'application/json'
-            }
-        };
-    }
-
-    function validateXCacheChannel(done, expectedCacheChannel) {
-        return function(res, err) {
-            if (err) {
-                return done(err);
-            }
-
-            assert.ok(res.headers['x-cache-channel']);
-            if (expectedCacheChannel) {
-                assert.equal(res.headers['x-cache-channel'], expectedCacheChannel);
-            }
-
-            done();
-        };
-    }
-
-    function noXCacheChannelHeader(done) {
-        return function(res, err) {
-            if (err) {
-                return done(err);
-            }
-
-            assert.ok(
-                !res.headers['x-cache-channel'],
-                'did not expect x-cache-channel header, got: `' + res.headers['x-cache-channel'] + '`'
-            );
-            done();
-        };
-    }
-
-    function withLayergroupId(callback) {
-        assert.response(
-            server,
-            layergroupRequest,
-            statusOkResponse,
-            function(res, err) {
-                if (err) {
-                    return callback(err);
-                }
-                callback(null, JSON.parse(res.body).layergroupid);
-            }
-        );
-    }
-
-    describe('header should be present', function() {
-
-        it('/api/v1/map Map instantiation', function(done) {
-            assert.response(
-                server,
-                layergroupRequest,
-                statusOkResponse,
-                validateXCacheChannel(done, 'test_windshaft_cartodb_user_1_db:public.test_table')
-            );
-        });
-
-        it ('/api/v1/map/:token/:z/:x/:y@:scale_factor?x.:format Mapnik retina tiles', function(done) {
-            withLayergroupId(function(err, layergroupId) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/' + layergroupId + '/0/0/0@2x.png'),
-                    validateXCacheChannel(done, 'test_windshaft_cartodb_user_1_db:public.test_table')
-                );
-            });
-        });
-
-        it ('/api/v1/map/:token/:z/:x/:y@:scale_factor?x.:format Mapnik tiles', function(done) {
-            withLayergroupId(function(err, layergroupId) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/' + layergroupId + '/0/0/0.png'),
-                    validateXCacheChannel(done, 'test_windshaft_cartodb_user_1_db:public.test_table')
-                );
-            });
-        });
-
-        it ('/api/v1/map/:token/:layer/:z/:x/:y.(:format) Per :layer rendering', function(done) {
-            withLayergroupId(function(err, layergroupId) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/' + layergroupId + '/0/0/0/0.png'),
-                    validateXCacheChannel(done, 'test_windshaft_cartodb_user_1_db:public.test_table')
-                );
-            });
-        });
-
-        it ('/api/v1/map/:token/:layer/attributes/:fid endpoint for info windows', function(done) {
-            withLayergroupId(function(err, layergroupId) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/' + layergroupId + '/0/attributes/1'),
-                    validateXCacheChannel(done, 'test_windshaft_cartodb_user_1_db:public.test_table')
-                );
-            });
-        });
-
-        it ('/api/v1/map/static/center/:token/:z/:lat/:lng/:width/:height.:format static maps', function(done) {
-            withLayergroupId(function(err, layergroupId) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/static/center/' + layergroupId + '/0/0/0/400/300.png'),
-                    validateXCacheChannel(done, 'test_windshaft_cartodb_user_1_db:public.test_table')
-                );
-            });
-        });
-
-        it ('/api/v1/map/static/bbox/:token/:bbox/:width/:height.:format static maps', function(done) {
-            withLayergroupId(function(err, layergroupId) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/static/bbox/' + layergroupId + '/-45,-45,45,45/400/300.png'),
-                    validateXCacheChannel(done, 'test_windshaft_cartodb_user_1_db:public.test_table')
-                );
-            });
-        });
-
-    });
-
-    describe('header should NOT be present', function() {
-
-        it('/', function(done) {
-            assert.response(
-                server,
-                getRequest('/'),
-                statusOkResponse,
-                noXCacheChannelHeader(done)
-            );
-        });
-
-        it('/version', function(done) {
-            assert.response(
-                server,
-                getRequest('/version'),
-                statusOkResponse,
-                noXCacheChannelHeader(done)
-            );
-        });
-
-        it('/health', function(done) {
-            assert.response(
-                server,
-                getRequest('/health'),
-                statusOkResponse,
-                noXCacheChannelHeader(done)
-            );
-        });
-
-        it('/api/v1/map/named list named maps', function(done) {
-            assert.response(
-                server,
-                getRequest('/api/v1/map/named', true),
-                statusOkResponse,
-                noXCacheChannelHeader(done)
-            );
-        });
-
-        describe('with named maps', function() {
-
-            var templateName = 'x_cache';
-
-            before(function(done) {
-                var template =  {
-                    version: '0.0.1',
-                    name: templateName,
-                    auth: {
-                        method: 'open'
-                    },
-                    layergroup:  mapConfig
-                };
-
-                var namedMapRequest = {
-                    url: '/api/v1/map/named?api_key=1234',
-                    method: 'POST',
-                    headers: {
-                        host: 'localhost',
-                        'Content-Type': 'application/json'
-                    },
-                    data: JSON.stringify(template)
-                };
-
-                assert.response(
-                    server,
-                    namedMapRequest,
-                    statusOkResponse,
-                    function(res, err) {
-                        done(err);
-                    }
-                );
-            });
-
-            after(function(done) {
-                assert.response(
-                    server,
-                    {
-                        url: '/api/v1/map/named/' + templateName + '?api_key=1234',
-                        method: 'DELETE',
-                        headers: {
-                            host: 'localhost'
-                        }
-                    },
-                    {
-                        status: 204
-                    },
-                    function(res, err) {
-                        done(err);
-                    }
-                );
-            });
-
-
-            it('/api/v1/map/named/:template_id Named map retrieval', function(done) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/named/' + templateName, true),
-                    statusOkResponse,
-                    noXCacheChannelHeader(done)
-                );
-            });
-
-            it('/api/v1/map/named/:template_id/jsonp Named map retrieval', function(done) {
-                assert.response(
-                    server,
-                    getRequest('/api/v1/map/named/' + templateName, true, 'cb'),
-                    statusOkResponse,
-                    noXCacheChannelHeader(done)
-                );
-            });
-
-        });
-
-    });
-
-
-});

test/integration/mapconfig_named_layers_datasource.js

@@ -1,304 +0,0 @@
-require('../support/test_helper');
-
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../lib/cartodb/template_maps.js');
-var PgConnection = require(__dirname + '/../../lib/cartodb/backends/pg_connection');
-var MapConfigNamedLayersAdapter = require('../../lib/cartodb/models/mapconfig_named_layers_adapter');
-
-// configure redis pool instance to use in tests
-var redisPool = new RedisPool(global.environment.redis);
-var pgConnection = new PgConnection(require('cartodb-redis')({ pool: redisPool }));
-
-var templateMaps = new TemplateMaps(redisPool, {
-    max_user_templates: global.environment.maxUserTemplates
-});
-
-var mapConfigNamedLayersAdapter = new MapConfigNamedLayersAdapter(templateMaps);
-
-var wadusSql = 'select 1 wadusLayer, null::geometry the_geom_webmercator';
-var wadusLayer = {
-    type: 'cartodb',
-    options: {
-        sql: wadusSql,
-        cartocss: '#layer { marker-fill: black; }',
-        cartocss_version: '2.3.0'
-    }
-};
-
-var wadusTemplateSql = 'select 1 wadusTemplateLayer, null::geometry the_geom_webmercator';
-var wadusTemplateLayer = {
-    type: 'cartodb',
-    options: {
-        sql: wadusTemplateSql,
-        cartocss: '#layer { marker-fill: <%= color %>; }',
-        cartocss_version: '2.3.0'
-    }
-};
-
-var wadusMapnikSql = 'select 1 wadusMapnikLayer, null::geometry the_geom_webmercator';
-var wadusMapnikLayer = {
-    type: 'mapnik',
-    options: {
-        sql: wadusMapnikSql,
-        cartocss: '#layer { polygon-fill: <%= polygon_color %>; }',
-        cartocss_version: '2.3.0'
-    }
-};
-
-var username = 'localhost';
-
-var templateName = 'valid_template';
-var template = {
-    version: '0.0.1',
-    name: templateName,
-    auth: {
-        method: 'open'
-    },
-    "placeholders": {
-        "color": {
-            "type": "css_color",
-            "default": "#cc3300"
-        }
-    },
-    layergroup: {
-        layers: [
-            wadusTemplateLayer
-        ]
-    }
-};
-
-var multipleLayersTemplateName = 'multiple_valid_template';
-var multipleLayersTemplate = {
-    version: '0.0.1',
-    name: multipleLayersTemplateName,
-    auth: {
-        method: 'token',
-        valid_tokens: ['valid1', 'valid2']
-    },
-    "placeholders": {
-        "polygon_color": {
-            "type": "css_color",
-            "default": "green"
-        },
-        "color": {
-            "type": "css_color",
-            "default": "red"
-        }
-    },
-    layergroup: {
-        layers: [
-            wadusMapnikLayer,
-            wadusTemplateLayer
-        ]
-    }
-};
-
-describe('named_layers datasources', function() {
-    before(function(done) {
-        templateMaps.addTemplate(username, template, function(err) {
-            if (err) {
-                return done(err);
-            }
-            templateMaps.addTemplate(username, multipleLayersTemplate, done);
-        });
-    });
-
-    function makeNamedMapLayerConfig(layers) {
-        return {
-            version: '1.3.0',
-            layers: layers
-        };
-    }
-
-    var simpleNamedLayer = {
-        type: 'named',
-        options: {
-            name: templateName
-        }
-    };
-
-    var multipleLayersNamedLayer = {
-        type: 'named',
-        options: {
-            name: multipleLayersTemplateName,
-            auth_tokens: ['valid2']
-        }
-    };
-
-    var testScenarios = [
-        {
-            desc: 'without datasource for non-named layers',
-            config: makeNamedMapLayerConfig([wadusLayer]),
-            test: function(err, layers, datasource, done) {
-                assert.ok(!err);
-                assert.equal(layers.length, 1);
-
-                assert.equal(layers[0].type, 'cartodb');
-                assert.equal(layers[0].options.sql, wadusSql);
-                assert.equal(datasource.getLayerDatasource(0), undefined);
-
-                done();
-            }
-        },
-
-        {
-            desc: 'with datasource for the named layer but not for the normal',
-            config: makeNamedMapLayerConfig([wadusLayer, simpleNamedLayer]),
-            test: function(err, layers, datasource, done) {
-                assert.ok(!err);
-                assert.equal(layers.length, 2);
-
-                assert.equal(layers[0].type, 'cartodb');
-                assert.equal(layers[0].options.sql, wadusSql);
-                assert.equal(datasource.getLayerDatasource(0), undefined);
-
-                assert.equal(layers[1].type, 'cartodb');
-                assert.equal(layers[1].options.sql, wadusTemplateSql);
-                var layerDatasource = datasource.getLayerDatasource(1);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                done();
-            }
-        },
-
-        {
-            desc: 'with datasource for the multiple layers in the named but not for the normal',
-            config: makeNamedMapLayerConfig([wadusLayer, multipleLayersNamedLayer]),
-            test: function(err, layers, datasource, done) {
-                assert.ok(!err);
-                assert.equal(layers.length, 3);
-
-                assert.equal(layers[0].type, 'cartodb');
-                assert.equal(layers[0].options.sql, wadusSql);
-                assert.equal(datasource.getLayerDatasource(0), undefined);
-
-                assert.equal(layers[1].type, 'mapnik');
-                assert.equal(layers[1].options.sql, wadusMapnikSql);
-                var layerDatasource = datasource.getLayerDatasource(1);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[2].type, 'cartodb');
-                assert.equal(layers[2].options.sql, wadusTemplateSql);
-                layerDatasource = datasource.getLayerDatasource(2);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                done();
-            }
-        },
-
-        {
-            desc: 'all with datasource because all are named',
-            config: makeNamedMapLayerConfig([multipleLayersNamedLayer, simpleNamedLayer]),
-            test: function(err, layers, datasource, done) {
-                assert.ok(!err);
-                assert.equal(layers.length, 3);
-
-                assert.equal(layers[0].type, 'mapnik');
-                assert.equal(layers[0].options.sql, wadusMapnikSql);
-                var layerDatasource = datasource.getLayerDatasource(0);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[1].type, 'cartodb');
-                assert.equal(layers[1].options.sql, wadusTemplateSql);
-                layerDatasource = datasource.getLayerDatasource(1);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[2].type, 'cartodb');
-                assert.equal(layers[2].options.sql, wadusTemplateSql);
-                layerDatasource = datasource.getLayerDatasource(2);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                done();
-            }
-        },
-
-        {
-            desc: 'with a mix of datasource and no datasource depending if layers are named or not',
-            config: makeNamedMapLayerConfig([
-                simpleNamedLayer,
-                multipleLayersNamedLayer,
-                wadusLayer,
-                simpleNamedLayer,
-                wadusLayer,
-                multipleLayersNamedLayer
-            ]),
-            test: function(err, layers, datasource, done) {
-
-                assert.ok(!err);
-                assert.equal(layers.length, 8);
-
-                assert.equal(layers[0].type, 'cartodb');
-                assert.equal(layers[0].options.sql, wadusTemplateSql);
-                var layerDatasource = datasource.getLayerDatasource(0);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[1].type, 'mapnik');
-                assert.equal(layers[1].options.sql, wadusMapnikSql);
-                layerDatasource = datasource.getLayerDatasource(1);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[2].type, 'cartodb');
-                assert.equal(layers[2].options.sql, wadusTemplateSql);
-                layerDatasource = datasource.getLayerDatasource(2);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[3].type, 'cartodb');
-                assert.equal(layers[3].options.sql, wadusSql);
-                assert.equal(datasource.getLayerDatasource(3), undefined);
-
-                assert.equal(layers[4].type, 'cartodb');
-                assert.equal(layers[4].options.sql, wadusTemplateSql);
-                layerDatasource = datasource.getLayerDatasource(4);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[5].type, 'cartodb');
-                assert.equal(layers[5].options.sql, wadusSql);
-                assert.equal(datasource.getLayerDatasource(5), undefined);
-
-                assert.equal(layers[6].type, 'mapnik');
-                assert.equal(layers[6].options.sql, wadusMapnikSql);
-                layerDatasource = datasource.getLayerDatasource(6);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                assert.equal(layers[7].type, 'cartodb');
-                assert.equal(layers[7].options.sql, wadusTemplateSql);
-                layerDatasource = datasource.getLayerDatasource(7);
-                assert.notEqual(layerDatasource, undefined);
-                assert.ok(layerDatasource.user);
-
-                done();
-            }
-        }
-    ];
-
-    testScenarios.forEach(function(testScenario) {
-        it('should return a list of layers ' + testScenario.desc, function(done) {
-            mapConfigNamedLayersAdapter.getLayers(username, testScenario.config.layers, pgConnection,
-                function(err, layers, datasource) {
-                    testScenario.test(err, layers, datasource, done);
-                }
-            );
-        });
-    });
-
-    after(function(done) {
-        templateMaps.delTemplate(username, templateName, function(err) {
-            if (err) {
-                return done(err);
-            }
-            templateMaps.delTemplate(username, multipleLayersTemplateName, done);
-        });
-    });
-});

test/integration/mapconfig_named_layers_expanded.js

@@ -1,327 +0,0 @@
-require('../support/test_helper');
-
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../lib/cartodb/template_maps.js');
-var PgConnection = require(__dirname + '/../../lib/cartodb/backends/pg_connection');
-var MapConfigNamedLayersAdapter = require('../../lib/cartodb/models/mapconfig_named_layers_adapter');
-
-describe('mapconfig_named_layers_adapter', function() {
-
-    // configure redis pool instance to use in tests
-    var redisPool = new RedisPool(global.environment.redis);
-    var pgConnection = new PgConnection(require('cartodb-redis')({ pool: redisPool }));
-
-    var templateMaps = new TemplateMaps(redisPool, {
-        max_user_templates: global.environment.maxUserTemplates
-    });
-
-    var mapConfigNamedLayersAdapter = new MapConfigNamedLayersAdapter(templateMaps);
-
-    var wadusLayer = {
-        type: 'cartodb',
-        options: {
-            sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-            cartocss: '#layer { marker-fill: <%= color %>; }',
-            cartocss_version: '2.3.0'
-        }
-    };
-
-    var wadusMapnikLayer = {
-        type: 'mapnik',
-        options: {
-            sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-            cartocss: '#layer { polygon-fill: <%= polygon_color %>; }',
-            cartocss_version: '2.3.0'
-        }
-    };
-
-    var username = 'localhost';
-
-    var templateName = 'valid_template';
-    var template = {
-        version: '0.0.1',
-        name: templateName,
-        auth: {
-            method: 'open'
-        },
-        "placeholders": {
-            "color": {
-                "type": "css_color",
-                "default": "#cc3300"
-            }
-        },
-        layergroup: {
-            layers: [
-                wadusLayer
-            ]
-        }
-    };
-
-    var tokenAuthTemplateName = 'auth_valid_template';
-    var tokenAuthTemplate = {
-        version: '0.0.1',
-        name: tokenAuthTemplateName,
-        auth: {
-            method: 'token',
-            valid_tokens: ['valid1', 'valid2']
-        },
-        layergroup: {
-            layers: [
-                wadusLayer
-            ]
-        }
-    };
-
-    var multipleLayersTemplateName = 'multiple_valid_template';
-    var multipleLayersTemplate = {
-        version: '0.0.1',
-        name: multipleLayersTemplateName,
-        auth: {
-            method: 'token',
-            valid_tokens: ['valid1', 'valid2']
-        },
-        "placeholders": {
-            "polygon_color": {
-                "type": "css_color",
-                "default": "green"
-            },
-            "color": {
-                "type": "css_color",
-                "default": "red"
-            }
-        },
-        layergroup: {
-            layers: [
-                wadusMapnikLayer,
-                wadusLayer
-            ]
-        }
-    };
-
-    var namedMapLayer = {
-        type: 'named',
-        options: {
-            name: templateName,
-            config: {},
-            auth_tokens: []
-        }
-    };
-
-    var nestedNamedMapTemplateName = 'nested_template';
-    var nestedNamedMapTemplate = {
-        version: '0.0.1',
-        name: nestedNamedMapTemplateName,
-        auth: {
-            method: 'open'
-        },
-        layergroup: {
-            layers: [
-                namedMapLayer
-            ]
-        }
-    };
-
-    function makeNamedMapLayerConfig(options) {
-        return {
-            version: '1.3.0',
-            layers: [
-                {
-                    type: 'named',
-                    options: options
-                }
-            ]
-        };
-    }
-
-
-    before(function(done) {
-        templateMaps.addTemplate(username, template, done);
-    });
-
-    it('should fail for named map layer with missing name', function(done) {
-        var missingNamedMapLayerConfig = makeNamedMapLayerConfig({
-            config: {}
-        });
-        mapConfigNamedLayersAdapter.getLayers(username, missingNamedMapLayerConfig.layers, pgConnection,
-            function(err, layers, datasource) {
-                assert.ok(err);
-                assert.ok(!layers);
-                assert.ok(!datasource);
-                assert.equal(err.message, 'Missing Named Map `name` in layer options');
-
-                done();
-            }
-        );
-    });
-
-    it('should fail for non-existing template name', function(done) {
-        var missingTemplateName = 'wadus';
-        var nonExistentNamedMapLayerConfig = makeNamedMapLayerConfig({
-            name: missingTemplateName
-        });
-        mapConfigNamedLayersAdapter.getLayers(username, nonExistentNamedMapLayerConfig.layers, pgConnection,
-            function(err, layers, datasource) {
-                assert.ok(err);
-                assert.ok(!layers);
-                assert.ok(!datasource);
-                assert.equal(
-                    err.message, "Template '" + missingTemplateName + "' of user '" + username + "' not found"
-                );
-
-                done();
-            }
-        );
-    });
-
-    it('should fail if not properly authorized', function(done) {
-        templateMaps.addTemplate(username, tokenAuthTemplate, function(err) {
-            if (err) {
-                return done(err);
-            }
-
-            var nonAuthTokensNamedMapLayerConfig = makeNamedMapLayerConfig({
-                name: tokenAuthTemplateName
-            });
-            mapConfigNamedLayersAdapter.getLayers(username, nonAuthTokensNamedMapLayerConfig.layers, pgConnection,
-                function(err, layers, datasource) {
-                    assert.ok(err);
-                    assert.ok(!layers);
-                    assert.ok(!datasource);
-                    assert.equal(err.message, "Unauthorized '" + tokenAuthTemplateName + "' template instantiation");
-
-                    templateMaps.delTemplate(username, tokenAuthTemplateName, done);
-                }
-            );
-        });
-    });
-
-    it('should fail for nested named map layers', function(done) {
-        templateMaps.addTemplate(username, nestedNamedMapTemplate, function(err) {
-            if (err) {
-                return done(err);
-            }
-
-            var nestedNamedMapLayerConfig = makeNamedMapLayerConfig({
-                name: nestedNamedMapTemplateName
-            });
-            mapConfigNamedLayersAdapter.getLayers(username, nestedNamedMapLayerConfig.layers, pgConnection,
-                function(err, layers, datasource) {
-                    assert.ok(err);
-                    assert.ok(!layers);
-                    assert.ok(!datasource);
-                    assert.equal(err.message, 'Nested named layers are not allowed');
-
-                    templateMaps.delTemplate(username, nestedNamedMapTemplateName, done);
-                }
-            );
-        });
-    });
-
-    it('should return an expanded list of layers for a named map layer', function(done) {
-        var validNamedMapMapLayerConfig = makeNamedMapLayerConfig({
-            name: templateName
-        });
-        mapConfigNamedLayersAdapter.getLayers(username, validNamedMapMapLayerConfig.layers, pgConnection,
-            function(err, layers, datasource) {
-                assert.ok(!err);
-                assert.ok(layers.length, 1);
-                assert.ok(layers[0].type, 'cartodb');
-                assert.notEqual(datasource.getLayerDatasource(0), undefined);
-
-                done();
-            }
-        );
-    });
-
-    it('should return on auth=token with valid tokens provided', function(done) {
-        templateMaps.addTemplate(username, tokenAuthTemplate, function(err) {
-            if (err) {
-                return done(err);
-            }
-
-            var validAuthTokensNamedMapLayerConfig = makeNamedMapLayerConfig({
-                name: tokenAuthTemplateName,
-                auth_tokens: ['valid1']
-            });
-            mapConfigNamedLayersAdapter.getLayers(username, validAuthTokensNamedMapLayerConfig.layers, pgConnection,
-                function(err, layers, datasource) {
-                    assert.ok(!err);
-                    assert.equal(layers.length, 1);
-                    assert.notEqual(datasource.getLayerDatasource(0), undefined);
-
-                    templateMaps.delTemplate(username, tokenAuthTemplateName, done);
-                }
-            );
-        });
-    });
-
-    it('should return an expanded list of layers for a named map layer, multiple layers version', function(done) {
-        templateMaps.addTemplate(username, multipleLayersTemplate, function(err) {
-            if (err) {
-                return done(err);
-            }
-
-            var multipleLayersNamedMapLayerConfig = makeNamedMapLayerConfig({
-                name: multipleLayersTemplateName,
-                auth_tokens: ['valid2']
-            });
-            mapConfigNamedLayersAdapter.getLayers(username, multipleLayersNamedMapLayerConfig.layers, pgConnection,
-                function(err, layers, datasource) {
-                    assert.ok(!err);
-                    assert.equal(layers.length, 2);
-
-                    assert.equal(layers[0].type, 'mapnik');
-                    assert.equal(layers[0].options.cartocss, '#layer { polygon-fill: green; }');
-                    assert.notEqual(datasource.getLayerDatasource(0), undefined);
-
-                    assert.equal(layers[1].type, 'cartodb');
-                    assert.equal(layers[1].options.cartocss, '#layer { marker-fill: red; }');
-                    assert.notEqual(datasource.getLayerDatasource(1), undefined);
-
-                    templateMaps.delTemplate(username, multipleLayersTemplateName, done);
-                }
-            );
-        });
-    });
-
-    it('should replace template params with the given config', function(done) {
-        templateMaps.addTemplate(username, multipleLayersTemplate, function(err) {
-            if (err) {
-                return done(err);
-            }
-
-            var color = '#cc3300',
-                polygonColor = '#ff9900';
-
-            var multipleLayersNamedMapLayerConfig = makeNamedMapLayerConfig({
-                name: multipleLayersTemplateName,
-                config: {
-                    polygon_color: polygonColor,
-                    color: color
-                },
-                auth_tokens: ['valid2']
-            });
-            mapConfigNamedLayersAdapter.getLayers(username, multipleLayersNamedMapLayerConfig.layers, pgConnection,
-                function(err, layers, datasource) {
-                    assert.ok(!err);
-                    assert.equal(layers.length, 2);
-
-                    assert.equal(layers[0].type, 'mapnik');
-                    assert.equal(layers[0].options.cartocss, '#layer { polygon-fill: ' + polygonColor + '; }');
-                    assert.notEqual(datasource.getLayerDatasource(0), undefined);
-
-                    assert.equal(layers[1].type, 'cartodb');
-                    assert.equal(layers[1].options.cartocss, '#layer { marker-fill: ' + color + '; }');
-                    assert.notEqual(datasource.getLayerDatasource(1), undefined);
-
-                    templateMaps.delTemplate(username, multipleLayersTemplateName, done);
-                }
-            );
-        });
-    });
-
-    after(function(done) {
-        templateMaps.delTemplate(username, templateName, done);
-    });
-});

test/support/SQLAPIEmu.js

@@ -0,0 +1,38 @@
+var http        = require('http');
+var url         = require('url');
+
+var o = function(port, cb) {
+
+  this.queries = [];
+  var that = this;
+  this.sqlapi_server = http.createServer(function(req,res) {
+        var query = url.parse(req.url, true).query;
+        that.queries.push(query);
+        if ( query.q.match('SQLAPIERROR') ) {
+          res.statusCode = 400;
+          res.write(JSON.stringify({'error':'Some error occurred'}));
+        } else if ( query.q.match('EPOCH.* as max') ) {
+          // This is the structure of the known query sent by tiler
+          var row = {
+            'max': 1234567890.123
+          };
+          res.write(JSON.stringify({rows: [ row ]}));
+        } else {
+          var qs = JSON.stringify(query);
+          var row = {
+            // This is the structure of the known query sent by tiler
+            'cdb_querytables': '{' + qs + '}',
+            'max': qs
+          };
+          res.write(JSON.stringify({rows: [ row ]}));
+        }
+        res.end();
+   }).listen(port, cb);
+};
+
+o.prototype.close = function(cb) {
+  this.sqlapi_server.close(cb);
+};
+
+module.exports = o;
+

test/support/VarnishEmu.js

@@ -0,0 +1,25 @@
+var net = require('net');
+
+module.exports = function(on_cmd_recieved, test_callback) {
+    var self = this;
+    var welcome_msg = 'hi, im a varnish emu, right?';
+
+    self.commands_recieved = [];
+
+    var server = net.createServer(function (socket) {
+      var command = '';
+      socket.write("200 " + welcome_msg.length + "\n");
+      socket.write(welcome_msg);
+      socket.on('data', function(data) {
+        self.commands_recieved.push(data);
+        on_cmd_recieved && on_cmd_recieved(self.commands_recieved);
+        socket.write('200 0\n');
+      });
+    });
+    server.listen(1337, "127.0.0.1");
+
+    server.on('listening', function(){
+      test_callback();
+    });
+};
+

test/support/assert.js

@@ -1,11 +1,10 @@
 // Cribbed from the ever prolific Konstantin Kaefer
 // https://github.com/mapbox/tilelive-mapnik/blob/master/test/support/assert.js
 
-var exec = require('child_process').exec,
-    fs = require('fs'),
-    http = require('http'),
-    path = require('path'),
-    util = require('util');
+var fs = require('fs');
+var http = require('http');
+var path = require('path');
+var exec = require('child_process').exec;
 
 var assert = module.exports = exports = require('assert');
 
@@ -67,51 +66,35 @@ assert.utfgridEqualsFile = function(buffer, file_b, tolerance, callback) {
     callback(err);
 };
 
-/**
- * Takes an image data as an input and an image path and compare them using ImageMagick fuzz algorithm, if case the
- * similarity is not within the tolerance limit it will callback with an error.
- *
- * @param buffer The image data to compare from
- * @param {string} referenceImageRelativeFilePath The relative file to compare against
- * @param {number} tolerance tolerated mean color distance, as a per mil (‰)
- * @param {function} callback Will call to home with null in case there is no error, otherwise with the error itself
- * @see FUZZY in http://www.imagemagick.org/script/command-line-options.php#metric
- */
-assert.imageEqualsFile = function(buffer, referenceImageRelativeFilePath, tolerance, callback) {
+//
+// @param tol tolerated color distance as a percent over max channel value
+//            by default this is zero. For meaningful values, see
+//            http://www.imagemagick.org/script/command-line-options.php#metric
+//
+assert.imageEqualsFile = function(buffer, file_b, tol, callback) {
     if (!callback) callback = function(err) { if (err) throw err; };
-    var referenceImageFilePath = path.resolve(referenceImageRelativeFilePath),
-        testImageFilePath = '/tmp/windshaft-test-image-' + (Math.random() * 1e16); // TODO: make predictable
-    var err = fs.writeFileSync(testImageFilePath, buffer, 'binary');
+    file_b = path.resolve(file_b);
+    var file_a = '/tmp/windshaft-test-image-test.png'; // + (Math.random() * 1e16); // TODO: make predictable 
+    var err = fs.writeFileSync(file_a, buffer, 'binary');
     if (err) throw err;
 
-    var imageMagickCmd = util.format(
-        'compare -metric fuzz "%s" "%s" /dev/null',
-        testImageFilePath, referenceImageFilePath
-    );
-
-    exec(imageMagickCmd, function(err, stdout, stderr) {
+    var fuzz = tol + '%';
+    exec('compare -fuzz ' + fuzz + ' -metric AE "' + file_a + '" "' +
+            file_b + '" /dev/null', function(err, stdout, stderr) {
         if (err) {
-            fs.unlinkSync(testImageFilePath);
+            fs.unlinkSync(file_a);
             callback(err);
         } else {
             stderr = stderr.trim();
-            var metrics = stderr.match(/([0-9]*) \((.*)\)/);
-            if ( ! metrics ) {
-                callback(new Error("No match for " + stderr));
-                return;
-            }
-            var similarity = parseFloat(metrics[2]),
-                tolerancePerMil = (tolerance / 1000);
-            if (similarity > tolerancePerMil) {
-                err = new Error(util.format(
-                        'Images %s and %s are not equal (got %d similarity, expected %d)',
-                        testImageFilePath, referenceImageFilePath, similarity, tolerancePerMil)
-                );
-                err.similarity = similarity;
-                callback(err);
+            var similarity = parseFloat(stderr);
+            if ( similarity > 0 ) {
+              var err = new Error('Images not equal(' + similarity + '): ' +
+                      file_a  + '    ' + file_b);
+              err.similarity = similarity;
+              callback(err);
             } else {
-                fs.unlinkSync(testImageFilePath);
-                callback(null);
+              fs.unlinkSync(file_a);
+              callback(null);
             }
         }
     });
@@ -226,8 +209,6 @@ assert.response = function(server, req, res, msg){
             response.on('end', function(){
                 if (timer) clearTimeout(timer);
 
-                check();
-
                 // Assert response body
                 if (res.body !== undefined) {
                     var eql = res.body instanceof RegExp
@@ -246,10 +227,9 @@ assert.response = function(server, req, res, msg){
                     assert.equal(
                         response.statusCode,
                         status,
-                        msg + colorize('Invalid response status code.\n'
+                        msg + 'Invalid response status code.\n'
                             + '    Expected: [green]{' + status + '}\n'
-                            + '    Got: [red]{' + response.statusCode + '}\n'
-                            + '    Response body: ' + response.body)
+                            + '    Got: [red]{' + response.statusCode + '}'
                     );
                 }
 
@@ -274,6 +254,7 @@ assert.response = function(server, req, res, msg){
 
                 // Callback
                 callback(response);
+                check();
             });
         });
 
@@ -281,16 +262,3 @@ assert.response = function(server, req, res, msg){
       }
 };
 
-/**
- * Colorize the given string using ansi-escape sequences.
- * Disabled when --boring is set.
- *
- * @param {String} str
- * @return {String}
- */
-function colorize(str) {
-    var colors = { bold: 1, red: 31, green: 32, yellow: 33 };
-    return str.replace(/\[(\w+)\]\{([^]*?)\}/g, function(_, color, str) {
-        return '\x1B[' + colors[color] + 'm' + str + '\x1B[0m';
-    });
-}

test/support/prepare_db.sh

@@ -10,109 +10,28 @@
 #        TODO: fix that
 #
 
-PREPARE_REDIS=yes
-PREPARE_PGSQL=yes
-
-while [ -n "$1" ]; do
-  if test "$1" = "--skip-pg"; then
-    PREPARE_PGSQL=no
-    shift; continue
-  elif test "$1" = "--skip-redis"; then
-    PREPARE_REDIS=no
-    shift; continue
-  fi
-done
-
 die() {
         msg=$1
         echo "${msg}" >&2
         exit 1
 }
 
-# This is where postgresql connection parameters are read from
-TESTENV=../../config/environments/test.js
-if [ \! -r ${TESTENV} ]; then
-  echo "Cannot read ${TESTENV}" >&2
-  exit 1
-fi
-
-TESTUSERID=1
-
-TESTUSER=`node -e "console.log(require('${TESTENV}').postgres_auth_user || '')"`
-if test -z "$TESTUSER"; then
-  echo "Missing postgres_auth_user from ${TESTENV}" >&2
-  exit 1
-fi
-TESTUSER=`echo ${TESTUSER} | sed "s/<%= user_id %>/${TESTUSERID}/"`
-
-TESTPASS=`node -e "console.log(require('${TESTENV}').postgres_auth_pass || 'test')"`
-# TODO: should postgres_auth_pass be optional ?
-if test -z "$TESTPASS"; then
-  echo "Missing postgres_auth_pass from ${TESTENV}" >&2
-  exit 1
-fi
-TESTPASS=`echo ${TESTPASS} | sed "s/<%= user_id %>/${TESTUSERID}/"`
-
-TEST_DB="${TESTUSER}_db"
-
-# NOTE: will be set by caller trough environment
+TEST_DB="cartodb_test_user_1_db"
 if test -z "$REDIS_PORT"; then REDIS_PORT=6333; fi
 
-PUBLICUSER=`node -e "console.log(require('${TESTENV}').postgres.user || 'xxx')"`
-PUBLICPASS=`node -e "console.log(require('${TESTENV}').postgres.password || 'xxx')"`
-echo "PUBLICUSER: ${PUBLICUSER}"
-echo "PUBLICPASS: ${PUBLICPASS}"
-echo "TESTUSER: ${TESTUSER}"
-echo "TESTPASS: ${TESTPASS}"
+echo "preparing postgres..."
+dropdb "${TEST_DB}"
+createdb -Ttemplate_postgis -EUTF8 "${TEST_DB}" || die "Could not create test database"
+psql "${TEST_DB}" < ./sql/windshaft.test.sql
+psql "${TEST_DB}" < ./sql/gadm4.sql
 
-if test x"$PREPARE_PGSQL" = xyes; then
-
-  echo "preparing postgres..."
-  dropdb "${TEST_DB}"
-  createdb -Ttemplate_postgis -EUTF8 "${TEST_DB}" || die "Could not create test database"
-
-  cat sql/windshaft.test.sql sql/gadm4.sql |
-    sed "s/:PUBLICUSER/${PUBLICUSER}/" | 
-    sed "s/:PUBLICPASS/${PUBLICPASS}/" | 
-    sed "s/:TESTUSER/${TESTUSER}/" | 
-    sed "s/:TESTPASS/${TESTPASS}/" | 
-    psql -v ON_ERROR_STOP=1 ${TEST_DB} || exit 1
-
-  psql -c "CREATE EXTENSION plpythonu;" ${TEST_DB}
-  curl -L -s https://github.com/CartoDB/cartodb-postgresql/raw/cdb/scripts-available/CDB_QueryStatements.sql -o sql/CDB_QueryStatements.sql
-  curl -L -s https://github.com/CartoDB/cartodb-postgresql/raw/cdb/scripts-available/CDB_QueryTables.sql -o sql/CDB_QueryTables.sql
-  cat sql/CDB_QueryStatements.sql sql/CDB_QueryTables.sql |
-    psql -v ON_ERROR_STOP=1 ${TEST_DB} || exit 1
-
-fi
-
-if test x"$PREPARE_REDIS" = xyes; then
-
-  echo "preparing redis..."
-
-  cat <<EOF | redis-cli -p ${REDIS_PORT} -n 5
-HMSET rails:users:localhost id ${TESTUSERID} \
-                            database_name "${TEST_DB}" \
-                            database_host localhost \
-                            map_key 1234
-SADD rails:users:localhost:map_key 1235
-EOF
-
-  # A user configured as with cartodb-2.5.0+ 
-  cat <<EOF | redis-cli -p ${REDIS_PORT} -n 5
-HMSET rails:users:cartodb250user id ${TESTUSERID} \
-                                 database_name "${TEST_DB}" \
-                                 database_host "localhost" \
-                                 database_password "${TESTPASS}" \
-                                 map_key 4321
-EOF
-
-  cat <<EOF | redis-cli -p ${REDIS_PORT} -n 0
-HSET rails:${TEST_DB}:my_table infowindow "this, that, the other"
-HSET rails:${TEST_DB}:test_table_private_1 privacy "0"
-EOF
-
-fi
+echo "preparing redis..."
+echo "HSET rails:users:localhost id 1" | redis-cli -p ${REDIS_PORT} -n 5
+echo 'HSET rails:users:localhost database_name "'"${TEST_DB}"'"' | redis-cli -p ${REDIS_PORT} -n 5
+echo "HSET rails:users:localhost map_key 1234" | redis-cli -p ${REDIS_PORT} -n 5
+echo "SADD rails:users:localhost:map_key 1235" | redis-cli -p ${REDIS_PORT} -n 5
+echo 'HSET rails:'"${TEST_DB}"':my_table infowindow "this, that, the other"' | redis-cli -p ${REDIS_PORT} -n 0
+echo 'HSET rails:'"${TEST_DB}"':test_table_private_1 privacy "0"' | redis-cli -p ${REDIS_PORT} -n 0
 
 echo "Finished preparing data. Ready to run tests"
 

test/support/sql/CDB_QueryStatements.sql

@@ -1,14 +0,0 @@
--- Return an array of statements found in the given query text
---
--- Regexp curtesy of Hubert Lubaczewski (depesz)
--- Implemented in plpython for performance reasons
---
-CREATE OR REPLACE FUNCTION CDB_QueryStatements(query text) 
-RETURNS SETOF TEXT AS $$
-  import re
-  pat = re.compile( r'''((?:[^'"$;]+|"[^"]*"|'[^']*'|(\$[^$]*\$).*?\2)+)''', re.DOTALL )
-  for match in pat.findall(query):
-    cleaned = match[0].strip()
-    if ( cleaned ):
-      yield cleaned
-$$ language 'plpythonu' IMMUTABLE STRICT;

test/support/sql/CDB_QueryTables.sql

@@ -1,67 +0,0 @@
--- Return an array of table names scanned by a given query
---
--- Requires PostgreSQL 9.x+
---
-CREATE OR REPLACE FUNCTION CDB_QueryTables(query text)
-RETURNS name[]
-AS $$
-DECLARE
-  exp XML;
-  tables NAME[];
-  rec RECORD;
-  rec2 RECORD;
-BEGIN
-  
-  tables := '{}';
-
-  FOR rec IN SELECT CDB_QueryStatements(query) q LOOP
-
-    IF NOT ( rec.q ilike 'select%' or rec.q ilike 'with%' ) THEN
-        --RAISE WARNING 'Skipping %', rec.q;
-        CONTINUE;
-    END IF;
-
-    BEGIN
-      EXECUTE 'EXPLAIN (FORMAT XML, VERBOSE) ' || rec.q INTO STRICT exp;
-    EXCEPTION WHEN others THEN
-      -- TODO: if error is 'relation "xxxxxx" does not exist', take xxxxxx as
-      --       the affected table ?
-      RAISE WARNING 'CDB_QueryTables cannot explain query: % (%: %)', rec.q, SQLSTATE, SQLERRM;
-      RAISE EXCEPTION '%', SQLERRM;
-      CONTINUE;
-    END;
-
-    -- Now need to extract all values of <Relation-Name>
-
-    -- RAISE DEBUG 'Explain: %', exp;
-
-    FOR rec2 IN WITH
-      inp AS (
-        SELECT
-          xpath('//x:Relation-Name/text()', exp, ARRAY[ARRAY['x', 'http://www.postgresql.org/2009/explain']]) as x,
-          xpath('//x:Relation-Name/../x:Schema/text()', exp, ARRAY[ARRAY['x', 'http://www.postgresql.org/2009/explain']]) as s
-      )
-      SELECT unnest(x)::name as p, unnest(s)::name as sc from inp
-    LOOP
-      -- RAISE DEBUG 'tab: %', rec2.p;
-      -- RAISE DEBUG 'sc: %', rec2.sc;
-      tables := array_append(tables, (rec2.sc || '.' || rec2.p)::name);
-    END LOOP;
-
-    -- RAISE DEBUG 'Tables: %', tables;
-
-  END LOOP;
-
-  -- RAISE DEBUG 'Tables: %', tables;
-
-  -- Remove duplicates and sort by name
-  IF array_upper(tables, 1) > 0 THEN
-    WITH dist as ( SELECT DISTINCT unnest(tables)::text as p ORDER BY p )
-       SELECT array_agg(p) from dist into tables;
-  END IF;
-
-  --RAISE DEBUG 'Tables: %', tables;
-
-  return tables;
-END
-$$ LANGUAGE 'plpgsql' VOLATILE STRICT;

test/support/sql/gadm4.sql

@@ -22,15 +22,15 @@ CREATE TABLE gadm4 (
     the_geom_webmercator geometry(MultiPolygon,3857)
 );
 
---GRANT ALL ON TABLE gadm4 TO postgres;
-GRANT ALL ON TABLE gadm4 TO :PUBLICUSER;
+GRANT ALL ON TABLE gadm4 TO postgres;
+GRANT ALL ON TABLE gadm4 TO publicuser;
 CREATE SEQUENCE gadm4_seq
     START WITH 1
     INCREMENT BY 1
     NO MINVALUE
     NO MAXVALUE
     CACHE 1;
---ALTER TABLE public.gadm4_seq OWNER TO postgres;
+ALTER TABLE public.gadm4_seq OWNER TO postgres;
 SELECT pg_catalog.setval('gadm4_seq', 58, false);
 ALTER TABLE gadm4 ALTER COLUMN cartodb_id SET DEFAULT nextval('gadm4_seq'::regclass);
 
@@ -98,6 +98,6 @@ ALTER TABLE ONLY gadm4
 
 CREATE INDEX bdll25_provincias_4326_2_the_geom_webmercator_idx ON gadm4 USING gist (the_geom_webmercator);
 
-GRANT ALL ON TABLE gadm4 TO :TESTUSER;
-GRANT SELECT ON TABLE gadm4 TO :PUBLICUSER;
+GRANT ALL ON TABLE gadm4 TO test_cartodb_user_1;
+GRANT SELECT ON TABLE gadm4 TO publicuser;
 

test/support/sql/windshaft.test.sql

@@ -15,13 +15,11 @@ SET search_path = public, pg_catalog;
 SET default_tablespace = '';
 SET default_with_oids = false;
 
--- public user role
-DROP USER IF EXISTS :PUBLICUSER;
-CREATE USER :PUBLICUSER WITH PASSWORD ':PUBLICPASS';
+-- publicuser role
+CREATE USER publicuser;
 
 -- db owner role
-DROP USER IF EXISTS :TESTUSER;
-CREATE USER :TESTUSER WITH PASSWORD ':TESTPASS';
+CREATE USER test_cartodb_user_1;
 
 -- first table
 CREATE TABLE test_table (
@@ -65,8 +63,8 @@ ALTER TABLE ONLY test_table ADD CONSTRAINT test_table_pkey PRIMARY KEY (cartodb_
 CREATE INDEX test_table_the_geom_idx ON test_table USING gist (the_geom);
 CREATE INDEX test_table_the_geom_webmercator_idx ON test_table USING gist (the_geom_webmercator);
 
-GRANT ALL ON TABLE test_table TO :TESTUSER;
-GRANT SELECT ON TABLE test_table TO :PUBLICUSER;
+GRANT ALL ON TABLE test_table TO test_cartodb_user_1;
+GRANT SELECT ON TABLE test_table TO publicuser;
 
 -- second table
 CREATE TABLE test_table_2 (
@@ -110,8 +108,8 @@ ALTER TABLE ONLY test_table_2 ADD CONSTRAINT test_table_2_pkey PRIMARY KEY (cart
 CREATE INDEX test_table_2_the_geom_idx ON test_table_2 USING gist (the_geom);
 CREATE INDEX test_table_2_the_geom_webmercator_idx ON test_table_2 USING gist (the_geom_webmercator);
 
-GRANT ALL ON TABLE test_table_2 TO :TESTUSER;
-GRANT SELECT ON TABLE test_table_2 TO :PUBLICUSER;
+GRANT ALL ON TABLE test_table_2 TO test_cartodb_user_1;
+GRANT SELECT ON TABLE test_table_2 TO publicuser;
 
 -- third table
 CREATE TABLE test_table_3 (
@@ -155,8 +153,8 @@ ALTER TABLE ONLY test_table_3 ADD CONSTRAINT test_table_3_pkey PRIMARY KEY (cart
 CREATE INDEX test_table_3_the_geom_idx ON test_table_3 USING gist (the_geom);
 CREATE INDEX test_table_3_the_geom_webmercator_idx ON test_table_3 USING gist (the_geom_webmercator);
 
-GRANT ALL ON TABLE test_table_3 TO :TESTUSER;
-GRANT SELECT ON TABLE test_table_3 TO :PUBLICUSER;
+GRANT ALL ON TABLE test_table_3 TO test_cartodb_user_1;
+GRANT SELECT ON TABLE test_table_3 TO publicuser;
 
 -- private table
 CREATE TABLE test_table_private_1 (
@@ -174,18 +172,5 @@ CREATE TABLE test_table_private_1 (
     CONSTRAINT enforce_srid_the_geom CHECK ((st_srid(the_geom) = 4326)),
     CONSTRAINT enforce_srid_the_geom_webmercator CHECK ((st_srid(the_geom_webmercator) = 3857))
 );
-INSERT INTO test_table_private_1 SELECT * from test_table;
 
-GRANT ALL ON TABLE test_table_private_1 TO :TESTUSER;
-
-CREATE TABLE IF NOT EXISTS
-  CDB_TableMetadata (
-    tabname regclass not null primary key,
-    updated_at timestamp with time zone not null default now()
-  );
-
-INSERT INTO CDB_TableMetadata (tabname, updated_at) VALUES ('test_table'::regclass, '2009-02-13T23:31:30.123Z');
-INSERT INTO CDB_TableMetadata (tabname, updated_at) VALUES ('test_table_private_1'::regclass, '2009-02-13T23:31:30.123Z');
-
--- GRANT SELECT ON CDB_TableMetadata TO :PUBLICUSER;
-GRANT SELECT ON CDB_TableMetadata TO :TESTUSER;
+GRANT ALL ON TABLE test_table_private_1 TO test_cartodb_user_1;

test/support/test_helper.js

@@ -6,19 +6,17 @@
  */
 
 var _ = require('underscore');
-var assert = require('assert');
-var LZMA  = require('lzma').LZMA;
-
-var lzmaWorker = new LZMA();
+var LZMA  = require('lzma/lzma_worker.js').LZMA;
 
 // set environment specific variables
+global.settings     = require(__dirname + '/../../config/settings');
 global.environment  = require(__dirname + '/../../config/environments/test');
-process.env.NODE_ENV = 'test';
+_.extend(global.settings, global.environment);
 
 
 // Utility function to compress & encode LZMA
 function lzma_compress_to_base64(payload, mode, callback) {
-  lzmaWorker.compress(payload, mode,
+  LZMA.compress(payload, mode, 
     function(ints) {
       ints = ints.map(function(c) { return String.fromCharCode(c + 128) }).join('')
       var base64 = new Buffer(ints, 'binary').toString('base64');
@@ -30,36 +28,7 @@ function lzma_compress_to_base64(payload, mode, callback) {
   );
 }
 
-// Check that the response headers do not request caching
-// Throws on failure
-function checkNoCache(res) {
-  assert.ok(!res.headers.hasOwnProperty('x-cache-channel'));
-  assert.ok(!res.headers.hasOwnProperty('cache-control')); // is this correct ?
-  assert.ok(!res.headers.hasOwnProperty('last-modified')); // is this correct ?
-}
-
-
-/**
- * Check that the response headers do not request caching
- * @see checkNoCache
- * @param res
- */
-function checkCache(res) {
-    assert.ok(res.headers.hasOwnProperty('x-cache-channel'));
-    assert.ok(res.headers.hasOwnProperty('cache-control'));
-    assert.ok(res.headers.hasOwnProperty('last-modified'));
-}
-
-function checkSurrogateKey(res, expectedKey) {
-    assert.ok(res.headers.hasOwnProperty('surrogate-key'));
-    assert.equal(res.headers['surrogate-key'], expectedKey);
-}
-
-
 module.exports = {
-  lzma_compress_to_base64: lzma_compress_to_base64,
-  checkNoCache: checkNoCache,
-  checkSurrogateKey: checkSurrogateKey,
-  checkCache: checkCache
-};
+  lzma_compress_to_base64: lzma_compress_to_base64
+}
 

test/unit/cartodb/cache/model/named_maps_entry.test.js

@@ -1,29 +0,0 @@
-var assert = require('assert');
-var _ = require('underscore');
-var NamedMapsCacheEntry = require('../../../../../lib/cartodb/cache/model/named_maps_entry');
-
-suite('cache named_maps_entry', function() {
-
-    var namedMapOwner = 'foo',
-        namedMapName = 'wadus_name',
-        namedMapsCacheEntry = new NamedMapsCacheEntry(namedMapOwner, namedMapName),
-        entryKey = namedMapsCacheEntry.key();
-
-    test('key is a string', function() {
-        assert.ok(_.isString(entryKey));
-    });
-
-    test('key is 8 chars length', function() {
-        assert.equal(entryKey.length, 8);
-        var entryKeyParts = entryKey.split(':');
-        assert.equal(entryKeyParts.length, 2);
-        assert.equal(entryKeyParts[0], 'n');
-    });
-
-    test('key is name spaced for named maps', function() {
-        var entryKeyParts = entryKey.split(':');
-        assert.equal(entryKeyParts.length, 2);
-        assert.equal(entryKeyParts[0], 'n');
-    });
-
-});

test/unit/cartodb/cdb_request.test.js

@@ -1,60 +0,0 @@
-require('../../support/test_helper');
-var assert = require('assert');
-
-var CdbRequest = require('../../../lib/cartodb/models/cdb_request');
-
-describe('req2params', function() {
-
-    function createRequest(host, userParam) {
-        var req = {
-            params: {},
-            headers: {
-                host: host
-            }
-        };
-
-        if (userParam) {
-            req.params.user = userParam;
-        }
-
-        return req;
-    }
-
-    it('extracts name from host header', function() {
-        var cdbRequest = new CdbRequest();
-        var user = cdbRequest.userByReq(createRequest('localhost'));
-
-        assert.equal(user, 'localhost');
-    });
-
-    it('extracts name from subdomain host header in case of no config', function() {
-        var userFromHostConfig = global.environment.user_from_host;
-        global.environment.user_from_host = null;
-
-        var cdbRequest = new CdbRequest();
-        var user = cdbRequest.userByReq(createRequest('development.localhost.lan'));
-
-        global.environment.user_from_host = userFromHostConfig;
-
-        assert.equal(user, 'development');
-    });
-
-    it('considers user param before headers', function() {
-        var cdbRequest = new CdbRequest();
-        var user = cdbRequest.userByReq(createRequest('localhost', 'development'));
-
-        assert.equal(user, 'development');
-    });
-
-    it('returns undefined when it cannot extract username', function() {
-        var userFromHostConfig = global.environment.user_from_host;
-        global.environment.user_from_host = null;
-
-        var cdbRequest = new CdbRequest();
-        var user = cdbRequest.userByReq(createRequest('localhost'));
-
-        global.environment.user_from_host = userFromHostConfig;
-
-        assert.equal(user, undefined);
-    });
-});

test/unit/cartodb/redis_pool.test.js

@@ -0,0 +1,63 @@
+var assert = require('../../support/assert')
+  , _ = require('underscore')
+  , RedisPool = require('../../../lib/cartodb/redis_pool')
+  , tests = module.exports = {};
+
+suite('redis_pool', function() {
+
+    // configure redis pool instance to use in tests
+    var test_opts = require('../../support/config').redis_pool;
+    
+    var redis_pool = new RedisPool(test_opts);
+
+    test('RedisPool object exists', function(done){
+      assert.ok(RedisPool);
+      done();
+    });
+    
+    test('RedisPool can create new redis_pool objects with default settings', function(done){
+      var redis_pool = new RedisPool();
+      done();
+    });
+    
+    test('RedisPool can create new redis_pool objects with specific settings', function(done){
+      var redis_pool = new RedisPool(_.extend({host:'127.0.0.1', port: '6379'}, test_opts));
+      done();
+    });
+    
+    
+    test('pool object has an acquire function', function(done){
+      var found=false;
+      var functions = _.functions(redis_pool);
+      for (var i=0; i<functions.length; ++i) {
+          if ( functions[i] == 'acquire' ) { found=true; break; }
+      }
+      assert.ok(found);
+      done();
+    });
+    
+    test('calling aquire returns a redis client object that can get/set', function(done){
+      redis_pool.acquire(0, function(err, client){
+        if ( err ) { done(err); return; }
+        client.set("key","value");
+        client.get("key", function(err,data){      
+          assert.equal(data, "value");      
+          redis_pool.release(0, client); // needed to exit tests
+          done();
+        })
+      });    
+    });
+    
+    test('calling aquire on another DB returns a redis client object that can get/set', function(done){
+      redis_pool.acquire(2, function(err, client){
+        if ( err ) { done(err); return; }
+        client.set("key","value");
+        client.get("key", function(err,data){      
+          assert.equal(data, "value");      
+          redis_pool.release(2, client); // needed to exit tests
+          done();
+        })
+      });      
+    });
+
+});

test/unit/cartodb/req2params.test.js

@@ -1,16 +1,13 @@
-var assert = require('assert');
-var _ = require('underscore');
-var test_helper = require('../../support/test_helper');
+var assert = require('assert')
+  , _ = require('underscore')
+  , redis = require('redis')
+  , test_helper = require('../../support/test_helper')
+  , tests = module.exports = {};
 
 suite('req2params', function() {
 
     // configure redis pool instance to use in tests
-    var opts = require('../../../lib/cartodb/server_options')();
-
-    var test_user = _.template(global.environment.postgres_auth_user, {user_id:1});
-    var test_pubuser = global.environment.postgres.user;
-    var test_database = test_user + '_db';
-
+    var opts = require('../../../lib/cartodb/server_options');
     
     test('can be found in server_options', function(){
       assert.ok(_.isFunction(opts.req2params));
@@ -18,79 +15,71 @@ suite('req2params', function() {
 
     test('cleans up request', function(done){
       opts.req2params({headers: { host:'localhost' }, query: {dbuser:'hacker',dbname:'secret'}}, function(err, req) {
-          if ( err ) { done(err); return; }
+          if ( err ) { console.log(err); throw new Error(err); }
           assert.ok(_.isObject(req.query), 'request has query');
           assert.ok(!req.query.hasOwnProperty('dbuser'), 'dbuser was removed from query');
           assert.ok(req.hasOwnProperty('params'), 'request has params');
-          assert.ok(!req.params.hasOwnProperty('interactivity'), 'request params do not have interactivity');
-          assert.equal(req.params.dbname, test_database, 'could forge dbname: '+ req.params.dbname);
-          assert.ok(req.params.dbuser === test_pubuser, 'could inject dbuser ('+req.params.dbuser+')');
+          assert.ok(req.params.hasOwnProperty('interactivity'), 'request params have interactivity');
+          assert.equal(req.params.dbname, 'cartodb_test_user_1_db', 'could forge dbname: '+ req.params.dbname);
+          assert.ok(!req.params.hasOwnProperty('dbuser'), 'could inject dbuser ('+req.params.dbuser+')');
           done();
       });
     });
 
     test('sets dbname from redis metadata', function(done){
       opts.req2params({headers: { host:'localhost' }, query: {} }, function(err, req) {
-          if ( err ) { done(err); return; }
+          if ( err ) { console.log(err); throw new Error(err); }
           //console.dir(req);
           assert.ok(_.isObject(req.query), 'request has query');
           assert.ok(!req.query.hasOwnProperty('dbuser'), 'dbuser was removed from query');
           assert.ok(req.hasOwnProperty('params'), 'request has params');
-          assert.ok(!req.params.hasOwnProperty('interactivity'), 'request params do not have interactivity');
-          assert.equal(req.params.dbname, test_database);
-          assert.ok(req.params.dbuser === test_pubuser, 'could inject dbuser ('+req.params.dbuser+')');
+          assert.ok(req.params.hasOwnProperty('interactivity'), 'request params have interactivity');
+          // database_name for user "localhost" (see test/support/prepare_db.sh)
+          assert.equal(req.params.dbname, 'cartodb_test_user_1_db');
+          // unauthenticated request gets no dbuser
+          assert.ok(!req.params.hasOwnProperty('dbuser'), 'could inject dbuser ('+req.params.dbuser+')');
           done();
       });
     });
 
     test('sets also dbuser for authenticated requests', function(done){
       opts.req2params({headers: { host:'localhost' }, query: {map_key: '1234'} }, function(err, req) {
-          if ( err ) { done(err); return; }
+          if ( err ) { console.log(err); throw new Error(err); }
           //console.dir(req);
           assert.ok(_.isObject(req.query), 'request has query');
           assert.ok(!req.query.hasOwnProperty('dbuser'), 'dbuser was removed from query');
           assert.ok(req.hasOwnProperty('params'), 'request has params');
-          assert.ok(!req.params.hasOwnProperty('interactivity'), 'request params do not have interactivity');
-          assert.equal(req.params.dbname, test_database);
-          assert.equal(req.params.dbuser, test_user);
+          assert.ok(req.params.hasOwnProperty('interactivity'), 'request params have interactivity');
+          // database_name for user "localhost" (see test/support/prepare_db.sh)
+          assert.equal(req.params.dbname, 'cartodb_test_user_1_db');
+          // id for user "localhost" (see test/support/prepare_db.sh)
+          assert.equal(req.params.dbuser, 'test_cartodb_user_1');
  
           opts.req2params({headers: { host:'localhost' }, query: {map_key: '1235'} }, function(err, req) {
               // wrong key resets params to no user
-              assert.ok(req.params.dbuser === test_pubuser, 'could inject dbuser ('+req.params.dbuser+')');
+              assert.ok(!req.params.hasOwnProperty('dbuser'), 'could inject dbuser ('+req.params.dbuser+')');
               done();
           });
       });
     });
 
     test('it should extend params with decoded lzma', function(done) {
-        var qo = {
-            config: {
-                version: '1.3.0'
-            }
-        };
-        test_helper.lzma_compress_to_base64(JSON.stringify(qo), 1, function(err, data) {
-            var req = {
-                headers: {
-                    host:'localhost'
-                },
-                query: {
-                    non_included: 'toberemoved',
-                    api_key: 'test',
-                    style: 'override',
-                    lzma: data
-                }
-            };
-            opts.req2params(req, function(err, req) {
-                if ( err ) {
-                    return done(err);
-                }
-                var query = req.params;
-                assert.deepEqual(qo.config, query.config);
-                assert.equal('test', query.api_key);
-                assert.equal(undefined, query.non_included);
-                done();
-            });
+      var qo = {
+        style: 'test',
+        style_version: '2.1.0',
+        cache_buster: 5
+      };
+      test_helper.lzma_compress_to_base64(JSON.stringify(qo), 1, function(err, data) {
+        opts.req2params({ query: { non_included: 'toberemoved', api_key: 'test', style: 'override', lzma: data }}, function(err, req) {
+          var query = req.params
+          assert.equal(qo.style, query.style)
+          assert.equal(qo.style_version, query.style_version)
+          assert.equal(qo.cache_buster, query.cache_buster)
+          assert.equal('test', query.api_key)
+          assert.equal(undefined, query.non_included)
+          done();
         });
+      });
     });
-
+    
 });

test/unit/cartodb/template_maps.test.js

@@ -1,525 +0,0 @@
-require('../../support/test_helper');
-
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../../lib/cartodb/template_maps.js');
-var step = require('step');
-var _ = require('underscore');
-
-describe('template_maps', function() {
-
-  // configure redis pool instance to use in tests
-  var redis_pool = new RedisPool(global.environment.redis);
-
-    var wadusLayer = {
-        options: {
-            sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-            cartocss: '#layer { marker-fill:blue; }',
-            cartocss_version: '2.3.0'
-        }
-    };
-
-  it('does not accept template with unsupported version', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var tpl = { version:'6.6.6',
-      name:'k', auth: {}, layergroup: {layers:[wadusLayer]} };
-    step(
-      function() {
-        tmap.addTemplate('me', tpl, this);
-      },
-      function checkFailed(err) {
-        assert.ok(err);
-        assert.ok(err.message.match(/unsupported.*version/i), err);
-        return null;
-      },
-      function finish(err) {
-        done(err);
-      }
-    );
-  });
-
-  it('does not accept template with missing name', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var tpl = { version:'0.0.1',
-      auth: {}, layergroup: {layers:[wadusLayer]} };
-    step(
-      function() {
-        tmap.addTemplate('me', tpl, this);
-      },
-      function checkFailed(err) {
-        assert.ok(err);
-        assert.ok(err.message.match(/missing.*name/i), err);
-        return null;
-      },
-      function finish(err) {
-        done(err);
-      }
-    );
-  });
-
-    describe('naming', function() {
-
-        function createTemplate(name) {
-            return {
-                version:'0.0.1',
-                name: name,
-                auth: {},
-                layergroup: {
-                    layers: [
-                        wadusLayer
-                    ]
-                }
-            };
-        }
-        var templateMaps = new TemplateMaps(redis_pool);
-
-        var invalidNames = [ "ab|", "a b", "a@b", "-1ab", "_x", "", " x", "x " ];
-        invalidNames.forEach(function(invalidName) {
-            it('should NOT accept template with invalid name: ' + invalidName, function(done) {
-                templateMaps.addTemplate('me', createTemplate(invalidName), function(err) {
-                    assert.ok(err, "Unexpected success with invalid name '" + invalidName + "'");
-                    assert.ok(
-                        err.message.match(/template.*name/i),
-                        "Unexpected error message with invalid name '" + invalidName + "': " + err.message
-                    );
-                    done();
-                });
-            });
-        });
-
-        var validNames = [
-            "AB", "1ab", "DFD19A1A-0AC6-11E5-B0CA-6476BA93D4F6", "25ad8300-0ac7-11e5-b93f-6476ba93d4f6"
-        ];
-        validNames.forEach(function(validName) {
-            it('should accept template with valid name: ' + validName, function(done) {
-                templateMaps.addTemplate('me', createTemplate(validName), function(err) {
-                    assert.ok(!err, "Unexpected error with valid name '" + validName + "': " + err);
-                    done();
-                });
-            });
-        });
-
-
-    });
-
-  it('does not accept template with invalid placeholder name', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var tpl = { version:'0.0.1',
-      name: "valid", placeholders: {},
-      auth: {}, layergroup: {layers:[wadusLayer]} };
-    var invalidnames = [ "ab|", "a b", "a@b", "1ab", "_x", "", " x", "x " ];
-    var testNext = function() {
-      if ( ! invalidnames.length ) { done(); return; }
-      var n = invalidnames.pop();
-      tpl.placeholders = {};
-      tpl.placeholders[n] = { type:'number', default:1 };
-      tmap.addTemplate('me', tpl, function(err) {
-        if ( ! err ) {
-          done(new Error("Unexpected success with invalid name '" + n + "'"));
-        }
-        else if ( ! err.message.match(/invalid.*name/i) ) {
-          done(new Error("Unexpected error message with invalid name '" + n + "': " + err));
-        }
-        else {
-          testNext();
-        }
-      });
-    };
-    testNext();
-  });
-
-  it('does not accept template with missing placeholder default', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var tpl = { version:'0.0.1',
-      name: "valid", placeholders: { v: {} },
-      auth: {}, layergroup: {layers:[wadusLayer]} };
-    tmap.addTemplate('me', tpl, function(err) {
-        if ( ! err ) {
-          done(new Error("Unexpected success with missing placeholder default"));
-        }
-        else if ( ! err.message.match(/missing default/i) ) {
-          done(new Error("Unexpected error message with missing placeholder default: " + err));
-        }
-        else {
-          done();
-        }
-      });
-  });
-
-  it('does not accept template with missing placeholder type', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var tpl = { version:'0.0.1',
-      name: "valid", placeholders: { v: { default:1 } },
-      auth: {}, layergroup: {layers:[wadusLayer]} };
-    tmap.addTemplate('me', tpl, function(err) {
-        if ( ! err ) {
-          done(new Error("Unexpected success with missing placeholder type"));
-        }
-        else if ( ! err.message.match(/missing type/i) ) {
-          done(new Error("Unexpected error message with missing placeholder default: " + err));
-        }
-        else {
-          done();
-        }
-      });
-  });
-
-  // See http://github.com/CartoDB/Windshaft-cartodb/issues/128
-  it('does not accept template with invalid token auth (undefined tokens)',
-  function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var tpl = { version:'0.0.1',
-      name: "invalid_auth1", placeholders: { },
-      auth: { method: 'token' }, layergroup: {layers:[wadusLayer]} };
-    tmap.addTemplate('me', tpl, function(err) {
-        if ( ! err ) {
-          done(new Error("Unexpected success with invalid token auth (undefined tokens)"));
-        }
-        else if ( ! err.message.match(/invalid 'token' authentication/i) ) {
-          done(new Error("Unexpected error message with invalid token auth (undefined tokens): " + err));
-        }
-        else {
-          done();
-        }
-      });
-  });
-
-  it('add, get and delete a valid template', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var expected_failure = false;
-    var tpl_id;
-    var tpl = { version:'0.0.1',
-      name: 'first', auth: {}, layergroup: {layers:[wadusLayer]} };
-    step(
-      function() {
-        tmap.addTemplate('me', tpl, this);
-      },
-      function addOmonimousTemplate(err, id) {
-        if ( err ) throw err;
-        tpl_id = id;
-        assert.equal(tpl_id, 'first');
-        expected_failure = true;
-        // should fail, as it already exists
-        tmap.addTemplate('me', tpl, this);
-      },
-      function getTemplate(err) {
-        if ( ! expected_failure && err ) throw err;
-        assert.ok(err);
-        assert.ok(err.message.match(/already exists/i), err);
-        tmap.getTemplate('me', tpl_id, this);
-      },
-      function delTemplate(err, got_tpl) {
-        if ( err ) throw err;
-        assert.deepEqual(got_tpl, _.extend({}, tpl, {auth: {method: 'open'}, placeholders: {}}));
-        tmap.delTemplate('me', tpl_id, this);
-      },
-      function finish(err) {
-        done(err);
-      }
-    );
-  });
-
-  it('add multiple templates, list them', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var tpl1 = { version:'0.0.1', name: 'first', auth: {}, layergroup: {layers:[wadusLayer]} };
-    var tpl1_id;
-    var tpl2 = { version:'0.0.1', name: 'second', auth: {}, layergroup: {layers:[wadusLayer]} };
-    var tpl2_id;
-    step(
-      function addTemplate1() {
-        tmap.addTemplate('me', tpl1, this);
-      },
-      function addTemplate2(err, id) {
-        if ( err ) throw err;
-        tpl1_id = id;
-        tmap.addTemplate('me', tpl2, this);
-      },
-      function listTemplates(err, id) {
-        if ( err ) throw err;
-        tpl2_id = id;
-        tmap.listTemplates('me', this);
-      },
-      function checkTemplates(err, ids) {
-        if ( err ) throw err;
-        assert.equal(ids.length, 2);
-        assert.ok(ids.indexOf(tpl1_id) != -1, ids.join(','));
-        assert.ok(ids.indexOf(tpl2_id) != -1, ids.join(','));
-        return null;
-      },
-      function delTemplate1(err) {
-        if ( tpl1_id ) {
-          var next = this;
-          tmap.delTemplate('me', tpl1_id, function(e) {
-            if ( err || e ) next(new Error(err + '; ' + e));
-            else next();
-          });
-        } else {
-          if ( err ) throw err;
-          return null;
-        }
-      },
-      function delTemplate2(err) {
-        if ( tpl2_id ) {
-          var next = this;
-          tmap.delTemplate('me', tpl2_id, function(e) {
-            if ( err || e ) next(new Error(err + '; ' + e));
-            else next();
-          });
-        } else {
-          if ( err ) throw err;
-          return null;
-        }
-      },
-      function finish(err) {
-        done(err);
-      }
-    );
-  });
-
-  it('update templates', function(done) {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-    var expected_failure = false;
-    var owner = 'me';
-    var tpl = { version:'0.0.1',
-      name: 'first',
-      auth: { method: 'open' },
-      layergroup: {layers:[wadusLayer]}
-    };
-    var tpl_id;
-    step(
-      function addTemplate() {
-        tmap.addTemplate(owner, tpl, this);
-      },
-      // Updating template name should fail
-      function updateTemplateName(err, id) {
-        if ( err ) throw err;
-        tpl_id = id;
-        expected_failure = true;
-        tpl.name = 'second';
-        tmap.updTemplate(owner, tpl_id, tpl, this);
-      },
-      function updateTemplateAuth(err) {
-        if ( err && ! expected_failure) throw err;
-        expected_failure = false;
-        assert.ok(err);
-        tpl.name = 'first';
-        tpl.auth.method = 'token';
-        tpl.auth.valid_tokens = [ 'tok1' ];
-        tmap.updTemplate(owner, tpl_id, tpl, this);
-      },
-      function updateTemplateWithInvalid(err) {
-        if ( err ) throw err;
-        tpl.version = '999.999.999';
-        expected_failure = true;
-        tmap.updTemplate(owner, tpl_id, tpl, this);
-      },
-      function updateUnexistentTemplate(err) {
-        if ( err && ! expected_failure) throw err;
-        assert.ok(err);
-        assert.ok(err.message.match(/unsupported.*version/i), err);
-        tpl.version = '0.0.1';
-        expected_failure = true;
-        tmap.updTemplate(owner, 'unexistent', tpl, this);
-      },
-      function delTemplate(err) {
-        if ( err && ! expected_failure) throw err;
-        expected_failure = false;
-        assert.ok(err);
-        assert.ok(err.message.match(/cannot update name/i), err);
-        tmap.delTemplate(owner, tpl_id, this);
-      },
-      function finish(err) {
-        done(err);
-      }
-    );
-  });
-
-  it('instanciate templates', function() {
-    var tmap = new TemplateMaps(redis_pool);
-    assert.ok(tmap);
-
-    var tpl1 =  {
-        version: '0.0.1',
-        name: 'acceptance1',
-        auth: { method: 'open' },
-        placeholders: {
-          fill: { type: "css_color", default: "red" },
-          color: { type: "css_color", default: "#a0fF9A" },
-          name: { type: "sql_literal", default: "test" },
-          zoom: { type: "number", default: "0" },
-          test_number: { type: "number", default: 23 }
-        },
-        layergroup: {
-          version: '1.0.0',
-          global_cartocss_version: '2.0.2',
-          layers: [
-             { options: {
-                 sql: "select '<%=name %>' || id, g from t",
-                 cartocss: '#layer { marker-fill:<%= fill %>; marker-width: <%=test_number  %>; }'
-               } },
-             { options: {
-                 sql: "select fun('<%=     name%>') g from x",
-                 cartocss: '#layer { line-color:<%= color %>; marker-fill:<%= color %>; }'
-               } },
-             { options: {
-                 sql: "select g from x",
-                 cartocss: '#layer[zoom=<%=zoom%>] { }'
-               } }
-          ]
-        }
-    };
-
-    var inst = tmap.instance(tpl1, {});
-
-    var lyr = inst.layers[0].options;
-    assert.equal(lyr.sql, "select 'test' || id, g from t");
-    assert.equal(lyr.cartocss, '#layer { marker-fill:red; marker-width: 23; }');
-
-    lyr = inst.layers[1].options;
-    assert.equal(lyr.sql, "select fun('test') g from x");
-    assert.equal(lyr.cartocss, '#layer { line-color:#a0fF9A; marker-fill:#a0fF9A; }');
-
-    inst = tmap.instance(tpl1, {color:'yellow', name:"it's dangerous"});
-
-    lyr = inst.layers[0].options;
-    assert.equal(lyr.sql, "select 'it''s dangerous' || id, g from t");
-    assert.equal(lyr.cartocss, '#layer { marker-fill:red; marker-width: 23; }');
-
-    lyr = inst.layers[1].options;
-    assert.equal(lyr.sql, "select fun('it''s dangerous') g from x");
-    assert.equal(lyr.cartocss, '#layer { line-color:yellow; marker-fill:yellow; }');
-
-    // Invalid css_color
-    var err = null;
-    try { tmap.instance(tpl1, {color:'##ff00ff'}); }
-    catch (e) { err = e; }
-    assert.ok(err);
-    assert.ok(err.message.match(/invalid css_color/i), err);
-
-    // Invalid css_color 2 (too few digits)
-    err = null;
-    try { tmap.instance(tpl1, {color:'#ff'}); }
-    catch (e) { err = e; }
-    assert.ok(err);
-    assert.ok(err.message.match(/invalid css_color/i), err);
-
-    // Invalid css_color 3 (too many digits)
-    err = null;
-    try { tmap.instance(tpl1, {color:'#1234567'}); }
-    catch (e) { err = e; }
-    assert.ok(err);
-    assert.ok(err.message.match(/invalid css_color/i), err);
-
-    // Invalid number
-    err = null;
-    try { tmap.instance(tpl1, {zoom:'#'}); }
-    catch (e) { err = e; }
-    assert.ok(err);
-    assert.ok(err.message.match(/invalid number/i), err);
-
-    // Invalid number 2
-    err = null;
-    try { tmap.instance(tpl1, {zoom:'23e'}); }
-    catch (e) { err = e; }
-    assert.ok(err);
-    assert.ok(err.message.match(/invalid number/i), err);
-
-    // Valid number
-    err = null;
-    try { tmap.instance(tpl1, {zoom:'-.23e10'}); }
-    catch (e) { err = e; }
-    assert.ok(!err);
-  });
-
-  // Can set a limit on the number of user templates
-  it('can limit number of user templates', function(done) {
-    var tmap = new TemplateMaps(redis_pool, {
-      max_user_templates: 2
-    });
-    assert.ok(tmap);
-    var tpl = { version:'0.0.1', auth: {}, layergroup: {layers:[wadusLayer]} };
-    var expectErr = false;
-    var idMe = [];
-    var idYou = [];
-    step(
-      function oneForMe() {
-        tpl.name = 'oneForMe';
-        tmap.addTemplate('me', tpl, this);
-      },
-      function twoForMe(err, id) {
-        if ( err ) throw err;
-        assert.ok(id);
-        idMe.push(id);
-        tpl.name = 'twoForMe';
-        tmap.addTemplate('me', tpl, this);
-      },
-      function threeForMe(err, id) {
-        if ( err ) throw err;
-        assert.ok(id);
-        idMe.push(id);
-        tpl.name = 'threeForMe';
-        expectErr = true;
-        tmap.addTemplate('me', tpl, this);
-      },
-      function errForMe(err/*, id*/) {
-        if ( err && ! expectErr ) throw err;
-        expectErr = false;
-        assert.ok(err);
-        assert.ok(err.message.match(/limit.*template/), err);
-        return null;
-      },
-      function delOneMe(err) {
-        if ( err ) throw err;
-        tmap.delTemplate('me', idMe.shift(), this);
-      },
-      function threeForMeRetry(err) {
-        if ( err ) throw err;
-        tpl.name = 'threeForMe';
-        tmap.addTemplate('me', tpl, this);
-      },
-      function oneForYou(err, id) {
-        if ( err ) throw err;
-        assert.ok(id);
-        idMe.push(id);
-        tpl.name = 'oneForYou';
-        tmap.addTemplate('you', tpl, this);
-      },
-      function twoForYou(err, id) {
-        if ( err ) throw err;
-        assert.ok(id);
-        idYou.push(id);
-        tpl.name = 'twoForYou';
-        tmap.addTemplate('you', tpl, this);
-      },
-      function threeForYou(err, id) {
-        if ( err ) throw err;
-        assert.ok(id);
-        idYou.push(id);
-        tpl.name = 'threeForYou';
-        expectErr = true;
-        tmap.addTemplate('you', tpl, this);
-      },
-      function errForYou(err/*, id*/) {
-        if ( err && ! expectErr ) throw err;
-        expectErr = false;
-        assert.ok(err);
-        assert.ok(err.message.match(/limit.*template/), err);
-        return null;
-      },
-      function finish(err) {
-        // TODO: delete all templates
-        done(err);
-      }
-    );
-  });
-
-});

test/unit/cartodb/template_maps_auth.test.js

@@ -1,105 +0,0 @@
-require('../../support/test_helper');
-
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-
-var TemplateMaps = require('../../../lib/cartodb/template_maps');
-
-describe('template_maps_auth', function() {
-
-    // configure redis pool instance to use in tests
-    var redisPool = new RedisPool(global.environment.redis),
-        templateMaps = new TemplateMaps(redisPool, {max_user_templates: 1000});
-
-    function makeTemplate(method, validTokens) {
-        var template = {
-            name: 'wadus_template',
-            auth: {
-                method: method
-            }
-        };
-
-        if (method === 'token') {
-            template.auth.valid_tokens = validTokens || [];
-        }
-
-        return template;
-    }
-
-    var methodToken = 'token',
-        methodOpen = 'open';
-
-    var tokenFoo = 'foo',
-        tokenBar = 'bar';
-
-    var authorizationTestScenarios = [
-        {
-            desc: 'open method is always authorized',
-            template: makeTemplate(methodOpen),
-            token: undefined,
-            expected: true
-        },
-        {
-            desc: 'token method is authorized for valid token',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: tokenFoo,
-            expected: true
-        },
-        {
-            desc: 'token method not authorized for invalid token',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: tokenBar,
-            expected: false
-        },
-        {
-            desc: 'token method is authorized for valid token array',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: [tokenFoo],
-            expected: true
-        },
-        {
-            desc: 'token method not authorized for invalid token array',
-            template: makeTemplate(methodToken, [tokenFoo]),
-            token: [tokenBar],
-            expected: false
-        },
-        {
-            desc: 'wadus method not authorized',
-            template: makeTemplate('wadus', [tokenFoo]),
-            token: tokenFoo,
-            expected: false
-        },
-        {
-            desc: 'undefined template result in not authorized',
-            template: undefined,
-            token: tokenFoo,
-            expected: false
-        },
-        {
-            desc: 'undefined template auth result in not authorized',
-            template: {},
-            token: tokenFoo,
-            expected: false
-        }
-    ];
-
-    authorizationTestScenarios.forEach(function(testScenario) {
-        it(testScenario.desc, function(done) {
-            var debugMessage = testScenario.expected ? 'should be authorized' : 'unexpectedly authorized';
-            var result = templateMaps.isAuthorized(testScenario.template, testScenario.token);
-            assert.equal(result, testScenario.expected, debugMessage);
-            done();
-        });
-    });
-
-    it("auth as 'open' string is authorized", function(done) {
-        var template = {
-            name: 'wadus_template',
-            auth: 'open'
-        };
-
-        assert.ok(templateMaps.isAuthorized(template));
-        done();
-    });
-
-});

test/unit/cartodb/template_maps_defaults.test.js

@@ -1,107 +0,0 @@
-require('../../support/test_helper');
-
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../../lib/cartodb/template_maps.js');
-var _ = require('underscore');
-
-describe('template_maps', function() {
-
-    var redisPool = new RedisPool(global.environment.redis),
-        templateMaps = new TemplateMaps(redisPool);
-
-    var owner = 'me';
-    var templateName = 'wadus';
-
-
-    var defaultTemplate = {
-        version:'0.0.1',
-        name: templateName,
-        layergroup: {
-            layers: [
-                {
-                    options: {
-                        sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-                        cartocss: '#layer { marker-fill:blue; }',
-                        cartocss_version: '2.3.0'
-                    }
-                }
-            ]
-        }
-    };
-
-    function makeTemplate(auth, placeholders) {
-        return _.extend({}, defaultTemplate, {
-            auth: auth,
-            placeholders: placeholders
-        });
-    }
-
-    var defaultAuth = {
-        method: 'open'
-    };
-
-    var authTokenSample = {
-        method: 'token',
-        valid_tokens: ['wadus_token']
-    };
-
-    var placeholdersSample = {
-        wadus: {
-            type: 'number',
-            default: 1
-        }
-    };
-
-    var testScenarios = [
-        {
-            desc: 'default auth and placeholders values',
-            template: defaultTemplate,
-            expected: {
-                auth: defaultAuth,
-                placeholders: {}
-            }
-        },
-        {
-            desc: 'default placeholders but specified auth',
-            template: makeTemplate(authTokenSample),
-            expected: {
-                auth: authTokenSample,
-                placeholders: {}
-            }
-        },
-        {
-            desc: 'default auth but specified placeholders',
-            template: makeTemplate(undefined, placeholdersSample),
-            expected: {
-                auth: defaultAuth,
-                placeholders: placeholdersSample
-            }
-        },
-        {
-            desc: 'specified auth and placeholders',
-            template: makeTemplate(authTokenSample, placeholdersSample),
-            expected: {
-                auth: authTokenSample,
-                placeholders: placeholdersSample
-            }
-        }
-    ];
-
-    testScenarios.forEach(function(testScenario) {
-        it('adding template returns a new instance with ' + testScenario.desc, function(done) {
-
-            templateMaps.addTemplate(owner, testScenario.template, function(err, templateId, template) {
-                assert.ok(!err, 'Unexpected error adding template: ' + (err && err.message));
-                assert.ok(testScenario.template !== template, 'template instances should be different');
-                assert.equal(template.name, templateName);
-                assert.deepEqual(template.auth, testScenario.expected.auth);
-                assert.deepEqual(template.placeholders, testScenario.expected.placeholders);
-
-                templateMaps.delTemplate(owner, templateName, done);
-            });
-
-        });
-    });
-
-});

test/unit/cartodb/valid_template_maps.test.js

@@ -1,113 +0,0 @@
-require('../../support/test_helper');
-
-var assert = require('assert');
-var RedisPool = require('redis-mpool');
-var TemplateMaps = require('../../../lib/cartodb/template_maps.js');
-var _ = require('underscore');
-
-describe('template_maps', function() {
-
-    var redisPool = new RedisPool(global.environment.redis),
-        templateMaps = new TemplateMaps(redisPool);
-
-    var owner = 'me';
-    var templateName = 'wadus';
-
-
-    var defaultTemplate = {
-        version:'0.0.1',
-        name: templateName
-    };
-
-    function makeTemplate(layers) {
-        var layergroup = {
-            layers: layers
-        };
-        return _.extend({}, defaultTemplate, {
-            layergroup: layergroup
-        });
-    }
-
-    var layerWithMissingOptions = {},
-        minimumValidLayer = {
-            options: {
-                sql: 'select 1 cartodb_id, null::geometry the_geom_webmercator',
-                cartocss: '#layer { marker-fill:blue; }',
-                cartocss_version: '2.3.0'
-            }
-        };
-
-    var testScenarios = [
-        {
-            desc: 'Missing layers array does not validate',
-            template: makeTemplate(),
-            expected: {
-                isValid: false,
-                message: 'Missing or empty layers array from layergroup config'
-            }
-        },
-        {
-            desc: 'Empty layers array does not validate',
-            template: makeTemplate([]),
-            expected: {
-                isValid: false,
-                message: 'Missing or empty layers array from layergroup config'
-            }
-        },
-        {
-            desc: 'Layer with missing options does not validate',
-            template: makeTemplate([
-                layerWithMissingOptions
-            ]),
-            expected: {
-                isValid: false,
-                message: 'Missing `options` in layergroup config for layers: 0'
-            }
-        },
-        {
-            desc: 'Multiple layers report invalid layer',
-            template: makeTemplate([
-                minimumValidLayer,
-                layerWithMissingOptions
-            ]),
-            expected: {
-                isValid: false,
-                message: 'Missing `options` in layergroup config for layers: 1'
-            }
-        },
-        {
-            desc: 'default auth but specified placeholders',
-            template: makeTemplate([
-                minimumValidLayer
-            ]),
-            expected: {
-                isValid: true,
-                message: ''
-            }
-        }
-    ];
-
-    testScenarios.forEach(function(testScenario) {
-        it(testScenario.desc, function(done) {
-
-            templateMaps.addTemplate(owner, testScenario.template, function(err) {
-
-                if (testScenario.expected.isValid) {
-
-                    assert.ok(!err);
-                    templateMaps.delTemplate(owner, templateName, done);
-
-                } else {
-
-                    assert.ok(err);
-                    assert.equal(err.message, testScenario.expected.message);
-                    done();
-
-                }
-
-            });
-
-        });
-    });
-
-});

tools/create_template

@@ -1,49 +0,0 @@
-#!/bin/sh
-
-verbose=no
-tiler_url=http://dev.localhost.lan:8181/tiles/template
-apikey=${CDB_APIKEY}
-
-while test -n "$1"; do
-  if test "$1" = "-v"; then
-    verbose=yes
-  elif test "$1" = "-k"; then
-    shift
-    apikey="$1"
-  elif test "$1" = "-u"; then
-    shift
-    tiler_url="$1"
-  elif test -z "$cfg"; then
-    cfg="$1"
-  else
-    echo "Unused parameter $1" >&2
-  fi
-  shift
-done
-
-if test -z "$cfg"; then
-  echo "Usage: $0 [-v] [-k <api_key>] [-u <tiler_url>] <template_config>" >&2
-  echo "Default <tiler_url> is ${tiler_url}" >&2
-  echo "Default <api_key> is read from CDB_APIKEY env variable" >&2
-  exit 1
-fi
-
-cmd="curl -skH Content-Type:application/json --data-binary @- ${tiler_url}?api_key=${apikey}"
-if test x${verbose} = xyes; then
-  cmd="${cmd} -v"
-fi
-res=`cat ${cfg} | tr '\n' ' ' | ${cmd}`
-if test $? -gt 0; then
-  echo "curl command failed: ${cmd}"
-fi
-
-if test x${verbose} = xyes; then
-  echo "${res}"
-fi
-
-# Successful response contains no space
-echo "$res" | grep " " && { echo $res && exit 1; }
-
-tok=`echo "$res" | sed 's/.*"template_id":"\([^"]*\)".*/\1/'`
-echo $tok
-

tools/delete_template

@@ -1,45 +0,0 @@
-#!/bin/sh
-
-verbose=no
-tiler_url=http://dev.localhost.lan:8181/tiles/template
-apikey=${CDB_APIKEY}
-
-while test -n "$1"; do
-  if test "$1" = "-v"; then
-    verbose=yes
-  elif test "$1" = "-k"; then
-    shift
-    apikey="$1"
-  elif test "$1" = "-u"; then
-    shift
-    tiler_url="$1"
-  elif test -z "$tpl"; then
-    tpl="$1"
-  else
-    echo "Unused parameter $1" >&2
-  fi
-  shift
-done
-
-if test -z "$tpl"; then
-  echo "Usage: $0 [-v] [-k <api_key>] [-u <tiler_url>] <template_id>" >&2
-  echo "Default <tiler_url> is ${tiler_url}" >&2
-  echo "Default <api_key> is read from CDB_APIKEY env variable" >&2
-  exit 1
-fi
-
-cmd="curl -X DELETE -skH Content-Type:application/json ${tiler_url}/${tpl}?api_key=${apikey}"
-if test x${verbose} = xyes; then
-  cmd="${cmd} -v"
-fi
-res=`${cmd}`
-if test $? -gt 0; then
-  echo "curl command failed: ${cmd}"
-fi
-
-if test x${verbose} = xyes; then
-  echo "${res}"
-fi
-
-tok=`echo "$res" | sed 's/.*"template_id":"\([^"]*\)".*/\1/'`
-echo $tok

tools/examples/mapconfig_simple.js

@@ -1,11 +0,0 @@
-{"version":"1.0.1",
-	"layers":[{
-    "type":"cartodb",
-	  "options":{
-      "sql":"select 1 as id, ST_SetSRID(ST_MakePoint(0,0),3857) as the_geom_webmercator",
-	    "cartocss":"#style{ marker-width: 12;}",
-	    "cartocss_version":"2.1.1",
-      "Interactivity":"id"
-    }
-  }]
-}

tools/examples/mapconfig_slow.js

@@ -1,11 +0,0 @@
-{"version":"1.0.1",
-	"layers":[{
-    "type":"cartodb",
-	  "options":{
-      "sql":"select 1 as id, ST_Transform(ST_SetSRID(ST_MakePoint(x/1000,x/2000),4326),3857) as the_geom_webmercator FROM generate_series(-170000,170000) x",
-	    "cartocss":"#style{ marker-width: 12;}",
-	    "cartocss_version":"2.1.1",
-      "Interactivity":"id"
-    }
-  }]
-}

tools/examples/mapconfig_torque.js

@@ -1,10 +0,0 @@
-{"version":"1.0.1",
-	"layers":[{
-    "type":"torque",
-	  "options":{
-      "sql":"select 1 as id, ST_SetSRID(ST_MakePoint(0,0),3857) as the_geom_webmercator",
-	    "cartocss":"Map{ -torque-time-attribute:'id'; -torque-aggregation-function:'count(id)'; -torque-frame-count:2; -torque-resolution:2}",
-      "cartocss_version": "2.1.1"
-    }
-  }]
-}

tools/examples/template_simple.js

@@ -1,17 +0,0 @@
-{
- "version":"0.0.1",
- "name":"simple",
- "placeholders":{},
- "auth":{ "method":"open" },
- "layergroup":{
-   "version":"1.0.1",
-    "layers":[{
-      "type":"cartodb",
-      "options":{
-        "sql":"select ST_SetSRID(ST_MakePoint(0,0),3857) as the_geom_webmercator",
-        "cartocss":"#s{ marker-width: 12;}",
-        "cartocss_version":"2.1.1"
-      }
-    }]
-  }
-}

tools/instanciate_template

@@ -1,53 +0,0 @@
-#!/bin/sh
-
-verbose=no
-tiler_url=http://dev.localhost.lan:8181/tiles/template
-apikey=${CDB_APIKEY}
-
-while test -n "$1"; do
-  if test "$1" = "-v"; then
-    verbose=yes
-  elif test "$1" = "-k"; then
-    shift
-    apikey="$1"
-  elif test "$1" = "-u"; then
-    shift
-    tiler_url="$1"
-  elif test -z "$tpl"; then
-    tpl="$1"
-  elif test -z "$cfg"; then
-    cfg="$1"
-  else
-    echo "Unused parameter $1" >&2
-  fi
-  shift
-done
-
-if test -z "$tpl"; then
-  echo "Usage: $0 [-v] [-k <api_key>] [-u <tiler_url>] <template_id> [<template_params>]" >&2
-  echo "Default <tiler_url> is ${tiler_url}" >&2
-  echo "Default <api_key> is read from CDB_APIKEY env variable" >&2
-  exit 1
-fi
-
-if test -z "$cfg"; then
-  cfg="/dev/null"
-fi
-
-tiler_url="${tiler_url}/${tpl}"
-
-cmd="curl -X POST -skH Content-Type:application/json --data-binary @- ${tiler_url}?api_key=${apikey}"
-if test x${verbose} = xyes; then
-  cmd="${cmd} -v"
-fi
-res=`cat ${cfg} | tr '\n' ' ' | ${cmd}`
-if test $? -gt 0; then
-  echo "curl command failed: ${cmd}"
-fi
-
-if test x${verbose} = xyes; then
-  echo "${res}"
-fi
-
-tok=`echo "$res" | sed 's/.*"layergroupid":"\([^"]*\)".*/\1/'`
-echo $tok

tools/list_templates

@@ -1,45 +0,0 @@
-#!/bin/sh
-
-verbose=no
-tiler_url=http://dev.localhost.lan:8181/tiles/template
-apikey=${CDB_APIKEY}
-
-while test -n "$1"; do
-  if test "$1" = "-v"; then
-    verbose=yes
-  elif test "$1" = "-k"; then
-    shift
-    apikey="$1"
-  elif test "$1" = "-u"; then
-    shift
-    tiler_url="$1"
-  elif test "$1" = "-h" -o "$1" = "-?"; then
-    echo "Usage: $0 [-v] [-k <api_key>] [-u <tiler_url>]" >&2
-    echo "Default <tiler_url> is ${tiler_url}" >&2
-    echo "Default <api_key> is read from CDB_APIKEY env variable" >&2
-    exit 0
-  else
-    echo "Unused parameter $1" >&2
-  fi
-  shift
-done
-
-
-cmd="curl -X GET -sk ${tiler_url}?api_key=${apikey}"
-if test x${verbose} = xyes; then
-  cmd="${cmd} -v"
-fi
-res=`${cmd}`
-if test $? -gt 0; then
-  echo "curl command failed: ${cmd}"
-fi
-
-if test x${verbose} = xyes; then
-  echo "${res}"
-fi
-
-node <<EOF
-var parsed = JSON.parse('$res');
-console.dir(parsed);
-EOF
-

tools/munin/windshaft

@@ -68,7 +68,7 @@ for pid in ${pids}; do
   log=$(grep "${pid}" "${tmpreport}" | grep -w 1w | awk '{print $9}')
   if test -e "${log}"; then
     kill -USR2 "${pid}"
-    cnt=$(tac ${log} | sed -n -e '/ItemKey/p;/ RenderCache /q' | wc -l)
+    cnt=$(tac ${log} | sed -n -e '/ItemKey/p;/^RenderCache/q' | wc -l)
     if test $cnt -gt $maxcache; then maxcache=$cnt; fi
   else
     # report the error...

tools/performance/stresstest_templates.sh

@@ -1,54 +0,0 @@
-#!/bin/sh
-
-verbose=no
-tiler_url=http://dev.localhost.lan:8181/tiles/template
-apikey=${CDB_APIKEY}
-
-while test -n "$1"; do
-  if test "$1" = "-k"; then
-    shift
-    apikey="$1"
-  elif test "$1" = "-u"; then
-    shift
-    tiler_url="$1"
-  elif test -z "$tpl"; then
-    tpl="$1"
-  else
-    echo "Unused parameter $1" >&2
-  fi
-  shift
-done
-
-if test -z "$tpl"; then
-  echo "Usage: $0 [-v] [-k <api_key>] [-u <tiler_url>] <template_config>" >&2
-  echo "Default <tiler_url> is ${tiler_url}" >&2
-  echo "Default <api_key> is read from CDB_APIKEY env variable" >&2
-  exit 1
-fi
-
-basedir=$(cd $(dirname $0); cd ..; pwd)
-export CDB_APIKEY=${apikey}
-max=3000000
-i=0
-while test "$i" -le "$max"; do
-  tpln=`cat ${tpl} | sed "s/\"name\":\"\(.*\)\"/\"name\":\"\1${i}\"/"`
-  tpl_id=`echo ${tpln} | ${basedir}/create_template -u ${tiler_url} /dev/stdin`
-  if test $? -ne 0; then
-    echo $tpl_id >&2
-    break
-  fi
-  tpl_id=`echo ${tpln} | ${basedir}/update_template -u ${tiler_url} ${tpl_id} /dev/stdin`
-  if test $? -ne 0; then
-    echo $tpl_id >&2
-    break
-  fi
-  out=`${basedir}/delete_template -u ${tiler_url} ${tpl_id}`
-  if test $? -ne 0; then
-    echo $out >&2
-    break
-  fi
-  i=$((i+1))
-  if test `expr $i % 100` -eq 0; then
-    echo -n "."
-  fi
-done

tools/show_style

@@ -1,148 +1,29 @@
-#!/usr/bin/env node
+#!/bin/sh
 
-var path = require('path');
-var redis = require('redis');
-var Step = require('step');
+# TODO: port to node, if you really need it
+
+REDIS_PORT=6379 # default port
 
 
-function usage(me, exitcode) {
-  console.log("Usage: " + me + " [--env <environment>] <username> [<tablename>|~<token>]");
-  process.exit(exitcode);
-}
+if test -z "$1"; then
+  echo "Usage: $0 <username> [<tablename>|~<token>]" >&2
+  exit 1
+fi
 
-var node_path = process.argv.shift(); 
-var script_path = process.argv.shift(); 
-var basedir = path.dirname(script_path);
-var me = path.basename(script_path);
-
-var ENV = 'development.js';
-var username, token;
-var arg;
-while ( arg = process.argv.shift() ) {
-  if ( arg == '--env' ) {
-    ENV = process.argv.shift();
-  }
-  else if ( ! username ) {
-    username = arg;
-  }
-  else if ( ! token ) {
-    token = arg;
-  }
-  else {
-    console.warn("Unused parameter " + arg);
-  }
-}
-
-if ( ! username ) usage(me, 1);
-
-console.log("Using environment " + ENV);
-
-global.environment = require('../config/environments/' + ENV);
-// _after_ setting global.environment
-var serverOptions = require('../lib/cartodb/server_options')();
-
-var client;
-var dbname;
-Step(
-  function getClient() {
-    client = redis.createClient(serverOptions.redis.port, serverOptions.redis.host);
-    client.on('connect', this);
-  },
-  function getUserMeta(err) {
-    if ( err ) throw err;
-    client.select(5);
-    client.hgetall('rails:users:' + username, this);
-  },
-  function readDB(err, data) {
-    if ( err ) throw err;
-    if ( ! data )
-      throw new Error('Username ' + username + ' unknown by redis on port '
-        + serverOptions.redis.port + ' (try CARTODB/script/restore_redis?)');
-    //console.log("Data:"); console.dir(data);
-    dbname = data['database_name'];
-    console.log("Database name for user " + username + ": " + dbname);
-    client.select(0);
-    return null;
-  },
-  function showTokens(err) {
-    if ( err ) throw err;
-    if ( token ) return null;
-    var next = this;
-    Step(
-      function getTokens() {
-        client.keys('map_style|' + dbname + '|*', this);
-      },
-      function showTokens(err, data) {
-        if (err) throw err;
-        if ( data ) console.log(data.join('\n'));
-        return null;
-      },
-      function showTokensFinish(err) {
-        next(err);
-      }
-    );
-  },
-  function showStyle(err) {
-    if ( err ) throw err;
-    if ( ! token ) return null;
-    var next = this;
-    Step(
-      function getStyle() {
-        client.get('map_style|' + dbname + '|' + token, this);
-      },
-      function showStyle(err, data) {
-        if ( err ) throw err;
-        if ( ! data ) {
-          throw new Error(token + ': no such map style known by redis on port '
-            + serverOptions.redis.port);
-        }
-//console.log("data: " + data);
-        var x=JSON.parse(data);
-        printMapnikStyle(x, this);
-      },
-      function showStyleFinish(err) {
-        next(err);
-      }
-    );
-  },
-  function finish(err) {
-    if ( err ) {
-      console.error(err.message)
-      process.exit(1);
-    }
-    process.exit(0);
-  }
-);
-
-function printMapnikStyle(x, callback) {
-  console.log('style: ' + x.style);
-  console.log('version: ' + x.version);
-  var grainstore = require(basedir + '/../node_modules/windshaft/node_modules/grainstore/lib/grainstore');
-  var mml_store = new grainstore.MMLStore(serverOptions.redis, serverOptions.grainstore);
-  var builderconfig = {dbname:dbname};
-  if ( token.match(/^~/) ) {
-    builderconfig.token = token.substring(1);
-  } else {
-    builderconfig.table = token;
-  }
-  var mml_builder;
-  Step(
-    function getBuilder() {
-      mml_builder = mml_store.mml_builder(builderconfig, this);
-    },
-    function getXML(err, builder) {
-      if ( err ) throw err;
-      mml_builder.toXML(this);
-    },
-    function showXML(err, xml) {
-      if ( err ) throw err;
-      console.log('- XML - ');
-      console.log(xml);
-      return null;
-    },
-    function finish(err) {
-      callback(err);
-    }
-  );
-}
+username="$1"
+token="$2"
 
+dbname=`redis-cli -p ${REDIS_PORT} -n 5 hget "rails:users:${username}" "database_name"`
+if test $? -ne 0; then
+  exit 1
+fi
+if test -z "${dbname}"; then
+  echo "Username ${username} unknown by redis (try CARTODB/script/restore_redis?)" >&2
+  exit 1
+fi
+echo "Database name for user ${username}: ${dbname}" # only if verbose?
+if test -n "$token"; then
+  redis-cli get "map_style|${dbname}|${token}" | sed -e 's/\\n/\n/g' -e 's/\\//g'
+else
+  redis-cli keys "map_style|${dbname}|*"
+fi

tools/update_template

@@ -1,47 +0,0 @@
-#!/bin/sh
-
-verbose=no
-tiler_url=http://dev.localhost.lan:8181/tiles/template
-apikey=${CDB_APIKEY}
-
-while test -n "$1"; do
-  if test "$1" = "-v"; then
-    verbose=yes
-  elif test "$1" = "-k"; then
-    shift
-    apikey="$1"
-  elif test "$1" = "-u"; then
-    shift
-    tiler_url="$1"
-  elif test -z "$tpl"; then
-    tpl="$1"
-  elif test -z "$cfg"; then
-    cfg="$1"
-  else
-    echo "Unused parameter $1" >&2
-  fi
-  shift
-done
-
-if test -z "$cfg"; then
-  echo "Usage: $0 [-v] [-k <api_key>] [-u <tiler_url>] <template_id> <template_config>" >&2
-  echo "Default <tiler_url> is ${tiler_url}" >&2
-  echo "Default <api_key> is read from CDB_APIKEY env variable" >&2
-  exit 1
-fi
-
-cmd="curl -X PUT -skH Content-Type:application/json --data-binary @- ${tiler_url}/${tpl}?api_key=${apikey}"
-if test x${verbose} = xyes; then
-  cmd="${cmd} -v"
-fi
-res=`cat ${cfg} | tr '\n' ' ' | ${cmd}`
-if test $? -gt 0; then
-  echo "curl command failed: ${cmd}"
-fi
-
-if test x${verbose} = xyes; then
-  echo "${res}"
-fi
-
-tok=`echo "$res" | sed 's/.*"template_id":"\([^"]*\)".*/\1/'`
-echo $tok