Commit Graph

1291 Commits

Author SHA1 Message Date
Raúl Marín
e99e4a02c9 Remove TODO
Since the server registration requires superadmin priviledges
it doesn't make sense to over protect the role creation
2019-11-14 19:00:09 +01:00
Raúl Marín
fa5f0bcbc1 CDB_Federated_Server_Grant_Access: comment about search_path 2019-11-14 18:55:38 +01:00
Raúl Marín
adca727169 Revert "Go back to public user mappings"
This reverts commit 64e185b841.
2019-11-14 18:46:45 +01:00
Raúl Marín
0893fae025 Revert "CDB_Federated_Server_Unregister: Drop owned in cascade"
This reverts commit 1b86517007.
2019-11-14 18:46:02 +01:00
Raúl Marín
e69d3b1c30 Place all views in a shared schema 2019-11-14 18:45:09 +01:00
Raúl Marín
6e455efcdd Improve warning 2019-11-14 14:15:56 +01:00
Raúl Marín
1b86517007 CDB_Federated_Server_Unregister: Drop owned in cascade
Since now views might be owned by other roles, we need to drop them
in cascade to force deletion
2019-11-14 14:07:41 +01:00
Raúl Marín
64e185b841 Go back to public user mappings 2019-11-14 13:43:28 +01:00
Raúl Marín
38d8a470bc Federated Server: Grant all over postgis and cartodb schemas 2019-11-14 13:24:32 +01:00
Raúl Marín
4920029560 CDB_FederatedServerTables: Improve permission handling and error messages 2019-11-14 13:10:21 +01:00
Raúl Marín
e231500c46 Give permissions over cartodb to the FS role 2019-11-13 14:20:08 +01:00
Raúl Marín
9eab5e2533 __CDB_FS_Generate_Server_Role_Name: set to STABLE
current_database() is stable, not immutable
2019-11-12 18:15:20 +01:00
Raúl Marín
0d455d9521 __CDB_FS_List_Foreign_Schemas_PG: Remove extra role generation 2019-11-12 18:14:36 +01:00
Rafa de la Torre
944b111bb1 Merge pull request #383 from CartoDB/federated_diagnostics
Retrieve target PG and postgis versions
2019-11-12 10:45:26 +01:00
Rafa de la Torre
d5ecb39250 Replace hardcoded 5432 by @@PGPORT@@
as requested in review comment
2019-11-12 10:32:25 +01:00
Rafa de la Torre
0ad7cd485d Simplify function with aggregate 2019-11-11 21:34:51 +01:00
Rafa de la Torre
6e9ee296c5 Remove useless commented code 2019-11-11 20:48:14 +01:00
Rafa de la Torre
d87d27d7e5 Use pg_options_to_table instead of manual parsing 2019-11-11 20:42:00 +01:00
Rafa de la Torre
5c9f6964a3 Fix typo: hardcoded loopback server 2019-11-11 18:46:07 +01:00
Rafa de la Torre
d76e3ccc3e Add server options to diagnostics 2019-11-11 16:02:04 +01:00
Rafa de la Torre
eba6cf4565 Test when postgis is not installed in the remote 2019-11-08 20:27:24 +01:00
Rafa de la Torre
6700d24232 Refactor: extract __CDB_FS_Import_If_Not_Exists 2019-11-08 20:16:26 +01:00
Rafa de la Torre
511e24a40e Remove unused var role_name 2019-11-08 20:05:08 +01:00
Rafa de la Torre
80f01d4a51 Implement retrieval of remote postgis version 2019-11-08 20:02:51 +01:00
Rafa de la Torre
d4bc69cd3c Return postgis version in diagnostics info (WIP) 2019-11-08 19:49:16 +01:00
Rafa de la Torre
8730292097 Function to retrieve remote PG server ver 2019-11-08 19:20:08 +01:00
Rafa de la Torre
efd757ffa3 Check against correct server version 2019-11-08 18:18:28 +01:00
Rafa de la Torre
40a2ba9569 Stub function to add server_version to diagnostics 2019-11-08 18:09:22 +01:00
Rafa de la Torre
35b2b7e589 Check the server is of type PG and return jsonb 2019-11-08 18:06:35 +01:00
Rafa de la Torre
4100b66f3b Scaffolding for diagnostic function(s) 2019-11-08 17:11:04 +01:00
Raul Marin
d5b3953568 Regress: Remove output that depends on PROJ release 2019-11-06 18:34:20 +01:00
Raul Marin
c64c61781e Make tests path insensitive 2019-11-06 18:26:58 +01:00
Raul Marin
82d8f7e1aa Deprecate FDW user setup ;__( 2019-11-06 18:26:37 +01:00
Raul Marin
3cde55ed3a Enforce output order in CDB_Federated_Server_List_Remote_Columns 2019-11-06 17:32:48 +01:00
Raul Marin
a91f14371a Use always the modern notation for named parameters 2019-11-06 17:25:10 +01:00
Raul Marin
899a12fc53 FederatedServer: Use NAME for internal types 2019-11-06 17:12:40 +01:00
Raul Marin
01258530ff Federated Server: Unify remote table listing
- Removes DB_Federated_Server_List_Registered_Tables in favor
of CDB_Federated_Server_List_Remote_Tables that now returns
both registered and unregistered tables and, when they are
registered, the information about the associated view
2019-11-06 17:04:11 +01:00
Raul Marin
90b58fcdec Federated Server: Test with incorrect password 2019-11-06 10:20:53 +01:00
Raul Marin
29e2ee670f Accept PG9.5 and PG10 permission error messages 2019-11-05 18:29:08 +01:00
Raul Marin
e98b18fd25 Add test around grant permissions and accessing registered tables 2019-11-05 18:07:11 +01:00
Raul Marin
e6f07d4f96 Rework API to grant and revoke permissions 2019-11-05 17:18:49 +01:00
Raul Marin
c9b01592e7 CDB_Federated_Table_Register: Handle conflict nicely 2019-11-05 16:53:25 +01:00
Raul Marin
e2beefdb53 Test around NULLs and invalids arguments 2019-11-05 16:39:13 +01:00
Raul Marin
73ee4107d4 CDB_FederatedServerTables: Improve tests readability 2019-11-05 14:48:52 +01:00
Raul Marin
aa481f4219 Permission tests and fixes for CDB_FederatedServerListRemote 2019-11-05 14:35:52 +01:00
Raul Marin
bac7d79ab3 CDB_FederatedServer: Improve tests readability 2019-11-05 13:22:45 +01:00
Raul Marin
98b2b02199 Improve tests readability and test deleting a server from granted access 2019-11-05 11:19:50 +01:00
Raul Marin
10ed64789d Add functions to grant and revoke permissions over federated servers 2019-11-04 19:23:36 +01:00
Raul Marin
0f66c54ce5 Comment cleanup 2019-11-04 16:53:48 +01:00
Raul Marin
03bc3436cd Add more tests for [un-]registering servers 2019-11-04 16:29:18 +01:00