cartodb4/dataservices-api
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Dont raise exception when empty params passed to HERE geocoder

Browse Source
This commit is contained in:
Mario de Frutos
2018-01-31 12:16:13 +01:00
parent 3484cce88b
commit 2f8dbbb5dc
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/lib/python/cartodb_services/cartodb_services/here/geocoder.py
+1 -1
View File
@@ -70,7 +70,7 @@ class HereMapsGeocoder(Traceable):
if value: if value:
params[key] = value params[key] = value
if not params: if not params:
raise NoGeocodingParams() return []
return self._execute_geocode(params) return self._execute_geocode(params)
def _execute_geocode(self, params): def _execute_geocode(self, params):
server/lib/python/cartodb_services/test/test_heremapsgeocoder.py
+2 -2
View File
@@ -128,8 +128,8 @@ class HereMapsGeocoderTestCase(unittest.TestCase):
def test_geocode_address_with_no_params(self, req_mock): def test_geocode_address_with_no_params(self, req_mock):
req_mock.register_uri('GET', HereMapsGeocoder.PRODUCTION_GEOCODE_JSON_URL, req_mock.register_uri('GET', HereMapsGeocoder.PRODUCTION_GEOCODE_JSON_URL,
text=self.GOOD_RESPONSE) text=self.GOOD_RESPONSE)
with self.assertRaises(NoGeocodingParams): result = self.geocoder.geocode()
self.geocoder.geocode() self.assertEqual(result, [])
def test_geocode_address_empty_response(self, req_mock): def test_geocode_address_empty_response(self, req_mock):
req_mock.register_uri('GET', HereMapsGeocoder.PRODUCTION_GEOCODE_JSON_URL, req_mock.register_uri('GET', HereMapsGeocoder.PRODUCTION_GEOCODE_JSON_URL,