cartodb4/dataservices-api
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove duped metrics for isochrones

Browse Source 
We are counting the success/empty inside the iteration of the results
returned by the third party service.

For example, if we ask for 3 isochrones to a provider we count:

- 1 for success or empty
- If success we add 1 more success for each isochrone in the result
- N isolines_generated

but it should be

- 1 for success or empty
- N isolines_generated
This commit is contained in:
Mario de Frutos
2018-11-19 17:59:47 +01:00
parent dc47f6f71b
commit 87bb8bea68
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/extension/sql/80_isolines_helper.sql
-6
View File
@@ -295,10 +295,8 @@ RETURNS SETOF cdb_dataservices_server.isoline AS $$
for isochrone in resp: for isochrone in resp:
result_polygon = coordinates_to_polygon(isochrone.coordinates) result_polygon = coordinates_to_polygon(isochrone.coordinates)
if result_polygon: if result_polygon:
quota_service.increment_success_service_use()
result.append([source, isochrone.duration, result_polygon]) result.append([source, isochrone.duration, result_polygon])
else: else:
quota_service.increment_empty_service_use()
result.append([source, isochrone.duration, None]) result.append([source, isochrone.duration, None])
quota_service.increment_success_service_use() quota_service.increment_success_service_use()
quota_service.increment_isolines_service_use(len(result)) quota_service.increment_isolines_service_use(len(result))
@@ -356,10 +354,8 @@ RETURNS SETOF cdb_dataservices_server.isoline AS $$
for isochrone in resp: for isochrone in resp:
result_polygon = coordinates_to_polygon(isochrone.coordinates) result_polygon = coordinates_to_polygon(isochrone.coordinates)
if result_polygon: if result_polygon:
service_manager.quota_service.increment_success_service_use()
result.append([source, isochrone.duration, result_polygon]) result.append([source, isochrone.duration, result_polygon])
else: else:
service_manager.quota_service.increment_empty_service_use()
result.append([source, isochrone.duration, None]) result.append([source, isochrone.duration, None])
service_manager.quota_service.increment_success_service_use() service_manager.quota_service.increment_success_service_use()
service_manager.quota_service.increment_isolines_service_use(len(result)) service_manager.quota_service.increment_isolines_service_use(len(result))
@@ -416,10 +412,8 @@ RETURNS SETOF cdb_dataservices_server.isoline AS $$
for isochrone in resp: for isochrone in resp:
result_polygon = coordinates_to_polygon(isochrone.coordinates) result_polygon = coordinates_to_polygon(isochrone.coordinates)
if result_polygon: if result_polygon:
service_manager.quota_service.increment_success_service_use()
result.append([source, isochrone.duration, result_polygon]) result.append([source, isochrone.duration, result_polygon])
else: else:
service_manager.quota_service.increment_empty_service_use()
result.append([source, isochrone.duration, None]) result.append([source, isochrone.duration, None])
service_manager.quota_service.increment_success_service_use() service_manager.quota_service.increment_success_service_use()
service_manager.quota_service.increment_isolines_service_use(len(result)) service_manager.quota_service.increment_isolines_service_use(len(result))