cartodb4/dataservices-api
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Implement test and fix for that case #201

Browse Source 
Add test_should_account_for_zero_paddded_keys plus its corresponding fix
for it.
This commit is contained in:
Rafa de la Torre
2016-06-13 13:07:21 +02:00
parent a2863d7135
commit b0bb60736c
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/lib/python/cartodb_services/cartodb_services/metrics/user.py
View File

@@ -85,6 +85,11 @@ class UserMetricsService:
service, metric, date)
score = self._redis_connection.zscore(redis_prefix, date.day)
aggregated_metric += score if score else 0
zero_padded_day = date.strftime('%d')
if str(date.day) != zero_padded_day:
score = self._redis_connection.zscore(redis_prefix, zero_padded_day)
aggregated_metric += score if score else 0
return aggregated_metric
# Private functions

5
server/lib/python/cartodb_services/test/test_user_service.py
View File

@@ -77,8 +77,11 @@ class TestUserService(TestCase):
us.increment_service_use(self.NOKIA_GEOCODER, 'fail_responses')
assert us.used_quota(self.NOKIA_GEOCODER, date.today()) == 2
@freeze_time("2015-06-01")
def test_should_account_for_zero_paddded_keys(self):
raise nose.SkipTest('not implemented yet')
us = self.__build_user_service('test_user')
self.redis_conn.zincrby('user:test_user:geocoder_here:success_responses:201506', '01', 400)
assert us.used_quota(self.NOKIA_GEOCODER, date(2015, 6,1)) == 400
@freeze_time("2015-06-01")
def test_should_account_for_wrongly_stored_non_padded_keys(self):