Merge pull request #628 from CartoDB/bug/sc-254346/opianalytics-here-isolines-returning-null

Add changes for new server release
Merge branch 'bug/sc-254346/opianalytics-here-isolines-returning-null' of github.com:CartoDB/dataservices-api into bug/sc-254346/opianalytics-here-isolines-returning-null
2022-09-05 13:24:52 +02:00 · 2022-09-05 13:23:56 +02:00 · 2022-09-02 11:42:27 +02:00 · 2022-09-02 11:42:16 +02:00 · 2022-09-01 16:20:27 +02:00 · 2022-09-01 16:15:30 +02:00
4 changed files with 16 additions and 8 deletions
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -8,7 +8,7 @@ jobs:
      matrix:
        pg_version: [10, 12]
    env:
-        PG_VERSION: ${{ matrix.pg_version }}
+      PG_VERSION: ${{ matrix.pg_version }}
    steps:
      - uses: actions/checkout@v1

@@ -16,12 +16,12 @@ jobs:
        run: echo "CLOUDSDK_PYTHON=/usr/bin/python" >> $GITHUB_ENV

      - name: Setup gcloud authentication
-        uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
+        uses: google-github-actions/setup-gcloud@v0
        with:
          service_account_key: ${{ secrets.GCS }}

      - name: Pull base image
-        run: gcloud auth configure-docker && docker pull gcr.io/cartodb-on-gcp-ci-testing/cartodb-postgresql-base:${{ matrix.pg_version }}
+        run: docker pull gcr.io/cartodb-on-gcp-ci-testing/cartodb-postgresql-base:${{ matrix.pg_version }}

      - name: Checkout ci tools repository
        uses: actions/checkout@v2
@@ -46,9 +46,9 @@ jobs:
      - name: Run python library tests
        run: docker-compose -f docker-compose.yaml exec -T postgres-server bash -c "cd /dataservices-api/server/ && MAPBOX_API_KEY=$MAPBOX_API_KEY TOMTOM_API_KEY=$TOMTOM_API_KEY GEOCODIO_API_KEY=$GEOCODIO_API_KEY nosetests lib/python/cartodb_services/test"
        env:
-           MAPBOX_API_KEY: ${{ secrets.MAPBOX_API_KEY }}
-           TOMTOM_API_KEY: ${{ secrets.TOMTOM_API_KEY }}
-           GEOCODIO_API_KEY: ${{ secrets.GEOCODIO_API_KEY }}
+          MAPBOX_API_KEY: ${{ secrets.MAPBOX_API_KEY }}
+          TOMTOM_API_KEY: ${{ secrets.TOMTOM_API_KEY }}
+          GEOCODIO_API_KEY: ${{ secrets.GEOCODIO_API_KEY }}
        timeout-minutes: 5

      - name: Run server tests
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,3 +1,8 @@
+Sep 5th, 2022
+==============
+* Version `0.24.2` of the Python library
+    * Fix error calculating isolines with HERE
+
 May 26th, 2021
 ==============
 * Version `0.40.1` of the server extension
--- a/server/lib/python/cartodb_services/cartodb_services/here/routing.py
+++ b/server/lib/python/cartodb_services/cartodb_services/here/routing.py
@@ -345,6 +345,9 @@ class HereMapsRoutingIsolineV8(Traceable):
            mode_params.update({'routingmode': mode_type})

        if not ('mode_traffic' in options and options['mode_traffic'] == 'enabled'):
-            mode_params.update({'departuretime': 'any'})
+            if 'is_destination' in options and options['is_destination'].lower() == 'true':
+                mode_params.update({'arrivaltime': 'any'})
+            else:
+                mode_params.update({'departuretime': 'any'})

        return mode_params
--- a/server/lib/python/cartodb_services/setup.py
+++ b/server/lib/python/cartodb_services/setup.py
@@ -10,7 +10,7 @@ from setuptools import setup, find_packages
 setup(
    name='cartodb_services',

-    version='0.24.1',
+    version='0.24.2',

    description='CartoDB Services API Python Library',
Author	SHA1	Message	Date
Moisés Calzado	94512eea59	Merge pull request #628 from CartoDB/bug/sc-254346/opianalytics-here-isolines-returning-null	2022-09-05 13:24:52 +02:00
Moisés Calzado	6ce052072c	Add changes for new server release	2022-09-05 13:23:56 +02:00
Moisés Calzado	27d3df3607	Merge branch 'bug/sc-254346/opianalytics-here-isolines-returning-null' of github.com:CartoDB/dataservices-api into bug/sc-254346/opianalytics-here-isolines-returning-null	2022-09-02 11:42:27 +02:00
Moisés Calzado	86c10f0ca5	Bump version	2022-09-02 11:42:16 +02:00
Alberto Hernández	9ff4e25603	Merge branch 'development' into bug/sc-254346/opianalytics-here-isolines-returning-null	2022-09-01 16:20:27 +02:00
alberhander	063cac1b65	try fix CI	2022-09-01 16:15:30 +02:00
Alberto Hernández	2819382dd0	fixing CI	2022-09-01 15:38:01 +02:00
Alberto Hernández	10a34da232	trying to fix action	2022-09-01 15:31:46 +02:00
Alberto Hernández	8caa735262	fix action	2022-09-01 15:27:28 +02:00
Moisés Calzado	c7ed86072b	Fix parameter for new HERE Isolines API	2022-09-01 13:30:08 +02:00
Manuel López Ruiz	a65cfb2fd2	Merge pull request #625 from CartoDB/fix/ch175898/gcp-github-actions fixed gcloud github actions setup	2022-03-30 18:04:42 +02:00
Manuel López Ruiz	a8e9476dad	Merge branch 'development' into fix/ch175898/gcp-github-actions	2022-03-30 18:04:23 +02:00
Manuel López Ruiz	2117afc336	Merge pull request #627 from CartoDB/chore/sc-219063/0EDAHT1N Fix deprecation notice GHAction	2022-03-30 17:51:31 +02:00
Manuel López Ruiz	52fb8b0875	Changes applyed to `0EDAHT1N`	2022-03-30 17:50:08 +02:00
Manuel López Ruiz	1794039c6b	Changes applyed to `4STN0GNB`	2022-03-30 17:50:07 +02:00
Miguel Angel Moreno	d8b00307cd	Revert "UPgrade pip" This reverts commit `1925bb6082`.	2022-03-07 16:53:12 +01:00
Miguel Angel Moreno	1925bb6082	UPgrade pip	2022-03-07 16:49:11 +01:00
Miguel Angel Moreno	5fe4263583	Merge branch 'master' of github.com:CartoDB/dataservices-api into fix/ch175898/gcp-github-actions	2022-03-07 16:33:36 +01:00
Manuel López Ruiz	24b17128fc	Delete gcloud from CI [ch-198662]	2021-12-21 10:48:16 +01:00
alvarorm22	de33fec79f	fixed gcloud github actions setup	2021-08-27 11:55:53 +02:00