0.6.12

adding ability to check if a logger exists

lib/log4js.js

@@ -62,6 +62,11 @@ var events = require('events')
   replaceConsole: false
 };
 
+function hasLogger(logger) {
+  return loggers.hasOwnProperty(logger);
+}
+
+
 /**
  * Get a logger instance. Instance is cached on categoryName level.
  * @param  {String} categoryName name of category to log to.
@@ -76,7 +81,7 @@ function getLogger (categoryName) {
   }
 
   var appenderList;
-  if (!loggers[categoryName]) {
+  if (!hasLogger(categoryName)) {
     // Create the logger for this name if it doesn't already exist
     loggers[categoryName] = new Logger(categoryName);
     if (appenders[categoryName]) {
@@ -115,7 +120,7 @@ function addAppender () {
     
     if (category === ALL_CATEGORIES) {
       addAppenderToAllLoggers(appender);
-    } else if (loggers[category]) {
+    } else if (hasLogger(category)) {
       loggers[category].addListener("log", appender);
     }
   });
@@ -123,7 +128,7 @@ function addAppender () {
 
 function addAppenderToAllLoggers(appender) {
   for (var logger in loggers) {
-    if (loggers.hasOwnProperty(logger)) {
+    if (hasLogger(logger)) {
       loggers[logger].addListener("log", appender);
     }
   }
@@ -139,7 +144,7 @@ function addAppenderToCategory(appender, category) {
 function clearAppenders () {
   appenders = {};
   for (var logger in loggers) {
-    if (loggers.hasOwnProperty(logger)) {
+    if (hasLogger(logger)) {
       loggers[logger].removeAllListeners("log");
     }
   }
@@ -304,6 +309,7 @@ function loadAppender(appender) {
 module.exports = {
   getLogger: getLogger,
   getDefaultLogger: getDefaultLogger,
+  hasLogger: hasLogger,
   
   addAppender: addAppender,
   loadAppender: loadAppender,

lib/logger.js

@@ -49,9 +49,12 @@ Logger.prototype.removeLevel = function() {
 
 Logger.prototype.log = function() {
   var args = Array.prototype.slice.call(arguments)
-  , logLevel = args.shift()
-  , loggingEvent = new LoggingEvent(this.category, logLevel, args, this);
-  this.emit("log", loggingEvent);
+  , logLevel = levels.toLevel(args.shift())
+  , loggingEvent;
+  if (this.isLevelEnabled(logLevel)) {
+    loggingEvent = new LoggingEvent(this.category, logLevel, args, this);
+    this.emit("log", loggingEvent);
+  }
 };
 
 Logger.prototype.isLevelEnabled = function(otherLevel) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "log4js",
-  "version": "0.6.10",
+  "version": "0.6.12",
   "description": "Port of Log4js to work with node.",
   "keywords": [
     "logging",

test/logglyAppender-test.js

@@ -70,7 +70,7 @@ vows.describe('log4js logglyAppender').addBatch({
         tags: ['loggly-tag1', 'loggly-tag2', 'loggly-tagn'] 
       });
       
-      setup.logger.log('Log event #1');
+      setup.logger.log('trace', 'Log event #1');
       return setup;
     },
     'there should be one message only': function (topic) {