Rename developerSettingsTab to developerMode for consistency (#2889)

This commit is contained in:
Hugh Nimmo-Smith
2024-12-11 14:30:16 +00:00
committed by GitHub
parent b834d8f679
commit 6c81f69590
3 changed files with 7 additions and 12 deletions

View File

@@ -14,7 +14,7 @@ import {
showHandRaisedTimer as showHandRaisedTimerSetting,
showReactions as showReactionsSetting,
playReactionsSound as playReactionsSoundSetting,
developerSettingsTab as developerSettingsTabSetting,
developerMode as developerModeSetting,
useSetting,
} from "./settings";
@@ -37,9 +37,7 @@ export const PreferencesSettingsTab: FC = () => {
fn(e.target.checked);
};
const [developerSettingsTab, setDeveloperSettingsTab] = useSetting(
developerSettingsTabSetting,
);
const [developerMode, setDeveloperMode] = useSetting(developerModeSetting);
return (
<div>
@@ -82,13 +80,13 @@ export const PreferencesSettingsTab: FC = () => {
<InputField
id="developerSettingsTab"
type="checkbox"
checked={developerSettingsTab}
checked={developerMode}
label={t("settings.preferences_tab.developer_mode_label")}
description={t(
"settings.preferences_tab.developer_mode_label_description",
)}
onChange={(event: ChangeEvent<HTMLInputElement>): void =>
setDeveloperSettingsTab(event.target.checked)
setDeveloperMode(event.target.checked)
}
/>
</FieldRow>

View File

@@ -23,7 +23,7 @@ import { widget } from "../widget";
import {
useSetting,
soundEffectVolumeSetting,
developerSettingsTab,
developerMode,
} from "./settings";
import { isFirefox } from "../Platform";
import { PreferencesSettingsTab } from "./PreferencesSettingsTab";
@@ -66,7 +66,7 @@ export const SettingsModal: FC<Props> = ({
const [soundVolume, setSoundVolume] = useSetting(soundEffectVolumeSetting);
const [soundVolumeRaw, setSoundVolumeRaw] = useState(soundVolume);
const [showDeveloperSettingsTab] = useSetting(developerSettingsTab);
const [showDeveloperSettingsTab] = useSetting(developerMode);
const audioTab: Tab<SettingsTab> = {
key: "audio",

View File

@@ -68,10 +68,7 @@ export const useOptInAnalytics = (): [
return PosthogAnalytics.instance.isEnabled() ? setting : [false, null];
};
export const developerSettingsTab = new Setting(
"developer-settings-tab",
false,
);
export const developerMode = new Setting("developer-settings-tab", false);
export const duplicateTiles = new Setting("duplicate-tiles", 0);