prioritize header > hideHeader

This commit is contained in:
Timo
2025-06-25 15:32:16 +02:00
parent ce15188d48
commit a8e67b76f2
2 changed files with 19 additions and 6 deletions

View File

@@ -243,4 +243,16 @@ describe("UrlParams", () => {
expect(getUrlParams("?intent=join_existing").skipLobby).toBe(false);
});
});
describe("header", () => {
it("uses header if provided", () => {
expect(getUrlParams("?header=app_bar&hideHeader=true").header).toBe(
"app_bar",
);
expect(getUrlParams("?header=none&hideHeader=false").header).toBe("none");
});
it("converts hideHeader to the correct header value", () => {
expect(getUrlParams("?hideHeader=true").header).toBe("none");
expect(getUrlParams("?hideHeader=false").header).toBe("standard");
});
});
});

View File

@@ -267,12 +267,13 @@ export const getUrlParams = (
intent = UserIntent.Unknown;
}
// Check hideHeader for backwards compatibility
let header = parser.getFlagParam("hideHeader")
? HeaderStyle.None
: parser.getParam("header");
if (header !== HeaderStyle.None && header !== HeaderStyle.AppBar)
header = HeaderStyle.Standard;
// Check hideHeader for backwards compatibility. If header is set, hideHeader
// is ignored.
const header =
parser.getParam("header") ??
(parser.getFlagParam("hideHeader")
? HeaderStyle.None
: HeaderStyle.Standard);
const widgetId = parser.getParam("widgetId");
const parentUrl = parser.getParam("parentUrl");