Compare commits

..

9 Commits

Author SHA1 Message Date
Robin
a304f37705 Run the 'prevent blocked' workflow even if PR has conflicts
See the description of pull_request versus pull_request_target documented at https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request.
2025-03-18 14:45:07 -04:00
Robin
7d6a60a6ad Merge pull request #3110 from element-hq/robin/participant-limits
Show "insufficient capacity" when hitting participant limits
2025-03-18 13:37:43 -04:00
Robin
45c3c7a37e Show "insufficient capacity" when hitting participant limits 2025-03-18 13:33:36 -04:00
Robin
22977dcf65 Merge pull request #3109 from element-hq/robin/livekit-2.9.1
Downgrade to livekit-client v2.9.1
2025-03-18 11:41:26 -04:00
Robin
213f234e94 Downgrade to livekit-client v2.9.1
livekit-client v2.9.2 regresses switching between the front/back cameras.
2025-03-18 11:36:08 -04:00
fkwp
990d5727d4 Merge pull request #3104 from element-hq/fkwp/update_readme
deleted old demo.jpg
2025-03-18 10:01:29 +01:00
Valere Fedronic
4653be86b3 Merge pull request #3101 from element-hq/valere/dev_ex_eslint_tests
Eslint: Ensure playwright files are checked by eslint
2025-03-18 09:57:02 +01:00
fkwp
7a0010dd36 deleted old demo.jpg 2025-03-18 09:33:05 +01:00
Valere
6a8abeb609 Eslint: Ensure playwright files are checked by eslint 2025-03-17 15:23:51 +01:00
7 changed files with 22 additions and 12 deletions

View File

@@ -1,6 +1,6 @@
name: Prevent blocked
on:
pull_request:
pull_request_target:
types: [opened, labeled, unlabeled]
jobs:
prevent-blocked:

BIN
demo.jpg

Binary file not shown.

Before

Width:  |  Height:  |  Size: 179 KiB

View File

@@ -13,8 +13,8 @@
"prettier:check": "prettier -c .",
"prettier:format": "prettier -w .",
"lint": "yarn lint:types && yarn lint:eslint && yarn lint:knip",
"lint:eslint": "eslint --max-warnings 0 src",
"lint:eslint-fix": "eslint --max-warnings 0 src --fix",
"lint:eslint": "eslint --max-warnings 0 src playwright",
"lint:eslint-fix": "eslint --max-warnings 0 src playwright --fix",
"lint:knip": "knip",
"lint:types": "tsc",
"i18n": "i18next",

View File

@@ -91,7 +91,7 @@ test("As a guest, create a call, share link and other join", async ({
await expect(creatorPage.getByTestId("modal_inviteLink")).toBeVisible();
await creatorPage.getByTestId("modal_inviteLink").click();
let inviteLink = (await creatorPage.evaluate(
const inviteLink = (await creatorPage.evaluate(
"navigator.clipboard.readText()",
)) as string;
expect(inviteLink).toContain("room/#/");

View File

@@ -22,11 +22,15 @@ import { GroupCallErrorBoundary } from "../room/GroupCallErrorBoundary.tsx";
test.each<[string, ConnectionError]>([
[
"LiveKit",
"LiveKit hits track limit",
new ConnectionError("", ConnectionErrorReason.InternalError, 503),
],
[
"LiveKit Cloud",
"LiveKit hits room participant limit",
new ConnectionError("", ConnectionErrorReason.ServerUnreachable, 200),
],
[
"LiveKit Cloud hits connection limit",
new ConnectionError("", ConnectionErrorReason.NotAllowed, 429),
],
])(

View File

@@ -144,11 +144,16 @@ async function connectAndPublish(
websocketTimeout: window.websocketTimeout ?? 45000,
});
} catch (e) {
// LiveKit uses 503 to indicate that the server has hit its track limits
// or equivalently, 429 in LiveKit Cloud
// For reference, the 503 response is generated at: https://github.com/livekit/livekit/blob/fcb05e97c5a31812ecf0ca6f7efa57c485cea9fb/pkg/service/rtcservice.go#L171
if (e instanceof ConnectionError && (e.status === 503 || e.status === 429))
// LiveKit uses 503 to indicate that the server has hit its track limits.
// https://github.com/livekit/livekit/blob/fcb05e97c5a31812ecf0ca6f7efa57c485cea9fb/pkg/service/rtcservice.go#L171
// It also errors with a status code of 200 (yes, really) for room
// participant limits.
// LiveKit Cloud uses 429 for connection limits.
// Either way, all these errors can be explained as "insufficient capacity".
if (
e instanceof ConnectionError &&
(e.status === 503 || e.status === 200 || e.status === 429)
)
throw new InsufficientCapacityError();
throw e;
}

View File

@@ -50,6 +50,7 @@
"include": [
"./node_modules/matrix-js-sdk/src/@types/*.d.ts",
"./src/**/*.ts",
"./src/**/*.tsx"
"./src/**/*.tsx",
"./playwright/**/*.ts"
]
}