test livekit-client 2.9.1

.github/workflows/blocked.yaml

@@ -1,6 +1,6 @@
 name: Prevent blocked
 on:
-  pull_request_target:
+  pull_request:
     types: [opened, labeled, unlabeled]
 jobs:
   prevent-blocked:

package.json

@@ -13,8 +13,8 @@
     "prettier:check": "prettier -c .",
     "prettier:format": "prettier -w .",
     "lint": "yarn lint:types && yarn lint:eslint && yarn lint:knip",
-    "lint:eslint": "eslint --max-warnings 0 src playwright",
-    "lint:eslint-fix": "eslint --max-warnings 0 src playwright --fix",
+    "lint:eslint": "eslint --max-warnings 0 src",
+    "lint:eslint-fix": "eslint --max-warnings 0 src --fix",
     "lint:knip": "knip",
     "lint:types": "tsc",
     "i18n": "i18next",

playwright/access.spec.ts

@@ -91,7 +91,7 @@ test("As a guest, create a call, share link and other join", async ({
   await expect(creatorPage.getByTestId("modal_inviteLink")).toBeVisible();
   await creatorPage.getByTestId("modal_inviteLink").click();
 
-  const inviteLink = (await creatorPage.evaluate(
+  let inviteLink = (await creatorPage.evaluate(
     "navigator.clipboard.readText()",
   )) as string;
   expect(inviteLink).toContain("room/#/");

src/livekit/useECConnectionState.test.tsx

@@ -22,15 +22,11 @@ import { GroupCallErrorBoundary } from "../room/GroupCallErrorBoundary.tsx";
 
 test.each<[string, ConnectionError]>([
   [
-    "LiveKit hits track limit",
+    "LiveKit",
     new ConnectionError("", ConnectionErrorReason.InternalError, 503),
   ],
   [
-    "LiveKit hits room participant limit",
-    new ConnectionError("", ConnectionErrorReason.ServerUnreachable, 200),
-  ],
-  [
-    "LiveKit Cloud hits connection limit",
+    "LiveKit Cloud",
     new ConnectionError("", ConnectionErrorReason.NotAllowed, 429),
   ],
 ])(

src/livekit/useECConnectionState.ts

@@ -144,16 +144,11 @@ async function connectAndPublish(
       websocketTimeout: window.websocketTimeout ?? 45000,
     });
   } catch (e) {
-    // LiveKit uses 503 to indicate that the server has hit its track limits.
-    // https://github.com/livekit/livekit/blob/fcb05e97c5a31812ecf0ca6f7efa57c485cea9fb/pkg/service/rtcservice.go#L171
-    // It also errors with a status code of 200 (yes, really) for room
-    // participant limits.
-    // LiveKit Cloud uses 429 for connection limits.
-    // Either way, all these errors can be explained as "insufficient capacity".
-    if (
-      e instanceof ConnectionError &&
-      (e.status === 503 || e.status === 200 || e.status === 429)
-    )
+    // LiveKit uses 503 to indicate that the server has hit its track limits
+    // or equivalently, 429 in LiveKit Cloud
+    // For reference, the 503 response is generated at: https://github.com/livekit/livekit/blob/fcb05e97c5a31812ecf0ca6f7efa57c485cea9fb/pkg/service/rtcservice.go#L171
+
+    if (e instanceof ConnectionError && (e.status === 503 || e.status === 429))
       throw new InsufficientCapacityError();
     throw e;
   }

tsconfig.json

@@ -50,7 +50,6 @@
   "include": [
     "./node_modules/matrix-js-sdk/src/@types/*.d.ts",
     "./src/**/*.ts",
-    "./src/**/*.tsx",
-    "./playwright/**/*.ts"
+    "./src/**/*.tsx"
   ]
 }