Commit Graph
100 Commits
Author SHA1 Message Date
Scott Giese d1509d6096 NULL check after malloc 2021-02-13 22:25:31 -06:00
Scott Giese 469a28c49a Remove obsolete, unused variable 2021-02-13 21:44:25 -06:00
Scott Giese a1f83542cb Remove unncessary cmake policy definitions 2021-02-13 21:43:48 -06:00
Scott Giese 074cb31c28 fix: sky and cockpit to turn black
Metar sky condition without base layer height (e.g. FEW///) is the cause of this issue.
Randomize the base layer height when the actual height is unknown.
2020-12-24 15:39:39 -06:00
Scott Giese e8f715c255 Maintenance: convert atoi to modern equivalence
Out of range results in undefined behavior in the C library.
Coverting to C++ library to avoid this risk.
2020-12-17 18:01:49 -06:00
Scott Giese e031ea7f7c Crash prevention: throw during dtor
get_manager() will be called during dtor, so throwing an exception would cause a hard crash.
2020-12-17 17:02:40 -06:00
Scott Giese 9bac911fe1 Maintenance: Use empty instead of size==0 2020-12-17 16:08:06 -06:00
Scott Giese cdd5cf8cd5 Remove unreachable code 2020-12-17 15:41:51 -06:00
Scott Giese 39d616a0d5 Support Boost v1.75
Resolved a breaking change.
2020-12-15 01:41:32 -06:00
Scott Giese 79252d889c Merge branch 'next' of https://git.code.sf.net/p/flightgear/simgear into next 2020-11-27 17:56:52 -06:00
Scott Giese aab373ac3a Model Loading: Overlays
Cannot copy overlays until the props has been read.
Ticket: #2429
2020-11-24 11:26:57 -06:00
Scott Giese 59809ab61f smell: avoid uncasting with left-shift 2020-11-23 16:17:28 -06:00
Scott Giese 7673da3832 smell: throwing heap object
null check.
2020-11-23 16:16:14 -06:00
Scott Giese 112c9a110b smell: potential div-by-0 2020-11-23 16:14:37 -06:00
Scott Giese 59e62b1414 warning: unreachable code 2020-11-23 16:13:43 -06:00
Scott Giese 43bf10d803 warning: defined but not used 2020-11-23 16:12:07 -06:00
Scott Giese 20bcb0f245 warning: defined but not used
clean up whitespace.
2020-11-23 16:11:08 -06:00
Scott Giese c469f072f1 warning: ‘Active’ will be initialized after 'CanWait' 2020-11-23 16:08:55 -06:00
Scott Giese 62f3923692 warning: comparison of integer expressions of different signedness 2020-11-23 16:07:39 -06:00
Scott Giese 03abb674dc warning: unused variable ‘fd’ 2020-11-23 16:06:43 -06:00
Scott Giese f6e63e1831 warning: unused variable ‘idx’ 2020-11-23 16:05:03 -06:00
Scott Giese da39e30439 METAR: mitigate wind sensor failures 2020-11-20 21:13:47 -06:00
Scott Giese f393a246ac METAR: When Wind unit not specified, default to knots.
FLIGHTGEAR-F6 resolved
2020-10-23 23:26:28 -05:00
Scott Giese d7a149e8cd METAR Wind Sensor Failure.
FLIGHTGEAR-F9 resolved.
2020-10-23 22:12:51 -05:00
Scott Giese cb4f3b1ca9 REVIEW: Memory Leaks 2020-09-24 22:24:12 -05:00
Scott Giese 9ecb90edda Clean up memory leak comment 2020-08-27 23:41:19 -05:00
Scott Giese 0d5552851b Memory Leak Fixed - SGTexturedTriangleBin
Reclaimed 42,560 bytes in 280 blocks
2020-08-27 23:40:25 -05:00
Scott Giese 5b0f44f0db Memory Leak Fix - matlib
Reclaimed 61,560 bytes in 405 blocks
2020-08-24 00:20:59 -05:00
Scott Giese f14bcfb3c5 Memory Leak Fix - SGMaterial
Reclaimed 61,560 bytes in 405 blocks
2020-08-24 00:20:26 -05:00
Scott Giese e1e70e8d33 Memory Leak Fix - BVHStaticGeometryBuilder
Was resolved at some point over the last two weeks.
Reclaimed 4,518,880 bytes in 141,215 blocks
2020-08-23 22:38:06 -05:00
Scott Giese bd01e741ac Memory Leak Fix - sg_path
Resolved via HTTPRespository fix
Reclaimed 272,181 bytes in 2,833 blocks
2020-08-23 22:22:18 -05:00
Scott Giese 423a0f65b0 Memory Leak Fix - HTTPRepository
Reclaimed 1,797,012 bytes in 7599 blocks
2020-08-23 22:15:28 -05:00
Scott Giese b8e06453ea Temporary fix: SimGear OpenAL dependency
FG configuration fails due to SG find_dependency(OpenAL) issue.
Skipping this dependency since FG itself will find_package(OpenAL).
2020-08-23 20:15:18 -05:00
Scott Giese 720a1fe7d2 REVIEW: Memory Leak - naTempSave()
1,024 bytes in 1 blocks are still reachable
2020-08-23 01:02:27 -05:00
Scott Giese fc1178fb39 REVIEW: Memory Leak - ODGauge
1,176 bytes in 3 blocks are indirectly lost
2020-08-23 00:57:39 -05:00
Scott Giese 7ac400a162 REVIEW: Memory Leak - vgCreateContextSH()
1,624 bytes in 1 blocks are still reachable
2020-08-23 00:27:31 -05:00
Scott Giese 3550047bc8 REVIEW: Memory Leak - condition.cxx
2,880 bytes in 40 blocks are indirectly lost
632 bytes in 79 blocks are indirectly lost
2020-08-23 00:07:19 -05:00
Scott Giese b7d2eea4b2 REVIEW: Memory Leak - props.cxx
2,028 (1,976 direct, 52 indirect) bytes in 13 blocks are definitely lost
1,963 bytes in 47 blocks are indirectly lost
1,544 bytes in 193 blocks are indirectly lost
662 bytes in 32 blocks are indirectly lost
152 bytes in 1 blocks are definitely lost
32 bytes in 1 blocks are indirectly lost
8 bytes in 1 blocks are indirectly lost
2020-08-22 23:52:36 -05:00
Scott Giese 69ad4a39e3 REVIEW: Memory Leak - nasal newBlock()
168 bytes in 7 blocks are still reachable
2020-08-22 22:42:09 -05:00
Scott Giese 4ccaa68c6a REVIEW: Memory Leak - ODGauge
3,572 (136 direct, 3,436 indirect) bytes in 1 blocks are definitely lost
3,572 (8 direct, 3,564 indirect) bytes in 1 blocks are definitely lost
2,712 bytes in 3 blocks are indirectly lost
384 bytes in 3 blocks are indirectly lost
168 bytes in 3 blocks are indirectly lost
2020-08-22 22:38:33 -05:00
Scott Giese fd6e4e7298 REVIEW: Memory Leak - nasal string.c; setlen()
3,953 bytes in 184 blocks are still reachable
2020-08-22 21:53:47 -05:00
Scott Giese 896f3b6928 REVIEW: Memory Leak - soundmgr_openal.cxx
4,136 bytes in 1 blocks are still reachable
2020-08-22 21:39:47 -05:00
Scott Giese 6f6c3a0e05 REVIEW: Memory Leak - SGReaderWriterXML sgLoad3DModel_internal()
4,352 bytes in 272 blocks are definitely lost
2020-08-22 21:30:41 -05:00
Scott Giese 6160fce2ae REVIEW: Memory Leak - SGComparisonCondition::setRightValue()
7,144 bytes in 47 blocks are indirectly lost
2020-08-22 18:23:19 -05:00
Scott Giese e1a6602a59 REVIEW: Memory Leak - naNewContext()
8,184 bytes in 1 blocks are still reachable
2020-08-22 18:07:11 -05:00
Scott Giese d18c9910e8 REVIEW: Memory Leak - SGMaterialLib::load()
8,800 bytes in 57 blocks are indirectly lost
2020-08-22 18:04:56 -05:00
Scott Giese b4ba7db5c0 REVIEW: Memory Leak - SGMaterialLib::load()
10,240 (1,440 direct, 8,800 indirect) bytes in 60 blocks are definitely lost
2020-08-22 17:57:54 -05:00
Scott Giese bdd7878d19 REVIEW: Memory Leak - condition::readAndConditions()
11,502 (1,560 direct, 9,942 indirect) bytes in 39 blocks are definitely lost
2020-08-22 17:42:58 -05:00
Scott Giese f210d6ba94 REVIEW: Memory Leak - SGPropertyNode::getChild()
12,862 (11,856 direct, 1,006 indirect) bytes in 78 blocks are definitely lost
2020-08-22 17:39:58 -05:00
Scott Giese 0807a6ddf7 REVIEW: Memory Leak - SGPropertyNode::addChangeListener
24,928 bytes in 164 blocks are indirectly lost
2020-08-22 17:37:39 -05:00
Scott Giese ea53e9af0c REVIEW: Memory Leak - UniformFactoryImpl::getUniform()
13,800 bytes in 69 blocks are indirectly lost
2020-08-22 17:36:43 -05:00
Scott Giese bcb22691fc REVIEW: Memory Leak - SGTexturedTriangleBin::buildGeometry()
42,560 bytes in 280 blocks are definitely lost
2020-08-22 17:10:43 -05:00
Scott Giese 34ca004e95 REVIEW: Memory Leak - SGMaterial::read_properties()
61,560 bytes in 405 blocks are definitely lost
2020-08-22 16:57:21 -05:00
Scott Giese 53487ae732 // REVIEW: Memory Leak - HTTPRepository copy-ctor
93,275 bytes in 2,275 blocks are indirectly lost
2020-08-22 16:16:38 -05:00
Scott Giese 685866ffa7 // REVIEW: Memory Leak - nasal newBlock()
113,376 bytes in 1 blocks are still reachable
2020-08-22 16:11:52 -05:00
Scott Giese e3ce59ee80 REVIEW: Memory Leak - Effect::buildAttribute()
144,400 bytes in 38 blocks are indirectly lost
2020-08-22 16:08:58 -05:00
Scott Giese ce019a169b REVIEW: Memory Leak - EffectBuilder::InitFromParameters()
156,910 (2,320 direct, 154,590 indirect) bytes in 29 blocks are definitely lost
2020-08-22 15:53:25 -05:00
Scott Giese 03a76a1805 REVIEW: Memory Leak - hash::resize()
196,628 bytes in 1 blocks are still reachable
2020-08-22 15:40:07 -05:00
Scott Giese 8f76c2b401 REVIEW: Memory Leak - SGPath::append()
212,955 bytes in 2,277 blocks are indirectly lost
2020-08-22 15:28:37 -05:00
Scott Giese 39b83cdb51 REVIEW: Memory Leak - ModelRegistry
262,144 bytes in 1 blocks are indirectly lost
2020-08-22 15:09:46 -05:00
Scott Giese 10ffa82ea6 REVIEW: Memory Leak - ChildInfo copy-ctor
447,264 bytes in 39 blocks are indirectly lost
2020-08-22 14:59:27 -05:00
Scott Giese 38e38bf3d3 CMake Fix: FindGDAL
FindPackageHandleStandardArgs.cmake  is not located within simgear/CMakeModules.
Use the normal CMake folder.
2020-08-22 14:45:13 -05:00
Scott Giese 995a176654 REVIEW: unique HTTPRepository is encapsulated within HTTPDirectory object. 2020-08-17 20:02:45 -05:00
Scott Giese a8c13cf041 REVIEW: Memory Leak - HTTPDirectory
885,598 (3,072 direct, 882,526 indirect) bytes in 48 blocks are definitely lost.
Candidate for shared_ptr or destruction within parent's dtor.
2020-08-17 19:35:06 -05:00
Scott Giese d79ecddaf9 REVIEW: Memory Leak - NASAL GC
1,032,712 bytes in 6 blocks are still reachable.
naFree(p->free0) is required during shutdown.
2020-08-17 19:11:01 -05:00
Scott Giese e5bbd62e96 Merge branch 'next' of https://git.code.sf.net/p/flightgear/simgear into next 2020-08-17 19:04:00 -05:00
Scott Giese 5fdcd72de9 REVIEW: Memory Leak - NASAL
2,048,000 bytes in 1 blocks are still reachable.
naFree(globals->deadBlocks) is required during shutdown.
2020-08-17 19:03:20 -05:00
Scott Giese a93629a127 Revert "Memory Leak: 95 MB"
This reverts commit cb54815cfc.
2020-08-09 09:39:04 -05:00
Scott Giese cb54815cfc Memory Leak: 95 MB
99,418,032 bytes in 654,066 blocks are still reachable in loss record 15,500 of 15,501
2020-08-08 20:34:59 -05:00
Scott Giese f76c640b69 Memory Leak: fix low-hanging fruit 2020-08-08 00:23:39 -05:00
Scott Giese 084e2502ab Memory Leak: 4.3 MB
4,518,880 bytes in 141,215 blocks are still reachable in loss record 15,491 of 15,501
2020-08-06 22:15:43 -05:00
Scott Giese da384d6f49 Logic error fix 2020-08-06 18:50:31 -05:00
Scott Giese a3ffc77a9d Bug fix: Check for a valid effect before dereference
Reported on the dev list as...
Crash with custom scenery
2020-07-03 13:23:23 -05:00
Scott Giese 6d8e9e5bbc VPB: Initial commit
Not for LTS
2020-06-28 11:30:33 -05:00
Scott Giese c5c10a003a Rollback error until stability issues are resolved. 2019-12-31 10:29:25 -06:00
Scott Giese 67e2860cc3 Disable NasalMainLoopRecipient
This is preventing FGFS shutdown on Linux OS.
Does not appear that this thread is properly joined and terminated.
2019-12-27 20:48:02 -06:00
Scott Giese fb57fe9da7 Catching an exception by value 2019-12-15 03:12:54 -06:00
Scott Giese 02496da4d2 Logic error 2019-12-15 03:08:06 -06:00
Scott Giese eb1afec22b Remove unused object creation 2019-12-15 02:39:43 -06:00
Scott Giese 1619df97f8 Potential unterminated string 2019-12-15 02:19:13 -06:00
Scott Giese c653a82619 Eliminate unitialized warning 2019-12-15 02:00:16 -06:00
Scott Giese 2289618cea Fix conditional compile logic 2019-12-15 00:18:39 -06:00
Scott Giese dc886118ba [CanvasText] Fix conditional compiles 2019-12-15 00:13:46 -06:00
Scott Giese 879b01004b [CanvasText] Fix conditional compiles 2019-12-14 23:31:13 -06:00
Scott Giese b742607c76 [ReaderWriteSTG] fix for missing header. 2019-10-03 11:50:07 -05:00
Scott Giese 202dfc9ebe Merge branch 'next' of https://git.code.sf.net/p/flightgear/simgear into next 2019-09-17 12:51:47 -05:00
Scott Giese 23f378cd93 Support VS 2019 - courtesy of Lars Toenning 2019-09-17 12:51:05 -05:00
Scott Giese 70c564dd2c Fix compile issue on Win10 VS2019 2019-09-16 23:30:59 -05:00
Scott Giese b28f030874 [CanvasText] Restore support for OSG 3.4 2019-08-04 10:43:00 -05:00
Scott Giese d883ab278d [osgText.getActiveFont] Breaking change within OSG 2019-08-04 02:27:57 -05:00
Scott Giese d8a46cffa5 [emesary] Fix naming conflict with some compilers 2019-06-15 17:22:53 -05:00
Scott Giese 3b3093c72e [nasal] remediate segfault in lib.c
state of vaCopy is altered during each usage, so it needs to be discarded and not reused by multiple calls.
2019-06-15 11:54:35 -05:00
Scott Giese 3d841a214c Merge branch 'next' of https://git.code.sf.net/p/flightgear/simgear into next 2019-06-14 22:12:02 -05:00
Scott Giese 2cbbb29eb5 [Emesary] Fix compile on Linux. 2019-06-14 22:11:31 -05:00
Scott Giese c0677ad8c5 [Emesary] Fix compile on Linux. 2019-06-14 21:43:47 -05:00
Scott Giese 14971f88ee [soundmgr_openal] Pause/Resume Sound.
The following changes fixes a case for me where I hear the sound change levels up and down for each pause un-pause cycle.
Patch provided by daniel.c.wickstrom@gmail.com.
2019-05-09 20:52:20 -05:00
Scott Giese 1a429b63c5 [SGImageUtils] eliminate unused variable. 2019-05-04 15:45:53 -05:00
Scott Giese ae6ad20940 [SGDemSession] fix uninitialized members. 2019-05-04 15:26:25 -05:00
Scott Giese fdcc9c9e0e Fix compile issue with OSG versions below 3.4 2019-03-05 23:56:47 -06:00
Scott Giese 2303da846b Fix missing header for OSG macros.
Patch provided by Stewart Andreason.
2019-02-05 21:46:02 -06:00